Re: [PATCH 1/3] api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE

2021-02-15 Thread Pavel Hrdina
On Mon, Feb 15, 2021 at 06:27:49PM +0100, Peter Krempa wrote: > The flag creates additional points of failure which are hard to recover > from, such as when thawing of the filesystems fails after an otherwise > successful snapshot. > > Encougage use of explicit virDomainFSFreeze/virDomainFSThaw.

[PATCH 1/3] api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE

2021-02-15 Thread Peter Krempa
The flag creates additional points of failure which are hard to recover from, such as when thawing of the filesystems fails after an otherwise successful snapshot. Encougage use of explicit virDomainFSFreeze/virDomainFSThaw. Signed-off-by: Peter Krempa --- src/libvirt-domain-snapshot.c | 3 +++