Re: [PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2

2021-02-16 Thread Pavel Hrdina
On Tue, Feb 16, 2021 at 09:46:42AM +0100, Peter Krempa wrote: > On Mon, Feb 15, 2021 at 19:20:25 +0100, Pavel Hrdina wrote: > > On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote: > > > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it > > > doesn't necessarily mean that

Re: [PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2

2021-02-16 Thread Peter Krempa
On Mon, Feb 15, 2021 at 19:20:25 +0100, Pavel Hrdina wrote: > On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote: > > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it > > doesn't necessarily mean that the command was sent to the agent. > > > > Since callers don't care

Re: [PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2

2021-02-15 Thread Pavel Hrdina
On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote: > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it > doesn't necessarily mean that the command was sent to the agent. > > Since callers don't care about the -2 value specifically, remove it. In addition this

[PATCH 3/3] qemuSnapshotFSFreeze: Don't return -2

2021-02-15 Thread Peter Krempa
The -2 value is misleading because if 'qemuAgentFSFreeze' fails it doesn't necessarily mean that the command was sent to the agent. Since callers don't care about the -2 value specifically, remove it. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 5 + 1 file changed, 1