[libvirt] [PATCH 1/2] util: adding virHasLastError and virGetLastErrorCode/Domain

Many places in the code call virGetLastError() just to check the raised error code, or domain. However virGetLastError() can return NULL, so the code has to check for that as well. So Instead we create functions virGetLastErrorCode and virGetLastErrorDomain (in addition to the existing

[libvirt] [PATCH 2/2] all: replacing virGetLastError with virHas/GetLastErrorCode/Domain

Many places in the code call virGetLastError() just to check the raised error code, or domain. However virGetLastError() can return NULL, so the code has to check for that as well. So Instead we create functions virGetLastErrorCode and virGetLastErrorDomain (in addition to the existing

[libvirt] [PATCH 0/2] adding virHas/GetLastErrorCode/Domain to paritally replace virGetLastError

Many places in the code call virGetLastError() just to check the raised error code, or domain. However virGetLastError() can return NULL, so the code has to check for that as well. So Instead we create functions virGetLastErrorCode and virGetLastErrorDomain (in addition to the existing

Re: [libvirt] unix_sock_dir for virtlogd

Hi, thanks for your reply Martin, 2018-05-04 1:44 GMT+03:00 Martin Kletzander : > On Thu, May 03, 2018 at 11:03:48PM +0300, Mathieu Tarral wrote: >> >> Hi ! >> >> I'm trying to run libvirtd from git, and the daemon is starting now, >> but when i try to start a VM (using

[libvirt] [PATCH v3 4/6] qemu: Add VM Generation ID to qemu command line

https://bugzilla.redhat.com/show_bug.cgi?id=1149445 If the domain requests usage of the genid functionality, then add the QEMU '-device vmgenid' to the command line providing either the supplied or generated GUID value. Add tests for both a generated and supplied GUID value. Signed-off-by: John

[libvirt] [PATCH v3 6/6] docs: Add news article for VM Generation ID

Signed-off-by: John Ferlan --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 80181415c6..c8495e6035 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,19 @@ + + +

[libvirt] [PATCH v3 0/6] Add support for VM Generation ID (vmgenid)

v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2: * Essentially handle comments from code review of original series from comments received for patch 6: https://www.redhat.com/archives/libvir-list/2018-April/msg02240.html It's a somewhat

[libvirt] [PATCH v3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

Before we generate the command line for qemu, if the domain about to be launched desires to utilize the VM Generation ID functionality, then handle both the regenerating the GUID value for backup recovery (restore operation) and the startup after snapshot as both require a new GUID to be generated

[libvirt] [PATCH v3 1/6] conf: Add VM Generation ID parse/format support

The VM Generation ID is a mechanism to provide a unique 128-bit, cryptographically random, and integer value identifier known as the GUID (Globally Unique Identifier) to the guest OS. The value is used to help notify the guest operating system when the virtual machine is executed with a different

[libvirt] [PATCH v3 5/6] domcaps: Add 'genid' to domain capabilities

Report domaincaps if the guest config accepts or $GUID. Signed-off-by: John Ferlan --- docs/formatdomaincaps.html.in | 7 ++- docs/schemas/domaincaps.rng | 7 +++ src/conf/domain_capabilities.c

[libvirt] [PATCH v3 2/6] qemu: Add VM Generation ID device capability

Add the query of the device objects for the vmgenid device Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 +

Re: [libvirt] [PATCH] qemu: add sdl opengl support

On 05/01/2018 03:22 PM, Maciej Wolny wrote: > Add SDL graphics gl attribute, modify the domain XML schema, add a > test, modify the documentation to include the new option. > > Signed-off-by: Maciej Wolny > --- > docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition

On 05/03/2018 06:50 PM, Martin Kletzander wrote: > On Thu, May 03, 2018 at 05:35:10PM -0400, Cole Robinson wrote: >> Introduced in 8525b9694. Some files weren't updated. I'm just >> guessing on the bhyve ones >> >> Signed-off-by: Cole Robinson >> --- >> Pushes as a build

Re: [libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition

On Thu, May 03, 2018 at 05:35:10PM -0400, Cole Robinson wrote: Introduced in 8525b9694. Some files weren't updated. I'm just guessing on the bhyve ones Signed-off-by: Cole Robinson --- Pushes as a build breaker tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 +

Re: [libvirt] unix_sock_dir for virtlogd

On Thu, May 03, 2018 at 11:03:48PM +0300, Mathieu Tarral wrote: Hi ! I'm trying to run libvirtd from git, and the daemon is starting now, but when i try to start a VM (using virt-manager) it complains that virtlogd socket is unreachable. The problem is that it tries to reach it at the

[libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition

Introduced in 8525b9694. Some files weren't updated. I'm just guessing on the bhyve ones Signed-off-by: Cole Robinson --- Pushes as a build breaker tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 +

Re: [libvirt] [PATCH 3/3] domain_capabilities: Report support

On 04/27/2018 11:09 AM, John Ferlan wrote: > > > On 04/17/2018 02:40 PM, Cole Robinson wrote: >> Report domaincaps if the guest >> config accepts >> >> Signed-off-by: Cole Robinson >> --- >> This bucks the domaincapabilities trend of always having a child >> enum if

[libvirt] unix_sock_dir for virtlogd

Hi ! I'm trying to run libvirtd from git, and the daemon is starting now, but when i try to start a VM (using virt-manager) it complains that virtlogd socket is unreachable. The problem is that it tries to reach it at the following location: virNetSocketNewConnectUNIX:713 : Failed to connect

[libvirt] Expose vfio device display/migration to libvirt and above, was Re: [PATCH 0/3] sample: vfio mdev display devices.

Hi, The previous discussion hasn't produced results, so let's start over. Here's the situation: - We currently have kernel and QEMU support for the QEMU vfio-pci display option. - The default for this option is 'auto', so the device will attempt to generate a display if the underlying

Re: [libvirt] [PATCH v5 0/2] Avoid slash characteres for 'domrename' command.

Done, John! -- Julio Cesar Faracco 2018-05-03 12:27 GMT-03:00 John Ferlan : > > > On 05/01/2018 11:56 AM, Julio Faracco wrote: >> The commits enhace the 'domrename' command of QEMU and Test drivers to >> avoid slashes chars inside the new domain name. >> >> Julio Faracco (2):

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

On Thu, 2018-05-03 at 16:59 +0100, Daniel P. Berrangé wrote: > On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote: > > Renaming the scripts sounds good to me. Just come up with > > a reasonable name and I'll go ahead with another round of > > patches. > > Perhaps just call it

Re: [libvirt] [PATCH 6/6] conf: Clean up object referencing for Add and Remove

On 05/03/2018 12:00 PM, Erik Skultety wrote: > On Tue, Apr 24, 2018 at 08:28:09AM -0400, John Ferlan wrote: >> When adding a new object to the domain object list, there should >> have been 2 virObjectRef calls made one for each list into which >> the object was placed to match the 2

[libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

Up until now, we had to skip it on FreeBSD due to some portability issues in the test suite, but as of libvirt commit 0b86e23d2569 they've all been fixed. Signed-off-by: Andrea Bolognani --- projects/libvirt.yaml | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [libvirt] [PATCH 2/6] conf: Use virDomainObjListFindBy*Locked for virDomainObjListAdd

On 05/03/2018 12:02 PM, Erik Skultety wrote: > On Tue, Apr 24, 2018 at 08:28:05AM -0400, John Ferlan wrote: >> Use the FindBy{UUID|Name}Locked helpers which will return a locked >> and ref counted object rather than the direct virHashLookup and >> virObjectLock of the returned object. We'll need

Re: [libvirt] [PATCH 1/3] tests: delete most qemu-img test cases assuming FMT_OPTIONS

On 04/17/2018 05:43 PM, Ján Tomko wrote: > We have two leftover "capabilites" for qemu-img: > QEMU_IMG_BACKING_FORMAT_OPTIONS > QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT > > The former says we are able to specify the backing format via -o > (which has been the case for a long time now) and the

Re: [libvirt] [PATCH 08/14] nwfilter: pass vm name in when instantiating filters

On Mon, Apr 30, 2018 at 04:09:40PM +0200, Jiri Denemark wrote: > On Fri, Apr 27, 2018 at 16:25:07 +0100, Daniel P. Berrangé wrote: > > The vm name is not needed for any functional requirement, but it will be > > useful when debugging problems to identify which VM is associated with a > > filter,

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-03 at 16:46 +0100, Daniel P. Berrangé wrote: > > On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote: > > > The Test-AutoBuild project, that this script is supposed > > > to be used with, hasn't seen

[libvirt] [PATCH] configure: remove bogus LIBVIRT_GETTEXT macro reference

The LIBVIRT_GETTEXT macro was an artifact of patch development and was later renamed to LIBVIRT_CHECK_NLS. This cruft causes configure to print out ./configure: line 75084: LIBVIRT_GETTEXT: command not found but fortunately this is non-fatal Reported-by: Martin Kletzander

Re: [libvirt] [PATCH 3/3] storage: remove qemu-img help scraping

On 04/17/2018 05:43 PM, Ján Tomko wrote: > We have been checking whether qemu-img supports the -o compat > option by scraping the -help output. > > Since we require QEMU 1.5.0 now and this option was introduced in 1.1, > assume we support it and ditch the help parsing code along with the >

Re: [libvirt] [PATCH 2/6] conf: Use virDomainObjListFindBy*Locked for virDomainObjListAdd

On Tue, Apr 24, 2018 at 08:28:05AM -0400, John Ferlan wrote: > Use the FindBy{UUID|Name}Locked helpers which will return a locked > and ref counted object rather than the direct virHashLookup and > virObjectLock of the returned object. We'll need to temporarily > virObjectUnref when we assign a

Re: [libvirt] [PATCH 3/6] conf: Move and use virDomainObjListRemoveLocked

On Tue, Apr 24, 2018 at 08:28:06AM -0400, John Ferlan wrote: > Rather than open code within virDomainObjListRemove, just call > the *Locked function. > > Additionally, add comments to virDomainObjListRemove to describe > the usage model. > > Signed-off-by: John Ferlan > ---

Re: [libvirt] [PATCH 2/3] tests: assume FMT_COMPAT for qemu-img tests

On 04/17/2018 05:43 PM, Ján Tomko wrote: > No point in testing outdated command lines. > > Signed-off-by: Ján Tomko > --- > .../qcow2-nocapacity-convert-prealloc.argv | 2 +- > tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- >

Re: [libvirt] [PATCH 6/6] conf: Clean up object referencing for Add and Remove

On Tue, Apr 24, 2018 at 08:28:09AM -0400, John Ferlan wrote: > When adding a new object to the domain object list, there should > have been 2 virObjectRef calls made one for each list into which > the object was placed to match the 2 virObjectUnref calls that > would occur during Remove as part of

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

On Thu, 2018-05-03 at 16:46 +0100, Daniel P. Berrangé wrote: > On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote: > > The Test-AutoBuild project, that this script is supposed > > to be used with, hasn't seen any activity in ~7 years; > > these days, libvirt-sandbox CI builds are

Re: [libvirt] [python PATCH] maint: Drop autobuild.sh

On Thu, May 03, 2018 at 05:42:40PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, libvirt-python CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt

Re: [libvirt] [PATCH v3 0/3] Support tpm-crb TPM interface for QEMU

On 05/03/2018 11:35 AM, John Ferlan wrote: On 04/26/2018 01:42 PM, Stefan Berger wrote: This patch series adds support for the recently added tpm-crb TPM interface for QEMU (2.12). Stefan Stefan Berger (3): tpm: Enable TPM CRB interface in the domain XML and test it qemu: Extend the

Re: [libvirt] [tck PATCH] maint: Drop autobuild.sh

On Thu, May 03, 2018 at 05:42:27PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, libvirt-tck CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt >

Re: [libvirt] [perl PATCH] maint: Drop autobuild.sh

On Thu, May 03, 2018 at 05:42:58PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, libvirt-perl CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt >

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

On Thu, May 03, 2018 at 05:42:50PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, libvirt-sandbox CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt

Re: [libvirt] [PATCH 09/14] nwfilter: convert the gentech driver code to use virNWFilterBinding

On Thu, May 03, 2018 at 02:57:04PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 05:05:40PM +0200, Jiri Denemark wrote: > > On Fri, Apr 27, 2018 at 16:25:08 +0100, Daniel P. Berrangé wrote: > > > Use the virNWFilterBinding struct in the gentech driver code > > > directly. > > > > > >

[libvirt] [perl PATCH] maint: Drop autobuild.sh

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-perl CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1]

[libvirt] [python PATCH] maint: Drop autobuild.sh

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-python CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1]

[libvirt] [sandbox PATCH] maint: Drop autobuild.sh

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1]

[libvirt] [tck PATCH] maint: Drop autobuild.sh

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-tck CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1]

Re: [libvirt] [PATCH v3 5/9] syntax-check: Prohibit canonicalize_file_name()

On Thu, May 03, 2018 at 12:54:19PM +0200, Andrea Bolognani wrote: > We want to make sure our wrapper is used instead in order > to keep the test suite working. > > Signed-off-by: Andrea Bolognani > --- > cfg.mk | 10 ++ > src/util/virfile.c | 2 +- > 2

Re: [libvirt] [PATCH v3 7/9] tests: Build virpcimock on non-Linux

On Thu, May 03, 2018 at 02:28:48PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-03 at 12:54 +0200, Andrea Bolognani wrote: > > There are only a couple issues preventing it from working on > > other platform such as FreeBSD. Let's fix them. > > > > With the mocking in place, qemumemlocktest

Re: [libvirt] [jenkins-ci PATCH 0/4] Introduce Fedora 28; drop Fedora 26

On Thu, May 03, 2018 at 02:41:37PM +0200, Andrea Bolognani wrote: > It's that time of the year again :) > > Andrea Bolognani (4): > guests: Add libvirt-fedora-28 > projects: Add libvirt-fedora-28 > projects: Remove libvirt-fedora-26 > guests: Remove libvirt-fedora-26 > >

Re: [libvirt] [PATCH v3 4/9] tests: Stop mocking canonicalize_file_name()

On Thu, May 03, 2018 at 12:54:18PM +0200, Andrea Bolognani wrote: > We're using virFileCanonicalizePath() everywhere now, so > mocking this function has become entirely pointless. > > Signed-off-by: Andrea Bolognani > --- > tests/virpcimock.c | 21 - > 1

Re: [libvirt] [PATCH v3 9/9] tests: Drop DO_TEST_LINUX()

On Thu, May 03, 2018 at 12:54:23PM +0200, Andrea Bolognani wrote: > Now that mocking NUMA information works on FreeBSD, there are > no longer any test cases that need to be restricted to Linux > only. > > Signed-off-by: Andrea Bolognani > --- > tests/qemuxml2argvtest.c | 46

Re: [libvirt] [PATCH v3 7/9] tests: Build virpcimock on non-Linux

On Thu, May 03, 2018 at 12:54:21PM +0200, Andrea Bolognani wrote: > There are only a couple issues preventing it from working on > other platform such as FreeBSD. Let's fix them. > > With the mocking in place, qemumemlocktest and qemuxml2xmltest > can finally succeed on FreeBSD. > > This commit

Re: [libvirt] [PATCH v3 3/9] all: Use virFileCanonicalizePath() instead of canonicalize_file_name()

On Thu, May 03, 2018 at 12:54:17PM +0200, Andrea Bolognani wrote: > The latter is impossible to mock on platforms that use the > gnulib implementation, such as FreeBSD, while the former > doesn't suffer from this limitation. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] ZFS backend does fail if used on non top level pools

On Wed, May 02, 2018 at 09:36:10AM +0200, Christian Ehrhardt wrote: > Hi, > by discussing on bug [1] we found an issue in the ZFS storage backend. > When one defines a zfs pool through XML (virsh pool-create --build) a top > level ZFS pool will be created and works fine. The virsh pool-define-as >

Re: [libvirt] [PATCH v3 0/3] Support tpm-crb TPM interface for QEMU

On 04/26/2018 01:42 PM, Stefan Berger wrote: > This patch series adds support for the recently added tpm-crb TPM > interface for QEMU (2.12). > > Stefan > > Stefan Berger (3): > tpm: Enable TPM CRB interface in the domain XML and test it > qemu: Extend the capabilities with tpm-crb

Re: [libvirt] [PATCH v3 8/9] tests: Extend NUMA mocking

On Thu, May 03, 2018 at 12:54:22PM +0200, Andrea Bolognani wrote: > While the current amount of mocking works just fine on most of > our target platforms, it somehow causes issues when using Clang > on FreeBSD. > > Work around the issue by mocking a couple more functions. It's > not pretty, but

Re: [libvirt] [PATCH v3 1/9] util: Introduce virFileCanonicalizePath()

On Thu, May 03, 2018 at 12:54:15PM +0200, Andrea Bolognani wrote: > It's a trivial wrapper around canonicalize_file_name(), > which we need in order to fully mock file access on non-Linux > platforms. > > Signed-off-by: Andrea Bolognani > --- > src/libvirt_private.syms | 1

Re: [libvirt] [PATCH v3 2/9] tests: Mock virFileCanonicalizePath()

On Thu, May 03, 2018 at 12:54:16PM +0200, Andrea Bolognani wrote: > We're going to need this later on. > > Signed-off-by: Andrea Bolognani > --- > tests/virpcimock.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Daniel P. Berrangé

Re: [libvirt] [PATCH v3 6/9] tests: Fix mode_t usage with va_arg()

On Thu, May 03, 2018 at 12:54:20PM +0200, Andrea Bolognani wrote: > Clang complains about it: > > error: second argument to 'va_arg' is of promotable type > 'mode_t' (aka 'unsigned short'); this va_arg has undefined > behavior because arguments will be promoted to 'int' >

Re: [libvirt] [PATCH v5 0/2] Avoid slash characteres for 'domrename' command.

On 05/01/2018 11:56 AM, Julio Faracco wrote: > The commits enhace the 'domrename' command of QEMU and Test drivers to > avoid slashes chars inside the new domain name. > > Julio Faracco (2): > qemu: avoid slash characters to the new domain name. > test: avoid slash characters to the new

[libvirt] [PATCH] storagefile: conditional build of virStorageFileLoadBackendModule

The virStorageFileLoadBackendModule method is only used if either fs or gluster storage is built in, which doesn't happen on mingw leading to warning of an unused static function. Signed-off-by: Daniel P. Berrangé --- Pushed as mingw build fix

Re: [libvirt] [dbus RFC PATCH 0/6] Remove all enum->string and string->enum code

On Thu, 2018-05-03 at 10:45 +0200, Katerina Koukiou wrote: > As mentioned in the patches commit message... > > Converting ENUMS to str can be user friendly though > it can be problematic between libvirt versions. > > In particular when some translated type will introduce a > new constant to the

Re: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration

On Thu, May 03, 2018 at 09:02:35AM -0400, John Ferlan wrote: > > > On 05/03/2018 08:34 AM, Erik Skultety wrote: > > On Tue, Apr 24, 2018 at 08:28:08AM -0400, John Ferlan wrote: > >> Since the @dconn reference via args->conn will be used via a thread > >> or callback, let's make sure memory

Re: [libvirt] [Qemu-devel] [qemu RFC v3 3/3] qapi: add "firmware.json"

Ping: On 04/21/18 01:12, Laszlo Ersek wrote: > Add a schema that describes the different uses and properties of virtual > machine firmware. > > Each firmware executable installed on a host system should come with at > least one JSON file that conforms to this schema. Each file informs the >

Re: [libvirt] [PATCH 09/14] nwfilter: convert the gentech driver code to use virNWFilterBinding

On Mon, Apr 30, 2018 at 05:05:40PM +0200, Jiri Denemark wrote: > On Fri, Apr 27, 2018 at 16:25:08 +0100, Daniel P. Berrangé wrote: > > Use the virNWFilterBinding struct in the gentech driver code > > directly. > > > > Signed-off-by: Daniel P. Berrangé > > --- > >

Re: [libvirt] [PATCH 04/14] nwfilter: make virNWFilterIPAddrLearnReq type private

On Mon, Apr 30, 2018 at 03:30:35PM +0200, Erik Skultety wrote: > On Fri, Apr 27, 2018 at 04:25:03PM +0100, Daniel P. Berrangé wrote: > > The virNWFilterIPAddrLearnReq type should only be used by the IP address > > learning code, so can live in the implementation file instead of header > > file. >

[libvirt] [PATCH] tests: unlink libxl-driver.log

The libxlxml2domconfigtest causes a libxl-driver.log file to be created which breaks make distchck if libxl is enabled. Delete the log file at the end of the test. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for make distcheck

Re: [libvirt] [dbus PATCH v2 6/9] Implement NodeGetSecurityModel method for Domain Interface

On Wed, May 02, 2018 at 12:34:43PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 23 +++ > 2 files changed, 28 insertions(+) Reviewed-by: Pavel Hrdina

Re: [libvirt] [dbus PATCH 3/4] Annotate properties for which we will not emit changed signal

On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote: > For some of these properties there is no libvirt event to detect the > change and for properties where we could somehow detect the change > let's annotate them as well. > > We could change the properties to methods but with the annotation

Re: [libvirt] [dbus PATCH v2 9/9] Implement NodeGetCPUMap method for Connect Interface

On Wed, May 02, 2018 at 12:34:46PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 35 +++ > tests/test_connect.py| 4 > 3 files

Re: [libvirt] [dbus PATCH v2 8/9] Implement NodeSuspendForDuration method for Connect Interface

On Wed, May 02, 2018 at 12:34:45PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 8 > src/connect.c| 42 ++ > 2 files changed, 50 insertions(+) > >

Re: [libvirt] [dbus PATCH v2 4/9] Implement NodeGetMemoryParameters method in Connect Interface

On Wed, May 02, 2018 at 12:34:41PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 38 ++ > 2 files changed, 44 insertions(+) > > diff

Re: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration

On 05/03/2018 08:34 AM, Erik Skultety wrote: > On Tue, Apr 24, 2018 at 08:28:08AM -0400, John Ferlan wrote: >> Since the @dconn reference via args->conn will be used via a thread >> or callback, let's make sure memory associated with it isn't free'd >> unexpectedly before we use it. The Unref

Re: [libvirt] [dbus PATCH v2 7/9] Implement NodeSetMemoryParameters method for Connect Interface

On Wed, May 02, 2018 at 12:34:44PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 31 +++ > 2 files changed, 37 insertions(+) Reviewed-by: Pavel

Re: [libvirt] [dbus PATCH v2 5/9] Implement NodeGetMemoryStats method for Connect Interface

On Wed, May 02, 2018 at 12:34:42PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 44 > > 2 files changed, 50 insertions(+) > >

Re: [libvirt] [dbus PATCH 4/4] Annotate properties that will never change during the object lifecycle

On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote: > These can be annotated as 'const' properties because they will never > change. > > Signed-off-by: Pavel Hrdina > --- > > data/org.libvirt.Connect.xml | 2 ++ > data/org.libvirt.Domain.xml | 1 + >

Re: [libvirt] [dbus PATCH 1/4] configure: Bump required libvirt version

On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote: > We will implement all libvirt APIs up to libvirt 3.0.0 version for > now. > > Signed-off-by: Pavel Hrdina > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Katerina Koukiou

Re: [libvirt] [dbus PATCH v2 2/9] Implement NodeGetFreeMemory method for Connect Interface

On Wed, May 02, 2018 at 12:34:39PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 24 > tests/test_connect.py| 4 > 3 files changed, 33

Re: [libvirt] [dbus PATCH v2 1/9] Implement NodeGetCPUStats method for Connect Interface

On Wed, May 02, 2018 at 12:34:38PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 7 +++ > src/connect.c| 41 + > tests/test_connect.py| 4 > 3

Re: [libvirt] [dbus PATCH v2 3/9] Implement NodeGetInfo method for Connect Interface

On Wed, May 02, 2018 at 12:34:40PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 25 + > tests/test_connect.py| 4 > 3 files changed, 34

Re: [libvirt] [PATCH 1/5] po: provide custom make rules for po file management

On Thu, May 03, 2018 at 02:19:27PM +0200, Martin Kletzander wrote: > On Thu, Apr 12, 2018 at 02:28:18PM +0100, Daniel P. Berrangé wrote: > > Historically we have relied on autopoint/gettextize to install a > > standard po/Makefile.in.in. There is very limited scope for customizing > > this and it

Re: [libvirt] [dbus PATCH 2/4] Revert "Implement BridgeName property for Network interface."

On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote: > This reverts commit 5b28d8f778d6c5b7ebd64909882b19d70cdc098f. > > This API is broken by design since you cannot specify whether it > returns bridge name from persistent or active XML definition. > > Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH 1/6] conf: Split FindBy{UUID|Name} into locked helpers

On 05/03/2018 06:38 AM, Erik Skultety wrote: > On Tue, Apr 24, 2018 at 08:28:04AM -0400, John Ferlan wrote: >> Create helpers virDomainObjListFindByUUIDLocked and >> virDomainObjListFindByNameLocked to avoid the need >> to lock the domain object list leaving that task >> for the caller. >> >>

[libvirt] [dbus PATCH 2/4] Revert "Implement BridgeName property for Network interface."

This reverts commit 5b28d8f778d6c5b7ebd64909882b19d70cdc098f. This API is broken by design since you cannot specify whether it returns bridge name from persistent or active XML definition. Signed-off-by: Pavel Hrdina --- data/org.libvirt.Network.xml | 4 src/network.c

[libvirt] [dbus PATCH 1/4] configure: Bump required libvirt version

We will implement all libvirt APIs up to libvirt 3.0.0 version for now. Signed-off-by: Pavel Hrdina --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6f166f2..cc8947c 100644 --- a/configure.ac +++

[libvirt] [jenkins-ci PATCH 5/4] guests: Update vault

libvirt-fedora-28 has been added and libvirt-fedora-26 has been removed: update the vault accordingly. Signed-off-by: Andrea Bolognani --- Forgot to do this when sending the series. guests/vars/vault.yml | 90 +-- 1 file

[libvirt] [dbus PATCH 0/4] various fixes

Pavel Hrdina (4): configure: Bump required libvirt version Revert "Implement BridgeName property for Network interface." Annotate properties for which we will not emit changed signal Annotate properties that will never change during the object lifecycle configure.ac | 2

[libvirt] [dbus PATCH 3/4] Annotate properties for which we will not emit changed signal

For some of these properties there is no libvirt event to detect the change and for properties where we could somehow detect the change let's annotate them as well. We could change the properties to methods but with the annotation we can keep them as properties in order to allow to get them by

[libvirt] [dbus PATCH 4/4] Annotate properties that will never change during the object lifecycle

These can be annotated as 'const' properties because they will never change. Signed-off-by: Pavel Hrdina --- data/org.libvirt.Connect.xml | 2 ++ data/org.libvirt.Domain.xml | 1 + data/org.libvirt.Network.xml | 2 ++ 3 files changed, 5 insertions(+) diff --git

[libvirt] [jenkins-ci PATCH 1/4] guests: Add libvirt-fedora-28

Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-fedora-28/install.yml | 3 +++ guests/host_vars/libvirt-fedora-28/main.yml| 20 guests/inventory | 1 + 3 files changed, 24 insertions(+) create mode 100644

[libvirt] [jenkins-ci PATCH 4/4] guests: Remove libvirt-fedora-26

Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-fedora-26/install.yml | 3 --- guests/host_vars/libvirt-fedora-26/main.yml| 20 guests/inventory | 1 - 3 files changed, 24 deletions(-) delete mode 100644

[libvirt] [jenkins-ci PATCH 3/4] projects: Remove libvirt-fedora-26

Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml| 2 -- projects/libvirt-dbus.yaml| 2 -- projects/libvirt-sandbox.yaml | 2 -- projects/libvirt-tck.yaml | 2 -- projects/libvirt.yaml | 2 -- projects/virt-manager.yaml| 3 --- 6 files

[libvirt] [jenkins-ci PATCH 2/4] projects: Add libvirt-fedora-28

Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml| 2 ++ projects/libvirt-dbus.yaml| 2 ++ projects/libvirt-sandbox.yaml | 2 ++ projects/libvirt-tck.yaml | 2 ++ projects/libvirt.yaml | 2 ++ projects/virt-manager.yaml| 3 +++ 6 files

[libvirt] [jenkins-ci PATCH 0/4] Introduce Fedora 28; drop Fedora 26

It's that time of the year again :) Andrea Bolognani (4): guests: Add libvirt-fedora-28 projects: Add libvirt-fedora-28 projects: Remove libvirt-fedora-26 guests: Remove libvirt-fedora-26 .../host_vars/{libvirt-fedora-26 => libvirt-fedora-28}/install.yml | 2 +-

Re: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration

On Tue, Apr 24, 2018 at 08:28:08AM -0400, John Ferlan wrote: > Since the @dconn reference via args->conn will be used via a thread > or callback, let's make sure memory associated with it isn't free'd > unexpectedly before we use it. The Unref will be done when the object > is Dispose'd. > >

Re: [libvirt] [PATCH v3 7/9] tests: Build virpcimock on non-Linux

On Thu, 2018-05-03 at 12:54 +0200, Andrea Bolognani wrote: > There are only a couple issues preventing it from working on > other platform such as FreeBSD. Let's fix them. > > With the mocking in place, qemumemlocktest and qemuxml2xmltest > can finally succeed on FreeBSD. Too bad it also happens

Re: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration

On Tue, Apr 24, 2018 at 08:28:08AM -0400, John Ferlan wrote: > Since the @dconn reference via args->conn will be used via a thread > or callback, let's make sure memory associated with it isn't free'd > unexpectedly before we use it. The Unref will be done when the object > is Dispose'd. > >

Re: [libvirt] [PATCH 1/5] po: provide custom make rules for po file management

On Thu, Apr 12, 2018 at 02:28:18PM +0100, Daniel P. Berrangé wrote: Historically we have relied on autopoint/gettextize to install a standard po/Makefile.in.in. There is very limited scope for customizing this and it also causes a bunch of extra stuff to be pulled into configure.ac which

Re: [libvirt] [PATCH 5/6] util: refactor storage file checks to allow error reporting

On Thu, Apr 26, 2018 at 11:15:42AM +0200, Peter Krempa wrote: > On Wed, Apr 25, 2018 at 16:52:42 +0100, Daniel Berrange wrote: > > The virStorageFileSupportsSecurityDriver and > > virStorageFileSupportsAccess currently just return a boolean > > value. This is ok because they don't have any failure

Re: [libvirt] [PATCH 3/6] storage: split fs storage file code from storage driver backend

On Thu, Apr 26, 2018 at 09:48:21AM +0200, Peter Krempa wrote: > On Wed, Apr 25, 2018 at 16:52:40 +0100, Daniel Berrange wrote: > > The storage file code needs to be run in the hypervisor drivers, while > > the storage backend code needs to be run in the storage driver. Split > > the source code as

Re: [libvirt] [PATCH 4/6] storage: fix virStorageFileGetBackingStoreStr error handling

On Thu, Apr 26, 2018 at 09:56:16AM +0200, Peter Krempa wrote: > On Wed, Apr 25, 2018 at 16:52:41 +0100, Daniel Berrange wrote: > > The virStorageFileGetBackingStoreStr method has overloaded the NULL > > return value to indicate both no backing available and a fatal > > error dealing with it. > >

Re: [libvirt] [PATCH 2/6] storage: split gluster storage file code from storage driver backend

On Thu, Apr 26, 2018 at 09:39:44AM +0200, Peter Krempa wrote: > On Wed, Apr 25, 2018 at 16:52:39 +0100, Daniel Berrange wrote: > > The storage file code needs to be run in the hypervisor drivers, while > > the storage backend code needs to be run in the storage driver. Split > > the source code as

  1   2   >