On Sat, Feb 13, 2021 at 08:36:29AM +0200, Ville Skyttä wrote:
> Signed-off-by: Ville Skyttä
> ---
> docs/tlscerts.html.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/tlscerts.html.in b/docs/tlscerts.html.in
> index 8a74311682..22fc054801 100644
> ---
On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote:
> The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
> doesn't necessarily mean that the command was sent to the agent.
>
> Since callers don't care about the -2 value specifically, remove it.
In addition this
On Mon, Feb 15, 2021 at 06:27:50PM +0100, Peter Krempa wrote:
> If we didn't freeze any filesystems we should not even attempt thawing
> them. Additionally 'guest-fsfreeze-freeze' fails if the filesystems are
> already frozen, where thawing them may break users data integrity if
> they used
On 2/15/21 2:21 PM, Pavel Hrdina wrote:
Fixes: 184245f53b94fc84f727eb6e8a2aa52df02d69c0
Signed-off-by: Pavel Hrdina
---
Reviewed-by: Daniel Henrique Barboza
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c
On 2/15/21 2:59 PM, Michal Privoznik wrote:
In one of my previous commits I've made an attempt to restore the
noqueue qdisc on a TAP corresponding to domain's if
QoS is cleared out. The commit consisted of two almost identical
hunks. In both the pointer is dereferenced. But in one of them,
On Mon, Feb 15, 2021 at 06:27:49PM +0100, Peter Krempa wrote:
> The flag creates additional points of failure which are hard to recover
> from, such as when thawing of the filesystems fails after an otherwise
> successful snapshot.
>
> Encougage use of explicit virDomainFSFreeze/virDomainFSThaw.
In one of my previous commits I've made an attempt to restore the
noqueue qdisc on a TAP corresponding to domain's if
QoS is cleared out. The commit consisted of two almost identical
hunks. In both the pointer is dereferenced. But in one of them,
the pointer to new bandwidth can't be NULL while
On 2/15/21 6:00 PM, Ján Tomko wrote:
On a Monday in 2021, Michal Privoznik wrote:
When qemuDomainGetFSInfo() is called it calls
qemuDomainGetFSInfoAgent() which executes 'guest-get-fsinfo'
guest agent command, parses returned JSON and returns an array of
qemuAgentFSInfo structures (well,
The flag creates additional points of failure which are hard to recover
from, such as when thawing of the filesystems fails after an otherwise
successful snapshot.
Encougage use of explicit virDomainFSFreeze/virDomainFSThaw.
Signed-off-by: Peter Krempa
---
src/libvirt-domain-snapshot.c | 3 +++
The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
doesn't necessarily mean that the command was sent to the agent.
Since callers don't care about the -2 value specifically, remove it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 5 +
1 file changed, 1
If we didn't freeze any filesystems we should not even attempt thawing
them. Additionally 'guest-fsfreeze-freeze' fails if the filesystems are
already frozen, where thawing them may break users data integrity if
they used VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE accidentally after an
explicit
Peter Krempa (3):
api: Discourage use of VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
qemuSnapshotCreateActiveExternal: Don't thaw filesystems when freeze
fails
qemuSnapshotFSFreeze: Don't return -2
src/libvirt-domain-snapshot.c | 3 +++
src/qemu/qemu_snapshot.c | 33
Fixes: 184245f53b94fc84f727eb6e8a2aa52df02d69c0
Signed-off-by: Pavel Hrdina
---
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 57e18d6f38..abc06b8cb0 100644
--- a/src/util/vircgroup.c
+++
On Wed, Feb 03, 2021 at 11:38:49AM -0600, Jonathon Jongsma wrote:
> This function will parse the list of mediated devices that are returned
> by mdevctl and convert it into our internal node device representation.
>
> Signed-off-by: Jonathon Jongsma
> ---
> src/node_device/node_device_driver.c
On Wed, Feb 03, 2021 at 11:38:47AM -0600, Jonathon Jongsma wrote:
> Add two flag values for virConnectListAllNodeDevices() so that we can
> list only node devices that are active or inactive.
>
> Signed-off-by: Jonathon Jongsma
> Reviewed-by: Erik Skultety
> ---
>
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/256476242
Andrea Bolognani (2):
ci: Update package list on Cirrus CI
ci: Build on macOS 11 instead of macOS 10.15
.gitlab-ci.yml | 10 +++---
ci/cirrus/build.yml | 1 +
macOS builder capacity on Cirrus CI is quite limited, and so we
can't afford to keep the old build job around after adding the
new one like we do for FreeBSD.
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml | 6 +++---
ci/cirrus/{macos-1015.vars =>
While pkgng on FreeBSD updates the package list automatically
when it's run, homebrew on macOS doesn't do the same thing, which
can result in stale packages being installed. Explicitly call
'brew update' before 'brew install' to avoid that scenario.
Signed-off-by: Andrea Bolognani
---
On a Monday in 2021, Michal Privoznik wrote:
When virDomainGetFSInfo() is called over a QEMU/KVM domain it
results into calling of 'guest-get-fsinfo' guest agent command to
which it replies with info on guest (mounted) filesystems. When
filling return structure we also try to do basic lookup and
On a Monday in 2021, Michal Privoznik wrote:
When qemuDomainGetFSInfo() is called it calls
qemuDomainGetFSInfoAgent() which executes 'guest-get-fsinfo'
guest agent command, parses returned JSON and returns an array of
qemuAgentFSInfo structures (well, pointers to those structs).
Then it grabs a
On a Monday in 2021, Michal Privoznik wrote:
As the very first thing, this function checks whether the number
of items inside @agentinfo array is not negative. This is
redundant as the only caller - qemuDomainGetFSInfo() already
checked for that and would not even call this function if that
was
As the very first thing, this function checks whether the number
of items inside @agentinfo array is not negative. This is
redundant as the only caller - qemuDomainGetFSInfo() already
checked for that and would not even call this function if that
was the case.
Signed-off-by: Michal Privoznik
---
When virDomainGetFSInfo() is called over a QEMU/KVM domain it
results into calling of 'guest-get-fsinfo' guest agent command to
which it replies with info on guest (mounted) filesystems. When
filling return structure we also try to do basic lookup and
translate guest agent provided disk address
The most important patch is the last one, the other two are just
cleanups I wrote while looking around.
Michal Prívozník (3):
qemu: Drop needless check in virDomainFSInfoFormat()
qemu: Move qemuAgentFSInfo array free into qemuDomainGetFSInfo()
qemu: Don't lie about @ndevAlias when
When qemuDomainGetFSInfo() is called it calls
qemuDomainGetFSInfoAgent() which executes 'guest-get-fsinfo'
guest agent command, parses returned JSON and returns an array of
qemuAgentFSInfo structures (well, pointers to those structs).
Then it grabs a domain job and tries to do some matching of
Signed-off-by: Ville Skyttä
---
docs/tlscerts.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/tlscerts.html.in b/docs/tlscerts.html.in
index 8a74311682..22fc054801 100644
--- a/docs/tlscerts.html.in
+++ b/docs/tlscerts.html.in
@@ -125,7 +125,7 @@ of the server
Using locally built images is a useful feature; our commentaries even
mention overriding them may be useful in some scenarios. Expose the
variables in the help to let users know they can use the feature.
Formatting would definitely break, so this patch adds more spacing for
proper alignment.
In commit 321293e2 I dropped the prepare.sh script, but forgot to
remove the corresponding variable from the Makefile.
Signed-off-by: Erik Skultety
---
ci/Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ci/Makefile b/ci/Makefile
index 7bbff3e9aa..94a4bf62c7 100644
---
Erik Skultety (2):
ci: Drop the CI_PREPARE_SCRIPT variable
ci: Makefile: Expose CI_IMAGE_PREFIX and CI_IMAGE_TAG in 'ci-help'
ci/Makefile | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
--
2.29.2
On Mon, Feb 15, 2021 at 14:21:45 +0300, Aleksei Zakharov wrote:
> This patch adds delay time (steal time inside guest) to libvirt
> domain per-vcpu stats. Delay time is a consequence of the overloaded
> CPU. Knowledge of the delay time of a virtual machine helps to react
> exactly when needed and
This patch adds delay time (steal time inside guest) to libvirt
domain per-vcpu stats. Delay time is a consequence of the overloaded
CPU. Knowledge of the delay time of a virtual machine helps to react
exactly when needed and rebalance the load between hosts.
This is used by cloud providers to
Fixed an issue in v2:
Close schedstat file after use.
Fixes since v1:
Collect per-vcpu stats.
Coding style errors
Use glib functions.
Aleksei Zakharov (1):
qemu: add per-vcpu delay stats
src/qemu/qemu_driver.c | 40 +---
1 file changed, 37 insertions(+), 3
On Fri, 2021-02-12 at 16:40 +0100, Andrea Bolognani wrote:
> Various workarounds that are necessary due to breakages in external
> services and distribution archives, plus fixes for a couple of issues
> that were discovered in the process.
>
> Changes from [v1]:
>
> * the first three patches
On Fri, Feb 12, 2021 at 04:40:35PM +0100, Andrea Bolognani wrote:
> Various workarounds that are necessary due to breakages in external
> services and distribution archives, plus fixes for a couple of issues
> that were discovered in the process.
>
> Changes from [v1]:
>
> * the first three
On Mon, Feb 15, 2021 at 11:22:18 +0100, Andrea Bolognani wrote:
> On Mon, 2021-02-15 at 11:10 +0100, Peter Krempa wrote:
> > On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > > After the recent fixes, it's now confirmed to work.
> > >
> > >
On Mon, Feb 15, 2021 at 11:22:33AM +0100, Peter Krempa wrote:
> On Mon, Feb 15, 2021 at 11:19:12 +0100, Erik Skultety wrote:
> > On Mon, Feb 15, 2021 at 11:10:43AM +0100, Peter Krempa wrote:
> > > On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > > > After the recent fixes, it's
On Mon, Feb 15, 2021 at 11:22:18AM +0100, Andrea Bolognani wrote:
> On Mon, 2021-02-15 at 11:10 +0100, Peter Krempa wrote:
> > On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > > After the recent fixes, it's now confirmed to work.
> > >
> > >
On Mon, Feb 15, 2021 at 11:19:12 +0100, Erik Skultety wrote:
> On Mon, Feb 15, 2021 at 11:10:43AM +0100, Peter Krempa wrote:
> > On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > > After the recent fixes, it's now confirmed to work.
> > >
> > >
On Mon, 2021-02-15 at 11:10 +0100, Peter Krempa wrote:
> On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > After the recent fixes, it's now confirmed to work.
> >
> > https://gitlab.com/libvirt/libvirt/-/issues/121
>
> Should it be closed then?
I will close it as soon as this
On Mon, Feb 15, 2021 at 11:10:43AM +0100, Peter Krempa wrote:
> On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> > After the recent fixes, it's now confirmed to work.
> >
> > https://gitlab.com/libvirt/libvirt/-/issues/121
>
> Should it be closed then?
Good point, we should
On 2/12/21 11:07 PM, Laine Stump wrote:
142 more down, 3084 to go :-)
This goes through all the standard methods of eliminating VIR_FREE -
first converting as many pointers as possible to g_autofree, then
converting a few more *Free* functions (that were more questionable
than previous Frees)
On 2/12/21 11:07 PM, Laine Stump wrote:
These are all cases when 1) the pointer is passed by reference from
the caller (ie.e. **) and expects it to be NULL on return if there is
an error, or 2) the variable holding the pointer is being checked or
re-used in the same function, but not right away.
On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote:
> After the recent fixes, it's now confirmed to work.
>
> https://gitlab.com/libvirt/libvirt/-/issues/121
Should it be closed then?
>
> Signed-off-by: Andrea Bolognani
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6
After the recent fixes, it's now confirmed to work.
https://gitlab.com/libvirt/libvirt/-/issues/121
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index a9a1a61119..440dbf2601 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@
On 2/12/21 6:55 PM, Peter Krempa wrote:
Peter Krempa (25):
virLockDaemonPreExecRestart: Refactor memory cleanup
virLogDaemonPreExecRestart: Refactor memory cleanup
virLogHandlerPreExecRestart: Refactor memory cleanup
virNetDaemonPreExecRestart: Refactor memory cleanup
On 2/12/21 6:55 PM, Peter Krempa wrote:
The parent array takes ownership of the inserted value once all checks
pass. Don't make the callers second-guess when that happens and modify
the function to take a double pointer so that it can be cleared once the
ownership is taken.
Signed-off-by: Peter
46 matches
Mail list logo
