On Tue, Feb 28, 2012 at 05:04:57PM +0100, Michal Privoznik wrote:
On 24.02.2012 11:34, Christophe Fergeau wrote:
src/qemu/qemu_command.c | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5a34504
s/Modyfing/Modifying
---
docs/formatdomain.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 5305f82..9e7dd08 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2580,7 +2580,7 @@
On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-interface.c | 35
libvirt-gconfig/libvirt-gconfig-domain-interface.h |4 ++
ACK
On Tue, Feb 28, 2012 at 08:25:03PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Binding for virDomainBlockResize().
---
libvirt-gobject/libvirt-gobject-domain-disk.c | 38
+
libvirt-gobject/libvirt-gobject-domain-disk.h
On Tue, Feb 28, 2012 at 08:25:04PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Getter for the associated domain of a domain device.
NB: it already exists as a gobject property
---
libvirt-gobject/libvirt-gobject-domain-device.c | 10 ++
On Wed, Feb 29, 2012 at 02:02:08PM +0100, Christophe Fergeau wrote:
On Tue, Feb 28, 2012 at 08:25:04PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Getter for the associated domain of a domain device.
NB: it already exists as a gobject property
The code to add the property looks good to me except for one minor nit, see
below.
I'd rather to see patch 6/6 come right after it since I was wondering how
config was getting set.
On Tue, Feb 28, 2012 at 08:25:05PM +0200, Zeeshan Ali (Khattak) wrote:
@@ -144,3 +166,13 @@ virDomainPtr
On Tue, Feb 28, 2012 at 08:25:06PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Remove now redundant 'path' property from GVirDomainDevice subclasses.
---
libvirt-gobject/libvirt-gobject-domain-disk.c | 88
On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Currently we only support existing DomainDevice implementations:
DomainDisk and DomainInterface.
---
.../libvirt-gobject-domain-device-private.h|2 +
On Wed, Feb 29, 2012 at 03:44:20PM +0200, Zeeshan Ali (Khattak) wrote:
On Wed, Feb 29, 2012 at 2:57 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt
On Wed, Feb 29, 2012 at 04:01:40PM +0200, Zeeshan Ali (Khattak) wrote:
On Wed, Feb 29, 2012 at 3:30 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Currently we only
On Wed, Feb 29, 2012 at 04:10:29PM +0200, Zeeshan Ali (Khattak) wrote:
Ah, I just realized why that is so:
static char *libxml_str_to_glib(xmlChar *str)
{
char *g_str;
if (str == NULL)
return NULL;
g_str = g_strdup((char *)str);
xmlFree(str);
return
On Wed, Feb 29, 2012 at 05:26:58PM +0200, Zeeshan Ali (Khattak) wrote:
There wont' be any need for freeing if
gvir_config_xml_get_child_element_content() and similar functions
returned chid_node-content rather than xmlNodeGetContent
(child_node). That way you never need to free any string.
On Wed, Feb 29, 2012 at 11:22:52PM +0200, Zeeshan Ali (Khattak) wrote:
Turns out that i copypasted the device from the corresponding
setter.
I realized yesterday that you probably got device from the setter and
that I should have checked if the attribute name was correct there... I
just checked
ACK, though you convinced me that we can and should propagate const char *
throughout the API, but that's another patch.
Christophe
On Thu, Mar 01, 2012 at 12:15:39AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
ACK, a few nits below
On Thu, Mar 01, 2012 at 12:15:42AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Currently we only support existing DomainDevice implementations:
DomainDisk and DomainInterface.
---
.../libvirt-gobject-domain-device-private.h
On Thu, Mar 01, 2012 at 12:15:41AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Remove now redundant 'path' property from GVirDomainDevice subclasses.
These classes now have access to their configurations, from which they
can easily get the path (among
ACK
On Thu, Mar 01, 2012 at 12:15:37AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
gvir_config_domain_interface_set_ifname() should be setting 'dev'
attribute under 'target', not 'device'.
---
libvirt-gconfig/libvirt-gconfig-domain-interface.c |
ACK
On Thu, Mar 01, 2012 at 12:15:38AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Getter for the associated domain of a domain device.
---
libvirt-gobject/libvirt-gobject-domain-device.c | 11 +++
ACK
On Thu, Mar 01, 2012 at 12:15:40AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
GVirDomainDevice should have an associated GVirConfigDomainDevice.
---
libvirt-gobject/libvirt-gobject-domain-device.c | 33
+++
On Mon, Mar 05, 2012 at 05:34:16PM -0700, Eric Blake wrote:
@@ -3619,7 +3619,7 @@ error:
/**
* virDomainSetMaxMemory:
* @domain: a domain object or NULL
- * @memory: the memory size in kilobytes
+ * @memory: the memory size in kibibytes (blocks of 1024)
of 1024 bytes? I don't know how
, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_CHARDEV_SOURCE_SPICE_VMC_GET_PRIVATE(obj
It was called GVIR_CONFIG_DOMAIN_CONSOLE_TARGET_GUESTFWD, which in
turn confused glib-mkenums, leading to a wrong value being generated
in the XML when trying to use this enumeration.
---
libvirt-gconfig/libvirt-gconfig-domain-channel.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include
Hey,
Thanks for doing this!
I'll do a more in depth review on Monday if noone beats me to it, just some
quick notes:
On Wed, Mar 07, 2012 at 06:02:06AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
-char *
-gvir_config_xml_get_child_element_content_glib
On Wed, Mar 07, 2012 at 01:56:44AM +0200, Zeeshan Ali (Khattak) wrote:
On Wed, Mar 7, 2012 at 1:03 AM, Eric Blake ebl...@redhat.com wrote:
Actually, if I understand things right, preserving order _is_ important
to guarantee. For example, with older XML that lacked per-device boot
Ping for this patch and for 3/3 ?
Christophe
On Tue, Mar 06, 2012 at 05:38:33PM +0100, Christophe Fergeau wrote:
This is needed to be able to add the SPICE agent channels
---
libvirt-gconfig/Makefile.am|2 +
...ibvirt-gconfig-domain-chardev-source-spicevmc.c
The reason for them being there was that they were more expensive
than the helpers returning an xmlChar* (additional g_strdup). Now
that we are returning a pointer to const data inside the xml node,
the _glib helpers only use is to cast from const xmlChar * to
const char *. Removing them makes the
When gvir_config_xml_get_attribute_content fails to find the
attribute that the caller is looking for, we will try to dereference
'attr' which is NULL in this case. This will cause a crash.
---
libvirt-gconfig/libvirt-gconfig-helpers.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
g_strcmp0 is convenient when comparing potentially NULL strings.
Use this in gvir_config_xml_get_attribute_content instead of
explicitly checking for NULL.
---
libvirt-gconfig/libvirt-gconfig-helpers.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git
On Wed, Mar 07, 2012 at 06:02:06AM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
There is no need for all the memory (de)allocations and especially
forcing the app developers to free the strings. They can always
g_strdup() the returned string if they
Hey,
On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote:
On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Ping for this patch and for 3/3 ?
./test-domain-create gives:
channel type=spicevmc
target type=channel-target-virtio
On Tue, Mar 13, 2012 at 04:31:56PM +0100, Christophe Fergeau wrote:
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote:
On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com
wrote:
target type=channel-target-virtio/
That's what I was mainly
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote:
On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com
wrote:
target type=channel-target-virtio/
That's what I was mainly looking at, and I wish the test would cover a
more complex and needed case
On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote:
How do you verify new_from_xml()? Am I missing something?
This is just copy and paste, and keeping all files consistent. I don't
think we have any user of these methods, except the top level ones, and I'm
not sure it's really
Because of a copy and paste error, the test program is making an
unneeded call to gvir_config_domain_channel_set_target_type
when setting up its USB redirection device.
---
libvirt-gconfig/tests/test-domain-create.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git
libvirt documentation for channels with type 'spicevmc' says that the
'target' child node has:
an optional attribute name controls how the guest will have access
to the channel, and defaults to name='com.redhat.spice.0'.
However, this default value is never set in libvirt code base,
there's only
On Mon, Mar 26, 2012 at 02:42:17PM +0200, Michal Novotny wrote:
Fedora is using /etc/redhat-release file so you use the same handling
for Fedora and RHEL then it's fine.
I also have a /etc/fedora-release on my f17. systemd people are pushing for
standardization around
On Tue, Mar 27, 2012 at 12:23:54PM +0200, Michal Novotny wrote:
On 03/27/2012 10:32 AM, Christophe Fergeau wrote:
On Mon, Mar 26, 2012 at 02:42:17PM +0200, Michal Novotny wrote:
Fedora is using /etc/redhat-release file so you use the same handling
for Fedora and RHEL then it's fine.
I
libxml2 will properly escape and in XML attribute content. If
we use xmlEncodeEntitiesReentrant for attributes, this causes issues
with UTF8 filenames (gvir_config_domain_disk_set_source for example):
the filename UTF8 characters will be substituted with entities
(é - #xE9;), but when it uses
On Wed, Mar 28, 2012 at 10:02:40AM -0600, Eric Blake wrote:
On 03/23/2012 04:08 AM, Christophe Fergeau wrote:
libvirt documentation for channels with type 'spicevmc' says that the
'target' child node has:
an optional attribute name controls how the guest will have access
to the channel
On Wed, Mar 28, 2012 at 03:20:45PM -0400, Laine Stump wrote:
I know I'm a bit late to the party (I missed your mail before), but
would it have been possible to do the default processing in the caller
rather than in the parsing function itself?
I cannot disagree since I was not sure at all that
Hey,
Patch looks good to me, thanks for writing it :)
Christophe
On Fri, Mar 30, 2012 at 03:50:37AM -0400, Laine Stump wrote:
commit b0e2bb33 set a default value for the SPICE agent channel by
inserting it during parsing of the channel XML. That method of setting
a default is problematic
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
---
.../libvirt-gconfig-domain-controller.c| 10 ++
.../libvirt-gconfig-domain-controller.h|2 ++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller.c
Hey,
This patch series adds the needed classes for apps to be able to
use USB redirection. I've followed
http://hansdegoede.livejournal.com/11084.html and added all the API needed
to be able to get the same XML. However, I'm not 100% sure all these
attributes are required, in particular the
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_CONTROLLER_GET_PRIVATE(obj
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_GET_PRIVATE(obj
---
.../libvirt-gconfig-domain-controller.c| 29
.../libvirt-gconfig-domain-controller.h|4 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 35 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 21
.../libvirt-gconfig-domain-controller-usb.h|3 +++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 25 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 13 +
.../libvirt-gconfig-domain-controller-usb.h| 15 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 30 insertions(+)
diff --git
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_USB_GET_PRIVATE(obj
---
libvirt-gconfig/tests/test-domain-create.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 4ee33aa..7be9fc2 100644
--- a/libvirt-gconfig/tests/test-domain-create.c
---
libvirt-gconfig/tests/test-domain-create.c | 53 +++-
1 file changed, 37 insertions(+), 16 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 7be9fc2..0c1aad5 100644
---
---
libvirt-gconfig/libvirt-gconfig-domain-redirdev.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-redirdev.h |2 ++
libvirt-gconfig/libvirt-gconfig.sym |1 +
3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c
---
libvirt-gconfig/tests/test-domain-create.c | 43 ++--
1 file changed, 35 insertions(+), 8 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 0c1aad5..2b2f734 100644
---
to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
---
If this looks correct I'll have a look at libvirt-glib and
libvirt-gobject
On Wed, Apr 11, 2012 at 10:24:42AM +0100, Daniel P. Berrange wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered
On Fri, Apr 06, 2012 at 02:51:35PM +0200, Christophe Fergeau wrote:
Hey,
This patch series adds the needed classes for apps to be able to
use USB redirection. I've followed
http://hansdegoede.livejournal.com/11084.html and added all the API needed
to be able to get the same XML. However
Hey,
Here is the second version of the patch series implementing USB controller
support in libvirt-gconfig. There's a bug fixed in
GVirConfigDomainAddressUsb creation (type=usb was missing) as well as a
few small bug fixes/changes in the test program. I also added an additional
patch implementing
to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_CONTROLLER_GET_PRIVATE(obj
---
libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c | 13 +
libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 15 +++
libvirt-gconfig/libvirt-gconfig.sym |2 ++
3 files changed, 30 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 21
.../libvirt-gconfig-domain-controller-usb.h|3 +++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 25 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller.c| 29
.../libvirt-gconfig-domain-controller.h|4 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 35 insertions(+)
diff --git
---
libvirt-gconfig/libvirt-gconfig-domain-redirdev.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-redirdev.h |2 ++
libvirt-gconfig/libvirt-gconfig.sym |1 +
3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_USB_GET_PRIVATE(obj
---
libvirt-gconfig/tests/test-domain-create.c | 46 +++-
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index cdee883..b6d8813 100644
---
---
libvirt-gconfig/tests/test-domain-create.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 4ee33aa..7be9fc2 100644
--- a/libvirt-gconfig/tests/test-domain-create.c
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_GET_PRIVATE(obj
---
libvirt-gconfig/tests/test-domain-create.c | 54 +++-
1 file changed, 38 insertions(+), 16 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 7be9fc2..cdee883 100644
---
---
libvirt-gconfig/libvirt-gconfig-domain-controller.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-controller.h |2 ++
libvirt-gconfig/libvirt-gconfig.sym |1 +
3 files changed, 13 insertions(+)
diff --git
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
This function is a helper function which adds all the needed devices
for working USB support in the guest. This can be done manually, but
is a bit tedious, hence this helper.
---
libvirt-gconfig/libvirt-gconfig-domain.c | 41
On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau cferg...@redhat.com
wrote:
What would _USB2 do? Add an _EHCI controller, plus either
_PIIX3_UHCI or _PIIX4_UHCI?
From what I remember Hans told me, all the 4 ehci + uhci
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
So IMHO we should not add this API
I'm fine with dropping the patch. My feeling was that this
On Wed, Apr 11, 2012 at 04:29:28PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+void gvir_config_domain_setup_default_usb_controllers(GVirConfigDomain
*domain)
I suggest it takes an enum
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
With respect to hypervisors, since the function has a GVirConfigDomain
parameter, we could use it
On Wed, Apr 11, 2012 at 06:51:48PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 6:19 PM, Daniel P. Berrange berra...@redhat.com
wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
This is a
Hey,
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
libvirt-gconfig/libvirt-gconfig-domain-disk.h |9
On Thu, Apr 12, 2012 at 12:06:52PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 03:48:09PM +0200, Christophe Fergeau wrote:
[..snip..]
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -69,6 +69,8 @@ LIBVIRT_GCONFIG_0.0.4
On Thu, Apr 12, 2012 at 12:08:42PM +0200, Guido Günther wrote:
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
On Thu, Apr 12, 2012 at 11:50:30PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
libvirt-gconfig/libvirt-gconfig-domain-disk.h |9
On Fri, Apr 13, 2012 at 04:41:32PM +0300, Zeeshan Ali (Khattak) wrote:
On Fri, Apr 13, 2012 at 2:26 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Apr 12, 2012 at 11:50:30PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 26
libvirt-gconfig/libvirt-gconfig-domain-timer.h |9
libvirt-gconfig/libvirt-gconfig.sym|3 +++
3 files changed, 38 insertions(+)
diff --git
---
libvirt-gconfig/libvirt-gconfig-domain-clock.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-clock.h |4
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-clock.c
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_TIMER_RTC_GET_PRIVATE
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
Specialized timer classes will inherit from it
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 22 +-
libvirt-gconfig/libvirt-gconfig-domain-timer.h |4
libvirt-gconfig/libvirt-gconfig.sym|2 --
3 files changed, 1 insertion(+), 27 deletions(-)
Hey,
I've just pushed these 2 documentation patches under the trivial rule.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
docs/formatdomain.html.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bb67cd1..e08a3d2 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -359,7 +359,7 @@
0.8.5/span, the
'omitted' was mispelt 'commited' twice. One of the sentences with
the typo was also missing an 'is' ('each VCPU *is* pinned to all...')
which I added in this commit while I was at it.
---
docs/formatdomain.html.in |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Update gvir_config_domain_device_new_from_tree to handle
GVirConfigDomainController nodes
---
.../libvirt-gconfig-domain-controller.c| 37
.../libvirt-gconfig-domain-device-private.h|3 ++
libvirt-gconfig/libvirt-gconfig-domain-device.c|2 +-
Update gvir_config_domain_device_new_from_tree to handle
GVirConfigDomainRedirdev nodes
---
libvirt-gconfig/libvirt-gconfig-domain-device.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.c
On Thu, Apr 19, 2012 at 03:12:01AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 74
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
On Thu, Apr 19, 2012 at 04:24:35PM +0300, Zeeshan Ali (Khattak) wrote:
On Thu, Apr 19, 2012 at 11:52 AM, Christophe Fergeau
cferg...@redhat.com wrote:
On Thu, Apr 19, 2012 at 03:12:01AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
+static void
On Thu, Apr 19, 2012 at 04:45:29PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 74
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
ACK
Christophe
On Thu, Apr 19, 2012 at 05:17:04PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 80
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
1 - 100 of 1510 matches
Mail list logo
