Re: [PATCH v2] statx: stx_subvol

2024-05-28 Thread Andreas Dilger
> On May 28, 2024, at 6:46 AM, John Garry wrote: > > On 12/03/2024 02:13, Eric Biggers wrote: >> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote: >>> __u32 stx_dio_mem_align; /* Memory buffer alignment for direct >>> I/O */ >>> __u32 stx_dio_offset_align; /*

Re: [PATCH v2] statx: stx_subvol

2024-05-28 Thread John Garry
On 12/03/2024 02:13, Eric Biggers wrote: On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote: __u32 stx_dio_mem_align; /* Memory buffer alignment for direct I/O */ __u32 stx_dio_offset_align; /* File offset alignment for direct I/O */ + __u64

Re: [PATCH v2] statx: stx_subvol

2024-03-12 Thread Neal Gompa
On Tue, Mar 12, 2024 at 7:27 AM Christian Brauner wrote: > > On Mon, Mar 11, 2024 at 11:43:00PM +0100, David Sterba wrote: > > On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote: > > > On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > > > > On 08.03.24 03:29,

Re: [PATCH v2] statx: stx_subvol

2024-03-12 Thread Christian Brauner
On Mon, Mar 11, 2024 at 11:43:00PM +0100, David Sterba wrote: > On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote: > > On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > > > On 08.03.24 03:29, Kent Overstreet wrote: > > > > Add a new statx field for (sub)volume

Re: [PATCH v2] statx: stx_subvol

2024-03-12 Thread Christian Brauner
On Mon, Mar 11, 2024 at 04:15:04PM -0400, Kent Overstreet wrote: > On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote: > > On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > > > On 08.03.24 03:29, Kent Overstreet wrote: > > > > Add a new statx field for

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread Eric Biggers
On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote: > __u32 stx_dio_mem_align; /* Memory buffer alignment for direct > I/O */ > __u32 stx_dio_offset_align; /* File offset alignment for direct I/O > */ > + __u64 stx_subvol; /* Subvolume identifier */

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread David Sterba
On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote: > On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > > On 08.03.24 03:29, Kent Overstreet wrote: > > > Add a new statx field for (sub)volume identifiers, as implemented by > > > btrfs and bcachefs. > > > > > >

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread Kent Overstreet
On Mon, Mar 11, 2024 at 02:43:11PM +0100, Christian Brauner wrote: > On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > > On 08.03.24 03:29, Kent Overstreet wrote: > > > Add a new statx field for (sub)volume identifiers, as implemented by > > > btrfs and bcachefs. > > > > > >

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread Christian Brauner
On Mon, Mar 11, 2024 at 08:12:33AM +, Johannes Thumshirn wrote: > On 08.03.24 03:29, Kent Overstreet wrote: > > Add a new statx field for (sub)volume identifiers, as implemented by > > btrfs and bcachefs. > > > > This includes bcachefs support; we'll definitely want btrfs support as > > well.

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread Christian Brauner
On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > On Fri, Mar 08, 2024 at 11:48:31AM -0500, Kent Overstreet wrote: > > On Fri, Mar 08, 2024 at 11:44:48AM -0500, Neal Gompa wrote: > > > On Fri, Mar 8, 2024 at 11:34 AM Kent Overstreet > > > wrote: > > > > > > > > On Fri, Mar 08,

Re: [PATCH v2] statx: stx_subvol

2024-03-11 Thread Johannes Thumshirn
On 08.03.24 03:29, Kent Overstreet wrote: > Add a new statx field for (sub)volume identifiers, as implemented by > btrfs and bcachefs. > > This includes bcachefs support; we'll definitely want btrfs support as > well. For btrfs you can add the following: From

Re: [PATCH v2] statx: stx_subvol

2024-03-10 Thread Kent Overstreet
On Mon, Mar 11, 2024 at 06:30:21AM +0100, Miklos Szeredi wrote: > On Mon, 11 Mar 2024 at 03:17, Dave Chinner wrote: > > > > On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > > > Should the XFS data and rt volumes be reported with different stx_vol > > > values? > > > > No,

Re: [PATCH v2] statx: stx_subvol

2024-03-10 Thread Miklos Szeredi
On Mon, 11 Mar 2024 at 03:17, Dave Chinner wrote: > > On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > > Should the XFS data and rt volumes be reported with different stx_vol > > values? > > No, because all the inodes are on the data volume and the same inode > can have data on

Re: [PATCH v2] statx: stx_subvol

2024-03-10 Thread Dave Chinner
On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > Should the XFS data and rt volumes be reported with different stx_vol > values? No, because all the inodes are on the data volume and the same inode can have data on the data volume or the rt volume. i.e. "data on rt, truncate,

Re: [PATCH v2] statx: stx_subvol

2024-03-09 Thread Kent Overstreet
On Sat, Mar 09, 2024 at 06:46:54AM -0500, Jeff Layton wrote: > On Fri, 2024-03-08 at 12:13 -0500, Kent Overstreet wrote: > > On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > > > On Fri, Mar 08, 2024 at 11:48:31AM -0500, Kent Overstreet wrote: > > > > It's a new feature, not a

Re: [PATCH v2] statx: stx_subvol

2024-03-09 Thread Jeff Layton
On Fri, 2024-03-08 at 12:13 -0500, Kent Overstreet wrote: > On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > > On Fri, Mar 08, 2024 at 11:48:31AM -0500, Kent Overstreet wrote: > > > It's a new feature, not a bugfix, this should never get backported. And > > > I the bcachefs

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Kent Overstreet
On Fri, Mar 08, 2024 at 08:56:33AM -0800, Darrick J. Wong wrote: > On Fri, Mar 08, 2024 at 11:48:31AM -0500, Kent Overstreet wrote: > > It's a new feature, not a bugfix, this should never get backported. And > > I the bcachefs maintainer wrote the patch, and I'm submitting it to the > > VFS

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Darrick J. Wong
On Fri, Mar 08, 2024 at 11:48:31AM -0500, Kent Overstreet wrote: > On Fri, Mar 08, 2024 at 11:44:48AM -0500, Neal Gompa wrote: > > On Fri, Mar 8, 2024 at 11:34 AM Kent Overstreet > > wrote: > > > > > > On Fri, Mar 08, 2024 at 06:42:27AM -0500, Neal Gompa wrote: > > > > On Thu, Mar 7, 2024 at 9:29 

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Kent Overstreet
On Fri, Mar 08, 2024 at 11:44:48AM -0500, Neal Gompa wrote: > On Fri, Mar 8, 2024 at 11:34 AM Kent Overstreet > wrote: > > > > On Fri, Mar 08, 2024 at 06:42:27AM -0500, Neal Gompa wrote: > > > On Thu, Mar 7, 2024 at 9:29 PM Kent Overstreet > > > wrote: > > > > > > > > Add a new statx field for

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Neal Gompa
On Fri, Mar 8, 2024 at 11:34 AM Kent Overstreet wrote: > > On Fri, Mar 08, 2024 at 06:42:27AM -0500, Neal Gompa wrote: > > On Thu, Mar 7, 2024 at 9:29 PM Kent Overstreet > > wrote: > > > > > > Add a new statx field for (sub)volume identifiers, as implemented by > > > btrfs and bcachefs. > > > >

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Kent Overstreet
On Fri, Mar 08, 2024 at 06:42:27AM -0500, Neal Gompa wrote: > On Thu, Mar 7, 2024 at 9:29 PM Kent Overstreet > wrote: > > > > Add a new statx field for (sub)volume identifiers, as implemented by > > btrfs and bcachefs. > > > > This includes bcachefs support; we'll definitely want btrfs support as

Re: [PATCH v2] statx: stx_subvol

2024-03-08 Thread Neal Gompa
On Thu, Mar 7, 2024 at 9:29 PM Kent Overstreet wrote: > > Add a new statx field for (sub)volume identifiers, as implemented by > btrfs and bcachefs. > > This includes bcachefs support; we'll definitely want btrfs support as > well. > > Link: >

[PATCH v2] statx: stx_subvol

2024-03-07 Thread Kent Overstreet
Add a new statx field for (sub)volume identifiers, as implemented by btrfs and bcachefs. This includes bcachefs support; we'll definitely want btrfs support as well. Link: https://lore.kernel.org/linux-fsdevel/2uvhm6gweyl7iyyp2xpfryvcu2g3padagaeqcbiavjyiis6prl@yjm725bizncq/ Signed-off-by: Kent