[PATCH] xfs: replace deprecated strncpy with strscpy_pad

2024-04-05 Thread Justin Stitt
gt;sb_fname, XFSLABEL_MAX); + strscpy_pad(label, sbp->sb_fname); spin_unlock(>m_sb_lock); if (copy_to_user(user_label, label, sizeof(label))) --- base-commit: c85af715cac0a951eea97393378e84bb49384734 change-id: 20240405-strncpy-xfs-split1-a2c408b934c6 Best regards, -- Justin Stitt

[PATCH] xfs: xattr: replace strncpy and check for truncation

2024-04-05 Thread Justin Stitt
t += prefix_len + namelen + 1; --- base-commit: c85af715cac0a951eea97393378e84bb49384734 change-id: 20240405-strncpy-xattr-split2-0a3aff0c6a20 Best regards, -- Justin Stitt

Re: [PATCH v4 0/7] Handle faults in KUnit tests

2024-04-05 Thread Shuah Khan
On 4/5/24 12:07, Mickaël Salaün wrote: On Fri, Apr 05, 2024 at 10:08:00AM -0600, Shuah Khan wrote: On 3/26/24 03:51, Mickaël Salaün wrote: Hi, This patch series teaches KUnit to handle kthread faults as errors, and it brings a few related fixes and improvements. Shuah, everything should be

Re: [syzbot] [mm?] [hardening?] BUG: bad usercopy in do_handle_open

2024-04-05 Thread Gustavo A. R. Silva
usercopy: Kernel memory overwrite attempt detected to SLUB object 'kmalloc-16' (offset 8, size 9)! We tried to copy 9 bytes into the f_handle[] array. But from my reading of the reproducer, f_handle.handle_bytes was set to 1. Aneesh, any thoughts on this? This was previously reported:

Re: [syzbot] [mm?] [hardening?] BUG: bad usercopy in do_handle_open

2024-04-05 Thread Andrew Morton
On Fri, 05 Apr 2024 10:40:30 -0700 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:c0b832517f62 Add linux-next specific files for 20240402 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=13a5c3b118 > kernel

Re: [PATCH v4 0/7] Handle faults in KUnit tests

2024-04-05 Thread Mickaël Salaün
On Fri, Apr 05, 2024 at 10:08:00AM -0600, Shuah Khan wrote: > On 3/26/24 03:51, Mickaël Salaün wrote: > > Hi, > > > > This patch series teaches KUnit to handle kthread faults as errors, and > > it brings a few related fixes and improvements. > > > > Shuah, everything should be OK now, could you

[syzbot] [mm?] [hardening?] BUG: bad usercopy in do_handle_open

2024-04-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c0b832517f62 Add linux-next specific files for 20240402 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=13a5c3b118 kernel config: https://syzkaller.appspot.com/x/.config?x=afcaf46d374cec8c

Re: [PATCH v4 0/7] Handle faults in KUnit tests

2024-04-05 Thread Shuah Khan
On 3/26/24 03:51, Mickaël Salaün wrote: Hi, This patch series teaches KUnit to handle kthread faults as errors, and it brings a few related fixes and improvements. Shuah, everything should be OK now, could you please merge this series? Please cc linux-kselftest and kunit mailing lists. You

Re: [PATCH v2] fs: Set file_handle::handle_bytes before referencing file_handle::f_handle

2024-04-05 Thread Kees Cook
On Fri, Apr 05, 2024 at 12:21:57PM +0200, Jan Kara wrote: > On Thu 04-04-24 14:12:15, Kees Cook wrote: > > Since __counted_by(handle_bytes) was added to struct file_handle, we need > > to explicitly set it in the one place it wasn't yet happening prior to > > accessing the flex array "f_handle".

Re: [PATCH v5][next] integrity: Avoid -Wflex-array-member-not-at-end warnings

2024-04-05 Thread Mimi Zohar
On Thu, 2024-04-04 at 18:56 -0600, Gustavo A. R. Silva wrote: > > "checkpatch.pl --strict" complains "CHECK: Alignment should match open > > parenthesis". I'll queue the patch, but how about teaching checkpatch.pl to > > ignore __struct_group()? > > I think this would do it: > > diff --git

Re: [PATCH] fs: Set file_handle::handle_bytes before referencing file_handle::f_handle

2024-04-05 Thread Christian Brauner
On Thu, Apr 04, 2024 at 11:19:00AM +0200, Jan Kara wrote: > On Wed 03-04-24 14:54:03, Kees Cook wrote: > > With adding __counted_by(handle_bytes) to struct file_handle, we need > > to explicitly set it in the one place it wasn't yet happening prior to > > accessing the flex array "f_handle". > >

Re: [PATCH v2] fs: Set file_handle::handle_bytes before referencing file_handle::f_handle

2024-04-05 Thread Jan Kara
On Thu 04-04-24 14:12:15, Kees Cook wrote: > Since __counted_by(handle_bytes) was added to struct file_handle, we need > to explicitly set it in the one place it wasn't yet happening prior to > accessing the flex array "f_handle". For robustness also check for a > negative value for handle_bytes,

Re: [PATCH 7/7] arm64: dts: qcom: Add SM8550 Xperia 1 V

2024-04-05 Thread neil . armstrong
On 04/04/2024 21:41, Konrad Dybcio wrote: On 2/12/24 18:26, Neil Armstrong wrote: On 12/02/2024 14:10, Konrad Dybcio wrote: Add support for Sony Xperia 1 V, a.k.a PDX234. This device is a part of the SoMC SM8550 Yodo platform. [...] +/* TODO: Only one SID of PMR735D seems accessible? */