Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-16 Thread Christian Brauner
On Wed, Feb 14, 2024 at 08:18:01PM +0100, Oleg Nesterov wrote: > On 02/14, Tycho Andersen wrote: > > > > On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote: > > > > > > We want to check the "flags" argument at the start, we do not want to > > > delay the "case 0:" check until we have

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Oleg Nesterov
On 02/14, Tycho Andersen wrote: > > On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote: > > > > We want to check the "flags" argument at the start, we do not want to > > delay the "case 0:" check until we have f.file (so that we can check > > f.file->f_flags). > > Fair point. I was

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Kees Cook
On Tue, Feb 13, 2024 at 05:18:01PM -0700, Tycho Andersen wrote: > On Tue, Feb 13, 2024 at 03:59:37PM -0800, coverity-bot wrote: > > Hello! > > > > This is an experimental semi-automated report about issues detected by > > Coverity from a scan of next-20240213 as part of the linux-next scan > >

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Tycho Andersen
On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote: > Hi Tycho, > > let me repeat just in case, I am fine either way, whatever you and > Christian prefer. In particular, I agree in advance if you decide > to not change the current code, it is correct even if it can fool > the tools. >

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Oleg Nesterov
Hi Tycho, let me repeat just in case, I am fine either way, whatever you and Christian prefer. In particular, I agree in advance if you decide to not change the current code, it is correct even if it can fool the tools. That said, On 02/14, Tycho Andersen wrote: > > On Wed, Feb 14, 2024 at

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Tycho Andersen
On Wed, Feb 14, 2024 at 10:06:41AM +0100, Oleg Nesterov wrote: > On 02/14, Oleg Nesterov wrote: > > > > On 02/13, Tycho Andersen wrote: > > > > > > I think this is a false positive, we have: > > > > Agreed, > > > > > That said, a default case wouldn't hurt, and we should fix the first > > >

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Oleg Nesterov
On 02/14, Oleg Nesterov wrote: > > On 02/13, Tycho Andersen wrote: > > > > I think this is a false positive, we have: > > Agreed, > > > That said, a default case wouldn't hurt, and we should fix the first > > comment anyways, since now we have extensions. > > > > I'm happy to send a patch or maybe

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-14 Thread Oleg Nesterov
On 02/13, Tycho Andersen wrote: > > I think this is a false positive, we have: Agreed, > That said, a default case wouldn't hurt, and we should fix the first > comment anyways, since now we have extensions. > > I'm happy to send a patch or maybe it's better for Christian to fix it > in-tree. I

Re: Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-13 Thread Tycho Andersen
On Tue, Feb 13, 2024 at 03:59:37PM -0800, coverity-bot wrote: > Hello! > > This is an experimental semi-automated report about issues detected by > Coverity from a scan of next-20240213 as part of the linux-next scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're

Coverity: __do_sys_pidfd_send_signal(): UNINIT

2024-02-13 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20240213 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of