Re: [PATCH v2] integrity: eliminate unnecessary "Problem loading X.509 certificate" msg

2024-03-12 Thread Coiby Xu
On Wed, Mar 06, 2024 at 01:40:01PM +0100, Maxime Ripard wrote: On Wed, Mar 06, 2024 at 06:55:00AM -0500, Mimi Zohar wrote: On Wed, 2024-03-06 at 11:57 +0100, Maxime Ripard wrote: > Hi Dmitry, Eric, James, Mimi, Paul, Serge, > > On Tue, Jan 09, 2024 at 08:24:28AM +0800, Coiby

Re: [PATCH v2] integrity: eliminate unnecessary "Problem loading X.509 certificate" msg

2024-02-16 Thread Coiby Xu
Hi Mimi, Could you take a look at this version of patch? If it escaped your attention because it got buried in the same thread, sorry for that. And I won't send new version as a reply to previous version in the future. On Tue, Jan 09, 2024 at 08:24:28AM +0800, Coiby Xu wrote: Currently when

Re: Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-08 Thread Coiby Xu
On Fri, Jan 05, 2024 at 09:59:14AM -0500, Mimi Zohar wrote: On Fri, 2024-01-05 at 21:27 +0800, Coiby Xu wrote: On Tue, Jan 02, 2024 at 12:54:02PM -0500, Mimi Zohar wrote: >Hi Coiby, Hi Mimi, > >According to https://docs.kernel.org/process/submitting-patches.html,the summary li

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-08 Thread Coiby Xu
On Fri, Jan 05, 2024 at 06:02:38PM +0200, Jarkko Sakkinen wrote: On Fri Jan 5, 2024 at 3:20 PM EET, Coiby Xu wrote: On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote: >On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: >> Currently when the kernel fails to a

[PATCH v2] integrity: eliminate unnecessary "Problem loading X.509 certificate" msg

2024-01-08 Thread Coiby Xu
there is no need to throw an error immediately in integrity_add_key. Reported-by: itrymybes...@protonmail.com Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331 Fixes: d19967764ba8 ("integrity: Introduce a Linux keyring called machine") Reviewed-by: Eric Snowberg Signed-off-by: Coiby

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
On Tue, Jan 02, 2024 at 05:33:53PM +, Eric Snowberg wrote: On Dec 26, 2023, at 9:41 PM, Coiby Xu wrote: Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
error "Problem loading X.509 certificate -126"? On Wed, 2023-12-27 at 12:41 +0800, Coiby Xu wrote: Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding to the

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote: On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding

[PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2023-12-26 Thread Coiby Xu
there is no need to throw an error immediately in integrity_add_key. Reported-by: itrymybes...@protonmail.com Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331 Signed-off-by: Coiby Xu --- security/integrity/digsig.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git