Re: Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-08 Thread Coiby Xu
On Fri, Jan 05, 2024 at 09:59:14AM -0500, Mimi Zohar wrote: On Fri, 2024-01-05 at 21:27 +0800, Coiby Xu wrote: On Tue, Jan 02, 2024 at 12:54:02PM -0500, Mimi Zohar wrote: >Hi Coiby, Hi Mimi, > >According to https://docs.kernel.org/process/submitting-patches.html,the summary line should be no

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-08 Thread Coiby Xu
On Fri, Jan 05, 2024 at 06:02:38PM +0200, Jarkko Sakkinen wrote: On Fri Jan 5, 2024 at 3:20 PM EET, Coiby Xu wrote: On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote: >On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: >> Currently when the kernel fails to add a cert to the

Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Jarkko Sakkinen
On Fri Jan 5, 2024 at 3:20 PM EET, Coiby Xu wrote: > On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote: > >On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: > >> Currently when the kernel fails to add a cert to the .machine keyring, > >> it will throw an error immediately in the

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Mimi Zohar
On Fri, 2024-01-05 at 21:27 +0800, Coiby Xu wrote: > On Tue, Jan 02, 2024 at 12:54:02PM -0500, Mimi Zohar wrote: > >Hi Coiby, > > Hi Mimi, > > > > >According to https://docs.kernel.org/process/submitting-patches.html,the > summary line should be no more than 70 - 75 characters. > > Thanks for

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
On Tue, Jan 02, 2024 at 05:33:53PM +, Eric Snowberg wrote: On Dec 26, 2023, at 9:41 PM, Coiby Xu wrote: Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding to the

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
On Tue, Jan 02, 2024 at 12:54:02PM -0500, Mimi Zohar wrote: Hi Coiby, Hi Mimi, According to https://docs.kernel.org/process/submitting-patches.html,the summary line should be no more than 70 - 75 characters. Thanks for pointing me to this limit! How about integrity: eliminate harmless

Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-05 Thread Coiby Xu
On Wed, Jan 03, 2024 at 04:09:29PM +0200, Jarkko Sakkinen wrote: On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding to

Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-03 Thread Jarkko Sakkinen
On Wed Dec 27, 2023 at 6:41 AM EET, Coiby Xu wrote: > Currently when the kernel fails to add a cert to the .machine keyring, > it will throw an error immediately in the function integrity_add_key. > > Since the kernel will try adding to the .platform keyring next or throw > an error (in the caller

Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-02 Thread Mimi Zohar
Hi Coiby, According to https://docs.kernel.org/process/submitting-patches.html,the summary line should be no more than 70 - 75 characters. On Wed, 2023-12-27 at 12:41 +0800, Coiby Xu wrote: > Currently when the kernel fails to add a cert to the .machine keyring, > it will throw an error

Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2024-01-02 Thread Eric Snowberg
> On Dec 26, 2023, at 9:41 PM, Coiby Xu wrote: > > Currently when the kernel fails to add a cert to the .machine keyring, > it will throw an error immediately in the function integrity_add_key. > > Since the kernel will try adding to the .platform keyring next or throw > an error (in the

[PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

2023-12-26 Thread Coiby Xu
Currently when the kernel fails to add a cert to the .machine keyring, it will throw an error immediately in the function integrity_add_key. Since the kernel will try adding to the .platform keyring next or throw an error (in the caller of integrity_add_key i.e. add_to_machine_keyring), so there