[patch] freevxfs: possible null pointer dereference fix

2007-02-19 Thread Dmitriy Monakhov
sb_read may return NULL, so let's explicitly check it. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/fs/freevxfs/vxfs_bmap.c b/fs/freevxfs/vxfs_bmap.c index 2d71128..f86fd3c 100644 --- a/fs/freevxfs/vxfs_bmap.c +++ b/fs/freevxfs/vxfs_bmap.c @@ -137,7 +137,7 @@

[patch] reiserfs: possible null pointer dereference during resize

2007-02-19 Thread Dmitriy Monakhov
sb_read may return NULL, let's explicitly check it. If so free new bitmap blocks array, after this we may safely exit as it done above during bitmap allocation. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/fs/reiserfs/resize.c b/fs/reiserfs/resize.c index

[KJ][PATCH] is_power_of_2 in fs/block_dev.c

2007-02-19 Thread Vignesh Babu BM
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/fs/block_dev.c b/fs/block_dev.c index fc7028b..e8f2a2b 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -22,6 +22,7 @@ #include #include #include

[KJ][PATCH] is_power_of_2 in fat

2007-02-19 Thread Vignesh Babu BM
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/fs/fat/inode.c b/fs/fat/inode.c index a9e4688..8437190 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -25,6 +25,7 @@ #include #include #include

[KJ][PATCH] is_power_of_2 in fs/hfs

2007-02-19 Thread Vignesh Babu BM
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c index 5fd0ed7..8a3a650 100644 --- a/fs/hfs/btree.c +++ b/fs/hfs/btree.c @@ -9,6 +9,7 @@ */ #include +#include

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Trent Waddington
Just in case anyone cares, after speaking with Michael for a few hours I've found he's not nearly as abrasive as this mailing list banter might suggest. He makes some good arguments once you stop him from spouting conspiracy stuff and, although I don't agree with all of them, I think he has some

Re: [PATCH] x86: mtrr range check correction

2007-02-19 Thread Jan Beulich
>>> Chuck Ebbert <[EMAIL PROTECTED]> 18.02.07 22:33 >>> >Jan Beulich wrote: >> Whether a region is below 1Mb is determined by its start rather than >> its end. >> >> This hunk got erroneously dropped from a previous patch. >> >> Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> >> >> ---

Re: 2.6.20-rc6 libata PATA ATAPI CDROM is not working

2007-02-19 Thread Joel Soete
> [snip] > > > > Hmm, readcd was trying to read 279884 blocks, while cdrecord said it > > wrote 279882 blocks. > > > yes and seems to be always the same: > with new burned cd I got: > # ll /MultiCd/cd060213.iso > -rwxr-xr-x 1 root root 3213312 Feb 13 2006 /MultiCd/cd060213.iso > > i.e.

Re: [BUG?] register_blkdev: failed to get major for device mapper

2007-02-19 Thread Rolf Eike Beer
Am Montag, 19. Februar 2007 schrieben Sie: > On Mon, 19 Feb 2007 15:39:38 +0100 Rolf Eike Beer <[EMAIL PROTECTED]> wrote: > > > It's totally weird. It prints the "skipped" message for every (!) > > > number, not just for the blacklisted ones. And I've triple checked that > > > I don't have missed

Re: Linux 2.6.20.1

2007-02-19 Thread Greg KH
diff --git a/Makefile b/Makefile index 7e2750f..d26f3f5 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 20 -EXTRAVERSION = +EXTRAVERSION = .1 NAME = Homicidal Dwarf Hamster # *DOCUMENTATION* diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c index

Re: Linux 2.6.18.7

2007-02-19 Thread Greg KH
diff --git a/Makefile b/Makefile index c8b2f7e..ed22616 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 18 -EXTRAVERSION = .6 +EXTRAVERSION = .7 NAME=Avast! A bilge rat! # *DOCUMENTATION* diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c index

Re: Linux 2.6.19.4

2007-02-19 Thread Greg KH
diff --git a/Makefile b/Makefile index 976d24a..fa3a8f2 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 19 -EXTRAVERSION = .3 +EXTRAVERSION = .4 NAME=Avast! A bilge rat! # *DOCUMENTATION* diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c index

Re: irqdesc porting help

2007-02-19 Thread Maximus
Hi, Sorry for the late response, attached is the code im trying to port to linux - 2.6.20. Regards, Jo On 2/15/07, Paul Mundt <[EMAIL PROTECTED]> wrote: On Thu, Feb 15, 2007 at 12:01:37PM +0530, Maximus wrote: > Im trying to port some drivers between 2.6.14 and 2.6.19 > > I find that

Re: Recent and not-so problems with tifm_sd driver

2007-02-19 Thread Pierre Ossman
Alex Dubov wrote: > > correction: my driver schedules (wakes kthread in 0.7) mmc_remove_host - > noticed it only now > Ok, good. Then things are as they should on your part. > > That's why I think that simply flushing the workqueue is enough. If workqueue > is empty we know for > sure that

Linux 2.6.20.1

2007-02-19 Thread Greg KH
We (the -stable team) are announcing the release of the 2.6.20.1 kernel. It contains one NFS fix that if you run a NFS server, you might want to apply. The diffstat and short summary of the fixes are below. I'll also be replying to this message with a copy of the patch between 2.6.20 and

Linux 2.6.19.4

2007-02-19 Thread Greg KH
We (the -stable team) are announcing the release of the 2.6.18.4 kernel. It contains one NFS fix that if you run a NFS server, you might want to apply. The diffstat and short summary of the fixes are below. I'll also be replying to this message with a copy of the patch between 2.6.19.3 and

Linux 2.6.18.7

2007-02-19 Thread Greg KH
We (the -stable team) are announcing the release of the 2.6.18.7 kernel. It contains one NFS fix that if you run a NFS server, you might want to apply. The diffstat and short summary of the fixes are below. I'll also be replying to this message with a copy of the patch between 2.6.18.6 and

Re: [-mm patch] drivers/mmc/Kconfig source drivers/mmc/card/Kconfig

2007-02-19 Thread Pierre Ossman
Adrian Bunk wrote: > On Sat, Feb 17, 2007 at 09:51:46PM -0800, Andrew Morton wrote: >> ... >> Changes since 2.6.20-mm1: >> ... >> git-mmc.patch >> ... >> git trees >> ... > > > The MMC_BLOCK option was accidentally lost. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Thanks. I wonder

Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Vaidyanathan Srinivasan
Balbir Singh wrote: > Vaidyanathan Srinivasan wrote: >> Balbir Singh wrote: >>> Paul Menage wrote: On 2/19/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> More worrisome is the potential for use-after-free. What prevents the >> pointer at mm->container from referring to freed memory

Re: Racy NLS behaviour in FAT (and possible other fs)

2007-02-19 Thread Pierre Ossman
OGAWA Hirofumi wrote: > Yes. But sorry, I don't have any plan and time to fix it now. > I know the feeling. :) I just wanted to know where things stand as I have little insight into vfat development. > If you are using "iocharset=utf8" now, "codepage=cp???,iocharset=xxx,utf8" > might help a

Re: NCPFS and brittle connections

2007-02-19 Thread Pierre Ossman
Petr Vandrovec wrote: > > Hello, > it would be nice if these two copies (request->txbuf, and > rxbuf->reply) could be eliminated, but I see no easy way how to do > that... > At least we have the basic functionality now. One can start looking at optimising it after that. > > Acked-by: Petr

Re: [-mm patch] UNION_FS must depend on SLAB

2007-02-19 Thread Pekka Enberg
On 2/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: CC fs/unionfs/copyup.o /home/bunk/linux/kernel-2.6/linux-2.6.20-mm2/fs/unionfs/copyup.c: In function 'create_parents_named': /home/bunk/linux/kernel-2.6/linux-2.6.20-mm2/fs/unionfs/copyup.c:620: error: 'malloc_sizes' undeclared (first

[PATCH 004 of 6] md: Clean out unplug and other queue function on md shutdown

2007-02-19 Thread NeilBrown
The mddev and queue might be used for another array which does not set these, so they need to be cleared. Signed-off-by: NeilBrown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/md.c |3 +++ 1 file changed, 3 insertions(+) diff .prev/drivers/md/md.c ./drivers/md/md.c ---

[PATCH 006 of 6] md: Add support for reshape of a raid6

2007-02-19 Thread NeilBrown
i.e. one or more drives can be added and the array will re-stripe while on-line. Most of the interesting work was already done for raid5. This just extends it to raid6. mdadm newer than 2.6 is needed for complete safety, however any version of mdadm which support raid5 reshape will do a good

[PATCH 005 of 6] md: Restart a (raid5) reshape that has been aborted due to a read/write error.

2007-02-19 Thread NeilBrown
An error always aborts any resync/recovery/reshape on the understanding that it will immediately be restarted if that still makes sense. However a reshape currently doesn't get restarted. With this patch it does. To avoid restarting when it is not possible to do work, we call into the

[PATCH 002 of 6] md: RAID6: clean up CPUID and FPU enter/exit code

2007-02-19 Thread NeilBrown
From: "H. Peter Anvin" <[EMAIL PROTECTED]> - Use kernel_fpu_begin() and kernel_fpu_end() - Use boot_cpu_has() for feature testing even in userspace Signed-off-by: H. Peter Anvin <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./drivers/md/raid6mmx.c |

[PATCH 003 of 6] md: Move warning about creating a raid array on partitions of the one device.

2007-02-19 Thread NeilBrown
md tries to warn the user if they e.g. create a raid1 using two partitions of the same device, as this does not provide true redundancy. However it also warns if a raid0 is created like this, and there is nothing wrong with that. At the place where the warning is currently printer, we don't

[PATCH 001 of 6] md: Fix raid10 recovery problem.

2007-02-19 Thread NeilBrown
There are two errors that can lead to recovery problems with raid10 when used in 'far' more (not the default). Due to a '>' instead of '>=' the wrong block is located which would result in garbage being written to some random location, quite possible outside the range of the device, causing the

[PATCH 000 of 6] md: Assorted fixes and features for md for 2.6.21

2007-02-19 Thread NeilBrown
Following 6 patches are against 2.6.20 and are suitable for 2.6.21. They are not against -mm because the new plugging makes raid5 not work and so not testable, and there are a few fairly minor intersections between these patches and those patches. There is also a very minor conflict with the

Re: 2.6.20-mm2

2007-02-19 Thread Andrew Morton
On Tue, 20 Feb 2007 02:20:21 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Sunday, 18 February 2007 20:43, Andrew Morton wrote: > > On Sun, 18 Feb 2007 13:44:54 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > > wrote: > > > > > On Sunday, 18 February 2007 06:51, Andrew Morton

Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver

2007-02-19 Thread Jaya Kumar
On 2/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote: On Mon, Feb 19, 2007 at 11:13:04PM -0500, Jaya Kumar wrote: > > Ok. Here's what I'm thinking for abstracting this: > > fbdev drivers would setup fb_mmap with their own_mmap as usual. In > own_mmap, they would do what they normally do and setup a

Re: 2.6.20 kernel hang with USB drive and vfat doing ftruncate

2007-02-19 Thread Robert Hancock
Kumar Gala wrote: [ 497.499249] usb-storage D 0 671 5 773 670 (L-TLB) [ 497.506930] Call Trace: [ 497.509372] [C3F35A60] [C00083AC] __switch_to+0x28/0x40 [ 497.514608] [C3F35A80] [C01F4B78] schedule+0x324/0x6bc [ 497.519756] [C3F35AC0] [C01F5D6C]

Re: GPL vs non-GPL device drivers

2007-02-19 Thread v j
You are trying to cram this in a simple yes or no box, and it just doesn't fit. There are questions nobody knows the answers to (such as what rights you need to distribute a derivative work or whether compiling code makes a translation). Thanks, all for the discussion. I certainly learnt a lot.

Re: Serial related oops

2007-02-19 Thread Robert Hancock
Michael K. Edwards wrote: Of course not. But dealing with a stuck IRQ line by locking up isn't very practical either. IRQ sharing is stupid yet universal, and it And we don't, that's why we have that "nobody cared" logic that disables the interrupt line if no driver services the interrupt.

Re: [Linux-fbdev-devel] [PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-19 Thread Antonino A. Daplas
On Fri, 2007-02-16 at 13:24 +0100, Adrian Bunk wrote: > On Thu, Feb 15, 2007 at 03:05:26PM -0800, Randy Dunlap wrote: > > On Thu, 15 Feb 2007 22:26:10 + (GMT) James Simmons wrote: > > > > > > > > I wouldn't say it orphan. I just can't spend 8 hours a day on it. > > > Alot of patches have

Re: [PATCH] slab: ensure cache_alloc_refill terminates

2007-02-19 Thread Christoph Lameter
On Mon, 19 Feb 2007, Pekka J Enberg wrote: > If slab->inuse is corrupted, cache_alloc_refill can enter an infinite > loop as detailed by Michael Richardson in the following post: > . We have seen that corruption too. >

Re: Serial related oops

2007-02-19 Thread Michael K. Edwards
On 2/19/07, Robert Hancock <[EMAIL PROTECTED]> wrote: How do you propose to do this? Drivers can get loaded and unloaded at any time. If you have a device generating spurious interrupts on a shared IRQ line, there's no way you can use any device on that line until that interrupt is shut off.

Re: [PATCH] free swap space when (re)activating page

2007-02-19 Thread Christoph Lameter
On Fri, 16 Feb 2007, Rik van Riel wrote: > What do you think? Looks good apart from one passage (which just vanished when I tried to reply, please post patches as inline text). It was the portion that modifies shrink_active_list. Why operate on the pagevec there? The pagevec only contains the

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Douglas Gilbert
Alan Stern wrote: > On Mon, 19 Feb 2007, Douglas Gilbert wrote: > >> Alan, >> The SG_GET_RESERVED_SIZE ioctl is also defined in >> the block layer, see block/scsi_ioctl.c . > > Ah, I didn't know that. (Or more likely, I used to know and have since > forgotten.) Thanks for pointing it out. >

Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver

2007-02-19 Thread Paul Mundt
On Mon, Feb 19, 2007 at 11:13:04PM -0500, Jaya Kumar wrote: > On 2/18/07, Paul Mundt <[EMAIL PROTECTED]> wrote: > >Given that, this would have to be something that's dealt with at the > >subsystem level rather than in individual drivers, hence the desire to > >see something like this more

Re: ata command timeout

2007-02-19 Thread Marc Marais
On Tue, 20 Feb 2007 13:07:50 +0900, Tejun Heo wrote > [EMAIL PROTECTED] wrote: > > Hello, > > > > I have been running 2.6.18 for two months and the last couple of days these > > error messages have appeared in my logs > > (sata_promise kernel module, sda:SATA sdb:PATA disks): > > > >

Re: PCI riser cards and PCI irq routing, etc

2007-02-19 Thread Udo van den Heuvel
Krzysztof Halasa wrote: > Udo van den Heuvel <[EMAIL PROTECTED]> writes: > >> At the bottom I added a dmesg output of the kernel after boot. >> I more or less know that irq 20 for the DVB-S card (saa7146 (1)) is >> 'working'. I know that irq 16 for saa7146 (0) (DVB-T) is not working for >> i2c

Re: PCI riser cards and PCI irq routing, etc

2007-02-19 Thread Udo van den Heuvel
Krzysztof Halasa wrote: > Udo van den Heuvel <[EMAIL PROTECTED]> writes: > >> At the bottom I added a dmesg output of the kernel after boot. >> I more or less know that irq 20 for the DVB-S card (saa7146 (1)) is >> 'working'. I know that irq 16 for saa7146 (0) (DVB-T) is not working for >> i2c

Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver

2007-02-19 Thread Jaya Kumar
On 2/18/07, Paul Mundt <[EMAIL PROTECTED]> wrote: Given that, this would have to be something that's dealt with at the subsystem level rather than in individual drivers, hence the desire to see something like this more generically visible. Hi Peter, Paul, fbdev folk, Ok. Here's what I'm

Re: ata command timeout

2007-02-19 Thread Tejun Heo
[EMAIL PROTECTED] wrote: > Hello, > > I have been running 2.6.18 for two months and the last couple of days these > error messages have appeared in my logs > (sata_promise kernel module, sda:SATA sdb:PATA disks): > >ata1: command timeout > Feb 17

[PATCH 2.6.21-rc1] ibmebus: make root device not of_device-based

2007-02-19 Thread Hoang-Nam Nguyen
The fake root device doesn't have an associated device tree node, so it should not be an of_device. This patch makes it a normal, bus-less device and thus saves a lot of checks later on. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- ibmebus.c | 33 ++---

Re: 2.6.20: fails to turn laptop power off (ACPI?)

2007-02-19 Thread Len Brown
On Monday 19 February 2007 19:12, Jonathan Woithe wrote: > As of 2.6.20 the kernel has not been able to turn the power off on my laptop > during shutdown. Up to and including 2.6.19, pressing the power button > triggered a shutdown via the ACPI system. Under 2.6.20 (with the same > kernel

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Mon, 19 Feb 2007, Douglas Gilbert wrote: > Alan, > The SG_GET_RESERVED_SIZE ioctl is also defined in > the block layer, see block/scsi_ioctl.c . Ah, I didn't know that. (Or more likely, I used to know and have since forgotten.) Thanks for pointing it out. > I suspect it is just a kludge

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

2007-02-19 Thread Tejun Heo
Rafael J. Wysocki wrote: > Update: > > I get the same BUG with 2.6.20-git13 100% of the time during the resume. > The system seems to be fully functional nonetheless. Known bug, will be fixed soon. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: lock checking feedback (bug?) 2.6.20(xfs)/i386 during boot

2007-02-19 Thread Timothy Shimmin
Thanks for the report, Linda. This and other lockdep reports are on our todo/bug list and I've added this one. (Nathan looked at some of these lock related changes I believe and we still have a pending patch of his to go thru) --Tim --On 18 February 2007 1:38:45 PM -0800 Linda Walsh <[EMAIL

[PATCH 2/2] Use resource_size_t for serial port IO addresses

2007-02-19 Thread David Gibson
At present, various parts of the serial code use unsigned long to define resource addresses. This is a problem, because some 32-bit platforms have physical addresses larger than 32-bits, and have mmio serial uarts located above the 4GB point. This patch changes the type of mapbase in both struct

[PATCH 1/2] Define FIXED_PORT flag for serial_core

2007-02-19 Thread David Gibson
At present, the serial core always allows setserial in userspace to change the port address, irq and base clock of any serial port. That makes sense for legacy ISA ports, but not for (say) embedded ns16550 compatible serial ports at peculiar addresses. In these cases, the kernel code configuring

Use resource_size_t for serial MMIO addresses

2007-02-19 Thread David Gibson
Andrew, please apply to -mm. I think these should be good to merge for 2.6.22. At present, MMIO addresses for serial port (the ->mapbase field in uart_port and other structures) are unsigned longs. This causes problems on some 32-bit platforms which have a >32-bit physical address bus, for

Re: NCPFS and brittle connections

2007-02-19 Thread Petr Vandrovec
Pierre Ossman wrote: Sorry this took so long but I got occupied with other things and this had to move down the pile a bit. New patch which uses dedicated buffers for the currently active packet. Also adds a new state RQ_ABANDONED which basically means "the caller no longer cares about this

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-19 Thread H. Peter Anvin
Rodolfo Giometti wrote: Please read the following consideratios before sending to /dev/null! :) RFC considerations -- While implementing a PPS API as RFC 2783 defines and using an embedded CPU GPIO-Pin as physical link to the signal, I encountered a deeper problem: At

Re: Serial related oops

2007-02-19 Thread Robert Hancock
Michael K. Edwards wrote: Still open, though it's a pity you're more interested in my flawed understanding that in the possibility that the kernel could be systematically made more robust against hardware bugs and coding errors by the simple expedient of putting all the ISRs in before turning on

Re: Serial related oops

2007-02-19 Thread Michael K. Edwards
On 2/19/07, Russell King <[EMAIL PROTECTED]> wrote: This can't happen because when __do_irq unmasks the interrupt source, the CPU mask is set, thereby preventing any further interrupt exceptions being taken. This is done precisely to prevent this situation happening. If you are seeing

Re: [-mm patch] make ipc/shm.c:shm_nopage() static

2007-02-19 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > On Thu, Feb 15, 2007 at 05:14:08AM -0800, Andrew Morton wrote: >>... >> Changes since 2.6.20-rc6-mm3: >>... >> +shm-make-sysv-ipc-shared-memory-use-stacked-files.patch >>... >> Misc >>... > > > shm_nopage() can become static. Acked-by: Eric W. Biederman

Fwd: RE: Boot time Bluetooth BUG: warning: (value > m) at hid-core.c:793

2007-02-19 Thread Veronique & Vincent
Hi again Marcel and Jiri, I've set up the hid-core.c to DEBUG mode... and it literally got pretty verbose... At line 2114 we finally get the BUG message (I've attached the full dmesg also...) : 2104 drivers/usb/input/hid-core.c: report (size 8) (unnumbered) 2105 drivers/usb/input/hid-core.c:

Re: [xfs-masters] [2.6 patch] make xfs_buftarg_list static again

2007-02-19 Thread Timothy Shimmin
Hi Adrian, --On 20 February 2007 1:07:47 AM +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: xfs_buftarg_list became global for no good reason. That's true. I'll make the change for git if Dave has no objections. It happened because in the SGI tree we want it global for use in kdb by

RE: GPL vs non-GPL device drivers

2007-02-19 Thread David Schwartz
Combined responses > On 2/20/07, Michael K. Edwards <[EMAIL PROTECTED]> wrote: > > There is no legal meaning to "combining" two works of authorship under > > the Berne Convention or any national implementation thereof. If you > > "compile" or "collect" them, you're in one area of law, and if you

Re: Recent and not-so problems with tifm_sd driver

2007-02-19 Thread Alex Dubov
> > > > mmc_rescan > > mmc_register_card > > device_add > > mmc_block_probe > > mmc_block_alloc > > -> queue thread starts running > > add_disk > > -> issues a lot of requests; card fails, my drivers calls > > mmc_remove_host, which in

Re: Serial related oops

2007-02-19 Thread Russell King
On Mon, Feb 19, 2007 at 04:04:26PM -0800, Michael K. Edwards wrote: > On 2/19/07, Russell King <[EMAIL PROTECTED]> wrote: > >The second interrupt comes in, and when you go to disable that > >source, you inadvertently re-enable the UART interrupt, despite it > >still being serviced. > > Incorrect.

[PATCH RFC] libata: FUA updates

2007-02-19 Thread Robert Hancock
This updates libata FUA support to be more more in line with reality. FUA support remains off by default. Add a setting for the fua command-line parameter on libata which enables FUA only on NCQ-supporting disks. Update the ata_dev_supports_fua function to remove the blacklisting of Maxtor

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Sunday, 18 February 2007 20:43, Andrew Morton wrote: > On Sun, 18 Feb 2007 13:44:54 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > On Sunday, 18 February 2007 06:51, Andrew Morton wrote: > > > > > > Temporarily at > > > > > > http://userweb.kernel.org/~akpm/2.6.20-mm2/ > > >

[PATCH 4/5] sata_nv: Use notifier for completion checks

2007-02-19 Thread Robert Hancock
The hardware provides us a notifier register that indicates what command tags have completed. Use this to determine which CPBs to check, rather than blindly checking all active CPBs. This should provide a minor performance win, since if the controller has touched some of these incomplete CPBs,

[PATCH 3/5] sata_nv: Cleanup taskfile setup

2007-02-19 Thread Robert Hancock
This edits the taskfile setup to more closely match the way that libata sends the taskfile for other controllers. This avoids putting taskfile writes into the CPB buffer that are not needed according to the taskfile flags. Signed-off-by: Robert Hancock <[EMAIL PROTECTED]> ---

[PATCH 1/5] sata_nv: Add CPB register info to error_handler output

2007-02-19 Thread Robert Hancock
When error handling occurs with pending commands, output the contents of the next CPB count and next CPB index registers as well as the others, since these may be useful for debugging. Signed-off-by: Robert Hancock <[EMAIL PROTECTED]> --- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15

[PATCH 5/5] sata_nv: enable hotplug interrupt and fix some readl/readw mismatches

2007-02-19 Thread Robert Hancock
We already have code that handles hotplug interrupt indications in ADMA mode, this turns on the control flag that actually enables these interrupts. Also fixes some cases in the same functions where a 16-bit register was read using a readl instead of a readw. Signed-off-by: Robert Hancock

[PATCH 0/5] sata_nv: various cleanups and fixes

2007-02-19 Thread Robert Hancock
This patch series contains several fixes for issues I noticed while debugging some command timeout problems. None of these proved to be related to that issue, but they fall into the category of things we should be doing anyway. Split into separate patches to ease bisecting in case of issues.

[PATCH 2/5] sata_nv: cleanup CPB and APRD initialization

2007-02-19 Thread Robert Hancock
Clean up the initialization of the CPB and APRD structures so that we strictly follow the rules for ordering of writes to the CPB flags and response flags, and prevent duplicate initialization. Signed-off-by: Robert Hancock <[EMAIL PROTECTED]> --- linux-2.6.20-git6edit/drivers/ata/sata_nv.c

[PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-19 Thread Robert Hancock
Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has been cleaned up

Re: [2.6 patch] make xfs_buftarg_list static again

2007-02-19 Thread David Chinner
On Tue, Feb 20, 2007 at 01:07:47AM +0100, Adrian Bunk wrote: > xfs_buftarg_list became global for no good reason. Fallout from a much larger patch. Looks like there were a couple of STATIC -> static conversions stuffed up. Thanks for catching this, Adrian. Tim - another one for you ;) >

[PATCH] sata_nv: delay on switching between NCQ and non-NCQ commands

2007-02-19 Thread Robert Hancock
This patch appears to solve some problems with commands timing out in cases where an NCQ command is immediately followed by a non-NCQ command (or possibly vice versa). This is a rather ugly solution, but until we know more about why this is needed, this is about all we can do. Signed-off-by:

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Trent Waddington
On 2/20/07, Michael K. Edwards <[EMAIL PROTECTED]> wrote: And for those reading along at home, _surely_ you understand the meanings of "ambiguities in an offer of contract must be construed against the offeror", "'derivative work' and 'license' are terms of art in copyright law", and "not a

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Michael K. Edwards
And for those reading along at home, _surely_ you understand the meanings of "ambiguities in an offer of contract must be construed against the offeror", "'derivative work' and 'license' are terms of art in copyright law", and "not a valid limitation of scope". If not, I highly recommend to you

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Trent Waddington
On 2/20/07, Michael K. Edwards <[EMAIL PROTECTED]> wrote: No, dear, I'm just not interested in convincing you if you can't be bothered to look back in the thread and Google a bit. Think of it as a penny ante, which is pretty cheap in a card game with billion-dollar table stakes. Well, with

Re: [-mm patch] fs/9p/vfs_addr.c: make 2 functions static

2007-02-19 Thread Eric Van Hensbergen
On 2/19/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Sat, Feb 17, 2007 at 09:51:46PM -0800, Andrew Morton wrote: >... > Changes since 2.6.20-mm1: >... > git-v9fs.patch >... > git trees >... This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL

Re: freezer problems

2007-02-19 Thread Oleg Nesterov
On 02/20, Rafael J. Wysocki wrote: > > BTW, what do you think of the updated patch I sent two messages ago? Ah, sorry, I just forgot... I think it is nice. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Michael K. Edwards
On 2/19/07, Trent Waddington <[EMAIL PROTECTED]> wrote: that's what I figured yes, as you're obviously not interested in convincing anyone of your opinions, otherwise you wouldn't mind repeating yourself when someone asks you a simple question. No, dear, I'm just not interested in convincing

Re: 2.6.20-mm2

2007-02-19 Thread Rafael J. Wysocki
On Monday, 19 February 2007 01:00, Andrew Morton wrote: > On Mon, 19 Feb 2007 00:25:48 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > > netconsole is good. > > > > I know. :-) > > > > In the meantime, I've got something worse on another x86_64 box: > > > > Asus Laptop ACPI

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-19 Thread Ayaz Abdulla
Robert Hancock wrote: Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Ayaz --- This email message is for the sole use of the intended recipient(s) and may

Re: Linux 2.6.16.41

2007-02-19 Thread Greg KH
On Tue, Feb 20, 2007 at 01:01:10AM +0100, Adrian Bunk wrote: > On Mon, Feb 19, 2007 at 03:48:46PM -0800, Greg KH wrote: > > On Sun, Feb 18, 2007 at 02:14:07AM +0100, Adrian Bunk wrote: > > > Herbert Xu (1): > > > [NETFILTER]: Clear GSO bits for TCP reset packet > > > > This patch causes the

Re: [2.6 patch] drivers/char/hvc_console.c: cleanups

2007-02-19 Thread Stephen Rothwell
On Tue, 20 Feb 2007 01:02:07 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > This patch contains the following cleanups: > - make needlessly global code static > - remove the unused EXPORT_SYMBOL's > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Stephen Rothwell <[EMAIL PROTECTED]>

RHEL3 2.4.21-37a6smp 10GBps Intel 10GBps NIC: ixgb_clean_tx_irq: Detected Tx Unit Hang - Machine locks up.

2007-02-19 Thread Justin Piszcz
Quick question, I am using the latest ixgb driver (1.0.126) as stated both on Intel's website and here: http://sourceforge.net/forum/forum.php?forum_id=645203 After a number of hours, sometimes days, I will get this error on the console and the box locks up: ixgb: eth2: ixgb_clean_tx_irq:

Re: x86_64: up to 255 or 256 CPUs?

2007-02-19 Thread William Lee Irwin III
On Tue, Feb 20, 2007 at 01:06:47AM +0100, Adrian Bunk wrote: > Quoting arch/x86_64/Kconfig: > <-- snip --> > ... > config NR_CPUS > int "Maximum number of CPUs (2-256)" > range 2 255 > ... > <-- snip --> > cu > Adrian The broadcast APIC ID clashes with the 256th cpu. -- wli

Re: [2.6 patch] proper prototype for hugetlb_get_unmapped_area()

2007-02-19 Thread William Lee Irwin III
On Tue, Feb 20, 2007 at 01:06:34AM +0100, Adrian Bunk wrote: > This patch adds a proper prototype for hugetlb_get_unmapped_area() in > include/linux/hugetlb.h. > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > This patch was already sent on: > - 25 Nov 2006 > fs/hugetlbfs/inode.c|5

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-19 Thread Robert Hancock
Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Ayaz --- This email message is for the sole use of the intended recipient(s) and may contain confidential

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Trent Waddington
On 2/20/07, Michael K. Edwards <[EMAIL PROTECTED]> wrote: Can we put the gamesmanship on "low" here for a moment? Ask yourself which is more likely: am I a crank who spends years researching the legal background of the GPL solely for the purpose of ranting incoherently on debian-legal and LKML,

Re: freezer problems

2007-02-19 Thread Rafael J. Wysocki
On Tuesday, 20 February 2007 01:12, Oleg Nesterov wrote: > On 02/20, Rafael J. Wysocki wrote: > > > > On Monday, 19 February 2007 23:41, Oleg Nesterov wrote: > > > On 02/19, Rafael J. Wysocki wrote: > > > > > > > > On Monday, 19 February 2007 21:23, Oleg Nesterov wrote: > > > > > > > > > > @@

Re: [ANNOUNCE] DualFS: File System with Meta-data and Data Separation

2007-02-19 Thread Jörn Engel
On Tue, 20 February 2007 00:57:50 +0100, Juan Piernas Canovas wrote: > > I understand the problem that you describe with respect to the GC, but > let me explain why I think that it has a small impact on DualFS. > > Actually, the GC may become a problem when the number of free segments is > 50%

Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Chris Mason
On Mon, Feb 19, 2007 at 07:21:09PM -0500, Benjamin LaHaise wrote: > On Mon, Feb 19, 2007 at 04:50:48PM -0500, Chris Mason wrote: > > aio is not responsible for this particular synchronization. Those fixes > > (if we make them) should come from other places. The patch is important > > to get aio

Re: [-mm patch] {rd,wr}msr_on_cpu SMP=n optimization

2007-02-19 Thread Dave Jones
On Tue, Feb 20, 2007 at 01:21:45AM +0100, Adrian Bunk wrote: > On Mon, Feb 19, 2007 at 07:14:34PM -0500, Dave Jones wrote: > > On Tue, Feb 20, 2007 at 01:07:13AM +0100, Adrian Bunk wrote: > >... > > > +#ifdef CONFIG_SMP > > > void rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h);

Re: GPL vs non-GPL device drivers

2007-02-19 Thread Michael K. Edwards
On 2/19/07, Trent Waddington <[EMAIL PROTECTED]> wrote: Hang on, you're actually debating that you have to abide by conditions of a license before you can copy a copyright work? Please, tell us the names of these appellate court decisions so that we can read them and weep. Can we put the

Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Zach Brown
I would argue that one common cause of the EIO is userland error (mmap concurrent with O_DIRECT), and EIO is the correct answer. I disagree. That means that using the pagecache to synchronize things like the proposed online defragmentation will occasionally make O_DIRECT users fail.

[-mm patch] drivers/net/vioc/: possible cleanups

2007-02-19 Thread Adrian Bunk
On Thu, Feb 15, 2007 at 05:14:08AM -0800, Andrew Morton wrote: >... > Changes since 2.6.20-rc6-mm3: >... > +Fabric7-VIOC-driver.patch >... > netdev stuff >... This patch contains the following possible cleanups: - remove dead #ifdef EXPORT_SYMTAB code - no "inline" functions in C files - gcc

[2.6 patch] kill net/rxrpc/rxrpc_syms.c

2007-02-19 Thread Adrian Bunk
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the files with the actual functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 26 Nov 2006 net/rxrpc/Makefile |1 - net/rxrpc/call.c |5 +

[2.6 patch] arch/i386/kernel/alternative.c should #include

2007-02-19 Thread Adrian Bunk
Every file should include the headers containing the prototypes for it's global functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 18 Jan 2007 - 4 Jan 2007 --- linux-2.6.20-rc2-mm1/arch/i386/kernel/alternative.c.old 2007-01-03

Re: [-mm patch] {rd,wr}msr_on_cpu SMP=n optimization

2007-02-19 Thread Adrian Bunk
On Mon, Feb 19, 2007 at 07:14:34PM -0500, Dave Jones wrote: > On Tue, Feb 20, 2007 at 01:07:13AM +0100, Adrian Bunk wrote: >... > > +#ifdef CONFIG_SMP > > void rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h); > > void wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h); > >

Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Benjamin LaHaise
On Mon, Feb 19, 2007 at 04:50:48PM -0500, Chris Mason wrote: > aio is not responsible for this particular synchronization. Those fixes > (if we make them) should come from other places. The patch is important > to get aio error handling right. > > I would argue that one common cause of the EIO

  1   2   3   4   5   6   7   8   9   >