Re: Wasting our Freedom

2007-09-17 Thread Hannah Schroeter
Hello! On Sun, Sep 16, 2007 at 03:19:41PM -0700, David Schwartz wrote: >[...] >If you take work that's under a dual-license and remove one license notice >from it when you create a derivative work, every recipient of that >derivative work still receives a dual license from the original author to

Re: Scheduler benchmarks - a follow-up

2007-09-17 Thread Ed Tomlinson
Rob, I gather this was with the complete -ck patchset? It would be interesting to see if just SD performed as well. If it does, CFS needs more work. if not there are other things in -ck that really do improve performance and should be looked into. Thanks Ed Tomlinson On September 17, 2007,

Re: Wasting our Freedom

2007-09-17 Thread Hannah Schroeter
Hello! On Sun, Sep 16, 2007 at 05:12:08PM -0400, Theodore Tso wrote: >[...] >What is going on whenever someone changes a code is that they make a >"derivative work". Only if the additions/changes are significant enough to be copyrightable on their own. >Whether or not you can even make a

Re: X freezes kernel during exit [Re: 2.6.23-rc3-mm1]

2007-09-17 Thread Jiri Slaby
On 09/09/2007 04:43 PM, Jiri Slaby wrote: > On 09/09/2007 04:33 PM, Andi Kleen wrote: >> On Sun, Sep 09, 2007 at 04:26:22PM +0200, Jiri Slaby wrote: >>> BTW it is reproducible for me on two different machines (i386-x86_64, >>> radeon-intel), don't you have the problem too? >> No problems here with

[git patches] IDE fixes

2007-09-17 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-disk.c |1 + drivers/ide/ppc/pmac.c |2 -- 2 files changed, 1 insertions(+), 2 deletions(-) Jorge Juan Chico (1): ide: ST320413A has the same

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 11:56:00 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > checkpatch generates a pile of warnings, all of which afacit are legit. > > For this warning: > > ERROR: need space after that ',' (ctx:WxV) > #627: FILE: security/keys/internal.h:28: > +#define kenter(FMT, ...)

Re: Credentials test patch

2007-09-17 Thread David Howells
Ulrich Drepper <[EMAIL PROTECTED]> wrote: > In sys_faccessat you temporarily allocate a cred object which is > discarded in the end. With a few more macro definitions you could > create a dup_cred variant which initialized an automatic variable of > type struct cred. This way the kmalloc/kfree

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > So who's going to review this? Nobody? Well gee, maybe it was my turn > anyway. Well, Kevin Coffman has reviewed it and tested it against his NFS keys patches. > checkpatch generates a pile of warnings, all of which afacit are legit. For this

Re: [PATCH]PCI:disable resource decode in PCI BAR detection

2007-09-17 Thread Ivan Kokshaysky
On Sun, Sep 16, 2007 at 10:01:52PM +0200, Benjamin Herrenschmidt wrote: > Agreed. I have a similar problem on ppc where it's common to have things > like the main PIC on a PCI device. Note that another problem is (or at > least was, i haven't checked recently) the P2P bridge scanning code > that,

Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-17 Thread Mel Gorman
On (16/09/07 23:31), Andrea Arcangeli didst pronounce: > On Sun, Sep 16, 2007 at 09:54:18PM +0100, Mel Gorman wrote: > > The 16MB is the size of a hugepage, the size of interest as far as I am > > concerned. Your idea makes sense for large block support, but much less > > for huge pages because

Re: iunique() fails to return ino_t (after commit 866b04fccbf125cd)

2007-09-17 Thread Jeff Layton
On Mon, 17 Sep 2007 08:06:15 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > On 9/17/07, Jeff Layton <[EMAIL PROTECTED]> wrote: > > On Mon, 17 Sep 2007 00:58:54 +0530 > > "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > > > > > Hi Jeff, > > > > > > I think commit

Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-17 Thread Mel Gorman
On (16/09/07 23:58), Goswin von Brederlow didst pronounce: > [EMAIL PROTECTED] (Mel Gorman) writes: > > > On (15/09/07 14:14), Goswin von Brederlow didst pronounce: > >> Andrew Morton <[EMAIL PROTECTED]> writes: > >> > >> > On Tue, 11 Sep 2007 14:12:26 +0200 Jörn Engel <[EMAIL PROTECTED]> wrote:

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Jeff Garzik
Tejun Heo wrote: [cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ > + if (qc->nbytes < 2048) > + return -EOPNOTSUPP; > + > /* No ATAPI DMA in smart mode */ > if (itdev->smart) > return -EOPNOTSUPP; > This looks like a gross hack. Aren't you

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-17 Thread Takashi Iwai
At Fri, 14 Sep 2007 18:48:05 +0100, Denys Vlasenko wrote: > > Hi Takashi, > > There is a lot of data structures in that code, > and most of them seems to be read-only. > > I added const modifiers to most of such places: > >textdata bss dec hex filename > 106315 179564

kernel thread id

2007-09-17 Thread Yishai Hadas
Hi List, I'm using NPTL multi-threaded library and kernel 2.4. When a new thread is created using the pthread_create call the returned thread handle is pthread_t. I want to get the kernel thread id for this pthread - means similar to what gettid returns when it's called by the thread itself.

Re: ata_piix, laptop cdrom, ICH7: EH, limiting speed to PIO

2007-09-17 Thread Sergey Dolgov
On 9/16/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Michal Piotrowski wrote: > > Sergey Dolgov pisze: > >> On Wed, Sep 12, 2007 at 10:19:03PM +0200, Michal Piotrowski wrote: > >>> Sergey Dolgov pisze: > Hi Michal, > > On Wed, Sep 12, 2007 at 06:33:20PM +0200, Michal Piotrowski wrote:

Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module.

2007-09-17 Thread Johannes Berg
On Sa, 2007-09-15 at 21:00 +0200, Eric Valette wrote: > I came to this conclusion too. But I would have preferred to have > #define subsys_exit(fn) modules_exit(fn) > > in the case of a module and nop in the non module case... module_exit is a no-op anyway in the

Re: [PATCH] kexec: reenable HPET before kexec

2007-09-17 Thread Konstantin Baydarov
On Fri, 31 Aug 2007 14:31:51 +0400 Konstantin Baydarov <[EMAIL PROTECTED]> wrote: > On Thu, 30 Aug 2007 12:04:33 -0600 > [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > > I was assuming that CLOCK_EVT_MODE_SHUTDOWN just mapped > > to the shutdown method of the clock events or something else. >

Re: cpuset trouble after hibernate

2007-09-17 Thread Pavel Machek
Hi! > This is my situation: > - I mounted the pseudo cpuset filesystem into /dev/cpuset > - I created a cpuset named oar with my 2 cpus > > cat /dev/cpuset/oar/cpus > 0-1 > > - Then I hibernate my computer with 'echo -n "disk" >/sys/power/state' > - After reboot: > > cat

Re: Wasting our Freedom

2007-09-17 Thread Henning Brauer
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> [2007-09-17 02:29]: > you claim that it's unethical for the linux community to use the code, but > brag about NetApp useing the code. what makes NetApp ok and Linux evil? NetApp does not pretend to be free and open and save the world etc -- Henning

Re: [PATCH]PCI:disable resource decode in PCI BAR detection

2007-09-17 Thread Ivan Kokshaysky
On Sun, Sep 16, 2007 at 01:52:59PM -0600, Matthew Wilcox wrote: > I don't think it would be that complicated. We could just delay probing > for mmconfig until after the pci bus probes are done. No changes to > other architectures needed. Indeed. Seems like it's a way to go. > I'm really

Radeonfb Xpress 200M RC410 support patch

2007-09-17 Thread Sellout Bessie
Ok, notthing special, and this is my first pqatch so forgive me if my method is off, however the following makes radeonfb work ith the 200m Xpress RC410. In my tests it was terribly unstable and would freeze until I set a refresh rate in the kernel argument to 75. e.g video=radeonfb:[EMAIL

Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-17 Thread Mel Gorman
On (17/09/07 00:48), Goswin von Brederlow didst pronounce: > [EMAIL PROTECTED] (Mel Gorman) writes: > > > On (16/09/07 17:08), Andrea Arcangeli didst pronounce: > >> zooming in I see red pixels all over the squares mized with green > >> pixels in the same square. This is exactly what happens with

Re: Wasting our Freedom

2007-09-17 Thread Hannah Schroeter
Hi! On Sun, Sep 16, 2007 at 11:13:51PM +0200, Adrian Bunk wrote: >On Sun, Sep 16, 2007 at 10:39:26PM +0200, Hannah Schroeter wrote: >> On Sun, Sep 16, 2007 at 09:59:09PM +0200, Adrian Bunk wrote: >> >On Sun, Sep 16, 2007 at 11:48:47AM -0700, Can E. Acar wrote: >> >>... >> >> First, these

Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

2007-09-17 Thread Avi Kivity
Christoph Hellwig wrote: > On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote: > >> From: Nguyen Anh Quynh <[EMAIL PROTECTED]> >> >> *nopage() in kvm_main.c should only store the type of mmap() fault if >> the pointers are not NULL. This patch fixes the problem. >> > > Care to

Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

2007-09-17 Thread Avi Kivity
Avi Kivity wrote: > Christoph Hellwig wrote: > >> On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote: >> >> >>> From: Nguyen Anh Quynh <[EMAIL PROTECTED]> >>> >>> *nopage() in kvm_main.c should only store the type of mmap() fault if >>> the pointers are not NULL. This patch

Re: [PATCH]PCI:disable resource decode in PCI BAR detection

2007-09-17 Thread Ivan Kokshaysky
On Sun, Sep 16, 2007 at 11:34:35AM -0600, Robert Hancock wrote: > > The most interesting fact there is that windows *does not* clear > > PCI_COMMAND_MEMORY bits during PCI bus enumeration, so BIOS writers > > have to rely on that. Yet another reason why your patch is unsafe. > > Windows 98

Re: Wasting our Freedom

2007-09-17 Thread Hannah Schroeter
Hi! On Sun, Sep 16, 2007 at 05:11:05PM -0400, Daniel Hazelton wrote: >On Sunday 16 September 2007 16:39:26 Hannah Schroeter wrote: >> On Sun, Sep 16, 2007 at 09:59:09PM +0200, Adrian Bunk wrote: >> >On Sun, Sep 16, 2007 at 11:48:47AM -0700, Can E. Acar wrote: >> >>... >> >> First, these

Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

2007-09-17 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote: > From: Nguyen Anh Quynh <[EMAIL PROTECTED]> > > *nopage() in kvm_main.c should only store the type of mmap() fault if > the pointers are not NULL. This patch fixes the problem. Care to convert it to ->faul while you're at it? - To

[PATCH -rc] KVM: Fix virtualization menu help text

2007-09-17 Thread Avi Kivity
What guest drivers? Cc: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- An August 18 patch from Jan Engelhardt (06bfb7e) added help text for the virtualization menu. Unfortunately the text is misleading, as "guest drivers" are usually interpreted to mean

Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-17 Thread Mel Gorman
On (17/09/07 00:38), Goswin von Brederlow didst pronounce: > [EMAIL PROTECTED] (Mel Gorman) writes: > > > On (15/09/07 02:31), Goswin von Brederlow didst pronounce: > >> Mel Gorman <[EMAIL PROTECTED]> writes: > >> > >> > On Fri, 2007-09-14 at 18:10 +0200, Goswin von Brederlow wrote: > >> >> Nick

Re: [PATCH] x86: constify stacktrace_ops

2007-09-17 Thread Jan Beulich
>>> Andrew Morton <[EMAIL PROTECTED]> 16.09.07 12:18 >>> >On Mon, 10 Sep 2007 14:02:17 +0100 "Jan Beulich" <[EMAIL PROTECTED]> wrote: > >> .. as they're never written to. > >arch/i386/kernel/traps.c: In function 'dump_trace': >arch/i386/kernel/traps.c:197: warning: initialization discards

Re: RFC: incorrect results from RTC reading method

2007-09-17 Thread Torsten Duwe
On Thursday 13 September 2007, Bob Montgomery wrote: > I think any method for reading the RTC must consider the (Update In > Progress) flag to avoid bogus results. This is a really good idea, I wonder if this has been tried before... But seriously, the RTC driver does that, and the boot process

Re: [PATCH] tristate choices with mixed tristate and boolean values

2007-09-17 Thread Jan Beulich
>>> Roman Zippel <[EMAIL PROTECTED]> 16.09.07 19:29 >>> >On Mon, 10 Sep 2007, Jan Beulich wrote: > >> --- linux-2.6.23-rc5/scripts/kconfig/menu.c 2007-09-07 16:48:23.0 >> +0200 >> +++ 2.6.23-rc5-tristate-choices/scripts/kconfig/menu.c 2007-09-03 >> 10:29:41.0 +0200 >> @@

Re: increase AT_VECTOR_SIZE to terminate saved_auxv properly

2007-09-17 Thread Olaf Hering
On Sat, Sep 15, Jakub Jelinek wrote: > > If AT_NULL is required, AT_VECTOR_SIZE should be changed from 44 to 46. > > No, it should be computed instead from the number of target independent aux > vector pairs and then from an per-arch macro which says how many arch > specific aux vector pairs are

Re: [RFC -mm 0/2] i386/x86_64 boot: 32-bit boot protocol

2007-09-17 Thread Huang, Ying
On Mon, 2007-09-17 at 10:40 +0200, Andi Kleen wrote: > On Monday 17 September 2007 10:26:12 Huang, Ying wrote: > > For machine with some new BIOS other than legacy BIOS, such as EFI, > > LinuxBIOS, etc, and kexec, the 16-bit real mode setup code in kernel > > based on legacy BIOS can not be used,

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-17 Thread Markus Rechberger
On 9/15/07, Bernard Jungen <[EMAIL PROTECTED]> wrote: > On Sat, Sep 15, 2007 at 11:04:42AM -0300, Mauro Carvalho Chehab wrote: > > With respect to your kernel-userspace API for xc3028, you made something > > that seemed to be a dream: there's a consensus: not a single developer > > believed that

Re: [RFC -mm 0/2] i386/x86_64 boot: 32-bit boot protocol

2007-09-17 Thread Andi Kleen
On Monday 17 September 2007 10:26:12 Huang, Ying wrote: > For machine with some new BIOS other than legacy BIOS, such as EFI, > LinuxBIOS, etc, and kexec, the 16-bit real mode setup code in kernel > based on legacy BIOS can not be used, so a 32-bit boot protocol need > to be defined. The patch

[PATCH 008/104] KVM: Trivial: Comment spelling may escape grep

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> Speling error in comment. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c

[PATCH 014/104] KVM: Set exit_reason to KVM_EXIT_MMIO where run->mmio is initialized.

2007-09-17 Thread Avi Kivity
From: Jeff Dike <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |2 +- drivers/kvm/svm.c |1 - drivers/kvm/vmx.c |1 - 3 files changed, 1 insertions(+), 3 deletions(-) diff --git

[PATCH 011/104] KVM: Use standard CR3 flags, tighten checking

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> The kernel now has asm/cpu-features.h: use those macros instead of inventing our own. Also spell out definition of CR3_RESEVED_BITS, fix spelling and tighten it for the non-PAE case. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi

[PATCH 015/104] KVM: Use standard CR8 flags, and fix TPR definition

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> Intel manual (and KVM definition) say the TPR is 4 bits wide. Also fix CR8_RESEVED_BITS typo. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Acked-by: H. Peter Anvin <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 012/104] KVM: Use standard CR4 flags, tighten checking

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> On this machine (Intel), writing to the CR4 bits 0x0800 and 0x1000 cause a GPF. The Intel manual is a little unclear, but AFIACT they're reserved, too. Also fix spelling of CR4_RESEVED_BITS. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>

[PATCH 023/104] KVM: load_pdptrs() cleanups

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> load_pdptrs can be handed an invalid cr3, and it should not oops. This can happen because we injected #gp in set_cr3() after we set vcpu->cr3 to the invalid value, or from kvm_vcpu_ioctl_set_sregs(), or memory configuration changes after the guest did

[PATCH 018/104] KVM: Return if the pdptrs are invalid when the guest turns on PAE.

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> Don't fall through and turn on PAE in this case. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH 021/104] KVM: VMX: Import some constants of vmcs from IA32 SDM

2007-09-17 Thread Avi Kivity
From: Yang, Sheng <[EMAIL PROTECTED]> This patch mainly imports some constants and rename two exist constants of vmcs according to IA32 SDM. It also adds two constants to indicate Lock bit and Enable bit in MSR_IA32_FEATURE_CONTROL, and replace the hardcode _5_ with these two bits.

[PATCH 016/104] KVM: x86 emulator: fix cmov for writeback changes

2007-09-17 Thread Avi Kivity
The writeback fixes (02c03a326a5df825cc01de426f72e160db2b9538) broke cmov emulation. Fix. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/kvm/x86_emulate.c

[PATCH 029/104] KVM: Convert vm lock to a mutex

2007-09-17 Thread Avi Kivity
From: Shaohua Li <[EMAIL PROTECTED]> This allows the kvm mmu to perform sleepy operations, such as memory allocation. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 +- drivers/kvm/kvm_main.c | 69

[PATCH 026/104] KVM: VMX: Improve the method of writing vmcs control

2007-09-17 Thread Avi Kivity
From: Yang, Sheng <[EMAIL PROTECTED]> Put cpu feature detecting part in hardware_setup, and stored the vmcs condition in global variable for further check. [glommer: fix for some i386-only machines not supporting CR8 load/store exiting] Signed-off-by: Sheng Yang <[EMAIL PROTECTED]>

[PATCH 043/104] KVM: SVM: Make set_msr_interception more reliable

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> set_msr_interception() is used by svm to set up which MSRs should be intercepted. It can only fail if someone has changed the code to try to intercept an MSR without updating the array of ranges. The return value is ignored anyway: it should just BUG() if

[PATCH 035/104] KVM: Change the emulator_{read,write,cmpxchg}_* functions to take a vcpu

2007-09-17 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> ... instead of a x86_emulate_ctxt, so that other callers can use it easily. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c| 25 +++--

[PATCH 024/104] KVM: Remove arch specific components from the general code

2007-09-17 Thread Avi Kivity
From: Gregory Haskins <[EMAIL PROTECTED]> struct kvm_vcpu has vmx-specific members; remove them to a private structure. Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |

[PATCH 044/104] KVM: Remove redundant alloc_vmcs_cpu declaration

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> alloc_vmcs_cpu is already declared (static) above, no need to redeclare. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff

[PATCH 046/104] KVM: Remove stat_set from debugfs

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> We shouldn't define stat_set on the debug attributes, since that will cause silent failure on writing: without a set argument, userspace will get -EACCESS. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 036/104] KVM: Remove kvm_{read,write}_guest()

2007-09-17 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> ... in favor of the more general emulator_{read,write}_*. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h | 17 +-- drivers/kvm/kvm_main.c | 74

[PATCH 031/104] KVM: VMX: pass vcpu_vmx internally

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> container_of is wonderful, but not casting at all is better. This patch changes vmx.c's internal functions to pass "struct vcpu_vmx" instead of "struct kvm_vcpu" and using container_of. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi

[PATCH 028/104] KVM: Use the scheduler preemption notifiers to make kvm preemptible

2007-09-17 Thread Avi Kivity
Current kvm disables preemption while the new virtualization registers are in use. This of course is not very good for latency sensitive workloads (one use of virtualization is to offload user interface and other latency insensitive stuff to a container, so that it is easier to analyze the

[PATCH 050/104] KVM: VMX: Remove a duplicated ia32e mode vm entry control

2007-09-17 Thread Avi Kivity
From: Li, Xin B <[EMAIL PROTECTED]> Remove a duplicated ia32e mode VM Entry control definition and use the proper one. Signed-off-by: Xin Li <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c |8 drivers/kvm/vmx.h |3 --- 2 files changed, 4

[PATCH 055/104] KVM: Communicate cr8 changes to userspace

2007-09-17 Thread Avi Kivity
From: Yang, Sheng <[EMAIL PROTECTED]> This allows running 64-bit Windows. Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c |3 ++- include/linux/kvm.h |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git

[PATCH 056/104] KVM: x86 emulator: implement 'and $imm, %{al|ax|eax}'

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction and al imm8 (opcode 0x24) and ax/eax imm16/imm32 (opcode 0x25) Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 21

[PATCH 052/104] KVM: Cleanup string I/O instruction emulation

2007-09-17 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> Both vmx and svm decode the I/O instructions, and both botch the job, requiring the instruction prefixes to be fetched in order to completely decode the instruction. So, if we see a string I/O instruction, use the x86 emulator to decode it, as it already

[PATCH 057/104] KVM: x86 emulator: implement 'jmp rel' instruction (opcode 0xe9)

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/kvm/x86_emulate.c

[PATCH 062/104] KVM: X86 emulator: fix 'push reg' writeback

2007-09-17 Thread Avi Kivity
Pointed out by Rusty Russell. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c index cf895aa..7439b34 100644 --- a/drivers/kvm/x86_emulate.c

[PATCH 059/104] KVM: x86 emulator: implement 'push reg' (opcodes 0x50-0x57)

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/x86_emulate.c

[PATCH 082/104] KVM: Set the ET flag in CR0 after initializing FX

2007-09-17 Thread Avi Kivity
From: Amit Shah <[EMAIL PROTECTED]> This was missed when moving stuff around in fbc4f2e Fixes Solaris guests and bug #1773613 Signed-off-by: Amit Shah <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 074/104] KVM: pending irq save/restore

2007-09-17 Thread Avi Kivity
From: Eddie Dong <[EMAIL PROTECTED]> Add in kernel irqchip save/restore support for pending vectors. Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> Signed-off-by: Qing He <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 ++

[PATCH 083/104] KVM: Remove the unused invlpg member of struct kvm_arch_ops.

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 - drivers/kvm/svm.c |6 -- 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/kvm/kvm.h

[PATCH 084/104] KVM: Clean up unloved invlpg emulation

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> invlpg shouldn't fetch the "src" address, since it may not be valid, however SVM's "solution" which neuters emulation of all group 7 instruction is horrible and breaks kvm-lite. The simplest fix is to put a special check in for invlpg. Signed-off-by:

[PATCH 081/104] KVM: enable in-kernel APIC INIT/SIPI handling

2007-09-17 Thread Avi Kivity
From: He, Qing <[EMAIL PROTECTED]> This patch enables INIT/SIPI handling using in-kernel APIC by introducing a ->mp_state field to emulate the SMP state transition. [avi: remove smp_processor_id() warning] Signed-off-by: Qing He <[EMAIL PROTECTED]> Signed-off-by: Xin Li <[EMAIL PROTECTED]>

[PATCH 085/104] KVM: Keep control regs in sync

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> We don't update the vcpu control registers in various places. We should do so. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |8 1 files changed, 4 insertions(+), 4

[PATCH 092/104] KVM: VMX: Fix exit qualification width on i386

2007-09-17 Thread Avi Kivity
From: He, Qing <[EMAIL PROTECTED]> According to Intel Software Developer's Manual, Vol. 3B, Appendix H.4.2, exit qualification should be of natural width. However, current code uses u64 as the data type for this register, which occasionally introduces invalid value to VMExit handling logics. This

[PATCH 086/104] KVM: Hoist SVM's get_cs_db_l_bits into core code.

2007-09-17 Thread Avi Kivity
From: Rusty Russell <[EMAIL PROTECTED]> SVM gets the DB and L bits for the cs by decoding the segment. This is in fact the completely generic code, so hoist it for kvm-lite to use. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 093/104] KVM: x86 emulator: push imm8

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement the instruction push imm8 opcode: 0x6a Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 17 ++--- 1 files changed, 14 insertions(+), 3

[PATCH 091/104] KVM: Move main vcpu loop into subarch independent code

2007-09-17 Thread Avi Kivity
This simplifies adding new code as well as reducing overall code size. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |9 +++- drivers/kvm/kvm_main.c | 124 +- drivers/kvm/svm.c | 142

[PATCH 095/104] KVM: x86 emulator: pushf

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction pushf opcode: 0x9c Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 11 +-- 1 files changed, 9 insertions(+), 2

[PATCH 094/104] KVM: x86 emulator: call near

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction opcode: 0xe8 call (near) Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 22 +- 1 files changed, 21

[PATCH 097/104] KVM: x86 emulator: sort opcodes into ascending order

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 99 ++--- 1 files changed, 49 insertions(+), 50 deletions(-) diff --git

[PATCH 096/104] KVM: Improve emulation failure reporting

2007-09-17 Thread Avi Kivity
Report failed opcodes from all locations. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/kvm_main.c | 16 drivers/kvm/svm.c |2 +- drivers/kvm/vmx.c |2 +- 4 files changed, 11 insertions(+), 10 deletions(-)

[PATCH 103/104] KVM: x86 emulator: popf

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction: popf opcode: 0x9d Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-)

[PATCH 099/104] KVM: X86 emulator: jump conditional short

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of more jump conditional instructions jcc shortrel opcodes: 0x70 - 0x7f Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 15 +-- 1

[PATCH 102/104] KVM: x86 emulator: fix src, dst value initialization

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Some operand fetches are less than the machine word size and can result in stale bits if used together with operands of different sizes. Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 100/104] KVM: x86 emulator: lea

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction lea r16/r32, m opcode: 0x8d: Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |5 - 1 files changed, 4 insertions(+), 1

[PATCH 101/104] KVM: x86 emulator: jmp abs

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction: jump absolute r/m opcode: 0xff /4 Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c |6 ++ 1 files changed, 6 insertions(+), 0

[PATCH 088/104] KVM: Rename kvm_arch_ops to kvm_x86_ops

2007-09-17 Thread Avi Kivity
From: Christian Ehrhardt <[EMAIL PROTECTED]> This patch just renames the current (misnamed) _arch namings to _x86 to ensure better readability when a real arch layer takes place. Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> ---

[PATCH 098/104] KVM: x86 emulator: imlpement jump conditional relative

2007-09-17 Thread Avi Kivity
From: Nitin A Kamble <[EMAIL PROTECTED]> Implement emulation of instruction: jump conditional rel opcodes: 0x0f 0x80 - 0x0f 0x8f Signed-off-by: Nitin A Kamble <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/x86_emulate.c | 61

[PATCH 087/104] KVM: Simplify memory allocation

2007-09-17 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> The mutex->splinlock convertion alllows us to make some code simplifications. As we can keep the lock longer, we don't have to release it and then have to check if the environment has not been modified before re-taking it. We can remove kvm->busy and

[PATCH 090/104] KVM: VMX: Move vm entry failure handling to the exit handler

2007-09-17 Thread Avi Kivity
This will help moving the main loop to subarch independent code. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 57a6055..713f78a 100644 ---

[PATCH 080/104] KVM: round robin for APIC lowest priority delivery mode

2007-09-17 Thread Avi Kivity
From: He, Qing <[EMAIL PROTECTED]> Signed-off-by: Qing He <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/lapic.c | 33 - 2 files changed, 29 insertions(+), 5 deletions(-) diff --git

[PATCH 089/104] KVM: MMU: Don't do GFP_NOWAIT allocations

2007-09-17 Thread Avi Kivity
Before preempt notifiers, kvm needed to allocate memory with GFP_NOWAIT so as not to have to enable preemption and take a heavyweight exit. On oom, we'd fall back to a GFP_KERNEL allocation. With preemption notifiers, we can do a GFP_KERNEL allocation, and perform the heavyweight exit only if

[PATCH 079/104] KVM: deliver PIC interrupt only to vcpu0

2007-09-17 Thread Avi Kivity
From: Qing He <[EMAIL PROTECTED]> This patch changes the PIC interrupts delivery. Now it is only delivered to vcpu0 when either condition is met (on vcpu0): 1. local APIC is hardware disabled 2. LVT0 is unmasked and configured to delivery mode ExtInt It fixes the 2x faster wall clock on

[PATCH 076/104] KVM: Keep track of missed timer irq injections

2007-09-17 Thread Avi Kivity
From: Eddie Dong <[EMAIL PROTECTED]> APIC timer IRQ is set every time when a certain period expires at host time, but the guest may be descheduled at that time and thus the irq be overwritten by later fire. This patch keep track of firing irq numbers and decrease only when the IRQ is injected to

[PATCH 078/104] KVM: disable tpr/cr8 sync when in-kernel APIC is used

2007-09-17 Thread Avi Kivity
From: He, Qing <[EMAIL PROTECTED]> Signed-off-by: Qing He <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index f4cbd4f..a25dfc9

[PATCH 075/104] KVM: VMX: Use shadow TPR/cr8 for 64-bits guests

2007-09-17 Thread Avi Kivity
From: Yang, Sheng <[EMAIL PROTECTED]> This patch enables TPR shadow of VMX on CR8 access. 64bit Windows using CR8 access TPR frequently. The TPR shadow can improve the performance of access TPR by not causing vmexit. Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> Signed-off-by: Yaozu (Eddie) Dong

[PATCH 066/104] KVM: Emulate local APIC in kernel

2007-09-17 Thread Avi Kivity
From: Eddie Dong <[EMAIL PROTECTED]> Because lightweight exits (exits which don't involve userspace) are many times faster than heavyweight exits, it makes sense to emulate high usage devices in the kernel. The local APIC is one such device, especially for Windows and for SMP, so we add an APIC

[PATCH 061/104] KVM: Support more memory slots

2007-09-17 Thread Avi Kivity
From: Izik Eidus <[EMAIL PROTECTED]> Needed for mapping memory at 4GB. Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/kvm.h

[PATCH 060/104] KVM: VMX: allow rmode_tss_base() to work with >2G of guest memory

2007-09-17 Thread Avi Kivity
From: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Izik Eidus <[EMAIL PROTECTED]> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- drivers/kvm/vmx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index cd999c0..b400668 100644 ---

[PATCH 077/104] KVM: Migrate lapic hrtimer when vcpu moves to another cpu

2007-09-17 Thread Avi Kivity
From: Eddie Dong <[EMAIL PROTECTED]> This reduces overhead by accessing cachelines from the wrong node, as well as simplifying locking. [Qing: fix for inactive or expired one-shot timer] Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> Signed-off-by: Qing He <[EMAIL PROTECTED]>

[PATCH 072/104] KVM: in-kernel IOAPIC save and restore support

2007-09-17 Thread Avi Kivity
From: He, Qing <[EMAIL PROTECTED]> This patch adds support for in-kernel ioapic save and restore (to and from userspace). It uses the same get/set_irqchip ioctl as in-kernel PIC. Signed-off-by: Qing He <[EMAIL PROTECTED]> Signed-off-by: Yaozu (Eddie) Dong <[EMAIL PROTECTED]> Signed-off-by: Avi

[PATCH 063/104] KVM: VMX: Split segments reload in vmx_load_host_state()

2007-09-17 Thread Avi Kivity
From: Laurent Vivier <[EMAIL PROTECTED]> vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into one in the hope that it is infrequent. With smp guests, fs reloading is frequent due to fs being used by threads. Unbundle the reloads so reduce expensive gs reloads. Signed-off-by:

[PATCH 073/104] KVM: in-kernel LAPIC save and restore support

2007-09-17 Thread Avi Kivity
From: Eddie Dong <[EMAIL PROTECTED]> This patch adds a new vcpu-based IOCTL to save and restore the local apic registers for a single vcpu. The kernel only copies the apic page as a whole, extraction of registers is left to userspace side. On restore, the APIC timer is restarted from the initial

<    1   2   3   4   5   6   7   8   9   10   >