[PATCH] drm/msm/mdp5: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

[PATCH] drm/msm/mdp5: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0]

Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message

2018-01-17 Thread Robin Murphy
[ +Marc just in case ] On 17/01/18 18:39, Nate Watterson wrote: From: Sinan Kaya Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled in ACPI FW to preserve compatibility with older kernel versions. Code is emitting warning message during boot.

Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message

2018-01-17 Thread Robin Murphy
[ +Marc just in case ] On 17/01/18 18:39, Nate Watterson wrote: From: Sinan Kaya Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled in ACPI FW to preserve compatibility with older kernel versions. Code is emitting warning message during boot. This is causing some test

[PATCH] drm/nouveau/mmu: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

[PATCH] drm/nouveau/mmu: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0]

[PATCH] crypto: artpec6 - remove select on non-existing CRYPTO_SHA384

2018-01-17 Thread Corentin Labbe
Since CRYPTO_SHA384 does not exists, Kconfig should not select it. Anyway, all SHA384 stuff is in CRYPTO_SHA512 which is already selected. Fixes: a21eb94fc4d3i ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") Signed-off-by: Corentin Labbe ---

[PATCH] crypto: artpec6 - remove select on non-existing CRYPTO_SHA384

2018-01-17 Thread Corentin Labbe
Since CRYPTO_SHA384 does not exists, Kconfig should not select it. Anyway, all SHA384 stuff is in CRYPTO_SHA512 which is already selected. Fixes: a21eb94fc4d3i ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") Signed-off-by: Corentin Labbe --- drivers/crypto/Kconfig | 1 - 1 file

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-17 Thread Al Viro
On Wed, Jan 17, 2018 at 02:17:26PM +, Alan Cox wrote: > On Tue, 2018-01-16 at 14:41 -0800, Linus Torvalds wrote: > > > > > > On Jan 16, 2018 14:23, "Dan Williams" > > wrote: > > > That said, for get_user specifically, can we do something even > > > cheaper. Dave H.

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-17 Thread Al Viro
On Wed, Jan 17, 2018 at 02:17:26PM +, Alan Cox wrote: > On Tue, 2018-01-16 at 14:41 -0800, Linus Torvalds wrote: > > > > > > On Jan 16, 2018 14:23, "Dan Williams" > > wrote: > > > That said, for get_user specifically, can we do something even > > > cheaper. Dave H. reminds me that any valid

[PATCH] drm: amd: Fix trailing semicolons

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing the two instances of them since they don't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide

[PATCH] drm: amd: Fix trailing semicolons

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing the two instances of them since they don't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Jeremy Linton
Hi, On 01/17/2018 12:20 PM, Sudeep Holla wrote: On 16/01/18 21:07, Jeremy Linton wrote: Hi, On 01/15/2018 06:33 AM, Sudeep Holla wrote: On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: The original intent in cacheinfo was that an architecture specific populate_cache_leaves()

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Jeremy Linton
Hi, On 01/17/2018 12:20 PM, Sudeep Holla wrote: On 16/01/18 21:07, Jeremy Linton wrote: Hi, On 01/15/2018 06:33 AM, Sudeep Holla wrote: On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: The original intent in cacheinfo was that an architecture specific populate_cache_leaves()

Re: [PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions

2018-01-17 Thread Alex Williamson
On Wed, 17 Jan 2018 19:30:29 +0100 KarimAllah Ahmed wrote: > ... since INTx is not supported by-spec for virtual functions. But the spec also states that VFs must implement the interrupt pin register as read-only zero, so either this is redundant or it's a workaround for VFs

Re: [PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions

2018-01-17 Thread Alex Williamson
On Wed, 17 Jan 2018 19:30:29 +0100 KarimAllah Ahmed wrote: > ... since INTx is not supported by-spec for virtual functions. But the spec also states that VFs must implement the interrupt pin register as read-only zero, so either this is redundant or it's a workaround for VFs that aren't quite

[PATCH] ASoC: Intel: remove select on non-existing SND_SOC_INTEL_COMMON

2018-01-17 Thread Corentin Labbe
SND_SST_ATOM_HIFI2_PLATFORM_PCI select SND_SOC_INTEL_COMMON which do not exists anymore. So remove this select. Fixes: c6059879be29 ("ASoC: Intel: Fix Kconfig with top-level selector") Signed-off-by: Corentin Labbe --- sound/soc/intel/Kconfig | 1 - 1 file changed, 1

[PATCH] ASoC: Intel: remove select on non-existing SND_SOC_INTEL_COMMON

2018-01-17 Thread Corentin Labbe
SND_SST_ATOM_HIFI2_PLATFORM_PCI select SND_SOC_INTEL_COMMON which do not exists anymore. So remove this select. Fixes: c6059879be29 ("ASoC: Intel: Fix Kconfig with top-level selector") Signed-off-by: Corentin Labbe --- sound/soc/intel/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git

Re: Hi (Assigning NULL to variable after freeing it).

2018-01-17 Thread Randy Dunlap
On 01/17/18 02:44, Jose Bale wrote: > Hi All, > > I have just started to contribute to linux kernel. I was thinking of > giving a patch where a variable is made null after free if not already > done. > > Some thing like this: > Original code: > kfree(x); > ...some other

Re: Hi (Assigning NULL to variable after freeing it).

2018-01-17 Thread Randy Dunlap
On 01/17/18 02:44, Jose Bale wrote: > Hi All, > > I have just started to contribute to linux kernel. I was thinking of > giving a patch where a variable is made null after free if not already > done. > > Some thing like this: > Original code: > kfree(x); > ...some other

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 12:12:51 -0500 Steven Rostedt wrote: > @@ -2393,15 +2451,20 @@ void console_unlock(void) >* waiter waiting to take over. >*/ > console_lock_spinning_enable(); > + offload = recursion_check_start();

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 12:12:51 -0500 Steven Rostedt wrote: > @@ -2393,15 +2451,20 @@ void console_unlock(void) >* waiter waiting to take over. >*/ > console_lock_spinning_enable(); > + offload = recursion_check_start(); > >

[PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message

2018-01-17 Thread Nate Watterson
From: Sinan Kaya Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled in ACPI FW to preserve compatibility with older kernel versions. Code is emitting warning message during boot. This is causing some test tools to record a false warning and is

[PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message

2018-01-17 Thread Nate Watterson
From: Sinan Kaya Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled in ACPI FW to preserve compatibility with older kernel versions. Code is emitting warning message during boot. This is causing some test tools to record a false warning and is causing support issues.

Re: [PATCH v2 1/3] Revert "do_SAK: Don't recursively take the tasklist_lock"

2018-01-17 Thread Eric W. Biederman
Oleg Nesterov writes: > On 01/17, Eric W. Biederman wrote: >> >> Oleg Nesterov writes: >> >> > On 01/17, Eric W. Biederman wrote: >> > >> >> Kirill Tkhai writes: >> >> >> >> > This reverts commit 20ac94378de5. >> >> > >> >> > send_sig()

Re: [PATCH v2 1/3] Revert "do_SAK: Don't recursively take the tasklist_lock"

2018-01-17 Thread Eric W. Biederman
Oleg Nesterov writes: > On 01/17, Eric W. Biederman wrote: >> >> Oleg Nesterov writes: >> >> > On 01/17, Eric W. Biederman wrote: >> > >> >> Kirill Tkhai writes: >> >> >> >> > This reverts commit 20ac94378de5. >> >> > >> >> > send_sig() does not take tasklist_lock for a long time, >> >> > so

Re: [PATCH v2 05/31] net: Allow pernet_operations to be executed in parallel

2018-01-17 Thread Andrei Vagin
On Mon, Nov 20, 2017 at 09:32:55PM +0300, Kirill Tkhai wrote: > This adds new pernet_operations::async flag to indicate operations, > which ->init(), ->exit() and ->exit_batch() methods are allowed > to be executed in parallel with the methods of any other pernet_operations. > > When there are

Re: [PATCH v2 05/31] net: Allow pernet_operations to be executed in parallel

2018-01-17 Thread Andrei Vagin
On Mon, Nov 20, 2017 at 09:32:55PM +0300, Kirill Tkhai wrote: > This adds new pernet_operations::async flag to indicate operations, > which ->init(), ->exit() and ->exit_batch() methods are allowed > to be executed in parallel with the methods of any other pernet_operations. > > When there are

Re: [PATCH v2] arm64: Branch predictor hardening for Cavium ThunderX2

2018-01-17 Thread Jon Masters
On 01/16/2018 06:45 PM, Jayachandran C wrote: > On Tue, Jan 16, 2018 at 04:52:53PM -0500, Jon Masters wrote: >> On 01/09/2018 07:47 AM, Jayachandran C wrote: >> >>> Use PSCI based mitigation for speculative execution attacks targeting >>> the branch predictor. The approach is similar to the one

Re: [PATCH v2] arm64: Branch predictor hardening for Cavium ThunderX2

2018-01-17 Thread Jon Masters
On 01/16/2018 06:45 PM, Jayachandran C wrote: > On Tue, Jan 16, 2018 at 04:52:53PM -0500, Jon Masters wrote: >> On 01/09/2018 07:47 AM, Jayachandran C wrote: >> >>> Use PSCI based mitigation for speculative execution attacks targeting >>> the branch predictor. The approach is similar to the one

[PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions

2018-01-17 Thread KarimAllah Ahmed
... since INTx is not supported by-spec for virtual functions. Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: KarimAllah Ahmed Signed-off-by: Jan H. Schönherr --- drivers/pci/probe.c

[PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions

2018-01-17 Thread KarimAllah Ahmed
... since INTx is not supported by-spec for virtual functions. Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: KarimAllah Ahmed Signed-off-by: Jan H. Schönherr --- drivers/pci/probe.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 3/5] powerpc/ftw: Implement a simple FTW driver

2018-01-17 Thread Randy Dunlap
On 01/16/18 18:50, Sukadev Bhattiprolu wrote: > The Fast Thread Wake-up (FTW) driver provides user space applications an > interface to the low latency Core-to-Core wakeup functionality in POWER9. > > This mechanism allows a thread on one core to efficiently send a message > to a "waiting thread"

Re: [PATCH 3/5] powerpc/ftw: Implement a simple FTW driver

2018-01-17 Thread Randy Dunlap
On 01/16/18 18:50, Sukadev Bhattiprolu wrote: > The Fast Thread Wake-up (FTW) driver provides user space applications an > interface to the low latency Core-to-Core wakeup functionality in POWER9. > > This mechanism allows a thread on one core to efficiently send a message > to a "waiting thread"

[PATCH] hwmon: (lm75) Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

[PATCH] hwmon: (lm75) Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0]

Re: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

2018-01-17 Thread Randy Dunlap
On 01/16/18 18:50, Sukadev Bhattiprolu wrote: > Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A > follow-on patch will implement the FTW driver and ioctl. > > Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman. > > Signed-off-by: Sukadev Bhattiprolu

Re: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

2018-01-17 Thread Randy Dunlap
On 01/16/18 18:50, Sukadev Bhattiprolu wrote: > Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A > follow-on patch will implement the FTW driver and ioctl. > > Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman. > > Signed-off-by: Sukadev Bhattiprolu >

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

2018-01-17 Thread Tobias Jakobi
Hey Arnd, looks good to me! Reviewed-by: Tobias Jakobi - Tobias Arnd Bergmann wrote: > The exynos DRM driver uses real-time 'struct timeval' values > for exporting its timestamps to user space. This has multiple > problems: > > 1. signed seconds overflow in

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

2018-01-17 Thread Tobias Jakobi
Hey Arnd, looks good to me! Reviewed-by: Tobias Jakobi - Tobias Arnd Bergmann wrote: > The exynos DRM driver uses real-time 'struct timeval' values > for exporting its timestamps to user space. This has multiple > problems: > > 1. signed seconds overflow in y2038 > 2. the 'struct timeval'

Re: [PATCH] mm: numa: Do not trap faults on shared data section pages.

2018-01-17 Thread Christopher Lameter
On Tue, 16 Jan 2018, Mel Gorman wrote: > My main source of discomfort is the fact that this is permanent as two > processes perfectly isolated but with a suitably shared COW mapping > will never migrate the data. A potential improvement to get the reported > bandwidth up in the test program would

Re: [PATCH] mm: numa: Do not trap faults on shared data section pages.

2018-01-17 Thread Christopher Lameter
On Tue, 16 Jan 2018, Mel Gorman wrote: > My main source of discomfort is the fact that this is permanent as two > processes perfectly isolated but with a suitably shared COW mapping > will never migrate the data. A potential improvement to get the reported > bandwidth up in the test program would

[PATCH] drm: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

[PATCH] drm: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0]

[PATCH] iommu/vt-d: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards

[PATCH] iommu/vt-d: Fix trailing semicolon

2018-01-17 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0]

Re: [PATCH] PCI / PM: Fix trailing semicolon

2018-01-17 Thread Bjorn Helgaas
[+cc Rafael] On Wed, Jan 17, 2018 at 10:33:21AM +, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Acked-by: Bjorn Helgaas

Re: [PATCH] PCI / PM: Fix trailing semicolon

2018-01-17 Thread Bjorn Helgaas
[+cc Rafael] On Wed, Jan 17, 2018 at 10:33:21AM +, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt Acked-by: Bjorn Helgaas Rafael, I have nothing queued

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Sudeep Holla
On 16/01/18 21:07, Jeremy Linton wrote: > Hi, > > On 01/15/2018 06:33 AM, Sudeep Holla wrote: >> On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: >>> The original intent in cacheinfo was that an architecture >>> specific populate_cache_leaves() would probe the hardware >>> and

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Sudeep Holla
On 16/01/18 21:07, Jeremy Linton wrote: > Hi, > > On 01/15/2018 06:33 AM, Sudeep Holla wrote: >> On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: >>> The original intent in cacheinfo was that an architecture >>> specific populate_cache_leaves() would probe the hardware >>> and

[PATCH v2] kvm: Map PFN-type memory regions as writable (if possible)

2018-01-17 Thread KarimAllah Ahmed
For EPT-violations that are triggered by a read, the pages are also mapped with write permissions (if their memory region is also writable). That would avoid getting yet another fault on the same page when a write occurs. This optimization only happens when you have a "struct page" backing the

[PATCH v2] kvm: Map PFN-type memory regions as writable (if possible)

2018-01-17 Thread KarimAllah Ahmed
For EPT-violations that are triggered by a read, the pages are also mapped with write permissions (if their memory region is also writable). That would avoid getting yet another fault on the same page when a write occurs. This optimization only happens when you have a "struct page" backing the

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

2018-01-17 Thread Bjorn Helgaas
On Sat, Jan 13, 2018 at 10:08:43PM +0100, SF Markus Elfring wrote: > > Your commit message says "omit an extra message", which suggests that > > there are currently two messages about the memory allocation failure, > > and that your patch removes one of them. > > Yes. - There is a general

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

2018-01-17 Thread Bjorn Helgaas
On Sat, Jan 13, 2018 at 10:08:43PM +0100, SF Markus Elfring wrote: > > Your commit message says "omit an extra message", which suggests that > > there are currently two messages about the memory allocation failure, > > and that your patch removes one of them. > > Yes. - There is a general

Re: [PATCH for 4.16 07/11] x86: Implement sync_core_before_usermode (v3)

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 10:10 AM, Mathieu Desnoyers wrote: > - On Jan 17, 2018, at 12:53 PM, Andy Lutomirski l...@kernel.org wrote: > >> On Wed, Jan 17, 2018 at 8:54 AM, Mathieu Desnoyers >> wrote: >>> Ensure that a core

Re: [PATCH for 4.16 07/11] x86: Implement sync_core_before_usermode (v3)

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 10:10 AM, Mathieu Desnoyers wrote: > - On Jan 17, 2018, at 12:53 PM, Andy Lutomirski l...@kernel.org wrote: > >> On Wed, Jan 17, 2018 at 8:54 AM, Mathieu Desnoyers >> wrote: >>> Ensure that a core serializing instruction is issued before returning to >>> user-mode.

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Juergen Gross
On 17/01/18 16:34, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 16/01/18 17:35, Ingo Molnar wrote: >>> >>> * Juergen Gross wrote: >>> On 16/01/18 16:46, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> There

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Juergen Gross
On 17/01/18 16:34, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 16/01/18 17:35, Ingo Molnar wrote: >>> >>> * Juergen Gross wrote: >>> On 16/01/18 16:46, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> There seem to exist several grub2 versions trashing >>

Re: [PATCH 03/16] x86/entry/32: Leave the kernel via the trampoline stack

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 6:10 AM, Joerg Roedel wrote: > On Wed, Jan 17, 2018 at 05:57:53AM -0800, Brian Gerst wrote: >> On Wed, Jan 17, 2018 at 1:24 AM, Joerg Roedel wrote: > >> > I have no real idea on how to switch back to the entry stack without >> > access to

Re: [PATCH 03/16] x86/entry/32: Leave the kernel via the trampoline stack

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 6:10 AM, Joerg Roedel wrote: > On Wed, Jan 17, 2018 at 05:57:53AM -0800, Brian Gerst wrote: >> On Wed, Jan 17, 2018 at 1:24 AM, Joerg Roedel wrote: > >> > I have no real idea on how to switch back to the entry stack without >> > access to per_cpu variables. I also can't

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-17 Thread Dan Williams
On Tue, Jan 16, 2018 at 10:50 PM, Dan Williams wrote: > On Tue, Jan 16, 2018 at 10:28 PM, Al Viro wrote: [..] >> Anything that open-codes copy_from_user() that way is *ALREADY* fucked if >> it cares about the overhead - recent x86 boxen will

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-17 Thread Dan Williams
On Tue, Jan 16, 2018 at 10:50 PM, Dan Williams wrote: > On Tue, Jan 16, 2018 at 10:28 PM, Al Viro wrote: [..] >> Anything that open-codes copy_from_user() that way is *ALREADY* fucked if >> it cares about the overhead - recent x86 boxen will have slowdown from >> hell on stac()/clac() pairs.

Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support

2018-01-17 Thread Andrew Lunn
On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote: > Hi, > > This is a third version of the patchset introducing mvpp2 driver ability > to operate with ACPI. Until follow-up generic MDIO is introduced > it can using the link interrupt capability (a.k.a. in-band management) > on all

Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support

2018-01-17 Thread Andrew Lunn
On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote: > Hi, > > This is a third version of the patchset introducing mvpp2 driver ability > to operate with ACPI. Until follow-up generic MDIO is introduced > it can using the link interrupt capability (a.k.a. in-band management) > on all

[PATCH] ubifs: Check ubifs_wbuf_sync() return code

2018-01-17 Thread Richard Weinberger
If ubifs_wbuf_sync() fails we must not write a master node with the dirty marker cleared. Otherwise it is possible that in case of an IO error while syncing we mark the filesystem as clean and UBIFS refuses to recover upon next mount. Cc: Fixes: 1e51764a3c2a ("UBIFS: add

[PATCH] ubifs: Check ubifs_wbuf_sync() return code

2018-01-17 Thread Richard Weinberger
If ubifs_wbuf_sync() fails we must not write a master node with the dirty marker cleared. Otherwise it is possible that in case of an IO error while syncing we mark the filesystem as clean and UBIFS refuses to recover upon next mount. Cc: Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")

Re: [PATCH 02/16] x86/entry/32: Enter the kernel via trampoline stack

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 1:18 AM, Joerg Roedel wrote: > On Tue, Jan 16, 2018 at 02:45:27PM -0800, Andy Lutomirski wrote: >> On Tue, Jan 16, 2018 at 8:36 AM, Joerg Roedel wrote: >> > +.macro SWITCH_TO_KERNEL_STACK nr_regs=0 check_user=0 >> >> How about marking

Re: [PATCH 02/16] x86/entry/32: Enter the kernel via trampoline stack

2018-01-17 Thread Andy Lutomirski
On Wed, Jan 17, 2018 at 1:18 AM, Joerg Roedel wrote: > On Tue, Jan 16, 2018 at 02:45:27PM -0800, Andy Lutomirski wrote: >> On Tue, Jan 16, 2018 at 8:36 AM, Joerg Roedel wrote: >> > +.macro SWITCH_TO_KERNEL_STACK nr_regs=0 check_user=0 >> >> How about marking nr_regs with :req to force everyone

Re: [PATCH for 4.16 07/11] x86: Implement sync_core_before_usermode (v3)

2018-01-17 Thread Mathieu Desnoyers
- On Jan 17, 2018, at 12:53 PM, Andy Lutomirski l...@kernel.org wrote: > On Wed, Jan 17, 2018 at 8:54 AM, Mathieu Desnoyers > wrote: >> Ensure that a core serializing instruction is issued before returning to >> user-mode. x86 implements return to user-space

Re: [PATCH for 4.16 07/11] x86: Implement sync_core_before_usermode (v3)

2018-01-17 Thread Mathieu Desnoyers
- On Jan 17, 2018, at 12:53 PM, Andy Lutomirski l...@kernel.org wrote: > On Wed, Jan 17, 2018 at 8:54 AM, Mathieu Desnoyers > wrote: >> Ensure that a core serializing instruction is issued before returning to >> user-mode. x86 implements return to user-space through sysexit, sysrel, >> and

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Sudeep Holla
(Sorry, somehow I missed this email until I saw Jeremy's reply today) On 15/01/18 16:07, Palmer Dabbelt wrote: > On Mon, 15 Jan 2018 04:33:38 PST (-0800), sudeep.ho...@arm.com wrote: >> On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: >>> The original intent in cacheinfo was that an

Re: [PATCH v6 02/12] drivers: base: cacheinfo: setup DT cache properties early

2018-01-17 Thread Sudeep Holla
(Sorry, somehow I missed this email until I saw Jeremy's reply today) On 15/01/18 16:07, Palmer Dabbelt wrote: > On Mon, 15 Jan 2018 04:33:38 PST (-0800), sudeep.ho...@arm.com wrote: >> On Fri, Jan 12, 2018 at 06:59:10PM -0600, Jeremy Linton wrote: >>> The original intent in cacheinfo was that an

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Frederic Weisbecker
Hi Mauro, On Wed, Jan 17, 2018 at 02:56:20PM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 16 Jan 2018 05:40:35 +0100 > Frederic Weisbecker escreveu: > > > So this set is in a testable state. I addressed preliminary reviews from > > Eric Dumazet, Paolo Abeni and Linus. > >

Re: [RFC PATCH 0/5] softirq: Per vector threading v2

2018-01-17 Thread Frederic Weisbecker
Hi Mauro, On Wed, Jan 17, 2018 at 02:56:20PM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 16 Jan 2018 05:40:35 +0100 > Frederic Weisbecker escreveu: > > > So this set is in a testable state. I addressed preliminary reviews from > > Eric Dumazet, Paolo Abeni and Linus. > > > > You may want to

Re: [PATCH 3/3] encrypted-keys: document new fscrypt key format

2018-01-17 Thread Theodore Ts'o
On Wed, Jan 17, 2018 at 02:38:59PM +, André Draszik wrote: > > > [...] > > > > Please be very clear about exactly what security properties are achieved > > by > > using encrypted-keys. > > I've left out all of this in the updated documentation, as any such > information should probably be in

Re: [PATCH 3/3] encrypted-keys: document new fscrypt key format

2018-01-17 Thread Theodore Ts'o
On Wed, Jan 17, 2018 at 02:38:59PM +, André Draszik wrote: > > > [...] > > > > Please be very clear about exactly what security properties are achieved > > by > > using encrypted-keys. > > I've left out all of this in the updated documentation, as any such > information should probably be in

Re: [PATCH v2 1/3] Revert "do_SAK: Don't recursively take the tasklist_lock"

2018-01-17 Thread Oleg Nesterov
On 01/17, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > On 01/17, Eric W. Biederman wrote: > > > >> Kirill Tkhai writes: > >> > >> > This reverts commit 20ac94378de5. > >> > > >> > send_sig() does not take tasklist_lock for a long time, > >> > so

Re: [PATCH v2 1/3] Revert "do_SAK: Don't recursively take the tasklist_lock"

2018-01-17 Thread Oleg Nesterov
On 01/17, Eric W. Biederman wrote: > > Oleg Nesterov writes: > > > On 01/17, Eric W. Biederman wrote: > > > >> Kirill Tkhai writes: > >> > >> > This reverts commit 20ac94378de5. > >> > > >> > send_sig() does not take tasklist_lock for a long time, > >> > so this commit and the problem it solves

Re: [PATCH -next] memory: ti-emif-sram: remove redundant dev_err call in ti_emif_probe()

2018-01-17 Thread Santosh Shilimkar
On 1/17/2018 3:29 AM, Wei Yongjun wrote: There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- Looks fine. Will pick it up for next merge window. Regards, Santosh

Re: [PATCH -next] memory: ti-emif-sram: remove redundant dev_err call in ti_emif_probe()

2018-01-17 Thread Santosh Shilimkar
On 1/17/2018 3:29 AM, Wei Yongjun wrote: There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- Looks fine. Will pick it up for next merge window. Regards, Santosh

Re: [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()

2018-01-17 Thread Santosh Shilimkar
On 1/13/2018 1:34 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 13 Jan 2018 10:24:03 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the

Re: [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()

2018-01-17 Thread Santosh Shilimkar
On 1/13/2018 1:34 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 13 Jan 2018 10:24:03 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by:

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-01-17 Thread Wei Wang
On Wed, Jan 3, 2018 at 3:31 PM, Cong Wang wrote: > > On Wed, Jan 3, 2018 at 12:55 PM, Ozgur wrote: > > > > > > 03.01.2018, 21:57, "Cong Wang" : > >> On Tue, Jan 2, 2018 at 3:58 PM, syzbot > >>

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-01-17 Thread Wei Wang
On Wed, Jan 3, 2018 at 3:31 PM, Cong Wang wrote: > > On Wed, Jan 3, 2018 at 12:55 PM, Ozgur wrote: > > > > > > 03.01.2018, 21:57, "Cong Wang" : > >> On Tue, Jan 2, 2018 at 3:58 PM, syzbot > >> wrote: > >>> Hello, > >>> > >>> syzkaller hit the following crash on > >>>

Re: [PATCH v6 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing

2018-01-17 Thread Sudeep Holla
On 16/01/18 20:22, Jeremy Linton wrote: > Hi, > [..] >> >> I forgot to mention this earlier, I see you have used parentheses too >> liberally at quite some place in this file like the above 4 line. >> Please drop those unnecessary parentheses. > > Yes, those tend to get leftover when I

Re: [PATCH v6 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing

2018-01-17 Thread Sudeep Holla
On 16/01/18 20:22, Jeremy Linton wrote: > Hi, > [..] >> >> I forgot to mention this earlier, I see you have used parentheses too >> liberally at quite some place in this file like the above 4 line. >> Please drop those unnecessary parentheses. > > Yes, those tend to get leftover when I

[PATCH 3/3] mfd: cros_ec_dev: Register cros_usbpd-charger driver as a subdevice.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda Check whether this EC instance has USBPD host command support and instatiate the cros_usbpd-charger driver as a subdevice in such case. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra

[PATCH 1/3] mfd: cros_ec: Add USBPD charger commands and struct definitions.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda The USB PD charger driver gets information from the ChromeOS EC, this patch adds the USBPD charger definitions needed by this driver. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra

[PATCH 3/3] mfd: cros_ec_dev: Register cros_usbpd-charger driver as a subdevice.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda Check whether this EC instance has USBPD host command support and instatiate the cros_usbpd-charger driver as a subdevice in such case. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 25 + 1 file

[PATCH 1/3] mfd: cros_ec: Add USBPD charger commands and struct definitions.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda The USB PD charger driver gets information from the ChromeOS EC, this patch adds the USBPD charger definitions needed by this driver. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra --- include/linux/mfd/cros_ec_commands.h | 135

[PATCH 0/3] mfd: cros_ec: add support for USBPD charger driver.

2018-01-17 Thread Enric Balletbo i Serra
Dear all, These patches introduces the ChromeOS EC USBPD charger driver, the driver has been used on Chromebooks kernels and ported to mainline. The patches were tested succesfully with a Samsung Chromebook Plus device but depends on the for-next Benson Leung branch [1] to apply cleanly. This

[PATCH 2/3] power: supply: add cros-ec USB PD charger driver.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda This driver gets various bits of information about what is connected to USB PD ports from the EC and converts that into power_supply properties. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra

[PATCH 0/3] mfd: cros_ec: add support for USBPD charger driver.

2018-01-17 Thread Enric Balletbo i Serra
Dear all, These patches introduces the ChromeOS EC USBPD charger driver, the driver has been used on Chromebooks kernels and ported to mainline. The patches were tested succesfully with a Samsung Chromebook Plus device but depends on the for-next Benson Leung branch [1] to apply cleanly. This

[PATCH 2/3] power: supply: add cros-ec USB PD charger driver.

2018-01-17 Thread Enric Balletbo i Serra
From: Sameer Nanda This driver gets various bits of information about what is connected to USB PD ports from the EC and converts that into power_supply properties. Signed-off-by: Sameer Nanda Signed-off-by: Enric Balletbo i Serra --- drivers/power/supply/Kconfig | 11 +

Re: [PATCH v6 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing

2018-01-17 Thread Sudeep Holla
On 16/01/18 20:55, Jeremy Linton wrote: > [...] >>> +/* >>> + * Determine if the *node parameter is a leaf node by iterating the >>> + * PPTT table, looking for nodes which reference it. >>> + * Return 0 if we find a node referencing the passed node, >>> + * or 1 if we don't. >>> + */ >>>

Re: [PATCH v6 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing

2018-01-17 Thread Sudeep Holla
On 16/01/18 20:55, Jeremy Linton wrote: > [...] >>> +/* >>> + * Determine if the *node parameter is a leaf node by iterating the >>> + * PPTT table, looking for nodes which reference it. >>> + * Return 0 if we find a node referencing the passed node, >>> + * or 1 if we don't. >>> + */ >>>

Re: [PATCH] kvm: Map PFN-type memory regions as writable (if possible)

2018-01-17 Thread Paolo Bonzini
On 17/01/2018 18:26, KarimAllah Ahmed wrote: > For EPT-violations that are triggered by a read, the pages are also mapped > with > write permissions (if their memory region is also writable). That would avoid > getting yet another fault on the same page when a write occurs. > > This optimization

Re: [PATCH] kvm: Map PFN-type memory regions as writable (if possible)

2018-01-17 Thread Paolo Bonzini
On 17/01/2018 18:26, KarimAllah Ahmed wrote: > For EPT-violations that are triggered by a read, the pages are also mapped > with > write permissions (if their memory region is also writable). That would avoid > getting yet another fault on the same page when a write occurs. > > This optimization

Re: [3/5] clk: divider: add divider_ro_round_rate helper

2018-01-17 Thread David Lechner
On 01/17/2018 11:47 AM, Jerome Brunet wrote: On Thu, 2018-01-11 at 17:08 -0600, David Lechner wrote: On 01/05/2018 11:09 AM, Jerome Brunet wrote: Like divider_round_rate, a couple a of driver are doing more or less the same operation to round the rate of the divider when it is read-only. We

Re: [3/5] clk: divider: add divider_ro_round_rate helper

2018-01-17 Thread David Lechner
On 01/17/2018 11:47 AM, Jerome Brunet wrote: On Thu, 2018-01-11 at 17:08 -0600, David Lechner wrote: On 01/05/2018 11:09 AM, Jerome Brunet wrote: Like divider_round_rate, a couple a of driver are doing more or less the same operation to round the rate of the divider when it is read-only. We

<    6   7   8   9   10   11   12   13   14   15   >