[PATCH 01/10] net: separate SIOCGIFCONF handling from dev_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. Separating that codepath from the rest of dev_ioctl() allows both to simplify dev_ioctl() itself (all other cases work with struct ifreq *) *and* seriously simplify the compat side of that beast:

[PATCH 07/10] lift handling of SIOCIW... out of dev_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- include/net/wext.h | 4 ++-- net/core/dev_ioctl.c | 18 -- net/socket.c | 2 +- net/wireless/wext-core.c | 13 + 4 files changed, 12 insertions(+), 25

[PATCH 01/10] net: separate SIOCGIFCONF handling from dev_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. Separating that codepath from the rest of dev_ioctl() allows both to simplify dev_ioctl() itself (all other cases work with struct ifreq *) *and* seriously simplify the compat side of that beast: all it takes is passing to

[PATCH 07/10] lift handling of SIOCIW... out of dev_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- include/net/wext.h | 4 ++-- net/core/dev_ioctl.c | 18 -- net/socket.c | 2 +- net/wireless/wext-core.c | 13 + 4 files changed, 12 insertions(+), 25 deletions(-) diff --git a/include/net/wext.h

[PATCH 10/10] kill kernel_sock_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro no users since 2014 Signed-off-by: Al Viro --- include/linux/net.h | 1 - net/socket.c| 13 - 2 files changed, 14 deletions(-) diff --git a/include/linux/net.h b/include/linux/net.h index

[PATCH 04/10] kill dev_ifsioc()

2018-01-18 Thread Al Viro
From: Al Viro it's been equivalent to sock_do_ioctl() since 2009... Signed-off-by: Al Viro --- net/socket.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/net/socket.c b/net/socket.c index

[PATCH 03/10] ip_rt_ioctl(): take copyin to caller

2018-01-18 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- include/net/route.h | 2 +- net/ipv4/af_inet.c | 7 ++- net/ipv4/fib_frontend.c | 8 ++-- net/ipv4/ipconfig.c | 13 + 4 files changed, 10 insertions(+), 20

[PATCH 10/10] kill kernel_sock_ioctl()

2018-01-18 Thread Al Viro
From: Al Viro no users since 2014 Signed-off-by: Al Viro --- include/linux/net.h | 1 - net/socket.c| 13 - 2 files changed, 14 deletions(-) diff --git a/include/linux/net.h b/include/linux/net.h index caeb159abda5..68acc54976bf 100644 --- a/include/linux/net.h +++

[PATCH 04/10] kill dev_ifsioc()

2018-01-18 Thread Al Viro
From: Al Viro it's been equivalent to sock_do_ioctl() since 2009... Signed-off-by: Al Viro --- net/socket.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/net/socket.c b/net/socket.c index 112216c537e7..f280258bd6a4 100644 --- a/net/socket.c +++

[PATCH 03/10] ip_rt_ioctl(): take copyin to caller

2018-01-18 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- include/net/route.h | 2 +- net/ipv4/af_inet.c | 7 ++- net/ipv4/fib_frontend.c | 8 ++-- net/ipv4/ipconfig.c | 13 + 4 files changed, 10 insertions(+), 20 deletions(-) diff --git a/include/net/route.h

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Rafael J. Wysocki
On Thursday, January 18, 2018 12:26:37 PM CET Mika Westerberg wrote: > On Thu, Jan 18, 2018 at 12:20:32PM +0200, Mika Westerberg wrote: > > On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > > > Unfortunately we couldn't get approval yet, since it's a prototype > > > machine. > > > >

Re: Missing watchdog after ACPI watchdog creation failure

2018-01-18 Thread Rafael J. Wysocki
On Thursday, January 18, 2018 12:26:37 PM CET Mika Westerberg wrote: > On Thu, Jan 18, 2018 at 12:20:32PM +0200, Mika Westerberg wrote: > > On Wed, Jan 17, 2018 at 12:53:41PM +0100, Takashi Iwai wrote: > > > Unfortunately we couldn't get approval yet, since it's a prototype > > > machine. > > > >

Re: [v8,02/12] objtool: Allow alternatives to be ignored

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 11:09:31AM -0800, Guenter Roeck wrote: > Hi folks, > > On Thu, Jan 11, 2018 at 09:46:24PM +, Woodhouse, David wrote: > > Getting objtool to understand retpolines is going to be a bit of a > > challenge. For now, take advantage of the fact that retpolines are > >

Re: [v8,02/12] objtool: Allow alternatives to be ignored

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 11:09:31AM -0800, Guenter Roeck wrote: > Hi folks, > > On Thu, Jan 11, 2018 at 09:46:24PM +, Woodhouse, David wrote: > > Getting objtool to understand retpolines is going to be a bit of a > > challenge. For now, take advantage of the fact that retpolines are > >

[PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: mm/memcontrol.c:1097:14: warning: symbol 'memcg1_stats' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: mm/memcontrol.c:1097:14: warning: symbol 'memcg1_stats' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c

Re: [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc

2018-01-18 Thread Al Viro
On Thu, Jan 18, 2018 at 04:43:02AM +, Al Viro wrote: > We could turn ->msg_control/->msg_controllen into another > iov_iter, but seeing that we never do scatter-gather for those > IMO that would be a massive overkill. A flag controlling whether > ->msg_control is kernel or userland

Re: [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc

2018-01-18 Thread Al Viro
On Thu, Jan 18, 2018 at 04:43:02AM +, Al Viro wrote: > We could turn ->msg_control/->msg_controllen into another > iov_iter, but seeing that we never do scatter-gather for those > IMO that would be a massive overkill. A flag controlling whether > ->msg_control is kernel or userland

ubifs: noatime support?

2018-01-18 Thread Pavel Machek
Hi! Ubifs seems to have atime support these days: sb->s_flags |= SB_ACTIVE; #ifndef CONFIG_UBIFS_ATIME_SUPPORT sb->s_flags |= SB_NOATIME; #else ubifs_msg(c, "full atime support is enabled."); #endif Which can be configured at compile-time, but no option to disable

ubifs: noatime support?

2018-01-18 Thread Pavel Machek
Hi! Ubifs seems to have atime support these days: sb->s_flags |= SB_ACTIVE; #ifndef CONFIG_UBIFS_ATIME_SUPPORT sb->s_flags |= SB_NOATIME; #else ubifs_msg(c, "full atime support is enabled."); #endif Which can be configured at compile-time, but no option to disable

Re: [PATCH 0/7] PM /Domain/OPP: Add support to get performance state from DT

2018-01-18 Thread Rafael J. Wysocki
On Thursday, January 18, 2018 7:34:04 AM CET Viresh Kumar wrote: > On 22-12-17, 12:56, Viresh Kumar wrote: > > Hi, > > > > Now that the DT bindings [1] are already Reviewed/Acked by respective > > maintainers, here is the code to start using them. > > > > The first two patches provide helpers in

Re: [PATCH 0/7] PM /Domain/OPP: Add support to get performance state from DT

2018-01-18 Thread Rafael J. Wysocki
On Thursday, January 18, 2018 7:34:04 AM CET Viresh Kumar wrote: > On 22-12-17, 12:56, Viresh Kumar wrote: > > Hi, > > > > Now that the DT bindings [1] are already Reviewed/Acked by respective > > maintainers, here is the code to start using them. > > > > The first two patches provide helpers in

Re: [PATCH v3 10/16] iommu: introduce device fault report API

2018-01-18 Thread Jean-Philippe Brucker
Hi Jacob, I've got minor comments after working with this patch, sorry for the multiple replies On 17/11/17 18:55, Jacob Pan wrote: [...] > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 829e9e9..97b7990 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@

Re: [PATCH v3 10/16] iommu: introduce device fault report API

2018-01-18 Thread Jean-Philippe Brucker
Hi Jacob, I've got minor comments after working with this patch, sorry for the multiple replies On 17/11/17 18:55, Jacob Pan wrote: [...] > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 829e9e9..97b7990 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@

Re: [PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Joe Perches
On Thu, 2018-01-18 at 10:08 -0500, Christopher Díaz Riveros wrote: > Fixes the following sparse warning: > > mm/memcontrol.c:1097:14: warning: > symbol 'memcg1_stats' was not declared. Should it be static? > > Signed-off-by: Christopher Díaz Riveros > --- >

Re: [PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Joe Perches
On Thu, 2018-01-18 at 10:08 -0500, Christopher Díaz Riveros wrote: > Fixes the following sparse warning: > > mm/memcontrol.c:1097:14: warning: > symbol 'memcg1_stats' was not declared. Should it be static? > > Signed-off-by: Christopher Díaz Riveros > --- > mm/memcontrol.c | 2 +- > 1 file

Re: [PATCH] input: cyapa: remove redundant assignment to 'pwr_cmd'

2018-01-18 Thread Dmitry Torokhov
On Wed, Jan 17, 2018 at 10:45:19AM +, Colin King wrote: > From: Colin Ian King > > The variable pwr_cmd is being assigned to cyapa->suspend_power_mode > twice, once during the declaration and once after taking an > interruptible mutex lock. Remove the redundant

Re: [PATCH] input: cyapa: remove redundant assignment to 'pwr_cmd'

2018-01-18 Thread Dmitry Torokhov
On Wed, Jan 17, 2018 at 10:45:19AM +, Colin King wrote: > From: Colin Ian King > > The variable pwr_cmd is being assigned to cyapa->suspend_power_mode > twice, once during the declaration and once after taking an > interruptible mutex lock. Remove the redundant first assignment > since the

Re: [PATCH] input: remove at32psif

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 07:58:11PM +0100, Corentin Labbe wrote: > Since AVR32 arch is gone, at32psif driver is useless. > This patch remove it. > > Signed-off-by: Corentin Labbe Applied, thank you. What about: config TOUCHSCREEN_WM97XX_ATMEL tristate "WM97xx

Re: [PATCH] input: remove at32psif

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 07:58:11PM +0100, Corentin Labbe wrote: > Since AVR32 arch is gone, at32psif driver is useless. > This patch remove it. > > Signed-off-by: Corentin Labbe Applied, thank you. What about: config TOUCHSCREEN_WM97XX_ATMEL tristate "WM97xx Atmel accelerated touch"

Re: [PATCH] ARC: Add a knob to control usage of dual-issue

2018-01-18 Thread Alexey Brodkin
Hi Vineet, On Thu, 2018-01-18 at 10:54 -0800, Vineet Gupta wrote: > On 01/18/2018 05:48 AM, Alexey Brodkin wrote: > > HS48 core starts with dual-issue enabled but in some cases like > > debugging as well as benchmarking it might be useful to disable > > dual-issue for a particular run. > > > >

Re: [PATCH] ARC: Add a knob to control usage of dual-issue

2018-01-18 Thread Alexey Brodkin
Hi Vineet, On Thu, 2018-01-18 at 10:54 -0800, Vineet Gupta wrote: > On 01/18/2018 05:48 AM, Alexey Brodkin wrote: > > HS48 core starts with dual-issue enabled but in some cases like > > debugging as well as benchmarking it might be useful to disable > > dual-issue for a particular run. > > > >

Re: [PATCH v22 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-18 Thread Michael S. Tsirkin
On Thu, Jan 18, 2018 at 10:30:18PM +0900, Tetsuo Handa wrote: > On 2018/01/18 1:44, Michael S. Tsirkin wrote: > >> +static void add_one_sg(struct virtqueue *vq, unsigned long pfn, uint32_t > >> len) > >> +{ > >> + struct scatterlist sg; > >> + unsigned int unused; > >> + int err; > >> + > >> +

Re: [PATCH v22 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-18 Thread Michael S. Tsirkin
On Thu, Jan 18, 2018 at 10:30:18PM +0900, Tetsuo Handa wrote: > On 2018/01/18 1:44, Michael S. Tsirkin wrote: > >> +static void add_one_sg(struct virtqueue *vq, unsigned long pfn, uint32_t > >> len) > >> +{ > >> + struct scatterlist sg; > >> + unsigned int unused; > >> + int err; > >> + > >> +

Re: [v8,02/12] objtool: Allow alternatives to be ignored

2018-01-18 Thread Guenter Roeck
Hi folks, On Thu, Jan 11, 2018 at 09:46:24PM +, Woodhouse, David wrote: > Getting objtool to understand retpolines is going to be a bit of a > challenge. For now, take advantage of the fact that retpolines are > patched in with alternatives. Just read the original (sane) > non-alternative

Re: [v8,02/12] objtool: Allow alternatives to be ignored

2018-01-18 Thread Guenter Roeck
Hi folks, On Thu, Jan 11, 2018 at 09:46:24PM +, Woodhouse, David wrote: > Getting objtool to understand retpolines is going to be a bit of a > challenge. For now, take advantage of the fact that retpolines are > patched in with alternatives. Just read the original (sane) > non-alternative

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > > On 18/01/2018 18:08, Dave Hansen wrote: > > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > > >>> > > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > > On 18/01/2018 18:08, Dave Hansen wrote: > > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > > >>> > > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >

[PATCH] input: remove at32psif

2018-01-18 Thread Corentin Labbe
Since AVR32 arch is gone, at32psif driver is useless. This patch remove it. Signed-off-by: Corentin Labbe --- drivers/input/serio/Kconfig| 10 -- drivers/input/serio/Makefile | 1 - drivers/input/serio/at32psif.c | 357

[PATCH] input: remove at32psif

2018-01-18 Thread Corentin Labbe
Since AVR32 arch is gone, at32psif driver is useless. This patch remove it. Signed-off-by: Corentin Labbe --- drivers/input/serio/Kconfig| 10 -- drivers/input/serio/Makefile | 1 - drivers/input/serio/at32psif.c | 357 - 3 files changed, 368

Re: [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks

2018-01-18 Thread David Lechner
On 01/18/2018 06:10 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds a new binding for TI DA8XX USB PHY clocks. These clocks are part of a syscon register called CFGCHIP3. CFGCHIP2 Signed-off-by: David Lechner +Examples: +

Re: [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks

2018-01-18 Thread David Lechner
On 01/18/2018 06:10 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: This adds a new binding for TI DA8XX USB PHY clocks. These clocks are part of a syscon register called CFGCHIP3. CFGCHIP2 Signed-off-by: David Lechner +Examples: + + cfgchip:

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Steven Rostedt
On Thu, 18 Jan 2018 10:02:17 -0800 Andi Kleen wrote: > Dave Young writes: > > printk("%sHardware name: %s\n", > >log_lvl, dump_stack_arch_desc_str); > > + if (kexec_crash_loaded()) > > + printk("%skdump kernel

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Steven Rostedt
On Thu, 18 Jan 2018 10:02:17 -0800 Andi Kleen wrote: > Dave Young writes: > > printk("%sHardware name: %s\n", > >log_lvl, dump_stack_arch_desc_str); > > + if (kexec_crash_loaded()) > > + printk("%skdump kernel loaded\n", log_lvl); > > Oops/warnings

Re: [PATCH] ARC: Add a knob to control usage of dual-issue

2018-01-18 Thread Vineet Gupta
On 01/18/2018 05:48 AM, Alexey Brodkin wrote: HS48 core starts with dual-issue enabled but in some cases like debugging as well as benchmarking it might be useful to disable dual-issue for a particular run. Note: 1. To disable dual-issue user has to change a value of a global variable

Re: [PATCH] ARC: Add a knob to control usage of dual-issue

2018-01-18 Thread Vineet Gupta
On 01/18/2018 05:48 AM, Alexey Brodkin wrote: HS48 core starts with dual-issue enabled but in some cases like debugging as well as benchmarking it might be useful to disable dual-issue for a particular run. Note: 1. To disable dual-issue user has to change a value of a global variable

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 10:25:21AM -0800, Randy Dunlap wrote: > On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > >> A driver should not enable an entire subsystem. > > > > I disagree. As you go through menuconfig and you

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 10:25:21AM -0800, Randy Dunlap wrote: > On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > >> A driver should not enable an entire subsystem. > > > > I disagree. As you go through menuconfig and you

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

2018-01-18 Thread Christoph Hellwig
On Thu, Jan 18, 2018 at 12:55:47PM -0500, Colin Walters wrote: > > FWIW: > https://git.gnome.org/browse/glib/commit/?id=3904c8761a60dbadbdfaf98fe23ff19cbdcc4a9a > > Since that a lot of userspace (including NetworkManager) uses eventfd. I > haven't > tried this patchset myself but I'd look at

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

2018-01-18 Thread Christoph Hellwig
On Thu, Jan 18, 2018 at 12:55:47PM -0500, Colin Walters wrote: > > FWIW: > https://git.gnome.org/browse/glib/commit/?id=3904c8761a60dbadbdfaf98fe23ff19cbdcc4a9a > > Since that a lot of userspace (including NetworkManager) uses eventfd. I > haven't > tried this patchset myself but I'd look at

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

2018-01-18 Thread Andi Kleen
On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote: > On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > > in kernel text area. Of course those functions were in the > > > .text area, but placed in right

Re: [PATCH v5 21/44] clk: davinci: New driver for TI DA8XX USB PHY clocks

2018-01-18 Thread David Lechner
On 01/18/2018 07:05 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +static int da8xx_usb1_phy_clk_set_parent(struct clk_hw *hw, u8 index) +{ + struct da8xx_usb1_phy_clk *clk = to_da8xx_usb1_phy_clk(hw); + unsigned int mask, val; + + /* Set the

Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

2018-01-18 Thread Andi Kleen
On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote: > On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > > in kernel text area. Of course those functions were in the > > > .text area, but placed in right

Re: [PATCH v5 21/44] clk: davinci: New driver for TI DA8XX USB PHY clocks

2018-01-18 Thread David Lechner
On 01/18/2018 07:05 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +static int da8xx_usb1_phy_clk_set_parent(struct clk_hw *hw, u8 index) +{ + struct da8xx_usb1_phy_clk *clk = to_da8xx_usb1_phy_clk(hw); + unsigned int mask, val; + + /* Set the

Re: [PATCH] ARC: Allow disabling of prefetch operations for debugging purposes

2018-01-18 Thread Vineet Gupta
On 01/18/2018 05:48 AM, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin --- arch/arc/Kconfig | 5 + arch/arc/include/asm/processor.h | 11 +++ arch/arc/lib/memcpy-archs.S | 16 arch/arc/lib/memset-archs.S |

Re: [PATCH] ARC: Allow disabling of prefetch operations for debugging purposes

2018-01-18 Thread Vineet Gupta
On 01/18/2018 05:48 AM, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin --- arch/arc/Kconfig | 5 + arch/arc/include/asm/processor.h | 11 +++ arch/arc/lib/memcpy-archs.S | 16 arch/arc/lib/memset-archs.S | 6 ++ 4 files

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

2018-01-18 Thread Bart Van Assche
On Thu, 2018-01-18 at 13:30 -0500, Mike Snitzer wrote: > 1%!? Where are you getting that number? Ming has detailed more > significant performance gains than 1%.. and not just on lpfc (though you > keep seizing on lpfc because of the low queue_depth of 3). That's what I derived from the numbers

[PATCH 2/9] clk: meson: remove useless pll rate param tables

2018-01-18 Thread Jerome Brunet
Read-only pll don't need param table to recalculate the rate. Providing them with a param table is just a waste of memory. Remove the useless tables from sys_pll on gxbb and axg. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 94

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

2018-01-18 Thread Bart Van Assche
On Thu, 2018-01-18 at 13:30 -0500, Mike Snitzer wrote: > 1%!? Where are you getting that number? Ming has detailed more > significant performance gains than 1%.. and not just on lpfc (though you > keep seizing on lpfc because of the low queue_depth of 3). That's what I derived from the numbers

[PATCH 2/9] clk: meson: remove useless pll rate param tables

2018-01-18 Thread Jerome Brunet
Read-only pll don't need param table to recalculate the rate. Providing them with a param table is just a waste of memory. Remove the useless tables from sys_pll on gxbb and axg. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 94

[PATCH 3/9] clk: meson: remove unnecessary rounding in the pll clock

2018-01-18 Thread Jerome Brunet
The pll driver perform the rate calculation in Mhz, which adds an unnecessary rounding down to the Mhz of the rate. Use 64bits long integer to perform this calculation safely on meson8b and perform the calculation in Hz instead Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock

[PATCH 3/9] clk: meson: remove unnecessary rounding in the pll clock

2018-01-18 Thread Jerome Brunet
The pll driver perform the rate calculation in Mhz, which adds an unnecessary rounding down to the Mhz of the rate. Use 64bits long integer to perform this calculation safely on meson8b and perform the calculation in Hz instead Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock

[PATCH 0/9] clk: meson: pll fixes

2018-01-18 Thread Jerome Brunet
This changeset is collection of fixes and clean-up around the pll clock provider. This has been triggered by the discussion around the ethernet clock on the axg [0]. On the axg the rate reported by the fixed_pll was off by 8Mhz, which led the internal mux of the ethernet driver to pick an mpll2

[PATCH 0/9] clk: meson: pll fixes

2018-01-18 Thread Jerome Brunet
This changeset is collection of fixes and clean-up around the pll clock provider. This has been triggered by the discussion around the ethernet clock on the axg [0]. On the axg the rate reported by the fixed_pll was off by 8Mhz, which led the internal mux of the ethernet driver to pick an mpll2

[PATCH 4/9] clk: meson: use frac parameter width instead of a constant

2018-01-18 Thread Jerome Brunet
Use the fractional part width in the calculation instead of 12, which happens to e the witdh right now. This is safer in case the field width ever change in the future Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-pll.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/9] clk: meson: check pll rate param table before using it

2018-01-18 Thread Jerome Brunet
Make sure the rate param table is available before using it. Some read-only pll don't provide it, which is ok because the table is not used by read-only clock. R/W clock are supposed to provide it, but it does not hurt check it. Signed-off-by: Jerome Brunet ---

[PATCH 4/9] clk: meson: use frac parameter width instead of a constant

2018-01-18 Thread Jerome Brunet
Use the fractional part width in the calculation instead of 12, which happens to e the witdh right now. This is safer in case the field width ever change in the future Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/9] clk: meson: check pll rate param table before using it

2018-01-18 Thread Jerome Brunet
Make sure the rate param table is available before using it. Some read-only pll don't provide it, which is ok because the table is not used by read-only clock. R/W clock are supposed to provide it, but it does not hurt check it. Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-pll.c | 10

Re: [PATCH 29/35] x86/speculation: Add IPBP support

2018-01-18 Thread Borislav Petkov
On Thu, Jan 18, 2018 at 12:35:23PM -0600, Josh Poimboeuf wrote: > Maybe I missed the memo, why do we need both X86_FEATURE_IBPB and > X86_FEATURE_AMD_IBPB? So AMD_IBPB is a different CPUID bit in a different CPUID function and on Intel, IBPB is set only when X86_FEATURE_SPEC_CTRL - see

[PATCH 7/9] clk: meson: fix pll with fractional part calculation

2018-01-18 Thread Jerome Brunet
The rate of the parent should not be multiplied by 2 when there is a fractional part to the pll. This is making the rate calculation of gxl_hdmi_pll wrong (and others as well). This multiplication is specific to the hdmi_pll of gxbb and is most likely due to a multiplier sitting in front of this

Re: [PATCH 29/35] x86/speculation: Add IPBP support

2018-01-18 Thread Borislav Petkov
On Thu, Jan 18, 2018 at 12:35:23PM -0600, Josh Poimboeuf wrote: > Maybe I missed the memo, why do we need both X86_FEATURE_IBPB and > X86_FEATURE_AMD_IBPB? So AMD_IBPB is a different CPUID bit in a different CPUID function and on Intel, IBPB is set only when X86_FEATURE_SPEC_CTRL - see

[PATCH 7/9] clk: meson: fix pll with fractional part calculation

2018-01-18 Thread Jerome Brunet
The rate of the parent should not be multiplied by 2 when there is a fractional part to the pll. This is making the rate calculation of gxl_hdmi_pll wrong (and others as well). This multiplication is specific to the hdmi_pll of gxbb and is most likely due to a multiplier sitting in front of this

[PATCH 8/9] clk: meson: gxbb: add the fractional part of the fixed_pll

2018-01-18 Thread Jerome Brunet
The fixed_pll of gxbb and gxl also has a fractional parameter. This has not been a problem so far because fractional part is actually set to 0 on these platforms, so the rate remains correct when it is ignored. Still, it is better represent the pll the way it is, so add the frac parameter now

[PATCH 8/9] clk: meson: gxbb: add the fractional part of the fixed_pll

2018-01-18 Thread Jerome Brunet
The fixed_pll of gxbb and gxl also has a fractional parameter. This has not been a problem so far because fractional part is actually set to 0 on these platforms, so the rate remains correct when it is ignored. Still, it is better represent the pll the way it is, so add the frac parameter now

[PATCH 6/9] clk: meson: add gxl hdmi pll

2018-01-18 Thread Jerome Brunet
The hdmi pll used in the gxl family is actually different from the gxbb. The register layout is completely different, which explain why the hdmi pll rate has always been rubbish on the gxl. Adding the correct register field is the first part of the fix to get a correct rate out the hdmi pll

[PATCH 6/9] clk: meson: add gxl hdmi pll

2018-01-18 Thread Jerome Brunet
The hdmi pll used in the gxl family is actually different from the gxbb. The register layout is completely different, which explain why the hdmi pll rate has always been rubbish on the gxl. Adding the correct register field is the first part of the fix to get a correct rate out the hdmi pll

[PATCH 5/9] clk: meson: add od3 to the pll driver

2018-01-18 Thread Jerome Brunet
Some meson plls, such as the hdmi pll, are using a 3rd od parameter, which is yet another "power of 2" post divider. Add it to fix the calculation of the hdmi_pll rate Fixes: 738f66d3211d ("clk: gxbb: add AmLogic GXBB clk controller driver") Signed-off-by: Jerome Brunet ---

[PATCH 5/9] clk: meson: add od3 to the pll driver

2018-01-18 Thread Jerome Brunet
Some meson plls, such as the hdmi pll, are using a 3rd od parameter, which is yet another "power of 2" post divider. Add it to fix the calculation of the hdmi_pll rate Fixes: 738f66d3211d ("clk: gxbb: add AmLogic GXBB clk controller driver") Signed-off-by: Jerome Brunet ---

[PATCH 9/9] clk: meson: axg: add the fractional part of the fixed_pll

2018-01-18 Thread Jerome Brunet
The fixed_pll also has a fractional part. On axg s400 board, without this parameter, the calculated rate is off by ~8Mhz (0,4%). The fixed_pll being the root of peripheral clock tree, this error is propagated to the rest of the clocks Adding the definition of the parameter fixes the problem

[PATCH 9/9] clk: meson: axg: add the fractional part of the fixed_pll

2018-01-18 Thread Jerome Brunet
The fixed_pll also has a fractional part. On axg s400 board, without this parameter, the calculated rate is off by ~8Mhz (0,4%). The fixed_pll being the root of peripheral clock tree, this error is propagated to the rest of the clocks Adding the definition of the parameter fixes the problem

Re: [PATCH v5 29/44] ARM: da8xx: add new USB PHY clock init using common clock framework

2018-01-18 Thread David Lechner
On 01/18/2018 09:14 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +int __init da8xx_register_usb20_phy_clk(bool use_usb_refclkin) +{ + struct regmap *cfgchip; + struct clk *usb0_psc_clk, *clk; + struct clk_hw *parent; + + cfgchip =

Re: [PATCH v5 29/44] ARM: da8xx: add new USB PHY clock init using common clock framework

2018-01-18 Thread David Lechner
On 01/18/2018 09:14 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:47 AM, David Lechner wrote: +int __init da8xx_register_usb20_phy_clk(bool use_usb_refclkin) +{ + struct regmap *cfgchip; + struct clk *usb0_psc_clk, *clk; + struct clk_hw *parent; + + cfgchip =

[PATCH] x86/cpu: Drop needless fall-through comment

2018-01-18 Thread Kees Cook
This fall-through comment is both misspelled and unneeded (it appears between case statements, not between operations before a case statement). Signed-off-by: Kees Cook --- arch/x86/kernel/cpu/bugs.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] x86/cpu: Drop needless fall-through comment

2018-01-18 Thread Kees Cook
This fall-through comment is both misspelled and unneeded (it appears between case statements, not between operations before a case statement). Signed-off-by: Kees Cook --- arch/x86/kernel/cpu/bugs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/cpu/bugs.c

Re: [PATCH v5 43/44] ARM: da8xx-dt: switch to device tree clocks

2018-01-18 Thread David Lechner
On 01/18/2018 09:27 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:55 AM, David Lechner wrote: This removes all of the clock init code from da8xx-dt.c. This includes all of the OF_DEV_AUXDATA that was just used for looking up clocks. Note: You need to have clocks defined in your device

[RFC] perf: Allow fine-grained PMU access control

2018-01-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For situations where sysadmins might want to allow different level of of access control for different PMUs, we start creating per-PMU perf_event_paranoid controls in sysfs. These work in equivalent fashion as the existing perf_event_paranoid

Re: [PATCH v5 43/44] ARM: da8xx-dt: switch to device tree clocks

2018-01-18 Thread David Lechner
On 01/18/2018 09:27 AM, Sekhar Nori wrote: On Monday 08 January 2018 07:55 AM, David Lechner wrote: This removes all of the clock init code from da8xx-dt.c. This includes all of the OF_DEV_AUXDATA that was just used for looking up clocks. Note: You need to have clocks defined in your device

[RFC] perf: Allow fine-grained PMU access control

2018-01-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For situations where sysadmins might want to allow different level of of access control for different PMUs, we start creating per-PMU perf_event_paranoid controls in sysfs. These work in equivalent fashion as the existing perf_event_paranoid sysctl, which now becomes the

Re: [Resend Patch] KVM/x86: Fix wrong macro references of X86_CR0_PG_BIT and X86_CR4_PAE_BIT in kvm_valid_sregs()

2018-01-18 Thread Eric Biggers
On Tue, Jan 16, 2018 at 05:34:07PM +0800, Tianyu Lan wrote: > kvm_valid_sregs() should use X86_CR0_PG and X86_CR4_PAE to check bit > status rather than X86_CR0_PG_BIT and X86_CR4_PAE_BIT. This patch is > to fix it. > > Fixes: f29810335965a(KVM/x86: Check input paging mode when cs.l is set) >

Re: [Resend Patch] KVM/x86: Fix wrong macro references of X86_CR0_PG_BIT and X86_CR4_PAE_BIT in kvm_valid_sregs()

2018-01-18 Thread Eric Biggers
On Tue, Jan 16, 2018 at 05:34:07PM +0800, Tianyu Lan wrote: > kvm_valid_sregs() should use X86_CR0_PG and X86_CR4_PAE to check bit > status rather than X86_CR0_PG_BIT and X86_CR4_PAE_BIT. This patch is > to fix it. > > Fixes: f29810335965a(KVM/x86: Check input paging mode when cs.l is set) >

[PATCH 4/5] crypto: bfin_crc: Add empty hash export and import

2018-01-18 Thread Kamil Konieczny
Crypto framework requires export/import in async hash. If driver do not implement them, wrapper functions in framework will be used, and it will cause error during ahash alg registration (unless one disables crypto internal tests). To make change in framework and expose this requirement, I will

[PATCH 4/5] crypto: bfin_crc: Add empty hash export and import

2018-01-18 Thread Kamil Konieczny
Crypto framework requires export/import in async hash. If driver do not implement them, wrapper functions in framework will be used, and it will cause error during ahash alg registration (unless one disables crypto internal tests). To make change in framework and expose this requirement, I will

[PATCH 3/5] crypto: ux500/hash: Add empty export and import

2018-01-18 Thread Kamil Konieczny
Crypto framework requires export/import in async hash. If driver do not implement them, wrapper functions in framework will be used, and it will cause error during ahash alg registration (unless one disables crypto internal tests). To make change in framework and expose this requirement, I will

[PATCH 3/5] crypto: ux500/hash: Add empty export and import

2018-01-18 Thread Kamil Konieczny
Crypto framework requires export/import in async hash. If driver do not implement them, wrapper functions in framework will be used, and it will cause error during ahash alg registration (unless one disables crypto internal tests). To make change in framework and expose this requirement, I will

Re: [PATCH] PCI: dwc: dra7xx: add back CONFIG_PCI dependency for endpoint

2018-01-18 Thread Lorenzo Pieralisi
On Thu, Jan 18, 2018 at 05:39:02PM +0100, Arnd Bergmann wrote: [...] > > However, since pci_irqd_intx_xlate is only defined inside > > CONFIG_PCI, even 489f8fe6aa71 will not help. > > > > Not completely sure about this, but perhaps a better fix is: > > > > +++ b/include/linux/pci.h > > @@

Re: [PATCH] PCI: dwc: dra7xx: add back CONFIG_PCI dependency for endpoint

2018-01-18 Thread Lorenzo Pieralisi
On Thu, Jan 18, 2018 at 05:39:02PM +0100, Arnd Bergmann wrote: [...] > > However, since pci_irqd_intx_xlate is only defined inside > > CONFIG_PCI, even 489f8fe6aa71 will not help. > > > > Not completely sure about this, but perhaps a better fix is: > > > > +++ b/include/linux/pci.h > > @@

[PATCH 5/5] crypto: ahash.c: Require export/import in ahash

2018-01-18 Thread Kamil Konieczny
Export and import are mandatory in async hash. As drivers were rewritten, drop empty wrappers and correct init of ahash transformation. Signed-off-by: Kamil Konieczny --- crypto/ahash.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-)

[PATCH 5/5] crypto: ahash.c: Require export/import in ahash

2018-01-18 Thread Kamil Konieczny
Export and import are mandatory in async hash. As drivers were rewritten, drop empty wrappers and correct init of ahash transformation. Signed-off-by: Kamil Konieczny --- crypto/ahash.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/crypto/ahash.c

Re: [PATCH 29/35] x86/speculation: Add IPBP support

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 07:31:16PM +0100, Borislav Petkov wrote: > On Thu, Jan 18, 2018 at 02:48:29PM +0100, Peter Zijlstra wrote: > > From: Thomas Gleixner > > <--- Add commit message here. > > > Signed-off-by: Thomas Gleixner > > Signed-off-by: Peter

Re: [PATCH 29/35] x86/speculation: Add IPBP support

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 07:31:16PM +0100, Borislav Petkov wrote: > On Thu, Jan 18, 2018 at 02:48:29PM +0100, Peter Zijlstra wrote: > > From: Thomas Gleixner > > <--- Add commit message here. > > > Signed-off-by: Thomas Gleixner > > Signed-off-by: Peter Zijlstra (Intel) > > --- > >

<    3   4   5   6   7   8   9   10   11   12   >