Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

2019-03-08 Thread Tomasz Duszynski
On Fri, Mar 08, 2019 at 12:59:35PM -0500, Sven Van Asbroeck wrote: > This driver's probe() uses a mix of devm_ and non-devm_ functions. This > means that the remove order will not be the exact opposite of the probe > order. > > Remove order: > 1. remove() executes: > iio_device_unregister >

Re: [PATCH serial] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

2019-03-08 Thread Vladimir Zapolskiy
On 03/08/2019 04:09 PM, Mao Wenan wrote: > Add the missing uart_unregister_driver() and i2c_del_driver() before return > from sc16is7xx_init() in the error handling case. > > Signed-off-by: Mao Wenan > --- > drivers/tty/serial/sc16is7xx.c | 12 ++-- > 1 file changed, 10 insertions(+), 2

Re: [RFC PATCH ghak10 v6 0/2] audit: Log changes that can affect the system clock

2019-03-08 Thread Richard Guy Briggs
On 2019-03-07 13:32, Ondrej Mosnacek wrote: > This patchset implements auditing of (syscall-triggered) changes that > can modify or indirectly affect the system clock. Some of these > changes can already be detected by simply logging relevant syscalls, > but this has some disadvantages: > a) It

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-08 Thread Matthew Garrett
On Fri, Mar 8, 2019 at 10:43 AM Mimi Zohar wrote: > FYI, efi_printk() works before exit_boot(), but not afterwards. The > system hangs. efi_printk() uses boot services to print, so that's not unexpected :) It would probably be sensible to return an error rather than crash, though…

Re: [PATCH 17/20] objtool: Fix sibling call detection

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:28PM +0100, Peter Zijlstra wrote: > It turned out that we failed to detect some sibling calls; > specifically those without relocation records; like: > > $ ./objdump-func.sh defconfig-build/mm/kasan/generic.o __asan_loadN > 0840 <__asan_loadN>: >

Re: [PATCH v2 1/2] tracing: kdb: Fix ftdump to not sleep

2019-03-08 Thread Steven Rostedt
On Fri, 8 Mar 2019 11:32:04 -0800 Douglas Anderson wrote: > As reported back in 2016-11 [1], the "ftdump" kdb command triggers a > BUG for "sleeping function called from invalid context". > > kdb's "ftdump" command wants to call ring_buffer_read_prepare() in > atomic context. A very simple

Re: [PATCH 2/4] Add SUNIX Multi-I/O card device driver

2019-03-08 Thread Enrico Weigelt, metux IT consult
On 08.03.19 13:34, Morris Ku wrote: Hi, > diff --git a/char/snx/snx_main.c b/char/snx/snx_main.c if it's a serial card, shouldn't it go to drivers/tty/serial/snx/ ? > +char snx_ser_ic_table[SNX_SER_PORT_MAX_UART][10] = { > + {"UNKNOWN"}, > + {"SUN1889"}, > + {"SUN1699"}, > +

Re: [PATCH v7 2/2] drm/panel: Add Feiyang FY07024DI26A30-D MIPI-DSI LCD panel

2019-03-08 Thread Jagan Teki
Hi, On Thu, Feb 28, 2019 at 11:02 PM Jagan Teki wrote: > > Hi Thierry, > > On Tue, Feb 19, 2019 at 1:57 AM Sam Ravnborg wrote: > > > > Hi Thierry > > > > > Pleas let me know if you any further comments on this? > > No further comments from my side, and I consider it > > ready to apply. > >

Re: [PATCH 16/20] objtool: Rewrite alt->skip_orig

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:27PM +0100, Peter Zijlstra wrote: > Really skip the original instruction flow, instead of letting it > continue with NOPs. > > Since the alternative code flow already continues after the original > instructions, only the alt-original is skipped. I like this

Re: [PATCH 0/9] docs: Fix various build warnings/errors

2019-03-08 Thread Tobin C. Harding
On Fri, Mar 08, 2019 at 09:40:03AM +0100, Markus Heiser wrote: > > Am 07.03.19 um 22:11 schrieb Tobin C. Harding: > > Hi, > > > > I had a few hours to spare so I thought I'd clear some Sphinx build > > warnings/errors. There isn't anything too controversial here. The only > > interesting thing

Re: [PATCH] arm64: dts: rockchip: Add Nanopi NEO4 initial support

2019-03-08 Thread Rob Herring
On Fri, Mar 8, 2019 at 12:12 PM Jagan Teki wrote: > > FriendlyElec NanoPi NEO4 is known to be a revision 4 based > NanoPi4 series of boards. > > Most of know peripherals are shared between Nanopi M4 vs NEO4, except > - 1GB DDR3 > - USB Host ports > - Missing DSI port > - USB 2.0 Host with

[PATCH v2 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references

2019-03-08 Thread Dan Murphy
Remove the LM3532 backlight driver references from the ti-lmu code as dedicated driver support is available. Signed-off-by: Dan Murphy --- v2 - Removed LM3532 register definitions from ti-lmu-register - https://lore.kernel.org/patchwork/patch/1048808/ drivers/mfd/ti-lmu.c| 11

[PATCH v2 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-03-08 Thread Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control. The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings. Signed-off-by: Dan Murphy --- v2 - Added

[PATCH v2 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-03-08 Thread Dan Murphy
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately. Signed-off-by: Dan Murphy --- v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values, I did not change the

[PATCH v2 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-03-08 Thread Dan Murphy
Add the lm3532 device tree documentation. Remove lm3532 device tree reference from the ti_lmu devicetree documentation. With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt. The reason for this is that the lm3532 dt documentation now defines the

Re: [RFC 02/15] slub: Add isolate() and migrate() methods

2019-03-08 Thread Tycho Andersen
On Sat, Mar 09, 2019 at 06:53:22AM +1100, Tobin C. Harding wrote: > On Fri, Mar 08, 2019 at 09:22:37AM -0700, Tycho Andersen wrote: > > On Fri, Mar 08, 2019 at 04:15:46PM +, Christopher Lameter wrote: > > > On Fri, 8 Mar 2019, Tycho Andersen wrote: > > > > > > > On Fri, Mar 08, 2019 at

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-08 Thread Jerome Glisse
On Fri, Mar 08, 2019 at 02:48:45PM -0500, Andrea Arcangeli wrote: > Hello Jeson, > > On Fri, Mar 08, 2019 at 04:50:36PM +0800, Jason Wang wrote: > > Just to make sure I understand here. For boosting through huge TLB, do > > you mean we can do that in the future (e.g by mapping more userspace >

Re: [PATCH 13/20] objtool: Hande function aliases

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 08:52:54PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 01:23:58PM -0600, Josh Poimboeuf wrote: > > > > On Thu, Mar 07, 2019 at 12:45:24PM +0100, Peter Zijlstra wrote: > > > Function aliases result in different symbols for the same set of > > > instructions;

Re: [RFC 02/15] slub: Add isolate() and migrate() methods

2019-03-08 Thread Tobin C. Harding
On Fri, Mar 08, 2019 at 09:22:37AM -0700, Tycho Andersen wrote: > On Fri, Mar 08, 2019 at 04:15:46PM +, Christopher Lameter wrote: > > On Fri, 8 Mar 2019, Tycho Andersen wrote: > > > > > On Fri, Mar 08, 2019 at 03:14:13PM +1100, Tobin C. Harding wrote: > > > > diff --git a/mm/slab_common.c

Re: [PATCH 13/20] objtool: Hande function aliases

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:23:58PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 07, 2019 at 12:45:24PM +0100, Peter Zijlstra wrote: > > Function aliases result in different symbols for the same set of > > instructions; track a canonical symbol so there is a unique point of > > access. > > > >

Re: [PATCH 03/20] x86/uaccess: Move copy_user_handle_tail into asm

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 08:48:35PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 12:53:21PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 07, 2019 at 12:45:14PM +0100, Peter Zijlstra wrote: > > > /* > > > + * Try to copy last bytes and clear the rest if needed. > > > + * Since protection

Re: [PATCH 12/20] objtool: Set insn->func for alternatives

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:16:29PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote: > > Make sure we set the function association for alternative instruction > > sequences; they are after all still part of the function. > > Can you also say _why_? I

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > > hypercall_page() with UACCESS enabled > > > > Xen needs to do HV calls with AC=1 for

Re: [PATCH 03/20] x86/uaccess: Move copy_user_handle_tail into asm

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 12:53:21PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:14PM +0100, Peter Zijlstra wrote: > > /* > > + * Try to copy last bytes and clear the rest if needed. > > + * Since protection fault in copy_from/to_user is not a normal situation, > > + * it is not

Re: [PATCH V3 0/6] stmmac: add some fixes for stm32

2019-03-08 Thread David Miller
From: Christophe Roullier Date: Tue, 5 Mar 2019 09:29:22 +0100 > For common stmmac: > - Add support to set CSR Clock range selection in DT > For stm32mpu: > - Glue codes to support magic packet > - Glue codes to support all PHY config : > PHY_MODE (MII,GMII, RMII,

Re: [PATCH] tools/perf-bench: Add basic syscall benchmark

2019-03-08 Thread Mel Gorman
On Fri, Mar 08, 2019 at 10:17:47AM -0800, Davidlohr Bueso wrote: > On Thu, 07 Mar 2019, Arnaldo Carvalho de Melo wrote: > > You forgot to update tools/perf/Documentation/perf-bench.txt, and please > > take a look at tools/perf/util/pmu.c convert_scale() to see how to save > > the current locale,

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-08 Thread Andrea Arcangeli
Hello Jeson, On Fri, Mar 08, 2019 at 04:50:36PM +0800, Jason Wang wrote: > Just to make sure I understand here. For boosting through huge TLB, do > you mean we can do that in the future (e.g by mapping more userspace > pages to kenrel) or it can be done by this series (only about three 4K >

Re: [RFC][PATCH 00/16] sched: Core scheduling

2019-03-08 Thread Subhra Mazumdar
On 2/22/19 4:45 AM, Mel Gorman wrote: On Mon, Feb 18, 2019 at 09:49:10AM -0800, Linus Torvalds wrote: On Mon, Feb 18, 2019 at 9:40 AM Peter Zijlstra wrote: However; whichever way around you turn this cookie; it is expensive and nasty. Do you (or anybody else) have numbers for real loads?

[PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and remove blank line

2019-03-08 Thread Anderson Reis
Break the line 258 in order fit the line width on 80 characters. Remove the blank line 279, as the line before is also a blank line. Solve these checkpath.el WARNING and CHECK: - lmp91000.c:258: WARNING: line over 80 characters - lmp91000.c:279: CHECK: Please don't use multiple blank lines

[PATCH v2 0/4] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes

2019-03-08 Thread Anderson Reis
Hi, We solved some checkpath.el CHECKs and WARNINGs. We also inverted the arms of an if statement, in order to make the code smaller as the else statement was supressed. We also changed a dev_err message as requested Anderson Reis (3): iio:potentiostat:lmp91000: reduce line width and remove

[PATCH v2 4/4] iio:potentiostat:lmp91000: change dev_err message

2019-03-08 Thread Anderson Reis
Change dev_err message on line 215 in order to inform that tia-gain-ohm is not defined and an external resistor is not specified. Signed-off-by: Anderson Reis Signed-off-by: Lucas Oshiro --- drivers/iio/potentiostat/lmp91000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 3/4] iio:potentiostat:lmp91000: invert if statement

2019-03-08 Thread Anderson Reis
Invert if statement arms in line 214, in order to make the code cleaner, solve these checkpatch.pl CHECKs: - lmp9100.c:214: CHECK: braces {} should be used on all arms of this statement - lmp9100.c:216: CHECK: Unbalanced braces around else statement Signed-off-by: Lucas Oshiro Signed-off-by:

[PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses

2019-03-08 Thread Anderson Reis
From: Lucas Oshiro Remove unnecessary parentheses on line 116, and solve these checkpatch.pl CHECKs: - lmp91000.c:116: CHECK: Unnecessary parentheses around 'state != channel' - lmp91000.c:116: CHECK: Unnecessary parentheses around 'channel == LMP91000_REG_MODECN_TEMP' Signed-off-by: Lucas

Re: [RFC][Patch v9 2/6] KVM: Enables the kernel to isolate guest free pages

2019-03-08 Thread Nitesh Narayan Lal
On 3/8/19 2:25 PM, Alexander Duyck wrote: > On Fri, Mar 8, 2019 at 11:10 AM Nitesh Narayan Lal wrote: >> >> On 3/8/19 1:06 PM, Alexander Duyck wrote: >>> On Thu, Mar 7, 2019 at 6:32 PM Michael S. Tsirkin wrote: On Thu, Mar 07, 2019 at 02:35:53PM -0800, Alexander Duyck wrote: > The only

Re: [PATCH 0/5] x86/percpu semantics and fixes

2019-03-08 Thread Nadav Amit
> On Mar 8, 2019, at 6:50 AM, Peter Zijlstra wrote: > > On Wed, Feb 27, 2019 at 11:12:52AM +0100, Peter Zijlstra wrote: > >> This is a collection of x86/percpu changes that I had pending and got >> reminded >> of by Linus' comment yesterday about __this_cpu_xchg(). >> >> This tidies up the

Re: [PATCH 15/20] objtool: Add --backtrace support

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:26PM +0100, Peter Zijlstra wrote: > For when you want to know the path that reached your fail state. > > $ ./objtool check --no-fp --backtrace arch/x86/lib/usercopy_64.o > arch/x86/lib/usercopy_64.o: warning: objtool: .altinstr_replacement+0x3: > UACCESS disable

[PATCH v2 1/2] tracing: kdb: Fix ftdump to not sleep

2019-03-08 Thread Douglas Anderson
As reported back in 2016-11 [1], the "ftdump" kdb command triggers a BUG for "sleeping function called from invalid context". kdb's "ftdump" command wants to call ring_buffer_read_prepare() in atomic context. A very simple solution for this is to add allocation flags to

[PATCH v2 2/2] tracing: kdb: Allow ftdump to skip all but the last few lines

2019-03-08 Thread Douglas Anderson
The 'ftdump' command in kdb is currently a bit of a last resort, at least if you have lots of traces turned on. It's going to print a whole boatload of lines out your serial port which is probably running at 115200. This could easily take many, many minutes. Usually you're most interested in

Re: [PATCH 0/2] ata: libahci: devslp fixes

2019-03-08 Thread Rajat Jain
On Fri, Mar 8, 2019 at 12:57 AM Hans de Goede wrote: > > Hi, > > On 08-03-19 01:04, Srinivas Pandruvada wrote: > > On Thu, 2019-03-07 at 15:07 -0800, Rajat Jain wrote: > >> Hello, > >> > >> On Thu, Mar 7, 2019 at 12:37 PM Hans de Goede > >> wrote: > >>> > >>> Hi, > >>> > >>> On 07-03-19 21:27,

Re: [PATCH] nfsd: allow nfsv3 readdir request to be larger.

2019-03-08 Thread J. Bruce Fields
Thanks! Applied. On Thu, Mar 07, 2019 at 09:49:46AM +1100, NeilBrown wrote: > > nfsd currently reports the NFSv4 dtpref FSINFO parameter (Just changed NFSv4 here to NFSv3.)--b. > to be PAGE_SIZE, so NFS clients will typically ask for one > page of directory entries at a time. This is

Re: [PATCH 14/20] objtool: Rewrite add_ignores()

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:25PM +0100, Peter Zijlstra wrote: > @@ -436,18 +413,31 @@ static void add_ignores(struct objtool_f > struct instruction *insn; > struct section *sec; > struct symbol *func; > + struct rela *rela; > > - for_each_sec(file, sec) { > -

Re: [PATCH net] rxrpc: Fix client call connect/disconnect race

2019-03-08 Thread David Miller
From: David Howells Date: Fri, 08 Mar 2019 12:48:39 + > rxrpc_disconnect_client_call() reads the call's connection ID protocol > value (call->cid) as part of that function's variable declarations. This > is bad because it's not inside the locked section and so may race with > someone

Re: [Intel-gfx] [PATCH] drm/i915: Zero initialize this_cpu in busywait_stop

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 12:27 AM Chris Wilson wrote: > > Quoting Nathan Chancellor (2019-03-08 01:20:24) > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/gpu/drm/i915/i915_request.c:1032:6: warning: variable 'this_cpu' > > is used uninitialized whenever '&&' condition

Re: [RFC][Patch v9 2/6] KVM: Enables the kernel to isolate guest free pages

2019-03-08 Thread Alexander Duyck
On Fri, Mar 8, 2019 at 11:10 AM Nitesh Narayan Lal wrote: > > > On 3/8/19 1:06 PM, Alexander Duyck wrote: > > On Thu, Mar 7, 2019 at 6:32 PM Michael S. Tsirkin wrote: > >> On Thu, Mar 07, 2019 at 02:35:53PM -0800, Alexander Duyck wrote: > >>> The only other thing I still want to try and see if I

Grant Donation of €1,700,000

2019-03-08 Thread Maria Eliza
You were chosen to receive a Cash Grant Donation of €1,700,000 from Maria-Elisabeth Schaeffler, Respond back for more details email me at: patriciachandl...@gmail.com

Re: [PATCH 13/20] objtool: Hande function aliases

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:24PM +0100, Peter Zijlstra wrote: > Function aliases result in different symbols for the same set of > instructions; track a canonical symbol so there is a unique point of > access. > > Signed-off-by: Peter Zijlstra (Intel) s/Hande/Handle/ in $SUBJECT Also you

Re: [PATCH 12/20] objtool: Set insn->func for alternatives

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote: > Make sure we set the function association for alternative instruction > sequences; they are after all still part of the function. Can you also say _why_? I presume it's so the warning messages will be saner. > > Signed-off-by:

Re: [PATCH] nvmet-fc: use zero-sized array and struct_size() in kzalloc()

2019-03-08 Thread James Smart
On 2/23/2019 10:51 AM, Gustavo A. R. Silva wrote: Update the code to use a zero-sized array instead of a pointer in structure nvmet_fc_tgt_queue and use struct_size() in kzalloc(). Notice that one of the more common cases of allocation size calculations is finding the size of a structure that

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-08 Thread Andrea Arcangeli
On Fri, Mar 08, 2019 at 04:58:44PM +0800, Jason Wang wrote: > Can I simply can set_page_dirty() before vunmap() in the mmu notifier > callback, or is there any reason that it must be called within vumap()? I also don't see any problem in doing it before vunmap. As far as the mmu notifier and

Donation of €1,700,000.

2019-03-08 Thread Maria Eliza
You were chosen to receive a Cash Grant Donation of €1,700,000 from Maria-Elisabeth Schaeffler, Respond back for more details email me at: patriciachandl...@gmail.com

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-08 Thread Andrea Arcangeli
On Fri, Mar 08, 2019 at 05:13:26PM +0800, Jason Wang wrote: > Actually not wrapping around,  the pages for used ring was marked as > dirty after a round of virtqueue processing when we're sure vhost wrote > something there. Thanks for the clarification. So we need to convert it to

[PATCH] rcu/rcutorture: Fix expected forward progress duration in oom notifier

2019-03-08 Thread Neeraj Upadhyay
Fix a possible miscalculation in rcutorture_oom_notify(), for the expected forward progress duration of current forward progress test. Signed-off-by: Neeraj Upadhyay --- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c

Re: [RFC][Patch v9 2/6] KVM: Enables the kernel to isolate guest free pages

2019-03-08 Thread Nitesh Narayan Lal
On 3/8/19 1:06 PM, Alexander Duyck wrote: > On Thu, Mar 7, 2019 at 6:32 PM Michael S. Tsirkin wrote: >> On Thu, Mar 07, 2019 at 02:35:53PM -0800, Alexander Duyck wrote: >>> The only other thing I still want to try and see if I can do is to add >>> a jiffies value to the page private data in the

Re: [PATCH v6 4/4] hugetlb: allow to free gigantic pages regardless of the configuration

2019-03-08 Thread Mike Kravetz
On 3/7/19 5:20 AM, Alexandre Ghiti wrote: > On systems without CONTIG_ALLOC activated but that support gigantic pages, > boottime reserved gigantic pages can not be freed at all. This patch > simply enables the possibility to hand back those pages to memory > allocator. > > Signed-off-by:

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread Jerome Glisse
On Fri, Mar 08, 2019 at 03:08:40AM +, Christopher Lameter wrote: > On Wed, 6 Mar 2019, john.hubb...@gmail.com wrote: > > > > GUP was first introduced for Direct IO (O_DIRECT), allowing filesystem code > > to get the struct page behind a virtual address and to let storage hardware > > perform

RE: [PATCH v3 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-03-08 Thread Vishal Sagar
Hi Luca, Thanks for reviewing this. Sorry I missed out on replying to this earlier. I had already sent v4 but have requested to be ignored. Your comments will be addressed in the v5 patch series. > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 01:00:38PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > > hypercall_page() with UACCESS enabled > > > > Xen needs to do HV calls with AC=1 for

Re: [PATCH v6] pidns: introduce syscall translate_pid

2019-03-08 Thread Nagarathnam Muthusamy
On 11/8/18 7:49 PM, Dmitry V. Levin wrote: Hi, On Mon, Jul 16, 2018 at 10:57:48AM -0700, Nagarathnam Muthusamy wrote: On 06/01/2018 12:18 PM, Konstantin Khlebnikov wrote: Each process have different pids, one for each pid namespace it belongs. When interaction happens within single pid-ns

Re: [PATCH 1/1] MIPS: Ensure ELF appended dtb is relocated

2019-03-08 Thread Paul Burton
Hi Yasha, On Fri, Mar 08, 2019 at 02:58:51PM +0200, Yasha Cherikovsky wrote: > This fixes booting with the combination of CONFIG_RELOCATABLE=y > and CONFIG_MIPS_ELF_APPENDED_DTB=y. > > Sections that appear after the relocation table are not relocated > on system boot (except .bss, which has

Re: [PATCH 14/22] x86/fpu: Eager switch PKRU state

2019-03-08 Thread Dave Hansen
On 3/8/19 10:08 AM, Sebastian Andrzej Siewior wrote: > On 2019-02-25 10:16:24 [-0800], Dave Hansen wrote: >>> + if (!cpu_feature_enabled(X86_FEATURE_OSPKE)) >>> + return; >>> + >>> + if (current->mm) { >>> + pk = get_xsave_addr(_fpu->state.xsave, XFEATURE_PKRU); >>> +

Re: [PATCH 05/20] x86/uaccess/xen: Suppress SMAP warnings

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:16PM +0100, Peter Zijlstra wrote: > drivers/xen/privcmd.o: warning: objtool: privcmd_ioctl()+0x1414: call to > hypercall_page() with UACCESS enabled > > Xen needs to do HV calls with AC=1 for hysterical raisins. Make the > warning go away. > > XXX: arguably we

Re: [PATCH] nvme-core: Share code between nvme_wait_ready() and nvme_shutdown_ctrl()

2019-03-08 Thread Andrey Smirnov
On Fri, Mar 8, 2019 at 5:23 AM Christoph Hellwig wrote: > > On Wed, Feb 06, 2019 at 04:13:12PM -0800, Andrey Smirnov wrote: > > Code polling NVME_CSTS_SHST_CMPLT in nvme_shutdown_ctrl() is very > > similar to polling loop in nvme_wait_ready(). Move shared polling loop > > code into

Re: [RFC][Patch v9 2/6] KVM: Enables the kernel to isolate guest free pages

2019-03-08 Thread Michael S. Tsirkin
On Fri, Mar 08, 2019 at 10:06:14AM -0800, Alexander Duyck wrote: > On Thu, Mar 7, 2019 at 6:32 PM Michael S. Tsirkin wrote: > > > > On Thu, Mar 07, 2019 at 02:35:53PM -0800, Alexander Duyck wrote: > > > The only other thing I still want to try and see if I can do is to add > > > a jiffies value

Re: [PATCH 03/20] x86/uaccess: Move copy_user_handle_tail into asm

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:14PM +0100, Peter Zijlstra wrote: > /* > + * Try to copy last bytes and clear the rest if needed. > + * Since protection fault in copy_from/to_user is not a normal situation, > + * it is not necessary to optimize tail handling. > + * > + * Input: > + * rdi

Re: [PATCH v1] Bluetooth: hci_qca: Enable the ldisc for ROME for x86 platforms.

2019-03-08 Thread Matthias Kaehlcke
On Fri, Mar 08, 2019 at 10:43:14AM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2019-03-08 02:12, Matthias Kaehlcke wrote: > > Hi Balakrishna, > > > > On Thu, Mar 07, 2019 at 03:47:22PM +0530, Balakrishna Godavarthi wrote: > > > When using btattach to setup Rome over ldisc we

[PATCH] Bluetooth: hci_qca: Add helper function to get the chip family

2019-03-08 Thread Matthias Kaehlcke
Many functions obtain a 'struct qca_serdev' only to read the btsoc_type field. Add a helper function that encapsulates this. This also fixes crashes observed on platforms with ROME controllers that are instantiated through ldisc and not as serdev clients. The crashes are caused by NULL pointer

Re: [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node_put

2019-03-08 Thread Florian Fainelli
On 3/5/19 9:24 AM, Ray Jui wrote: > > > On 3/5/2019 3:33 AM, Wen Yang wrote: >> The call to of_get_next_child returns a node pointer with refcount >> incremented thus it must be explicitly decremented after the last >> usage. >> >> Detected by coccinelle with the following warnings: >>

Re: [PATCH] ARCv2: spinlock: remove the extra smp_mb before lock, after unlock

2019-03-08 Thread Vineet Gupta
On 3/8/19 12:37 AM, Peter Zijlstra wrote: > I'm thinking those assignments should be WRITE_ONCE() at the very least. Done !

[PATCH v5 3/7] psi: rename psi fields in preparation for psi trigger addition

2019-03-08 Thread Suren Baghdasaryan
Renaming psi_group structure member fields used for calculating psi totals and averages for clear distinction between them and trigger-related fields that will be added next. Signed-off-by: Suren Baghdasaryan --- include/linux/psi_types.h | 14 ++--- kernel/sched/psi.c| 41

Re: [PATCH v6 0/3] Stingray thermal driver support

2019-03-08 Thread Florian Fainelli
On 2/14/19 8:20 PM, Srinath Mannam wrote: > Hi Eduardo, > > Could you please provide your review comments? So it sounds like this driver was included in a pull request to Linus for 5.1 [1], although I did not see a response to that patch series, which would have helped synchronize the Device

Re: [PATCH v6 3/3] arm64: dts: stingray: Add Stingray Thermal DT support.

2019-03-08 Thread Florian Fainelli
On Thu, 3 Jan 2019 14:25:34 +0530, Srinath Mannam wrote: > From: Pramod Kumar > > Add DT nodes for thermal zones memory base address > to read temperature. > > Signed-off-by: Pramod Kumar > Signed-off-by: Srinath Mannam > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > --- Applied

[PATCH v5 4/7] psi: split update_stats into parts

2019-03-08 Thread Suren Baghdasaryan
Split update_stats into collect_percpu_times and update_averages for collect_percpu_times to be reused later inside psi monitor. Signed-off-by: Suren Baghdasaryan --- kernel/sched/psi.c | 55 +++--- 1 file changed, 32 insertions(+), 23 deletions(-) diff

[PATCH v5 5/7] psi: track changed states

2019-03-08 Thread Suren Baghdasaryan
Introduce changed_states parameter into collect_percpu_times to track the states changed since the last update. Signed-off-by: Suren Baghdasaryan --- kernel/sched/psi.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/kernel/sched/psi.c

[PATCH v5 7/7] psi: introduce psi monitor

2019-03-08 Thread Suren Baghdasaryan
Psi monitor aims to provide a low-latency short-term pressure detection mechanism configurable by users. It allows users to monitor psi metrics growth and trigger events whenever a metric raises above user-defined threshold within user-defined time window. Time window and threshold are both

[PATCH v5 6/7] refactor header includes to allow kthread.h inclusion in psi_types.h

2019-03-08 Thread Suren Baghdasaryan
kthread.h can't be included in psi_types.h because it creates a circular inclusion with kthread.h eventually including psi_types.h and complaining on kthread structures not being defined because they are defined further in the kthread.h. Resolve this by removing psi_types.h inclusion from the

[PATCH v5 2/7] psi: make psi_enable static

2019-03-08 Thread Suren Baghdasaryan
psi_enable is not used outside of psi.c, make it static. Suggested-by: Andrew Morton Signed-off-by: Suren Baghdasaryan --- kernel/sched/psi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 22c1505ad290..281702de9772 100644

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-08 Thread Mimi Zohar
On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > On Fri, Mar 8, 2019 at 5:40 AM Mimi Zohar wrote: > > > > On Thu, 2019-03-07 at 14:50 -0800, Matthew Garrett wrote: > > > Is the issue that it gives incorrect results on the first read, or is > > > the issue that it gives incorrect

[PATCH v5 1/7] psi: introduce state_mask to represent stalled psi states

2019-03-08 Thread Suren Baghdasaryan
The psi monitoring patches will need to determine the same states as record_times(). To avoid calculating them twice, maintain a state mask that can be consulted cheaply. Do this in a separate patch to keep the churn in the main feature patch at a minimum. This adds 4-byte state_mask member

[PATCH v5 0/7] psi: pressure stall monitors v5

2019-03-08 Thread Suren Baghdasaryan
This is respin of: https://lwn.net/ml/linux-kernel/20190206023446.177362-1-surenb%40google.com/ Android is adopting psi to detect and remedy memory pressure that results in stuttering and decreased responsiveness on mobile devices. Psi gives us the stall information, but because we're dealing

Re: [PATCH] xfs: clean up xfs_dir2_leafn_add

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 10:38 AM Darrick J. Wong wrote: > > On Fri, Mar 08, 2019 at 10:12:33AM -0800, Nick Desaulniers wrote: > > On Fri, Mar 8, 2019 at 8:13 AM Darrick J. Wong > > wrote: > > > > > > From: Darrick J. Wong > > > > > > Remove typedefs and consolidate local variable

Re: [PATCH v1 1/2] interconnect: Add support for path tags

2019-03-08 Thread Evan Green
On Fri, Feb 8, 2019 at 9:21 AM Georgi Djakov wrote: > > Consumers may have use cases with different bandwidth requirements based > on the system or driver state. The consumer driver can append a specific > tag to the path and pass this information to the interconnect platform > driver to do the

Re: [PATCH] tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 10:38 AM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > It's not

Re: [PATCH 07/11] perf session: Add __perf_session__process_dir_events function

2019-03-08 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 08, 2019 at 03:38:05PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Mar 08, 2019 at 02:47:41PM +0100, Jiri Olsa escreveu: > > +static int __perf_session__process_dir_events(struct perf_session *session) > > +{ > > + struct perf_data *data = session->data; > > + struct

Re: [PATCH] xfs: clean up xfs_dir2_leafn_add

2019-03-08 Thread Darrick J. Wong
On Fri, Mar 08, 2019 at 10:12:33AM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 8:13 AM Darrick J. Wong > wrote: > > > > From: Darrick J. Wong > > > > Remove typedefs and consolidate local variable initialization. > > > > Signed-off-by: Darrick J. Wong > > --- > >

[PATCH] tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

2019-03-08 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, Clang warns: drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] It's not wrong; when options is NULL, baud has no default value. Use 9600 as that

Re: [PATCH 07/11] perf session: Add __perf_session__process_dir_events function

2019-03-08 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 08, 2019 at 02:47:41PM +0100, Jiri Olsa escreveu: > Adding __perf_session__process_dir_events function > to process events over the directory data. > > All directory events are pushed into sessions ordered > data and flushed for processing. > > Link:

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König wrote: > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > > uninitialized whenever 'if'

[PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-03-08 Thread Johan Jonker
When a MK808 TV-stick with RK3066 processor is given a poweroff command, the monitor doesn't turn blank, but freezes. The VOP and HDMI share the same power domain, so that means that both there clocks were never turned off. Fix the disable of the VOP and HDMI TX by adding an extra shutdown

Re: [GIT PULL] livepatching for 5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 16:08:11 +0100 (CET): > git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git > for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b7af27bf9471f5d54d71dc2e4228d6bc065bdb57 Thank you! --

Re: [GIT PULL] hsi changes for hsi-5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 23:01:23 +0100: > ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git > tags/hsi-for-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7427e28688ed48b0a9484c4035f86e836d9787a2 Thank you! --

Re: [GIT PULL] Bulk GPIO changes for the v5.1 kernel cycle

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 10:35:57 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git > tags/gpio-v5.1-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a422bf11bdb4b95fc78e175339e8eed501e9c13c Thank you! --

Re: [GIT PULL] EDAC updates for 5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 11:21:56 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tags/edac_for_5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1b37b8c48d2c2d8553f116ec2a75d21056f1fb35 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] (swiotlb) stable/for-linus-5.1 branch

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 21:17:32 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git > stable/for-linus-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e4ff63b437e29d305dfc17eed69559354ad48167 Thank you! --

Re: [PATCH v1 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-03-08 Thread Evan Green
On Fri, Feb 8, 2019 at 9:22 AM Georgi Djakov wrote: > > From: David Dai > > Add support for wake and sleep commands by using a tag to indicate > whether or not the aggregate and set requests are active only or > dual context for a particular path. > > Signed-off-by: David Dai > Signed-off-by:

Re: [GIT PULL] RAS updates for 5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 15:16:45 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras-core-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e13284da944df29ab08e8a9d2a50fc0ad1d858ab Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] MFD for v5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Thu, 7 Mar 2019 09:38:28 +: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cf2e8c544cd3b33e9e403b7b72404c221bf888d1 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] (ibft) stable/for-linus-5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 21:18:30 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git > stable/for-linus-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/564e741171e92aaf095db403c5e9ed3b160e27e9 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] Backlight for v5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Thu, 7 Mar 2019 09:34:56 +: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git > backlight-next-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/04e0361848afbe86fbf8b80945568df4c5bf6f07 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] power-supply changes for 5.1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Tue, 5 Mar 2019 23:04:47 +0100: > ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git > tags/for-v5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1cabd3e0bd88d7ba9854cbb9213ef40eccad603b Thank you! --

Re: [GIT PULL] Thermal-SoC management changes for v5.1-rc1

2019-03-08 Thread pr-tracker-bot
The pull request you sent on Wed, 6 Mar 2019 08:12:09 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9f24a81e2e5daf8820c8654afcd8512e797c41f2 Thank you! -- Deet-doot-dot, I am a

<    1   2   3   4   5   6   7   8   9   10   >