Re: [PATCH v3 04/12] ppc64/kexec_file: avoid stomping memory used by special regions

2020-07-15 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > Hari Bathini writes: > >> diff --git a/arch/powerpc/include/asm/crashdump-ppc64.h >> b/arch/powerpc/include/asm/crashdump-ppc64.h >> new file mode 100644 >> index 000..90deb46 >> --- /dev/null >> +++ b/arch/powerpc/include/asm/crashdump-ppc64.h >> @@ -0,0

Re: [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver

2020-07-15 Thread Alexey Budankov
On 16.07.2020 2:59, David E. Box wrote: > On Wed, 2020-07-15 at 10:39 +0300, Alexey Budankov wrote: >> Hi David, >> >> On 14.07.2020 9:23, David E. Box wrote: > > ... > >>> >>> +static int pmt_telem_open(struct inode *inode, struct file *filp) >>> +{ >>> + struct pmt_telem_priv *priv; >>> +

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Anand Moon
Hi Vinod, On Thu, 16 Jul 2020 at 11:20, Vinod Koul wrote: > > On 13-07-20, 07:42, Anand Moon wrote: > > Instead of a busy waiting while loop using udelay > > use readl_poll_timeout function to check the condition > > is met or timeout occurs in crport_handshake function. > > readl_poll_timeout

Re: [PATCH v2 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

2020-07-15 Thread Andrii Nakryiko
On Tue, Jul 14, 2020 at 11:08 PM Song Liu wrote: > > Calling get_perf_callchain() on perf_events from PEBS entries may cause > unwinder errors. To fix this issue, the callchain is fetched early. Such > perf_events are marked with __PERF_SAMPLE_CALLCHAIN_EARLY. > > Similarly, calling

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Vinod Koul
On 13-07-20, 07:42, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to sleep until the condition

Re: [PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Marek Szyprowski
nction, it is broken and must be fixed. > > WARNING: CPU: 0 PID: 1 at drivers/base/core.c:1790 device_release+0x94/0xa4 > Device '53f9c000.gpio:50038000.ethernet' does not have a release() function, > it is broken and must be fixed. > > WARNING: CPU: 0 PID: 1 at drivers/base/core

[PATCH] remoteproc: qcom: pil-info: Fix shift overflow

2020-07-15 Thread Bjorn Andersson
On platforms with 32-bit phys_addr_t the shift to get the upper word of the base address of the memory region is invalid. Cast the base to 64 bit to resolv this. Fixes: 549b67da660d ("remoteproc: qcom: Introduce helper to store pil info in IMEM") Reported-by: Lee Jones Reported-by: Nathan

[PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-15 Thread Rajendra Nayak
Add an optional power domain which when specified can be used for setting the performance state of Venus. Signed-off-by: Rajendra Nayak --- This is a resend of https://lore.kernel.org/patchwork/patch/1241077/ Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml| 6 +-

[PATCH v2 4/4] arm64: dts: sc7180: Add OPP tables and power-domains for venus

2020-07-15 Thread Rajendra Nayak
Add the OPP tables in order to be able to vote on the performance state of a power-domain Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/4] media: venus: core: Add support for opp tables/perf voting

2020-07-15 Thread Rajendra Nayak
Add support to add OPP tables and perf voting on the OPP powerdomain. This is needed so venus votes on the corresponding performance state for the OPP powerdomain along with setting the core clock rate. Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke ---

[PATCH v2 3/4] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-15 Thread Rajendra Nayak
Add the OPP tables in order to be able to vote on the performance state of a power-domain. Signed-off-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/4] DVFS support for Venus

2020-07-15 Thread Rajendra Nayak
v2: Fixed up the labels of OPP nodes in patch 4 Included the bindings update patch as part of this series, a resend of https://lore.kernel.org/patchwork/patch/1241077/ These patches add DVFS support for Venus Patch 1 will need to be picked by Rob. Patch 2 will need to be picked by Stan,

Re: [PATCH v3 12/12] ppc64/kexec_file: fix kexec load failure with lack of memory hole

2020-07-15 Thread Thiago Jung Bauermann
Hari Bathini writes: > The kexec purgatory has to run in real mode. Only the first memory > block maybe accessible in real mode. And, unlike the case with panic > kernel, no memory is set aside for regular kexec load. Another thing > to note is, the memory for crashkernel is reserved at an

RE: [PATCH 16/24] scsi: megaraid: Fix a whole bunch of function header formatting issues

2020-07-15 Thread Chandrakanth Patil
Acked-by: Chandrakanth Patil -Original Message- From: linux-scsi-ow...@vger.kernel.org On Behalf Of Lee Jones Sent: Thursday, July 9, 2020 10:46 AM To: j...@linux.ibm.com; martin.peter...@oracle.com; linux-s...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Lee Jones ; Kashyap Desai

Re: [PATCH RFC don't apply] vdpa_sim: endian-ness for config space

2020-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2020 at 10:02:32PM +0800, Jason Wang wrote: > > On 2020/7/15 下午9:58, Michael S. Tsirkin wrote: > > VDPA sim stores config space as native endian, but that > > is wrong: modern guests expect LE. > > I coded up the following to fix it up, but it is wrong too: > > vdpasim_create is

Re: [PATCH 2/2] Input: elan_i2c - Modify the IAP related function for page sizes 128, 512 bytes.

2020-07-15 Thread Dmitry Torokhov
Hi Jingle, On Tue, Jul 14, 2020 at 06:56:41AM -0400, Jingle Wu wrote: > + if (!iap) > + cmd = ETP_I2C_FW_VERSION_CMD; > + else if (pattern_ver == 0) > + cmd = ETP_I2C_IAP_VERSION_CMD_OLD; Just to confirm, the older devices (I assume that pattern 0 means older)

[PATCH] rtc: pl031: fix alarm support

2020-07-15 Thread Marek Szyprowski
Commit 75a472845196 ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") adjusted driver to the new API, but during the conversion a call to enable alarm irq in set_alarm() was lost. Restore it, what fixes alarm support in the PL031 RTC driver. Fixes: 75a472845196 ("rtc: pl031: switch to

[PATCH] clk: qcom: ipq8074: Add correct index for PCIe clocks

2020-07-15 Thread Sivaprakash Murugesan
The PCIe clocks GCC_PCIE0_AXI_S_BRIDGE_CLK, GCC_PCIE0_RCHNG_CLK_SRC, GCC_PCIE0_RCHNG_CLK are wrongly added to the gcc reset group. Move them to the gcc clock group. Reported-by: kernel test robot Signed-off-by: Sivaprakash Murugesan --- include/dt-bindings/clock/qcom,gcc-ipq8074.h | 6 +++---

Re: [PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Matt Roper
On Wed, Jul 15, 2020 at 09:27:42PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable > 'ret' is uninitialized when used here [-Wuninitialized] > ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), >

Re: [PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Guenter Roeck
On 7/15/20 10:08 PM, Saravana Kannan wrote: > Marek and Guenter reported that commit 287905e68dd2 ("driver core: > Expose device link details in sysfs") caused sleeping/scheduling while > atomic warnings. > > BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:935 >

Re: [PATCH] time/sched_clock: Use raw_read_seqcount_latch()

2020-07-15 Thread Leo Yan
Hi Peter, Ahemd, On Wed, Jul 15, 2020 at 05:58:50PM +0200, Peter Zijlstra wrote: [...] > > > diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c > > > index fa3f800d7d76..ea007928d681 100644 > > > --- a/kernel/time/sched_clock.c > > > +++ b/kernel/time/sched_clock.c > > > @@

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Andy Lutomirski
> On Jul 15, 2020, at 9:15 PM, Nicholas Piggin wrote: > > Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: >> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >> >>> Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm:

[PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-07-15 Thread Bhanu Prakash Maiya
From: Bhanu Prakash Maiya Add DT compatible string in Documentation/devicetree/bindings/mfd/cros_ec.txt Signed-off-by: Bhanu Prakash Maiya --- Changes in v3: - Rebased changes on google,cros-ec.yaml Changes in v2: - No change Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 6

[PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

2020-07-15 Thread Bhanu Prakash Maiya
From: Bhanu Prakash Maiya This patch enables uart transport layer for cros_ec framework. The cros-ec-uart binds with EC device working on uart transport to send request and receive response. Signed-off-by: Bhanu Prakash Maiya --- Changes in v3: - checkpatch.pl script warns about char len 80

[PATCH v3 6/7] arm64: perf: Add cap_user_time_short

2020-07-15 Thread Leo Yan
From: Peter Zijlstra This completes the ARM64 cap_user_time support. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Leo Yan --- arch/arm64/kernel/perf_event.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/perf_event.c

[PATCH v3 7/7] tools headers UAPI: Update tools's copy of linux/perf_event.h

2020-07-15 Thread Leo Yan
To get the changes in the commit: "perf: Add perf_event_mmap_page::cap_user_time_short ABI" This update is a prerequisite to add support for short clock counters related ABI extension. Signed-off-by: Leo Yan --- tools/include/uapi/linux/perf_event.h | 23 --- 1 file

Re: [PATCH 2/2] debugfs: Add access restriction option

2020-07-15 Thread Randy Dunlap
Hi Peter, Here are a few more comments/corrections. On 7/15/20 9:54 PM, Peter Enderborg wrote: > Since debugfs include sensitive information it need to be treated > carefully. But it also has many very useful debug functions for userspace. > With this option we can have same configuration for

[PATCH v3 5/7] perf: Add perf_event_mmap_page::cap_user_time_short ABI

2020-07-15 Thread Leo Yan
From: Peter Zijlstra In order to support short clock counters, provide an ABI extension. As a whole: u64 time, delta, cyc = read_cycle_counter(); + if (cap_user_time_short) + cyc = time_cycle + ((cyc - time_cycle) & time_mask); delta = mul_u64_u32_shr(cyc, time_mult,

[PATCH v3 4/7] arm64: perf: Only advertise cap_user_time for arch_timer

2020-07-15 Thread Leo Yan
From: Peter Zijlstra When sched_clock is running on anything other than arch_timer, don't advertise cap_user_time*. Requested-by: Will Deacon Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Leo Yan --- arch/arm64/kernel/perf_event.c | 19 +-- 1 file changed, 13

[PATCH v3 1/7] sched_clock: Expose struct clock_read_data

2020-07-15 Thread Leo Yan
From: Peter Zijlstra In order to support perf_event_mmap_page::cap_time features, an architecture needs, aside from a userspace readable counter register, to expose the exact clock data so that userspace can convert the counter register into a correct timestamp. Provide struct clock_read_data

[PATCH v3 2/7] time/sched_clock: Use raw_read_seqcount_latch()

2020-07-15 Thread Leo Yan
From: "Ahmed S. Darwish" sched_clock uses seqcount_t latching to switch between two storage places protected by the sequence counter. This allows it to have interruptible, NMI-safe, seqcount_t write side critical sections. Since 7fc26327b756 ("seqlock: Introduce raw_read_seqcount_latch()"),

[PATCH v3 3/7] arm64: perf: Implement correct cap_user_time

2020-07-15 Thread Leo Yan
From: Peter Zijlstra As reported by Leo; the existing implementation is broken when the clock and counter don't intersect at 0. Use the sched_clock's struct clock_read_data information to correctly implement cap_user_time and cap_user_time_zero. Note that the ARM64 counter is architecturally

[PATCH v2] ASoC: soc-component: Add missed return for calling soc_component_ret

2020-07-15 Thread Shengjiu Wang
Add missed return for calling soc_component_ret, otherwise the return value is wrong. Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") Signed-off-by: Shengjiu Wang --- changes in v2 - add missed return in snd_soc_pcm_component_sync_stop and - snd_soc_pcm_component_new

[PATCH trivial] spi: Fix SPI NOR and SPI NAND acronyms

2020-07-15 Thread Tudor Ambarus
The industry refers to these flash types as "SPI NOR" and "SPI NAND". Be consistent and use the same acronyms. Signed-off-by: Tudor Ambarus --- drivers/spi/Kconfig| 10 +- drivers/spi/spi-fsl-qspi.c | 2 +- drivers/spi/spi-orion.c| 2 +- 3 files changed, 7 insertions(+), 7

Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC

2020-07-15 Thread Vinod Koul
Hi Alim, On 16-07-20, 06:47, Alim Akhtar wrote: > > > +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy > > > +*phy) { > > > + int ret = 0; > > > > superfluous init, am sure I flagged it before as well > > > Yes, you did, but 0-DAY CI kernel test gave warning [1], so I kept

[PATCH v3 0/7] arm64: perf: Proper cap_user_time* support

2020-07-15 Thread Leo Yan
This patch set is rebased for Peter's patch set to support cap_user_time/cap_user_time_short ABI for Arm64, and export Arm arch timer counter related parameters from kernel to Perf tool. After get feedback from Ahmed, this patch set contains Ahmed's new patch to refine sched clock data accessing

RE: [PATCH v2] powercap: Add Power Limit4 support

2020-07-15 Thread Pawnikar, Sumeet R
> -Original Message- > From: Srinivas Pandruvada > Sent: Wednesday, July 15, 2020 5:44 AM > To: Rafael J. Wysocki ; Pawnikar, Sumeet R > > Cc: Rafael J. Wysocki ; Zhang, Rui > ; Linux PM ; Linux Kernel > Mailing List ; Shevchenko, Andriy > > Subject: Re: [PATCH v2] powercap: Add Power

[PATCH v1] driver core: Fix scheduling while atomic warnings during device link deletion

2020-07-15 Thread Saravana Kannan
Marek and Guenter reported that commit 287905e68dd2 ("driver core: Expose device link details in sysfs") caused sleeping/scheduling while atomic warnings. BUG: sleeping function called from invalid context at kernel/locking/mutex.c:935 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 12,

Re: [External] Re: [PATCH v2] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy

2020-07-15 Thread Muchun Song
On Thu, Jul 16, 2020 at 1:54 AM Roman Gushchin wrote: > > On Thu, Jul 16, 2020 at 12:50:22AM +0800, Muchun Song wrote: > > If the kmem_cache refcount is greater than one, we should not > > mark the root kmem_cache as dying. If we mark the root kmem_cache > > dying incorrectly, the non-root

RE: [PATCH v2] powercap: Add Power Limit4 support

2020-07-15 Thread Pawnikar, Sumeet R
> -Original Message- > From: linux-pm-ow...@vger.kernel.org > On Behalf Of Rafael J. Wysocki > Sent: Tuesday, July 14, 2020 6:51 PM > To: Pawnikar, Sumeet R ; Srinivas > Pandruvada > Cc: Rafael J. Wysocki ; Zhang, Rui > ; Linux PM ; Linux Kernel > Mailing List ; Shevchenko, Andriy > >

Re: [PATCH v7 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-07-15 Thread Nathan Chancellor
On Mon, Jun 22, 2020 at 12:19:39PM -0700, Bjorn Andersson wrote: > A region in IMEM is used to communicate load addresses of remoteproc to > post mortem debug tools. Implement a helper function that can be used to > store this information in order to enable these tools to process > collected

Re: [PATCH v4 7/9] bus: mhi: core: Introduce debugfs entries and counters for MHI

2020-07-15 Thread Manivannan Sadhasivam
On Thu, Jul 09, 2020 at 12:33:02PM -0700, bbh...@codeaurora.org wrote: > On 2020-07-04 08:41, Manivannan Sadhasivam wrote: > > On Mon, Jun 29, 2020 at 09:39:40AM -0700, Bhaumik Bhatt wrote: > > > Introduce debugfs entries to show state, register, channel, and event > > > ring information. Add MHI

Re: WARNING in submit_bio_checks

2020-07-15 Thread syzbot
syzbot has bisected this issue to: commit 449325b52b7a6208f65ed67d3484fd7b7184477b Author: Alexei Starovoitov Date: Tue May 22 02:22:29 2018 + umh: introduce fork_usermode_blob() helper bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10fc4b0090 start commit:

[PATCH 2/2] debugfs: Add access restriction option

2020-07-15 Thread Peter Enderborg
Since debugfs include sensitive information it need to be treated carefully. But it also has many very useful debug functions for userspace. With this option we can have same configuration for system with need of debugfs and a way to turn it off. This gives a extra protection for exposure on

[PATCH v7 0/2] debugfs: Add access restriction option

2020-07-15 Thread Peter Enderborg
Since debugfs include sensitive information it need to be treated carefully. But it also has many very useful debug functions for userspace. With this option we can have same configuration for system with need of debugfs and a way to turn it off. This gives a extra protection for exposure on

[PATCH 1/2] tracefs: Remove unnecessary debug_fs checks.

2020-07-15 Thread Peter Enderborg
This is a preparation for debugfs restricted mode. We don't need debugfs to trace, the removed check stop tracefs to work if debugfs is not initialised. We instead tries to automount within debugfs and relay on it's handling. The code path is to create a backward compatibility from when tracefs

Re: [PATCH v3] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-15 Thread Michael Ellerman
Daniel Axtens writes: > Hi Nayna, > > Looks good to me. > > Sorry for not noticing this before, but I think >> +#include > is now superfluous (I think it's leftover from the machine_is > version?). Maybe mpe will take pity on you and remove it when he picks > up your patch. Yeah I did that.

Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

2020-07-15 Thread Shengjiu Wang
On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto wrote: > > > Hi Shengjiu > > > Add missed return for snd_soc_pcm_component_mmap, otherwise it always > > return -EINVAL. > > > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > > Signed-off-by: Shengjiu Wang > > --- > >

[PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

2020-07-15 Thread Nathan Chancellor
Clang warns: drivers/net/ethernet/intel/igc/igc_mac.c:374:6: warning: variable 'link' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!mac->get_link_status) { ^ drivers/net/ethernet/intel/igc/igc_mac.c:424:33: note:

RE: [PATCH v2] panic: prevent panic_timeout * 1000 from overflow

2020-07-15 Thread charley.ashbringer
> > Since panic_timeout is an integer passed-in through sysctl, > > the loop boundary panic_timeout * 1000 could overflow and > > result in a zero-delay panic when panic_timeout is greater > > than INT_MAX/1000. > > > > Fix this by moving 1000 to the left, also in case i/1000 > > might never be

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of July 16, 2020 2:15 pm: > Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: >> - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: >> >>> Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm:

RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-15 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM > > Hi Shimoda-san, > > On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda > wrote: > > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > > On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar > > >

[PATCH] riscv: Add SiFive drivers to rv32_defconfig

2020-07-15 Thread Bin Meng
From: Bin Meng This adds SiFive drivers to rv32_defconfig, to keep in sync with the 64-bit config. This is useful when testing 32-bit kernel with QEMU 'sifive_u' 32-bit machine. Signed-off-by: Bin Meng --- arch/riscv/configs/rv32_defconfig | 5 + 1 file changed, 5 insertions(+) diff

[PATCH] spi: atmel-quadspi: Use optimezed memcpy_fromio()/memcpy_toio()

2020-07-15 Thread Tudor Ambarus
Optimezed mem*io operations are defined for LE platforms, use them. The ARM and !ARCH_EBSA110 dependencies for COMPILE_TEST were added only for the _memcpy_fromio()/_memcpy_toio() functions. Drop these dependencies. Tested unaligned accesses on both sama5d2 and sam9x60 QSPI controllers using SPI

[PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), ^~~ drivers/gpu/drm/i915/display/intel_combo_phy.c:261:10:

[PATCH] can: m_can: Set device to software init mode before closing

2020-07-15 Thread Faiz Abbas
There might be some requests pending in the buffer when the interface close sequence occurs. In some devices, these pending requests might lead to the module not shutting down properly when m_can_clk_stop() is called. Therefore, move the device to init state before potentially powering it down.

[PATCH v3 3/4] regulator: core: Add basic enable/disable support for sync_state() callbacks

2020-07-15 Thread Saravana Kannan
Consider the following example: - regulator-X is provided by device-X. - regulator-X is a supplier to device-A, device-B and device-C. - device-A is off/inactive from boot. - device-B and device-C are left on/active by the bootloader - regulator-X is left on boot by the bootloader at 2000 mV to

[PATCH v3 4/4] regulator: core: Add voltage support for sync_state() callbacks

2020-07-15 Thread Saravana Kannan
Consider the following example: - regulator-X is provided by device-X. - regulator-X is a supplier to device-A, device-B and device-C. - device-A is off/inactive from boot. - device-B and device-C are left on/active by the bootloader - regulator-X is left on boot by the bootloader at 2000 mV to

[PATCH v3 1/4] driver core: Add dev_set_drv_sync_state()

2020-07-15 Thread Saravana Kannan
This can be used by frameworks to set the sync_state() helper functions for drivers that don't already have them set. Signed-off-by: Saravana Kannan --- include/linux/device.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index

[PATCH v3 2/4] regulator: core: Add destroy_regulator()

2020-07-15 Thread Saravana Kannan
Part of the regulator_get() code is already factored out into create_regulator(). This patch factors out some of the regulator_put() code into destroy_regulator() so that create_regulator() has a corresponding unwind function. Subsequent patches will use this function. Signed-off-by: Saravana

[PATCH v3 0/4] regulator_sync_state() support

2020-07-15 Thread Saravana Kannan
Consider the following example: - regulator-X is provided by device-X. - regulator-X is a supplier to device-A, device-B and device-C. - device-A is off/inactive from boot. - device-B and device-C are left on/active by the bootloader - regulator-X is left on boot by the bootloader at 2000 mV to

Re: kernel BUG at net/core/dev.c:LINE! (3)

2020-07-15 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:4ff91fa0 Merge branch 'udp_tunnel-NIC-RX-port-offload-infr.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1777b9bf10 kernel config:

Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

2020-07-15 Thread Kuninori Morimoto
Hi Shengjiu > Add missed return for snd_soc_pcm_component_mmap, otherwise it always > return -EINVAL. > > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") > Signed-off-by: Shengjiu Wang > --- Oops, indeed. Thank you for the patch. But it seems these functions are also

Re: [PATCH 3/3 v3] usb: typec: tcpm: Stay in BIST mode till hardreset or unattached

2020-07-15 Thread Guenter Roeck
On 7/15/20 8:41 PM, Badhri Jagan Sridharan wrote: > Port starts to toggle when transitioning to unattached state. > This is incorrect while in BIST mode. > > 6.4.3.1 BIST Carrier Mode > Upon receipt of a BIST Message, with a BIST Carrier Mode BIST Data Object, > the UUT Shall send out a

Re: [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode

2020-07-15 Thread Nicholas Piggin
Excerpts from Mathieu Desnoyers's message of July 14, 2020 12:13 am: > - On Jul 13, 2020, at 9:47 AM, Nicholas Piggin npig...@gmail.com wrote: > >> Excerpts from Nicholas Piggin's message of July 13, 2020 2:45 pm: >>> Excerpts from Andy Lutomirski's message of July 11, 2020 3:04 am:

Re: [PATCH v8 6/7] arm64: dts: add dts nodes for MT6779

2020-07-15 Thread Hanks Chen
On Tue, 2020-07-14 at 20:14 +0200, Matthias Brugger wrote: > > On 14/07/2020 11:20, Hanks Chen wrote: > > this adds initial MT6779 dts settings for board support, > > including cpu, gic, timer, ccf, pinctrl, uart, sysirq...etc. > > > > Signed-off-by: Hanks Chen > > --- > >

[PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap

2020-07-15 Thread Shengjiu Wang
Add missed return for snd_soc_pcm_component_mmap, otherwise it always return -EINVAL. Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()") Signed-off-by: Shengjiu Wang --- sound/soc/soc-component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

2020-07-15 Thread Wang Hai
If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) should be called to free the ndev created earlier. Otherwise, a memleak will occur. Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting") Reported-by: Hulk Robot Signed-off-by: Wang Hai ---

Re: [PATCH v12 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

2020-07-15 Thread Yicong Yang
Hi Bjorn, Thanks for the comments. On 2020/7/15 5:10, Bjorn Helgaas wrote: > [+cc Lorenzo] > > On Mon, Jul 13, 2020 at 03:10:19PM +0100, Shiju Jose wrote: >> From: Yicong Yang >> >> The HiSilicon HIP PCIe controller is capable of handling errors >> on root port and perform port reset

Re: [PATCH 3/9 v2 net-next] net: wimax: fix duplicate words in comments

2020-07-15 Thread Jakub Kicinski
On Wed, 15 Jul 2020 20:35:34 -0700 Randy Dunlap wrote: > On 7/15/20 8:34 PM, Jakub Kicinski wrote: > > On Wed, 15 Jul 2020 09:42:40 -0700 Randy Dunlap wrote: > >> /* > >> - * CPP sintatic sugar to generate A_B like symbol names when one of > >> - * the arguments is a a preprocessor #define. >

[PATCH 0/3] KVM: VMX: Clean up RTIT MAXPHYADDR usage

2020-07-15 Thread Sean Christopherson
Stop using cpuid_query_maxphyaddr() for a random RTIT MSR check and unexport said function to discourage future use. Sean Christopherson (3): KVM: VMX: Use precomputed MAXPHYADDR for RTIT base MSR check KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function KVM: x86: Unexport

[PATCH 3/3] KVM: x86: Unexport cpuid_query_maxphyaddr()

2020-07-15 Thread Sean Christopherson
Stop exporting cpuid_query_maxphyaddr() now that it's not being abused by VMX. Signed-off-by: Sean Christopherson --- arch/x86/kvm/cpuid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 7d92854082a14..e4a8065fbddd7 100644 ---

[PATCH 1/3] KVM: VMX: Use precomputed MAXPHYADDR for RTIT base MSR check

2020-07-15 Thread Sean Christopherson
Use cpuid_maxphyaddr() instead of cpuid_query_maxphyaddr() for the RTIT base MSR check. There is no reason to recompute MAXPHYADDR as the precomputed version is synchronized with CPUID updates, and MSR_IA32_RTIT_OUTPUT_BASE is not written between stuffing CPUID and refreshing

[PATCH 2/3] KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function

2020-07-15 Thread Sean Christopherson
Replace the subtly not-a-constant MSR_IA32_RTIT_OUTPUT_BASE_MASK with a proper helper function to check whether or not the specified base is valid. Blindly referencing the local 'vcpu' is especially nasty. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 11 +++ 1 file

Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver

2020-07-15 Thread Neal Liu
Hi Chun-Kuang, On Thu, 2020-07-16 at 07:46 +0800, Chun-Kuang Hu wrote: > HI, Neal: > > Neal Liu 於 2020年7月9日 週四 下午5:13寫道: > > > > MediaTek bus fabric provides TrustZone security support and data > > protection to prevent slaves from being accessed by unexpected > > masters. > > The security

[PATCH 3/9] KVM: VMX: Drop a duplicate declaration of construct_eptp()

2020-07-15 Thread Sean Christopherson
Remove an extra declaration of construct_eptp() from vmx.h. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h index 0d06951e607ce..0e8d25b0cec35 100644 --- a/arch/x86/kvm/vmx/vmx.h

[PATCH 8/9] KVM: x86/mmu: Rename max_page_level to max_huge_page_level

2020-07-15 Thread Sean Christopherson
Rename max_page_level to explicitly call out that it tracks the max huge page level so as to avoid confusion when a future patch moves the max TDP level, i.e. max root level, into the MMU and kvm_configure_mmu(). Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 14 +++---

[PATCH 2/3 v3] usb: typec: tcpci: Support BIST test data mode for compliance.

2020-07-15 Thread Badhri Jagan Sridharan
Quoting from TCPCI spec: "Setting this bit to 1 is intended to be used only when a USB compliance tester is using USB BIST Test Data to test the PHY layer of the TCPC. The TCPM should clear this bit when a disconnect is detected. 0: Normal Operation. Incoming messages enabled by RECEIVE_DETECT

[PATCH 3/3 v3] usb: typec: tcpm: Stay in BIST mode till hardreset or unattached

2020-07-15 Thread Badhri Jagan Sridharan
Port starts to toggle when transitioning to unattached state. This is incorrect while in BIST mode. 6.4.3.1 BIST Carrier Mode Upon receipt of a BIST Message, with a BIST Carrier Mode BIST Data Object, the UUT Shall send out a continuous string of BMC encoded alternating "1"s and “0”s. The UUT

[PATCH 6/9] KVM: VXM: Remove temporary WARN on expected vs. actual EPTP level mismatch

2020-07-15 Thread Sean Christopherson
Remove the WARN in vmx_load_mmu_pgd() that was temporarily added to aid bisection/debug in the event the current MMU's shadow root level didn't match VMX's computed EPTP level. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH 4/9] KVM: VMX: Make vmx_load_mmu_pgd() static

2020-07-15 Thread Sean Christopherson
Make vmx_load_mmu_pgd() static as it is no longer invoked directly by nested VMX (or any code for that matter). No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 2 +- arch/x86/kvm/vmx/vmx.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)

[PATCH 0/9] KVM: x86: TDP level cleanups and shadow NPT fix

2020-07-15 Thread Sean Christopherson
The primary purpose of this series is to implement a suggestion from Paolo to have the MMU make the decision between 4 and 5 level EPT/TDP (when 5-level page tables are supported). Having the MMU "own" the decision of whether or not to use 5-level paging leads to a variety of nice cleanups, and

[PATCH 7/9] KVM: x86: Dynamically calculate TDP level from max level and MAXPHYADDR

2020-07-15 Thread Sean Christopherson
Calculate the desired TDP level on the fly using the max TDP level and MAXPHYADDR instead of doing the same when CPUID is updated. This avoids the hidden dependency on cpuid_maxphyaddr() in vmx_get_tdp_level() and also standardizes the "use 5-level paging iff MAXPHYADDR > 48" behavior across x86.

[PATCH 5/9] KVM: x86: Pull the PGD's level from the MMU instead of recalculating it

2020-07-15 Thread Sean Christopherson
Use the shadow_root_level from the current MMU as the root level for the PGD, i.e. for VMX's EPTP. This eliminates the weird dependency between VMX and the MMU where both must independently calculate the same root level for things to work correctly. Temporarily keep VMX's calculation of the

[PATCH 2/9] KVM: x86/mmu: Add separate helper for shadow NPT root page role calc

2020-07-15 Thread Sean Christopherson
Refactor the shadow NPT role calculation into a separate helper to better differentiate it from the non-nested shadow MMU, e.g. the NPT variant is never direct and derives its root level from the TDP level. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 30

[PATCH 1/3 v3] usb: typec: tcpm: Support bist test data mode for compliance

2020-07-15 Thread Badhri Jagan Sridharan
TCPM supports BIST carried mode. PD compliance tests require BIST Test Data to be supported as well. Introducing set_bist_data callback to signal tcpc driver for configuring the port controller hardware to enable/disable BIST Test Data mode. Signed-off-by: Badhri Jagan Sridharan Reviewed-by:

[PATCH 1/9] KVM: nSVM: Correctly set the shadow NPT root level in its MMU role

2020-07-15 Thread Sean Christopherson
Move the initialization of shadow NPT MMU's shadow_root_level into kvm_init_shadow_npt_mmu() and explicitly set the level in the shadow NPT MMU's role to be the TDP level. This ensures the role and MMU levels are synchronized and also initialized before __kvm_mmu_new_pgd(), which consumes the

[PATCH 9/9] KVM: x86: Specify max TDP level via kvm_configure_mmu()

2020-07-15 Thread Sean Christopherson
Capture the max TDP level during kvm_configure_mmu() instead of using a kvm_x86_ops hook to do it at every vCPU creation. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_host.h | 4 ++-- arch/x86/kvm/mmu/mmu.c | 9 ++--- arch/x86/kvm/svm/svm.c | 3 +--

Re: [PATCH net-next] net: phy: sfp: Cotsworks SFF module EEPROM fixup

2020-07-15 Thread Florian Fainelli
On 7/15/2020 8:32 PM, Chris Healy wrote: > > > On Wed, Jul 15, 2020 at 8:10 PM Florian Fainelli > wrote: > > > > On 7/14/2020 10:59 AM, Chris Healy wrote: > > Some Cotsworks SFF have invalid data in the first few bytes of the > > module EEPROM. 

Re: [TEGRA194_CPUFREQ PATCH v6 3/3] cpufreq: Add Tegra194 cpufreq driver

2020-07-15 Thread Viresh Kumar
On 15-07-20, 20:57, Sumit Gupta wrote: > Sorry, missed to remove this. Will wait if any other comments before > re-spin. I don't have any further comments, maybe just send a new version of this patch alone and name it v6.1. -- viresh

Re: [PATCH 3/9 v2 net-next] net: wimax: fix duplicate words in comments

2020-07-15 Thread Randy Dunlap
On 7/15/20 8:34 PM, Jakub Kicinski wrote: > On Wed, 15 Jul 2020 09:42:40 -0700 Randy Dunlap wrote: >> /* >> - * CPP sintatic sugar to generate A_B like symbol names when one of >> - * the arguments is a a preprocessor #define. >> + * CPP syntatic sugar to generate A_B like symbol names when one

Re: [PATCH 3/9 v2 net-next] net: wimax: fix duplicate words in comments

2020-07-15 Thread Jakub Kicinski
On Wed, 15 Jul 2020 09:42:40 -0700 Randy Dunlap wrote: > /* > - * CPP sintatic sugar to generate A_B like symbol names when one of > - * the arguments is a a preprocessor #define. > + * CPP syntatic sugar to generate A_B like symbol names when one of synta*c*tic Let me fix that up before

Re: [PATCH 1/1] staging: android: ashmem: Fix lockdep warning for write operation

2020-07-15 Thread Eric Biggers
On Wed, Jul 15, 2020 at 07:45:27PM -0700, Suren Baghdasaryan wrote: > syzbot report [1] describes a deadlock when write operation against an > ashmem fd executed at the time when ashmem is shrinking its cache results > in the following lock sequence: > > Possible unsafe locking scenario: > >

Re: [PATCH 2/2] debugfs: Add access restriction option

2020-07-15 Thread Randy Dunlap
Hi, On 7/15/20 8:25 AM, Peter Enderborg wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 9ad9210d70a1..aec81f38bfce 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -476,6 +476,38 @@ config DEBUG_FS > > If unsure, say N. > > +choice > + prompt

Re: [PATCH] opp: Increase parsed_static_opps on _of_add_opp_table_v1

2020-07-15 Thread Viresh Kumar
On 15-07-20, 23:54, Walter Lozano wrote: > Currently, when using _of_add_opp_table_v2 parsed_static_opps is > increased and this value is used on _opp_remove_all_static to > check if there are static opps entries that need to be freed. > Unfortunately this does not happens when using

Re: [PATCH] SUNDANCE NETWORK DRIVER: Replace HTTP links with HTTPS ones

2020-07-15 Thread Joe Perches
On Wed, 2020-07-15 at 17:44 -0700, Jakub Kicinski wrote: > On Thu, 9 Jul 2020 22:49:25 +0200 Alexander A. Klimov wrote: > > Rationale: > > Reduces attack surface on kernel devs opening the links for MITM > > as HTTPS traffic is much harder to manipulate. > > > > Deterministic algorithm: > > For

Re: [PATCH v2 0/2] psi: enhance psi with the help of ebpf

2020-07-15 Thread Yafang Shao
On Thu, Jul 16, 2020 at 12:36 AM Shakeel Butt wrote: > > Hi Yafang, > > On Tue, Mar 31, 2020 at 3:05 AM Yafang Shao wrote: > > > > PSI gives us a powerful way to anaylze memory pressure issue, but we can > > make it more powerful with the help of tracepoint, kprobe, ebpf and etc. > > Especially

[PATCH v4 7/8] irqchip/loongson-liointc: Fix potential dead lock

2020-07-15 Thread Tiezhu Yang
In the function liointc_set_type(), we need to call the function irq_gc_unlock_irqrestore() before returning. Fixes: dbb152267908 ("irqchip: Add driver for Loongson I/O Local Interrupt Controller") Reported-by: Jianmin Lv Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-loongson-liointc.c |

[PATCH v4 5/8] irqchip/loongson-pch-pic: Check return value of irq_domain_translate_twocell()

2020-07-15 Thread Tiezhu Yang
Check the return value of irq_domain_translate_twocell() due to it may returns -EINVAL if failed and use variable fwspec for it, and then use a new variable parent_fwspec which is proper for irq_domain_alloc_irqs_parent(). Fixes: ef8c01eb64ca ("irqchip: Add Loongson PCH PIC controller")

[RESEND v13 03/11] KVM: VMX: Set guest CET MSRs per KVM and host configuration

2020-07-15 Thread Yang Weijiang
CET MSRs pass through guest directly to enhance performance. CET runtime control settings are stored in MSR_IA32_{U,S}_CET, Shadow Stack Pointer(SSP) are stored in MSR_IA32_PL{0,1,2,3}_SSP, SSP table base address is stored in MSR_IA32_INT_SSP_TAB, these MSRs are defined in kernel and re-used here.

  1   2   3   4   5   6   7   8   9   10   >