Re: [PATCH] bus: mhi: core: debugfs: Use correct format specifiers for addresses

2020-09-25 Thread Greg KH
On Sat, Sep 26, 2020 at 10:57:42AM +0530, Manivannan Sadhasivam wrote: > On Fri, Sep 25, 2020 at 12:01:54PM -0600, Jeffrey Hugo wrote: > > On 9/25/2020 11:16 AM, Manivannan Sadhasivam wrote: > > > For exposing the addresses of read/write pointers and doorbell register, > > > let's use the correct

Re: [PATCH] bus: mhi: core: debugfs: Use correct format specifiers for addresses

2020-09-25 Thread Manivannan Sadhasivam
On Fri, Sep 25, 2020 at 12:01:54PM -0600, Jeffrey Hugo wrote: > On 9/25/2020 11:16 AM, Manivannan Sadhasivam wrote: > > For exposing the addresses of read/write pointers and doorbell register, > > let's use the correct format specifiers. This fixes the following issues > > generated using W=1

Re: [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

2020-09-25 Thread Coiby Xu
On Fri, Sep 25, 2020 at 10:57:27AM -0500, Alex Elder wrote: On 9/25/20 9:07 AM, Coiby Xu wrote: On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote: On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote: Use __8 to replace int and remove the unnecessary __bitwise type

Re: [PATCH] Documentation/llvm: Fix clang target examples

2020-09-25 Thread Masahiro Yamada
On Sat, Sep 26, 2020 at 3:52 AM Nick Desaulniers wrote: > > On Fri, Sep 25, 2020 at 8:21 AM Florian Fainelli wrote: > > > > clang --target= is how we can specify a particular toolchain > > triple to be use, fix the two occurences in the documentation. > > Ah right, my mistake. It's either

[PATCH] drm/msm/dp: DisplayPort PHY compliance tests fixup

2020-09-25 Thread Tanmay Shah
Bandwidth code was being used as test link rate. Fix this by converting bandwidth code to test link rate Do not reset voltage and pre-emphasis level during IRQ HPD attention interrupt. Also fix pre-emphasis parsing during test link status process Signed-off-by: Tanmay Shah ---

RE: [PATCH v1 3/3] dt-bindings: riscv: convert pwm bindings to json-schema

2020-09-25 Thread Sagar Kadam
Hello Rob, > -Original Message- > From: Rob Herring > Sent: Wednesday, September 23, 2020 2:07 AM > To: Sagar Kadam > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > ri...@lists.infradead.org; devicet...@vger.kernel.org; linux- > c...@vger.kernel.org;

[PATCH] mm,slab_common: use list_for_each_entry in dump_unreclaimable_slab()

2020-09-25 Thread Hui Su
dump_unreclaimable_slab() acquires the slab_mutex first, and it won't remove any slab_caches list entry when itering the slab_caches lists. Thus, we do not need list_for_each_entry_safe here, which is against removal of list entry. Signed-off-by: Hui Su --- mm/slab_common.c | 4 ++-- 1 file

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread Kees Cook
On Fri, Sep 25, 2020 at 07:47:47PM -0700, Andy Lutomirski wrote: > > > On Sep 25, 2020, at 6:23 PM, YiFei Zhu wrote: > > > > On Fri, Sep 25, 2020 at 4:07 PM Andy Lutomirski > > wrote: > >> We'd need at least three states per syscall: unknown, always-allow, > >> and need-to-run-filter. > >>

RE: [RFC PATCH] RISC-V: Use SBI SRST extension when available

2020-09-25 Thread Anup Patel
> -Original Message- > From: Anup Patel > Sent: 25 September 2020 17:01 > To: Palmer Dabbelt ; Palmer Dabbelt > ; Paul Walmsley ; > Albert Ou > Cc: Atish Patra ; Alistair Francis > ; Anup Patel ; linux- > ri...@lists.infradead.org; linux-kernel@vger.kernel.org; Anup Patel > >

RE: [PATCH] [v2] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-25 Thread Tianxianting
Hi Jens Thanks a lot for the comments, I think it is not hot path, it is only called when system startup or device hot-plugging. So I submitted V3 patch for you reviewing :) https://lkml.org/lkml/2020/9/25/1543 -Original Message- From: Jens Axboe [mailto:ax...@kernel.dk] Sent:

[PATCH] mm,oom_kill: fix the comment of is_dump_unreclaim_slabs()

2020-09-25 Thread Hui Su
fix the comment of is_dump_unreclaim_slabs(), it just check whether nr_unreclaimable slabs amount is greater than user memory. Signed-off-by: Hui Su --- mm/oom_kill.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index

[RFC][PATCH 4/6] dma-buf: system_heap: Allocate higher order pages if available

2020-09-25 Thread John Stultz
While the system heap can return non-contiguous pages, try to allocate larger order pages if possible. This will allow slight performance gains and make implementing page pooling easier. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren

[RFC][PATCH 6/6] dma-buf: heaps: Skip sync if not mapped

2020-09-25 Thread John Stultz
This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.e...@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be

[RFC][PATCH 0/6] dma-buf: Performance improvements for system heap

2020-09-25 Thread John Stultz
Hey All, So this patch series contains a series of performance optimizations to the dma-buf system heap. Unfortunately, in working these up, I realized the heap-helpers infrastructure we tried to add to miniimize code duplication is not as generic as we intended. For some heaps it makes sense

[RFC][PATCH 3/6] dma-buf: heaps: Remove heap-helpers code

2020-09-25 Thread John Stultz
The heap-helpers code was not as generic as initially hoped and it is now not being used, so remove it from the tree. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Ørjan Eide Cc: Robin Murphy Cc:

[RFC][PATCH 1/6] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists

2020-09-25 Thread John Stultz
In preparation for some patches to optmize the system heap code, rework the dmabuf exporter to utilize sgtables rather then pageslists for tracking the associated pages. This will allow for large order page allocations, as well as more efficient page pooling. In doing so, the system heap stops

[RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-09-25 Thread John Stultz
Since the heap-helpers logic ended up not being as generic as hoped, move the heap-helpers dma_buf_ops implementations into the cma_heap directly. This will allow us to remove the heap_helpers code in a following patch. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc:

[RFC][PATCH 5/6] dma-buf: system_heap: Add pagepool support to system heap

2020-09-25 Thread John Stultz
Reuse/abuse the pagepool code from the network code to speed up allocation performance. This is similar to the ION pagepool usage, but tries to utilize generic code instead of a custom implementation. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc:

For your information..

2020-09-25 Thread Angela Richardson
Dear Sir/Ma, My name is Angela Richardson. I am the Director Of Information (D.O.F) of Her Majesty Custom and Revenue, London United Kingdom. Our duty is to look into transactions and records of banks, Securities Companies and Financial Houses within Europe based on the directive of former

Re: [PATCH v5 3/3] remoteproc: qcom: Add minidump id for sm8150 modem remoteproc

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 16:51 PDT 2020, Siddharth Gupta wrote: > Add minidump id for modem in sm8150 chipset. "...so that the regions to be included in the coredump generated upon a crash is based on the minidump tables in SMEM instead of those in the ELF header." Regards, Bjorn > > Signed-off-by:

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 12:53 PM, Dave Hansen wrote: > > On 9/25/20 12:43 PM, Sean Christopherson wrote: >>> That means that the intent argument (SGX_PROT_*) is currently unused. >> No, the intent argument is used (eventually) by SGX's ->mprotect() >> implementation, i.e. sgx_mprotect()

Re: [PATCH v5 2/3] remoteproc: qcom: Add capability to collect minidumps

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 16:51 PDT 2020, Siddharth Gupta wrote: > This patch adds support for collecting minidump in the event of remoteproc > crash. Parse the minidump table based on remoteproc's unique minidump-id, > read all memory regions from the remoteproc's minidump table entry and > expose the

Re: [PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-25 Thread Bart Van Assche
On 2020-09-25 19:39, Xianting Tian wrote: > diff --git a/block/blk-mq.c b/block/blk-mq.c > index b3d2785ee..62d152d03 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -3256,9 +3256,11 @@ static int __blk_mq_alloc_rq_maps(struct > blk_mq_tag_set *set) > { > int i; > > - for

Re: [greybus-dev] [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t

2020-09-25 Thread Coiby Xu
On Fri, Sep 25, 2020 at 11:02:23AM -0500, Alex Elder wrote: On 9/25/20 9:11 AM, Coiby Xu wrote: On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote: From: Coiby Xu Sent: 24 September 2020 11:21 Use __8 to replace int and remove the unnecessary __bitwise type attribute. Found by

Re: [PATCH v5 1/2] remoteproc: Move coredump configuration to sysfs

2020-09-25 Thread Bjorn Andersson
On Fri 18 Sep 10:22 PDT 2020, Rishabh Bhatnagar wrote: > diff --git a/drivers/remoteproc/remoteproc_debugfs.c > b/drivers/remoteproc/remoteproc_debugfs.c [..] > +static ssize_t coredump_store(struct device *dev, > + struct device_attribute *attr, > +

Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs

2020-09-25 Thread Bjorn Andersson
On Tue 15 Sep 02:51 PDT 2020, Arnaud POULIQUEN wrote: > Hi Rishabh, > > On 8/27/20 9:48 PM, Rishabh Bhatnagar wrote: > > From Android R onwards Google has restricted access to debugfs in user > > and user-debug builds. This restricts access to most of the features > > exposed through debugfs.

Re: [PATCH v5 15/17] device-dax: add an 'align' attribute

2020-09-25 Thread Dan Williams
On Fri, Sep 25, 2020 at 7:22 PM Andrew Morton wrote: > > On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams > wrote: > > > Introduce a device align attribute. While doing so, rename the region > > align attribute to be more explicitly named as so, but keep it named as > > @align to retain the API

[tip:x86/seves] BUILD SUCCESS 0ddfb1cf3b6b07c97cff16ea69931d986f9622ee

2020-09-25 Thread kernel test robot
defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a002-20200925 i386

Re: [PATCH next 0/2] printk: fix reading beyond buffer

2020-09-25 Thread Joe Perches
On Sat, 2020-09-26 at 04:01 +0206, John Ogness wrote: > Hello, > > Marek Szyprowski reported [0] a problem with a particular printk > usage. This particular usage performs thousands of LOG_CONT calls. > The printk.c implementation was only limiting the growing record by > the maximum size

Re: kernel BUG at include/linux/mm.h:LINE! (6)

2020-09-25 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1197c51790 kernel config:

WARNING in __kernel_read (2)

2020-09-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b10b8ad8 Add linux-next specific files for 20200921 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1437eff190 kernel config: https://syzkaller.appspot.com/x/.config?x=3cf0782933432b43 dashboard

Greetings.....

2020-09-25 Thread razak ahmed
Dear Friend, I am Barrister Razak George Ahmed, a lawyer and personal attorney to the late business man from your country who has a similar name with you, I request your consent to present you as the next of kin with the following relatives in order to continue to release his unknown deposits

[PATCH v4] Documentation: Chinese translation of Documentation/arm64/amu.rst

2020-09-25 Thread Bailu Lin
This is a Chinese translated version of Documentation/arm64/amu.rst Signed-off-by: Bailu Lin --- Changes in v4: - Remove zh_CN/arm64/amu.rst's inappropriate License claim. - Align zh_CN/arm64/index.rst. Changes in v3: - Remove Documentation/arm64/amu.rst's inappropriate License claim. Changes

Re: [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init()

2020-09-25 Thread Barry Song
Xu Wang 于2020年9月21日周一 下午3:45写道: > > In case of error, the function clk_register() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Xu Wang Acked-by: Barry Song Thanks > --- >

[PATCH] platform_data: ti: fix a typo

2020-09-25 Thread Wang Qing
Modify the typo: "compliment" -> "complement". Signed-off-by: Wang Qing --- include/linux/platform_data/cros_ec_commands.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 6:23 PM, YiFei Zhu wrote: > > On Fri, Sep 25, 2020 at 4:07 PM Andy Lutomirski wrote: >> We'd need at least three states per syscall: unknown, always-allow, >> and need-to-run-filter. >> >> The downsides are less determinism and a bit of an uglier >> implementation.

[PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()

2020-09-25 Thread Xianting Tian
We found blk_mq_alloc_rq_maps() takes more time in kernel space when testing nvme device hot-plugging. The test and anlysis as below. Debug code, 1, blk_mq_alloc_rq_maps(): u64 start, end; depth = set->queue_depth; start = ktime_get_ns(); pr_err("[%d:%s

Re: remove alloc_vm_area v2

2020-09-25 Thread Andrew Morton
On Thu, 24 Sep 2020 15:58:42 +0200 Christoph Hellwig wrote: > this series removes alloc_vm_area, which was left over from the big > vmalloc interface rework. It is a rather arkane interface, basicaly > the equivalent of get_vm_area + actually faulting in all PTEs in > the allocated area. It

[PATCH] power: supply: fix spelling typo

2020-09-25 Thread Wang Qing
Modify the comment typo: "compliment" -> "complement". Signed-off-by: Wang Qing --- drivers/power/supply/ds2780_battery.c | 6 +++--- drivers/power/supply/ds2781_battery.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/ds2780_battery.c

[PATCH] net: wireless: ti: fix a typo in comments

2020-09-25 Thread Wang Qing
Modify the comment typo: "compliment" -> "complement". Signed-off-by: Wang Qing --- drivers/net/wireless/ti/wl1251/reg.h | 2 +- drivers/net/wireless/ti/wl12xx/reg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/reg.h

[PATCH v5] doc: zh_CN: index files in arm64 subdirectory

2020-09-25 Thread Bailu Lin
Add arm64 subdirectory into the table of Contents for zh_CN, then add other translations in arm64 conveniently. Signed-off-by: Bailu Lin --- Changes in v5: - Remove zh_CN/arm64/index.rst's inappropriate License claim. Changes in v4: - Remove index.rst's inappropriate License claim. Changes in

Re: [PATCH v5 15/17] device-dax: add an 'align' attribute

2020-09-25 Thread Andrew Morton
On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams wrote: > Introduce a device align attribute. While doing so, rename the region > align attribute to be more explicitly named as so, but keep it named as > @align to retain the API for tools like daxctl. > > Changes on align may not always be

[PATCH V3] doc: zh_CN: add translatation for tmpfs

2020-09-25 Thread Wang Qing
Translate Documentation/filesystems/tmpfs.rst into Chinese. Signed-off-by: Wang Qing --- .../translations/zh_CN/filesystems/index.rst | 1 + .../translations/zh_CN/filesystems/tmpfs.rst | 146 + 2 files changed, 147 insertions(+) create mode 100644

[PATCH v2 -next] drivers: thermal: tsens: fix missing put_device error

2020-09-25 Thread Zheng Bin
Fixes coccicheck error: drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call of_find_device_by_node on line 715, but without a corresponding object release within this function. Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.c") Signed-off-by:

Re: [PATCH] Documentation/llvm: Fix clang target examples

2020-09-25 Thread Nathan Chancellor
On Fri, Sep 25, 2020 at 08:21:14AM -0700, Florian Fainelli wrote: > clang --target= is how we can specify a particular toolchain > triple to be use, fix the two occurences in the documentation. > > Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ > Clang/LLVM") >

[PATCH] block: fix a typo for skd_main.c

2020-09-25 Thread Wang Qing
Modify the comment typo: "compliment" -> "complement". Signed-off-by: Wang Qing --- drivers/block/skd_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index ae6454c..e70e764 --- a/drivers/block/skd_main.c +++

[PATCH] hwmon: fix spelling typo in comments

2020-09-25 Thread Wang Qing
Modify the comment typo: "compliment" -> "complement". Signed-off-by: Wang Qing --- drivers/hwmon/tmp513.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c index 23908dc..c37d321 --- a/drivers/hwmon/tmp513.c +++

Re: [PATCH 09/11] drivers/char/ipmi: convert stats to use counter_atomic32

2020-09-25 Thread Shuah Khan
On 9/25/20 6:15 PM, Corey Minyard wrote: On Fri, Sep 25, 2020 at 05:47:23PM -0600, Shuah Khan wrote: counter_atomic* is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes.

Re: KASAN: use-after-free Read in bit_putcs

2020-09-25 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13b41d0390 kernel config:

Re: [PATCH v2 1/3] ARM: tegra: Add device-tree for Ouya

2020-09-25 Thread Peter Geis
On Thu, Sep 24, 2020 at 8:12 PM Dmitry Osipenko wrote: > > ... > > +/ { > > + model = "Ouya Game Console"; > > + compatible = "ouya,ouya", "nvidia,tegra30"; > > + > > + aliases { > > + rtc0 = > > + rtc1 = "/rtc@7000e000"; > > + serial0 = /* Debug

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-25 Thread jun qian
Thomas Gleixner 于2020年9月24日周四 下午11:37写道: > > On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: > > > > +#define SOFTIRQ_PENDING_MASK ((1UL << NR_SOFTIRQS) - 1) > > > > +/* > > + * The pending_next_bit is recorded for the next processing order when > > + * the loop is broken. This per cpu

Re: [PATCH] drm: of: fix leak of port_node

2020-09-25 Thread kernel test robot
Hi Tobias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.9-rc6 next-20200925] [cannot apply to drm/drm-next

[PATCH V2] increase error-prone spell checking

2020-09-25 Thread Wang Qing
Increase direcly,ununsed,manger spelling error check Signed-off-by: Wang Qing --- scripts/spelling.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/spelling.txt b/scripts/spelling.txt index f253681..bd99940 --- a/scripts/spelling.txt +++ b/scripts/spelling.txt @@ -482,6 +482,7

[PATCH next 1/2] printk: avoid and/or handle record truncation

2020-09-25 Thread John Ogness
If a reader provides a buffer that is smaller than the message text, the @text_len field of @info will have a value larger than the buffer size. If readers blindly read @text_len bytes of data without checking the size, they will read beyond their buffer. Add this check to record_print_text() to

[PATCH next 2/2] printk: reduce setup_text_buf size to LOG_LINE_MAX

2020-09-25 Thread John Ogness
@setup_text_buf only copies the original text messages (without any prefix or extended text). It only needs to be LOG_LINE_MAX in size. Signed-off-by: John Ogness --- kernel/printk/printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/printk/printk.c

[PATCH next 0/2] printk: fix reading beyond buffer

2020-09-25 Thread John Ogness
Hello, Marek Szyprowski reported [0] a problem with a particular printk usage. This particular usage performs thousands of LOG_CONT calls. The printk.c implementation was only limiting the growing record by the maximum size available in the ringbuffer, thus creating a record that was several

Re: REGRESSION: 37f4a24c2469: blk-mq: centralise related handling into blk_mq_get_driver_tag

2020-09-25 Thread Ming Lei
On Fri, Sep 25, 2020 at 12:19:02PM -0700, Shakeel Butt wrote: > On Fri, Sep 25, 2020 at 10:58 AM Shakeel Butt > wrote: > > > [snip] > > > > I don't think you can ignore the flushing. The __free_once() in > > ___cache_free() assumes there is a space available. > > > > BTW do_drain() also have the

Re: [PATCH v10 06/16] s390/vfio-ap: introduce shadow APCB

2020-09-25 Thread Halil Pasic
On Fri, 21 Aug 2020 15:56:06 -0400 Tony Krowiak wrote: > The APCB is a field within the CRYCB that provides the AP configuration > to a KVM guest. Let's introduce a shadow copy of the KVM guest's APCB and > maintain it for the lifespan of the guest. > AFAIU this is supposed to be a no change

Re: [PATCH] cpuidle: change #ifdef for the declaration of cpuidle_enter_s2idle()

2020-09-25 Thread zhuguangqing83
> On Thu, Sep 24, 2020 at 10:01 AM wrote: > > > > From: zhuguangqing > > > > Currently, if CONFIG_SUSPEND=n and CONFIG_CPU_IDLE=y, the function > > cpuidle_enter_s2idle() is declared but not defined, it may cause error > > when cpuidle_enter_s2idle() is called. > > > > If CONFIG_SUSPEND=y and

Re: [PATCH 22/22] kvm: mmu: Don't clear write flooding count for direct roots

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:23, Ben Gardon wrote: > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > index 42dde27decd75..c07831b0c73e1 100644 > --- a/arch/x86/kvm/mmu/tdp_mmu.c > +++ b/arch/x86/kvm/mmu/tdp_mmu.c > @@ -124,6 +124,18 @@ static struct kvm_mmu_page

Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator

2020-09-25 Thread Marek Behún
On Sat, 26 Sep 2020 02:51:17 +0200 Tobias Jordan wrote: > In one of the error paths of the for_each_child_of_node loop in > tlc591xx_probe, add missing call to of_node_put. > > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the > managed led API") > > Signed-off-by: Tobias

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread YiFei Zhu
On Fri, Sep 25, 2020 at 4:07 PM Andy Lutomirski wrote: > We'd need at least three states per syscall: unknown, always-allow, > and need-to-run-filter. > > The downsides are less determinism and a bit of an uglier > implementation. The upside is that we don't need to loop over all > syscalls at

Re: [PATCH] dt-bindings: iio: sx9310: Add various settings as DT properties

2020-09-25 Thread Stephen Boyd
Sorry this thread is deep! Good news is I have moved the proximity thresholds, hysteresis, hardware gain, and debounce to userspace. Now just to figure out this filter strength. Quoting Jonathan Cameron (2020-09-09 04:15:50) > On Tue, 8 Sep 2020 23:18:43 -0700 > Stephen Boyd wrote: > > >

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-25 Thread Linus Torvalds
On Fri, Sep 25, 2020 at 5:41 PM Jason Gunthorpe wrote: > > I don't completely grok the consequences of the anon_vma check. We > can exclude file backed mappings as they are broken for pinning > anyhow, so what is left that could be MAP_PRIVATE of a non-anon_vma? It really shouldn't ever happen.

Re: [PATCH 20/22] kvm: mmu: NX largepage recovery for TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:23, Ben Gardon wrote: > + > + if (!kvm->arch.tdp_mmu_enabled) > + return err; > + > + err = kvm_vm_create_worker_thread(kvm, kvm_nx_lpage_recovery_worker, 1, > + "kvm-nx-lpage-tdp-mmu-recovery", > +

Re: [PATCH 00/22] Introduce the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > Over the years, the needs for KVM's x86 MMU have grown from running small > guests to live migrating multi-terabyte VMs with hundreds of vCPUs. Where > we previously depended on shadow paging to run all guests, we now have > two dimensional paging (TDP). This

Re: [PATCH 18/22] kvm: mmu: Support disabling dirty logging for the tdp MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > + for_each_tdp_pte_root(iter, root, start, end) { > + if (!is_shadow_present_pte(iter.old_spte) || > + is_last_spte(iter.old_spte, iter.level)) > + continue; > + I'm starting to wonder if another iterator

Re: [PATCH 17/22] kvm: mmu: Support dirty logging for the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > start_level, KVM_MAX_HUGEPAGE_LEVEL, false); > + if (kvm->arch.tdp_mmu_enabled) > + flush = kvm_tdp_mmu_wrprot_slot(kvm, memslot, false) || flush; > spin_unlock(>mmu_lock); > In fact you can just pass

[PATCH v4 3/6] tracing: add trace_export support for event trace

2020-09-25 Thread Tingwei Zhang
Only function traces can be exported to other destinations currently. This patch exports event trace as well. Move trace export related function to the beginning of file so other trace can call trace_process_export() to export. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware)

[PATCH v4 1/6] stm class: ftrace: change dependency to TRACING

2020-09-25 Thread Tingwei Zhang
We will support copying event trace to STM. Change STM_SOURCE_FTRACE to depend on TRACING since we will support multiple tracers. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) Reviewed-by: Alexander Shishkin --- drivers/hwtracing/stm/Kconfig | 2 +- 1 file changed, 1

[PATCH v4 5/6] stm class: ftrace: enable supported trace export flag

2020-09-25 Thread Tingwei Zhang
Set flags for trace_export. Export function trace, event trace and trace marker to stm. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) Reviewed-by: Alexander Shishkin --- drivers/hwtracing/stm/ftrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-09-25 Thread boris . ostrovsky
On 9/25/20 3:04 PM, Anchal Agarwal wrote: > On Tue, Sep 22, 2020 at 11:17:36PM +, Anchal Agarwal wrote: >> On Tue, Sep 22, 2020 at 12:18:05PM -0400, boris.ostrov...@oracle.com wrote: >>> CAUTION: This email originated from outside of the organization. Do not >>> click links or open

[PATCH v4 6/6] stm class: ftrace: use different channel accroding to CPU

2020-09-25 Thread Tingwei Zhang
To avoid mixup of packets from differnt ftrace packets simultaneously, use different channel for packets from different CPU. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/ftrace.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v4 0/6] tracing: export event trace and trace_marker

2020-09-25 Thread Tingwei Zhang
Ftrace has ability to export trace packets to other destination. Currently, only function trace can be exported. This series extends the support to event trace and trace_maker. STM is one possible destination to export ftrace. Use separate channel for each CPU to avoid mixing up packets from

[PATCH v4 2/6] tracing: add flag to control different traces

2020-09-25 Thread Tingwei Zhang
More traces like event trace or trace marker will be supported. Add flag for difference traces, so that they can be controlled separately. Move current function trace to it's own flag instead of global ftrace enable flag. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware)

[PATCH v4 4/6] tracing: add trace_export support for trace_marker

2020-09-25 Thread Tingwei Zhang
Add the support to route trace_marker buffer to other destination via trace_export. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) Reviewed-by: Alexander Shishkin --- include/linux/trace.h | 1 + kernel/trace/trace.c | 9 + 2 files changed, 10 insertions(+) diff

Re: [PATCH] s390/vfio-ap: fix unregister GISC when KVM is already gone results in OOPS

2020-09-25 Thread Halil Pasic
On Fri, 25 Sep 2020 18:29:16 -0400 Tony Krowiak wrote: > > > On 9/21/20 11:45 AM, Halil Pasic wrote: > > On Fri, 18 Sep 2020 13:02:34 -0400 > > Tony Krowiak wrote: > > > >> Attempting to unregister Guest Interruption Subclass (GISC) when the > >> link between the matrix mdev and KVM has been

Re: [PATCH] HID: hid-input: fix stylus battery reporting

2020-09-25 Thread Kenneth Albanowski
[Re-send to appease the mail daemons] Confirmed, I've validated this on a 4.19 derivative, this fixes the problem and battery strength gets reported again. - Kenneth Albanowski On Fri, Sep 25, 2020 at 4:35 PM Dmitry Torokhov wrote: > > With commit 4f3882177240 hid-input started clearing of

Re: [PATCH] HID: hid-input: fix stylus battery reporting

2020-09-25 Thread Jiri Kosina
On Fri, 25 Sep 2020, Dmitry Torokhov wrote: > With commit 4f3882177240 hid-input started clearing of "ignored" usages > to avoid using garbage that might have been left in them. However > "battery strength" usages should not be ignored, as we do want to > use them. > > Fixes: 4f3882177240 ("HID:

Re: [PATCH 02/22] kvm: mmu: Introduce tdp_iter

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > + bool done; > + > + done = try_step_down(iter); > + if (done) > + return; > + > + done = try_step_side(iter); > + while (!done) { > + if (!try_step_up(iter)) { > + iter->valid = false; > +

[PATCH v2] leds: tlc591xx: fix leak of device node iterator

2020-09-25 Thread Tobias Jordan
In one of the error paths of the for_each_child_of_node loop in tlc591xx_probe, add missing call to of_node_put. Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API") Signed-off-by: Tobias Jordan --- v2: rebased to Pavel's for-next branch

Re: [PATCH 16/22] kvm: mmu: Add dirty logging handler for changed sptes

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +static void handle_changed_spte_dlog(struct kvm *kvm, int as_id, gfn_t gfn, > + u64 old_spte, u64 new_spte, int level) > +{ > + bool pfn_changed; > + struct kvm_memory_slot *slot; _dlog is a new abbreviation... I

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-25 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 02:06:59PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 12:56 PM Linus Torvalds > wrote: > > > > And honestly, since this is all getting fairly late in the rc, and it > > took longer than I thought, I think we should do the GFP_ATOMIC > > approach for now - not

Re: RGMII timing calibration (on 12nm Amlogic SoCs) - integration into dwmac-meson8b

2020-09-25 Thread Andrew Lunn
> The reference code I linked tries to detect the RGMII interface mode. > However, for each board we know the phy-mode as well as the RX and TX > delay - so I'm not trying to port the RGMII interface detection part > to the mainline driver. > > on X96 Air (which I'm using for testing) Amlogic

Re: [PATCH 05/22] kvm: mmu: Add functions to handle changed TDP SPTEs

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > + > + /* > + * Recursively handle child PTs if the change removed a subtree from > + * the paging structure. > + */ > + if (was_present && !was_leaf && (pfn_changed || !is_present)) { > + pt = spte_to_child_pt(old_spte,

Re: [PATCH v2 seccomp 3/6] seccomp/cache: Add "emulator" to check if filter is arg-dependent

2020-09-25 Thread Andy Lutomirski
> On Sep 25, 2020, at 4:49 PM, Kees Cook wrote: > > On Fri, Sep 25, 2020 at 02:07:46PM -0700, Andy Lutomirski wrote: >>> On Fri, Sep 25, 2020 at 1:37 PM Kees Cook wrote: >>> >>> On Fri, Sep 25, 2020 at 12:51:20PM -0700, Andy Lutomirski wrote: > On Sep 25, 2020, at 12:42 PM,

Re: [PATCH 15/22] kvm: mmu: Support changed pte notifier in tdp MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > @@ -1708,6 +1695,21 @@ static int kvm_unmap_rmapp(struct kvm *kvm, struct > kvm_rmap_head *rmap_head, > return kvm_zap_rmapp(kvm, rmap_head); > } > > +u64 kvm_mmu_changed_pte_notifier_make_spte(u64 old_spte, kvm_pfn_t new_pfn) > +{ > + u64

Re: [PATCH 14/22] kvm: mmu: Add access tracking for tdp_mmu

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > @@ -332,7 +331,7 @@ static inline bool kvm_vcpu_ad_need_write_protect(struct > kvm_vcpu *vcpu) > return vcpu->arch.mmu == >arch.guest_mmu; > } > > -static inline bool spte_ad_enabled(u64 spte) > +inline bool spte_ad_enabled(u64 spte) > { >

Re: general protection fault in perf_misc_flags

2020-09-25 Thread Nick Desaulniers
On Fri, Sep 25, 2020 at 5:22 AM Dmitry Vyukov wrote: > > On Wed, Sep 23, 2020 at 5:20 PM Dmitry Vyukov wrote: > > > > On Wed, Sep 23, 2020 at 12:34 PM Borislav Petkov wrote: > > > > > > On Wed, Sep 23, 2020 at 11:24:48AM +0200, Dmitry Vyukov wrote: > > > > 3. Run syzkaller locally with custom

Re: [PATCH] mfd: syscon: Don't free allocated name for regmap_config

2020-09-25 Thread Suman Anna
On 9/24/20 7:39 AM, Lee Jones wrote: > On Thu, 03 Sep 2020, Marc Zyngier wrote: > >> The name allocated for the regmap_config structure is freed >> pretty early, right after the registration of the MMIO region. >> >> Unfortunately, that doesn't follow the life cycle that debugfs >> expects, as it

Re: [PATCH 10/22] kvm: mmu: Add TDP MMU PF handler

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > > -static bool is_nx_huge_page_enabled(void) > +bool is_nx_huge_page_enabled(void) > { > return READ_ONCE(nx_huge_pages); > } > @@ -381,7 +361,7 @@ static inline u64 spte_shadow_dirty_mask(u64 spte) > return spte_ad_enabled(spte) ?

Re: [PATCH 11/22] kvm: mmu: Factor out allocating a new tdp_mmu_page

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > Move the code to allocate a struct kvm_mmu_page for the TDP MMU out of the > root allocation code to support allocating a struct kvm_mmu_page for every > page of page table memory used by the TDP MMU, in the next commit. > > Tested by running kvm-unit-tests

[PATCH] f2fs: remove unneeded parameter in find_in_block()

2020-09-25 Thread Chao Yu
From: Chao Yu We can relocate @res_page assignment in find_in_block() to its caller, so unneeded parameter could be removed for cleanup. Signed-off-by: Chao Yu --- fs/f2fs/dir.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/fs/f2fs/dir.c

Re: [GIT PULL] Second batch of KVM fixes for Linux 5.9-rc7

2020-09-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Sep 2020 19:36:52 -0400: > https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7c7ec3226f5f33f9c050d85ec20f18419c622ad6 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference

2020-09-25 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 25 Sep 2020 12:03:23 -0500 > There is a null-check for _pcs_, but it is being dereferenced > prior to this null-check. So, if _pcs_ can actually be null, > then there is a potential null pointer dereference that should > be fixed by null-checking _pcs_

Re: [PATCH 09/11] drivers/char/ipmi: convert stats to use counter_atomic32

2020-09-25 Thread Corey Minyard
On Fri, Sep 25, 2020 at 05:47:23PM -0600, Shuah Khan wrote: > counter_atomic* is introduced to be used when a variable is used as > a simple counter and doesn't guard object lifetimes. This clearly > differentiates atomic_t usages that guard object lifetimes. > > counter_atomic* variables will

Re: [PATCH 07/22] kvm: mmu: Support zapping SPTEs in the TDP MMU

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:22, Ben Gardon wrote: > +/* > + * If the MMU lock is contended or this thread needs to yield, flushes > + * the TLBs, releases, the MMU lock, yields, reacquires the MMU lock, > + * restarts the tdp_iter's walk from the root, and returns true. > + * If no yield is needed, returns

Re: [f2fs-dev] [PATCH] f2fs: point man pages for some f2fs utils

2020-09-25 Thread Jaegeuk Kim
On 09/26, Chao Yu wrote: > On 2020-9-26 7:26, Jaegeuk Kim wrote: > > On 09/25, Jaegeuk Kim wrote: > > > This patch adds some missing contexts related to f2fs-tools in f2fs > > > documentation. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > Documentation/filesystems/f2fs.rst | 46

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-25 Thread Shuah Khan
On 9/25/20 5:52 PM, Kees Cook wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: -- Addressed Kees's comments: 1. Non-atomic counters renamed to counter_simple32 and counter_simple64 to clearly indicate size. 2. Added warning for counter_simple* usage and it

Re: [PATCH v2] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-25 Thread David Miller
From: Wilken Gottwalt Date: Fri, 25 Sep 2020 15:58:57 +0200 > Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 > ethernet adapter. > > Signed-off-by: Wilken Gottwalt Applied.

  1   2   3   4   5   6   7   8   9   10   >