[PATCH v2 net 1/1] net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call

2020-11-14 Thread Wong Vee Khee
Fix an issue where dump stack is printed on suspend resume flow due to netif_set_real_num_rx_queues() is not called with rtnl_lock held(). Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set real_num_rx|tx_queues") Reported-by: Christophe ROULLIER Tested-by: Christophe ROULLIER

[PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-14 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 113 +++ 1 file changed, 113 insertions(+) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index e24a99031b80..f6947fb0182f 100644

Re: [PATCH] iio: core: centralize ioctl() calls to the main chardev

2020-11-14 Thread Alexandru Ardelean
On Sat, Nov 14, 2020 at 5:32 PM Jonathan Cameron wrote: > > On Sat, 14 Nov 2020 15:30:23 + > Jonathan Cameron wrote: > > > On Mon, 2 Nov 2020 08:59:57 +0200 > > Alexandru Ardelean wrote: > > > > > On Fri, Sep 25, 2020 at 3:38 PM Jonathan Cameron wrote: > > > > > > > > On Thu, 24 Sep 2020

drivers/dma/sun6i-dma.c:244:45: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: 005b73d0dd83c9cb9420a196bea8070cde30ecac m68knommu: __force type casts for raw IO access date: 4 months ago config: m68k-randconfig-s031-20201115 (attached

[PATCH v2 1/1] page_frag: Recover from memory pressure

2020-11-14 Thread Dongli Zhang
The ethernet driver may allocate skb (and skb->data) via napi_alloc_skb(). This ends up to page_frag_alloc() to allocate skb->data from page_frag_cache->va. During the memory pressure, page_frag_cache->va may be allocated as pfmemalloc page. As a result, the skb->pfmemalloc is always true as

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-14 Thread Leon Romanovsky
On Sat, Nov 14, 2020 at 12:21:39AM +0100, Greg KH wrote: > On Fri, Nov 13, 2020 at 04:07:57PM +, Ertman, David M wrote: > > > -Original Message- > > > From: Greg KH > > > Sent: Friday, November 13, 2020 7:50 AM > > > To: Ertman, David M > > > Cc: alsa-de...@alsa-project.org;

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Huacai Chen
Hi, Roman, On Sun, Nov 15, 2020 at 6:02 AM Roman Kiryanov wrote: > > Hi Hancai, > > do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a > patch to retire it. Not required for MIPS. Huacai > > Regards, > Roman. > > On Sat, Nov 14, 2020 at 12:06 AM 陈华才 wrote: > > > > Hi, All, > >

Re: WARNING: can't access registers at asm_common_interrupt

2020-11-14 Thread Jürgen Groß
On 14.11.20 19:10, Andy Lutomirski wrote: On Sat, Nov 14, 2020 at 1:16 AM Jürgen Groß wrote: On 13.11.20 18:34, Andy Lutomirski wrote: On Wed, Nov 11, 2020 at 12:25 PM Andrew Cooper wrote: So I think there is at most one of these that wants anything more complicated than a plain

[PATCH] btrfs: remove the useless value assignment in block_rsv_release_bytes

2020-11-14 Thread xiakaixu1987
From: Kaixu Xia The variable qgroup_to_release is overwritten by the following if/else statement before it is used, so this assignment is useless. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- fs/btrfs/block-rsv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-11-14 Thread Krzysztof Wilczyński
Hello Pali! Sincere apologies for taking a long time to get back to you. On 20-11-04 17:29:31, Pali Rohár wrote: [...] > > Krzysztof, as Bjorn wrote, do you want to take this issue? > [...] Yes. I already talked to Bjorn about this briefly, and thus I am more than happy to take care about

Re: [PATCH] PCI: Add sysfs attribute for PCI device power state

2020-11-14 Thread Krzysztof Wilczyński
Hi Maximilian, On 20-11-02 15:15:20, Maximilian Luz wrote: > While most PCI power-states can be queried from user-space via lspci, > this has some limits. Specifically, lspci fails to provide an accurate > value when the device is in D3cold as it has to resume the device before > it can access

[PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-14 Thread Matt Mullins
bpf_link_free is always called in process context, including from a workqueue and from __fput. Neither of these have the ability to propagate an -ENOMEM to the caller. Reported-by: syzbot+83aa762ef23b6f0d1...@syzkaller.appspotmail.com Reported-by:

aiu-encoder-spdif.c:undefined reference to `clk_set_parent'

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: 6ae9ca9ce986bffe71fd0fbf9595de8500891b52 ASoC: meson: aiu: add i2s and spdif support date: 9 months ago config: mips-randconfig-c003-20201104 (attached as

Re: [PATCH v2] sched/uclamp: Allow to reset a task uclamp constraint value

2020-11-14 Thread Yun Hsiang
Hi Dietmar, On Fri, Nov 13, 2020 at 12:34:54PM +0100, Dietmar Eggemann wrote: > In case the user wants to stop controlling a uclamp constraint value > for a task, use the magic value -1 in sched_util_{min,max} with the > appropriate sched_flags (SCHED_FLAG_UTIL_CLAMP_{MIN,MAX}) to indicate > the

[PATCH] Asoc: qcom: lpass-platform: Fix memory leak

2020-11-14 Thread Srinivasa Rao Mandadapu
lpass_pcm_data is not freed in error paths. Free it in error paths to avoid memory leak. Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage") Signed-off-by: Pavel Machek Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu ---

Re: [PATCH RT 1/5] net: Properly annotate the try-lock for the seqlock

2020-11-14 Thread Mike Galbraith
On Sat, 2020-11-14 at 13:24 -0600, Tom Zanussi wrote: > On Sat, 2020-11-14 at 20:00 +0100, Mike Galbraith wrote: > > > __raw_write_seqcount_end() is an integral part of write_sequnlock(), > > but we do seem to be missing a seqcount_release() in 5.4-rt. > > > > Yep, you're right, it's just the

Re: [RFC bpf-next 1/3] bpf: add module support to btf display helpers

2020-11-14 Thread Yonghong Song
On 11/14/20 8:04 AM, Alexei Starovoitov wrote: On Fri, Nov 13, 2020 at 10:59 PM Andrii Nakryiko wrote: On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire wrote: bpf_snprintf_btf and bpf_seq_printf_btf use a "struct btf_ptr *" argument that specifies type information about the type to be

Re: [PATCH net] net: x25: Correct locking for x25_kill_by_device and x25_kill_by_neigh

2020-11-14 Thread Xie He
On Sat, Nov 14, 2020 at 2:36 AM Xie He wrote: > > This patch adds correct locking for x25_kill_by_device and > x25_kill_by_neigh, and removes the incorrect locking in x25_connect and > x25_disconnect. I see if I do this change, I need to make sure the sock lock is not held when calling

Re: [PATCH v4] riscv: Enable per-task stack canaries

2020-11-14 Thread Guo Ren
Hi Palmer, Could you help move the patch into your next-tree with Kees' review added? On Sat, Nov 14, 2020 at 6:57 AM Kees Cook wrote: > > On Sun, Oct 18, 2020 at 12:38:17PM +, guo...@kernel.org wrote: > > From: Guo Ren > > > > This enables the use of per-task stack canary values if GCC

sprd_thermal.c:undefined reference to `devm_platform_ioremap_resource'

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: 554fdbaf19b188224d52d2fa80c049e4d42002e8 thermal: sprd: Add Spreadtrum thermal driver support date: 8 months ago config: s390-randconfig-r014-20201115

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Hi Russell, On 15.11.20 02:02, Russell King - ARM Linux admin wrote: > On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: >> Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: >> Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. >> >> In

Re: [PATCH v4 net-next 00/13] Add ethtool ntuple filters support

2020-11-14 Thread Alexander Duyck
On Sat, Nov 14, 2020 at 11:53 AM Naveen Mamindlapalli wrote: > > This patch series adds support for ethtool ntuple filters, unicast > address filtering, VLAN offload and SR-IOV ndo handlers. All of the > above features are based on the Admin Function(AF) driver support to > install and delete the

Re: [PATCH v2] Documentation: Chinese translation of Documentation/arm64/perf.rst

2020-11-14 Thread Alex Shi
在 2020/11/14 上午6:22, Jonathan Corbet 写道: > On Thu, 29 Oct 2020 21:05:41 -0700 > Bailu Lin wrote: > >> This is a Chinese translated version of >> Documentation/arm64/perf.rst >> >> Signed-off-by: Bailu Lin >> --- >> Changes in v2: >> - Modify a translation of 'guest/host/blackout window' as

phy-tegra-usb.c:undefined reference to `clk_get_parent'

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: 91687c1926bcd6b80d669375d57331b7bf80bf99 usb: phy: Enable compile testing for some of drivers date: 11 months ago config: mips-randconfig-c003-20201104

Re: [PATCH v2 2/4] clk: qcom: Add SDX55 GCC support

2020-11-14 Thread Bjorn Andersson
On Fri 06 Nov 03:38 CST 2020, Vinod Koul wrote: > On 05-11-20, 16:18, Manivannan Sadhasivam wrote: > > From: Naveen Yadav > > > > Add Global Clock Controller (GCC) support for SDX55 SoCs from Qualcomm. > > > > Signed-off-by: Naveen Yadav > > [mani: converted to parent_data, commented critical

Re: [PATCH v2 3/9] media: Rename stateful codec control macros

2020-11-14 Thread Ezequiel Garcia
On Sat, 2020-11-14 at 13:53 +0100, Hans Verkuil wrote: > On 13/11/2020 22:51, Ezequiel Garcia wrote: > > For historical reasons, stateful codec controls are named > > as {}_MPEG_{}. While we can't at this point sanely > > change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER), > >

Re: [PATCH v2 9/9] media: docs: Move the H264 stateless codec uAPI

2020-11-14 Thread Ezequiel Garcia
On Sat, 2020-11-14 at 13:57 +0100, Hans Verkuil wrote: > On 13/11/2020 22:51, Ezequiel Garcia wrote: > > Now that we've destaged the H264 stateless codec controls, > > and with all the pieces in place, update the documentation > > and move it to its own section. > > > > Signed-off-by: Ezequiel

Re: [PATCH v3] net: openvswitch: use core API to update/provide stats

2020-11-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 13 Nov 2020 23:53:36 +0200 you wrote: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function

Re: [PATCH v3] net: xfrm: use core API for updating/providing stats

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 23:59:40 +0200 Lev Stipakov wrote: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > > While on it, remove xfrmi_get_stats64()

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Russell King - ARM Linux admin
On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: > Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: > Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. > > In case a comphy is not provided, mvneta_validate()'s check >

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-14 Thread Chun-Kuang Hu
Hi, Bilal: Please help to test this patch on your Chromebook elm, thanks. Regards, Chun-Kuang Hu Chun-Kuang Hu 於 2020年11月15日 週日 上午8:14寫道: > > From: CK Hu > > Using vm->hfront_porch + vm->hback_porch to calculate > horizontal_backporch_byte would make it negtive, so > use

Re: [PATCH] rtc: at91rm9200: add correction support

2020-11-14 Thread Alexandre Belloni
On 10/11/2020 14:18:27+0100, Nicolas Ferre wrote: > Hi Alexandre, > > Thanks you for adding this feature to newest at91 RTC IPs. > > > On 09/11/2020 at 00:20, Alexandre Belloni wrote: > > The sama5d4 and sama5d2 RTCs are able to correct for imprecise crystals, up > > FYI, sam9x60 RTC has the

[PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. In case a comphy is not provided, mvneta_validate()'s check state->interface == PHY_INTERFACE_MODE_2500BASEX could never be true (it would've

drivers/usb/host/ehci-hcd.c:1286: warning: "PLATFORM_DRIVER" redefined

2020-11-14 Thread kernel test robot
Hi Krzysztof, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: 88eaaecc44461f9fb147bf7ee6ccc6d4e9fc23e0 usb: host: Enable compile testing for some of drivers date:

Re: [PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 19:16:22 +0800 Wang Hai wrote: > If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), > msg should be canceled by genlmsg_cancel(). > > Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring > interface") > Reported-by: Hulk Robot >

Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

2020-11-14 Thread Dan Williams
On Fri, Nov 13, 2020 at 5:09 PM Ben Widawsky wrote: [..] > > Unused, maybe move it to the patch that adds the use? > > > > This is a remnant from when Dan gave me the basis to do the mmio work. I agree > it can be removed now. Yes. > > > +static int cxl_mem_dvsec(struct pci_dev *pdev, int

[PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-14 Thread Chun-Kuang Hu
From: CK Hu Using vm->hfront_porch + vm->hback_porch to calculate horizontal_backporch_byte would make it negtive, so use horizontal_backporch_byte itself to make it positive. Fixes: 35bf948f1edb ("drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp") Signed-off-by: CK Hu

Re: [PATCH] net: stmmac: dwmac_lib: enlarge dma reset timeout

2020-11-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 13 Nov 2020 09:09:02 +0800 you wrote: > If the phy enables power saving technology, the dwmac's software reset > needs more time to complete, enlarge dma reset timeout to 20us. > > Signed-off-by: Jisheng Zhang >

Re: [PATCH v2 0/9] Stateless H.264 de-staging

2020-11-14 Thread Ezequiel Garcia
Hi Hans, Thanks for the quick review. On Sat, 2020-11-14 at 13:58 +0100, Hans Verkuil wrote: > On 13/11/2020 22:51, Ezequiel Garcia wrote: > > Now that H.264 stateless controls are solid, we can get it > > out of staging. > > > > Following some guidelines from Hans, this series creates a > >

undefined reference to `start_isolate_page_range'

2020-11-14 Thread kernel test robot
Hi Michal, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: 2602276d3d3811b1a48c48113042cd75fcbfc27d microblaze: Wire CMA allocator date: 10 months ago config:

Re: [PATCH net v1] lan743x: fix issue causing intermittent kernel log warnings

2020-11-14 Thread Sven Van Asbroeck
On Sat, Nov 14, 2020 at 6:19 PM Jakub Kicinski wrote: > > The _irq() cases look a little strange, are you planning a refactor in > net-next? I'd like to, but I don't understand skbs/queues well enough (yet).

sun6i-msgbox.c:undefined reference to `devm_ioremap_resource'

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: 25831c44b0b79ac6261d36d7e777a52bdf92f239 mailbox: sun6i-msgbox: Add a new mailbox driver date: 8 months ago config: s390-randconfig-r014-20201115 (attached

Re: [PATCH 0/2] Preserve goldfish rtc

2020-11-14 Thread Alexandre Belloni
On Sat, 14 Nov 2020 21:09:19 +0800, Jiaxun Yang wrote: > Cc: che...@lemote.com > Cc: gre...@linuxfoundation.org > > Jiaxun Yang (2): > rtc: goldfish: Remove GOLDFISH dependency > MAINTAINERS: Set myself as Goldfish RTC maintainer > > [...] Applied, thanks! [1/2] rtc: goldfish: Remove

[PATCH v2] counter: microchip-tcb-capture: Fix CMR value check

2020-11-14 Thread William Breathitt Gray
The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values for CMR. This patch fixes the action_get() callback to properly check for these values rather than mask them. Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") Cc: Kamel Bouhara Acked-by: Alexandre Belloni

Re: [PATCH net v1] lan743x: prevent entire kernel HANG on open, for some platforms

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 15:47:41 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > On arm imx6, when opening the chip's netdev, the whole Linux > kernel intermittently hangs/freezes. > > This is caused by a bug in the driver code which tests if pcie > interrupts are working correctly,

Re: [PATCH net v1] lan743x: fix issue causing intermittent kernel log warnings

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:59:49 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > When running this chip on arm imx6, we intermittently observe > the following kernel warning in the log, especially when the > system is under high load: > The driver is calling dev_kfree_skb() from code

RE: load_unaligned_zeropad() on x86-64

2020-11-14 Thread David Laight
From: Linus Torvalds > Sent: 14 November 2020 18:02 > > On Sat, Nov 14, 2020 at 7:53 AM David Laight wrote: > > > > The change e419b4cc585680940bc42f8ca8a071d6023fb1bb added > > asm code for load_unaligned_zeropad(). > > > > However it doesn't look right for 64bit. > > It masks the address with

Re: [PATCH v5 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

2020-11-14 Thread kernel test robot
Hi Nick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on kdave/for-next f2fs/dev-test linus/master v5.10-rc3 next-20201113] [cannot apply to crypto/master squashfs/master] [If your patch is applied to the wrong git

drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set but not used

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: 0990366bab3c6afb93b276106e1e24d4bc69db7b usb: musb: Add support for MediaTek musb controller date: 10 months ago config:

Re: [PATCH AUTOSEL 4.19 18/21] kprobes: Tell lockdep about kprobe nesting

2020-11-14 Thread Sasha Levin
On Tue, Nov 10, 2020 at 03:44:58PM +0900, Masami Hiramatsu wrote: Hi, On Mon, 9 Nov 2020 22:55:38 -0500 Sasha Levin wrote: From: "Steven Rostedt (VMware)" [ Upstream commit 645f224e7ba2f4200bf163153d384ceb0de5462e ] Since the kprobe handlers have protection that prohibits other handlers

Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check

2020-11-14 Thread William Breathitt Gray
On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > > for CMR. This patch fixes

Re: [PATCH] rtc: snvs: Remove NULL pointer check before clk_*

2020-11-14 Thread Alexandre Belloni
On Fri, 13 Nov 2020 08:03:05 +, Xu Wang wrote: > Because clk_* already checked NULL clock parameter, > so the additional checks are unnecessary, just remove them. Applied, thanks! [1/1] rtc: snvs: Remove NULL pointer check before clk_* commit: 081e2500df50c7f330b9346794c6759ea7f8fb81

Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check

2020-11-14 Thread Alexandre Belloni
On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > for CMR. This patch fixes the action_get() callback to properly check > > for these values rather than

Re: [PATCH] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare

2020-11-14 Thread Alexandre Belloni
On Fri, 13 Nov 2020 07:45:38 +, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. Applied, thanks! [1/1] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare

Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check

2020-11-14 Thread Alexandre Belloni
On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > for CMR. This patch fixes the action_get() callback to properly check > for these values rather than mask them. > > Fixes: 106b104137fd ("counter: Add microchip

Re: [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler

2020-11-14 Thread Alexandre Belloni
On Tue, 10 Nov 2020 17:35:47 +0800, Tian Tao wrote: > Coccinelle noticed: > drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT > drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no > primary handler requested without

Re: [PATCH v2] rtc: hym8563: enable wakeup when applicable

2020-11-14 Thread Alexandre Belloni
On Fri, 6 Nov 2020 09:06:31 +, Guillaume Tucker wrote: > Enable wakeup in the hym8563 driver if the IRQ was successfully > requested or if wakeup-source is set in the devicetree. > > As per the description of device_init_wakeup(), it should be enabled > for "devices that everyone expects to

genirq/irqdomain: Make irq_domain_disassociate() static

2020-11-14 Thread Thomas Gleixner
No users outside of the core code. Signed-off-by: Thomas Gleixner --- include/linux/irqdomain.h |2 -- kernel/irq/irqdomain.c|2 +- 2 files changed, 1 insertion(+), 3 deletions(-) --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -387,8 +387,6 @@ extern int

Re: [PATCH RFC v1 1/4] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-11-14 Thread Andrew Lunn
On Sat, Nov 14, 2020 at 09:01:01PM +0100, Martin Blumenstingl wrote: > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > delay register which allows picoseconds precision. Deprecate the old > "amlogic,rx-delay-ns" in favour of a new "amlogic,rgmii-rx-delay-ps" > property. > >

Re: [PATCH] rtc: sc27xx: Remove unnecessary conversion to bool

2020-11-14 Thread Alexandre Belloni
On Fri, 6 Nov 2020 15:30:54 +0800, xiakaixu1...@gmail.com wrote: > Here we could use the '!=' expression to fix the following coccicheck > warning: > > ./drivers/rtc/rtc-sc27xx.c:566:50-55: WARNING: conversion to bool not needed > here Applied, thanks! [1/1] rtc: sc27xx: Remove unnecessary

Re: [PATCH] rtc: da9063: Simplify bool comparison

2020-11-14 Thread Alexandre Belloni
On Fri, 6 Nov 2020 16:00:37 +0800, xiakaixu1...@gmail.com wrote: > Fix the following coccicheck warning: > > ./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool Applied, thanks! [1/1] rtc: da9063: Simplify bool comparison commit: a48c6224ae07bed02893c58073ca2942acb5c3d5 Best

pl353-smc.c:undefined reference to `amba_driver_register'

2020-11-14 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: ea0c0ad6b6eb36726088991d97a55b99cae456d0 memory: Enable compile testing for most of the drivers date: 3 months ago config: arm-randconfig-p002-20201115

Re: [PATCH] rtc: Fix memleak in sun6i_rtc_clk_init

2020-11-14 Thread Alexandre Belloni
Hi, Thank you for the patch. On 14/11/2020 12:18:21+0800, Youling Tang wrote: > When rtc->base or rtc->int_osc or rtc->losc or rtc->ext_losc is NULL, > we should free clk_data and rtc before the function returns to prevent > memleak. > I think this is fixed by

Re: [PATCH][V2] PCI: Fix a potential uninitentional integer overflow issue

2020-11-14 Thread Colin Ian King
On 14/11/2020 21:53, Bjorn Helgaas wrote: > [+cc Dan] > > On Tue, Nov 10, 2020 at 10:10:48PM +, Colin King wrote: >> From: Colin Ian King >> >> The shift of 1 by align_order is evaluated using 32 bit arithmetic >> and the result is assigned to a resource_size_t type variable that >> is a 64

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Roman Kiryanov
Hi Hancai, do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a patch to retire it. Regards, Roman. On Sat, Nov 14, 2020 at 12:06 AM 陈华才 wrote: > > Hi, All, > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as > well, so I think we should keep it in

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Roman Kiryanov
> > Thus I do think it shouldn't be retired as for now. If nobody comes in I'd > > also willing to maintain > > it. > > Ok, can someone submit a patch to update the MAINTAINERS file for this > so we know who to route issues to over time? I will send a patch to update MAINTAINERS for goldfish-rtc.

RF: SUPPORT FOR COVID-19 VICTIMS

2020-11-14 Thread Francois Pinault
Hello! A donation of $1,750,000 USD has been made to you by Mr Francois Pinault to support the victims of COVID-19 around you. Kindly reply this email for further information.As I wait for your response, I wish you a wonderful day. Yours Faithfully, Mr. Francois Pinault

Re: [PATCH][V2] PCI: Fix a potential uninitentional integer overflow issue

2020-11-14 Thread Bjorn Helgaas
[+cc Dan] On Tue, Nov 10, 2020 at 10:10:48PM +, Colin King wrote: > From: Colin Ian King > > The shift of 1 by align_order is evaluated using 32 bit arithmetic > and the result is assigned to a resource_size_t type variable that > is a 64 bit unsigned integer on 64 bit platforms. Fix an

[tip: irq/core] genirq: Remove GENERIC_IRQ_LEGACY_ALLOC_HWIRQ

2020-11-14 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the irq/core branch of tip: Commit-ID: f296dcd629aa412a80a53215e46087f53af87f08 Gitweb: https://git.kernel.org/tip/f296dcd629aa412a80a53215e46087f53af87f08 Author:Thomas Gleixner AuthorDate:Sat, 14 Nov 2020 22:01:45 +01:00

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-14 Thread Al Viro
On Fri, Nov 13, 2020 at 04:54:53PM -0700, Nathan Chancellor wrote: > Hi Al, > > On Wed, Nov 11, 2020 at 10:21:16PM +, Al Viro wrote: > > On Wed, Nov 11, 2020 at 09:52:20PM +, Al Viro wrote: > > > > > That can be done, but I would rather go with > > > n = copy_to_iter(m->buf +

[GIT PULL] percpu fix for v5.10-rc4

2020-11-14 Thread Dennis Zhou
Hi Linus, A fix for a Wshadow warning in asm-generic percpu macros came in and then I tacked on the removal of flexible array initializers in the percpu allocator which was discussed in the 5.9 pull request. Thanks, Dennis The following changes since commit

Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks

2020-11-14 Thread Bjorn Helgaas
[+cc Rafael for question about ACPI method for PCI host bridge reset] On Sat, Nov 14, 2020 at 09:58:08PM +0100, Thomas Gleixner wrote: > On Sat, Nov 14 2020 at 14:39, Bjorn Helgaas wrote: > > On Sat, Nov 14, 2020 at 12:40:10AM +0100, Thomas Gleixner wrote: > >> On Sat, Nov 14 2020 at 00:31,

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-14 Thread Arnd Bergmann
On Sat, Nov 14, 2020 at 4:14 PM Richard Cochran wrote: > > On Fri, Nov 13, 2020 at 05:21:43PM +0100, Arnd Bergmann wrote: > > I've prototyped a patch that I think makes this more sensible > > again: https://pastebin.com/AQ5nWS9e > > I like the behavior described in the text. > > Instead of this

Re: [PATCH v4 06/17] PCI: add SIOV and IMS capability detection

2020-11-14 Thread Raj, Ashok
On Sat, Nov 14, 2020 at 10:34:30AM +, Christoph Hellwig wrote: > On Thu, Nov 12, 2020 at 11:42:46PM +0100, Thomas Gleixner wrote: > > DMI vendor name is pretty good final check when the bit is 0. The > > strings I'm aware of are: > > > > QEMU, Bochs, KVM, Xen, VMware, VMW, VMware Inc.,

Re: [PATCH v1] clk: tegra30: Use 300MHz for video decoder by default

2020-11-14 Thread Stephen Boyd
Quoting Dmitry Osipenko (2020-11-04 05:48:10) > The 600MHz is a too high clock rate for some SoC versions for the video > decoder hardware and this may cause stability issues. Use 300MHz for the > video decoder by default, which is supported by all hardware versions. > > Fixes: ed1a2459e20c

Re: [PATCH v4 06/11] clk: at91: clk-sam9x60-pll: allow runtime changes for pll

2020-11-14 Thread Stephen Boyd
Quoting Claudiu Beznea (2020-11-06 01:46:23) > diff --git a/drivers/clk/at91/clk-sam9x60-pll.c > b/drivers/clk/at91/clk-sam9x60-pll.c > index 78f458a7b2ef..6fe5d8530a0c 100644 > --- a/drivers/clk/at91/clk-sam9x60-pll.c > +++ b/drivers/clk/at91/clk-sam9x60-pll.c > @@ -225,8 +225,51 @@ static int

Re: [PATCH v2 5/5] clk: qcom: dispcc-sm8250: handle MMCX power domain

2020-11-14 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2020-10-23 06:19:25) > On SM8250 MMCX power domain is required to access MMDS_GDSC registers. > This power domain is expressed as mmcx-supply regulator property. Use > this regulator as MDSS_GDSC supply. > > Signed-off-by: Dmitry Baryshkov > --- Applied to clk-next

Re: [PATCH] perf test: Fix dwarf unwind for optimized builds.

2020-11-14 Thread Jiri Olsa
On Fri, Nov 13, 2020 at 04:08:03PM -0800, Ian Rogers wrote: > To ensure the stack frames are on the stack tail calls optimizations > need to be inhibited. If your compiler supports an attribute use it, > otherwise use an asm volatile barrier. > > The barrier fix was suggested here: >

genirq: Remove GENERIC_IRQ_LEGACY_ALLOC_HWIRQ

2020-11-14 Thread Thomas Gleixner
Commit bb9d812643d8 ("arch: remove tile port") removed the last user of this cruft two years ago... Signed-off-by: Thomas Gleixner --- include/linux/irq.h | 15 --- kernel/irq/Kconfig |5 - kernel/irq/irqdesc.c | 51 ---

Re: [PATCH 0/2] clk: add devm variant of clk_notifier_register

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:38:45) > This patchset adds memory managed variant of clk_notifier_register and > a first usage of it the amlogic clock controller of the g12 SoC family. > > Jerome Brunet (2): > clk: add devm variant of clk_notifier_register I'm not sure if we want to

Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks

2020-11-14 Thread Thomas Gleixner
Bjorn, On Sat, Nov 14 2020 at 14:39, Bjorn Helgaas wrote: > On Sat, Nov 14, 2020 at 12:40:10AM +0100, Thomas Gleixner wrote: >> On Sat, Nov 14 2020 at 00:31, Thomas Gleixner wrote: >> > On Fri, Nov 13 2020 at 10:46, Bjorn Helgaas wrote: >> >> pci_device_shutdown() still clears the Bus Master

Re: [PATCH 2/2] clk: meson: g12: use devm variant to register notifiers

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:38:47) > Until now, nothing was done to unregister the dvfs clock notifiers of the > Amlogic g12 SoC family. This is not great but this driver was not really > expected to be unloaded. With the ongoing effort to build everything as > module for this platform,

Re: [PATCH 1/2] clk: add devm variant of clk_notifier_register

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:38:46) > Add a memory managed variant of clk_notifier_register() to make life easier > on clock consumers using notifiers > > Signed-off-by: Jerome Brunet > --- Applied to clk-next

v5.10-rc3 vs. Droid 4

2020-11-14 Thread Pavel Machek
Hi! Does anyone have Droid 4 working with 5.10-rc3? I tried it with the original config; I got message about culomb counter calibration done scrolling (and boot progressing very slowly or not at all) . So ... I disabled cpcap battery & charger support. But init still drops me to emergency shell.

Re: [PATCH RFC v1 1/1] scsi: pm: Leave runtime resume along if block layer PM is enabled

2020-11-14 Thread Bart Van Assche
On 11/12/20 10:30 PM, Can Guo wrote: > If block layer runtime PM is enabled for one SCSI device, then there is > no need to forcibly change the SCSI device and its request queue's runtime > PM status to active in scsi_dev_type_resume(), since block layer PM shall > resume the SCSI device on the

Re: [PATCH v2 2/3] clk: add api to get clk consumer from clk_hw

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:21:46) > clk_register() is deprecated. Using 'clk' member of struct clk_hw is > discouraged. With this constraint, it is difficult for driver to > register clocks using the clk_hw API and then use the clock with > the consumer API > > This adds a simple

Re: [PATCH v2 1/3] clk: avoid devm_clk_release name clash

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:21:45) > In clk-devres.c, devm_clk_release() is used to call clk_put() memory > managed clock. In clk.c the same name, in a different scope is used to call > clk_unregister(). > > As it stands, it is not really a problem but it does not readability, >

Re: [PATCH v2 3/3] clk: meson: g12: drop use of __clk_lookup()

2020-11-14 Thread Stephen Boyd
Quoting Jerome Brunet (2020-10-21 09:21:47) > g12 clock controller used __clk_lookup() to get struct clk from a > struct clk_hw. This type of hack is no longer required as CCF now provides > the necessary functions to get this. > > Signed-off-by: Jerome Brunet > --- Applied to clk-next

Re: [PATCH v2] perf data: Allow to use stdio functions for pipe mode

2020-11-14 Thread Jiri Olsa
On Fri, Oct 30, 2020 at 02:47:42PM +0900, Namhyung Kim wrote: > When perf data is in a pipe, it reads each event separately using > read(2) syscall. This is a huge performance bottleneck when > processing large data like in perf inject. Also perf inject needs to > use write(2) syscall for the

Re: [PATCH 1/6] seq_file: add seq_read_iter

2020-11-14 Thread Al Viro
On Sat, Nov 14, 2020 at 07:00:25AM +, Al Viro wrote: > On Fri, Nov 13, 2020 at 11:19:34PM -0700, Nathan Chancellor wrote: > > > Assuming so, I have attached the output both with and without the > > WARN_ON. Looks like mountinfo is what is causing the error? > > Cute... FWIW, on #origin +

Re: [GIT PULL] SCSI fixes for 5.10-rc3

2020-11-14 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Nov 2020 16:20:13 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0c0451112b629946c93ed2102b7ae47d4d1dc0bc Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] SELinux fixes for v5.10 (#1)

2020-11-14 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Nov 2020 18:29:23 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git > tags/selinux-pr-20201113 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/30636a59f4c1a40720156079cabcad60351949f2 Thank you! --

Re: [GIT PULL] hwmon fixes for v5.10-rc4

2020-11-14 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Nov 2020 17:51:11 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git > hwmon-for-v5.10-rc4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7e908b7461ec395293335852485a183c16765303 Thank you! --

Re: [GIT PULL] clk fixes for v5.10-rc3

2020-11-14 Thread pr-tracker-bot
The pull request you sent on Sat, 14 Nov 2020 11:39:34 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > tags/clk-fixes-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/31908a604ced3c047022c2cc9f178d3287f06dfe Thank you! --

Re: [GIT PULL] um fixes for 5.10-rc4

2020-11-14 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Nov 2020 23:20:04 +0100 (CET): > git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git > tags/for-linus-5.10-rc4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4aea779d35120d5062647d288817678decb28c10 Thank you! --

Re: [RESEND PATCH v2 4/5] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-11-14 Thread Rob Clark
On Sat, Nov 14, 2020 at 12:10 PM Jonathan Marek wrote: > > On 11/14/20 2:39 PM, Rob Clark wrote: > > On Sat, Nov 14, 2020 at 10:58 AM Jonathan Marek wrote: > >> > >> On 11/14/20 1:46 PM, Rob Clark wrote: > >>> On Sat, Nov 14, 2020 at 8:24 AM Christoph Hellwig wrote: > > On Sat, Nov

Re: [PATCH net 1/1] net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 22:49:48 +0800 Wong Vee Khee wrote: > Fix an issue where dump stack is printed on suspend resume flow due to > netif_set_real_num_rx_queues() is not called with rtnl_lock held(). > > Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set > real_num_rx|tx_queues") >

Re: [PATCH 24/24] perf record: Add --buildid-mmap option to enable mmap's build id

2020-11-14 Thread Jiri Olsa
On Sat, Nov 14, 2020 at 09:31:56AM +0900, Namhyung Kim wrote: > On Fri, Nov 13, 2020 at 8:09 PM Jiri Olsa wrote: > > > > On Fri, Nov 13, 2020 at 01:40:00PM +0900, Namhyung Kim wrote: > > > On Mon, Nov 09, 2020 at 10:54:15PM +0100, Jiri Olsa wrote: > > > > Adding --buildid-mmap option to enable

drivers/media/platform/exynos4-is/fimc-isp-video.h:35:6: warning: no previous prototype for 'fimc_isp_video_device_unregister'

2020-11-14 Thread kernel test robot
Hi Stephen, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable date: 6

Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks

2020-11-14 Thread Bjorn Helgaas
On Sat, Nov 14, 2020 at 12:40:10AM +0100, Thomas Gleixner wrote: > Bjorn, > > On Sat, Nov 14 2020 at 00:31, Thomas Gleixner wrote: > > On Fri, Nov 13 2020 at 10:46, Bjorn Helgaas wrote: > >> pci_device_shutdown() still clears the Bus Master Enable bit if we're > >> doing a kexec and the device is

  1   2   3   4   >