Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add compress_mode mount option

2020-12-02 Thread Daeho Jeong
Yep, you're right~ :) 2020년 12월 3일 (목) 오전 10:16, Chao Yu 님이 작성: > > On 2020/12/2 18:54, Daeho Jeong wrote: > > We might use compress_extension=*,compress_option=user. > > In this option, we're gonna allocate all the writes in cold zone. > > Oh, so all files in data partition will be tagged as

[no subject]

2020-12-02 Thread Yun Levi
On Thu, Dec 3, 2020 at 7:51 AM Yun Levi wrote: > > On Thu, Dec 3, 2020 at 6:26 AM Yury Norov wrote: > > > > On Wed, Dec 2, 2020 at 10:22 AM Yun Levi wrote: > > > > > > On Thu, Dec 3, 2020 at 2:26 AM Yury Norov wrote: > > > > > > > Also look at lib/find_bit_benchmark.c > > > Thanks. I'll see. >

Re: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

2020-12-02 Thread ivanhu
On 12/2/20 7:38 PM, Heinrich Schuchardt wrote: > On 11/30/20 11:38 AM, ivanhu wrote: >> >> >> On 11/30/20 5:17 PM, Heinrich Schuchardt wrote: >>> On 11/30/20 9:16 AM, ivanhu wrote: Hi Heinrich, Thanks for the patch. It looks good to me, but I noticed that the

Re: [PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb()

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 08:15:02 -0600 Alex Elder wrote: > Jon Hunter reported observing a build bug in the IPA driver: > > https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef826...@nvidia.com > > The problem is that the QMB0 max read value set for IPA v4.5 (16) is > too large to fit in

Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd wrote: > > This is already handed by default in spi_setup() if the bits_per_word is > 0, so just drop it to shave off a line. > > Cc: Simon Glass > Cc: Gwendal Grignou > Cc: Douglas Anderson > Cc: Alexandru M Stan > Signed-off-by: Stephen Boyd

Re: [SPECIFICATION RFC] The firmware and bootloader log specification

2020-12-02 Thread Julius Werner
Standardizing in-memory logging sounds like an interesting idea, especially with regards to components that can run on top of different firmware stacks (things like GRUB or TF-A). But I would be a bit wary of creating a "new standard to rule them all" and then expecting all projects to switch what

Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where

[PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-02 Thread Stephen Boyd
There isn't any need to overwrite the mode here in the driver with what has been detected by the firmware, such as DT or ACPI. In fact, if we use the SPI CS gpio descriptor feature we will overwrite the mode with SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly SPI_CS_HIGH.

[PATCH 0/2] cros_ec_spi: Work better with CS GPIO descriptors

2020-12-02 Thread Stephen Boyd
Two small patches to work better with the new CS GPIO descriptor logic. The first one fixes a problem found while trying to enable that feature and the second patch removes a line that I noticed while looking in the same area. Cc: Simon Glass Cc: Gwendal Grignou Cc: Douglas Anderson Cc:

[PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

2020-12-02 Thread Stephen Boyd
This is already handed by default in spi_setup() if the bits_per_word is 0, so just drop it to shave off a line. Cc: Simon Glass Cc: Gwendal Grignou Cc: Douglas Anderson Cc: Alexandru M Stan Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_spi.c | 1 - 1 file changed, 1

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: > From: Nick Terrell > > This patch: > - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h` > - Adds a new API in `include/linux/zstd.h` that is functionally > equivalent to the in-use subset of the current API. Functions are >

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add compress_mode mount option

2020-12-02 Thread Chao Yu
On 2020/12/2 18:54, Daeho Jeong wrote: We might use compress_extension=*,compress_option=user. In this option, we're gonna allocate all the writes in cold zone. Oh, so all files in data partition will be tagged as compressed file, but the compressing time will be controlled by user, then, only

Re: [PATCH] rtc: adapt allowed RTC update error

2020-12-02 Thread Thomas Gleixner
Cc+ RTC folks. On Wed, Dec 02 2020 at 23:08, Thomas Gleixner wrote: > On Wed, Dec 02 2020 at 16:54, Jason Gunthorpe wrote: >>> I don't think the timer should be canceled if the ntp_synced() state did >>> not change. Otherwise every do_adtimex() call will cancel/restart >>> it, which does not

Re: [PATCH RFC 10/39] KVM: x86/xen: support upcall vector

2020-12-02 Thread Ankur Arora
On 2020-12-02 11:02 a.m., David Woodhouse wrote: On Wed, 2020-12-02 at 18:34 +, Joao Martins wrote: On 12/2/20 4:47 PM, David Woodhouse wrote: On Wed, 2020-12-02 at 13:12 +, Joao Martins wrote: On 12/2/20 11:17 AM, David Woodhouse wrote: I might be more inclined to go for a model

Re: [PATCH 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-02 Thread kernel test robot
3bb61aa61828499a7d0f5e560051625fd02ae7e4 config: x86_64-randconfig-a004-20201202 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/40fa9177042a71ae3df7c776d693d27bce63fce8 git remote add linux-review https

Re: [PATCH 6/6] mm/gup: migrate pinned pages out of movable zone

2020-12-02 Thread Jason Gunthorpe
On Wed, Dec 02, 2020 at 07:19:45PM -0500, Pavel Tatashin wrote: > > It is a good moment to say, I really dislike how this was implemented > > in the first place. > > > > Scanning the output of gup just to do the is_migrate_movable() test is > > kind of nonsense and slow. It would be better/faster

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-12-02 Thread Li, Aubrey
On 2020/12/2 22:09, Li, Aubrey wrote: > Hi Balbir, > > I still placed the patch embedded in this thread, welcome any comments. Sorry, this version needs more work, refined as below, and I realized I should place a version number to the patch, start from v2 now. Thanks, -Aubrey

Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event

2020-12-02 Thread Namhyung Kim
Hi Stephane and Andi, On Thu, Dec 3, 2020 at 8:40 AM Stephane Eranian wrote: > > On Wed, Dec 2, 2020 at 2:42 PM Andi Kleen wrote: > > > > On Wed, Dec 02, 2020 at 11:47:25AM -0800, Stephane Eranian wrote: > > > On Wed, Dec 2, 2020 at 11:28 AM Andi Kleen wrote: > > > > > > > > > + prev_cgrp

Re: [PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-02 Thread Jakub Kicinski
On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote: > If adding bridge sysfs fails, br->ifobj will be NULL, there is no > need to delete its non-existent sysfs when deleting the bridge device, > otherwise, it will cause a warning. So, when br->ifobj == NULL, > directly return can fix this bug. > >

Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event

2020-12-02 Thread Namhyung Kim
Hi Peter, On Thu, Dec 3, 2020 at 1:19 AM Peter Zijlstra wrote: > > On Thu, Dec 03, 2020 at 12:02:04AM +0900, Namhyung Kim wrote: > > > +#ifdef CONFIG_CGROUP_PERF > > +static inline void > > +perf_sw_event_cgroup_switch(struct task_struct *prev, struct task_struct > > *next) > > +{ > > +

[PATCH v2] i2c: ismt: Use dma_set_mask_and_coherent

2020-12-02 Thread Youling Tang
'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. Signed-off-by: Youling Tang --- drivers/i2c/busses/i2c-ismt.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] Documentation: fix typos found in process, dev-tools, and doc-guide subdirectories

2020-12-02 Thread Miguel Ojeda
On Wed, Dec 2, 2020 at 8:56 AM Andrew Klychkov wrote: > > Fix four typos in kcov.rst, sphinx.rst, clang-format.rst, and > embargoed-hardware-issues.rst > > Signed-off-by: Andrew Klychkov > --- > Documentation/dev-tools/kcov.rst| 2 +- > Documentation/doc-guide/sphinx.rst

Re: [PATCH v3 7/7] bus: mhi: Improve documentation on channel transfer setup APIs

2020-12-02 Thread Hemant Kumar
On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: The mhi_prepare_for_transfer() and mhi_unprepare_from_transfer() APIs could use better explanation, especially with the addition of two new APIs to start and stop the transfers on channels. Add better set of information for those APIs. Signed-off-by:

Re: [RFC PATCH] blk-mq: Clean up references when freeing rqs

2020-12-02 Thread Ming Lei
On Wed, Dec 02, 2020 at 11:18:31AM +, John Garry wrote: > On 02/12/2020 03:31, Ming Lei wrote: > > On Tue, Dec 01, 2020 at 09:02:18PM +0800, John Garry wrote: > > > It has been reported many times that a use-after-free can be > > > intermittently > > > found when iterating busy requests: > >

[resend/standalone PATCH v4] Add auxiliary bus support

2020-12-02 Thread Dan Williams
From: Dave Ertman Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. It enables drivers to create an auxiliary_device and bind an auxiliary_driver to it. The bus supports probe/remove shutdown and suspend/resume callbacks. Each auxiliary_device has a unique string based

Re: [PATCH v3 5/7] bus: mhi: core: Check execution environment for channel before issuing reset

2020-12-02 Thread Hemant Kumar
On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: A client can attempt to unprepare certain channels for transfer even after the execution environment they are supposed to run in has changed. In the event that happens, the device need not be notified of the reset and the host can proceed with clean up

Re: [PATCH v12 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-12-02 Thread Kelley, Sean V
> On Dec 2, 2020, at 3:44 PM, Bjorn Helgaas wrote: > > On Fri, Nov 20, 2020 at 04:10:33PM -0800, Sean V Kelley wrote: >> From: Qiuxu Zhuo >> >> When attempting error recovery for an RCiEP associated with an RCEC device, >> there needs to be a way to update the Root Error Status, the

Re: [PATCH v3 3/7] bus: mhi: core: Improvements to the channel handling state machine

2020-12-02 Thread Hemant Kumar
On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: Add support to enable sending the stop channel command and improve the channel handling state machine such that all commands go through a common function. This can help ensure that the state machine is not violated in any way and adheres to the MHI

linux-next: manual merge of the v4l-dvb tree with the mvebu tree

2020-12-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the v4l-dvb tree got a conflict in: MAINTAINERS between commit: 8c4e256e3d42 ("MAINTAINERS: Add an entry for MikroTik CRS3xx 98DX3236 boards") from the mvebu tree and commit: b24cc2a18c50 ("media: smiapp: Rename as "ccs"") from the v4l-dvb tree. I

Re: [PATCH] i2c: busses: Use dma_set_mask_and_coherent

2020-12-02 Thread Youling Tang
Hi, Wolfram On 12/03/2020 12:01 AM, Wolfram Sang wrote: On Tue, Nov 24, 2020 at 09:08:35PM +0800, Youling Tang wrote: 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. Signed-off-by: Youling Tang

Re: [PATCH 4/4] riscv: dts: add initial board data for the SiFive HiFive Unmatched

2020-12-02 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yash-Shah/arch-riscv-add-board-and-SoC-DT-file-support/20201202-160811 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh

[PATCH v2 0/7] Clean up UBSAN Makefile

2020-12-02 Thread Kees Cook
Hi, This series attempts to address the issues seen with UBSAN's object-size sanitizer causing problems under GCC. In the process, the Kconfig and Makefile are refactored to do all the cc-option calls in the Kconfig. Additionally start to detangle -Wno-maybe-uninitialized, disable UBSAN_TRAP

[PATCH v2 4/7] ubsan: Disable UBSAN_TRAP for all*config

2020-12-02 Thread Kees Cook
Doing all*config builds attempts to build as much as possible. UBSAN_TRAP effectively short-circuits lib/usban.c, so it should be disabled for COMPILE_TEST so that the lib/ubsan.c code gets built. Reviewed-by: Nathan Chancellor Signed-off-by: Kees Cook --- lib/Kconfig.ubsan | 1 + 1 file

Re: [PATCH] netfilter: conntrack: fix -Wformat

2020-12-02 Thread Tom Rix
On 12/2/20 2:34 PM, Nick Desaulniers wrote: > On Tue, Nov 10, 2020 at 2:04 PM Joe Perches wrote: >> On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote: >> >>> Yeah, we could go through and remove %h and %hh to solve this, too, right? >> Yup. >> >> I think one of the checkpatch

[PATCH v2 6/7] ubsan: Remove UBSAN_MISC in favor of individual options

2020-12-02 Thread Kees Cook
Make each UBSAN option individually selectable and remove UBSAN_MISC which no longer has any purpose. Add help text for each Kconfig, and include a reference to the Clang sanitizer documentation. Disable unsigned overflow by default (not available with GCC and makes x86 unbootable with Clang).

[PATCH net v3] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
Don't try to adjust XFRM support flags if the bond device isn't yet registered. Bad things can currently happen when netdev_change_features() is called without having wanted_features fully filled in yet. This code runs on post-module-load mode changes, as well as at module init time and new bond

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-02 Thread Stephen Boyd
Quoting Stephen Boyd (2020-12-02 15:28:45) > Quoting Alexandru M Stan (2020-12-02 14:18:20) > > Unfortunately this patch makes my cros-ec (the main EC that used to > > work even before my debugging) also fail to probe: > > [0.839533] cros-ec-spi spi6.0: EC failed to respond in time > > [

[PATCH v2 2/7] ubsan: Move cc-option tests into Kconfig

2020-12-02 Thread Kees Cook
Instead of doing if/endif blocks with cc-option calls in the UBSAN Makefile, move all the tests into Kconfig and use the Makefile to collect the results. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/lkml/CAHk-=wjPasyJrDuwDnpHJS2TuQfExwe=px-szlen8gfmaqj...@mail.gmail.com/

[PATCH v2 1/7] ubsan: Remove redundant -Wno-maybe-uninitialized

2020-12-02 Thread Kees Cook
In commit 78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized") -Wmaybe-uninitialized was disabled globally, so keeping the disabling logic here too doesn't make sense. Signed-off-by: Kees Cook --- lib/Kconfig.ubsan | 4 scripts/Makefile.ubsan | 4 2 files changed, 8

[PATCH v2 7/7] ubsan: Expand tests and reporting

2020-12-02 Thread Kees Cook
Expand the UBSAN tests to include some additional UB cases. Notably the out-of-bounds enum loading appears not to work. Also include per-test reporting, including the relevant CONFIG_UBSAN... Kconfigs. Signed-off-by: Kees Cook --- lib/test_ubsan.c | 74

[PATCH v2 5/7] ubsan: Enable for all*config builds

2020-12-02 Thread Kees Cook
With UBSAN_OBJECT_SIZE disabled for GCC, only UBSAN_ALIGNMENT remained a noisy UBSAN option. Disable it for COMPILE_TEST so the rest of UBSAN can be used for full all*config builds or other large combinations. Link:

[PATCH v2 3/7] ubsan: Disable object-size sanitizer under GCC

2020-12-02 Thread Kees Cook
GCC's -fsanitize=object-size (as part of CONFIG_UBSAN_MISC) greatly increases stack utilization. Do not allow this under GCC. Suggested-by: Linus Torvalds Link: https://lore.kernel.org/lkml/CAHk-=wjPasyJrDuwDnpHJS2TuQfExwe=px-szlen8gfmaqj...@mail.gmail.com/ Reviewed-by: Nathan Chancellor

Re: [PATCH v2 1/9] KVM: x86: Add AMD SEV specific Hypercall3

2020-12-02 Thread Sean Christopherson
On Tue, Dec 01, 2020, Ashish Kalra wrote: > From: Brijesh Singh > > KVM hypercall framework relies on alternative framework to patch the > VMCALL -> VMMCALL on AMD platform. If a hypercall is made before > apply_alternative() is called then it defaults to VMCALL. The approach > works fine on non

Re: [PATCH] Documentation: fix typos found in process, dev-tools, and doc-guide subdirectories

2020-12-02 Thread Randy Dunlap
On 12/1/20 11:54 PM, Andrew Klychkov wrote: > Fix four typos in kcov.rst, sphinx.rst, clang-format.rst, and > embargoed-hardware-issues.rst > > Signed-off-by: Andrew Klychkov > --- > Documentation/dev-tools/kcov.rst| 2 +- > Documentation/doc-guide/sphinx.rst

Re: [RFC V2 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-02 Thread Anshuman Khandual
On 12/3/20 2:02 AM, Heiko Carstens wrote: > On Mon, Nov 30, 2020 at 08:59:52AM +0530, Anshuman Khandual wrote: >> This overrides arch_get_mappabble_range() on s390 platform and drops now >> redundant similar check in vmem_add_mapping(). This compensates by adding >> a new check __segment_load()

Re: [PATCH v3 4/7] bus: mhi: core: Add support to stop or start channel data transfers

2020-12-02 Thread Hemant Kumar
Hi Bhaumik, On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: Some MHI client drivers may want to request a pause or halt of data transfer activity on their channels. Support for this does not exist and must be introduced, wherein the channel context is not reset or cleared but only the STOP channel

Re: [PATCH] Documentation: fix typos found in admin-guide subdirectory

2020-12-02 Thread Randy Dunlap
On 12/2/20 12:44 AM, Andrew Klychkov wrote: > diff --git a/Documentation/admin-guide/binfmt-misc.rst > b/Documentation/admin-guide/binfmt-misc.rst > index 7a86413..287d54c 100644 > --- a/Documentation/admin-guide/binfmt-misc.rst > +++ b/Documentation/admin-guide/binfmt-misc.rst > @@ -43,7 +43,7

Re: [PATCH] Documentation: fix typos in process/kernel-docs.rst

2020-12-02 Thread Randy Dunlap
On 12/1/20 11:49 PM, Andrew Klychkov wrote: > Fix two typos in kernel-docs.rst > > Signed-off-by: Andrew Klychkov > --- > Documentation/process/kernel-docs.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/process/kernel-docs.rst >

Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread

2020-12-02 Thread Herbert Xu
On Wed, Dec 02, 2020 at 04:28:07PM +0200, Horia Geantă wrote: > > I wasn't able to find a follow-up on this topic. > Could you advise on what's the proper thing to do going forward? I think someone needs to come up with a patch that does not cause regressions. Cheers, -- Email: Herbert Xu Home

Re: [PATCH 6/6] mm/gup: migrate pinned pages out of movable zone

2020-12-02 Thread Pavel Tatashin
> It is a good moment to say, I really dislike how this was implemented > in the first place. > > Scanning the output of gup just to do the is_migrate_movable() test is > kind of nonsense and slow. It would be better/faster to handle this > directly while gup is scanning the page tables and adding

Re: [PATCH bpf V3 0/2] xsk: fix for xsk_poll writeable

2020-12-02 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (refs/heads/master): On Tue, 1 Dec 2020 21:56:56 +0800 you wrote: > V2: >#2 patch made some changes following magnus' opinions. > > V3: >Regarding the function xskq_cons_present_entries, I think daniel are right, >I have modified it. >

Re: [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state

2020-12-02 Thread Hemant Kumar
On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: If a channel was explicitly stopped but not reset, allow it to move to a disabled state so the channel context can be cleaned up. As the channel remained in a stopped state, its context was not reset and cleared, which needs to be done if a client

Re: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response

2020-12-02 Thread Hemant Kumar
Hi Bhaumik, On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: Add support to receive the response to a STOP channel command to the How about saying "Add support to send the STOP channel command ? MHI bus. If a client would like to STOP a channel instead of issuing a RESET to it, this would provide

[tip:x86/sgx] BUILD SUCCESS bab8c183d1d452f5fdc059aef2f0788bd2986231

2020-12-02 Thread kernel test robot
defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201202

Re: [RFC V2 0/3] mm/hotplug: Pre-validate the address range with platform

2020-12-02 Thread Anshuman Khandual
On 12/3/20 2:05 AM, Heiko Carstens wrote: > On Mon, Nov 30, 2020 at 08:59:49AM +0530, Anshuman Khandual wrote: >> This series adds a mechanism allowing platforms to weigh in and prevalidate >> incoming address range before proceeding further with the memory hotplug. >> This helps prevent

Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable

2020-12-02 Thread Miguel Ojeda
On Thu, Dec 3, 2020 at 12:55 AM Axel Rasmussen wrote: > > This is what clang-format yields. Are you thinking it would be better > to line everything up with the ( in uffd_error( ? Yeah, sometimes clang-format cannot do a good job with the 80 column limit + 8 tabs. You are definitely not forced

Re: [PATCH v8 02/16] kbuild: add support for Clang LTO

2020-12-02 Thread Nick Desaulniers
On Tue, Dec 1, 2020 at 1:37 PM Sami Tolvanen wrote: > > This change adds build system support for Clang's Link Time > Optimization (LTO). With -flto, instead of ELF object files, Clang > produces LLVM bitcode, which is compiled into native code at link > time, allowing the final binary to be

[PATCH] drm/nouveau: avoid a use-after-free when BO init fails

2020-12-02 Thread Jeremy Cline
nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code back to the caller. On failures, ttm_bo_init() invokes the provided destructor which should de-initialize and free the memory. Thus, when nouveau_bo_init() returns an error the gem object has already been released and the

Re: [PATCH] mm/page_isolation: do not isolate the max order page

2020-12-02 Thread Vlastimil Babka
On 12/2/20 1:21 PM, Muchun Song wrote: > The max order page has no buddy page and never merge to other order. > So isolating and then freeing it is pointless. > > Signed-off-by: Muchun Song Acked-by: Vlastimil Babka > --- > mm/page_isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 3/6] mm/gup: make __gup_longterm_locked common

2020-12-02 Thread Pavel Tatashin
On Wed, Dec 2, 2020 at 1:19 PM Pavel Tatashin wrote: > > On Wed, Dec 2, 2020 at 11:33 AM Ira Weiny wrote: > > > > On Wed, Dec 02, 2020 at 08:31:45AM -0800, 'Ira Weiny' wrote: > > > On Wed, Dec 02, 2020 at 12:23:27AM -0500, Pavel Tatashin wrote: > > > > __gup_longterm_locked() has CMA || FS_DAX

Re: [PATCH v2] tpm_tis: Disable interrupts if interrupt storm detected

2020-12-02 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2020-12-02 09:49 MST: > On Tue, Dec 01, 2020 at 12:59:23PM -0700, Jerry Snitselaar wrote: >> >> Jerry Snitselaar @ 2020-11-30 20:26 MST: >> >> > Jerry Snitselaar @ 2020-11-30 19:58 MST: >> > >> >> When enabling the interrupt code for the tpm_tis driver we have >> >> noticed

Re: [PATCH v8 00/16] Add support for Clang LTO

2020-12-02 Thread Nick Desaulniers
On Tue, Dec 1, 2020 at 1:37 PM Sami Tolvanen wrote: > > This patch series adds support for building the kernel with Clang's > Link Time Optimization (LTO). In addition to performance, the primary > motivation for LTO is to allow Clang's Control-Flow Integrity (CFI) > to be used in the kernel.

[PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2020-12-02 Thread Chun-Kuang Hu
rx_callback is a standard mailbox callback mechanism and could cover the function of proprietary cmdq_task_cb, so it is better to use the standard one instead of the proprietary one. But register rx_callback should before mbox_request_channel(), so remove cmdq_pkt_flush() and let client driver

Re: [PATCH v6 3/3] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

2020-12-02 Thread kernel test robot
Hi Nick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on kdave/for-next f2fs/dev-test kees/for-next/pstore linus/master v5.10-rc6] [cannot apply to crypto/master squashfs/master next-20201201] [If your patch is

Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable

2020-12-02 Thread Axel Rasmussen
On Wed, Dec 2, 2020 at 3:10 PM Peter Xu wrote: > > Hi, Axel, > > Looks mostly good to me, but a few nitpickings below. > > On Wed, Dec 02, 2020 at 01:15:42PM -0800, Axel Rasmussen wrote: > > [...] > > > +static void uffd_error(const char *message, __s64 code) > > +{ > > + fprintf(stderr, "%s:

Re: [PATCH AUTOSEL 5.7 03/30] ima: extend boot_aggregate with kernel measurements

2020-12-02 Thread Sasha Levin
On Mon, Nov 30, 2020 at 10:13:02PM -0500, Mimi Zohar wrote: On Mon, 2020-11-30 at 19:21 -0500, Sasha Levin wrote: On Sun, Nov 29, 2020 at 08:17:38AM -0500, Mimi Zohar wrote: >Hi Sasha, > >On Wed, 2020-07-08 at 21:27 -0400, Sasha Levin wrote: >> On Wed, Jul 08, 2020 at 12:13:13PM -0400, Mimi

Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files

2020-12-02 Thread Moritz Fischer
Hi Sonal, On Wed, Dec 02, 2020 at 06:57:11PM +, Sonal Santan wrote: > Hi Moritz, > > > -Original Message- > > From: Moritz Fischer > > Sent: Monday, November 30, 2020 8:27 PM > > To: Sonal Santan > > Cc: linux-kernel@vger.kernel.org; linux-f...@vger.kernel.org; Max Zhen > > ; Lizhi

Re: [PATCH v3 6/7] bus: mhi: core: Remove __ prefix for MHI channel unprepare function

2020-12-02 Thread Hemant Kumar
On 12/2/20 3:40 PM, Bhaumik Bhatt wrote: The __mhi_unprepare_channel() API does not require the __ prefix. Get rid of it and make the internal function consistent with the other function names. Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Reviewed-by: Hemant Kumar The

Re: [PATCH] mm: refactor initialization of stuct page for holes in memory layout

2020-12-02 Thread Andrew Morton
On Tue, 1 Dec 2020 20:15:02 +0200 Mike Rapoport wrote: > From: Mike Rapoport > > There could be struct pages that are not backed by actual physical memory. > This can happen when the actual memory bank is not a multiple of > SECTION_SIZE or when an architecture does not register memory holes

Re: [PATCH v12 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-12-02 Thread Bjorn Helgaas
On Fri, Nov 20, 2020 at 04:10:33PM -0800, Sean V Kelley wrote: > From: Qiuxu Zhuo > > When attempting error recovery for an RCiEP associated with an RCEC device, > there needs to be a way to update the Root Error Status, the Uncorrectable > Error Status and the Uncorrectable Error Severity of

crediting bug reports and fixes folded into original patch

2020-12-02 Thread Vlastimil Babka
Hi, there was a bit of debate on Twitter about this, so I thought I would bring it here. Imagine a scenario where patch sits as a commit in -next and there's a bug report or fix, possibly by a bot or with some static analysis. The maintainer decides to fold it into the original patch, which makes

[PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated

2020-12-02 Thread Tony Krowiak
The vfio_ap device driver registers a group notifier with VFIO when the file descriptor for a VFIO mediated device for a KVM guest is opened to receive notification that the KVM pointer is set (VFIO_GROUP_NOTIFY_SET_KVM event). When the KVM pointer is set, the vfio_ap driver stashes the pointer

[PATCH v3 7/7] bus: mhi: Improve documentation on channel transfer setup APIs

2020-12-02 Thread Bhaumik Bhatt
The mhi_prepare_for_transfer() and mhi_unprepare_from_transfer() APIs could use better explanation, especially with the addition of two new APIs to start and stop the transfers on channels. Add better set of information for those APIs. Signed-off-by: Bhaumik Bhatt --- include/linux/mhi.h | 26

Re: [PATCH v2] mm: Don't fault around userfaultfd-registered regions on reads

2020-12-02 Thread Peter Xu
On Wed, Dec 02, 2020 at 02:37:33PM -0800, Hugh Dickins wrote: > On Tue, 1 Dec 2020, Andrea Arcangeli wrote: > > > > Any suggestions on how to have the per-vaddr per-mm _PAGE_UFFD_WP bit > > survive the pte invalidates in a way that remains associated to a > > certain vaddr in a single mm (so it

Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event

2020-12-02 Thread Stephane Eranian
On Wed, Dec 2, 2020 at 2:42 PM Andi Kleen wrote: > > On Wed, Dec 02, 2020 at 11:47:25AM -0800, Stephane Eranian wrote: > > On Wed, Dec 2, 2020 at 11:28 AM Andi Kleen wrote: > > > > > > > + prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup; > > > > + next_cgrp =

[PATCH v3 5/7] bus: mhi: core: Check execution environment for channel before issuing reset

2020-12-02 Thread Bhaumik Bhatt
A client can attempt to unprepare certain channels for transfer even after the execution environment they are supposed to run in has changed. In the event that happens, the device need not be notified of the reset and the host can proceed with clean up for the channel context and memory allocated

[PATCH v3 4/7] bus: mhi: core: Add support to stop or start channel data transfers

2020-12-02 Thread Bhaumik Bhatt
Some MHI client drivers may want to request a pause or halt of data transfer activity on their channels. Support for this does not exist and must be introduced, wherein the channel context is not reset or cleared but only the STOP channel command is issued. This would need to be paired with an API

[PATCH v3 3/7] bus: mhi: core: Improvements to the channel handling state machine

2020-12-02 Thread Bhaumik Bhatt
Add support to enable sending the stop channel command and improve the channel handling state machine such that all commands go through a common function. This can help ensure that the state machine is not violated in any way and adheres to the MHI specification. Signed-off-by: Bhaumik Bhatt ---

[PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state

2020-12-02 Thread Bhaumik Bhatt
If a channel was explicitly stopped but not reset, allow it to move to a disabled state so the channel context can be cleaned up. As the channel remained in a stopped state, its context was not reset and cleared, which needs to be done if a client driver module is unloaded or a device crash

[PATCH v3 0/7] Updates to MHI channel handling

2020-12-02 Thread Bhaumik Bhatt
MHI specification shows a state machine with support for STOP channel command and the validity of certain state transitions. MHI host currently does not provide any mechanism to stop a channel and restart it without resetting it. There are also times when the device moves on to a different

Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held

2020-12-02 Thread Qian Cai
On Wed, 2020-12-02 at 15:15 -0800, Andrew Morton wrote: > On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > > > We can't call kvfree() with a spin lock held, so defer it. > > > > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct > allocatio > n") > > Do you think it's

[PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response

2020-12-02 Thread Bhaumik Bhatt
Add support to receive the response to a STOP channel command to the MHI bus. If a client would like to STOP a channel instead of issuing a RESET to it, this would provide support for it. Signed-off-by: Bhaumik Bhatt --- drivers/bus/mhi/core/main.c | 5 + 1 file changed, 5 insertions(+)

[PATCH v3 6/7] bus: mhi: core: Remove __ prefix for MHI channel unprepare function

2020-12-02 Thread Bhaumik Bhatt
The __mhi_unprepare_channel() API does not require the __ prefix. Get rid of it and make the internal function consistent with the other function names. Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/main.c | 10 +- 1 file changed, 5

Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints

2020-12-02 Thread Tejun Heo
Hello, On Wed, Dec 02, 2020 at 03:23:57PM -0800, Shakeel Butt wrote: > > There've been some changes to cgroup ids recently and now cgroup id, ino and > > its file_handle are all compatible. On 64bit ino machines, they're all the > > same and won't be reused. On 32bit ino machines, the lower 32bit

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-02 Thread Stephen Boyd
Quoting Alexandru M Stan (2020-12-02 14:18:20) > On Wed, Dec 2, 2020 at 1:49 PM Stephen Boyd wrote: > > > > Let's set the 'use_gpio_descriptors' field so that we use the new way of > > requesting the CS GPIOs in the core. This allows us to avoid having to > > configure the CS pins in "output"

Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints

2020-12-02 Thread Shakeel Butt
On Wed, Dec 2, 2020 at 11:01 AM Tejun Heo wrote: > > Hello, > > On Tue, Dec 01, 2020 at 12:53:46PM -0800, Shakeel Butt wrote: > > The writeback tracepoint in include/trace/events/writeback.h is > > already using the cgroup IDs. Actually it used to use cgroup_path but > > converted to cgroup_ino.

Re: [PATCH v3 00/17] Introducing Linux root partition support for Microsoft Hypervisor

2020-12-02 Thread Wei Liu
On Wed, Dec 02, 2020 at 08:51:38PM +0100, Enrico Weigelt, metux IT consult wrote: > On 24.11.20 18:07, Wei Liu wrote: > > Hi, > > > There will be a subsequent patch series to provide a > > device node (/dev/mshv) such that userspace programs can create and run > > virtual > > machines. > >

Re: [PATCH v12 07/15] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery()

2020-12-02 Thread Bjorn Helgaas
On Fri, Nov 20, 2020 at 04:10:28PM -0800, Sean V Kelley wrote: > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c > index 7a5af873d8bc..46a5b84f8842 100644 > --- a/drivers/pci/pcie/err.c > +++ b/drivers/pci/pcie/err.c > @@ -151,24 +151,27 @@ pci_ers_result_t pcie_do_recovery(struct

Re: [PATCH -tip 23/32] sched: Add a per-thread core scheduling interface

2020-12-02 Thread chris hyser
On 12/2/20 4:47 PM, Chris Hyser wrote: + get_task_struct(task); + + /* +* Check if this process has the right to modify the specified +* process. Use the regular "ptrace_may_access()" checks. +*/ + if (!ptrace_may_access(task,

[no subject]

2020-12-02 Thread Yun Levi
On Thu, Dec 3, 2020 at 3:55 AM Andy Shevchenko wrote: > > On Wed, Dec 02, 2020 at 08:51:27PM +0200, Andy Shevchenko wrote: > > On Thu, Dec 03, 2020 at 03:27:33AM +0900, Yun Levi wrote: > > > On Thu, Dec 3, 2020 at 2:36 AM Andy Shevchenko > > > wrote: > > > > On Wed, Dec 02, 2020 at 09:26:05AM

Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held

2020-12-02 Thread Andrew Morton
On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > We can't call kvfree() with a spin lock held, so defer it. > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct allocatio n") Do you think it's worth a cc:stable? IOW, is this known to ever produce a warning? (If not,

Re: [PATCH] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2020-12-02 Thread Nick Desaulniers
On Mon, Nov 30, 2020 at 7:42 PM Masahiro Yamada wrote: > > On Tue, Dec 1, 2020 at 12:29 PM Masahiro Yamada wrote: > > > > The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang. > > > > You can see it at https://godbolt.org/z/6ed1oW (this link misses -gdwarf-4 for clang, but I think

Re: [PATCH] userfaultfd: selftests: make __{s,u}64 format specifiers portable

2020-12-02 Thread Peter Xu
Hi, Axel, Looks mostly good to me, but a few nitpickings below. On Wed, Dec 02, 2020 at 01:15:42PM -0800, Axel Rasmussen wrote: [...] > +static void uffd_error(const char *message, __s64 code) > +{ > + fprintf(stderr, "%s: %" PRId64 "\n", message, (int64_t)code); > + exit(1); > +}

Re: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-02 Thread Moritz Fischer
Hi Max, On Wed, Dec 02, 2020 at 09:24:29PM +, Max Zhen wrote: > Hi Moritz, > > Thanks for your feedback. Please see my reply inline. > > Thanks, > -Max > > > -Original Message- > > From: Moritz Fischer > > Sent: Monday, November 30, 2020 20:55 > > To: Sonal Santan > > Cc:

Re: [PATCH 5/8] clk: sunxi-ng: Add support for the Allwinner H616 CCU

2020-12-02 Thread André Przywara
On 02/12/2020 21:03, Jernej Škrabec wrote: > Dne sreda, 02. december 2020 ob 14:54:06 CET je Andre Przywara napisal(a): >> While the clocks are fairly similar to the H6, many differ in tiny >> details, so a separate clock driver seems indicated. >> >> Derived from the H6 clock driver, and adjusted

[PATCH v7 7/7] mtd: spi-nor: keep lock bits if they are non-volatile

2020-12-02 Thread Michael Walle
Traditionally, linux unlocks the whole flash because there are legacy devices which has the write protections bits set by default at startup. If you actually want to use the flash protection bits, eg. because there is a read-only part for a bootloader, this automatic unlocking is harmful. If there

Re: [PATCH] rtc: adapt allowed RTC update error

2020-12-02 Thread Jason Gunthorpe
On Wed, Dec 02, 2020 at 11:08:38PM +0100, Thomas Gleixner wrote: > > > > arch/x86/kernel/kvmclock.c: x86_platform.set_wallclock = > > kvm_set_wallclock; > > arch/x86/kernel/x86_init.c: x86_platform.set_wallclock = > > set_rtc_noop; > > arch/x86/xen/time.c:

[PATCH v7 4/7] mtd: spi-nor: sst: remove global protection flag

2020-12-02 Thread Michael Walle
This is considered bad for the following reasons: (1) We only support the block protection with BPn bits for write protection. Not all SST parts support this. (2) Newly added flash chip will automatically inherit the "has locking" support and thus needs to explicitly tested. Better

[PATCH v7 3/7] mtd: spi-nor: atmel: remove global protection flag

2020-12-02 Thread Michael Walle
This is considered bad for the following reasons: (1) We only support the block protection with BPn bits for write protection. Not all Atmel parts support this. (2) Newly added flash chip will automatically inherit the "has locking" support and thus needs to explicitly tested. Better

[PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C

2020-12-02 Thread Michael Walle
This flash part actually has 4 block protection bits. Reported-by: Tudor Ambarus Cc: sta...@vger.kernel.org # v5.7+ Signed-off-by: Michael Walle --- I didn't add the Fixes: tag because we depend on the 4bit BP support which was introduced in 5.7. changes since v6: - new patch

<    1   2   3   4   5   6   7   8   9   10   >