[PATCH v2] f2fs: fix to keep isolation of atomic write

2020-12-29 Thread Chao Yu
ThreadA ThreadB - f2fs_ioc_start_atomic_write - write - f2fs_ioc_commit_atomic_write - f2fs_commit_inmem_pages - f2fs_drop_inmem_pages - f2fs_drop_inmem_pages - __revoke_inmem_pages - f2fs_vm_page_mkwrite

Re: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback

2020-12-29 Thread Can Guo
On 2020-12-30 15:20, Avri Altman wrote: Users can initiate resets to specific SCSI device/target/host through IOCTL. When this happens, the SCSI cmd passed to eh_device/target/host _reset_handler() callbacks is initialized with a request whose tag is -1. So, in this case, it is not right for

Re: Registering IRQ for MT7530 internal PHYs

2020-12-29 Thread Heiner Kallweit
On 30.12.2020 05:22, DENG Qingfang wrote: > Hi, > > I added MT7530 IRQ support and registered its internal PHYs to IRQ. > It works but my patch used two hacks. > > 1. Removed phy_drv_supports_irq check, because config_intr and > handle_interrupt are not set for Generic PHY. > I don't think

[PATCH] ibmvnic: fix: NULL pointer dereference.

2020-12-29 Thread YANG LI
The error is due to dereference a null pointer in function reset_one_sub_crq_queue(): if (!scrq) { netdev_dbg(adapter->netdev, "Invalid scrq reset. irq (%d) or msgs(%p).\n", scrq->irq, scrq->msgs); return -EINVAL; } If the expression is true,

RE: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback

2020-12-29 Thread Avri Altman
> Users can initiate resets to specific SCSI device/target/host through > IOCTL. When this happens, the SCSI cmd passed to eh_device/target/host > _reset_handler() callbacks is initialized with a request whose tag is -1. > So, in this case, it is not right for eh_device_reset_handler() callback

Re: [PATCH] 9p: fix: Uninitialized variable p.

2020-12-29 Thread Dominique Martinet
YANG LI wrote on Wed, Dec 30, 2020: > The pointer p is being used but it isn't being initialized, > need to assign a NULL to it. My understanding is p has to be initialized: the only way out of the while(1) loop below sets it. I don't mind fixing false positive warnings as it makes maintenance

Re: [PATCH v2 1/2] x86/cpufeatures: Add the Virtual SPEC_CTRL feature

2020-12-29 Thread Borislav Petkov
On Tue, Dec 22, 2020 at 04:31:32PM -0600, Babu Moger wrote: > Newer AMD processors have a feature to virtualize the use of the > SPEC_CTRL MSR. Presence of this feature is indicated via CPUID > function 0x800A_EDX[20]: GuestSpecCtrl. When preset, the SPEC_CTRL > MSR is automatically

Re: [PATCH v2 2/2] KVM: SVM: Add support for Virtual SPEC_CTRL

2020-12-29 Thread Borislav Petkov
On Tue, Dec 22, 2020 at 04:31:55PM -0600, Babu Moger wrote: > @@ -2549,7 +2559,10 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, struct > msr_data *msr_info) > !guest_cpuid_has(vcpu, X86_FEATURE_AMD_SSBD)) > return 1; > > - msr_info->data =

[PATCH v2] checkpatch: ignore warning designated initializers using NR_CPUS

2020-12-29 Thread Peng Wang
Some max_length wants to hold as large room as possible to ensure enough size to tackle with the biggest NR_CPUS. An example below: kernel/cgroup/cpuset.c: static struct cftype legacy_files[] = { { .name = "cpus", .seq_show = cpuset_common_seq_show,

Re: [PATCH] checkpatch: ignore warning designated initializers using NR_CPUS

2020-12-29 Thread Peng Wang
Hi, Joe On 12/30/20 1:35 PM, , Joe Perches wrote: On Wed, 2020-12-30 at 12:13 +0800, Peng Wang wrote: Some max_length wants to hold as large room as possible to ensure enough size to tackle with the biggest NR_CPUS. As an example below: kernel/cgroup/cpuset.c: static struct cftype

Re: [PATCH] mm: fix: Uninitialized variable ret.

2020-12-29 Thread Muchun Song
YANG LI 于2020年12月30日周三 下午3:02写道: > > The ret is being used but it isn't being initialized, > need to assign a value to it, like 0. Hi Yang, I didn't see where it was used without initialized. Can you point that out to me? Thanks. > > Signed-off-by: YANG LI > Reported-by: Abaci > --- >

[PATCH] isci: style: remove the unneeded variable: "status".

2020-12-29 Thread YANG LI
The variable 'status' is being initialized with SCI_SUCCESS and never update later with a new value. The initialization is redundant and can be removed. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/scsi/isci/request.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH] fs: fix: second lock in function d_prune_aliases().

2020-12-29 Thread YANG LI
Goto statement jumping will cause lock to be executed again without executing unlock, placing the lock statement in front of goto label to fix this problem. Signed-off-by: YANG LI Reported-by: Abaci --- fs/dcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dcache.c

Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()

2020-12-29 Thread Borislav Petkov
On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > check_iommu_entries() checks for cyclic dependency in iommu entries > and fixes the cyclic dependency by setting x->depend to NULL. But > this repairing isn't correct if q is in front of p, there will be > "EXECUTION ORDER INVALID!"

[PATCH] mm: fix: Uninitialized variable ret.

2020-12-29 Thread YANG LI
The ret is being used but it isn't being initialized, need to assign a value to it, like 0. Signed-off-by: YANG LI Reported-by: Abaci --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 605f671..15ba17d 100644 ---

[PATCH] Bluetooth: btusb: Add a Kconfig option to disable USB wakeup by default

2020-12-29 Thread max.chou
From: Max Chou For the original commit of 9e45524a011107a73bc2cdde8370c61e82e93a4d, wakeup is always disabled for Realtek Bluetooth devices. However, there's the capability for Realtek Bluetooth devices to apply USB wakeup. Otherwise, there's the better power consumption without USB wakeup

Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures

2020-12-29 Thread Vidya Sagar
Ideally Bjorn's patch should have worked. Could you please collect 'sudo lspci -vv' (please don't forget to give sudo) with Bjorn's patch before and after hibernate? Also, is it right to say that with policy set to "performance" there is no issue during hibernate/resume? - Vidya Sagar On

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2020-12-29 Thread Xin Ji
On Tue, Dec 29, 2020 at 04:34:20PM +0200, Laurent Pinchart wrote: > Hi Xin Ji, > > On Tue, Dec 29, 2020 at 02:50:48PM +0800, Xin Ji wrote: > > On Mon, Dec 28, 2020 at 05:08:56PM +0200, Laurent Pinchart wrote: > > > On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > > > > Add DPI flag for

Re: [PATCH 12/21] vhost-vdpa: introduce uAPI to get the number of virtqueue groups

2020-12-29 Thread Jason Wang
On 2020/12/29 下午8:24, Eli Cohen wrote: On Wed, Dec 16, 2020 at 02:48:09PM +0800, Jason Wang wrote: Follows the vDPA support for multiple address spaces, this patch introduce uAPI for the userspace to know the number of virtqueue groups supported by the vDPA device. Can you explain what

Re: [PATCH] liquidio: fix: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'.

2020-12-29 Thread Joe Perches
On Wed, 2020-12-30 at 14:41 +0800, YANG LI wrote: > For safety, modify '%u' to '%d' to keep the type consistent. There is no additional safety here. The for loop ensures that i is positive as num_ioq_vector is also int and so i can not be negative as it's incremented from 0. > diff --git

[PATCH] 9p: fix: Uninitialized variable p.

2020-12-29 Thread YANG LI
The pointer p is being used but it isn't being initialized, need to assign a NULL to it. Signed-off-by: YANG LI Reported-by: Abaci --- net/9p/trans_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 93f2f86..d4d635f

[PATCH] liquidio: fix: warning: %u in format string (no. 3) requires 'unsigned int' but the argument type is 'signed int'.

2020-12-29 Thread YANG LI
For safety, modify '%u' to '%d' to keep the type consistent. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c

[PATCH] misc: rtsx: remove unused function

2020-12-29 Thread ricky_wu
From: Ricky Wu removed unused function 'rtsx_pci_disable_aspm' Signed-off-by: Ricky Wu --- drivers/misc/cardreader/rtsx_pcr.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/misc/cardreader/rtsx_pcr.c b/drivers/misc/cardreader/rtsx_pcr.c index 2aa6648fa41f..d782754fa346

[PATCH] xen: fix: use WARN_ON instead of if condition followed by BUG.

2020-12-29 Thread YANG LI
Use WARN_ON instead of if condition followed by BUG in gnttab_batch_map() and gnttab_batch_copy(). This issue was detected with the help of coccicheck. Signed-off-by: YANG LI Reported-by: Abaci --- drivers/xen/grant-table.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH] cifs: style: replace one-element array with flexible-array

2020-12-29 Thread YANG LI
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1]

Re: [PATCH 11/21] vhost-vdpa: introduce asid based IOTLB

2020-12-29 Thread Jason Wang
On 2020/12/29 下午7:53, Eli Cohen wrote: + +static struct vhost_vdpa_as *vhost_vdpa_alloc_as(struct vhost_vdpa *v, u32 asid) +{ + struct hlist_head *head = >as[asid % VHOST_VDPA_IOTLB_BUCKETS]; + struct vhost_vdpa_as *as; + + if (asid_to_as(v, asid)) + return

Re: [PATCH 11/21] vhost-vdpa: introduce asid based IOTLB

2020-12-29 Thread Jason Wang
On 2020/12/29 下午8:05, Eli Cohen wrote: + +static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid) The return value is never interpreted. I think it should either be made void or return values checked. Right, will make it void. +{ + struct vhost_vdpa_as *as =

Re: [PATCH] io_uring: style: redundant NULL check.

2020-12-29 Thread Randy Dunlap
On 12/29/20 10:22 PM, YANG LI wrote: > If the pointer in kfree is empty, the function does nothing, > so remove the redundant NULL check. > > Signed-off-by: YANG LI > Reported-by: Abaci > --- Looks like you should do something with these 2 comments: /* it's reportedly faster than

[PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support

2020-12-29 Thread vijayakannan . ayyathurai
From: Vijayakannan Ayyathurai Add generic clocksource and clockevent driver for the timer IP used in Intel Keem Bay SoC. One free running Counter used as a clocksource device and one Timer used as a clockevent device. Both are enabled through TIM_GEN_CONFIG register. This register is in the DT

[PATCH v2 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC timer

2020-12-29 Thread vijayakannan . ayyathurai
From: Vijayakannan Ayyathurai Add Device Tree bindings for the Timer IP, which used as clocksource and clockevent device in the Intel Keem Bay SoC. Acked-by: Mark Gross Acked-by: Andy Shevchenko Signed-off-by: Vijayakannan Ayyathurai --- .../bindings/timer/intel,keembay-timer.yaml | 52

[PATCH v2 0/2] Add drivers for Intel Keem Bay SoC timer block

2020-12-29 Thread vijayakannan . ayyathurai
From: Vijayakannan Ayyathurai Hi, This patch set adds the driver for Intel Keem Bay SoC timer block, which contains 32-bit general purpose timers, a 64 bit free running counter. Patch 1 holds the Device Tree binding documentation and Patch 2 holds the Device Driver for clocksource and

[PATCH] mlx4: style: replace zero-length array with flexible-array member.

2020-12-29 Thread YANG LI
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members"[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1]

Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2020-12-29 Thread Joe Perches
On Wed, 2020-12-30 at 14:07 +0800, YANG LI wrote: > The warning was because of the following line in function > liquidio_set_fec(): > > retval = wait_for_sc_completion_timeout(oct, sc, 0); > if (retval) > return (-EIO); I presume abaci is a robot Perhaps also the robot could look for

Re: [PATCH 11/21] vhost-vdpa: introduce asid based IOTLB

2020-12-29 Thread Jason Wang
On 2020/12/29 下午7:41, Eli Cohen wrote: On Wed, Dec 16, 2020 at 02:48:08PM +0800, Jason Wang wrote: This patch converts the vhost-vDPA device to support multiple IOTLBs tagged via ASID via hlist. This will be used for supporting multiple address spaces in the following patches. Signed-off-by:

[PATCH] io_uring: style: redundant NULL check.

2020-12-29 Thread YANG LI
If the pointer in kfree is empty, the function does nothing, so remove the redundant NULL check. Signed-off-by: YANG LI Reported-by: Abaci --- fs/io_uring.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 7e35283..105e188

Review request 0/2: init/main.c: sink the kernel_init to the bottom

2020-12-29 Thread Liu Peibao
It looks better that sinking the kernel_init() to bottom. And such the statement of kernel_init_freeable() is redundant. Also there is a warning found by the checkpatch.pl.

[PATCH 2/2] init/main.c: sink the kernel_init to the bottom

2020-12-29 Thread Liu Peibao
Remove the redundant kernel_init_freeable statement. Signed-off-by: Liu Peibao --- init/main.c | 132 ++-- 1 file changed, 65 insertions(+), 67 deletions(-) diff --git a/init/main.c b/init/main.c index 1e492de770c8..d5c2fa85ee54 100644 ---

[PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2020-12-29 Thread YANG LI
The warning was because of the following line in function liquidio_get_fec(): retval = wait_for_sc_completion_timeout(oct, sc, 0); if (retval) return retval; If this statement is not true, retval must be 0 and not updated later. So, It is better to return 0 directly. Signed-off-by:

ERROR: modpost: ".__warn_printk" undefined!

2020-12-29 Thread kernel test robot
Hi Christoph, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 139711f033f636cc78b6aaf7363252241b9698ef commit: a7b75c5a8c41445f33efb663887ff5f5c3b4454b net: pass a sockptr_t into ->setsockopt date: 5 months ago

[PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2020-12-29 Thread YANG LI
The warning was because of the following line in function liquidio_set_fec(): retval = wait_for_sc_completion_timeout(oct, sc, 0); if (retval) return (-EIO); If this statement is not true, retval must be 0 and not updated later. So, It is better to return 0 directly. Signed-off-by:

[PATCH 1/2] init/main.c: fix strings split across lines

2020-12-29 Thread Liu Peibao
Fix warning found by checkpatch.pl. Signed-off-by: Liu Peibao --- init/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/init/main.c b/init/main.c index 6feee7f11eaf..1e492de770c8 100644 --- a/init/main.c +++ b/init/main.c @@ -1470,8 +1470,7 @@ static int __ref

[PATCH] initramfs: fix "Decoding failed"

2020-12-29 Thread Hongfei Shang
From: Hongfei Shang when initrd image file load in memory, it is align to 4 bytes, so there are may be some padding bytes(<4), should ignore these padding bytes and handle as normal end before: (when size of initrd.img is: size%4 = 1, 2 or 3) "Initramfs unpacking failed: Decoding failed"

Re: [PATCH] checkpatch: ignore warning designated initializers using NR_CPUS

2020-12-29 Thread Joe Perches
On Wed, 2020-12-30 at 12:13 +0800, Peng Wang wrote: > Some max_length wants to hold as large room as possible to > ensure enough size to tackle with the biggest NR_CPUS. As > an example below: > > kernel/cgroup/cpuset.c: > static struct cftype legacy_files[] = { > { >

Re: [PATCH] RDMA/ocrdma: fix use after free in ocrdma_dealloc_ucontext_pd()

2020-12-29 Thread Leon Romanovsky
On Tue, Dec 29, 2020 at 06:46:53PM -0800, t...@redhat.com wrote: > From: Tom Rix > > In ocrdma_dealloc_ucontext_pd() uctx->cntxt_pd is assigned to > the variable pd and then after uctx->cntxt_pd is freed, the > variable pd is passed to function _ocrdma_dealloc_pd() which > dereferences pd

Re: [PATCH v2 11/48] opp: Add dev_pm_opp_find_level_ceil()

2020-12-29 Thread Viresh Kumar
On 28-12-20, 17:03, Dmitry Osipenko wrote: > 28.12.2020 09:22, Viresh Kumar пишет: > > On 24-12-20, 16:00, Dmitry Osipenko wrote: > >> In a device driver I want to set PD to the lowest performance state by > >> removing the performance vote when dev_pm_opp_set_rate(dev, 0) is > >> invoked by the

[PATCH] mailbox: arm_mhuv2: Fix sparse warnings

2020-12-29 Thread Viresh Kumar
This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2 driver. drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 (different address spaces) drivers/mailbox/arm_mhuv2.c:506:24:expected void const volatile [noderef] __iomem *addr

Re: [PATCH 10/21] vhost: support ASID in IOTLB API

2020-12-29 Thread Jason Wang
On 2020/12/29 下午6:20, Eli Cohen wrote: -static int vhost_process_iotlb_msg(struct vhost_dev *dev, +static int vhost_process_iotlb_msg(struct vhost_dev *dev, u16 asid, struct vhost_iotlb_msg *msg) { int ret = 0; + if (asid != 0) +

Registering IRQ for MT7530 internal PHYs

2020-12-29 Thread DENG Qingfang
Hi, I added MT7530 IRQ support and registered its internal PHYs to IRQ. It works but my patch used two hacks. 1. Removed phy_drv_supports_irq check, because config_intr and handle_interrupt are not set for Generic PHY. 2. Allocated ds->slave_mii_bus before calling ds->ops->setup, because we

[PATCH] checkpatch: ignore warning designated initializers using NR_CPUS

2020-12-29 Thread Peng Wang
Some max_length wants to hold as large room as possible to ensure enough size to tackle with the biggest NR_CPUS. As an example below: kernel/cgroup/cpuset.c: static struct cftype legacy_files[] = { { .name = "cpus", .seq_show = cpuset_common_seq_show,

Re: [PATCH 07/21] vdpa: multiple address spaces support

2020-12-29 Thread Jason Wang
On 2020/12/29 下午3:28, Eli Cohen wrote: @@ -43,6 +43,8 @@ struct vdpa_vq_state { * @index: device index * @features_valid: were features initialized? for legacy guests * @nvqs: the number of virtqueues + * @ngroups: the number of virtqueue groups + * @nas: the number of address spaces

Re: [PATCH 07/21] vdpa: multiple address spaces support

2020-12-29 Thread Jason Wang
On 2020/12/29 下午3:28, Eli Cohen wrote: @@ -43,6 +43,8 @@ struct vdpa_vq_state { * @index: device index * @features_valid: were features initialized? for legacy guests * @nvqs: the number of virtqueues + * @ngroups: the number of virtqueue groups + * @nas: the number of address spaces

WARNING in cm109_urb_irq_callback/usb_submit_urb

2020-12-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5814bc2d Merge tag 'perf-tools-2020-12-24' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12f074db50 kernel config: https://syzkaller.appspot.com/x/.config?x=bf519e1e96191576

[PATCH v3] MIPS: zboot: head.S clean up

2020-12-29 Thread Jiaxun Yang
.cprestore is removed as we don't expect Position Independent zboot ELF. .noreorder is also removed and rest instructions are massaged to improve readability. t9 register is used for indirect jump as MIPS ABI requirement. start label is removed as it already defined in LEAF. Reported-by: Paul

Re: [PATCH v2] MIPS: zboot: head.S clean up

2020-12-29 Thread Jiaxun Yang
在 2020/12/30 上午11:08, Jiaxun Yang 写道: .cprestore is removed as we don't expect Position Independent zboot ELF. .noreorder is also removed and rest instructions are massaged to improve readability. t9 register is used for indirect jump as MIPS ABI requirement. start label is removed as it

[PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR.

2020-12-29 Thread Yi Li
1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. 2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR. and go to call iput properly. Signed-off-by: Yi Li --- fs/ext4/fast_commit.c | 23 --- 1 file changed, 12

[PATCH 2/2] MIPS: Loongson64: Set cluster for cores

2020-12-29 Thread Jiaxun Yang
cluster is required for cacheinfo to set shared_cpu_map correctly. Signed-off-by: Jiaxun Yang Reviewed-by: Tiezhu Yang Tested-by: Tiezhu Yang --- arch/mips/loongson64/smp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c index

[PATCH RESEND 1/2] MIPS: cacheinfo: Add missing VCache

2020-12-29 Thread Jiaxun Yang
Victim Cache is defined by Loongson as per-core unified private Cache. Add this into cacheinfo and make cache levels selfincrement instead of hardcode levels. Signed-off-by: Jiaxun Yang Reviewed-by: Tiezhu Yang Tested-by: Tiezhu Yang --- arch/mips/kernel/cacheinfo.c | 34

Re: [PATCH v2 -next] staging: greybus: light: Use kzalloc for allocating only one thing

2020-12-29 Thread Alex Elder
On 12/29/20 7:37 PM, Zheng Yongjun wrote: Use kzalloc rather than kcalloc(1,...) The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ @@ - kcalloc(1, + kzalloc( ...) // Signed-off-by: Zheng Yongjun Looks good. Reviewed-by: Alex Elder

Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2020-12-29 Thread Chen-Yu Tsai
On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec wrote: > > Hi! > > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a): > > This adds a device-tree definition for the CSI0 MCLK pin, > > which can be used for feeding MIPI CSI-2 sensors. > > > > Signed-off-by: Paul

[PATCH 1/3] MIPS: Add vulnerabilities infrastructure

2020-12-29 Thread Jiaxun Yang
Add infrastructure to display CPU vulnerabilities. As most MIPS CPU vendors are dead today and we can't confirm vulnerabilities states with them, we'll display vulnerabilities as "Unknown" by default and override them in cpu-probe.c Signed-off-by: Jiaxun Yang --- arch/mips/Kconfig

[PATCH 3/3] MIPS: cpu-probe: Vulnerabilities for Loongson cores

2020-12-29 Thread Jiaxun Yang
Loongson64C is known to be vulnerable to meltdown according to PoC from Rui Wang . Loongson64G defended these side-channel attack by silicon. Signed-off-by: Jiaxun Yang --- arch/mips/kernel/cpu-probe.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/mips/kernel/cpu-probe.c

[PATCH 2/3] MIPS: cpu-probe: Vulnerabilities for MIPS cores

2020-12-29 Thread Jiaxun Yang
Accorading to MIPS's announcement[1], only P5600 and P6600 is affected by spectre v1 and v2, other cores are not affected. So we mark vulnerabilities states for MIPS cores as known and set P5600 and P6600 as vulnerable. [1]:

[PATCH] tty: serial: amba-pl011: added RS485 support [v3]

2020-12-29 Thread Ivan Sistik
AMBA PL011 do not have hardware support for RS485. This implementation is for drive enable signal (DE), which switch direction of RS485 driver chip. This signal si drived by RTS pin. Correct multiplexor settings have to be provided to Device Tree. Usually it is 'ctsrts', which is used for enabling

[PATCH v2] MIPS: zboot: head.S clean up

2020-12-29 Thread Jiaxun Yang
.cprestore is removed as we don't expect Position Independent zboot ELF. .noreorder is also removed and rest instructions are massaged to improve readability. t9 register is used for indirect jump as MIPS ABI requirement. start label is removed as it already defined in LEAF. Reported-by: Paul

Re: [PATCH v4 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-29 Thread Xu Yilun
On Tue, Dec 29, 2020 at 06:37:37AM -0800, Tom Rix wrote: > > On 12/28/20 6:42 PM, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver leverages the uio_pdrv_genirq, it adds the

[PATCH] RDMA/ocrdma: fix use after free in ocrdma_dealloc_ucontext_pd()

2020-12-29 Thread trix
From: Tom Rix In ocrdma_dealloc_ucontext_pd() uctx->cntxt_pd is assigned to the variable pd and then after uctx->cntxt_pd is freed, the variable pd is passed to function _ocrdma_dealloc_pd() which dereferences pd directly or through its call to ocrdma_mbx_dealloc_pd(). Reorder the free using

RE: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node

2020-12-29 Thread Peng Fan
> Subject: Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node > > On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote: > > On Tue, Dec 29, 2020 at 6:15 AM wrote: > > > > > > From: Peng Fan > > > > > > According to RM, there is a spba bus inside aips3 and aips1, add it. > > > > > >

Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-29 Thread Nicholas Piggin
Excerpts from Russell King - ARM Linux admin's message of December 29, 2020 8:44 pm: > On Tue, Dec 29, 2020 at 01:09:12PM +1000, Nicholas Piggin wrote: >> I think it should certainly be documented in terms of what guarantees >> it provides to application, _not_ the kinds of instructions it may or

RE: [PATCH 3/4] arm64: dts: imx8mn: add spba bus node

2020-12-29 Thread Peng Fan
> Subject: Re: [PATCH 3/4] arm64: dts: imx8mn: add spba bus node > > On Tue, Dec 29, 2020 at 08:00:44PM +0800, peng@nxp.com wrote: > > From: Peng Fan > > > > According to RM, there is a spba bus inside aips3 and aips1, add it. > > This does not look like matching contents of commit. Posted

[PATCH] irqchip/gic: remove a if in gic_of_setup()

2020-12-29 Thread Yejune Deng
There is two function gic_of_init() and gic_of_init_child() called gic_of_setup(),both gic and node never fail,so remove if (!gic || !node) is safe. Signed-off-by: Yejune Deng --- drivers/irqchip/irq-gic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/irqchip/irq-gic.c

Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

2020-12-29 Thread Xu Yilun
On Tue, Dec 29, 2020 at 01:13:08PM +, Mark Brown wrote: > On Tue, Dec 29, 2020 at 01:27:42PM +0800, Xu Yilun wrote: > > The xfer waiting time is the result of xfer->len / xfer->speed_hz, but > > when the following patch is merged, > > > > commit 9326e4f1e5dd ("spi: Limit the spi device max

Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

2020-12-29 Thread Jakub Kicinski
On Tue, 29 Dec 2020 17:52:56 -0800 Cong Wang wrote: > On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski wrote: > > > > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:78cbac647e61 Merge branch > > >

Re: [PATCH] irqchip/gic: add WARN_ON() to facilitate backtracking

2020-12-29 Thread Yejune Deng
OK,I will adopt it and resubmit. On Tue, Dec 29, 2020 at 5:27 PM Marc Zyngier wrote: > > Yejune, > > On 2020-12-29 07:15, Yejune Deng wrote: > > There is two function gic_of_init() and gic_of_init_child() called > > gic_of_setup(),so add WARN_ON() to facilitate backtracking. > > > >

linux-next: stats (Was: Linux 5.11-rc1)

2020-12-29 Thread Stephen Rothwell
Hi all, As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20201214 was the first linux-next after the merge window opened.) Commits in v5.11-rc1 (relative to v5.10): 12498 Commits in next-20201214:

Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

2020-12-29 Thread Cong Wang
On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski wrote: > > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments' > > git tree: net-next > > console output:

[PATCH v2 net-next] net: kcm: Replace fput with sockfd_put

2020-12-29 Thread Zheng Yongjun
The function sockfd_lookup uses fget on the value that is stored in the file field of the returned structure, so fput should ultimately be applied to this value. This can be done directly, but it seems better to use the specific macro sockfd_put, which does the same thing. The refactoring

Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

2020-12-29 Thread Jakub Kicinski
On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14df482840 > kernel

[PATCH v2 -next] staging: greybus: light: Use kzalloc for allocating only one thing

2020-12-29 Thread Zheng Yongjun
Use kzalloc rather than kcalloc(1,...) The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ @@ - kcalloc(1, + kzalloc( ...) // Signed-off-by: Zheng Yongjun --- drivers/staging/greybus/light.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 5/5] ARM: dts: meson: add the AO ARC remote processor

2020-12-29 Thread Martin Blumenstingl
The 32-bit Amlogic Meson SoCs embed an ARC processor in the Always-On power domain which is typically used for managing system suspend. The memory for this ARC core is taken from the AHB SRAM area. Depending on the actual SoC a different ARC core is used: - Meson6 and earlier: some ARCv1 ISA based

[PATCH 0/5] Amlogic Meson Always-On ARC remote-processor support

2020-12-29 Thread Martin Blumenstingl
EM4 to the Zephyr RTOS. The code can be found here: [0] (the resulting zephyr.elf can then be loaded as remote-processor firmware from Linux). [0] https://github.com/xdarklight/zephyr-rtos/commits/amlogic_ao_em4-20201229 Martin Blumenstingl (5): dt-bindings: sram: Add compatible strings

[PATCH 2/5] dt-bindings: Amlogic: add the documentation for the SECBUS2 registers

2020-12-29 Thread Martin Blumenstingl
The Meson8/Meson8b/Meson8m2 SoCs have a register bank called SECBUS2 which contains registers for various IP blocks such as pin-controller bits for the BSD_EN and TEST_N GPIOs as well as some AO ARC core control bits. The registers can be accessed directly when not running in "secure mode". When

[PATCH 1/5] dt-bindings: sram: Add compatible strings for the Meson AO ARC SRAM

2020-12-29 Thread Martin Blumenstingl
Amlogic Meson8, Meson8b and Meson8m2 SoCs embed an ARC EM4 core typically used for managing system suspend. A section of the SoCs SRAM is mapped as memory for this ARC core. Add new compatible strings for the SRAM section for the ARC core memory. Signed-off-by: Martin Blumenstingl ---

[PATCH 4/5] remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor

2020-12-29 Thread Martin Blumenstingl
Amlogic Meson6, Meson8, Meson8b and Meson8m2 embed an ARC core in the Always-On (AO) power-domain. This is typically used for waking up the ARM cores after system suspend. The configuration is spread across three different registers: - AO_REMAP_REG0 which must be programmed to zero, it's actual

[PATCH 3/5] dt-bindings: remoteproc: Add the documentation for Meson AO ARC rproc

2020-12-29 Thread Martin Blumenstingl
Amlogic Meson6, Meson8, Meson8b and Meson8m2 SoCs embed an ARC EM4 controller for always-on operations, typically used for managing system suspend. Signed-off-by: Martin Blumenstingl --- .../remoteproc/amlogic,meson-mx-ao-arc.yaml | 87 +++ 1 file changed, 87 insertions(+)

[ANNOUNCE] 4.9.249-rt164

2020-12-29 Thread Luis Claudio R. Goncalves
Hello RT-list! I'm pleased to announce the 4.9.249-rt164 stable release. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.9-rt Head SHA1: cd8267a1050e4380c4325a5384de42f4412bfc2b Or to build 4.9.249-rt164

Re: [PATCH] MIPS: Loongson64: Give chance to build under !CONFIG_NUMA and !CONFIG_SMP

2020-12-29 Thread Tiezhu Yang
On 12/30/2020 12:39 AM, Thomas Bogendoerfer wrote: On Wed, Dec 16, 2020 at 10:44:23AM +0800, Tiezhu Yang wrote: I have tested the following three configs on the Loongson platform: (1) !NUMA and !SMP, (2) !NUMA and SMP, (3) NUMA and SMP, everything is all right. But there exists the following

[PATCH 1/6] block: manage bio slab cache by xarray

2020-12-29 Thread Ming Lei
Managing bio slab cache via xarray by using slab cache size as xarray index, and storing 'struct bio_slab' instance into xarray. So code is simplified a lot, meantime is is more readable than before. Signed-off-by: Ming Lei --- block/bio.c | 104

[PATCH 5/6] block: move three bvec helpers declaration into private helper

2020-12-29 Thread Ming Lei
bvec_alloc(), bvec_free() and bvec_nr_vecs() are only used inside block layer core functions, no need to declare them in public header. Signed-off-by: Ming Lei --- block/blk.h | 4 include/linux/bio.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set'

2020-12-29 Thread Ming Lei
This bioset is just for allocating bio only from bio_next_split, and it needn't bvecs, so remove the flag. Cc: linux-bca...@vger.kernel.org Cc: Coly Li Signed-off-by: Ming Lei --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/6] block: set .bi_max_vecs as actual allocated vector number

2020-12-29 Thread Ming Lei
bvec_alloc() may allocate more bio vectors than requested, so set .bi_max_vecs as actual allocated vector number, instead of the requested number. This way can help fs build bigger bio because new bio often won't be allocated until the current one becomes full. Signed-off-by: Ming Lei ---

[PATCH 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split

2020-12-29 Thread Ming Lei
q->bio_split is only used by bio_split() for fast cloning bio, and no need to allocate bvecs, so remove this flag. Signed-off-by: Ming Lei --- block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index

[PATCH 0/6] block: improvement on bioset & bvec allocation

2020-12-29 Thread Ming Lei
Hello, All are bioset / bvec improvement, and most of them are quite straightforward. Ming Lei (6): block: manage bio slab cache by xarray block: don't pass BIOSET_NEED_BVECS for q->bio_split block: don't allocate inline bvecs if this bioset needn't bvecs block: set .bi_max_vecs as

[PATCH 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs

2020-12-29 Thread Ming Lei
The inline bvecs won't be used if user needn't bvecs by not passing BIOSET_NEED_BVECS, so don't allocate bvecs in this situation. Signed-off-by: Ming Lei --- block/bio.c | 11 +++ include/linux/bio.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v3 0/5] dwmac-meson8b: picosecond precision RX delay support

2020-12-29 Thread Martin Blumenstingl
Hi Jakub, On Mon, Dec 28, 2020 at 9:37 PM Jakub Kicinski wrote: > > On Thu, 24 Dec 2020 00:29:00 +0100 Martin Blumenstingl wrote: > > Hello, > > > > with the help of Jianxin Pan (many thanks!) the meaning of the "new" > > PRG_ETH1[19:16] register bits on Amlogic Meson G12A, G12B and SM1 SoCs > >

[PATCH] fs/buffer: try to submit writeback bio in unit of page

2020-12-29 Thread Ming Lei
It is observed that __block_write_full_page() always submit bio with size of block size, which is often 512 bytes. In case of sequential IO, or >=4k BS random/seq writeback IO, most of times IO represented by all buffer_head in each page can be done in single bio. It is actually done in single

[PATCH] xfs: Wake CIL push waiters more reliably

2020-12-29 Thread Donald Buczek
Threads, which committed items to the CIL, wait in the xc_push_wait waitqueue when used_space in the push context goes over a limit. These threads need to be woken when the CIL is pushed. The CIL push worker tries to avoid the overhead of calling wake_all() when there are no waiters waiting. It

Re: [PATCH] block: add debugfs stanza for QUEUE_FLAG_NOWAIT.

2020-12-29 Thread Jens Axboe
On 12/28/20 12:27 PM, Andres Freund wrote: > This was missed in 021a24460dc2. Leads to the numeric value of > QUEUE_FLAG_NOWAIT (i.e. 29) showing up in > /sys/kernel/debug/block/*/state. Applied, thanks. -- Jens Axboe

Re: [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes

2020-12-29 Thread Jens Axboe
On 12/28/20 8:47 PM, Randy Dunlap wrote: > Fix new kernel-doc warnings in fs/block_dev.c: > > ../fs/block_dev.c:1066: warning: Excess function parameter 'whole' > description in 'bd_abort_claiming' > ../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not > described in

Re: [PATCH -next] aoe: Use kzalloc for allocating only one thing

2020-12-29 Thread Jens Axboe
On 12/29/20 6:51 AM, Zheng Yongjun wrote: > Use kzalloc rather than kcalloc(1,...) > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > @@ > > - kcalloc(1, > + kzalloc( > ...) > // Should probably fix up that missing set of ()

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-29 Thread Qais Yousef
Hi Jiri On 12/29/20 18:34, Jiri Olsa wrote: > On Tue, Dec 29, 2020 at 03:13:52PM +, Qais Yousef wrote: > > Hi > > > > When I enable CONFIG_DEBUG_INFO_BTF I get the following error in the BTFIDS > > stage > > > > FAILED unresolved symbol udp6_sock > > > > I cross compile for arm64. My

  1   2   3   4   5   >