Re: [PATCH V10 01/10] dt-bindings: remoteproc: convert imx rproc bindings to json-schema

2021-02-17 Thread Rob Herring
On Mon, 15 Feb 2021 20:34:14 +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Convert the imx rproc binding to DT schema format using json-schema. > > Signed-off-by: Peng Fan > --- > .../bindings/remoteproc/fsl,imx-rproc.yaml| 60 +++ >

Re: [PATCH V0 1/6] dt-bindings: Added the yaml bindings for DCC

2021-02-17 Thread Rob Herring
On Wed, 17 Feb 2021 12:18:22 +0530, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. > > Signed-off-by: Souradeep Chowdhury > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 49 > ++ > 1 file

Re: [PATCH v3 RESEND] Added AMS tsl2591 driver implementation

2021-02-17 Thread Rob Herring
On Sat, 13 Feb 2021 13:22:41 +, Joe Sandom wrote: > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light, raw visible light, > raw combined light and combined lux value. >

Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

2021-02-17 Thread Dmitry Torokhov
Hi Ronald, On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote: > @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data > *applespi) > return sts; > } > > - applespi->cmd_msg_queued = true; > + applespi->cmd_msg_queued = ktime_get();

Re: [PATCH v1 07/18] media: hantro: Add a field to distinguish the hardware versions

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Decoders hardware blocks could exist in multiple versions: add > a field to distinguish them at runtime. > Keep the default behavoir to be G1 hardware. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia >

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-17 Thread Rob Clark
On Wed, Feb 17, 2021 at 11:08 AM Jordan Crouse wrote: > > On Wed, Feb 17, 2021 at 07:14:16PM +0530, Akhil P Oommen wrote: > > On 2/17/2021 8:36 AM, Rob Clark wrote: > > >On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: > > >> > > >>Ignore nvmem_cell_get() EOPNOTSUPP error in the same way

Re: [PATCH v1 15/18] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2 > of the driver. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  

Re: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. > If codec_ops is not set for a codec variant, things will go south really fast. See hantro_start_streaming for instance. I think you can just drop this patch.

[RELEASE] Userspace RCU 0.11.3 and 0.12.2

2021-02-17 Thread Mathieu Desnoyers
Hi, This is a bugfix release announcement for the Userspace RCU library (liburcu) for its two currently maintained branches. liburcu is a LGPLv2.1 userspace RCU (read-copy-update) library. This data synchronization library provides read-side access which scales linearly with the number of cores.

Re: [PATCH][next] HID: playstation: fix array size comparison (off-by-one)

2021-02-17 Thread Benjamin Tissoires
On Mon, Feb 15, 2021 at 5:39 PM Colin King wrote: > > From: Colin Ian King > > The comparison of value with the array size ps_gamepad_hat_mapping > appears to be off-by-one. Fix this by using >= rather than > for the > size comparison. > > Addresses-Coverity: ("Out-of-bounds read") > Fixes:

[PATCH] pstore: remove redundant initialization of variable zipped_len

2021-02-17 Thread Colin King
From: Colin Ian King The variable zipped_len is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Clean up the code and move the scope of zipped_len. Addresses-Coverity: ("Unused value")

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-17 Thread Marc Zyngier
On 2021-02-17 19:57, Michael Walle wrote: Hi Greg, There's no need to keep around a dentry pointer to a simple file that debugfs itself can look up when we need to remove it from the system. So simplify the code by deleting the variable and cleaning up the logic around the debugfs file.

Re: [PATCH v1 05/18] media: controls: Add control for HEVC codec

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add HEVC decode params and scaling matrix controls. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/media/v4l2-core/v4l2-ctrls.c | 36

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-17 Thread Michael Walle
llowing oops on my board (arm64, freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup() debugfs_mount is NULL. [0.00] Linux version 5.11.0-next-20210217-00014-g41e0e92a2d05 (mwalle@mwalle01) (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0, GNU ld (GNU Binutils for Debian) 2.3

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-17 Thread Jiri Olsa
On Wed, Feb 10, 2021 at 02:17:25PM -0500, Nicholas Fraser wrote: > lsdir_bid_tail_filter() ignored any build-id that wasn't exactly 20 > bytes. This worked only for SHA-1 build-ids. The build-id for a PE file > is always a 16-byte GUID and ELF files can also have MD5 or UUID > build-ids. > > This

Re: [PATCH v1 04/18] media: hevc: add structures for hevc codec

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, Thanks a lot for picking this up. On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Define additional structures to be used by HEVC codecs. > This will allow to provide the needed information to the > hardware block. > Adapt Cedrus driver to use these new structures >

Re: [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id

2021-02-17 Thread Jiri Olsa
On Tue, Feb 16, 2021 at 04:06:44PM -0500, Nicholas Fraser wrote: > tests/shell/buildid.sh added an ELF executable with an MD5 build-id to > the perf debug cache but did not check whether the object was printed > by a subsequent call to "perf buildid-cache -l". It was being omitted > from the list.

[PATCH] drivers/base/cpu: remove redundant initialization of variable retval

2021-02-17 Thread Colin King
From: Colin Ian King The variable retval is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/base/cpu.c | 2 +-

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-17 Thread Scott Branden
Hi Greg, On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: > On Tue, Jan 26, 2021 at 07:51:18PM +0100, Greg Kroah-Hartman wrote: >> On Tue, Jan 26, 2021 at 10:30:16AM -0800, Scott Branden wrote: >>> Hi Greg, >>> >>> >>> On 2021-01-25 11:29 p.m., Greg Kroah-Hartman wrote: On Mon, Jan 25,

Re: [RFC PATCH 4/5] hugetlb: don't permit pmd sharing if soft dirty in use

2021-02-17 Thread Peter Xu
On Wed, Feb 10, 2021 at 04:03:21PM -0800, Mike Kravetz wrote: > If page modifications are being monitoried with the soft dirty mechanism, > then this information is contained in page table entries. Tracking is > enabled on a 'per-process' basis. hugetlb pmd sharing allows processes > to share

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Si-Wei Liu
On 2/16/2021 8:20 AM, Eli Cohen wrote: When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used indices resulting in hardware virqtqueue objects becoming out of sync. We can avoid this function alltogether

Re: [PATCH] of: property: fw_devlink: Ignore interrupts property for some configs

2021-02-17 Thread Rob Herring
On Mon, Feb 15, 2021 at 4:43 PM Saravana Kannan wrote: > > When CONFIG_OF_IRQ is not defined, it doesn't make sense to parse > interrupts property. > > Also, parsing and tracking interrupts property breaks some PPC > devices[1]. But none of the IRQ drivers in PPC seem ready to be > converted to

Re: [PATCH v3 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation

2021-02-17 Thread Vivek Goyal
On Wed, Feb 17, 2021 at 02:26:53PM -0500, Steven Rostedt wrote: > On Wed, 17 Feb 2021 12:40:43 -0600 > john.p.donne...@oracle.com wrote: > > > Hello. > > > > Ping. > > > > Can we get this reviewed and staged ? > > > > Thank you. > > Andrew, > > Seems you are the only one pushing patches in

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Sebastian Andrzej Siewior
On 2021-02-17 11:19:07 [-0800], Paul E. McKenney wrote: > > Ah. One nice thing is that you can move the RCU threads to a house > > keeping CPU - away from the CPU(s) running the RT tasks. Would this > > scenario be still affected (if ksoftirqd would be blocked)? > > At this point, I am going to

Re: [PATCH v1 03/18] arm64: dts: imx8mq-evk: add reserve memory node for CMA region

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Define allocation range for the default CMA region. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia Despite it seems like I signed-off this one... > Signed-off-by: Adrian Ratiu > --- >  

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-17 Thread Mike Kravetz
On 2/17/21 11:02 AM, Andrew Morton wrote: > On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz > wrote: > >> page structs are not guaranteed to be contiguous for gigantic pages. The >> routine update_and_free_page can encounter a gigantic page, yet it assumes >> page structs are contiguous when

Re: [RFC PATCH 3/5] mm proc/task_mmu.c: add soft dirty pte checks for hugetlb

2021-02-17 Thread Peter Xu
On Wed, Feb 10, 2021 at 04:03:20PM -0800, Mike Kravetz wrote: > Pagemap was only using the vma flag PM_SOFT_DIRTY for hugetlb vmas. > This is insufficient. Check the individual pte entries. > > Signed-off-by: Mike Kravetz > --- > fs/proc/task_mmu.c | 4 > 1 file changed, 4 insertions(+) >

Re: [RFC PATCH 2/5] hugetlb: enhance hugetlb fault processing to support soft dirty

2021-02-17 Thread Peter Xu
On Wed, Feb 10, 2021 at 04:03:19PM -0800, Mike Kravetz wrote: > hugetlb fault processing code would COW all write faults where the > pte was not writable. Soft dirty will write protect ptes as part > of it's tracking mechanism. The existing hugetlb_cow code will do > the right thing for PRIVATE

Re: [PATCH v1 02/18] media: hantro: Define HEVC codec profiles and supported features

2021-02-17 Thread Ezequiel Garcia
Hello Benjamin, Thanks a lot for the patch. On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Define which HEVC profiles (up to level 5.1) and features > (no scaling, no 10 bits) are supported by the driver. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia >

Re: [PATCH v3 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation

2021-02-17 Thread Steven Rostedt
On Wed, 17 Feb 2021 12:40:43 -0600 john.p.donne...@oracle.com wrote: > Hello. > > Ping. > > Can we get this reviewed and staged ? > > Thank you. Andrew, Seems you are the only one pushing patches in for kexec/crash. Is this maintained by anyone? -- Steve

Re: [PATCH 5.10 098/104] switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT

2021-02-17 Thread Pavel Machek
Hi! > > > From: Horatiu Vultur > > > > > > commit 059d2a1004981dce19f0127dabc1b4ec927d202a upstream. > > > > > > Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to > > > notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere > > > else, therefore we can remove

drivers/mtd/nand/onenand/onenand_omap2.c:385:17: sparse: sparse: incorrect type in argument 2 (different address spaces)

2021-02-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f40ddce88593482919761f74910f42f4b84c004b commit: 421015713b306e47af95d4d61cdfbd96d462e4cb ARM: 9017/2: Enable KASan for ARM date: 4 months ago config: arm-randconfig-s032-20210218 (attached as .config)

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-17 Thread Jiri Olsa
On Tue, Feb 16, 2021 at 11:35:06AM -0500, Nicholas Fraser wrote: > No problem, I've added a call to "perf buildid-cache -l" in check() to make > sure the added IDs are reported. The MD5 test fails without the previous > patch to allow 16-byte build-ids. > > Do you also want PE files tested by

Re: [PATCH v2 05/11] drm/qxl: rename qxl_bo_kmap -> qxl_bo_vmap_locked

2021-02-17 Thread Thomas Zimmermann
Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Append _locked to Make clear that these functions should be called with reserved bo's only. While being at it also rename kmap -> vmap. No functional change. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann ---

Re: [PATCH v2 06/11] drm/qxl: add qxl_bo_vmap/qxl_bo_vunmap

2021-02-17 Thread Thomas Zimmermann
Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Add vmap/vunmap variants which reserve (and pin) the bo. They can be used in case the caller doesn't hold a reservation for the bo. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_object.h | 2 ++

Re: [PATCH v2 04/11] drm/qxl: fix lockdep issue in qxl_alloc_release_reserved

2021-02-17 Thread Thomas Zimmermann
Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Call qxl_bo_unpin (which does a reservation) without holding the release_mutex lock. Fixes lockdep (correctly) warning on a possible deadlock. Fixes: 65ffea3c6e73 ("drm/qxl: unpin release objects") Signed-off-by: Gerd Hoffmann Acked-by: Thomas

Re: [PATCH v2 03/11] drm/qxl: use ttm bo priorities

2021-02-17 Thread Thomas Zimmermann
Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Allow to set priorities for buffer objects. Use priority 1 for surface and cursor command releases. Use priority 0 for drawing command releases. That way the short-living drawing commands are first in line when it comes to eviction, making it

Re: [PATCH v2 02/11] drm/qxl: more fence wait rework

2021-02-17 Thread Thomas Zimmermann
Am 17.02.21 um 13:32 schrieb Gerd Hoffmann: Move qxl_io_notify_oom() call into wait condition. That way the driver will call it again if one call wasn't enough. Also allows to remove the extra dma_fence_is_signaled() check and the goto. Fixes: 5a838e5d5825 ("drm/qxl: simplify

[PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

2021-02-17 Thread Ronald Tschalär
The response to a command may never arrive or it may be corrupted (and hence dropped) for some reason. While exceedingly rare, when it did happen it blocked all further commands. One way to fix this was to do a suspend/resume. However, recovering automatically seems like a nicer option. Hence this

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 07:01:59PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-17 07:54:47 [-0800], Paul E. McKenney wrote: > > > I though boosting is accomplished by acquiring a rt_mutex in a > > > rcu_read() section. Do you have some code to point me to, to see how a > > > timer is

[PATCH 2/3] Input: applespi: Fix occasional crc errors under load.

2021-02-17 Thread Ronald Tschalär
For some reason, when the system is under heavy CPU load, the read following the write sometimes occurs unusually quickly, resulting in the read data not being quite ready and hence a bad packet getting read. Adding another delay after reading the status message appears to fix this.

[PATCH 3/3] Input: applespi: Add trace_event module param for early tracing.

2021-02-17 Thread Ronald Tschalär
The problem is that tracing can't be set via sysfs until the module is loaded, at which point the keyboard and trackpad initialization commands have already been run and hence tracing can't be used to debug problems here. Adding this param allows tracing to be enabled for messages sent and

Re: output: was: Re: [PATCH v4] printk: Userspace format enumeration support

2021-02-17 Thread Steven Rostedt
On Wed, 17 Feb 2021 15:28:24 + Chris Down wrote: > Petr Mladek writes: > >I guess that you already use it internally and have its own tooling > >around it. > > Hmm, we're actually not using it yet widely because I don't want to backport > it > to our prod kernel until we're reasonably

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
Hi Mathieu, I worked on this further and had 1 more comment on the prepare/unprepare for TCM banks below > -Original Message- > From: Ben Levinsky > Sent: Wednesday, February 17, 2021 8:47 AM > To: Mathieu Poirier > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org;

Re: [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER

2021-02-17 Thread Marc Zyngier
On Wed, 17 Feb 2021 14:28:00 +, Marc Zyngier wrote: > > Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is > made at the architecture level, and shouldn't involve the irqchip > at all (we even provide a fallback helper when the option isn't > selected). > > Drop all

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-17 Thread Jordan Crouse
On Wed, Feb 17, 2021 at 07:14:16PM +0530, Akhil P Oommen wrote: > On 2/17/2021 8:36 AM, Rob Clark wrote: > >On Tue, Feb 16, 2021 at 12:10 PM Jonathan Marek wrote: > >> > >>Ignore nvmem_cell_get() EOPNOTSUPP error in the same way as a ENOENT error, > >>to fix the case where the kernel was compiled

Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-17 Thread Andrew Morton
On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz wrote: > page structs are not guaranteed to be contiguous for gigantic pages. The > routine update_and_free_page can encounter a gigantic page, yet it assumes > page structs are contiguous when setting page flags in subpages. > > If

Re: [PATCH v2] gpio: pca953x: add support for open drain pins on PCAL6524

2021-02-17 Thread Bedel, Alban
On Wed, 2021-02-17 at 16:19 +0200, Andy Shevchenko wrote: > On Wed, Feb 17, 2021 at 3:11 PM Bedel, Alban > wrote: > > On Tue, 2021-02-16 at 19:50 +0200, Andy Shevchenko wrote: > > > On Tue, Feb 16, 2021 at 6:37 PM Bedel, Alban < > > > alban.be...@aerq.com> > > > wrote: > > > > On Mon, 2021-02-15

Re: [PATCH v2] IMA: support for duplicate data measurement

2021-02-17 Thread Tushar Sugandhi
Thanks for the feedback Mimi. Appreciate it. On 2021-02-17 7:03 a.m., Mimi Zohar wrote: Hi Tushar, The Subject line could be improved. Perhaps something like - "IMA: support for duplicate measurement records" Will do. On Tue, 2021-02-16 at 18:46 -0800, Tushar Sugandhi wrote: IMA does not

[PATCH v3 1/1] rcuscale: add kfree_rcu() single-argument scale test

2021-02-17 Thread Uladzislau Rezki (Sony)
To stress and test a single argument of kfree_rcu() call, we should to have a special coverage for it. We used to have it in the test-suite related to vmalloc stressing. The reason is the rcuscale is a correct place for RCU related things. Therefore introduce two torture_param() variables, one is

Re: [PATCH 4/7] KVM: nVMX: move inject_page_fault tweak to .complete_mmu_init

2021-02-17 Thread Maxim Levitsky
On Wed, 2021-02-17 at 18:37 +0100, Paolo Bonzini wrote: > On 17/02/21 18:29, Sean Christopherson wrote: > > All that being said, I'm pretty we can eliminate setting > > inject_page_fault dynamically. I think that would yield more > > maintainable code. Following these flows is a nightmare. The

Re: [PATCH] mm, compaction: make fast_isolate_freepages() stay within zone

2021-02-17 Thread Mel Gorman
On Wed, Feb 17, 2021 at 06:33:00PM +0100, Vlastimil Babka wrote: > Compaction always operates on pages from a single given zone when isolating > both pages to migrate and freepages. Pageblock boundaries are intersected with > zone boundaries to be safe in case zone starts or ends in the middle of

[PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption

2021-02-17 Thread Mike Kravetz
page structs are not guaranteed to be contiguous for gigantic pages. The routine update_and_free_page can encounter a gigantic page, yet it assumes page structs are contiguous when setting page flags in subpages. If update_and_free_page encounters non-contiguous page structs, we can see “BUG:

[PATCH 2/2] hugetlb: fix copy_huge_page_from_user contig page struct assumption

2021-02-17 Thread Mike Kravetz
page structs are not guaranteed to be contiguous for gigantic pages. The routine copy_huge_page_from_user can encounter gigantic pages, yet it assumes page structs are contiguous when copying pages from user space. Since page structs for the target gigantic page are not contiguous, the data

Re: KASAN: use-after-free Read in tcp_current_mss

2021-02-17 Thread Paolo Abeni
On Wed, 2021-02-17 at 07:36 -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:773dc50d Merge branch 'Xilinx-axienet-updates' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=13460822d0 > kernel config:

Re: [PATCH 4/7] KVM: nVMX: move inject_page_fault tweak to .complete_mmu_init

2021-02-17 Thread Maxim Levitsky
On Wed, 2021-02-17 at 09:29 -0800, Sean Christopherson wrote: > On Wed, Feb 17, 2021, Maxim Levitsky wrote: > > This fixes a (mostly theoretical) bug which can happen if ept=0 > > on host and we run a nested guest which triggers a mmu context > > reset while running nested. > > In this case the

Re: [PATCH v3 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation

2021-02-17 Thread john . p . donnelly
On 2/11/21 12:08 PM, Saeed Mirzamohammadi wrote: This adds crashkernel=auto feature to configure reserved memory for vmcore creation. CONFIG_CRASH_AUTO_STR is defined to be set for different kernel distributions and different archs based on their needs. Signed-off-by: Saeed Mirzamohammadi

Re: [MPTCP] KASAN: use-after-free Read in mptcp_established_options

2021-02-17 Thread Paolo Abeni
On Wed, 2021-02-17 at 09:30 -0800, syzbot wrote: > syzbot found the following issue on: > > HEAD commit:966df6de lan743x: sync only the received area of an rx rin.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=11afe082d0 > kernel config:

Re: [PATCH] test-media: wrap vivid code around $vivid variable

2021-02-17 Thread Helen Koike
On 2/17/21 3:22 PM, Hans Verkuil wrote: On 17/02/2021 19:11, Helen Koike wrote: The script was trying to load vivid and run some commands on top of it even when $vivid = 0. Wrap all vivid code under $vivid variable. Signed-off-by: Helen Koike --- contrib/test/test-media | 66

MIPS: net: mscc: ocelot: undefined reference to `packing'

2021-02-17 Thread Naresh Kamboju
The mips defconfig build failed on today's Linux next 20210217 tag. make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=mips CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc' 'HOSTCC=sccache gcc' uImage.gz mips-linux-gnu-ld: drivers/net/ethernet/mscc

Re: [PATCH] staging: comedi: cast to (unsigned int *)

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 11:40:00PM +0530, Atul Gopinathan wrote: > On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote: > > On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote: > > > Resolve the following warning generated by sparse: > > > > > >

Re: [PATCH] perf annotate: do not jump after 'k' is pressed

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 01:45:25PM +0100, Martin Liška escreveu: > Do not jump when 'k' is pressed, the cursor show stay where it is. > Right now, it jumps to the currently selected hot instruction. Thanks, applied. - Arnaldo > Signed-off-by: Martin Liška > --- >

Re: [PATCH] test-media: wrap vivid code around $vivid variable

2021-02-17 Thread Hans Verkuil
On 17/02/2021 19:11, Helen Koike wrote: > The script was trying to load vivid and run some commands on top of it > even when $vivid = 0. > Wrap all vivid code under $vivid variable. > > Signed-off-by: Helen Koike > --- > contrib/test/test-media | 66 - >

Re: [PATCH v5 2/3] mm, slub: don't combine pr_err with INFO

2021-02-17 Thread David Rientjes
On Mon, 15 Feb 2021, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. > This patch is motivated by David's comment[1]. > > - before the patch > [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 > fp=0x60d32ca8

Re: [PATCH v2] ARM: Implement Clang's SLS mitigation

2021-02-17 Thread Nick Desaulniers
On Fri, Feb 12, 2021 at 11:53 AM 'Jian Cai' via Clang Built Linux wrote: The oneline of the commit is "ARM: Implement Clang's SLS mitigation," but that's not precise. GCC implements the same flag with the same arguments. There is nothing compiler specific about this patch. (Though perhaps

Re: [PATCH] perf metricgroup: remove unneeded semicolon

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 04:34:25PM +0900, Namhyung Kim escreveu: > Hello, > > On Mon, Feb 1, 2021 at 4:41 PM Yang Li wrote: > > > > Eliminate the following coccicheck warning: > > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon > > > > Reported-by: Abaci Robot > > Signed-off-by:

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 11:35:06AM -0500, Nicholas Fraser escreveu: > No problem, I've added a call to "perf buildid-cache -l" in check() to make > sure the added IDs are reported. The MD5 test fails without the previous > patch to allow 16-byte build-ids. > > Do you also want PE files tested by

Re: [PATCH v3 2/2] drm/i915/icp+: Use icp_hpd_irq_setup() instead of spt_hpd_irq_setup()

2021-02-17 Thread Rodrigo Vivi
On Tue, Feb 16, 2021 at 09:53:37PM -0500, Lyude Paul wrote: > While reviewing patches for handling workarounds related to gen9 bc, Imre > from Intel discovered that we're using spt_hpd_irq_setup() on ICP+ PCHs > despite it being almost the same as icp_hpd_irq_setup(). Since we need to > be calling

Re: [PATCH 2/2] rcu-tasks: add RCU-tasks self tests

2021-02-17 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 11:47:59PM +0900, Masami Hiramatsu wrote: > On Tue, 16 Feb 2021 09:30:03 -0800 > "Paul E. McKenney" wrote: > > > On Mon, Feb 15, 2021 at 12:28:26PM +0100, Sebastian Andrzej Siewior wrote: > > > On 2021-02-13 08:45:54 [-0800], Paul E. McKenney wrote: > > > > Glad you like

Re: [PATCH] mm, compaction: make fast_isolate_freepages() stay within zone

2021-02-17 Thread David Rientjes
On Wed, 17 Feb 2021, Vlastimil Babka wrote: > Compaction always operates on pages from a single given zone when isolating > both pages to migrate and freepages. Pageblock boundaries are intersected with > zone boundaries to be safe in case zone starts or ends in the middle of > pageblock. The use

Re: [PATCH] perf tools: Add OCaml demangling

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 04:47:30PM +0900, Namhyung Kim escreveu: > Hello, > > (+ Cc: LKML) > > On Thu, Feb 4, 2021 at 6:22 AM Fabian Hemmer wrote: > > > > Detect symbols generated by the OCaml compiler based on their prefix. > > > > Demangle OCaml symbols, returning a newly allocated string

[PATCH] test-media: wrap vivid code around $vivid variable

2021-02-17 Thread Helen Koike
The script was trying to load vivid and run some commands on top of it even when $vivid = 0. Wrap all vivid code under $vivid variable. Signed-off-by: Helen Koike --- contrib/test/test-media | 66 - 1 file changed, 33 insertions(+), 33 deletions(-) diff

possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Jason A. Donenfeld
Hi Netdev & Willem, I've received a report of stack corruption -- via the stack protector check -- in icmp_send. I was sent a vmcore, and was able to extract the OOPS from there. However, I've been unable to produce the bug and I don't see where it'd be in the code. That might point to a more

Re: [PATCH RESEND v5] proc: Allow pid_revalidate() during LOOKUP_RCU

2021-02-17 Thread Stephen Brennan
Stephen Brennan writes: > The pid_revalidate() function drops from RCU into REF lookup mode. When > many threads are resolving paths within /proc in parallel, this can > result in heavy spinlock contention on d_lockref as each thread tries to > grab a reference to the /proc dentry (and drop it

Re: [PATCH] arm64: dts: qcom: sc7180:: modified qfprom CORR size as per RAW size

2021-02-17 Thread Doug Anderson
Hi, On Wed, Feb 17, 2021 at 9:27 AM Ravi Kumar Bokka wrote: > > modified QFPROM controller CORRECTED region size as per RAW region size > > Signed-off-by: Ravi Kumar Bokka > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas

Re: [PATCH] iommu/amd: Fix sleeping in atomic in increase_address_space()

2021-02-17 Thread Will Deacon
On Wed, Feb 17, 2021 at 05:30:04PM +0300, Andrey Ryabinin wrote: > increase_address_space() calls get_zeroed_page(gfp) under spin_lock with > disabled interrupts. gfp flags passed to increase_address_space() may allow > sleeping, so it comes to this: > > BUG: sleeping function called from

Re: [PATCH] staging: comedi: cast to (unsigned int *)

2021-02-17 Thread Atul Gopinathan
On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote: > On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote: > > Resolve the following warning generated by sparse: > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in > > assignment (different address

Re: [PATCH 2/3] x86/sev-es: Check if regs->sp is trusted before adjusting #VC IST stack

2021-02-17 Thread Andy Lutomirski
On Wed, Feb 17, 2021 at 4:02 AM Joerg Roedel wrote: > > From: Joerg Roedel > > The code in the NMI handler to adjust the #VC handler IST stack is > needed in case an NMI hits when the #VC handler is still using its IST > stack. > But the check for this condition also needs to look if the

Re: [GIT PULL] clang-lto for v5.12-rc1

2021-02-17 Thread Kees Cook
On Tue, Feb 16, 2021 at 10:48:10PM +, Alexander Lobakin wrote: > From: Kees Cook > Date: Tue, 16 Feb 2021 12:34:37 -0800 > > > Hi Linus, > > > > Please pull this Clang Link Time Optimization series for v5.12-rc1. This > > has been in linux-next for the entire last development cycle, and is

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 08:20:46 + Lee Jones wrote: > On Mon, 15 Feb 2021, Jakub Kicinski wrote: > > On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > > Yes, please share. > > > > https://github.com/kuba-moo/nipa > > Thanks for this. > > Oh, I see. So you conduct tests locally,

Re: [PATCH 6/7] KVM: nVMX: don't load PDPTRS right after nested state set

2021-02-17 Thread Paolo Bonzini
On 17/02/21 18:52, Sean Christopherson wrote: Just move the call to nested_vmx_load_cr3 to nested_get_vmcs12_pages to implement this. I don't love this approach. KVM_SET_NESTED_STATE will now succeed with a bad vmcs12.GUEST_CR3. At a minimum, GUEST_CR3 should be checked in

Re: [PATCH] arm64: Add part number for Arm Cortex-A78

2021-02-17 Thread Neeraj Upadhyay
On 2/17/2021 10:36 PM, Will Deacon wrote: On Wed, Feb 17, 2021 at 10:14:11PM +0530, Neeraj Upadhyay wrote: Add the MIDR part number info for the Arm Cortex-A78. Signed-off-by: Neeraj Upadhyay --- arch/arm64/include/asm/cputype.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 13:12:29 -0500 Vincent Cheng wrote: > >> +} > >> + > >> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > >> +{ > >> + const char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL > >> state %d"; > >> + u8 i = LOCK_TIMEOUT_MS / LOCK_POLL_INTERVAL_MS; > >

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-02-17 Thread Sebastian Andrzej Siewior
On 2021-02-17 07:54:47 [-0800], Paul E. McKenney wrote: > > I though boosting is accomplished by acquiring a rt_mutex in a > > rcu_read() section. Do you have some code to point me to, to see how a > > timer is involved here? Or is it the timer saying that *now* boosting is > > needed. > > Yes,

[PATCH v4] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-17 Thread Lyude Paul
From: Tejas Upadhyay For Legacy S3 suspend/resume GEN9 BC needs to enable and setup TGP PCH. v2: * Move Wa_14010685332 into it's own function - vsyrjala * Add TODO comment about figuring out if we can move this workaround - imre v3: * Rename cnp_irq_post_reset() to cnp_display_clock_wa() * Add

Re: [PATCH 4/7] KVM: nVMX: move inject_page_fault tweak to .complete_mmu_init

2021-02-17 Thread Paolo Bonzini
On 17/02/21 18:57, Sean Christopherson wrote: That said, I'm also rusty on_why_ this code is needed. Why isn't it enough to inject the exception normally, and let nested_vmx_check_exception decide whether to inject a vmexit to L1 or an exception into L2? Hmm, I suspect it was required at one

Re: [PATCH 3/3] x86/sev-es: Improve comments in and around __sev_es_ist_enter/exit()

2021-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2021 at 01:01:43PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Better explain why this code is necessary and what it is doing. > > Signed-off-by: Joerg Roedel > --- > arch/x86/kernel/sev-es.c | 23 --- > 1 file changed, 16 insertions(+), 7

Re: [PATCH 2/3] x86/sev-es: Check if regs->sp is trusted before adjusting #VC IST stack

2021-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2021 at 01:01:42PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > The code in the NMI handler to adjust the #VC handler IST stack is > needed in case an NMI hits when the #VC handler is still using its IST > stack. > But the check for this condition also needs to look if the

Re: [PATCH 1/3] x86/sev-es: Introduce from_syscall_gap() helper

2021-02-17 Thread Borislav Petkov
I guess subject prefix should be "x86/traps:" but I'll fix that up while applying eventually. On Wed, Feb 17, 2021 at 01:01:41PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Introduce a helper to check whether an exception came from the syscall > gap and use it in the SEV-ES code > >

Re: [PATCH 4/7] KVM: nVMX: move inject_page_fault tweak to .complete_mmu_init

2021-02-17 Thread Sean Christopherson
On Wed, Feb 17, 2021, Paolo Bonzini wrote: > On 17/02/21 18:29, Sean Christopherson wrote: > > All that being said, I'm pretty we can eliminate setting > > inject_page_fault dynamically. I think that would yield more > > maintainable code. Following these flows is a nightmare. The change > >

Re: [RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-17 Thread Dario Binacchi
Hi Tomi, > Il 17/02/2021 07:41 Tomi Valkeinen ha > scritto: > > > On 16/02/2021 22:22, Dario Binacchi wrote: > > The fdd property of the tilcdc_panel_info structure must set the reqdly > > bit field (bit 12 to 19) of the raster control register. The previous > > statement set the least

Re: [PATCH 6/7] KVM: nVMX: don't load PDPTRS right after nested state set

2021-02-17 Thread Sean Christopherson
On Wed, Feb 17, 2021, Maxim Levitsky wrote: > Just like all other nested memory accesses, after a migration loading > PDPTRs should be delayed to first VM entry to ensure > that guest memory is fully initialized. > > Just move the call to nested_vmx_load_cr3 to nested_get_vmcs12_pages > to

[PATCH] MAINTAINERS: add uapi directories to API/ABI section

2021-02-17 Thread Vlastimil Babka
Let's add include/uapi/ and arch/*/include/uapi/ to API/ABI section, so that for patches modifying them, get_maintainers.pl suggests CCing linux-api@ so people don't forget. Reported-by: David Hildenbrand Signed-off-by: Vlastimil Babka --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH 1/2] rcuscale: add kfree_rcu() single-argument scale test

2021-02-17 Thread Uladzislau Rezki
On Tue, Feb 16, 2021 at 09:35:02AM -0800, Paul E. McKenney wrote: > On Mon, Feb 15, 2021 at 05:27:05PM +0100, Uladzislau Rezki wrote: > > On Tue, Feb 09, 2021 at 05:00:52PM -0800, Paul E. McKenney wrote: > > > On Tue, Feb 09, 2021 at 09:13:43PM +0100, Uladzislau Rezki wrote: > > > > On Thu, Feb

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 06:34:13PM +0100, David Hildenbrand wrote: > On 17.02.21 18:26, Minchan Kim wrote: > > On Wed, Feb 17, 2021 at 05:51:27PM +0100, David Hildenbrand wrote: > > > On 17.02.21 17:36, Minchan Kim wrote: > > > > alloc_contig_range is usually used on cma area or movable zone. > >

Re: [PATCH v3 2/8] mm: memcontrol: kill mem_cgroup_nodeinfo()

2021-02-17 Thread Michal Koutný
On Tue, Feb 09, 2021 at 11:32:58AM -0500, Johannes Weiner wrote: > include/linux/memcontrol.h | 8 +--- > mm/memcontrol.c| 21 +++-- > 2 files changed, 12 insertions(+), 17 deletions(-) Reviewed-by: Michal Koutný signature.asc Description: Digital signature

Re: [PATCH v3 3/8] mm: memcontrol: privatize memcg_page_state query functions

2021-02-17 Thread Michal Koutný
On Tue, Feb 09, 2021 at 11:32:59AM -0500, Johannes Weiner wrote: > include/linux/memcontrol.h | 44 -- > mm/memcontrol.c| 32 +++ > 2 files changed, 32 insertions(+), 44 deletions(-) Reviewed-by: Michal Koutný

Re: [PATCH 00/11] HID: playstation: revert LED class exposure

2021-02-17 Thread Pavel Machek
On Wed 2021-02-17 18:31:47, Benjamin Tissoires wrote: > [sending those patches on behalf of Roderick] > > There is a current thread on LED LKML which basically means that > we have to revert the LED class exposure until things are settled. > > I am sending here the full series that will end up

Re: [PATCH v3 1/8] mm: memcontrol: fix cpuhotplug statistics flushing

2021-02-17 Thread Michal Koutný
On Tue, Feb 09, 2021 at 11:32:57AM -0500, Johannes Weiner wrote: > mm/memcontrol.c | 35 +-- > 1 file changed, 21 insertions(+), 14 deletions(-) Reviewed-by: Michal Koutný signature.asc Description: Digital signature

Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1

2021-02-17 Thread Michal Koutný
Hello. On Tue, Feb 09, 2021 at 11:33:00AM -0500, Johannes Weiner wrote: > @@ -1971,10 +1978,14 @@ int cgroup_setup_root(struct cgroup_root *root, u16 > ss_mask) > if (ret) > goto destroy_root; > > - ret = rebind_subsystems(root, ss_mask); > + ret =

<    1   2   3   4   5   6   7   8   9   10   >