Re: [PATCH v4 2/2] dt-bindings: usb: rt1711h device tree binding document

Hi Rob, 2018-03-27 6:23 GMT+08:00 Rob Herring : > On Tue, Mar 20, 2018 at 05:15:04PM +0800, ShuFan Lee wrote: >> From: ShuFan Lee >> >> Add device tree binding document for Richtek RT1711H Type-C chip driver >> >> Signed-off-by: ShuFan Lee

Re: [PATCH v4 2/2] dt-bindings: usb: rt1711h device tree binding document

Hi Rob, 2018-03-27 6:23 GMT+08:00 Rob Herring : > On Tue, Mar 20, 2018 at 05:15:04PM +0800, ShuFan Lee wrote: >> From: ShuFan Lee >> >> Add device tree binding document for Richtek RT1711H Type-C chip driver >> >> Signed-off-by: ShuFan Lee >> --- >>

Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

Hi Guenter, 2018-03-20 0:29 GMT+08:00 Guenter Roeck : > On Mon, Mar 19, 2018 at 11:49:35AM +0800, ShuFan Lee wrote: >> From: ShuFan Lee >> >> Add device tree binding document for Richtek RT1711H Type-C chip driver > > Cc: Rob Herring

Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

Hi Guenter, 2018-03-20 0:29 GMT+08:00 Guenter Roeck : > On Mon, Mar 19, 2018 at 11:49:35AM +0800, ShuFan Lee wrote: >> From: ShuFan Lee >> >> Add device tree binding document for Richtek RT1711H Type-C chip driver > > Cc: Rob Herring , devicet...@vger.kernel.org > is missing. Added here but it

Re: [PATCH v2] staging: typec: rt1711h typec chip driver

Hi Guenter, 2018-03-17 10:16 GMT+08:00 Guenter Roeck : > On 03/16/2018 10:40 AM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Richtek RT1711H Type-C chip driver that works with >> Type-C Port Controller Manager to provide USB PD and >> USB Type-C

Re: [PATCH v2] staging: typec: rt1711h typec chip driver

Hi Guenter, 2018-03-17 10:16 GMT+08:00 Guenter Roeck : > On 03/16/2018 10:40 AM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Richtek RT1711H Type-C chip driver that works with >> Type-C Port Controller Manager to provide USB PD and >> USB Type-C functionalities. >> Add definition of

Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi Heikki, 2018-03-16 23:05 GMT+08:00 Heikki Krogerus : > Hi ShuFan, > > On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: >> +static int rt1711h_init_gpio(struct rt1711h_chip *chip) >> +{ >> + int ret; >> + struct device_node *np =

Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi Heikki, 2018-03-16 23:05 GMT+08:00 Heikki Krogerus : > Hi ShuFan, > > On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: >> +static int rt1711h_init_gpio(struct rt1711h_chip *chip) >> +{ >> + int ret; >> + struct device_node *np = chip->dev->of_node; >> + >> + ret =

Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi Greg, 2018-03-16 21:29 GMT+08:00 Mats Karrman : > Hi, > > On 2018-03-16 13:58, Greg KH wrote: > >> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: >>> >>> From: ShuFan Lee >>> >>> Richtek RT1711H Type-C chip driver that works with

Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi Greg, 2018-03-16 21:29 GMT+08:00 Mats Karrman : > Hi, > > On 2018-03-16 13:58, Greg KH wrote: > >> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: >>> >>> From: ShuFan Lee >>> >>> Richtek RT1711H Type-C chip driver that works with >>> Type-C Port Controller Manager to provide USB

Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

Hi Greg, 2018-03-12 19:07 GMT+08:00 Greg KH : > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote: >> From: ShuFan Lee > > Your subject is odd, that line should be below, in the signed-off-by: > area, not as the subject of the patch :( > > Can you

Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

Hi Greg, 2018-03-12 19:07 GMT+08:00 Greg KH : > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote: >> From: ShuFan Lee > > Your subject is odd, that line should be below, in the signed-off-by: > area, not as the subject of the patch :( > > Can you fix this up and resend? Yes. If I

Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, 2018-03-12 13:58 GMT+08:00 Jun Li <jun...@nxp.com>: > Hi >> -Original Message----- >> From: 李書帆 [mailto:leechu...@gmail.com] >> Sent: 2018年3月12日 13:22 >> To: Jun Li <jun...@nxp.com> >> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org&g

Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, 2018-03-12 13:58 GMT+08:00 Jun Li : > Hi >> -Original Message- >> From: 李書帆 [mailto:leechu...@gmail.com] >> Sent: 2018年3月12日 13:22 >> To: Jun Li >> Cc: Greg Kroah-Hartman ; >> heikki.kroge...@linux.intel.com; li...@roeck-us.net; g...@kroa

Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, Thank you. 2018-03-12 12:33 GMT+08:00 Jun Li : > Hi, > >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) { >> + struct tcpci *tcpci = dev_id; >> + >> + return tcpci_irq(tcpci); >> +} >> > ... > >> + err = devm_request_threaded_irq(>dev, client->irq,

Re: [PATCH v7] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, Thank you. 2018-03-12 12:33 GMT+08:00 Jun Li : > Hi, > >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) { >> + struct tcpci *tcpci = dev_id; >> + >> + return tcpci_irq(tcpci); >> +} >> > ... > >> + err = devm_request_threaded_irq(>dev, client->irq, NULL, >> +

Re: [PATCH v6] staging: typec: handle vendor defined part and modify drp toggling flow

Hi, 2018-03-05 22:49 GMT+08:00 Guenter Roeck : > On 03/04/2018 08:16 PM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, >> tcpci_start_drp_toggling >> and export tcpci_irq. More operations

Re: [PATCH v6] staging: typec: handle vendor defined part and modify drp toggling flow

Hi, 2018-03-05 22:49 GMT+08:00 Guenter Roeck : > On 03/04/2018 08:16 PM, ShuFan Lee wrote: >> >> From: ShuFan Lee >> >> Handle vendor defined behavior in tcpci_init, tcpci_set_vconn, >> tcpci_start_drp_toggling >> and export tcpci_irq. More operations can be extended in tcpci_data if >> needed.

Re: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi, Sorry, I modify it to plain text mode and send again 2018-03-03 2:39 GMT+08:00 李書帆 <leechu...@gmail.com>: > > Hi Jun, > > I think this operation should be moved to vendor's operation after > rechecking the specification. > > 2018-03-02 22:38 GMT+08:00 Jun Li

Re: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi, Sorry, I modify it to plain text mode and send again 2018-03-03 2:39 GMT+08:00 李書帆 : > > Hi Jun, > > I think this operation should be moved to vendor's operation after > rechecking the specification. > > 2018-03-02 22:38 GMT+08:00 Jun Li : >> >&

RE: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, > -Original Message- > From: Jun Li [mailto:jun...@nxp.com] > Sent: Thursday, March 01, 2018 6:06 PM > To: shufan_lee(李書帆); ShuFanLee; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; g...@kroah.com > Cc: cy_huang(黃啟原); linux-kernel@vger

RE: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, > -Original Message- > From: Jun Li [mailto:jun...@nxp.com] > Sent: Thursday, March 01, 2018 6:06 PM > To: shufan_lee(李書帆); ShuFanLee; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; g...@kroah.com > Cc: cy_huang(黃啟原); linux-kernel@vger

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

inux.intel.com; li...@roeck-us.net; g...@kroah.com 副本: shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; dl-linux-imx 主旨: RE: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow Hi, > -Original Message- > From: linux-u

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

k-us.net; g...@kroah.com 副本: shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; dl-linux-imx 主旨: RE: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow Hi, > -Original Message- > From: linux-usb-ow...@vger.kernel.o

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

上午 06:15 收件者: ShuFanLee 副本: heikki.kroge...@linux.intel.com; g...@kroah.com; shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org 主旨: Re: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow On Wed, Feb 21, 2018 at 11:02:23PM +0800, Shu

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

...@linux.intel.com; g...@kroah.com; shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org 主旨: Re: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow On Wed, Feb 21, 2018 at 11:02:23PM +0800, ShuFanLee wrote: > From: ShuFanLee > > Hand

回覆: [PATCH v3] Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export tcpci_irq. More operations can be extended in tcpci_data if needed. According to TCPCI specification, 4.4.5.2 RO

: Greg KH <g...@kroah.com> 寄件日期: 2018年2月21日 下午 10:39 收件者: ShuFanLee 副本: heikki.kroge...@linux.intel.com; li...@roeck-us.net; shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org 主旨: Re: [PATCH v3] Handle vendor defined behavior in tcpci_init, tcpci_set

回覆: [PATCH v3] Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export tcpci_irq. More operations can be extended in tcpci_data if needed. According to TCPCI specification, 4.4.5.2 RO

: Greg KH 寄件日期: 2018年2月21日 下午 10:39 收件者: ShuFanLee 副本: heikki.kroge...@linux.intel.com; li...@roeck-us.net; shufan_lee(李書帆); cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org 主旨: Re: [PATCH v3] Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export tcpci_irq

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Tuesday, January 30, 2018 3:58 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus;

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Tuesday, January 30, 2018 3:58 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus;

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Behalf Of Guenter Roeck Sent: Tuesday, January 23, 2018 2:51 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus; 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 22, 2018 at 02:01:13AM +0

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

On Behalf Of Guenter Roeck Sent: Tuesday, January 23, 2018 2:51 AM To: shufan_lee(李書帆) Cc: Heikki Krogerus; 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On Mon, Jan 22, 2018 at 02:01:13AM +0

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Saturday, January 20, 2018 12:03 AM To: Heikki Krogerus Cc: shufan_lee(李書帆); 'Jun Li'; ShuFanLee

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Saturday, January 20, 2018 12:03 AM To: Heikki Krogerus Cc: shufan_lee(李書帆); 'Jun Li'; ShuFanLee

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] Sent: Friday, January 19, 2018 4:22 PM To: shufan_lee(李書帆) Cc: 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: Re: [PATCH] USB

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] Sent: Friday, January 19, 2018 4:22 PM To: shufan_lee(李書帆) Cc: 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: Re: [PATCH] USB

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: Jun Li [mailto:jun...@nxp.com] Sent: Friday, January 19, 2018 11:10 AM To: ShuFanLee; heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Hi

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: Jun Li [mailto:jun...@nxp.com] Sent: Friday, January 19, 2018 11:10 AM To: ShuFanLee; heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; Guenter Roeck Subject: RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Hi

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-%s", dev_name(chip->dev)); > +if (!chip->dbgdir) { > +chip->dbgdir = debugfs_create_dir(dirname, NULL); > +if (!chip->dbgdir) > +return -ENOMEM; No need to ever check the return value of debugfs_ calls, you should not care and can always use the value to any future debugfs calls, if you reall

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-%s", dev_name(chip->dev)); > +if (!chip->dbgdir) { > +chip->dbgdir = debugfs_create_dir(dirname, NULL); > +if (!chip->dbgdir) > +return -ENOMEM; No need to ever check the return value of debugfs_ calls, you should not care and can always use the value to any future debugfs calls, if you reall

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: ShuFanLee [mailto:leechu...@gmail.com] Sent: Wednesday, January 10, 2018 2:59 PM To: heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver From: ShuFanLee <shuf

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

- From: ShuFanLee [mailto:leechu...@gmail.com] Sent: Wednesday, January 10, 2018 2:59 PM To: heikki.kroge...@linux.intel.com Cc: cy_huang(黃啟原); shufan_lee(李書帆); linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver From: ShuFanLee

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Wednesday, January 10, 2018 1:26 AM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On 01/09/18 00:45

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

* -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Wednesday, January 10, 2018 1:26 AM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver On 01/09/18 00:45

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-5526612 * -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Tuesday, January 09, 2018 2:19 PM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

-5526612 * -Original Message- From: Randy Dunlap [mailto:rdun...@infradead.org] Sent: Tuesday, January 09, 2018 2:19 PM To: shufan_lee(李書帆); heikki.kroge...@linux.intel.com Cc: linux-kernel@vger.kernel.org; cy_huang(黃啟原) Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C

[PATCH] USB TYPEC: RT1711H Type-C Chip Driver

From: ShuFan Lee Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Signed-off-by: ShuFan Lee ---​ Documentation/devicetree/bindings/usb/richtek,rt1711h.txt | 38

[PATCH] USB TYPEC: RT1711H Type-C Chip Driver

From: ShuFan Lee Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Signed-off-by: ShuFan Lee ---​ Documentation/devicetree/bindings/usb/richtek,rt1711h.txt | 38 arch/arm64/boot/dts/hisilicon/rt1711h.dtsi