Re: [PATCH V2] scsi: ufs-pci: Add LTR support for Intel controllers

2020-09-09 Thread Adrian Hunter
On 2/09/20 12:27 pm, Adrian Hunter wrote: > On 2/09/20 5:12 am, Martin K. Petersen wrote: >> >> Adrian, >> >>> Intel host controllers support the setting of latency tolerance. >>> Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The &g

[PATCH 0/2] perf intel-pt: Improve handling for tid is -1

2020-09-09 Thread Adrian Hunter
Hi Here is a minor non-urgent fix for Intel PT. Adrian Hunter (2): perf script: Display negative tid in non-sample events perf intel-pt: Fix "context_switch event has no tid" error tools/perf/builtin-script.c | 10 ++ tools/perf/util/event.c | 2 +- tools

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-09-07 Thread Adrian Hunter
On 4/09/20 8:43 am, Ian Rogers wrote: > On Tue, Aug 4, 2020 at 8:50 AM Ian Rogers wrote: >> On Tue, Aug 4, 2020 at 7:49 AM Adrian Hunter wrote: >>> On 4/08/20 4:33 pm, Ian Rogers wrote: >>>> On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter >>>> wrote: &g

[PATCH] perf tools: Consolidate close_control_option()'s into one function

2020-09-03 Thread Adrian Hunter
Consolidate control option fifo closing into one function. Signed-off-by: Adrian Hunter --- This patch is on top of patch: "perf tools: Add FIFO file names as alternative options to --control" tools/perf/builtin-record.c | 12 +--- tools/perf/builtin-sta

Re: [PATCH V2 5/6] perf record: Add 'snapshot' control command

2020-09-03 Thread Adrian Hunter
On 2/09/20 8:03 pm, Alexey Budankov wrote: > > On 01.09.2020 12:37, Adrian Hunter wrote: >> Add 'snapshot' control command to create an AUX area tracing snapshot the >> same as if sending SIGUSR2. The advantage of the FIFO is that access is >> governed by access to

Re: [PATCH V3 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-09-03 Thread Adrian Hunter
On 2/09/20 8:03 pm, Alexey Budankov wrote: > > On 02.09.2020 13:57, Adrian Hunter wrote: >> Enable the --control option to accept file names as an alternative to >> file descriptors. >> >> Example: >> >> $ mkfifo perf.control >> $ mkfifo perf.

[PATCH V3 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-09-02 Thread Adrian Hunter
cat perf.ack [2]+ Terminated perf record --control fifo:perf.control,perf.ack -- sleep 300 $ Signed-off-by: Adrian Hunter Acked-by: Jiri Olsa --- Changes in V3: Rename evlist__parse_control_names to evlist__parse_control_fifo Explicitly initialize *ctl_fd_close = fa

Re: [PATCH V2] scsi: ufs-pci: Add LTR support for Intel controllers

2020-09-02 Thread Adrian Hunter
da76f71fef7d8a1a72af09d48899573feb60065

Re: [PATCH] mmc: sdhci-acpi: Clear amd_sdhci_host on reset

2020-09-01 Thread Adrian Hunter
uning for AMDI0040") > > Signed-off-by: Raul E Rangel Acked-by: Adrian Hunter > --- > - Performed 100+ suspend/resume cycles without issue. > - Also verified tuning continues to work. > > drivers/mmc/host/sdhci-acpi.c | 31 --- > 1 fi

Re: [PATCH v2] mmc: sdhci: Don't enable presets while tuning

2020-09-01 Thread Adrian Hunter
On 24/08/20 9:21 pm, Raul E Rangel wrote: > SDHCI presets are not currently used for eMMC HS/HS200/HS400, but are > used for DDR52. The HS400 retuning sequence is: > > HS400->DDR52->HS->HS200->Perform Tuning->HS->HS400 > > This means that when HS400 tuning happens, we transition through

[PATCH V2 6/6] perf intel-pt: Document snapshot control command

2020-09-01 Thread Adrian Hunter
The documentation descibes snapshot mode. Update it to include the new snapshot control command. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 23 +++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf

[PATCH V2 0/6] perf tools: Enable AUX area tracing snapshots using a FIFO

2020-09-01 Thread Adrian Hunter
the --control option to accept file names. Patch 5 adds snapshot control command. The final patch updates Intel PT documentation. Changes in V2: Use fifo: prefix in --control option Adrian Hunter (6): perf tools: Consolidate --control option parsing into one function perf tools

[PATCH V2 3/6] perf tools: Use AsciiDoc formatting for --control option documentation

2020-09-01 Thread Adrian Hunter
The --control option does not display well in man pages unless AsciiDoc formatting is used. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-record.txt | 46 tools/perf/Documentation/perf-stat.txt | 46 2 files changed, 46

[PATCH V2 5/6] perf record: Add 'snapshot' control command

2020-09-01 Thread Adrian Hunter
trol fifo:perf.control,perf.ack -S -e intel_pt//u -- sleep 60 & [2] 15243 $ ps -e | grep perf 15244 pts/100:00:00 perf $ kill -USR2 15244 bash: kill: (15244) - Operation not permitted $ echo snapshot > perf.control ack Signed-off-by: Adrian Hunter --- tools/perf/Documen

[PATCH V2 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-09-01 Thread Adrian Hunter
cat perf.ack [2]+ Terminated perf record --control fifo:perf.control,perf.ack -- sleep 300 $ Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-record.txt | 2 + tools/perf/Documentation/perf-stat.txt | 2 + tools/perf/builtin-record.c | 34 ++

[PATCH V2 2/6] perf tools: Handle read errors from ctl_fd

2020-09-01 Thread Adrian Hunter
Handle read errors from ctl_fd such as EINTR, EAGAIN and EWOULDBLOCK. Signed-off-by: Adrian Hunter --- tools/perf/util/evlist.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 62e3f87547ce

[PATCH V2 1/6] perf tools: Consolidate --control option parsing into one function

2020-09-01 Thread Adrian Hunter
Consolidate --control option parsing into one function, in preparation for adding FIFO file name options. Signed-off-by: Adrian Hunter --- tools/perf/builtin-record.c | 22 ++ tools/perf/builtin-stat.c | 22 ++ tools/perf/util/evlist.c| 24

[PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-01 Thread Adrian Hunter
Signed-off-by: Adrian Hunter --- kernel/trace/ftrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 275441254bb5..4e64367c9774 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -2782,6 +2782,7 @@ s

Re: Broadcom WiFi SDIO performance regression after commit "mmc: sdhci: Remove finish_tasklet"

2020-08-31 Thread Adrian Hunter
On 27/08/20 12:36 pm, Dmitry Osipenko wrote: > 27.08.2020 09:45, Adrian Hunter пишет: >> On 27/08/20 9:07 am, Dmitry Osipenko wrote: >>> Hello! >>> >>> I was debugging WiFi performance problems on Acer A500 tablet device >>> that has BCM4329 WiFi chip

Re: [PATCH] mmc: sdhci-msm: Add retries when all tuning phases are found valid

2020-08-31 Thread Adrian Hunter
gt; errors later in boot. > > I have seen cases where all phases were found to be valid 3 times in a > row, so increase the retry count to 10 just to be extra sure. > > Fixes: 415b5a75da43 ("mmc: sdhci-msm: Add platform_execute_tuning > implementation") > Signed-off

Re: [PATCH 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-08-31 Thread Adrian Hunter
On 31/08/20 4:19 pm, Jiri Olsa wrote: > On Sat, Aug 29, 2020 at 01:50:13PM +0300, Adrian Hunter wrote: > > SNIP > >> +*p = '\0'; >> + >> +/* >> + * O_RDWR avoids POLLHUPs which is necessary to allow the other >> + * end of

Re: [PATCH v1 2/2] mmc: mediatek: add pre_enable() and post_disable() hook function

2020-08-31 Thread Adrian Hunter
le(). > > Signed-off-by: Chun-Hung Wu Acked-by: Adrian Hunter > --- > drivers/mmc/host/mtk-sd.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 4e2583f..f53e11b 100644 >

Re: [PATCH v1 1/2] mmc: cqhci: add new cqhci_host_ops pre_enable() and post_disable()

2020-08-31 Thread Adrian Hunter
On 27/08/20 12:33 pm, Chun-Hung Wu wrote: > Add pre_enable() and post_disable() for cqhci_host_ops. > Add hook functions before cqhci enable and > after cqhci disable for platforms need them. > > Signed-off-by: Chun-Hung Wu Acked-by: Adrian Hunter > --- > drivers/mm

Re: [PATCH 5/6] perf record: Add 'snapshot' control command

2020-08-31 Thread Adrian Hunter
On 31/08/20 9:23 am, Andi Kleen wrote: > On Sat, Aug 29, 2020 at 01:50:14PM +0300, Adrian Hunter wrote: >> Add 'snapshot' control command to create an AUX area tracing snapshot the >> same as if sending SIGUSR2. The advantage of the FIFO is that access is >> governed

[PATCH 5/6] perf record: Add 'snapshot' control command

2020-08-29 Thread Adrian Hunter
trol perf.control,perf.ack -S -e intel_pt//u -- sleep 60 & [2] 15243 $ ps -e | grep perf 15244 pts/100:00:00 perf $ kill -USR2 15244 bash: kill: (15244) - Operation not permitted $ echo snapshot > perf.control ack Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf

[PATCH 6/6] perf intel-pt: Document snapshot control command

2020-08-29 Thread Adrian Hunter
The documentation descibes snapshot mode. Update it to include the new snapshot control command. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 23 +++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf

[PATCH 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-08-29 Thread Adrian Hunter
cat perf.ack [2]+ Terminated perf record --control perf.control,perf.ack -- sleep 300 $ Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-record.txt | 2 + tools/perf/Documentation/perf-stat.txt | 2 + tools/perf/builtin-record.c | 34 tools/pe

[PATCH 3/6] perf tools: Use AsciiDoc formatting for --control option documentation

2020-08-29 Thread Adrian Hunter
The --control option does not display well in man pages unless AsciiDoc formatting is used. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-record.txt | 46 tools/perf/Documentation/perf-stat.txt | 46 2 files changed, 46

[PATCH 1/6] perf tools: Consolidate --control option parsing into one function

2020-08-29 Thread Adrian Hunter
Consolidate --control option parsing into one function, in preparation for adding FIFO file name options. Signed-off-by: Adrian Hunter --- tools/perf/builtin-record.c | 22 ++ tools/perf/builtin-stat.c | 22 ++ tools/perf/util/evlist.c| 24

[PATCH 2/6] perf tools: Handle read errors from ctl_fd

2020-08-29 Thread Adrian Hunter
Handle read errors from ctl_fd such as EINTR, EAGAIN and EWOULDBLOCK. Signed-off-by: Adrian Hunter --- tools/perf/util/evlist.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 62e3f87547ce

[PATCH 0/6] perf tools: Enable AUX area tracing snapshots using a FIFO

2020-08-29 Thread Adrian Hunter
the --control option to accept file names. Patch 5 adds snapshot control command. The final patch updates Intel PT documentation. Adrian Hunter (6): perf tools: Consolidate --control option parsing into one function perf tools: Handle read errors from ctl_fd perf tools: Use AsciiDoc

[PATCH V2] scsi: ufs-pci: Add LTR support for Intel controllers

2020-08-27 Thread Adrian Hunter
Intel host controllers support the setting of latency tolerance. Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The raw register values are also exposed via debugfs. Signed-off-by: Adrian Hunter --- Changes in V2: Put debugfs code altogether drivers/scsi/

Re: Broadcom WiFi SDIO performance regression after commit "mmc: sdhci: Remove finish_tasklet"

2020-08-27 Thread Adrian Hunter
t; WiFi throughput regression after 5.2 kernel: What is that in percentage terms? > > commit c07a48c2651965e84d35cf193dfc0e5f7892d612 > Author: Adrian Hunter > Date: Fri Apr 5 15:40:20 2019 +0300 > > mmc: sdhci: Remove finish_tasklet > > Remove finish_ta

Re: Ftrace regression in v5.9-rc1 due to commit fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")

2020-08-26 Thread Adrian Hunter
On 26/08/20 12:30 pm, Miroslav Benes wrote: > Hi, > > during v5.9-rc1 testing I ran into an issue (BUG dump at the end of the > email). I suspected commit fc0ea795f53c ("ftrace: Add symbols for ftrace > trampolines") (which git bisect later confirmed) and a missing call to >

Re: [PATCH] scsi: ufs-pci: Add LTR support for Intel controllers

2020-08-26 Thread Adrian Hunter
On 26/08/20 9:13 am, Avri Altman wrote: > >> >> Intel host controllers support the setting of latency tolerance. >> Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The >> raw register values are also exposed via debugfs. >> >>

[PATCH] scsi: ufs-pci: Add LTR support for Intel controllers

2020-08-25 Thread Adrian Hunter
Intel host controllers support the setting of latency tolerance. Accordingly, implement the PM QoS ->set_latency_tolerance() callback. The raw register values are also exposed via debugfs. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd-pci.c | 122 +-

Re: [PATCH v4 2/3] sdhci: sparx5: Add Sparx5 SoC eMMC driver

2020-08-24 Thread Adrian Hunter
On 24/08/20 6:10 pm, Lars Povlsen wrote: > This adds the eMMC driver for the Sparx5 SoC. It is based upon the > designware IP, but requires some extra initialization and quirks. > > Signed-off-by: Lars Povlsen Already acked this, still: Acked-by: Adrian Hunter > --- >

Re: [PATCH 2/2] perf intel-pt: Fix corrupt data after perf inject from

2020-08-24 Thread Adrian Hunter
ot;perf tools: Add hw_idx in struct branch_stack") > Signed-off-by: Al Grant > Signed-off-by: Leo Yan Acked-by: Adrian Hunter > --- > tools/perf/util/intel-pt.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/intel-p

Re: [RFC PATCH V3 04/21] mmc: core: UHS-II support, try to select UHS-II interface

2020-08-21 Thread Adrian Hunter
On 21/08/20 3:25 pm, Ulf Hansson wrote: > [...] > @@ -2300,6 +2304,33 @@ void mmc_rescan(struct work_struct *work) goto out; } + if (host->caps & MMC_CAP_UHS2) { + /* +* Start to try UHS-II

Re: [RFC PATCH V3 15/21] mmc: sdhci: UHS-II support, modify set_power() to handle vdd2

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:11 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > VDD2 is used for powering UHS-II interface. > Modify sdhci_set_power_and_bus_voltage(), sdhci_set_power_noreg() > and sdhci_set_power_noreg() to handle VDD2. vdd2 is always 1.8 V and I suspect there may never be support for

Re: [RFC PATCH V3 14/21] mmc: sdhci: UHS-II support, handle vdd2 in case of power-off

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:11 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > Configure a regulator for VDD2 in case of power-off. > > Signed-off-by: Ben Chuang > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/host/sdhci.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:11 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > sdhci_start_signal_voltage_switch() should be called only in UHS-I mode, > and not for UHS-II mode. > > Signed-off-by: Ben Chuang > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/host/sdhci.c | 7 ++- > 1 file

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:10 pm, Ben Chuang wrote: > From: Ben Chuang > > In this commit, UHS-II related operations will be called via a function > pointer array, sdhci_uhs2_ops, in order to make UHS-II support as > a kernel module. > This array will be initialized only if CONFIG_MMC_SDHCI_UHS2 is enabled >

Re: [RFC PATCH V3 11/21] mmc: sdhci: UHS-II support, export host operations to core

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:10 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > Export sdhci-specific UHS-II operations to core. > > Signed-off-by: Ben Chuang > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/host/sdhci.c | 70 > 1 file changed, 70

Re: [RFC PATCH V3 10/21] mmc: sdhci: UHS-II support, dump UHS-II registers

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:10 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > Dump UHS-II specific registers, if available, in sdhci_dumpregs() > for informative/debugging use. > > Signed-off-by: Ben Chuang > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/host/sdhci.c | 24

Re: [RFC PATCH V3 09/21] mmc: sdhci: add UHS-II related definitions in headers

2020-08-21 Thread Adrian Hunter
On 10/07/20 2:10 pm, Ben Chuang wrote: > From: AKASHI Takahiro > > Add UHS-II related definitions in shdci.h and sdhci-uhs2.h. > > Signed-off-by: Ben Chuang > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/host/sdhci-uhs2.h | 215 ++ >

Re: [PATCH] mmc: sdhci-acpi: Fix HS400 tuning for AMDI0040

2020-08-19 Thread Adrian Hunter
Signed-off-by: Raul E Rangel If you make amd_sdhci_execute_tuning() static as the robot pointed out: Acked-by: Adrian Hunter > --- > > drivers/mmc/host/sdhci-acpi.c | 68 +-- > 1 file changed, 58 insertions(+), 10 deletions(-) > > diff --git a/drivers/

[PATCH V2 2/2] scsi: ufs: Improve interrupt handling for shared interrupts

2020-08-11 Thread Adrian Hunter
For shared interrupts, the interrupt status might be zero, so check that first. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index bb2543010af9

[PATCH V2 1/2] scsi: ufs: Fix interrupt error message for shared interrupts

2020-08-11 Thread Adrian Hunter
The interrupt might be shared, in which case it is not an error for the interrupt handler to be called when the interrupt status is zero, so don't print the message unless there was enabled interrupt status. Signed-off-by: Adrian Hunter Fixes: 9333d77573485 ("scsi: ufs: Fix irq return

[PATCH] scsi: ufs-pci: Add quirk for broken auto-hibernate for Intel EHL

2020-08-10 Thread Adrian Hunter
Intel EHL UFS host controller advertises auto-hibernate capability but it does not work correctly. Add a quirk for that. Signed-off-by: Adrian Hunter Fixes: 8c09d75276971 ("scsi: ufshdc-pci: Add Intel PCI IDs for EHL") --- drivers/scsi/ufs/ufshcd-pci.c | 16 ++-- driver

[PATCH 2/2] scsi: ufs: Improve interrupt handling for shared interrupts

2020-08-10 Thread Adrian Hunter
For shared interrupts, the interrupt status might be zero, so check that first. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index d7522dba4dcf

[PATCH 1/2] scsi: ufs: Fix interrupt error message for shared interrupts

2020-08-10 Thread Adrian Hunter
The interrupt might be shared, in which case it is not an error for the interrupt handler to be called when the interrupt status is zero, so remove the message print and register dump. Signed-off-by: Adrian Hunter Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code") --- driver

Re: [PATCH] mmc: sdhci-pci-o2micro: fix spelling mistake "unsupport" -> "unsupported"

2020-08-06 Thread Adrian Hunter
+ code author ernest.zhang On 6/08/20 2:50 pm, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_info message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/mmc/host/sdhci-pci-o2micro.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] mmc: sdhci-pci-o2micro: fix spelling mistake "unsupport" -> "unsupported"

2020-08-06 Thread Adrian Hunter
On 6/08/20 3:21 pm, Adrian Hunter wrote: > + code author ernest.zhang That email address bounced, so instead adding shirley her > > On 6/08/20 2:50 pm, Colin King wrote: >> From: Colin Ian King >> >> There is a spelling mistake in a pr_info messag

Re: [PATCH 0/2] perf: Allow closing siblings' file descriptors

2020-08-06 Thread Adrian Hunter
On 8/07/20 6:16 pm, Alexander Shishkin wrote: > Hi guys, > > I've been looking at reducing the number of open file descriptors per perf > session. If we retain one descriptor per event, in a large group they add > up. At the same time, we're not actually using them for anything after the >

Re: [PATCH] mmc: sdhci_am654: Add workaround for card detect debounce timer

2020-08-05 Thread Adrian Hunter
On 5/08/20 11:22 am, Faiz Abbas wrote: > Hi Adrian, > > On 05/08/20 1:44 pm, Adrian Hunter wrote: >> On 30/07/20 2:41 am, Faiz Abbas wrote: >>> There is a one time delay because of a card detect debounce timer in the >>> controller IP. This timer runs as soon

Re: [PATCH] mmc: sdhci_am654: Add workaround for card detect debounce timer

2020-08-05 Thread Adrian Hunter
On 30/07/20 2:41 am, Faiz Abbas wrote: > There is a one time delay because of a card detect debounce timer in the > controller IP. This timer runs as soon as power is applied to the module > regardless of whether a card is present or not and any writes to > SDHCI_POWER_ON will return 0 before it

Re: [PATCH v2 6/6] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-05 Thread Adrian Hunter
K is used > for data timeout by Tegra SDMMC hardware and having TMCLK not enabled > is not recommended. > > So, this patch fixes it. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 41 ++

Re: [PATCH v2 2/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186

2020-08-05 Thread Adrian Hunter
MMC hardware by default uses timeout clock (TMCLK) instead > of SDCLK and this quirk should not be set. > > So, this patch remove this quirk for Tegra186. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 1 - > 1 f

Re: [PATCH v2 1/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-05 Thread Adrian Hunter
10 SDMMC hardware by default uses timeout clock (TMCLK) > instead of SDCLK and this quirk should not be set. > > So, this patch remove this quirk for Tegra210. > > Signed-off-by: Sowjanya Komatineni Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-tegra.c | 1 -

Re: [PATCH] mmc: sdhci_am654: Replace HTTP links with HTTPS ones

2020-08-05 Thread Adrian Hunter
Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Acked-by: Adrian Hunter > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov > ' v5.7..master > > If there are any URLs to be removed compl

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Adrian Hunter
On 4/08/20 4:33 pm, Ian Rogers wrote: > On Tue, Aug 4, 2020 at 3:08 AM Adrian Hunter wrote: >> >> On 28/07/20 11:57 am, Ian Rogers wrote: >>> If events in a group explicitly set a frequency or period with leader >>> sampling, don't disable the samples on t

Re: [PATCH V2 00/12] perf intel-pt: Add support for decoding FUP/TIP only

2020-08-04 Thread Adrian Hunter
On 10/07/20 6:10 pm, Adrian Hunter wrote: > Hi > > Here are some fixes and small improvements for Intel PT. Andi added his "Reviewed-by" with 2 comments to tweak the documentation. The patches still apply, so do you want me to send a V3? > > Changes in V2: &

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-08-04 Thread Adrian Hunter
On 28/07/20 11:57 am, Ian Rogers wrote: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' Might be worth explaining this

Re: [PATCH v2] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event

2020-08-04 Thread Adrian Hunter
ary sample information unnecessarily uses up space in the perf buffer. Acked-by: Adrian Hunter > > Thanks > Jin Yao > > On 7/23/2020 9:01 AM, Jin, Yao wrote: >> Hi Jiri, Adrian, >> >> On 7/22/2020 7:08 PM, Jiri Olsa wrote: >>> On Wed, Jul 22, 2020 at

Re: [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host controller Seabird1

2020-08-03 Thread Adrian Hunter
Sorry, I have been away for a while, but I will look at it shortly. On 3/08/20 10:23 pm, Shirley Her (SC) wrote: > Hi, Adrian: > > Do you have chance to review the patched code? > > Thanks, > Shirley > > > *From:*

[PATCH V2 05/12] perf auxtrace: Add optional error flags to the itrace 'e' option

2020-07-10 Thread Adrian Hunter
Allow the 'e' option to be followed by flags which will affect what errors will or will not be reported. Each flag must be preceded by either '+' or '-'. The flags are: o overflow l trace data lost Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt

[PATCH V2 11/12] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-10 Thread Adrian Hunter
and wrote 57.870 MB perf.data ] $ time perf script --itrace=bi | wc -l 58948289 real1m23.863s user1m23.251s sys 0m7.452s $ time perf script --itrace=biq | wc -l 3385694 real0m4.453s user0m4.455s sys 0m0.328s Signed-off-by: Adrian Hunter --- tools/perf

[PATCH V2 12/12] perf intel-pt: Add support for decoding PSB+ only

2020-07-10 Thread Adrian Hunter
perf script --itrace=biqq | wc -l 1883 real0m0.047s user0m0.043s sys 0m0.009s Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 15 +++ .../util/intel-pt-decoder/intel-pt-decoder.c | 18 ++ 2 files changed, 33 insertions

[PATCH V2 08/12] perf intel-pt: Use itrace debug log flags to suppress some messages

2020-07-10 Thread Adrian Hunter
decreasing the size of the log. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 5 - tools/perf/util/intel-pt.c | 17 ++--- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/tools/perf/Documentation/perf-intel-pt.txt b/

[PATCH V2 10/12] perf auxtrace: Add itrace 'q' option for quicker, less detailed decoding

2020-07-10 Thread Adrian Hunter
The 'q' option is for modes of decoding that are quicker because they skip or omit decoding some aspects of trace data. If supported, the 'q' option may be repeated to increase the effect. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c

[PATCH V2 09/12] perf intel-pt: Time filter logged perf events

2020-07-10 Thread Adrian Hunter
Change the debug logging (when used with the --time option) to time filter logged perf events, but allow that to be overridden by using "d+a" instead of plain "d". That can reduce the size of the log file. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/pe

[PATCH V2 06/12] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-10 Thread Adrian Hunter
ost errors For example, for errors but not overflow or data lost errors: --itrace=e-o-l Suppressing those errors can be useful for testing and debugging because they are not due to decoding. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 9 - tools

[PATCH V2 07/12] perf auxtrace: Add optional log flags to the itrace 'd' option

2020-07-10 Thread Adrian Hunter
Allow the 'd' option to be followed by flags which will affect what debug messages will or will not be reported. Each flag must be preceded by either '+' or '-'. The flags are: a all perf events Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 5 + tools

[PATCH V2 04/12] perf auxtrace: Add missing itrace options to help text

2020-07-10 Thread Adrian Hunter
Add missing itrace options o, G and L. Signed-off-by: Adrian Hunter --- tools/perf/util/auxtrace.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h index 142ccf7d34df..e3ce5fb03ca0 100644 --- a/tools/perf/util

[PATCH V2 02/12] perf intel-pt: Fix duplicate branch after CBR

2020-07-10 Thread Adrian Hunter
r/bin/sleep) Signed-off-by: Adrian Hunter Fixes: 91de8684f1cff ("perf intel-pt: Cater for CBR change in PSB+") Fixes: abe5a1d3e4bee ("perf intel-pt: Decoder to output CBR changes immediately") Cc: sta...@vger.kernel.org --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 8

[PATCH V2 03/12] perf tools: Improve aux_output not supported error

2020-07-10 Thread Adrian Hunter
Error: branch-loads: PMU Hardware doesn't support 'aux_output' feature Signed-off-by: Adrian Hunter --- tools/perf/util/evsel.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 80a7f9862aec..6606c1e3b4fe 100644 --- a/tools/perf/util

[PATCH V2 01/12] perf intel-pt: Fix FUP packet state

2020-07-10 Thread Adrian Hunter
While walking code towards a FUP ip, the packet state is INTEL_PT_STATE_FUP or INTEL_PT_STATE_FUP_NO_TIP. That was mishandled resulting in the state becoming INTEL_PT_STATE_IN_SYNC prematurely. The result was an occasional lost EXSTOP event. Signed-off-by: Adrian Hunter Cc: sta

[PATCH V2 00/12] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-10 Thread Adrian Hunter
Hi Here are some fixes and small improvements for Intel PT. Changes in V2: For d/e flags, use +/- alphabetic options instead of numbers Update help text Improve documentation Adrian Hunter (12): perf intel-pt: Fix FUP packet state perf intel-pt: Fix

Re: [PATCH V7 15/15] perf script: Show text poke address symbol

2020-07-10 Thread Adrian Hunter
On 10/07/20 2:34 pm, Arnaldo Carvalho de Melo wrote: > Em Tue, May 12, 2020 at 03:19:22PM +0300, Adrian Hunter escreveu: >> It is generally more useful to show the symbol with an address. In this >> case, the print function requires the 'machine' which means changing >&g

Re: [PATCH 2/2] mmc: sdhci-of-aspeed: Fix clock divider calculation

2020-07-10 Thread Adrian Hunter
On 9/07/20 10:57 pm, Eddie James wrote: > When calculating the clock divider, start dividing at 2 instead of 1. > The divider is divided by two at the end of the calculation, so starting > at 1 may result in a divider of 0, which shouldn't happen. > > Signed-off-by: Eddie James A

Re: [PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-09 Thread Adrian Hunter
On 9/07/20 9:13 pm, Adrian Hunter wrote: > On 9/07/20 8:50 pm, Andi Kleen wrote: >> On Thu, Jul 09, 2020 at 08:36:22PM +0300, Adrian Hunter wrote: >>> The itrace "e" option may be followed by a number which has the >>> following effect for Intel PT: >

Re: [PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-09 Thread Adrian Hunter
On 9/07/20 8:50 pm, Andi Kleen wrote: > On Thu, Jul 09, 2020 at 08:36:22PM +0300, Adrian Hunter wrote: >> The itrace "e" option may be followed by a number which has the >> following effect for Intel PT: >> 1 Suppress overflow events >> 2

[PATCH 09/11] perf auxtrace: Add itrace 'q' option for quicker, less detailed decoding

2020-07-09 Thread Adrian Hunter
The 'q' option is for modes of decoding that are quicker because they skip or omit decoding some aspects of trace data. If supported, the 'q' option may be repeated to increase the effect. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c

[PATCH 07/11] perf intel-pt: Use itrace debug log flags to suppress some messages

2020-07-09 Thread Adrian Hunter
The "d" option may be followed by a number which has the following effect: 1 Suppress logging of perf events Suppressing perf events is useful for decreasing the size of the log. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 4 +++-

[PATCH 03/11] perf tools: Improve aux_output not supported error

2020-07-09 Thread Adrian Hunter
Error: branch-loads: PMU Hardware doesn't support 'aux_output' feature Signed-off-by: Adrian Hunter --- tools/perf/util/evsel.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 9aa51a65593d..9c5c72094112 100644 --- a/tools/perf/util

[PATCH 08/11] perf intel-pt: Time filter logged perf events

2020-07-09 Thread Adrian Hunter
Change the debug logging (when used with the --time option) to time filter logged perf events, but allow that to be overridden by using "d2" instead of plain "d". By default that can greatly reduce the size of the log file. Signed-off-by: Adrian Hunter --- tools/perf/Docu

[PATCH 06/11] perf auxtrace: Add optional log flags to the itrace 'd' option

2020-07-09 Thread Adrian Hunter
Allow the 'd' option to be followed by an architecture-specific number which flags what kind of debug messages will or will not be logged. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c | 2 ++ tools/perf/util/auxtrace.h

[PATCH 11/11] perf intel-pt: Add support for decoding PSB+ only

2020-07-09 Thread Adrian Hunter
perf script --itrace=biqq | wc -l 1883 real0m0.047s user0m0.043s sys 0m0.009s Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 3 +++ .../util/intel-pt-decoder/intel-pt-decoder.c | 18 ++ 2 files changed, 21 insertions(+) diff

[PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-09 Thread Adrian Hunter
or testing and debugging because they are not due to decoding. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 7 ++- tools/perf/util/intel-pt.c | 12 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/tools/perf/Documentation/

[PATCH 02/11] perf intel-pt: Fix duplicate branch after CBR

2020-07-09 Thread Adrian Hunter
r/bin/sleep) Signed-off-by: Adrian Hunter Fixes: 91de8684f1cff ("perf intel-pt: Cater for CBR change in PSB+") Fixes: abe5a1d3e4bee ("perf intel-pt: Decoder to output CBR changes immediately") Cc: sta...@vger.kernel.org --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 8

[PATCH 04/11] perf auxtrace: Add optional error flags to the itrace 'e' option

2020-07-09 Thread Adrian Hunter
Allow the 'e' option to be followed by an architecture-specific number which flags what kind of errors will or will not be reported. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c | 2 ++ tools/perf/util/auxtrace.h | 2

[PATCH 10/11] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-09 Thread Adrian Hunter
and wrote 57.870 MB perf.data ] $ time perf script --itrace=bi | wc -l 58948289 real1m23.863s user1m23.251s sys 0m7.452s $ time perf script --itrace=biq | wc -l 3385694 real0m4.453s user0m4.455s sys 0m0.328s Signed-off-by: Adrian Hunter --- tools/perf

[PATCH 01/11] perf intel-pt: Fix FUP packet state

2020-07-09 Thread Adrian Hunter
While walking code towards a FUP ip, the packet state is INTEL_PT_STATE_FUP or INTEL_PT_STATE_FUP_NO_TIP. That was mishandled resulting in the state becoming INTEL_PT_STATE_IN_SYNC prematurely. The result was an occasional lost EXSTOP event. Signed-off-by: Adrian Hunter Cc: sta

[PATCH 00/11] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-09 Thread Adrian Hunter
Hi Here are some fixes and small improvements for Intel PT. Adrian Hunter (11): perf intel-pt: Fix FUP packet state perf intel-pt: Fix duplicate branch after CBR perf tools: Improve aux_output not supported error perf auxtrace: Add optional error flags to the itrace 'e

Re: [PATCH V7 00/15] perf/x86: Add perf text poke events

2020-07-08 Thread Adrian Hunter
On 27/05/20 6:54 pm, Peter Zijlstra wrote: > On Wed, May 27, 2020 at 12:47:16PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, May 20, 2020 at 05:56:34PM +0200, Peter Zijlstra escreveu: >>> On Tue, May 19, 2020 at 10:40:01PM -0300, Arnaldo Carvalho de Melo wrote: PeterZ, from what we

Re: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down to basic comment block

2020-07-02 Thread Adrian Hunter
d > function arguments either, we're going to assume that this is > not actually a bona fide kerneldoc use-case. > > Fixes the following W=1 kernel build warning: > > drivers/mmc/host/cqhci.c:163: warning: Function parameter or member > 'cq_host' not described in 'cqhci_host_alloc_

Re: [PATCH v6 3/4] mmc: mediatek: command queue support

2020-07-01 Thread Adrian Hunter
On 9/06/20 4:18 am, Chun-Hung Wu wrote: > Support command queue for mt6779 platform. > a. Add msdc_set_busy_timeout() to calculate emmc write timeout. > b. Connect mtk msdc driver to cqhci driver through >host->cq_host->ops = _cmdq_ops; > c. msdc_cmdq_irq() will link up with cqchi_irq().

Re: [PATCH] mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE_A

2020-07-01 Thread Adrian Hunter
er gets updated with the required > strength value. > > Signed-off-by: Akshu Agrawal Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c &g

Re: 0001-Fix-CQE-task-queue-timeout.patch

2020-07-01 Thread Adrian Hunter
On 22/06/20 8:44 am, chen jiangnan wrote: > From 547e5635c04f4f9d62cbc1e3a4b4527f87c4e83b Mon Sep 17 00:00:00 2001 > From: JiangnanChen  > Date: Mon, 22 Jun 2020 05:32:21 + > Subject: [PATCH] Fix CQE task queue timeout. CQE notifies the software that Please separate subject from commit

<    1   2   3   4   5   6   7   8   9   10   >