[PATCH 18/19] perf tests: Add a test for time-utils

2019-06-04 Thread Adrian Hunter
Test time ranges work as expected. Signed-off-by: Adrian Hunter --- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c| 4 + tools/perf/tests/tests.h | 1 + tools/perf/tests/time-utils-test.c | 234 + 4 files changed, 240

[PATCH 10/19] perf intel-pt: Add support for lookahead

2019-06-04 Thread Adrian Hunter
Implement the lookahead callback to let the decoder access subsequent buffers. intel_pt_lookahead() manages the buffer lifetime and calls the decoder for each buffer until the decoder returns a non-zero value. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt.c | 59

[PATCH 16/19] perf time-utils: Simplify perf_time__parse_for_ranges() error paths slightly

2019-06-04 Thread Adrian Hunter
Simplify perf_time__parse_for_ranges() error paths slightly. Signed-off-by: Adrian Hunter --- tools/perf/util/time-utils.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/time-utils.c b/tools/perf/util/time-utils.c index 3e87c21c293c

[PATCH 07/19] perf intel-pt: Add reposition parameter to intel_pt_get_data()

2019-06-04 Thread Adrian Hunter
When the decoder gets the next trace buffer, some state is reset if the buffer is not consecutive to the previous buffer. Add a parameter 'reposition' so that can be done also to support a "fast forward" facility. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt

[PATCH 13/19] perf time-utils: Factor out set_percent_time()

2019-06-04 Thread Adrian Hunter
Factor out set_percent_time() so it can be reused. Signed-off-by: Adrian Hunter --- tools/perf/util/time-utils.c | 39 +--- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/tools/perf/util/time-utils.c b/tools/perf/util/time-utils.c index

[PATCH 05/19] perf intel-pt: Factor out intel_pt_8b_tsc()

2019-06-04 Thread Adrian Hunter
Factor out intel_pt_8b_tsc() so it can be reused. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 26 --- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel

[PATCH 01/19] perf auxtrace: Add perf time interval to itrace_synth_ops

2019-06-04 Thread Adrian Hunter
Instruction trace decoders can optimize output based on what time intervals will be filtered, so pass that information in itrace_synth_ops. Signed-off-by: Adrian Hunter --- tools/perf/util/auxtrace.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tools

[PATCH 14/19] perf time-utils: Prevent percentage time range overlap

2019-06-04 Thread Adrian Hunter
Prevent percentage time range overlap. This is only a 1 nanosecond change but makes the results more logical e.g. a sample cannot be in both the first 10% and the second 20%. Note, there is a later patch that adds a test for time-utils. Signed-off-by: Adrian Hunter --- tools/perf/util/time

[PATCH 15/19] perf time-utils: Fix --time documentation

2019-06-04 Thread Adrian Hunter
Correct some punctuation and spelling and correct the format to show that the time resolution is nanoseconds not microseconds. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-diff.txt | 6 +++--- tools/perf/Documentation/perf-report.txt | 6 +++--- tools/perf/Documentation/perf

[PATCH 08/19] perf intel-pt: Add intel_pt_fast_forward()

2019-06-04 Thread Adrian Hunter
n at a PSB, "fast forward" stops at the last PSB that has a timestamp before the target timestamp. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 130 ++ .../util/intel-pt-decoder/intel-pt-decoder.h | 2 + 2 files changed, 132 inser

[PATCH 06/19] perf intel-pt: Factor out intel_pt_reposition()

2019-06-04 Thread Adrian Hunter
Factor out intel_pt_reposition() so it can be reused. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util

[PATCH 00/19] perf intel-pt: Add support for efficient time interval filtering

2019-06-04 Thread Adrian Hunter
l time ranges needed to support the time intervals. Adrian Hunter (19): perf auxtrace: Add perf time interval to itrace_synth_ops perf script: Set perf time interval in itrace_synth_ops perf report: Set perf time interval in itrace_synth_ops perf intel-pt: Add lookahead callback

Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script

2019-06-04 Thread Adrian Hunter
On 31/05/19 7:45 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, May 20, 2019 at 11:45:16AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Mon, May 20, 2019 at 02:37:07PM +0300, Adrian Hunter escreveu: >>> Commit 4eb068157121 ("perf script: Make itrace script default

Re: [PATCH v2 2/2] mmc: sdhci-milbeaut: add Milbeaut SD controller driver

2019-06-04 Thread Adrian Hunter
Adrian who maintains > SDHCI drivers, to allow him to provide some input. Looks OK. Could address the output of: scripts/checkpatch.pl --strict And the "readl(host->ioaddr + SDHCI_INT_STATUS) == 0x" thing only makes sense for PCI. Nevertheless: Acked-by: Adrian Hunter

Re: [PATCH 8/9] mmc: sdhci-sprd: Add PHY DLL delay configuration

2019-06-03 Thread Adrian Hunter
On 20/05/19 1:12 PM, Baolin Wang wrote: > Set the PHY DLL delay for each timing mode, which is used to sample the clock > accurately and make the clock more stable. > > Signed-off-by: Baolin Wang One comment, nevertheless: Acked-by: Adrian Hunter > --- > drivers/mmc/host/s

Re: [PATCH 6/9] mmc: sdhci-sprd: Enable PHY DLL to make clock stable

2019-06-03 Thread Adrian Hunter
higher clock. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c | 44 > - > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/m

Re: [PATCH 5/9] mmc: sdhci-sprd: Add HS400 enhanced strobe mode

2019-06-03 Thread Adrian Hunter
On 20/05/19 1:11 PM, Baolin Wang wrote: > Add HS400 enhanced strobe mode support for Spreadtrum SD host controller. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c | 32 > 1 file chan

Re: [PATCH 4/9] mmc: sdhci-sprd: Implement the get_max_timeout_count() interface

2019-06-03 Thread Adrian Hunter
On 20/05/19 1:11 PM, Baolin Wang wrote: > Implement the get_max_timeout_count() interface to set the Spredtrum SD > host controller actual maximum timeout count. > > Signed-off-by: Baolin Wang Seems surprising that there isn't a custom ->set_timeout() as well. Nevertheless: A

Re: [PATCH 3/9] mmc: sdhci-sprd: Add optional gate clock support

2019-06-03 Thread Adrian Hunter
On 20/05/19 1:11 PM, Baolin Wang wrote: > For the Spreadtrum SC9860 platform, we should enable another gate clock > '2x_enable' to make the SD host controller work well. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/s

Re: [PATCH 1/9] mmc: sdhci-sprd: Check the enable clock's return value correctly

2019-06-03 Thread Adrian Hunter
On 20/05/19 1:11 PM, Baolin Wang wrote: > Missed to check the enable clock's return value, fix it. > > Signed-off-by: Baolin Wang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-sprd.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 18/22] perf scripts python: exported-sql-viewer.py: Add IPC information to the Branch reports

2019-06-02 Thread Adrian Hunter
On 31/05/19 7:44 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, May 20, 2019 at 02:37:24PM +0300, Adrian Hunter escreveu: >> Enhance the "All branches" and "Selected branches" reports to display IPC >> information if it is available. > > So, testing this I

Re: [PATCH] mmc: sdhci-pci: remove redundant check of slots == 0

2019-05-31 Thread Adrian Hunter
> Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-pci-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c > b/drivers/mmc/host/sdh

[tip:perf/core] perf intel-pt: Rationalize intel_pt_sync_switch()'s use of next_tid

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: 14f1cfd4f7b4794e2f9d2ae214bcf049654b0b5c Gitweb: https://git.kernel.org/tip/14f1cfd4f7b4794e2f9d2ae214bcf049654b0b5c Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:30 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf intel

[tip:perf/core] perf intel-pt: Improve sync_switch by processing PERF_RECORD_SWITCH* in events

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: c7b4f15ff79b539fed4c382e52e988548081bc9d Gitweb: https://git.kernel.org/tip/c7b4f15ff79b539fed4c382e52e988548081bc9d Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:29 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf intel

[tip:perf/core] perf scripts python: export-to-postgresql.py: Add support for pyside2

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: 3cd3216dbb421244b96b992f193e778a3baa2220 Gitweb: https://git.kernel.org/tip/3cd3216dbb421244b96b992f193e778a3baa2220 Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:27 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf

[tip:perf/core] perf scripts python: export-to-sqlite.py: Add support for pyside2

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: bfb3170e2481b76a4f8aae94176e45d681a37f3e Gitweb: https://git.kernel.org/tip/bfb3170e2481b76a4f8aae94176e45d681a37f3e Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:26 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Add support for pyside2

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: df8ea22a8fd9e4e8502f4fa917622801e1b4d09e Gitweb: https://git.kernel.org/tip/df8ea22a8fd9e4e8502f4fa917622801e1b4d09e Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:25 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Use argparse module for argument parsing

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: 1ed7f47fd3af3c09d2cd64d1aff1c5b96d238111 Gitweb: https://git.kernel.org/tip/1ed7f47fd3af3c09d2cd64d1aff1c5b96d238111 Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:24 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Change python2 to python

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: c6aba1bf258ff1ce201f112dafe1bdde601573dd Gitweb: https://git.kernel.org/tip/c6aba1bf258ff1ce201f112dafe1bdde601573dd Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:23 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:45 -0300 perf

[tip:perf/core] perf intel-pt: Fix itrace defaults for perf script intel-pt documentation

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: a2d8a1585e35444789c1c8cf7e2e51fb15589880 Gitweb: https://git.kernel.org/tip/a2d8a1585e35444789c1c8cf7e2e51fb15589880 Author: Adrian Hunter AuthorDate: Mon, 20 May 2019 14:37:09 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:42 -0300 perf intel

[tip:perf/core] perf auxtrace: Fix itrace defaults for perf script

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: 355200e0f6a9ce14771625014aa469f5ecbd8977 Gitweb: https://git.kernel.org/tip/355200e0f6a9ce14771625014aa469f5ecbd8977 Author: Adrian Hunter AuthorDate: Mon, 20 May 2019 14:37:08 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:42 -0300 perf

[tip:perf/core] perf intel-pt: Fix itrace defaults for perf script

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: 26f19c2eb7e54015564ff133b91983a74e84541b Gitweb: https://git.kernel.org/tip/26f19c2eb7e54015564ff133b91983a74e84541b Author: Adrian Hunter AuthorDate: Mon, 20 May 2019 14:37:07 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:42 -0300 perf intel

[tip:perf/core] perf-with-kcore.sh: Always allow fix_buildid_cache_permissions

2019-05-30 Thread tip-bot for Adrian Hunter
Commit-ID: a685c7a4a25c80f1f022b55830f2d894ee8847eb Gitweb: https://git.kernel.org/tip/a685c7a4a25c80f1f022b55830f2d894ee8847eb Author: Adrian Hunter AuthorDate: Fri, 12 Apr 2019 14:38:28 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 May 2019 18:37:42 -0300 perf

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Adrian Hunter
On 28/05/19 2:21 PM, Arend Van Spriel wrote: > > > On 5/28/2019 12:04 PM, Adrian Hunter wrote: >> On 26/05/19 9:42 PM, Arend Van Spriel wrote: >>> On 5/18/2019 12:54 AM, Douglas Anderson wrote: >>>> Normally when the MMC core sees an "-EILSEQ&

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Adrian Hunter
On 26/05/19 9:42 PM, Arend Van Spriel wrote: > On 5/18/2019 12:54 AM, Douglas Anderson wrote: >> Normally when the MMC core sees an "-EILSEQ" error returned by a host >> controller then it will trigger a retuning of the card.  This is >> generally a good idea. > > Probably a question for Adrian,

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-27 Thread Adrian Hunter
On 27/05/19 12:37 PM, Brian Masney wrote: > On Sun, May 26, 2019 at 03:58:19PM -0400, Brian Masney wrote: >> I attached a patch that shows how I was able to determine what had >> already claimed the host. > On Mon, May 27, 2019 at 10:48:24AM +0300, Adrian Hunter wrote: >&g

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-27 Thread Adrian Hunter
: >>>> On Fri, May 24, 2019 at 03:17:13PM +0300, Adrian Hunter wrote: >>>>> On 24/05/19 2:10 PM, Brian Masney wrote: >>>>>> WiFi stopped working on the LG Nexus 5 phone and the issue was bisected >>>>>> to the commit c07a48c26519 ("mmc

Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done()

2019-05-24 Thread Adrian Hunter
On 24/05/19 2:10 PM, Brian Masney wrote: > WiFi stopped working on the LG Nexus 5 phone and the issue was bisected > to the commit c07a48c26519 ("mmc: sdhci: Remove finish_tasklet") that > moved from using a tasklet to a work queue. That patch also changed > sdhci_irq() to return IRQ_WAKE_THREAD

[PATCH 05/22] perf intel-pt: Accumulate cycle count from CYC packets

2019-05-20 Thread Adrian Hunter
the decoder is walking is reached. In addition, the cycle count is not accurate for any but the first branch of a TNT packet. Signed-off-by: Adrian Hunter --- .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 14 +- .../perf/util/intel-pt-decoder/intel-pt-decoder.h | 1 + 2 files

[PATCH 02/22] perf auxtrace: Fix itrace defaults for perf script

2019-05-20 Thread Adrian Hunter
$ perf script --itrace=cepwx > cmp2.txt $ diff -sq cmp1.txt cmp2.txt Files cmp1.txt and cmp2.txt differ After: $ perf script --itrace > cmp1.txt $ perf script --itrace=cepwx > cmp2.txt $ diff -sq cmp1.txt cmp2.txt Files cmp1.txt and cmp2.txt are identical Signed-off-by: Adrian Hunte

[PATCH 04/22] perf intel-pt: Factor out intel_pt_update_sample_time

2019-05-20 Thread Adrian Hunter
To eliminate some duplication and make the code more understandable, factor out intel_pt_update_sample_time. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/perf/util

[PATCH 12/22] perf intel-pt: Document IPC usage

2019-05-20 Thread Adrian Hunter
Add brief documentation about instructions-per-cycle (IPC) information derived from Intel PT. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/intel-pt.txt | 30 +++ 1 file changed, 30 insertions(+) diff --git a/tools/perf/Documentation/intel-pt.txt b/tools

[PATCH 14/22] perf db-export: Add brief documentation

2019-05-20 Thread Adrian Hunter
Add brief documentation to explain how the database export maintains backward and forward compatibility. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/db-export.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 tools/perf/Documentation/db

[PATCH 13/22] perf thread-stack: Accumulate IPC information

2019-05-20 Thread Adrian Hunter
Cycle and instruction counts are added to the stack. The IPC of a function and all functions it calls, is also recorded. Signed-off-by: Adrian Hunter --- tools/perf/util/thread-stack.c | 14 ++ tools/perf/util/thread-stack.h | 4 2 files changed, 18 insertions(+) diff --git

[PATCH 09/22] perf intel-pt: Record when decoding PSB+ packets

2019-05-20 Thread Adrian Hunter
In preparation for using MTC packets to count cycles, record whether decoding is between a PSB and PSBEND packets. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 41 ++- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/tools/perf

[PATCH 20/22] perf scripts python: exported-sql-viewer.py: Add IPC information to Call Graph Graph

2019-05-20 Thread Adrian Hunter
Enhance the call graph to display IPC information if it is available. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 69 +++ 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b

[PATCH 22/22] perf scripts python: exported-sql-viewer.py: Select find text when find bar is activated

2019-05-20 Thread Adrian Hunter
. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py index 94489cf2ce0e..6e7934f2ac9a 100755 --- a/tools/perf/scripts

[PATCH 21/22] perf scripts python: exported-sql-viewer.py: Add IPC information to Call Tree

2019-05-20 Thread Adrian Hunter
Enhance the call tree to display IPC information if it is available. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 69 +++ 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools

[PATCH 16/22] perf scripts python: export-to-sqlite.py: Export IPC information

2019-05-20 Thread Adrian Hunter
Export cycle and instruction counts on samples and calls tables. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/export-to-sqlite.py | 36 --- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf

[PATCH 10/22] perf intel-pt: Re-factor TIP cases in intel_pt_walk_to_ip

2019-05-20 Thread Adrian Hunter
To make it easier to add new code for different TIP cases, separate each case. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 23 ++- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/intel-pt-decoder/intel-pt

[PATCH 18/22] perf scripts python: exported-sql-viewer.py: Add IPC information to the Branch reports

2019-05-20 Thread Adrian Hunter
Enhance the "All branches" and "Selected branches" reports to display IPC information if it is available. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 102 ++ 1 file changed, 83 insertions(+), 19 deletions(-) diff --git

[PATCH 03/22] perf intel-pt: Fix itrace defaults for perf script intel-pt documentation

2019-05-20 Thread Adrian Hunter
Fix intel-pt documentation to reflect the change of itrace defaults for perf script. Signed-off-by: Adrian Hunter Fixes: 4eb068157121 ("perf script: Make itrace script default to all calls") Cc: sta...@vger.kernel.org --- tools/perf/Documentation/intel-pt.txt | 10 +- 1 file

[PATCH 15/22] perf db-export: Export IPC information

2019-05-20 Thread Adrian Hunter
Export cycle and instruction counts on samples and call-returns. Signed-off-by: Adrian Hunter --- tools/perf/util/scripting-engines/trace-event-python.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools

[PATCH 11/22] perf intel-pt: Accumulate cycle count from TSC/TMA/MTC packets

2019-05-20 Thread Adrian Hunter
been "lost", typically due to mwait, which is indicated by a TSC/TMA packet that is not part of PSB+. Signed-off-by: Adrian Hunter --- .../util/intel-pt-decoder/intel-pt-decoder.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/tools/perf/util/intel-pt-decode

[PATCH 17/22] perf scripts python: export-to-postgresql.py: Export IPC information

2019-05-20 Thread Adrian Hunter
Export cycle and instruction counts on samples and calls tables. Signed-off-by: Adrian Hunter --- .../scripts/python/export-to-postgresql.py| 36 --- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/tools/perf/scripts/python/export-to-postgresql.py b/tools

[PATCH 19/22] perf scripts python: exported-sql-viewer.py: Add CallGraphModelParams

2019-05-20 Thread Adrian Hunter
Add a parameter to call graph and call tree, to determine whether IPC information is available. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 73 +++ 1 file changed, 41 insertions(+), 32 deletions(-) diff --git a/tools/perf/scripts/python

[PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script

2019-05-20 Thread Adrian Hunter
rf script > cmp1.txt $ perf script --itrace=cepwx > cmp2.txt $ diff -sq cmp1.txt cmp2.txt Files cmp1.txt and cmp2.txt are identical Signed-off-by: Adrian Hunter Fixes: 90e457f7be08 ("perf tools: Add Intel PT support") Cc: sta...@vger.kernel.org # v4.20+ --- tools/perf

[PATCH 08/22] perf script: Add output of IPC ratio

2019-05-20 Thread Adrian Hunter
cycles are due to the time to enter the kernel, not the actual kernel page fault handler. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-script.txt | 5 - tools/perf/builtin-script.c | 23 ++- 2 files changed, 26 insertions(+), 2 deletions

[PATCH 06/22] perf tools: Add IPC information to perf_sample

2019-05-20 Thread Adrian Hunter
Add counts of instructions and cycles, in order to represent instructions-per-cycle (IPC). Signed-off-by: Adrian Hunter --- tools/perf/util/event.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h index 9e999550f247..1f1da6082806 100644

[PATCH 07/22] perf intel-pt: Add support for samples to contain IPC ratio

2019-05-20 Thread Adrian Hunter
of cycles since the last update, and thus represent the average IPC since the last IPC value. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c index

[PATCH 00/22] perf intel-pt: Add support for instructions-per-cycle (IPC)

2019-05-20 Thread Adrian Hunter
en there are patches to export IPC including un-related patch 14 "perf db-export: Add brief documentation" and un-related patch 22 "perf scripts python: exported-sql-viewer.py: Select find text when find bar is activated" Adrian Hunter (22): perf intel-pt: Fix itrace defaults

[tip:perf/core] perf intel-pt: Fix sample timestamp wrt non-taken branches

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 1b6599a9d8e6c9f7e9b0476012383b1777f7fc93 Gitweb: https://git.kernel.org/tip/1b6599a9d8e6c9f7e9b0476012383b1777f7fc93 Author: Adrian Hunter AuthorDate: Fri, 10 May 2019 15:41:43 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 16 May 2019 14:17:24 -0300 perf intel

[tip:perf/core] perf intel-pt: Fix improved sample timestamp

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 61b6e08dc8e3ea80b7485c9b3f875ddd45c8466b Gitweb: https://git.kernel.org/tip/61b6e08dc8e3ea80b7485c9b3f875ddd45c8466b Author: Adrian Hunter AuthorDate: Fri, 10 May 2019 15:41:42 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 16 May 2019 14:17:23 -0300 perf intel

[tip:perf/core] perf intel-pt: Fix instructions sampling rate

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 7ba8fa20e26eb3c0c04d747f7fd2223694eac4d5 Gitweb: https://git.kernel.org/tip/7ba8fa20e26eb3c0c04d747f7fd2223694eac4d5 Author: Adrian Hunter AuthorDate: Fri, 10 May 2019 15:41:41 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 16 May 2019 14:17:23 -0300 perf intel

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Add 'About' dialog box

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: b62d18aba1109506c1926ab7b564c4ac3bd48786 Gitweb: https://git.kernel.org/tip/b62d18aba1109506c1926ab7b564c4ac3bd48786 Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:28 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Add context menu

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 9bc4e4bfe6169343a8f019cd5d7843a558b78363 Gitweb: https://git.kernel.org/tip/9bc4e4bfe6169343a8f019cd5d7843a558b78363 Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:27 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Add copy to clipboard

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 96c43b9a7ab3b70bc35d762f7b76082dfd118a6a Gitweb: https://git.kernel.org/tip/96c43b9a7ab3b70bc35d762f7b76082dfd118a6a Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:26 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Add tree level

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 3ac641f4acd66c109b74f108f8a61f2905702b10 Gitweb: https://git.kernel.org/tip/3ac641f4acd66c109b74f108f8a61f2905702b10 Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:25 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Fix error when shrinking / enlarging font

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: 4b2084537e5f3b58337bce894391fb63bf3b0e28 Gitweb: https://git.kernel.org/tip/4b2084537e5f3b58337bce894391fb63bf3b0e28 Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:23 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

[tip:perf/core] perf scripts python: exported-sql-viewer.py: Move view creation

2019-05-18 Thread tip-bot for Adrian Hunter
Commit-ID: be6e747136a4dc8aad99259e47fd6f7362a43996 Gitweb: https://git.kernel.org/tip/be6e747136a4dc8aad99259e47fd6f7362a43996 Author: Adrian Hunter AuthorDate: Fri, 3 May 2019 15:08:24 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 May 2019 16:36:47 -0300 perf scripts

Re: [RFC PATCH 2/2] mmc: sdhci: Quirk for AMD SDHC Device 0x7906

2019-05-13 Thread Adrian Hunter
On 12/05/19 8:04 PM, S-k, Shyam-sundar wrote: > On 5/2/2019 12:02 PM, Adrian Hunter wrote: >> Cc: some AMD people >> >> On 1/05/19 8:54 PM, Raul E Rangel wrote: >>> AMD SDHC 0x7906 requires a hard reset to clear all internal state. >>> Otherwise it can ge

[PATCH 3/3] perf intel-pt: Fix sample timestamp wrt non-taken branches

2019-05-10 Thread Adrian Hunter
then also. Note that commit 3f04d98e972b5 ("perf intel-pt: Improve sample timestamp") was also a stable fix and appears, for example, in v4.4 stable tree as commit a4ebb58fd124 ("perf intel-pt: Improve sample timestamp"). Signed-off-by: Adrian Hunter Fixes: 3f04d98e972b (&qu

[PATCH 0/3] perf intel-pt: Intel PT fixes

2019-05-10 Thread Adrian Hunter
Hi Here are 3 non-urgent fixes for Intel PT. Adrian Hunter (3): perf intel-pt: Fix instructions sampling rate perf intel-pt: Fix improved sample timestamp perf intel-pt: Fix sample timestamp wrt non-taken branches .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 31

[PATCH 1/3] perf intel-pt: Fix instructions sampling rate

2019-05-10 Thread Adrian Hunter
(/lib/x86_64-linux-gnu/ld-2.28.so) ls 13812 [003] 2167315.222728: 16479 instructions:u: 7fac71e2477a _dl_map_object_deps+0x1ba (/lib/x86_64-linux-gnu/ld-2.28.so) ... Signed-off-by: Adrian Hunter Fixes: f4aa081949e7b ("perf tools: Add Intel PT decoder") Cc: sta...@vger.

[PATCH 2/3] perf intel-pt: Fix improved sample timestamp

2019-05-10 Thread Adrian Hunter
stable fix and appears, for example, in v4.4 stable tree as commit a4ebb58fd124 ("perf intel-pt: Improve sample timestamp"). Signed-off-by: Adrian Hunter Fixes: 3f04d98e972b5 ("perf intel-pt: Improve sample timestamp") Cc: sta...@vger.kernel.org # v4.4+ --- tools/perf/util/intel

Re: [PATCH v2 3/3] mmc: sdhci_am654: Fix SLOTTYPE write

2019-05-10 Thread Adrian Hunter
On 10/05/19 6:42 AM, Faiz Abbas wrote: > In the call to regmap_update_bits() for SLOTTYPE, the mask and value > fields are exchanged. Fix this. This didn't have any affect on the > driver because this was a NOP and it was taking the correct value from > the bootloader. > > Cc: stable Except

Re: [PATCH v2 2/2] mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-09 Thread Adrian Hunter
ing bug existed since the driver was first introduced but there is no need for this driver to be supported in kernel versions that old. > > Cc: sta...@vger.kernel.org # v4.12+ > Signed-off-by: Trac Hoang > Signed-off-by: Scott Branden Acked-by: Adrian Hunter > --- > drivers/m

Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write

2019-05-08 Thread Adrian Hunter
On 7/05/19 7:27 PM, Faiz Abbas wrote: > Hi Adrian, > > On 26/04/19 11:30 AM, Adrian Hunter wrote: >> On 25/04/19 6:57 PM, Faiz Abbas wrote: >>> In the call to regmap_update_bits() for SLOTTYPE, the mask and value >>> fields are exchanged. Fix this. >> >&g

Re: [PATCH 2/2] mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-07 Thread Adrian Hunter
On 8/05/19 1:46 AM, Scott Branden wrote: > Hi Adrian, > > On 2019-05-06 11:31 p.m., Adrian Hunter wrote: >> On 6/05/19 8:01 PM, Scott Branden wrote: >>> From: Trac Hoang >>> >>> The iproc host eMMC/SD controller hold time does not meet the >>>

Re: [PATCH 1/2] mmc: sdhci-iproc: cygnus: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-07 Thread Adrian Hunter
the falling clock edges rather than the > rising clock edges. > > This change applies only to the Cygnus platform. > > Fixes: c833e92bbb60 ("mmc: sdhci-iproc: support standard byte register > accesses") > Signed-off-by: Trac Hoang > Signed-off-by: Scott Bran

Re: [PATCH 2/2] mmc: sdhci-iproc: Set NO_HISPD bit to fix HS50 data hold time problem

2019-05-07 Thread Adrian Hunter
On 6/05/19 8:01 PM, Scott Branden wrote: > From: Trac Hoang > > The iproc host eMMC/SD controller hold time does not meet the > specification in the HS50 mode. This problem can be mitigated > by disabling the HISPD bit; thus forcing the controller output > data to be driven on the falling clock

Re: [PATCH] mmc: block: Fix memory leak in blk-mq when cleaning up

2019-05-06 Thread Adrian Hunter
On 4/05/19 2:35 AM, Douglas Anderson wrote: > If I run the following on rk3288-veyron-minnie (a 2GB machine) > > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 3000); do > echo "" $i > echo ff0f.dwmmc > unbind > sleep .5 > echo

[PATCH 2/6] perf scripts python: exported-sql-viewer.py: Move view creation

2019-05-03 Thread Adrian Hunter
As preparation for adding support for copying to clipboard, create view in TreeWindowBase instead of derived classes. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/scripts

[PATCH 5/6] perf scripts python: exported-sql-viewer.py: Add context menu

2019-05-03 Thread Adrian Hunter
Add a context menu (right-click) that provides options for copying to clipboard, including, for trees, the ability to copy only the cell under the mouse pointer. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 41 +++ 1 file changed, 41

[PATCH 4/6] perf scripts python: exported-sql-viewer.py: Add copy to clipboard

2019-05-03 Thread Adrian Hunter
Add support for copying to clipboard. Two menu options are added to copy the selected rows / columns with normal spacing, or as comma-separated-values. In the case of trees, only entire rows can be copied. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql-viewer.py | 217

[PATCH 3/6] perf scripts python: exported-sql-viewer.py: Add tree level

2019-05-03 Thread Adrian Hunter
As preparation for adding support for copying to clipboard, keep track of what level each item is in tree items. Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 4 1 file changed, 4 insertions(+) diff --git a/tools/perf/scripts/python/exported-sql

[PATCH 0/6] perf scripts python: exported-sql-viewer.py: Minor improvements

2019-05-03 Thread Adrian Hunter
Hi Here are a some minor improvememnts to exported-sql-viewer.py The patches go on top of the pyside2 support patches, here: https://lore.kernel.org/lkml/20190412113830.4126-1-adrian.hun...@intel.com Adrian Hunter (6): perf scripts python: exported-sql-viewer.py: Fix error when

[PATCH 6/6] perf scripts python: exported-sql-viewer.py: Add 'About' dialog box

2019-05-03 Thread Adrian Hunter
With support for Python 2 or 3 and PySide 1 or 2 (Qt 4 or 5), it is useful to see what versions are in use. Add an 'About' dialog box that displays Python, PySide, Qt and database server (SQLite or PostgreSQL) version numbers. Signed-off-by: Adrian Hunter --- .../scripts/python/exported-sql

[PATCH 1/6] perf scripts python: exported-sql-viewer.py: Fix error when shrinking / enlarging font

2019-05-03 Thread Adrian Hunter
bute 'view' Signed-off-by: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py index c586abfb2b46..28

Re: [PATCH] mmc: Fix tag set memory leak

2019-05-03 Thread Adrian Hunter
s: 81196976ed94 ("mmc: block: Add blk-mq support") Acked-by: Adrian Hunter > --- > I found this using kmemleak and plugging and unplugging an SD card in a > few times. > > Here is an example of the output of kmemleak: > unreferenced object 0x888125be4ce8 (size

Re: [RFC PATCH 2/2] mmc: sdhci: Quirk for AMD SDHC Device 0x7906

2019-05-02 Thread Adrian Hunter
Cc: some AMD people On 1/05/19 8:54 PM, Raul E Rangel wrote: > AMD SDHC 0x7906 requires a hard reset to clear all internal state. > Otherwise it can get into a bad state where the DATA lines are always > read as zeros. > > This change requires firmware that can transition the device into >

Re: [PATCH 0/8] perf scripts python: Support pyside2 and misc Intel PT

2019-04-29 Thread Adrian Hunter
On 12/04/19 2:38 PM, Adrian Hunter wrote: > Hi > > Here are patches to add support for pyside2 to the db-export scripts, > and a couple of Intel PT patches. > > > Adrian Hunter (8): > perf scripts python: exported-sql-viewer.py: Change python2 to python >

Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write

2019-04-26 Thread Adrian Hunter
On 25/04/19 6:57 PM, Faiz Abbas wrote: > In the call to regmap_update_bits() for SLOTTYPE, the mask and value > fields are exchanged. Fix this. Could you also comment on whether this has any known effect on the driver. > > Signed-off-by: Faiz Abbas > --- > drivers/mmc/host/sdhci_am654.c | 4

Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations

2019-04-25 Thread Adrian Hunter
On 25/04/19 6:57 PM, Faiz Abbas wrote: > Fix the following minor things: > > 1. Line wrapping with the regmap_*() functions is way more conservative > than required by the 80 character rule. Expand the function calls out to > use less number of lines. > > 2. Add an error message if the DLL fails

Re: [PATCH 06/12] perf tools: Do not erase uncovered maps by kcore

2019-04-23 Thread Adrian Hunter
On 16/04/19 7:01 PM, Jiri Olsa wrote: > Maps in kcore do not cover bpf maps, so we can't just > remove everything. Keeping all kernel maps, which are > not covered by kcore maps. Memory for jited-bpf is allocated from the same area that is used for modules. In the case of /proc/kcore, that

Re: [PATCH v1 0/4] Add tracing for SDHCI register access

2019-04-18 Thread Adrian Hunter
On 12/04/19 5:50 PM, Raul Rangel wrote: > On Fri, Apr 12, 2019 at 09:26:44AM +0300, Adrian Hunter wrote: >> On 12/04/19 1:08 AM, Raul E Rangel wrote: >>> I was debugging a SDHC hardware bug and got tired of having to >>> translate the register values by hand. Thi

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-17 Thread Adrian Hunter
On 17/04/19 9:51 AM, Jiri Olsa wrote: > On Wed, Apr 17, 2019 at 09:35:32AM +0300, Adrian Hunter wrote: >> On 16/04/19 7:01 PM, Jiri Olsa wrote: >>> The eBPF program can be loaded multiple times >>> with the same name (tag). We can share dso >>> objects for

Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects

2019-04-17 Thread Adrian Hunter
On 16/04/19 7:01 PM, Jiri Olsa wrote: > The eBPF program can be loaded multiple times > with the same name (tag). We can share dso > objects for those programs. Doesn't a eBPF program get recompiled differently every time it is loaded? > > Link:

[tip:perf/urgent] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

2019-04-16 Thread tip-bot for Adrian Hunter
Commit-ID: 6e4b1cac30d297718218dc268199ed20df074b98 Gitweb: https://git.kernel.org/tip/6e4b1cac30d297718218dc268199ed20df074b98 Author: Adrian Hunter AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 16 Apr 2019 11:27:05 -0300 perf scripts

Re: [RFC] mmc: cqhci: clear pending interrupt and halt

2019-04-16 Thread Adrian Hunter
On 16/04/19 10:27 AM, Peng Fan wrote: > Hi Adrian, > >> >> On 16/04/19 9:48 AM, Peng Fan wrote: >>> On i.MX8MM, we are running Dual Linux OS, with 1st Linux using SD Card >>> as rootfs storage, 2nd Linux using eMMC as rootfs storage. We let the >>> the 1st linux configure power/clock for the 2nd

<    3   4   5   6   7   8   9   10   11   12   >