RE: [EXT] Re: [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory

From: Greg KH Sent: Wednesday, October 28, 2020 3:07 PM > On Wed, Oct 28, 2020 at 06:05:28AM +, Sherry Sun wrote: > > Hi Greg, > > > > > Subject: Re: [PATCH V5 0/2] Change vring space from nomal memory to > > > dma coherent memory > > > > > > On Wed, Oct 28, 2020 at 10:03:03AM +0800, Sherry

RE: [EXT] Re: [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory

From: Greg KH Sent: Wednesday, October 28, 2020 7:14 PM > On Wed, Oct 28, 2020 at 10:17:39AM +0000, Andy Duan wrote: > > From: Greg KH Sent: Wednesday, October > > 28, 2020 3:07 PM > > > On Wed, Oct 28, 2020 at 06:05:28AM +, Sherry Sun wrote: > > > > Hi

RE: [PATCH v2 tty] tty: serial: fsl_lpuart: LS1021A has a FIFO size of 16 words, like LS1028A

From: Vladimir Oltean Sent: Friday, October 23, 2020 9:34 AM > Prior to the commit that this one fixes, the FIFO size was derived from the > read-only register LPUARTx_FIFO[TXFIFOSIZE] using the following > formula: > > TX FIFO size = 2 ^ (LPUARTx_FIFO[TXFIFOSIZE] - 1) > > The documentation

RE: [EXT] [PATCH] tty: serial: fsl_lpuart: LS1021A has a FIFO size of 32 datawords

ing for fields TXFIFOSIZE and RXFIFOSIZE is the same for > LS1028A as for LS1021A. > > The RXFIFOSIZE in the Layerscape SoCs is fixed at this value: > 101 Receive FIFO/Buffer depth = 32 datawords. > > When Andy Duan wrote the commit in Fixes: below, he assumed that the 101 > enc

RE: [PATCH] tty: serial: fsl_lpuart: fix lpuart32_poll_get_char

From: Peng Fan Sent: Tuesday, September 29, 2020 5:55 PM > The watermark is set to 1, so we need to input two chars to trigger RDRF using > the original logic. With the new logic, we could always get the char when > there > is data in FIFO. > > Suggested-by: Fugang Duan > Signed-off-by: Peng

RE: [EXT] Re: [PATCH] net: fec: Keep device numbering consistent with datasheet

From: David Miller Sent: Thursday, September 24, 2020 4:32 AM > From: Stefan Riedmueller > Date: Wed, 23 Sep 2020 16:25:28 +0200 > > > From: Christian Hemp > > > > Make use of device tree alias for device enumeration to keep the > > device order consistent with the naming in the datasheet. >

RE: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in fec_time_keep()

From: Zhang Changzhong Sent: Monday, September 14, 2020 9:14 PM > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/freescale/fec_ptp.c:523:6: warning: > variable 'ns' set but not used [-Wunused-but-set-variable] > 523 | u64 ns; > | ^~ > > After commit

RE: [PATCH net-next] net: ethernet: fec: remove redundant null check before clk_disable_unprepare()

From: Zhang Changzhong Sent: Monday, September 7, 2020 8:50 PM > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just remove > them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong

RE: [EXT] Re: [PATCH v1 0/5] imx6qp QuadPlus: support improved enet clocking

From: Shawn Guo Sent: Monday, August 17, 2020 3:17 PM > On Sun, Jul 12, 2020 at 08:25:07PM -0400, Sven Van Asbroeck wrote: > > On the imx6qp QuadPlus, the h/w designers have improved enet clocking. > > > > This patchset extends the clock tree to reflect the situation on QuadPlus. > > > > This

RE: [EXT] [PATCH net-next v2 0/4] net: fec: a few improvements

From: Sergey Organov Sent: Wednesday, July 15, 2020 11:43 PM > This is a collection of simple improvements that reduce and/or simplify code. > They got developed out of attempt to use DP83640 PTP PHY connected to > built-in FEC (that has its own PTP support) of the iMX 6SX micro-controller. >

RE: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()

From: Sergey Organov Sent: Wednesday, July 8, 2020 4:49 PM > Andy Duan writes: > > > From: Sergey Organov Sent: Tuesday, July 7, 2020 > > 10:43 PM > >> Andy Duan writes: > >> > >> > From: Sergey Organov Sent: Monday, July 6, > >> &

RE: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()

From: Sergey Organov Sent: Tuesday, July 7, 2020 10:43 PM > Andy Duan writes: > > > From: Sergey Organov Sent: Monday, July 6, 2020 > 10:26 PM > >> Code of the form "if(x) x = 0" replaced with "x = 0". > >> > >> Code of the fo

RE: [EXT] Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

From: Sven Van Asbroeck Sent: Tuesday, July 7, 2020 11:21 PM > Andy, Fabio, > > Sounds like we now have a solution which makes logical sense, although it > requires changes and additions to drivers/clk/imx/. Before I create a patch, > can you read the plan below and check that it makes sense,

RE: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()

From: Sergey Organov Sent: Monday, July 6, 2020 10:26 PM > Code of the form "if(x) x = 0" replaced with "x = 0". > > Code of the form "if(x == a) x = a" removed. > > Signed-off-by: Sergey Organov > --- > drivers/net/ethernet/freescale/fec_ptp.c | 4 +--- > 1 file changed, 1 insertion(+), 3

RE: [EXT] [PATCH 2/5] net: fec: enable to use PPS feature without time stamping

From: Sergey Organov Sent: Monday, July 6, 2020 10:26 PM > PPS feature could be useful even when hardware time stamping of network > packets is not in use, so remove offending check for this condition from > fec_ptp_enable_pps(). If hardware time stamping of network packets is not in use, PPS is

RE: [EXT] Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

From: Sven Van Asbroeck Sent: Monday, July 6, 2020 11:00 PM > On Mon, Jul 6, 2020 at 10:58 AM Sven Van Asbroeck > wrote: > > > > Hi Fabio, > > > > On Mon, Jul 6, 2020 at 9:46 AM Fabio Estevam > wrote: > > > > > > Would it make sense to use compatible = "mmio-mux"; like we do on > > > imx7s,

RE: [EXT] Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

From: Sven Van Asbroeck Sent: Sunday, July 5, 2020 11:34 PM > > ext phy-| \ > | | > enet_ref-o--|M |pad--| \ >| |_/ | | >| |M |mac_gtx >| | | >

RE: [EXT] Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

From: Sven Van Asbroeck > Hi Fabio, Andy, > > On Thu, Jul 2, 2020 at 6:29 PM Fabio Estevam wrote: > > > > With the device tree approach, I think that a better place to touch > > GPR5 would be inside the fec driver. > > > > Are we 100% sure this is the best way forward, though? > > All the FEC

RE: [EXT] Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

From: Sven Van Asbroeck Sent: Friday, July 3, 2020 8:51 AM > Hi Fabio, > > On Thu, Jul 2, 2020 at 6:29 PM Fabio Estevam wrote: > > > > With the device tree approach, I think that a better place to touch > > GPR5 would be inside the fec driver. > > > > Cool idea. I notice that the latest FEC

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Sven Van Asbroeck Sent: Wednesday, July 1, 2020 9:52 PM > Andy, Fabio, > > Does the following describe the mainline situation? > Please correct if not. > > 1. imx6 ethernet ref_clk can be generated internally (by imx6) or >externally (by PHY or oscillator on PCB) 2. if internal,

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Fabio Estevam Sent: Wednesday, July 1, 2020 11:39 AM > Hi Andy, > > On Wed, Jul 1, 2020 at 12:18 AM Andy Duan wrote: > > > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > > @@ -202,6 +202,8 @@ > > {

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Sven Van Asbroeck Sent: Tuesday, June 30, 2020 11:24 PM > Andy, Fabio, > > On Tue, Jun 30, 2020 at 2:36 AM Andy Duan wrote: > > > > Sven, no matter PHY supply 125Mhz clock to pad or not, GPR5[9] is to > > select RGMII gtx clock source from: > > - 0 Cloc

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Fabio Estevam Sent: Tuesday, June 30, 2020 7:49 PM > Hi Andy, > > On Tue, Jun 30, 2020 at 3:36 AM Andy Duan wrote: > > > Fabio, our QA double verify 5.4.24_2.1.0, no matter SD boot or > > tftp/nfs boot, both work fine on i.MX6QP sabresd board, please double

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Sven Van Asbroeck Sent: Monday, June 29, 2020 10:37 PM > On Mon, Jun 29, 2020 at 10:26 AM Fabio Estevam > wrote: > > > > Just tested 5.4.24_2.1.0 on an imx6qp sabresd and DHCP also fails there. > > I think I discovered the problem ! > > When I compare the sabresd devicetree on mainline

RE: [EXT] Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Fabio Estevam Sent: Monday, June 29, 2020 10:26 PM > Hi Sven, > > On Mon, Jun 29, 2020 at 10:40 AM Sven Van Asbroeck > wrote: > > > Thank you for testing this out on a different platform ! > > > > I had a look at how things are done in the Freescale fork of the > > kernel > >

RE: [EXT] [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

> - Fabio Estevam: use of_machine_is_compatible() to determine if we > are running on an imx6 plus. > > To: Shawn Guo > To: Andy Duan > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-ar

RE: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Sven Van Asbroeck Sent: Wednesday, June 24, 2020 10:56 AM > Hi Andy, > > On Tue, Jun 23, 2020 at 9:40 PM Andy Duan wrote: > > > > The patch looks good. > > Reviewed-by: Fugang Duan > > Thank you ! > > To check we're on a plus, the patch uses: &

RE: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

From: Shawn Guo Sent: Tuesday, June 23, 2020 7:54 PM > Hi Fugang, > > Can you take a look at this patch? Thanks! > The patch looks good. Reviewed-by: Fugang Duan > Shawn > > On Sat, Jun 13, 2020 at 04:17:03PM -0400, Sven Van Asbroeck wrote: > > On imx6, the ethernet reference clock

RE: [EXT] Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails

From: David Miller Sent: Tuesday, June 16, 2020 4:42 AM > From: Navid Emamdoost > Date: Sun, 14 Jun 2020 00:38:01 -0500 > > > in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs, > > fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which > > increments the counter even

RE: [EXT] [PATCH] i2c: busses: Fix a reference count leak.

From: wu000...@umn.edu Sent: Sunday, June 14, 2020 6:12 AM > From: Qiushi Wu > > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus call pm_runtime_put_noidle() if > pm_runtime_get_sync() fails. > > Fixes: 13d6eb20fc79 ("i2c: imx-lpi2c: add

RE: [EXT] [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error

From: Dinghao Liu Sent: Monday, June 1, 2020 2:17 PM > pm_runtime_get_sync() increments the runtime PM usage counter even the > call returns an error code. Thus a corresponding decrement is needed on the > error handling path to keep the counter balanced. > > Fix this by adding the missed

RE: [PATCH 0/4] Change i.MX/MXS SoCs ocotp/iim node name to efuse

From: Anson Huang Sent: Thursday, May 28, 2020 11:13 AM > In the nvmem yaml schema, it requires the nodename to be one of > "eeprom|efuse|nvram", so need to change all i.MX/MXS SoCs ocotp/iim node > name to efuse: > > MXS platforms: i.MX23/28; > i.MX platforms with IIM: i.MX25/27/31/35/51/53. >

RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

From: Shawn Guo Sent: Wednesday, May 13, 2020 4:50 PM > On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK > > ethernet function can work now. > > > > Signed-off-by: Fugang Duan

RE: [EXT] [PATCH v1 3/3] tty: serial: lpuart: Add RS485 support for 32-bit uart flavour

From: Philippe Schenker Sent: Wednesday, October 16, 2019 11:19 PM > This commits adds RS485 support for LPUART hardware that uses 32-bit > registers. These are typically found in i.MX8 processors. > > Signed-off-by: Philippe Schenker Reviewed-by: Fugang Duan > > --- > >

RE: [EXT] [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

From: Philippe Schenker Sent: Wednesday, October 16, 2019 11:19 PM > Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function > > Signed-off-by: Philippe Schenker Reviewed-by: Fugang Duan > --- > > drivers/tty/serial/fsl_lpuart.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

RE: [EXT] [PATCH v1 1/3] tty: serial: lpuart: Remove unnecessary code from set_mctrl

From: Philippe Schenker Sent: Wednesday, October 16, 2019 11:19 PM > Currently flow control is not working due to lpuart32_set_mctrl that is > clearing TXCTSE bit in all cases. This bit gets earlier setup by > lpuart32_set_termios. > > As I read in Documentation set_mctrl is also not meant for

RE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message

From: Anson Huang Sent: Wednesday, October 9, 2019 6:16 PM > Failed to get irq using name is NOT fatal as driver will use index to get irq > instead, use platform_get_irq_byname_optional() instead of > platform_get_irq_byname() to avoid below error message during > probe: > > [0.819312] fec

RE: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() to avoid error message

From: Anson Huang Sent: Wednesday, October 9, 2019 6:16 PM > Use platform_get_irq_byname_optional() and platform_get_irq_optional() > instead of platform_get_irq_byname() and platform_get_irq() for optional > IRQs to avoid below error message during probe: > > [0.795803] fec

RE: [EXT] [PATCH v3] serial: imx: adapt rx buffer and dma periods

From: Philipp Puschmann Sent: Friday, September 20, 2019 3:06 PM > Am 20.09.19 um 05:42 schrieb Andy Duan: > > From: Philipp Puschmann Sent: Thursday, > > September 19, 2019 10:51 PM > >> Using only 4 DMA periods for UART RX is very few if we have a high > >> fr

RE: [EXT] [PATCH v3] serial: imx: adapt rx buffer and dma periods

From: Philipp Puschmann Sent: Thursday, September 19, 2019 10:51 PM > Using only 4 DMA periods for UART RX is very few if we have a high frequency > of small transfers - like in our case using Bluetooth with many small packets > via UART - causing many dma transfers but in each only filling a

RE: [EXT] [PATCH v4 0/3] Fix UART DMA freezes for i.MX SOCs

From: Philipp Puschmann Sent: Thursday, September 19, 2019 10:30 PM > For some years and since many kernel versions there are reports that RX > UART DMA channel stops working at one point. So far the usual workaround > was to disable RX DMA. This patches fix the underlying problem. > > When a

RE: [EXT] Re: [PATCH 0/4] Fix UART DMA freezes for iMX6

From: Philipp Puschmann Sent: Monday, September 16, 2019 9:55 PM > Hi Fabio, > > Am 12.09.19 um 20:23 schrieb Fabio Estevam: > > Hi Philipp, > > > > Thanks for submitting these fixes. > > > > On Wed, Sep 11, 2019 at 11:50 AM Philipp Puschmann > > wrote: > >> > >> For some years and since many

RE: [PATCH v2 net-next] net: fec: add C45 MDIO read/write support

From: Marco Hartman Sent: Wednesday, August 21, 2019 7:44 PM > IEEE 802.3ae clause 45 defines a modified MDIO protocol that uses a two > staged access model in order to increase the address space. > > This patch adds support for C45 MDIO read and write accesses, which are > used whenever the

RE: [EXT] Re: [PATCH net-next 0/1] net: fec: add C45 MDIO read/write support

From: Andrew Lunn Sent: Tuesday, August 20, 2019 9:04 PM > On Tue, Aug 20, 2019 at 02:32:26AM +0000, Andy Duan wrote: > > From: Andrew Lunn > > > On Mon, Aug 19, 2019 at 05:11:14PM +, Marco Hartmann wrote: > > > > As of yet, the Fast Ethernet Control

RE: [EXT] Re: [PATCH net-next 0/1] net: fec: add C45 MDIO read/write support

From: Andrew Lunn > On Mon, Aug 19, 2019 at 05:11:14PM +, Marco Hartmann wrote: > > As of yet, the Fast Ethernet Controller (FEC) driver only supports > > Clause 22 conform MDIO transactions. IEEE 802.3ae Clause 45 defines a > > modified MDIO protocol that uses a two staged access model in

RE: [PATCH net-next 1/1] fec: add C45 MDIO read/write support

From: Marco Hartmann Sent: Tuesday, August 20, 2019 1:11 AM > IEEE 802.3ae clause 45 defines a modified MDIO protocol that uses a two > staged access model in order to increase the address space. > > This patch adds support for C45 MDIO read and write accesses, which are > used whenever the

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

From: Srinivas Kandagatla Sent: Tuesday, August 6, 2019 6:04 PM > On 04/07/2019 15:20, fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > > i.MX8QM platform support. > > > > Signed-off-by: Fugang Duan > > --- > >

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

From: Srinivas Kandagatla Sent: Tuesday, August 6, 2019 6:04 PM > On 04/07/2019 15:20, fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > > i.MX8QM platform support. > > > > Signed-off-by: Fugang Duan > > --- > >

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

From: Sven Van Asbroeck Sent: Wednesday, July 17, 2019 8:48 PM > On Tue, Jul 16, 2019 at 9:32 PM Andy Duan wrote: > > > > Yes, so the old legacy code is kept there. But it is better to clean > > up all if there have enough boards to verify them. > > Would it ma

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

From: Sven Van Asbroeck Sent: Tuesday, July 16, 2019 9:19 PM > Hi Andy, > > On Mon, Jul 15, 2019 at 10:02 PM Andy Duan > wrote: > > > > the phylib already can handle mii bus reset and phy device reset > > That's a great suggestion, thank you !! I completel

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

From: Sven Van Asbroeck Sent: Tuesday, July 16, 2019 5:05 AM > The current fec driver allows the PHY to be reset via a gpio, specified in the > devicetree. However, some PHYs need to be reset in a more complex way. > > To accommodate such PHYs, allow an optional reset controller in the fec >

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

From: gre...@linuxfoundation.org Sent: Monday, July 15, 2019 3:37 PM > On Mon, Jul 15, 2019 at 05:34:47AM +0000, Andy Duan wrote: > > Ping... > > It's the middle of the merge window, we can't do anything with any patches > until after that. Please be patient. > > gre

RE: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

Ping ... > From: Fugang Duan > > iMX8 fuse word index represent as one 4-bytes word, it should not be divided > by 4. > > Exp: > - MAC0 address layout in fuse: > offset 708: MAC[3] MAC[2] MAC[1] MAC[0] > offset 709: XX xx MAC[5] MAC[4] > > Signed-off-by: Fugang Duan > --- >

RE: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

Ping... > From: Fugang Duan > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > i.MX8QM platform support. > > Signed-off-by: Fugang Duan > --- > drivers/nvmem/imx-ocotp-scu.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

From: Andy Duan Sent: Friday, July 5, 2019 3:33 PM > From: Lothar Waßmann Sent: Friday, July 5, 2019 > 3:13 PM > > Hi, > > > > On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote: > > > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > > >

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

From: Lothar Waßmann Sent: Friday, July 5, 2019 3:13 PM > Hi, > > On Fri, 5 Jul 2019 02:46:32 +0000 Andy Duan wrote: > > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > > From: Lothar Waßmann Sent: Thursday, July > > > 4, > > > 2019 11:46 PM

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > From: Lothar Waßmann Sent: Thursday, July 4, > 2019 11:46 PM > > Hi, > > > > On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@nxp.com wrote: > > > From: Fugang Duan > > > > > > iMX8 fuse

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

From: Lothar Waßmann Sent: Thursday, July 4, 2019 11:46 PM > Hi, > > On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > iMX8 fuse word index represent as one 4-bytes word, it should not be > > divided by 4. > > > > Exp: > > - MAC0 address layout in

RE: [EXT] [PATCH 73/87] ethernet: freescale: Remove memset after dma_alloc_coherent

From: Fuqian Huang Sent: Friday, June 28, 2019 1:47 AM > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of > git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang Acked-by:

RE: [EXT] Re: Issue: regmap: use debugfs even when no device

From: Mark Brown Sent: Wednesday, May 29, 2019 7:16 PM > To: Andy Duan > Cc: da...@lechnology.com; raf...@kernel.org; Robby Cai > ; gre...@linuxfoundation.org; linux-kernel > > Subject: Re: [EXT] Re: Issue: regmap: use debugfs even when no device > > On Wed, May 29, 201

RE: [EXT] Re: Issue: regmap: use debugfs even when no device

From: Mark Brown Sent: Tuesday, May 28, 2019 9:27 PM > On Tue, May 28, 2019 at 02:20:15AM +0000, Andy Duan wrote: > > > So on i.MX8MM/8QM/8QXP platforms, we catch the issue that user dump > > regmap registers without power cause system hang. > > Maybe revert the

RE: [EXT] Re: [PATCHv2 1/2] ARM: dts: imx6sx: Use MX6SX_CLK_ENET for fec 'ahb' clock

From: Fabio Estevam > Hi Andy, > > On Sun, May 5, 2019 at 5:15 AM Andy Duan wrote: > > > Nack the patch ! > > ... > > Secondly, for your issue you caught, which was fixed by patch: > > commit d7c3a206e6338e4ccdf030719dec028e26a521d5 > > Author: Andy

RE: [PATCHv2 1/2] ARM: dts: imx6sx: Use MX6SX_CLK_ENET for fec 'ahb' clock

> +< > IMX6SX_CLK_ENET>, > > > > Yes, there is really no IMX6SX_CLK_ENET_AHB as per the Refernce Manual > > and it is the same we do on imx6qdl.dtsi: > > > > Reviewed-by: Fabio Estevam Nack the patch ! Firstly, i.MX6SX has ENET AHB bus cl

RE: [PATCH] net: fec: get regulator optional

From: Stefan Agner Sent: Monday, January 21, 2019 10:59 PM > According to the device tree binding the phy-supply property is optional. Use > the regulator_get_optional API accordingly. The code already handles NULL > just fine. > > This gets rid of the following warning: > fec

RE: iMX6 FEC driver Linux-fslc 4.17 - IPV6 Multicast not working when unplugging/plugging ethernet cable

From: Stefano Cappa > Hi everyone, > I already posted this in NXP forum as a comment > (https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fco > mmunity.nxp.com%2Fthread%2F359397data=02%7C01%7Cfugang.dua > n%40nxp.com%7C189d5cad534e470a162508d66c068de2%7C686ea1d3bc2b >

RE: [PATCH] serial: imx: restore handshaking irq for imx1

From: Uwe Kleine-König Sent: 2018年9月20日 20:11 > Back in 2015 when irda was dropped from the driver imx1 was broken. > This change reintroduces the support for the third interrupt of the UART. > > Fixes: afe9cbb1a6ad ("serial: imx: drop support for IRDA") > Signed-off-by: Uwe Kleine-König > ---

RE: [PATCH] serial: imx: restore handshaking irq for imx1

From: Uwe Kleine-König Sent: 2018年9月20日 20:11 > Back in 2015 when irda was dropped from the driver imx1 was broken. > This change reintroduces the support for the third interrupt of the UART. > > Fixes: afe9cbb1a6ad ("serial: imx: drop support for IRDA") > Signed-off-by: Uwe Kleine-König > ---

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

From: Lucas Stach Sent: 2018年9月20日 18:42 > Am Donnerstag, den 20.09.2018, 10:33 + schrieb Andy Duan: > > From: Lucas Stach Sent: 2018年9月20日 > 17:40 > > > Am Donnerstag, den 20.09.2018, 08:39 + schrieb Robin Gong: > > > > > -Original Message--

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

From: Lucas Stach Sent: 2018年9月20日 18:42 > Am Donnerstag, den 20.09.2018, 10:33 + schrieb Andy Duan: > > From: Lucas Stach Sent: 2018年9月20日 > 17:40 > > > Am Donnerstag, den 20.09.2018, 08:39 + schrieb Robin Gong: > > > > > -Original Message--

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

From: Lucas Stach Sent: 2018年9月20日 17:40 > Am Donnerstag, den 20.09.2018, 08:39 + schrieb Robin Gong: > > > -Original Message- > > > From: Uwe Kleine-König > > > Sent: 2018年9月20日 15:55 > > > To: Robin Gong > > > Cc: jsl...@suse.com

RE: [PATCH v1] tty: serial: imx: enable IDDMAEN for the last tail data

From: Lucas Stach Sent: 2018年9月20日 17:40 > Am Donnerstag, den 20.09.2018, 08:39 + schrieb Robin Gong: > > > -Original Message- > > > From: Uwe Kleine-König > > > Sent: 2018年9月20日 15:55 > > > To: Robin Gong > > > Cc: jsl...@suse.com

RE: [PATCH -next] serial: imx: remove set but not used variable 'rtsirq'

iants have a single combined irq. > > The correct fix for the warning would be to restore that request_irq. > > -- > Regards, > Leonard Yes, your explain is very correct! Thanks for your comment. We should restore rtsirq request that for i.MX1. Regards, Andy Duan

RE: [PATCH -next] serial: imx: remove set but not used variable 'rtsirq'

iants have a single combined irq. > > The correct fix for the warning would be to restore that request_irq. > > -- > Regards, > Leonard Yes, your explain is very correct! Thanks for your comment. We should restore rtsirq request that for i.MX1. Regards, Andy Duan

RE: [RFC] Configure i.MX6 RGMII pad group control registers from device tree

From: A.s. Dong Sent: 2018年6月24日 12:24 > Copy Andy & Frank, > > > -Original Message- > > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > > Sent: Tuesday, June 12, 2018 11:10 PM > > To: linux-g...@vger.kernel.org > > Cc: linux-arm-ker...@lists.infradead.org; Shawn Guo > > ; Sascha

RE: [RFC] Configure i.MX6 RGMII pad group control registers from device tree

From: A.s. Dong Sent: 2018年6月24日 12:24 > Copy Andy & Frank, > > > -Original Message- > > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > > Sent: Tuesday, June 12, 2018 11:10 PM > > To: linux-g...@vger.kernel.org > > Cc: linux-arm-ker...@lists.infradead.org; Shawn Guo > > ; Sascha

RE: [PATCH, net-next] net: ethernet: freescale: fix false-positive string overflow warning

From: Arnd Bergmann Sent: 2018年5月28日 23:50 > While compile-testing on arm64 with gcc-8.1, I ran into a build diagnostic: > > drivers/net/ethernet/freescale/fec_main.c: In function 'fec_probe': > drivers/net/ethernet/freescale/fec_main.c:3517:25: error: '%d' directive > writing between 1 and 10

RE: [PATCH, net-next] net: ethernet: freescale: fix false-positive string overflow warning

From: Arnd Bergmann Sent: 2018年5月28日 23:50 > While compile-testing on arm64 with gcc-8.1, I ran into a build diagnostic: > > drivers/net/ethernet/freescale/fec_main.c: In function 'fec_probe': > drivers/net/ethernet/freescale/fec_main.c:3517:25: error: '%d' directive > writing between 1 and 10

RE: [PATCH net-next] net: fec: remove stale comment

> From: YueHaibing Sent: 2018年5月24日 19:27 > This comment is outdated as fec_ptp_ioctl has been replaced by > fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement > the SIOCGHWTSTAMP ioctl") > > Signed-off-by: YueHaibing Thanks.

RE: [PATCH net-next] net: fec: remove stale comment

> From: YueHaibing Sent: 2018年5月24日 19:27 > This comment is outdated as fec_ptp_ioctl has been replaced by > fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement > the SIOCGHWTSTAMP ioctl") > > Signed-off-by: YueHaibing Thanks. Acked-by: Fugang Duan > --- >

RE: [PATCH net-next v3 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

From: Florian Fainelli Sent: 2018年5月18日 4:08 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- >

RE: [PATCH net-next v3 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

From: Florian Fainelli Sent: 2018年5月18日 4:08 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- > drivers/net/ethernet/freescale/Kconfig| 2 +- > drivers/net/ethernet/freescale/fec.h | 2

RE: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

From: Florian Fainelli Sent: 2018年5月16日 7:56 > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in

RE: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

From: Florian Fainelli Sent: 2018年5月16日 7:56 > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in drivers that strictly

RE: [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

From: Florian Fainelli Sent: 2018年5月16日 7:48 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- >

RE: [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

From: Florian Fainelli Sent: 2018年5月16日 7:48 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- > drivers/net/ethernet/freescale/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

RE: WARNING: CPU: 0 PID: 0 at ./include/linux/netfilter.h:233 arp_rcv

From: Marco Franchi Sent: Friday, January 05, 2018 11:03 PM >Hi, > >I am getting the following warning on a imx6ul-evk board running linux-next >20180105: > >[9.233290] [ cut here ] >[9.242068] WARNING: CPU: 0 PID: 0 at

RE: WARNING: CPU: 0 PID: 0 at ./include/linux/netfilter.h:233 arp_rcv

From: Marco Franchi Sent: Friday, January 05, 2018 11:03 PM >Hi, > >I am getting the following warning on a imx6ul-evk board running linux-next >20180105: > >[9.233290] [ cut here ] >[9.242068] WARNING: CPU: 0 PID: 0 at >./include/linux/netfilter.h:233

RE: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

icet...@vger.kernel.org; linux- >ker...@vger.kernel.org; Andy Duan <fugang.d...@nxp.com> >Subject: Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux >headers > >On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: >> From: Fugang Duan <fugang.d

RE: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

From: Rob Herring Sent: Saturday, January 06, 2018 12:45 AM >To: Stefan Agner >Cc: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam >; mark.rutl...@arm.com; linux-arm- >ker...@lists.infradead.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org; Andy Dua

RE: [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner Sent: Monday, December 11, 2017 8:17 PM >This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH >when the refclk is generated by the FSL. > >This patchset depends on the "phylib: Add device reset GPIO support" patch >submitted by Geert

RE: [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner Sent: Monday, December 11, 2017 8:17 PM >This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH >when the refclk is generated by the FSL. > >This patchset depends on the "phylib: Add device reset GPIO support" patch >submitted by Geert

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

From: Richard Leitner <richard.leit...@skidata.com> Sent: Wednesday, December 06, 2017 4:12 PM >To: Andy Duan <fugang.d...@nxp.com>; Richard Leitner <d...@g0hl1n.net>; >robh...@kernel.org; mark.rutl...@arm.com; and...@lunn.ch; >f.faine...@gmail.com; frowand.l...@gmail.c

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

From: Richard Leitner Sent: Wednesday, December 06, 2017 4:12 PM >To: Andy Duan ; Richard Leitner ; >robh...@kernel.org; mark.rutl...@arm.com; and...@lunn.ch; >f.faine...@gmail.com; frowand.l...@gmail.com >Cc: da...@davemloft.net; geert+rene...@glider.be; >sergei.shtyl...@cogentem

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

From: Richard Leitner Sent: Tuesday, December 05, 2017 9:26 PM >Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning >the refclk on and off again during operation (according to their datasheet). >Nonetheless exactly this behaviour was introduced for power saving

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

From: Richard Leitner Sent: Tuesday, December 05, 2017 9:26 PM >Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning >the refclk on and off again during operation (according to their datasheet). >Nonetheless exactly this behaviour was introduced for power saving reasons >by

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, November 20, 2017 8:55 PM >On 11/20/2017 11:35 AM, Andy Duan wrote: >> From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, >> November 20, 2017 5:57 PM >>> To: Andy Duan <fug

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner Sent: Monday, November 20, 2017 8:55 PM >On 11/20/2017 11:35 AM, Andy Duan wrote: >> From: Richard Leitner Sent: Monday, >> November 20, 2017 5:57 PM >>> To: Andy Duan ; f.faine...@gmail.com; >>> and...@lunn.ch >>> Cc: Richa

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, November 20, 2017 5:57 PM >To: Andy Duan <fugang.d...@nxp.com>; f.faine...@gmail.com; >and...@lunn.ch >Cc: Richard Leitner <d...@g0hl1n.net>; net...@vger.kernel.org; linux- >ker...@vger.kernel.org &g

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner Sent: Monday, November 20, 2017 5:57 PM >To: Andy Duan ; f.faine...@gmail.com; >and...@lunn.ch >Cc: Richard Leitner ; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC >LAN871

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Richard Leitner <d...@g0hl1n.net> Sent: Monday, November 20, 2017 4:34 PM >To: f.faine...@gmail.com; Andy Duan <fugang.d...@nxp.com>; >and...@lunn.ch >Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; >richard.leit...@skidata.com >Subject: [PATCH v2 3

  1   2   >