Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet

On Sun, 1 Nov 2020 at 08:20, Jernej Skrabec wrote: > > RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in > ethernet node. > > Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable > ethernet") > Signed-off-by: Jernej Skrabec Hi Jernej, Tested-by: Marcus

Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset

On Wed, 16 Oct 2019 at 10:04, Maxime Ripard wrote: > > On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > On the newer SoCs the offset is used to set the mode of the > > connection. As it is to be used elsewhere then it makes sense > > to move

Re: [PATCH v6 2/7] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets

On Wed, 16 Oct 2019 at 10:06, Maxime Ripard wrote: > > Hi, > > On Wed, Oct 16, 2019 at 09:07:35AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Newer SoCs like the H6 have the channel offset bits in a different > > position to what is on the H3. As we will eventually add

Re: [PATCH] ASoC: sun4i-i2s: incorrect regmap for A83t

On Fri, 30 Aug 2019 at 13:45, Mark Brown wrote: > > On Wed, Aug 21, 2019 at 06:23:20PM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Fixes: 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T") > > Signed-off-by: Marcus Cooper > > --- > > This doesn't apply against current

Re: [PATCH v6 2/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On Tue, 27 Aug 2019 at 11:34, Maxime Ripard wrote: > > On Mon, Aug 26, 2019 at 08:07:33PM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > On the newer SoCs such as the H3 and A64 this is set by default > > to transfer a 0 after each sample in each slot. However the A10 > > and

Re: [PATCH v6 3/3] ASoC: sun4i-i2s: Adjust LRCLK width

On Tue, 27 Aug 2019 at 09:01, Maxime Ripard wrote: > > On Mon, Aug 26, 2019 at 08:07:34PM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Some codecs such as i2s based HDMI audio and the Pine64 DAC require > > a different amount of bit clocks per frame than what is calculated

Re: [linux-sunxi] [PATCH v6 1/3] ASoC: sun4i-i2s: incorrect regmap for A83T

On Tue, 27 Aug 2019 at 10:01, Chen-Yu Tsai wrote: > > On Tue, Aug 27, 2019 at 1:55 PM Code Kipper wrote: > > > > On Tue, 27 Aug 2019 at 06:13, Chen-Yu Tsai wrote: > > > > > > On Tue, Aug 27, 2019 at 2:07 AM wrote: > > > > > > > > F

Re: [linux-sunxi] [PATCH v6 1/3] ASoC: sun4i-i2s: incorrect regmap for A83T

On Tue, 27 Aug 2019 at 06:13, Chen-Yu Tsai wrote: > > On Tue, Aug 27, 2019 at 2:07 AM wrote: > > > > From: Marcus Cooper > > > > The regmap configuration is set up for the legacy block on the > > A83T whereas it uses the new block with a larger register map. > > Looking at the code Allwinner

Re: [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

On Wed, 14 Aug 2019 at 08:09, wrote: > > From: Jernej Skrabec > > I2S doesn't work if parent rate couldn't be change. Difference between > wanted and actual rate is too big. > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > Signed-off-by: Jernej Skrabec Signed-off-by: Marcus

Re: [linux-sunxi] [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

ThanksI've added to my next patch series but if you could add it when applying that would be great. BR, CK On Wed, 21 Aug 2019 at 06:07, Chen-Yu Tsai wrote: > > On Wed, Aug 14, 2019 at 2:09 PM wrote: > > > > From: Jernej Skrabec > > > > I2S doesn't work if parent rate couldn't be change.

Re: [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > Hi, > > On Wed, Aug 14, 2019 at 08:08:41AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Codecs without a control connection such as i2s based HDMI audio and > > the Pine64 DAC require a different amount of bit clocks

Re: [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On Wed, 14 Aug 2019 at 11:30, Mark Brown wrote: > > On Wed, Aug 14, 2019 at 08:08:41AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Codecs without a control connection such as i2s based HDMI audio and > > the Pine64 DAC require a different amount of bit clocks per frame

Re: [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > Hi, > > On Wed, Aug 14, 2019 at 08:08:40AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > On the newer SoCs such as the H3 and A64 this is set by default > > to transfer a 0 after each sample in each slot. However the A10

Re: [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs

On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > On Wed, Aug 14, 2019 at 08:08:43AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > There is a need to support more formats on the newer SoCs(H3 and later). > > Extend the formats supported to include DSP_A and DSP_B modes.

Re: [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality

On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > On Wed, Aug 14, 2019 at 08:08:51AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > The i2s block supports multi-lane i2s output however this functionality > > is only possible in earlier SoCs where the pins are exposed and

Re: [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S

On Wed, 14 Aug 2019 at 09:57, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:50 CEST je codekip...@gmail.com > napisal(a): > > From: Jernej Skrabec > > > > H6 I2S is very similar to that in H3, except it supports up to 16 > > channels. > > > > Signed-off-by: Jernej Skrabec

Re: [linux-sunxi] [PATCH v5 14/15] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support

On Wed, 14 Aug 2019 at 10:28, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:53 CEST je codekip...@gmail.com > napisal(a): > > From: Marcus Cooper > > > > Extend the functionality of the driver to include support of 20 and > > 24 bits per sample for the earlier SoCs. > > >

Re: [linux-sunxi] [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

On Wed, 14 Aug 2019 at 10:38, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:54 CEST je codekip...@gmail.com > napisal(a): > > From: Marcus Cooper > > > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > > to reflect this. > > > > Signed-off-by:

Re: [linux-sunxi] [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On Tue, 4 Jun 2019 at 09:53, Chen-Yu Tsai wrote: > > On Tue, Jun 4, 2019 at 1:47 AM wrote: > > > > From: Marcus Cooper > > > > On the newer SoCs this is set by default to transfer a 0 after > > each sample in each slot. However the platform that this driver > > was developed on had the default

Re: [linux-sunxi] Re: [PATCH v4 6/9] ASoC: sun4i-i2s: Add multi-lane functionality

On Tue, 4 Jun 2019 at 11:02, Christopher Obbard wrote: > > On Tue, 4 Jun 2019 at 09:43, Code Kipper wrote: > > > > On Tue, 4 Jun 2019 at 09:58, Maxime Ripard > > wrote: > > > > > > On Mon, Jun 03, 2019 at 07:47:32PM +0200, codekip...@gm

Re: [PATCH v4 4/9] ASoC: sun4i-i2s: Reduce quirks for sun8i-h3

On Tue, 4 Jun 2019 at 09:46, Maxime Ripard wrote: > > On Mon, Jun 03, 2019 at 07:47:30PM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > We have a number of flags used to identify the functionality > > of the IP block found on the sun8i-h3 and later devices. As it > > is only

Re: [PATCH v4 6/9] ASoC: sun4i-i2s: Add multi-lane functionality

On Tue, 4 Jun 2019 at 09:58, Maxime Ripard wrote: > > On Mon, Jun 03, 2019 at 07:47:32PM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > The i2s block supports multi-lane i2s output however this functionality > > is only possible in earlier SoCs where the pins are exposed and

Re: [linux-sunxi] Re: [PATCH v4 1/9] ASoC: sun4i-i2s: Fix sun8i tx channel offset mask

On Tue, 4 Jun 2019 at 09:39, Chen-Yu Tsai wrote: > > On Tue, Jun 4, 2019 at 3:34 PM Maxime Ripard > wrote: > > > > On Mon, Jun 03, 2019 at 07:47:27PM +0200, codekip...@gmail.com wrote: > > > From: Marcus Cooper > > > > > > Although not causing any noticeable issues, the mask for the > > >

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

On 13 March 2018 at 09:23, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > On Tue, Mar 13, 2018 at 09:15:49AM +0100, Code Kipper wrote: >> On 13 March 2018 at 09:00, Maxime Ripard <maxime.rip...@bootlin.com> wrote: >> > On Mon, Mar 12, 2018 at 04:57:51PM +01

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

On 13 March 2018 at 09:23, Maxime Ripard wrote: > On Tue, Mar 13, 2018 at 09:15:49AM +0100, Code Kipper wrote: >> On 13 March 2018 at 09:00, Maxime Ripard wrote: >> > On Mon, Mar 12, 2018 at 04:57:51PM +0100, codekip...@gmail.com wrote: >> >> From: Marcus Coo

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

On 13 March 2018 at 09:00, Maxime Ripard wrote: > On Mon, Mar 12, 2018 at 04:57:51PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The i2s block supports multi-lane i2s output however this functionality >> is only possible in

Re: [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality

On 13 March 2018 at 09:00, Maxime Ripard wrote: > On Mon, Mar 12, 2018 at 04:57:51PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The i2s block supports multi-lane i2s output however this functionality >> is only possible in earlier SoCs where the pins are exposed and for >>

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 12:32, Mark Brown <broo...@kernel.org> wrote: > On Mon, Jan 29, 2018 at 08:34:00AM +0100, Code Kipper wrote: > >> I'm not sure..I was looking for a clean example of being able to >> override the number of bclks in the lrclk width and some other &g

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 12:32, Mark Brown wrote: > On Mon, Jan 29, 2018 at 08:34:00AM +0100, Code Kipper wrote: > >> I'm not sure..I was looking for a clean example of being able to >> override the number of bclks in the lrclk width and some other >> devices(Rpi) were do

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 08:38, Chen-Yu Tsai <w...@csie.org> wrote: > On Mon, Jan 29, 2018 at 3:34 PM, Code Kipper <codekip...@gmail.com> wrote: >> On 29 January 2018 at 02:50, Chen-Yu Tsai <w...@csie.org> wrote: >>> On Wed, Jan 24, 2018 at 10:10 PM, <codekip

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 08:38, Chen-Yu Tsai wrote: > On Mon, Jan 29, 2018 at 3:34 PM, Code Kipper wrote: >> On 29 January 2018 at 02:50, Chen-Yu Tsai wrote: >>> On Wed, Jan 24, 2018 at 10:10 PM, wrote: >>>> From: Marcus Cooper >>>> >>>>

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 02:50, Chen-Yu Tsai wrote: > On Wed, Jan 24, 2018 at 10:10 PM, wrote: >> From: Marcus Cooper >> >> Some codecs require a different amount of a bit clocks per frame than >> what is calculated by the sample width.

Re: [linux-sunxi] [PATCH 1/3] ASoC: sun4i-i2s: Add set_tdm_slot functionality

On 29 January 2018 at 02:50, Chen-Yu Tsai wrote: > On Wed, Jan 24, 2018 at 10:10 PM, wrote: >> From: Marcus Cooper >> >> Some codecs require a different amount of a bit clocks per frame than >> what is calculated by the sample width. Use the tdm slot bindings to >> provide this mechanism. >>

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On 25 January 2018 at 09:41, Maxime Ripard wrote: > Hi, > > On Wed, Jan 24, 2018 at 03:11:01PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> On the newer SoCs this is set by default to transfer a 0 after >> each sample in

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On 25 January 2018 at 09:41, Maxime Ripard wrote: > Hi, > > On Wed, Jan 24, 2018 at 03:11:01PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> On the newer SoCs this is set by default to transfer a 0 after >> each sample in each slot. Add the regmap field to configure this >> and

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On 24 January 2018 at 15:11, wrote: > From: Marcus Cooper > > On the newer SoCs this is set by default to transfer a 0 after > each sample in each slot. Add the regmap field to configure this > and set it so that it pads the sample with 0s. > >

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add regmap field to sign extend sample

On 24 January 2018 at 15:11, wrote: > From: Marcus Cooper > > On the newer SoCs this is set by default to transfer a 0 after > each sample in each slot. Add the regmap field to configure this > and set it so that it pads the sample with 0s. > > Signed-off-by: Marcus Cooper NACK missing regmap

Re: [PATCH] ASoC: sun4i-i2s: Show detailed error when DAI configuration callbacks fail

On 14 December 2017 at 08:29, Chen-Yu Tsai wrote: > When any of the DAI hardware configuration callbacks (.hw_param, > .set_fmt, .set_sysclk) fails, there is no explanation about why it > failed. This is particularly confusing for .hw_param, which covers > many parameters of the

Re: [PATCH] ASoC: sun4i-i2s: Show detailed error when DAI configuration callbacks fail

On 14 December 2017 at 08:29, Chen-Yu Tsai wrote: > When any of the DAI hardware configuration callbacks (.hw_param, > .set_fmt, .set_sysclk) fails, there is no explanation about why it > failed. This is particularly confusing for .hw_param, which covers > many parameters of the DAI. Telling the

Re: [linux-sunxi] Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

On 31 August 2017 at 16:52, Maxime Ripard wrote: > On Thu, Aug 31, 2017 at 01:36:09AM +0200, Stefan Brüns wrote: >> The A64 SoC has the same dma engine as the H3 (sun8i), with a >> reduced amount of physical channels. Add the proper config data >> and compatible

Re: [linux-sunxi] Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

On 31 August 2017 at 16:52, Maxime Ripard wrote: > On Thu, Aug 31, 2017 at 01:36:09AM +0200, Stefan Brüns wrote: >> The A64 SoC has the same dma engine as the H3 (sun8i), with a >> reduced amount of physical channels. Add the proper config data >> and compatible string to support it. >> >>

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

On 31 August 2017 at 13:50, Code Kipper <codekip...@gmail.com> wrote: > Hi Mark, > > Wens has given this patch series his blessing so it's good to go. > > Let us know if you need me to resubmit, I take that back as I can see that's all been submitted. Thanks, CK > > B

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

On 31 August 2017 at 13:50, Code Kipper wrote: > Hi Mark, > > Wens has given this patch series his blessing so it's good to go. > > Let us know if you need me to resubmit, I take that back as I can see that's all been submitted. Thanks, CK > > BR, > CK > On 19 Au

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

Hi Mark, Wens has given this patch series his blessing so it's good to go. Let us know if you need me to resubmit, BR, CK On 19 August 2017 at 14:48, wrote: > From: Marcus Cooper > > Hi All, > please find attached a series of patches to bring i2s

Re: [PATCH v5 0/8] ASoC: Add I2S support for Allwinner H3 SoCs

Hi Mark, Wens has given this patch series his blessing so it's good to go. Let us know if you need me to resubmit, BR, CK On 19 August 2017 at 14:48, wrote: > From: Marcus Cooper > > Hi All, > please find attached a series of patches to bring i2s support to the > Allwinner H3 SoC. This has

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

On 31 August 2017 at 01:36, Stefan Brüns wrote: > The A64 SoC has the same dma engine as the H3 (sun8i), with a > reduced amount of physical channels. Add the proper config data > and compatible string to support it. > > Signed-off-by: Stefan Brüns

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

On 31 August 2017 at 01:36, Stefan Brüns wrote: > The A64 SoC has the same dma engine as the H3 (sun8i), with a > reduced amount of physical channels. Add the proper config data > and compatible string to support it. > > Signed-off-by: Stefan Brüns > --- >

Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2

On 25 August 2017 at 12:32, Antony Antony wrote: > Add initial DT support for NanoPi NEO Plus 2 by FriendlyELEC > Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU > 1 GB DDR3 RAM > 8GB eMMC flash (Samsung

Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2

On 25 August 2017 at 12:32, Antony Antony wrote: > Add initial DT support for NanoPi NEO Plus 2 by FriendlyELEC > Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU > 1 GB DDR3 RAM > 8GB eMMC flash (Samsung KLM8G1WEPD-B031) >

Re: [linux-sunxi] [PATCH v3 11/11] ASoC: sun4i-i2s: Add support for H3

On 12 August 2017 at 14:27, Chen-Yu Tsai wrote: > On Sat, Aug 12, 2017 at 7:00 PM, wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different register locations, extended clock

Re: [linux-sunxi] [PATCH v3 11/11] ASoC: sun4i-i2s: Add support for H3

On 12 August 2017 at 14:27, Chen-Yu Tsai wrote: > On Sat, Aug 12, 2017 at 7:00 PM, wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different register locations, extended clock division and >> more operational modes. As we have to

Re: [linux-sunxi] [PATCH v3 05/12] ASoC: sun4i-i2s: Add regmap fields for channels

On 1 August 2017 at 10:31, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> On the original i2s block the channel mapping and selection were >> configured for stereo audio by default: This is

Re: [linux-sunxi] [PATCH v3 05/12] ASoC: sun4i-i2s: Add regmap fields for channels

On 1 August 2017 at 10:31, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> On the original i2s block the channel mapping and selection were >> configured for stereo audio by default: This is not the case with >> the newer SoCs and they are also

Re: [linux-sunxi] [PATCH v3 02/12] ASoC: sun4i-i2s: Add clkdiv offsets to quirks

On 1 August 2017 at 04:55, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> The BCLKDIV and MCLKDIV found on newer SoCs start from an offset of 1. >> Add the functionality to adjust the

Re: [linux-sunxi] [PATCH v3 02/12] ASoC: sun4i-i2s: Add clkdiv offsets to quirks

On 1 August 2017 at 04:55, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 10:17 PM, wrote: >> From: Marcus Cooper >> >> The BCLKDIV and MCLKDIV found on newer SoCs start from an offset of 1. >> Add the functionality to adjust the division values according to the >> needs to the device being

Re: [linux-sunxi] [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs

On 31 July 2017 at 09:05, Olliver Schinagl wrote: > Hey Marcus, > > On 29-07-17 16:17, codekip...@gmail.com wrote: >> >> From: Marcus Cooper >> >> Hi All, >> please find attached a series of patches to bring i2s support to the >> Allwinner H3 SoC.

Re: [linux-sunxi] [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs

On 31 July 2017 at 09:05, Olliver Schinagl wrote: > Hey Marcus, > > On 29-07-17 16:17, codekip...@gmail.com wrote: >> >> From: Marcus Cooper >> >> Hi All, >> please find attached a series of patches to bring i2s support to the >> Allwinner H3 SoC. This has been tested with the following setups:

Re: [PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

On 25 July 2017 at 16:36, Maxime Ripard wrote: > Hi, > > On Sat, Jul 22, 2017 at 08:53:52AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different

Re: [PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

On 25 July 2017 at 16:36, Maxime Ripard wrote: > Hi, > > On Sat, Jul 22, 2017 at 08:53:52AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun8i-h3 introduces a lot of changes to the i2s block such >> as different register locations, extended clock division and >> more

Re: [PATCH v2 1/2] ASoC: sun4i-i2s: Add more quirks for newer SoCs

On 25 July 2017 at 07:52, Maxime Ripard wrote: > Hi Markus, > > On Sat, Jul 22, 2017 at 08:53:51AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> In preparation for changing this driver to support newer SoC >>

Re: [PATCH v2 1/2] ASoC: sun4i-i2s: Add more quirks for newer SoCs

On 25 July 2017 at 07:52, Maxime Ripard wrote: > Hi Markus, > > On Sat, Jul 22, 2017 at 08:53:51AM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> In preparation for changing this driver to support newer SoC >> implementations then where needed there has been a switch from >>

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add support for H3

On 5 July 2017 at 18:20, Maxime Ripard wrote: > On Wed, Jul 05, 2017 at 05:43:24PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> There are a lot of changes to the sun8i-h3 i2s block but not enough >> to warrant to a new

Re: [PATCH 3/3] ASoC: sun4i-i2s: Add support for H3

On 5 July 2017 at 18:20, Maxime Ripard wrote: > On Wed, Jul 05, 2017 at 05:43:24PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> There are a lot of changes to the sun8i-h3 i2s block but not enough >> to warrant to a new driver. >> >> Signed-off-by: Marcus Cooper >> --- >>

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 19 January 2017 at 18:03, Mark Brown <broo...@kernel.org> wrote: > On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote: > >> I missed the binding documentation on the patch for the driver so I >> pushed it separately instead of pushing a new patch version.

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 19 January 2017 at 18:03, Mark Brown wrote: > On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote: > >> I missed the binding documentation on the patch for the driver so I >> pushed it separately instead of pushing a new patch version. >> You can find it under t

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 17 January 2017 at 19:15, Mark Brown wrote: > On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the >> transmit fifo is at a different

Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 17 January 2017 at 19:15, Mark Brown wrote: > On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the >> transmit fifo is at a different address. >> >> Signed-off-by: Marcus

Re: [PATCH] ASoC: sun4i-i2s: Add quirks for newer SoCs

On 20 December 2016 at 20:16, Maxime Ripard wrote: > Hi, > > On Tue, Dec 20, 2016 at 03:55:24PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Newer SoCs have additional functionality so a quirks structure >> has been added

Re: [PATCH] ASoC: sun4i-i2s: Add quirks for newer SoCs

On 20 December 2016 at 20:16, Maxime Ripard wrote: > Hi, > > On Tue, Dec 20, 2016 at 03:55:24PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Newer SoCs have additional functionality so a quirks structure >> has been added to handle them. So far we've seen the use of a >> reset

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun8i-h3: Set CLK_SET_RATE_PARENT for audio module clocks

On 11 November 2016 at 11:05, Chen-Yu Tsai wrote: > The audio module clocks are supposed to be set according to the sample > rate of the audio stream. The audio PLL provides the clock signal for > thees module clocks, and only it is freely tunable. nick! these CK > > Set

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun8i-h3: Set CLK_SET_RATE_PARENT for audio module clocks

On 11 November 2016 at 11:05, Chen-Yu Tsai wrote: > The audio module clocks are supposed to be set according to the sample > rate of the audio stream. The audio PLL provides the clock signal for > thees module clocks, and only it is freely tunable. nick! these CK > > Set CLK_SET_RATE_PARENT for

Re: [PATCH 07/14] ASoC: Add sun8i audio card

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand

Re: [PATCH 07/14] ASoC: Add sun8i audio card

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/Kconfig | 14 +++

Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add APB deassert function for sun4i-i2s driver. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/sun4i-i2s.c | 16 +++- > 1 file changed, 15

Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add APB deassert function for sun4i-i2s driver. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/sun4i-i2s.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c

Re: [PATCH 04/14] ASoC: Add sun8i analog codec driver

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the analog part of the sun8i (A33) codec driver. This driver > implements all the analog part of the codec using PRCM registers. > > The read/write regmap functions must be handled in a custom way as >

Re: [PATCH 04/14] ASoC: Add sun8i analog codec driver

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the analog part of the sun8i (A33) codec driver. This driver > implements all the analog part of the codec using PRCM registers. > > The read/write regmap functions must be handled in a custom way as > the PRCM register behaves as

Re: [PATCH 07/14] ASoC: Add sun8i audio card

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand

Re: [PATCH 07/14] ASoC: Add sun8i audio card

On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add the audio card for sun8i SoC. This card links the codec driver > (digital part) with the DAI driver. The analog codec driver is > added as an aux_device. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/Kconfig | 14 +++

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On 29 August 2016 at 20:03, Danny Milosavljevic wrote: > > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. > --- > sound/soc/sunxi/sun4i-codec.c | 256 >

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On 29 August 2016 at 20:03, Danny Milosavljevic wrote: > > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. > --- > sound/soc/sunxi/sun4i-codec.c | 256 > ++

Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

On 30 July 2016 at 17:17, Maxime Ripard wrote: > On Sat, Jul 30, 2016 at 04:27:15PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The A31 SoC uses the same SPDIF block as found in earlier SoCs, but its >> reset is

Re: [PATCH 1/2] ASoC: sunxi: Add bindings for sun6i to SPDIF

On 30 July 2016 at 17:17, Maxime Ripard wrote: > On Sat, Jul 30, 2016 at 04:27:15PM +0200, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The A31 SoC uses the same SPDIF block as found in earlier SoCs, but its >> reset is controlled via a separate reset controller. >> >> Signed-off-by:

Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver

snip > + > + /* Always favor the highest oversampling rate */ > + for (i = (ARRAY_SIZE(sun4i_i2s_oversample_rates) - 1); i >= 0; i--) { > + unsigned int oversample_rate = sun4i_i2s_oversample_rates[i]; > + > + bclk_div = sun4i_i2s_get_bclk_div(i2s,

Re: [PATCH 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver

snip > + > + /* Always favor the highest oversampling rate */ > + for (i = (ARRAY_SIZE(sun4i_i2s_oversample_rates) - 1); i >= 0; i--) { > + unsigned int oversample_rate = sun4i_i2s_oversample_rates[i]; > + > + bclk_div = sun4i_i2s_get_bclk_div(i2s,

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

Hi Danny, I've got some patches to go which covers pretty much everything that we can manage with the sun4i-codec. I'm only lacking testing of certain bits as I don't have capable hardware(i.e. FM capture). I've ignored the phone out part of the A20 as I couldn't find the pins. I'll try to upload

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

Hi Danny, I've got some patches to go which covers pretty much everything that we can manage with the sun4i-codec. I'm only lacking testing of certain bits as I don't have capable hardware(i.e. FM capture). I've ignored the phone out part of the A20 as I couldn't find the pins. I'll try to upload

Re: [linux-sunxi] Re: [PATCH v7 0/2] ASoC: Add SPDIF support for Allwinner SoCs

On 22 February 2016 at 04:12, Mark Brown wrote: > On Sun, Feb 21, 2016 at 12:13:36PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> For now just the SPDIF transmitter has been tested on a Mele A2000(A10) >> and a Itead Ibox(A20). > >

Re: [linux-sunxi] Re: [PATCH v7 0/2] ASoC: Add SPDIF support for Allwinner SoCs

On 22 February 2016 at 04:12, Mark Brown wrote: > On Sun, Feb 21, 2016 at 12:13:36PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> For now just the SPDIF transmitter has been tested on a Mele A2000(A10) >> and a Itead Ibox(A20). > > This was already applied. If any updates are

Re: [PATCH v5 0/2] ASoC: Add SPDIF support for Allwinner SoCs

NAK...last bunch of changes introduced a warning which slipped through, I'll fix that and send a new patch series. CK On 8 February 2016 at 16:26, wrote: > From: Marcus Cooper > > This patch set adds support for the Allwinner SPDIF transceiver. > > For now just the SPDIF transmitter has been

Re: [PATCH v5 0/2] ASoC: Add SPDIF support for Allwinner SoCs

NAK...last bunch of changes introduced a warning which slipped through, I'll fix that and send a new patch series. CK On 8 February 2016 at 16:26, wrote: > From: Marcus Cooper > > This patch set adds support for the Allwinner SPDIF transceiver. > >

Re: [PATCH v4 2/2] ASoC: sunxi: Add support for the SPDIF block

On 5 February 2016 at 10:27, Maxime Ripard wrote: > Hi, > > On Thu, Feb 04, 2016 at 12:09:22PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun4i, sun5i and sun7i SoC families have an SPDIF >> block which is capable of playback and capture. >> >> This patch enables the

Re: [PATCH v4 2/2] ASoC: sunxi: Add support for the SPDIF block

On 5 February 2016 at 10:27, Maxime Ripard wrote: > Hi, > > On Thu, Feb 04, 2016 at 12:09:22PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> The sun4i, sun5i and sun7i SoC families have an SPDIF >> block which is capable

Re: [PATCH v3 2/2] ASOC: sunxi: Add support for the SPDIF block

On 2 February 2016 at 22:17, Maxime Ripard wrote: > Hi, > > It looks mostly good on my side, a few comments though. > > On Tue, Feb 02, 2016 at 03:49:54PM +0100, codekip...@gmail.com wrote: >> +#ifdef CONFIG_PM >> +static int sun4i_spdif_runtime_suspend(struct device *dev) >> +{ >> + struct

Re: [PATCH v3 2/2] ASOC: sunxi: Add support for the SPDIF block

On 2 February 2016 at 22:17, Maxime Ripard wrote: > Hi, > > It looks mostly good on my side, a few comments though. > > On Tue, Feb 02, 2016 at 03:49:54PM +0100, codekip...@gmail.com wrote: >> +#ifdef CONFIG_PM >> +static int sun4i_spdif_runtime_suspend(struct

Re: [PATCH v3 1/2] dt-bindings: add sun4i SPDIF transceiver bindings

On 2 February 2016 at 23:31, Maxime Ripard wrote: > Hi, > > On Tue, Feb 02, 2016 at 03:49:53PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Add devicetree bindings for the SPDIF transceiver found on >> found on Allwinners A10 and A20 SoCs. >> >> Signed-off-by: Marcus Cooper

Re: [PATCH v3 1/2] dt-bindings: add sun4i SPDIF transceiver bindings

On 2 February 2016 at 23:31, Maxime Ripard wrote: > Hi, > > On Tue, Feb 02, 2016 at 03:49:53PM +0100, codekip...@gmail.com wrote: >> From: Marcus Cooper >> >> Add devicetree bindings for the SPDIF transceiver found on >> found on Allwinners

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

On 6 October 2015 at 11:00, Maxime Ripard wrote: > On Fri, Oct 02, 2015 at 08:44:03AM +0200, Code Kipper wrote: >> >> +config SND_SOC_SUNXI_DAI_SPDIF >> >> +tristate >> >> + depends on OF >> >> +select SND_SOC_GENE

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

On 6 October 2015 at 11:00, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Oct 02, 2015 at 08:44:03AM +0200, Code Kipper wrote: >> >> +config SND_SOC_SUNXI_DAI_SPDIF >> >> +tristate >> >> + depends on OF >&g

Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings

On 5 October 2015 at 10:41, Maxime Ripard wrote: > On Fri, Oct 02, 2015 at 07:24:20AM +0200, Code Kipper wrote: >> >> + >> >> + - compatible : should be one of the following: >> >> +- "allwinner,sun4i-a10-spdif": for the Allwinne

  1   2   >