[PATCH v8] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-21 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer --- Changes from v7: * Move struct fat_bios_param_block from fat.h to fat/inode.c --- Documentation/filesystems/vfat.txt | 5 + fs/fat/fat.h | 3 +- fs/fat/inode.c | 342

[PATCH v8] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-21 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer cse@gmail.com --- Changes from v7: * Move struct fat_bios_param_block from fat.h to fat/inode.c --- Documentation/filesystems/vfat.txt | 5 + fs/fat/fat.h | 3 +- fs/fat/inode.c | 342

[PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-14 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer --- Changes since v6: * Update show_options() * Add option documentation to Doc/filesystems/vfat.txt Thanks. --- Documentation/filesystems/vfat.txt | 5 + fs/fat/fat.h | 28 +++- fs/fat/inode.c | 318

[PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-14 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer cse@gmail.com --- Changes since v6: * Update show_options() * Add option documentation to Doc/filesystems/vfat.txt Thanks. --- Documentation/filesystems/vfat.txt | 5 + fs/fat/fat.h | 28 +++- fs/fat/inode.c

[PATCH v6] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer --- Changes since v5: * Leave the bulk of sbi-> filling logic to the aptly named fat_fill_super() * Create separate structure for deserialized BPB values * fat_read_bpb() deserializes BPB from raw fat_boot_sector and performs validati

Re: [PATCH v5] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
On Mon, 14 Apr 2014 07:14:51 +0900 OGAWA Hirofumi wrote: > Conrad Meyer writes: > > > + sbi->sec_per_clus = fdefaults->sec_per_clus; > > + sbi->cluster_size = sb->s_blocksize * > > sbi->sec_per_clus; > > + sbi->cluster_bits = ffs(sbi->cl

[PATCH v5] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
Signed-off-by: Conrad Meyer --- Changes since v4: * Read FAT FS block device size with i_size_read() * In silent (probing) mode, don't message * Use dos1xfloppy as a gate to allow trying static BPB values (don't require floppy to be archaic with this option) * Split out BPB-parsing

Re: [PATCH v4] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
On Sun, 13 Apr 2014 12:57:42 +0900 OGAWA Hirofumi wrote: > Conrad Meyer writes: > > Hi, > > Sorry for late reply. > > > + > > + bd_sects = > > part_nr_sects_read(sb->s_bdev->bd_part); > > This would be better to use > i_re

Re: [PATCH v4] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
On Sun, 13 Apr 2014 12:57:42 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: Conrad Meyer ceme...@uw.edu writes: Hi, Sorry for late reply. + + bd_sects = part_nr_sects_read(sb-s_bdev-bd_part); This would be better to use i_read_size(sb-s_bdev-bd_inode-i_size) Ok

[PATCH v5] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
Signed-off-by: Conrad Meyer cse@gmail.com --- Changes since v4: * Read FAT FS block device size with i_size_read() * In silent (probing) mode, don't message * Use dos1xfloppy as a gate to allow trying static BPB values (don't require floppy to be archaic with this option) * Split

Re: [PATCH v5] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
On Mon, 14 Apr 2014 07:14:51 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: Conrad Meyer cse@gmail.com writes: + sbi-sec_per_clus = fdefaults-sec_per_clus; + sbi-cluster_size = sb-s_blocksize * sbi-sec_per_clus; + sbi-cluster_bits = ffs(sbi-cluster_size) - 1

[PATCH v6] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-13 Thread Conrad Meyer
/fat/fat-1.html Signed-off-by: Conrad Meyer cse@gmail.com --- Changes since v5: * Leave the bulk of sbi- filling logic to the aptly named fat_fill_super() * Create separate structure for deserialized BPB values * fat_read_bpb() deserializes BPB from raw fat_boot_sector and performs

[PATCH v4] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
. Values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer --- Changes since v3

Re: [PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
On Mon, Mar 31, 2014 at 3:13 PM, Andrew Morton wrote: > On Sat, 29 Mar 2014 12:10:35 -0700 Conrad Meyer wrote: > >> + .nr_sectors = 360 * KB_IN_SECTORS, >> + .sec_per_clus = 2, >> + .dir_entries = 112, >> + .media = 0xFD, >> + .fat_length =

Re: [PATCH] fs: ext4: Sign-extend tv_sec after ORing in epoch bits

2014-03-31 Thread Conrad Meyer
parate patch to fix this a few months ago, that was > "more correct" than this one? Did that not land? > > Cheers, Andreas > >> On Mar 30, 2014, at 8:58, Conrad Meyer wrote: >> >> Fixes kernel.org bug #23732. >> >> Background: ext4 stores time a

[PATCH v3] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
. Values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer --- Based on next

Re: [PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
On Mon, 31 Mar 2014 23:07:32 +0900 OGAWA Hirofumi wrote: > Conrad Meyer writes: > > > +static void fat_update_archaic_boot_sector(struct > > super_block *sb, > > + struct fat_boot_sector *b) > > +{ > > + struct fat_floppy_defaults *di; > > + sect

Re: [PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
On Mon, 31 Mar 2014 23:07:32 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: Conrad Meyer ceme...@uw.edu writes: +static void fat_update_archaic_boot_sector(struct super_block *sb, + struct fat_boot_sector *b) +{ + struct fat_floppy_defaults *di; + sector_t bd_sects

[PATCH v3] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
. Values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer cse@gmail.com

Re: [PATCH] fs: ext4: Sign-extend tv_sec after ORing in epoch bits

2014-03-31 Thread Conrad Meyer
there was a separate patch to fix this a few months ago, that was more correct than this one? Did that not land? Cheers, Andreas On Mar 30, 2014, at 8:58, Conrad Meyer ceme...@uw.edu wrote: Fixes kernel.org bug #23732. Background: ext4 stores time as a 34-bit quantity; 2 bits in some extra

Re: [PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
On Mon, Mar 31, 2014 at 3:13 PM, Andrew Morton a...@linux-foundation.org wrote: On Sat, 29 Mar 2014 12:10:35 -0700 Conrad Meyer ceme...@uw.edu wrote: + .nr_sectors = 360 * KB_IN_SECTORS, + .sec_per_clus = 2, + .dir_entries = 112, + .media = 0xFD, + .fat_length = 2

[PATCH v4] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-31 Thread Conrad Meyer
. Values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer cse@gmail.com

[PATCH] fs: ext4: Sign-extend tv_sec after ORing in epoch bits

2014-03-30 Thread Conrad Meyer
of the seconds quantity before ORing in the 2 "epoch" bits from nanoseconds. This patch ORs in the 2 higher bits, then sign extends the 34-bit signed number to 64 bits. Signed-off-by: Conrad Meyer --- Patch against next-20140328. Note, the on-disk format has always been written correctly. I

[PATCH] fs: ext4: Sign-extend tv_sec after ORing in epoch bits

2014-03-30 Thread Conrad Meyer
of the seconds quantity before ORing in the 2 epoch bits from nanoseconds. This patch ORs in the 2 higher bits, then sign extends the 34-bit signed number to 64 bits. Signed-off-by: Conrad Meyer cse@gmail.com --- Patch against next-20140328. Note, the on-disk format has always been written correctly

[PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-29 Thread Conrad Meyer
#42617. BPB default values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer

Re: [PATCH] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-29 Thread Conrad Meyer
On Sun, 30 Mar 2014 02:56:46 +0900 OGAWA Hirofumi wrote: > Conrad Meyer writes: > > Hi, > > > When possible, infer DOS 2.x BIOS Parameter Block from > > block device geometry (for floppies and floppy images). > > Update in-memory only. We only perform this

Re: [PATCH] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-29 Thread Conrad Meyer
On Sun, 30 Mar 2014 02:56:46 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: Conrad Meyer ceme...@uw.edu writes: Hi, When possible, infer DOS 2.x BIOS Parameter Block from block device geometry (for floppies and floppy images). Update in-memory only. We only perform

[PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-29 Thread Conrad Meyer
#42617. BPB default values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer cse

[PATCH] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-28 Thread Conrad Meyer
#42617. BPB default values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer

[PATCH] fs: FAT: Add support for DOS 1.x formatted volumes

2014-03-28 Thread Conrad Meyer
#42617. BPB default values are inferred from media size and a table.[0] Media size is assumed to be static for archaic FAT volumes. See also [1]. [0]: https://en.wikipedia.org/wiki/File_Allocation_Table#Exceptions [1]: http://www.win.tue.nl/~aeb/linux/fs/fat/fat-1.html Signed-off-by: Conrad Meyer cse

[PATCH] Staging: vt6655: Fix sparse-indicated type mismatch to kmalloc

2014-03-20 Thread Conrad Meyer
Signed-off-by: Conrad Meyer --- Patch is against next-20140320. Fixes a minor sparse warning in the staging driver vt6655. p->length is u16; implicit cast to size_t is fine. No reason to cast GFP_KERNEL... --- drivers/staging/vt6655/wpactl.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] Staging: vt6655: Fix sparse-indicated type mismatch to kmalloc

2014-03-20 Thread Conrad Meyer
Signed-off-by: Conrad Meyer cse@gmail.com --- Patch is against next-20140320. Fixes a minor sparse warning in the staging driver vt6655. p-length is u16; implicit cast to size_t is fine. No reason to cast GFP_KERNEL... --- drivers/staging/vt6655/wpactl.c | 2 +- 1 file changed, 1 insertion

[PATCH] Staging: comedi: fixup: dev_warn() with correct dev

2014-03-11 Thread Conrad Meyer
Replace hw_dev with class_dev in new dev_warn()s. Sending this as a patch on top of the one already applied, since GregKH already took that one. If this is the wrong way to fix it, please let me know how I should proceed, I'm new. Thanks! Signed-off-by: Conrad Meyer --- .../comedi/drivers

[PATCH] Staging: comedi: fixup: dev_warn() with correct dev

2014-03-11 Thread Conrad Meyer
Replace hw_dev with class_dev in new dev_warn()s. Sending this as a patch on top of the one already applied, since GregKH already took that one. If this is the wrong way to fix it, please let me know how I should proceed, I'm new. Thanks! Signed-off-by: Conrad Meyer cse@gmail.com

[PATCH 2/2] Staging: comedi: Validate early to flatten code

2014-03-09 Thread Conrad Meyer
Take advantage of -EINVAL returns to flatten code structure and hopefully reduce the number of 80+ character lines. Signed-off-by: Conrad Meyer --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 621 ++--- 1 file changed, 303 insertions(+), 318 deletions(-) diff --git

[PATCH 2/2] Staging: comedi: Validate early to flatten code

2014-03-09 Thread Conrad Meyer
Take advantage of -EINVAL returns to flatten code structure and hopefully reduce the number of 80+ character lines. Signed-off-by: Conrad Meyer cse@gmail.com --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 621 ++--- 1 file changed, 303 insertions(+), 318 deletions

[PATCH 3/3] Staging: comedi: do not initialize statics to 0 (apci1500)

2014-03-08 Thread Conrad Meyer
Minor style cleanup per checkpatch.pl. Signed-off-by: Conrad Meyer --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging

[PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-08 Thread Conrad Meyer
INVAL as well. Signed-off-by: Conrad Meyer --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 166 + 1 file changed, 107 insertions(+), 59 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data/hwd

Updated: [PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

2014-03-08 Thread Conrad Meyer
Rename some very long functions in addi-data/hwdrv_apci1500.c. Signed-off-by: Conrad Meyer --- .../staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 18 -- drivers/staging/comedi/drivers/addi_apci_1500.c| 4 ++-- 2 files changed, 10 insertions(+), 12 deletions

[PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

2014-03-08 Thread Conrad Meyer
Fix minor checkpatch.pl style issues (80-char line limits) in addi_apci_1500.c. Signed-off-by: Conrad Meyer --- drivers/staging/comedi/drivers/addi_apci_1500.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi_apci_1500.c b/drivers

[PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

2014-03-08 Thread Conrad Meyer
Fix minor checkpatch.pl style issues (80-char line limits) in addi_apci_1500.c. Signed-off-by: Conrad Meyer cse@gmail.com --- drivers/staging/comedi/drivers/addi_apci_1500.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers

Updated: [PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

2014-03-08 Thread Conrad Meyer
Rename some very long functions in addi-data/hwdrv_apci1500.c. Signed-off-by: Conrad Meyer cse@gmail.com --- .../staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 18 -- drivers/staging/comedi/drivers/addi_apci_1500.c| 4 ++-- 2 files changed, 10 insertions(+), 12

[PATCH 3/3] Staging: comedi: do not initialize statics to 0 (apci1500)

2014-03-08 Thread Conrad Meyer
Minor style cleanup per checkpatch.pl. Signed-off-by: Conrad Meyer cse@gmail.com --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b

[PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-08 Thread Conrad Meyer
. Signed-off-by: Conrad Meyer cse@gmail.com --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 166 + 1 file changed, 107 insertions(+), 59 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data