This patch adds kernel-dot-emacs.txt (elisp) which deliver best
indentation, comments and white space highlighting functionalities.
This also changes the CodingStyle and 00-INDEX files by referencing
the new kernel-dot-emacs.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
Reviewed-by:
This patch adds kernel-dot-emacs.txt (elisp) which deliver best
indentation, comments and white space highlighting functionalities.
This also changes the CodingStyle and 00-INDEX files by referencing
the new kernel-dot-emacs.
Signed-off-by: Geyslan G. Bem
Reviewed-by: Tiago Natel de Moura
which deliver best
> indentation, comments and white space highlighting functionalities.
>
> This also changes the CodingStyle and 00-INDEX files by referencing
> the new kernel-dot-emacs.
>
> Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
> ---
>
> Notes
> indentation, comments and white space highlighting functionalities.
>
> This also changes the CodingStyle and 00-INDEX files by referencing
> the new kernel-dot-emacs.
>
> Signed-off-by: Geyslan G. Bem
> ---
>
> Notes:
> This patch was done by suggestion of Jonathan
Hello, ping...
2016-01-27 19:51 GMT-03:00 Geyslan G. Bem :
> This patch adds kernel-dot-emacs.txt (elisp) which deliver best
> indentation, comments and white space highlighting functionalities.
>
> This also changes the CodingStyle and 00-INDEX files by referencing
> the new k
Hello, ping...
2016-01-27 19:51 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> This patch adds kernel-dot-emacs.txt (elisp) which deliver best
> indentation, comments and white space highlighting functionalities.
>
> This also changes the CodingStyle and 00-INDEX files by ref
This patch adds kernel-dot-emacs.txt (elisp) which deliver best
indentation, comments and white space highlighting functionalities.
This also changes the CodingStyle and 00-INDEX files by referencing
the new kernel-dot-emacs.
Signed-off-by: Geyslan G. Bem
---
Notes:
This patch was done
This patch adds kernel-dot-emacs.txt (elisp) which deliver best
indentation, comments and white space highlighting functionalities.
This also changes the CodingStyle and 00-INDEX files by referencing
the new kernel-dot-emacs.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Hello,
2015-12-30 12:49 GMT-03:00 Geyslan G. Bem :
> This patch escapes a regex that uses left brace.
>
> Using checkpatch.pl with Perl 5.22.0 generates the warning: "Unescaped
> left brace in regex is deprecated, passed through in regex;"
>
> Comment from regcomp.c i
Hello,
2015-12-30 12:49 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> This patch escapes a regex that uses left brace.
>
> Using checkpatch.pl with Perl 5.22.0 generates the warning: "Unescaped
> left brace in regex is deprecated, passed through in regex;"
>
&
2016-01-25 19:18 GMT-03:00 Geyslan G. Bem :
> 2016-01-25 17:40 GMT-03:00 Alan Stern :
>> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>>
>>> 2016-01-25 17:08 GMT-03:00 Alan Stern :
>>> > On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>>> >
>>> &g
2016-01-25 17:01 GMT-03:00 Jonathan Corbet :
> On Thu, 21 Jan 2016 22:18:30 -0300
> "Geyslan G. Bem" wrote:
>
>> This patch does use of more emacs functionalities which deliver to the
>> user indentation, commenting and white space highlighting.
>
> So perh
2016-01-25 17:40 GMT-03:00 Alan Stern :
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-25 17:08 GMT-03:00 Alan Stern :
>> > On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>> >
>> >> Ok Greg, there was three patchset versions for this file that wou
2016-01-25 17:08 GMT-03:00 Alan Stern :
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> Ok Greg, there was three patchset versions for this file that would
>> count over 40+ emails. This is v3. I didn't find any answer with ack
>> for it.
>> About sending, there
2016-01-25 16:56 GMT-03:00 Greg Kroah-Hartman :
> On Mon, Jan 25, 2016 at 04:52:52PM -0300, Geyslan G. Bem wrote:
>> 2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman :
>> > On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
>> >> 2015-12-13
2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman :
> On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
>> 2015-12-13 13:59 GMT-03:00 Geyslan G. Bem :
>> >
>> > Cleanup done with the help of coccinelle, checkpatch and cppcheck tools.
>> >
>> >
2016-01-25 16:56 GMT-03:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>:
> On Mon, Jan 25, 2016 at 04:52:52PM -0300, Geyslan G. Bem wrote:
>> 2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>:
>> > On Thu, Dec 24, 2015 at 01:03:39
2016-01-25 17:08 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> Ok Greg, there was three patchset versions for this file that would
>> count over 40+ emails. This is v3. I didn't find any answer with ack
>> for
2016-01-25 0:30 GMT-03:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>:
> On Thu, Dec 24, 2015 at 01:03:39PM -0300, Geyslan G. Bem wrote:
>> 2015-12-13 13:59 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>> >
>> > Cleanup done with the help of co
2016-01-25 17:40 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-25 17:08 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
>> > On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>> >
>&g
2016-01-25 17:01 GMT-03:00 Jonathan Corbet <cor...@lwn.net>:
> On Thu, 21 Jan 2016 22:18:30 -0300
> "Geyslan G. Bem" <geys...@gmail.com> wrote:
>
>> This patch does use of more emacs functionalities which deliver to the
>> user indentation, commenting a
2016-01-25 19:18 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> 2016-01-25 17:40 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
>> On Mon, 25 Jan 2016, Geyslan G. Bem wrote:
>>
>>> 2016-01-25 17:08 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
er this code
correctly tabify the commented result.
kernel-comment-dwim also removes trailing white spaces created by the
comment-region.
Finally the white space highlighting is a must to alert about long
lines, leading or trailing spaces and top or bottom empty lines.
Signed-off-by: Gey
er this code
correctly tabify the commented result.
kernel-comment-dwim also removes trailing white spaces created by the
comment-region.
Finally the white space highlighting is a must to alert about long
lines, leading or trailing spaces and top or bottom empty lines.
Signed-off-by: Ge
tion, but it
will mostly make the style consistent and easy as Joe stated. I'm not
claiming for that changing, just debating. :-D
But IMHO standardization could make things easier.
>
> Alan Stern
>
--
Regards,
Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "uns
2016-01-05 11:10 GMT-03:00 Geyslan G. Bem :
> 2016-01-05 10:02 GMT-03:00 Julia Lawall :
>>> *** Error in `/usr/lib/coccinelle/spatch': corrupted double-linked
>>> list (not small): 0x01c523d0 ***
>>> === Backtrace: =
>>
>> Wow...
2016-01-05 12:15 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-04 18:01 GMT-03:00 Alan Stern :
>> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>> >
>> >> This patch fixes a coding style issue reported by checkpatch related
2016-01-05 12:27 GMT-03:00 Geyslan G. Bem :
> 2016-01-05 12:23 GMT-03:00 Joe Perches :
>> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>>
>>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(
2016-01-05 12:23 GMT-03:00 Joe Perches :
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>
>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>> > >&
2016-01-04 23:40 GMT-03:00 Joe Perches :
> On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
>> 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
>> > > > > > This patch fixes coding style issues reported by checkpatch
>> > > > > > concer
2016-01-05 10:49 GMT-03:00 Andrzej Hajda :
> On 01/05/2016 01:59 PM, Geyslan G. Bem wrote:
>> Hello,
>>
>> 2016-01-04 4:45 GMT-03:00 Andrzej Hajda :
>>> Unsigned expressions cannot be lesser than zero. Presence of comparisons
>>> 'unsigned (<|<=|>|
gt;> arch/x86/include/generated/uapi -I arch/x86/include/generated -I
>> include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi
>> -I ./include/uapi -I include/generated/uapi --include
>> ./include/linux/kconfig.h --max 8 --index 7
>> ./drivers/cpufreq/cpuf
ude/linux/kconfig.h --max 8 --index 7
./drivers/cpufreq/cpufreq-dt.c:87:20-28: WARNING: Unsigned expression
compared with zero: volt_old > 0
./drivers/cpufreq/scpi-cpufreq.c:36:5-11: WARNING: Unsigned expression
compared with zero: domain < 0
./drivers/hsi/controllers/omap_ssi.c:327:
. -I ./arch/x86/include -I
>> arch/x86/include/generated/uapi -I arch/x86/include/generated -I
>> include -I ./arch/x86/include/uapi -I arch/x86/include/generated/uapi
>> -I ./include/uapi -I include/generated/uapi --include
>> ./include/linux/kconfig.h --max 8 --index 7
ay for that indentation, but it
will mostly make the style consistent and easy as Joe stated. I'm not
claiming for that changing, just debating. :-D
But IMHO standardization could make things easier.
>
> Alan Stern
>
--
Regards,
Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this
2016-01-05 11:10 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> 2016-01-05 10:02 GMT-03:00 Julia Lawall <julia.law...@lip6.fr>:
>>> *** Error in `/usr/lib/coccinelle/spatch': corrupted double-linked
>>> list (not small): 0x01c523d0 ***
>>> =
2016-01-04 23:40 GMT-03:00 Joe Perches <j...@perches.com>:
> On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
>> 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
>> > > > > > This patch fixes coding style issues reported by checkpatch
>> > > &g
2016-01-05 12:15 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-04 18:01 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
>> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>> >
>> &
2016-01-05 12:27 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> 2016-01-05 12:23 GMT-03:00 Joe Perches <j...@perches.com>:
>> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>>
>>> > >>
2016-01-05 12:23 GMT-03:00 Joe Perches <j...@perches.com>:
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>
>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>> >
2016-01-05 10:49 GMT-03:00 Andrzej Hajda <a.ha...@samsung.com>:
> On 01/05/2016 01:59 PM, Geyslan G. Bem wrote:
>> Hello,
>>
>> 2016-01-04 4:45 GMT-03:00 Andrzej Hajda <a.ha...@samsung.com>:
>>> Unsigned expressions cannot be lesser than zero. Presence
; 0
./drivers/hsi/controllers/omap_ssi.c:327:5-12: WARNING: Unsigned
expression compared with zero: ssi -> id < 0
./drivers/clk/clk-vt8500.c:462:16-20: WARNING: Unsigned expression
compared with zero: div1 >= 0
./drivers/clk/clk-vt8500.c:506:16-20: WARNING: Unsigned expression
compared with zero: div1 >= 0
./drivers/clk/clk-vt8500.c:395:17-21: WARNING: Unsigned expression
compared with zero: div2 >= 0
./drivers/clk/clk-vt8500.c:463:17-21: WARNING: Unsigned expression
compared with zero: div2 >= 0
./drivers/clk/clk-vt8500.c:507:17-21: WARNING: Unsigned expression
compared with zero: div2 >= 0
^CMakefile:1488: recipe for target 'coccicheck' failed
make: *** [coccicheck] Error 1
--
Regards,
Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2016-01-04 18:01 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes a coding style issue reported by checkpatch related to
>> many leading tabs, removing a 'do while' loop and making use of goto tag
>> instead.
>
> This is hi
2016-01-04 18:00 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> Functions must have the opening brace at the beginning of the next line
>> and body conforming indentation.
>
> This isn't necessary if the function is an empty static inline void
herwise your patches will start to very
>> quickly be ignored.
Good to know. Tks.
>
>
>Just wanted to remind everybody that this option is forced when checking
> the networking code...
Ditto.
>
>> thanks,
>>
>> greg k-h
>
>
> MBR, Sergei
>
-
2016-01-04 17:58 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes coding style issues reported by checkpatch concerning
>> to unnecessary space after a cast.
>
> This is a case where checkpatch is wrong, IMO. Casts should always be
&
2016-01-04 17:50 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes an unsigned comparison to less than 0.
>
> No, it doesn't. It changes an unsigned comparison for less than or
> equal to 0, which is very different from less
This patch fixes coding style issues reported by checkpatch concerning
to unnecessary space after a cast.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci
This patch fixes coding style issues reported by checkpatch. The only
change in this patch that isn't just removing spaces before opening
square brackets is at line 213 where the initialization of fls_strings[]
is placed in same line.
Signed-off-by: Geyslan G. Bem
---
Notes:
Before
This patch fixes coding style issues reported by checkpatch.
Coding style demands usage of C89-style comments and a specific format
when it's multiline.
This also removes the Free Software Foundation address because FSF can
change it again.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host
This patch fixes coding style issues reported by checkpatch concerning
to missing spaces around operators.
There is an additional change on line 49 that removes unnecessary
parenthesis around ternary operands.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers
This patch fixes an unsigned comparison to less than 0.
Signed-off-by: Geyslan G. Bem
---
Notes:
I'm not sure about that comparison because in qh_lines() temp receives
the snprintf() return and thereafter occurs this comparison:
if (size < temp)
temp = s
This patch puts the closing parenthesis at the statement end removing
unnecessary "new line".
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/
n line 50.
- On line 55 a call to ehci_dbg reduced to a single line.
- sizeof operands surrounded with parenthesis on lines 877, 883, 889
and 901.
Signed-off-by: Geyslan G. Bem
---
Notes:
Before this patch there are 105 warnings about spaces before opening
parenthesis.
This patch fixes coding style issue reported by checkpatch concerning to
an unnecessary line before close brace.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index
36920 81 12 37013 9095 drivers/usb/host/ehci-hcd.o
After:
text data bss dec hex filename
36920 81 12 37013 9095 drivers/usb/host/ehci-hcd.o
Signed-off-by: Geyslan G. Bem
---
Notes:
The comment
/* functions have the "wrong" filename when they
This patch fixes a coding style issue reported by checkpatch related to
kmalloc_array usage.
On same line the sizeof operand was enclosed by parenthesis.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
This patch fixes coding style issues reported by checkpatch concerning
to missing line after variable declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index
This patch fixes coding style issues reported by checkpatch concerning
to conditional blocks without braces.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host
This patch fixes a coding style issue reported by checkpatch concerning
to usage of sizeof operand as a variable instead the type.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b
770.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 180 ++--
1 file changed, 88 insertions(+), 92 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 2268756
This patch fixes coding style issues reported by checkpatch concerning
to missing line after struct declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index
Functions must have the opening brace at the beginning of the next line
and body conforming indentation.
This patch also reduces qh_lines() header definition to two lines.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 44 +---
1 file
This patchset removes all errors reported by checkpatch in addition to
some refactoring.
Geyslan G. Bem (17):
usb: host: ehci-dbg: remove space before open parenthesis
usb: host: ehci-dbg: remove space before open square bracket
usb: host: ehci-dbg: use C89-style comments
usb: host: ehci
parameters.
- On line 723 the constant "0x03" is moved to right.
Signed-off-by: Geyslan G. Bem
---
Notes:
Before this patch there are 14 warnings about trailing statements that
should be on next line. After there are still 4. These lines concern to
a macro that will be modifie
n line 50.
- On line 55 a call to ehci_dbg reduced to a single line.
- sizeof operands surrounded with parenthesis on lines 877, 883, 889
and 901.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
Before this patch there are 105 warnings about spaces before opening
This patch fixes an unsigned comparison to less than 0.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
I'm not sure about that comparison because in qh_lines() temp receives
the snprintf() return and thereafter occurs this comparison:
if (size
This patch puts the closing parenthesis at the statement end removing
unnecessary "new line".
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ehci
This patch fixes coding style issues reported by checkpatch.
Coding style demands usage of C89-style comments and a specific format
when it's multiline.
This also removes the Free Software Foundation address because FSF can
change it again.
Signed-off-by: Geyslan G. Bem <geys...@gmail.
This patch fixes coding style issues reported by checkpatch concerning
to missing spaces around operators.
There is an additional change on line 49 that removes unnecessary
parenthesis around ternary operands.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
This patch fixes coding style issues reported by checkpatch. The only
change in this patch that isn't just removing spaces before opening
square brackets is at line 213 where the initialization of fls_strings[]
is placed in same line.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Functions must have the opening brace at the beginning of the next line
and body conforming indentation.
This patch also reduces qh_lines() header definition to two lines.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.
This patchset removes all errors reported by checkpatch in addition to
some refactoring.
Geyslan G. Bem (17):
usb: host: ehci-dbg: remove space before open parenthesis
usb: host: ehci-dbg: remove space before open square bracket
usb: host: ehci-dbg: use C89-style comments
usb: host: ehci
parameters.
- On line 723 the constant "0x03" is moved to right.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
Before this patch there are 14 warnings about trailing statements that
should be on next line. After there are still 4. These lines concern to
a m
This patch fixes coding style issue reported by checkpatch concerning to
an unnecessary line before close brace.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/us
36920 81 12 37013 9095 drivers/usb/host/ehci-hcd.o
After:
text data bss dec hex filename
36920 81 12 37013 9095 drivers/usb/host/ehci-hcd.o
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
The comment
/* functions have the "wrong" filename whe
This patch fixes a coding style issue reported by checkpatch related to
kmalloc_array usage.
On same line the sizeof operand was enclosed by parenthesis.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch fixes coding style issues reported by checkpatch concerning
to missing line after variable declarations.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/us
This patch fixes coding style issues reported by checkpatch concerning
to unnecessary space after a cast.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-d
770.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 180 ++--
1 file changed, 88 insertions(+), 92 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/hos
This patch fixes coding style issues reported by checkpatch concerning
to missing line after struct declarations.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drive
This patch fixes coding style issues reported by checkpatch concerning
to conditional blocks without braces.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci
This patch fixes a coding style issue reported by checkpatch concerning
to usage of sizeof operand as a variable instead the type.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
2016-01-04 18:00 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> Functions must have the opening brace at the beginning of the next line
>> and body conforming indentation.
>
> This isn't necessary if the function
except for
>> drivers/staging/ stuff, otherwise your patches will start to very
>> quickly be ignored.
Good to know. Tks.
>
>
>Just wanted to remind everybody that this option is forced when checking
> the networking code...
Ditto.
>
>> thanks,
>>
>
2016-01-04 17:58 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes coding style issues reported by checkpatch concerning
>> to unnecessary space after a cast.
>
> This is a case where checkpatch is wr
2016-01-04 17:50 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes an unsigned comparison to less than 0.
>
> No, it doesn't. It changes an unsigned comparison for less than or
> equal to 0, which is very
2016-01-04 18:01 GMT-03:00 Alan Stern <st...@rowland.harvard.edu>:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> This patch fixes a coding style issue reported by checkpatch related to
>> many leading tabs, removing a 'do while' loop and making use of goto tag
>&g
2015-12-16 8:21 GMT-03:00 Geyslan G. Bem :
> 2015-12-15 21:13 GMT-03:00 Joe Perches :
>> On Tue, 2015-12-15 at 20:58 -0300, Geyslan G. Bem wrote:
>>> 2015-12-10 8:24 GMT-03:00 Geyslan G. Bem :
>>> > Suggested-by: Peter Senna Tschudin
>>> > Reported-by:
of a construct. This catches it in the middle of
a literal string, or when it's the first thing after something like
"\b"."
This works as a complement to 4e5d56bd.
Signed-off-by: Geyslan G. Bem
Suggested-by: Peter Senna Tschudin
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 ins
2015-12-16 8:21 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> 2015-12-15 21:13 GMT-03:00 Joe Perches <j...@perches.com>:
>> On Tue, 2015-12-15 at 20:58 -0300, Geyslan G. Bem wrote:
>>> 2015-12-10 8:24 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>
of a construct. This catches it in the middle of
a literal string, or when it's the first thing after something like
"\b"."
This works as a complement to 4e5d56bd.
Signed-off-by: Geyslan G. Bem <geys...@gmail.com>
Suggested-by: Peter Senna Tschudin <peter.se...@gmail.com>
2015-12-24 13:27 GMT-03:00 Greg Kroah-Hartman :
> On Thu, Dec 24, 2015 at 01:01:36PM -0300, Geyslan G. Bem wrote:
>>
>> 2015-12-11 18:24 GMT-03:00 Geyslan G. Bem :
>>
>> This cleanup was done with the help of checkpatch and coccinelle tools.
>>
>>
2015-12-13 13:59 GMT-03:00 Geyslan G. Bem :
>
> Cleanup done with the help of coccinelle, checkpatch and cppcheck tools.
>
> Geyslan G. Bem (10):
> usb: host: ehci-sched: refactor scan_isoc function
> usb: host: ehci-sched: move constants to right
> usb: host: ehci-
2015-12-13 13:59 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>
> Cleanup done with the help of coccinelle, checkpatch and cppcheck tools.
>
> Geyslan G. Bem (10):
> usb: host: ehci-sched: refactor scan_isoc function
> usb: host: ehci-sched: move constants to right
&
2015-12-24 13:27 GMT-03:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>:
> On Thu, Dec 24, 2015 at 01:01:36PM -0300, Geyslan G. Bem wrote:
>>
>> 2015-12-11 18:24 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>>
>> This cleanup was done with the
2015-12-15 21:13 GMT-03:00 Joe Perches :
> On Tue, 2015-12-15 at 20:58 -0300, Geyslan G. Bem wrote:
>> 2015-12-10 8:24 GMT-03:00 Geyslan G. Bem :
>> > Suggested-by: Peter Senna Tschudin
>> > Reported-by: Geyslan G. Bem
>> >
>>
>> Joe, do you appl
2015-12-15 21:13 GMT-03:00 Joe Perches <j...@perches.com>:
> On Tue, 2015-12-15 at 20:58 -0300, Geyslan G. Bem wrote:
>> 2015-12-10 8:24 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>> > Suggested-by: Peter Senna Tschudin <peter.se...@gmail.com>
>> > R
2015-12-10 8:24 GMT-03:00 Geyslan G. Bem :
> 2015-12-09 19:59 GMT-03:00 Geyslan G. Bem :
>>
>>
>> 2015-12-07 20:36 GMT-03:00 Geyslan G. Bem :
>>>
>>> 2015-12-07 20:06 GMT-03:00 Joe Perches :
>>> > On Mon, 2015-12-07 at 19:53 -0300, Ge
2015-12-10 8:24 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
> 2015-12-09 19:59 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>>
>>
>> 2015-12-07 20:36 GMT-03:00 Geyslan G. Bem <geys...@gmail.com>:
>>>
>>> 2015-12-07 20:06 GMT-03:00 Joe P
1 - 100 of 538 matches
Mail list logo
