[PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

2024-05-20 Thread Guido Günther
The only key that should wake up the phone is power button press. This prevents accidental wakeup due to e.g. pressing the buttons in the pocket or backpack and is in line what userspace uses to unblank the device. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5

Re: [PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-14 Thread Guido Günther
Hi, On Mon, May 13, 2024 at 03:13:53PM -0700, Dmitry Torokhov wrote: > Hi Guido, > > On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote: > > This helps user space to figure out which keys should be used to unidle a > > device. E.g on phones the volume rocker shoul

[PATCH v1 1/1] Input: gpio-keys - expose wakeup keys in sysfs

2024-05-09 Thread Guido Günther
This helps user space to figure out which keys should be used to unidle a device. E.g on phones the volume rocker should usually not unblank the screen. Signed-off-by: Guido Günther --- drivers/input/keyboard/gpio_keys.c | 23 --- 1 file changed, 16 insertions(+), 7

Re: [PATCH v5 1/2] phy: core: Use runtime pm during configure too

2021-04-12 Thread Guido Günther
Hi, On Mon, Apr 12, 2021 at 04:40:56PM +0800, Liu Ying wrote: > Hi Guido, > > On Fri, 2021-04-09 at 13:40 +0200, Guido Günther wrote: > > The phy's configure phase usually needs register access so taking the > > device out of pm_runtime suspend looks useful. > > > &

[PATCH v5 2/2] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-04-09 Thread Guido Günther
/platform/soc@0/soc@0:bus@3080/30a0.mipi_dsi suspended Signed-off-by: Guido Günther --- drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi

[PATCH v5 0/2] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-04-09 Thread Guido Günther
Guido Günther (2): phy: core: Use runtime pm during configure too phy: fsl-imx8-mipi-dphy: Hook into runtime pm drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 13 + drivers/phy/phy-core.c | 6 ++ 2 files changed, 19 insertions(+) -- 2.30.1

[PATCH v5 1/2] phy: core: Use runtime pm during configure too

2021-04-09 Thread Guido Günther
' runtime phy_pm_runtime handling but manage it manually so this will for now only affect the phy-fsl-imx8-mipi-dphy driver. Signed-off-by: Guido Günther --- drivers/phy/phy-core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index

Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-02-22 Thread Guido Günther
Hi Liu, On Sat, Feb 20, 2021 at 01:37:29PM +0800, Liu Ying wrote: > Hi Guido, > > On Wed, 2020-12-16 at 12:27 +0100, Guido Günther wrote: > > This allows us to shut down the mipi power domain on the imx8. The > > alternative would be to drop the dphy from the mipi power d

[PATCH v4 0/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-02-22 Thread Guido Günther
runtime pm - simplify mixel_dphy_remove Guido Günther (1): phy: fsl-imx8-mipi-dphy: Hook into runtime pm drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 10 ++ 1 file changed, 10 insertions(+) -- 2.30.0

[PATCH v4 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-02-22 Thread Guido Günther
/platform/soc@0/soc@0:bus@3080/30a0.mipi_dsi suspended Signed-off-by: Guido Günther --- drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c

[PATCH v1 1/6] arm64: dts: librem5-devkit: Use a less generic codec name

2021-02-21 Thread Guido Günther
The codec is currently named after the chip but it should be named like the device itself since otherwise it's impossible to distinguish it from other devices using the same codec (e.g. in alsa's UCM). Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2

[PATCH v1 6/6] arm64: dts: librem5-devkit: Move headphone detection to sound card

2021-02-21 Thread Guido Günther
This allows for automatic output source switching in userspace. Enable the pullup on the GPIO to actually make it trigger and mark it as active-high since detection is reversed otherwise. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 21 ++- 1

[PATCH v1 5/6] arm64: dts: librem5-devkit: Add mux for built-in vs headset mic

2021-02-21 Thread Guido Günther
Add mux so we can select either headset or built-in microphone input. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 25 --- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH v1 3/6] arm64: dts: librem5-devkit: "Drop Line In Jack"

2021-02-21 Thread Guido Günther
The SGTL500s LINEINL and LINEINR are N/C. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale

[PATCH v1 4/6] arm64: defconfig: Enable asoc simple mux

2021-02-21 Thread Guido Günther
This is needed to model the mic input mux on the Librem 5 devkit. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index e830d1be6f27..762fb6a132df 100644 --- a/arch

[PATCH v1 2/6] arm64: dts: librem5-devkit: Add speaker amplifier

2021-02-21 Thread Guido Günther
Wire up the amplifier that drives the builtin speaker. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 21 +-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64

[PATCH v1 0/6] arm64: dts: librem5-devkit: Improve audio support

2021-02-21 Thread Guido Günther
done for the Librem 5. Patches are against next-20210210 but also apply against Shawn's imx-dt64-5.12 Guido Günther (6): arm64: dts: librem5-devkit: Use a less generic codec name arm64: dts: librem5-devkit: Add speaker amplifier arm64: dts: librem5-devkit: "Drop Line In Jack&quo

Re: [PATCH v3 0/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2021-02-19 Thread Guido Günther
Hi, On Wed, Dec 16, 2020 at 07:22:32PM +0100, Guido Günther wrote: > This allows us to shut down the mipi power domain on the imx8. The alternative > would be to drop the dphy from the mipi power domain in the SOCs device tree > and only have the DSI host controller visible there but sin

[PATCH v3 4/4] usb: typec: tps6598x: Add trace event for data status

2021-02-15 Thread Guido Günther
This is useful to debug DP negotiation and pin assignment even when the firmware does all the work. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 12 ++- drivers/usb/typec/tps6598x.h | 38 + drivers/usb/typec/tps6598x_trace.h | 54

[PATCH v3 3/4] usb: typec: tps6598x: Add trace event for power status register

2021-02-15 Thread Guido Günther
Together with the PD status register this is vital for debugging power negotiations at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 19 +-- drivers/usb/typec/tps6598x.h | 19 +++ drivers/usb/typec/tps6598x_trace.h | 38

[PATCH v3 1/4] usb: typec: tps6598x: Add trace event for IRQ events

2021-02-15 Thread Guido Günther
Allow to get irq event information via the tracing framework. This allows to inspect USB-C negotiation at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/Makefile | 3 + drivers/usb/typec/tps6598x.c | 9 ++- drivers/usb/typec/tps6598x.h | 64

[PATCH v3 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-15 Thread Guido Günther
This allows to trace status information which helps to debug problems with role switching, etc. We don't use the generic FIELD_GET() to reduce the macro size since we otherwise trip up sparse. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 26 - drivers/usb/typec

[PATCH v3 0/4] usb: typec: tps6598x: Add IRQ flag and register tracing

2021-02-15 Thread Guido Günther
org/linux-usb/20210213031237.GP219708@shao2-debian/ Guido Günther (4): usb: typec: tps6598x: Add trace event for IRQ events usb: typec: tps6598x: Add trace event for status register usb: typec: tps6598x: Add trace event for power status register usb: typec: tps6598x: Add trace event for d

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-15 Thread Guido Günther
Hi, On Sun, Feb 14, 2021 at 09:41:27PM +0100, Luc Van Oostenryck wrote: > On Sun, Feb 14, 2021 at 11:00:48AM -0800, Linus Torvalds wrote: > > On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones > > wrote: > > > > > > > > > > > I looked around but didn't find any hints how to fix this. Any pointers > >

Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-14 Thread Guido Günther
trace.h:157:1: sparse: sparse: too long token > >> expansion > I looked around but didn't find any hints how to fix this. Any pointers I missed (added the sparse list to cc:)? Cheers, -- Guido > vim +157 drivers/usb/typec/./tps6598x_trace.h > > c90c0282e4ce33 Guido Günther 202

[PATCH v2 4/4] usb: typec: tps6598x: Add trace event for data status

2021-02-12 Thread Guido Günther
This is useful to debug DP negotiation and pin assignment even when the firmware does all the work. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 12 ++- drivers/usb/typec/tps6598x.h | 36 drivers/usb/typec/tps6598x_trace.h | 54

[PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-12 Thread Guido Günther
This allows to trace status information which helps to debug problems with role switching, etc. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 26 - drivers/usb/typec/tps6598x.h | 66 + drivers/usb/typec/tps6598x_trace.h | 94

[PATCH v2 1/4] usb: typec: tps6598x: Add trace event for IRQ events

2021-02-12 Thread Guido Günther
Allow to get irq event information via the tracing framework. This allows to inspect USB-C negotiation at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/Makefile | 3 + drivers/usb/typec/tps6598x.c | 9 ++- drivers/usb/typec/tps6598x.h | 64

[PATCH v2 0/4] usb: typec: tps6598x: Add IRQ flag and register tracing

2021-02-12 Thread Guido Günther
ild testes on mips) Guido Günther (4): usb: typec: tps6598x: Add trace event for IRQ events usb: typec: tps6598x: Add trace event for status register usb: typec: tps6598x: Add trace event for power status register usb: typec: tps6598x: Add trace event for data status drivers/usb/ty

[PATCH v2 3/4] usb: typec: tps6598x: Add trace event for power status register

2021-02-12 Thread Guido Günther
Together with the PD status register this is vital for debugging power negotiations at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 19 +-- drivers/usb/typec/tps6598x.h | 19 +++ drivers/usb/typec/tps6598x_trace.h | 38

[PATCH v1 3/4] usb: typec: tps6598x: Add trace event for power status register

2021-02-11 Thread Guido Günther
Together with the PD status register this is vital for debugging power negotiations at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 19 +-- drivers/usb/typec/tps6598x.h | 19 +++ drivers/usb/typec/tps6598x_trace.h | 38

[PATCH v1 4/4] usb: typec: tps6598x: Add trace event for data status

2021-02-11 Thread Guido Günther
This is useful to debug DP negotiation and pin assignment even when the firmware does all the work. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 12 ++- drivers/usb/typec/tps6598x.h | 36 drivers/usb/typec/tps6598x_trace.h | 54

[PATCH v1 2/4] usb: typec: tps6598x: Add trace event for status register

2021-02-11 Thread Guido Günther
This allows to trace status information which helps to debug problems with role switching, etc. Signed-off-by: Guido Günther --- drivers/usb/typec/tps6598x.c | 26 - drivers/usb/typec/tps6598x.h | 66 + drivers/usb/typec/tps6598x_trace.h | 94

[PATCH v1 1/4] usb: typec: tps6598x: Add trace event for IRQ events

2021-02-11 Thread Guido Günther
Allow to get irq event information via the tracing framework. This allows to inspect USB-C negotiation at runtime. Signed-off-by: Guido Günther --- drivers/usb/typec/Makefile | 3 + drivers/usb/typec/tps6598x.c | 9 ++- drivers/usb/typec/tps6598x.h | 61

[PATCH v1 0/4] usb: typec: tps6598x: Add IRQ flag and register tracing

2021-02-11 Thread Guido Günther
ION|DP_CONNECTION, DP pinout D It should not impose any problems for firmwares that don't have IRQs for the registers enabled. The trace will then just be missing those events. Patch is against next-20210210. Guido Günther (4): usb: typec: tps6598x: Add trace event for IRQ events usb: ty

[PATCH] spi: imx: Don't print error on -EPROBEDEFER

2021-01-18 Thread Guido Günther
This avoids [0.962538] spi_imx 3082.spi: bitbang start failed with -517 durig driver probe. Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly") Signed-off-by: Guido Günther --- drivers/spi/spi-imx.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v3 1/4] arm64: defconfig: Enable Librem 5 devkit components

2021-01-11 Thread Guido Günther
Hi, On Mon, Jan 11, 2021 at 08:23:09AM +0800, Shawn Guo wrote: > On Fri, Jan 08, 2021 at 01:57:07PM +0100, Guido Günther wrote: > > The Librem 5 devkit is based on NXP's i.MX8MQ. Schematics are at > > https://source.puri.sm/Librem5/dvk-mx8m-bsb. > > > > This enable

Re: [PATCH] arm64: dts: imx8mq: Add clock parents for mipi dphy

2021-01-10 Thread Guido Günther
Hi, On Sun, Jan 10, 2021 at 08:46:29PM +0800, Shawn Guo wrote: > On Fri, Dec 18, 2020 at 06:50:05PM +0100, Guido Günther wrote: > > This makes sure the clock tree setup for the dphy is not dependent on > > other components. > > > > Without this change bringing u

[PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy

2021-01-10 Thread Guido Günther
/217 if LCDIF doesn't set up that part of the clock tree first. This was noticed when testing the Librem 5 devkit with defconfig. It doesn't happen when modules are built in. Signed-off-by: Guido Günther --- Changes from v1: - as per review comment from Shawn Guo https://lore.kernel.org/linux

Re: [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit

2021-01-10 Thread Guido Günther
Hi Shawn, On Sun, Jan 10, 2021 at 08:26:18PM +0800, Shawn Guo wrote: > On Thu, Dec 17, 2020 at 04:13:11PM +0100, Guido Günther wrote: > > This enables more components to get a working display, panel, audio and > > sensors. It also updates some device tree bits to make mainline boot

[PATCH v3 1/4] arm64: defconfig: Enable Librem 5 devkit components

2021-01-08 Thread Guido Günther
controller - NXP SGTL5000 audio codec - Microcrystal RV-4162-C7 RTC - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS - the SIMCom SIM7100E/A modem - NXP PTN5110HQZ usb-c controller Signed-off-by: Guido Günther Reviewed-by: Krzysztof Kozlowski --- arch/arm64/configs/defconfig | 9 + 1 file changed, 9

[PATCH v3 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators

2021-01-08 Thread Guido Günther
be able to turn these off (and I've tested that or LDO6 and mipi with USB disabled) it is of little practical use atm since USB doesn't runtime suspend so let's revisit this at a later point. Signed-off-by: Guido Günther Reviewed-by: Krzysztof Kozlowski --- .../boot/dts/freescale/imx8mq-librem5

[PATCH v3 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2021-01-08 Thread Guido Günther
24576000 0 0 5 sai6_root_clk 00024576000 0 0 5 Signed-off-by: Guido Günther Reviewed-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 5 - 1 file changed, 5 deletions(-) diff

[PATCH v3 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2021-01-08 Thread Guido Günther
The board has it's own RTC chip which is backed by the (optional) battery and hence preserves data/time on poweroff when that is inserted. Signed-off-by: Guido Günther Reviewed-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 1 file changed, 4

[PATCH v3 0/4] Config and device tree updates for the Librem 5 development kit

2021-01-08 Thread Guido Günther
doesn't hang when resuming the gpu power domain. There's a generic fix pending for that helps all boards https://lore.kernel.org/lkml/beba25e85db20649aa040fc0ae549895c9265f6f.ca...@fi.rohmeurope.com/ Guido Günther (4): arm64: defconfig: Enable Librem 5 devkit components arm64: dts: imx8mq

Re: [PATCH v2] regulators: bd718x7: Add enable times

2020-12-21 Thread Guido Günther
Hi, On Mon, Dec 21, 2020 at 06:08:15AM +, Vaittinen, Matti wrote: > > On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote: > > Use the typical startup times from the data sheet so boards get a > > reasonable default. Not setting any enable time can lead to board >

[PATCH v2] regulators: bd718x7: Add enable times

2020-12-18 Thread Guido Günther
Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards. This fixes gpu power domain resume on the Librem 5. Signed-off-by: Guido Günther --- v2 - As per review

[PATCH] arm64: dts: imx8mq: Add clock parents for mipi dphy

2020-12-18 Thread Guido Günther
/217 if LCDIF doesn't set up that part of the clock tree first. This was noticed when testing the Librem 5 devkit with defconfig. It doesn't happen when modules are built in. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 11 --- 1 file changed, 8 insertions

[PATCH v1 3/3] arm64: defconfig: Enable more DM/MD targets as modules

2020-12-18 Thread Guido Günther
Most notably DM_CRYPT for disk encryption but things like snapshot, etc. are useful on embedded as well and the others make sense on arm64 servers. CONFIG_BLK_DEV_MD gets dropped because other config options like CONFIG_MD_RAID0 depend on it. Signed-off-by: Guido Günther --- arch/arm64/configs

[PATCH v1 2/3] arm64: defconfig: Enable more filesystems

2020-12-18 Thread Guido Günther
xfs, f2fs and iso are common enough to have them everywhere. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index e42ba0c8f302..6f5f03237db6 100644 --- a/arch

[PATCH v1 0/3] arm64: defconfig: Enable some (hopefully) useful options

2020-12-18 Thread Guido Günther
specific I have no idea which tree I would target so I picked next-20201218. Guido Günther (3): arm64: defconfig: Enable function tracer arm64: defconfig: Enable more filesystems arm64: defconfig: Enable more DM/MD targets as modules arch/arm64/configs/defconfig | 26

[PATCH v1 1/3] arm64: defconfig: Enable function tracer

2020-12-18 Thread Guido Günther
This allows for way easier runtime inspection and debugging. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index e7aef72206e3..e42ba0c8f302 100644

[PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators

2020-12-17 Thread Guido Günther
be able to turn these off (and I've tested that or LDO6 and mipi with USB disabled) it is of little practical use atm since USB doesn't runtime suspend so let's revisit this at a later point. Signed-off-by: Guido Günther --- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11

[PATCH v2 1/4] arm64: defconfig: Enable Librem 5 devkit components

2020-12-17 Thread Guido Günther
controller - NXP SGTL5000 audio codec - Microcrystal RV-4162-C7 RTC - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS - the SIMCom SIM7100E/A modem Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch

[PATCH v2 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2020-12-17 Thread Guido Günther
24576000 0 0 5 sai6_root_clk 00024576000 0 0 5 Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm64/boot/dts

[PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2020-12-17 Thread Guido Günther
The board has it's own RTC chip which is backed by the (optional) battery and hence preserves data/time on poweroff when that is inserted. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64

[PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit

2020-12-17 Thread Guido Günther
,Vinod Koul ,Anson Huang ,Michael Walle ,devicet...@vger.kernel.org,linux-arm-ker...@lists.infradead.org,linux-kernel@vger.kernel.org,phone-de...@vger.kernel.org Guido Günther (4): arm64: defconfig: Enable Librem 5 devkit components arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators

Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2020-12-16 Thread Guido Günther
Hi Lucas, On Wed, Dec 16, 2020 at 01:05:36PM +0100, Lucas Stach wrote: > Hi Guido, > > this time hopefully with less broken quoting. My mailer is driving me > mad right now... > > Am Mittwoch, dem 16.12.2020 um 12:27 +0100 schrieb Guido Günther: > > This allows us to

[PATCH v3 0/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2020-12-16 Thread Guido Günther
/ee22b072e0abe07559a3e6a63ccf6ece064a46cb.ca...@pengutronix.de/ Check for pm_runtime_get_sync failure Guido Günther (1): phy: fsl-imx8-mipi-dphy: Hook into runtime pm .../phy/freescale/phy-fsl-imx8-mipi-dphy.c| 25 ++- 1 file changed, 24 insertions(+), 1 deletion(-) -- 2.29.2

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Guido Günther
Hi Matti, On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > Hello Guido, > > Thanks for looking at this! > > On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: > > Use the typical startup times from the data sheet so boards get a > > reasonab

[PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2020-12-16 Thread Guido Günther
/platform/soc@0/soc@0:bus@3080/30a0.mipi_dsi suspended Signed-off-by: Guido Günther --- .../phy/freescale/phy-fsl-imx8-mipi-dphy.c| 22 ++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale

[PATCH v2 0/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm

2020-12-16 Thread Guido Günther
/platform/soc@0/soc@0:bus@3080/30a00300.dphy suspended /devices/platform/soc@0/soc@0:bus@3080/30a0.mipi_dsi suspended Changes from v1: - Tweak commit message slightly Guido Günther (1): phy: fsl-imx8-mipi-dphy: Hook into runtime pm .../phy/freescale/phy-fsl-imx8-mipi-dphy.c

[PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Guido Günther
Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards. This fixes gpu power domain resume on the Librem 5. Signed-off-by: Guido Günther --- drivers/regulator

[PATCH 0/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Guido Günther
Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards. This fixes gpu power domain resume on the Librem 5. Guido Günther (1): regulators: bd718x7: Add enable

Re: [PATCH 1/4] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2020-12-15 Thread Guido Günther
Hi, On Tue, Dec 08, 2020 at 10:04:57AM +0100, Guido Günther wrote: > Hi, > On Fri, Dec 04, 2020 at 03:33:41PM +0800, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either >

[PATCH v1 1/1] drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge

2020-12-15 Thread Guido Günther
the only DRM_DEV_ERROR() usage, the rest of the driver uses dev_err(). Signed-off-by: Guido Günther Fixes: c42001e357f7 ("drm: mxsfb: Use drm_panel_bridge") --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu

[PATCH v1 0/1] drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge

2020-12-15 Thread Guido Günther
the only DRM_DEV_ERROR() usage, the rest of the driver uses dev_err(). Guido Günther (1): drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.29.2

[PATCH 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2020-12-13 Thread Guido Günther
Otherwise the boot hangs early on. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on

2020-12-13 Thread Guido Günther
They power vital parts of the board and low power consumption is not really an issue here. It also brings things more in line with what Purism is using downstream. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 19 ++- 1 file changed, 10

[PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2020-12-13 Thread Guido Günther
The board has it's own rtc chip. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

2020-12-13 Thread Guido Günther
: CONFIG_USB_SERIAL_OPTION Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index c8ca76751a34..dd70bf09659d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs

[PATCH 0/4] Config and device tree updates for the Librem5 Devkit

2020-12-13 Thread Guido Günther
could be applied independently. The series was tested against next-20201209 and i made sure the defconfig changes also apply on top of shawnguo/imx/defconfig. Guido Günther (4): arm64: defconfig: Enable Librem5 Devkit components arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc arm64: dts

Re: [PATCH v3 3/5] dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema

2020-12-13 Thread Guido Günther
takes reference to the latest > dphy node in imx8mq.dtsi. > > Cc: Guido Günther > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: Rob Herring > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- > v2->v3: > * Improve the 'clock-names' property by d

Re: [PATCH v3 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2020-12-13 Thread Guido Günther
Hi, On Fri, Dec 11, 2020 at 09:46:21AM +0800, Liu Ying wrote: > Add support for Mixel MIPI DPHY + LVDS PHY combo IP > as found on Freescale i.MX8qxp SoC. > > Cc: Guido Günther > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: Rob Herring > Cc: NXP Linux Team &

Re: [PATCH v3 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-13 Thread Guido Günther
he LVDS PHY mode only > for the i.MX8qxp Mixel combo PHY, i.e., the MIPI DPHY mode is yet to be > supported, so for now error would be returned from ->set_mode() if MIPI > DPHY mode is passed over to it for the combo PHY. > > Cc: Guido Günther > Cc: Robert Chiras > Cc: Kishon Vijay Abrah

Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-09 Thread Guido Günther
Hi, On Tue, Dec 08, 2020 at 06:03:05PM +0800, Liu Ying wrote: > On Tue, 2020-12-08 at 10:24 +0100, Guido Günther wrote: > > Hi Liu, > > some minor comments inline: > > > > On Fri, Dec 04, 2020 at 03:33:44PM +0800, Liu Ying wrote: > > > i.MX8qxp SoC embeds a Mi

Re: [PATCH v2 6/6] dt-binding: display: mantix: Add compatible for panel from YS

2020-12-08 Thread Guido Günther
Hi, On Mon, Dec 07, 2020 at 03:32:06PM -0600, Rob Herring wrote: > On Wed, 18 Nov 2020 09:29:53 +0100, Guido Günther wrote: > > This panel from Shenzhen Yashi Changhua Intelligent Technology Co > > uses the same driver IC but a different LCD. > > > > Signed-off-by:

Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-08 Thread Guido Günther
t this patch supports the LVDS PHY mode only > for the i.MX8qxp Mixel combo PHY, i.e., the MIPI DPHY mode is yet to be > supported, so for now error would be returned from ->set_mode() if MIPI > DPHY mode is passed over to it for the combo PHY. > > Cc: Guido Günther > Cc: Robert

Re: [PATCH 3/4] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2020-12-08 Thread Guido Günther
found on Freescale i.MX8qxp SoC. > > Cc: Guido Günther > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: Rob Herring > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- > Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.txt | 8 +++- > 1 file

Re: [PATCH 1/4] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable()

2020-12-08 Thread Guido Günther
l_dsi_enable() to set PHY mode to MIPI DPHY > explicitly. > > Cc: Guido Günther > Cc: Robert Chiras > Cc: Martin Kepplinger > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: D

Re: [PATCH 0/4] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-08 Thread Guido Günther
Hi Liu, On Fri, Dec 04, 2020 at 03:33:40PM +0800, Liu Ying wrote: > Hi, > > This series adds i.MX8qxp LVDS PHY mode support for the Mixel PHY in the > Freescale i.MX8qxp SoC. This looks good to me from the NWL and actual phy driver part. I'll comment in the individual patches but leave comments

[PATCH v5 2/2] usb: typec: tps6598x: Export some power supply properties

2020-12-05 Thread Guido Günther
This allows downstream supplies and userspace to detect whether external power is supplied. Signed-off-by: Guido Günther Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko --- drivers/usb/typec/Kconfig| 1 + drivers/usb/typec/tps6598x.c | 103

[PATCH v5 1/2] usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C

2020-12-05 Thread Guido Günther
;Kconfig recursive dependency limitations" when selecting POWER_SUPPLY. Signed-off-by: Guido Günther Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko --- drivers/usb/typec/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/Kconfig b/driv

[PATCH v5 0/2] usb: typec: tps6598x: Export some power supply properties

2020-12-05 Thread Guido Günther
- use POWER_SUPPLY_USB_TYPE_PD when a PD contract got negotiated Guido Günther (2): usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C usb: typec: tps6598x: Export some power supply properties drivers/usb/typec/Kconfig| 5 +- drivers/usb/typec/tps6598x.c | 103

Re: [PATCH v2 0/6] drm/panel: mantix and st7703 fixes and additions

2020-12-04 Thread Guido Günther
Hi Linus, On Thu, Nov 19, 2020 at 09:35:17AM +0100, Linus Walleij wrote: > On Wed, Nov 18, 2020 at 9:29 AM Guido Günther wrote: > > > This adds new panel type to the mantix driver as found on the Librem 5 and > > fixes a glitch in the init sequence (affecting bot

Re: [PATCH v4 2/2] usb: typec: tps6598x: Export some power supply properties

2020-12-01 Thread Guido Günther
Hi Andy, On Tue, Dec 01, 2020 at 03:52:40PM +0200, Andy Shevchenko wrote: > On Tue, Dec 1, 2020 at 2:59 PM Guido Günther wrote: > > This allows downstream supplies and userspace to detect > > whether external power is supplied. > > ... > > > +static int devm_tps659

Re: [PATCH v2 4/7] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

2020-12-01 Thread Guido Günther
Hi Martin, On Tue, Dec 01, 2020 at 01:39:29PM +0100, Martin Kepplinger wrote: > Add optional interconnect properties for the dram path requests. > > Signed-off-by: Martin Kepplinger > --- > Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [PATCH v3 2/2] usb: typec: tps6598x: Export some power supply properties

2020-12-01 Thread Guido Günther
Hi, On Mon, Nov 30, 2020 at 08:35:26PM +0200, Andy Shevchenko wrote: > On Fri, Nov 27, 2020 at 2:57 PM Guido Günther wrote: > > > > This allows downstream supplies and userspace to detect > > whether external power is supplied. > > > + if (!(pwr_status

[PATCH v4 2/2] usb: typec: tps6598x: Export some power supply properties

2020-12-01 Thread Guido Günther
This allows downstream supplies and userspace to detect whether external power is supplied. Signed-off-by: Guido Günther Reviewed-by: Heikki Krogerus --- drivers/usb/typec/Kconfig| 1 + drivers/usb/typec/tps6598x.c | 105 +++ 2 files changed, 106

[PATCH v4 0/2] usb: typec: tps6598x: Export some power supply properties

2020-12-01 Thread Guido Günther
Kroah-Hartman ,linux-...@vger.kernel.org,linux-kernel@vger.kernel.org,Andy Shevchenko Guido Günther (2): usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C usb: typec: tps6598x: Export some power supply properties drivers/usb/typec/Kconfig| 5 +- drivers/usb/typec/tps6598x.c

[PATCH v4 1/2] usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C

2020-12-01 Thread Guido Günther
;Kconfig recursive dependency limitations" when selecting POWER_SUPPLY. Signed-off-by: Guido Günther Reviewed-by: Heikki Krogerus --- drivers/usb/typec/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index

[PATCH v1 0/1] drm/imx/dcss: Add interconnect support

2020-12-01 Thread Guido Günther
in a cyan screen. Modelled like mdp5_kms. Guido Günther (1): drm/imx/dcss: Add interconnect support drivers/gpu/drm/imx/dcss/dcss-dev.c | 47 +++-- drivers/gpu/drm/imx/dcss/dcss-dev.h | 3 ++ 2 files changed, 48 insertions(+), 2 deletions(-) -- 2.29.2

[PATCH v1 1/1] drm/imx/dcss: Add interconnect support

2020-12-01 Thread Guido Günther
This allows us to raise DRAM bandiwth to a high enough value for a stable picture on i.mx8mq. We pick a bandwidth that should be sufficient for 4k@60Hz. Modelled like mdp5_kms. Signed-off-by: Guido Günther --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 47 +++-- drivers/gpu

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

2020-11-29 Thread Guido Günther
Hi Pavel, On Sat, Nov 28, 2020 at 09:58:48PM +0100, Pavel Machek wrote: > Hi! > > > > > This series enables components found on Purism's Librem 5 > > > > that are available in mainline. > > > > > > > > - changes from v1 > > > > - As per review comments from Krzysztof Kozlowski > > > > > >

Re: [PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

2020-11-28 Thread Guido Günther
Hi, On Fri, Nov 27, 2020 at 05:45:03PM +0100, Geert Uytterhoeven wrote: > Hi Guido, > > Thanks for your patch! > > On Fri, Nov 27, 2020 at 5:42 PM Guido Günther wrote: > > This enables > > > > - CONFIG_BATTERY_MAX17042: battery chip > > - CO

[PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

2020-11-28 Thread Guido Günther
backlight - CONFIG_REGULATOR_TPS65132: regulator for the LCD panel - CONFIG_TOUCHSCREEN_EDT_FT5X06: touch controller - CONFIG_TYPEC_TPS6598X: USB PD controller - CONFIG_VCNL4000: ambient light and proximity sensor as modules. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 12

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

2020-11-28 Thread Guido Günther
Hi Pavel, On Fri, Nov 27, 2020 at 09:09:08PM +0100, Pavel Machek wrote: > Hi! > > > This series enables components found on Purism's Librem 5 > > that are available in mainline. > > > > - changes from v1 > > - As per review comments from Krzysztof Kozlowski > > > >

[PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

2020-11-28 Thread Guido Günther
are on top of Shawn's imx/defconfig Guido Günther (1): arm64: defconfig: Enable more Librem 5 hardware arch/arm64/configs/defconfig | 12 1 file changed, 12 insertions(+) -- 2.29.2

[PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

2020-11-27 Thread Guido Günther
- CONFIG_TOUCHSCREEN_EDT_FT5X06: touch controller - CONFIG_TYPEC_TPS6598X: USB PD controller - CONFIG_VCNL4000: ambient light and proximiry sensor as modules. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/configs/defconfig b

Re: [PATCH v1 6/8] arm64: defconfig: Enable CONFIG_VCNL4000

2020-11-27 Thread Guido Günther
Hi Krzysztof, On Fri, Nov 27, 2020 at 05:13:58PM +0100, Krzysztof Kozlowski wrote: > On Fri, 27 Nov 2020 at 15:23, Guido Günther wrote: > > > > This is the Librem 5's proximity sensor. > > Just squash all of them. Enabling option by option is too much. Done for v2. Cheers,

  1   2   3   4   >