[PATCH v4 resend 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-02-04 Thread Hans de Goede
y: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 12 +++- sound/soc/codecs/wm5110.c | 12 +++- sound/soc/codecs/wm8997.c | 14 -- sound/soc/codecs/wm8998.c | 9 + 4 files changed, 43 insertions(+), 4

[PATCH v4 resend 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-02-04 Thread Hans de Goede
d-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/

[PATCH v4 resend 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-02-04 Thread Hans de Goede
ndy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 42 ++--- sound/soc/codecs/arizona.h | 1 - 2 files changed, 18 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/arizona-jac

[PATCH v4 resend 01/13] mfd: arizona: Drop arizona-extcon cells

2021-02-04 Thread Hans de Goede
The arizona jack-dection handling is being reworked so that the codec-child-device drivers directly handle jack-detect themselves, so it is no longer necessary to instantiate "arizona-extcon" child-devices. Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Han

[PATCH v4 resend 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-02-04 Thread Hans de Goede
ound/soc/codecs/arizona-jack.c . This is a preparation patch for converting the arizona extcon-driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Ha

[PATCH v4 resend 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-02-04 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff

[PATCH v4 resend 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2021-02-04 Thread Hans de Goede
ked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 76aacbac5869..72d23b15108c 100644 --- a/drivers/extcon/extcon-arizona.c ++

[PATCH v4 resend 03/13] extcon: arizona: Fix various races on driver unbind

2021-02-04 Thread Hans de Goede
of various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede

Re: [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-04 Thread Hans de Goede
Hi, On 2/4/21 12:05 PM, Lee Jones wrote: > On Sat, 23 Jan 2021, Hans de Goede wrote: > >> Hi all, >> >> Here is v4 of my series to rework the arizona codec jack-detect support >> to use the snd_soc_jack helpers instead of direct extcon reporting. >> >> T

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Hans de Goede
Hi, On 2/4/21 11:57 AM, Lee Jones wrote: > On Thu, 04 Feb 2021, Hans de Goede wrote: > >> Hi all, >> >> On 1/20/21 10:49 PM, Hans de Goede wrote: >>> Hi All, >>> >>> Here is v4 of my series to add support for Intel Bay Trail based devices

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Hans de Goede
Hi all, On 1/20/21 10:49 PM, Hans de Goede wrote: > Hi All, > > Here is v4 of my series to add support for Intel Bay Trail based devices > which use a WM5102 codec for audio output/input. > > This was developed and tested on a Lenovo Yoga Tablet 1051L. > > The MFD an

Re: linux-next: build warning after merge of the drivers-x86 tree

2021-02-03 Thread Hans de Goede
Hi Stephen, Andy, On 2/4/21 6:13 AM, Stephen Rothwell wrote: > Hi all, > > After merging the drivers-x86 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt': >

Re: [PATCH] platform/x86/intel-uncore-freq: Add Sapphire Rapids server support

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 12:43 PM, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > Sapphire Rapids uncore frequency control is the same as Skylake and Ice Lake. > Add the Sapphire Rapids CPU model number to the match array. > > Signed-off-by: Artem Bityutskiy > Reviewed-by: Tony Luck Thank you

Re: [PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable

2021-02-03 Thread Hans de Goede
Hi, On 1/26/21 9:55 PM, David E. Box wrote: > Fix error in Kconfig that exposed INTEL_PMT_CLASS as a user selectable > option. It is already selected by INTEL_PMT_TELEMETRY and > INTEL_PMT_CRASHLOG which are user selectable. > > Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver") >

Re: [PATCH] platform/surface: aggregator: Fix braces in if condition with unlikely() macro

2021-02-03 Thread Hans de Goede
Hi, On 1/26/21 6:22 PM, Maximilian Luz wrote: > The braces of the unlikely() macro inside the if condition only cover > the subtraction part, not the whole statement. This causes the result of > the subtraction to be converted to zero or one. While that still works > in this context, it causes

[GIT PULL] platform-drivers-x86 for 5.11-3

2021-02-03 Thread Hans de Goede
-sysman: - fix a NULL pointer dereference hp-wmi: - Disable tablet-mode reporting by default Hans de Goede (1): platform/x86: hp-wmi: Disable tablet-mode reporting by default Mario Limonciello (1): platform/x86: dell-wmi

Re: [PATCH 0/3] Platform: OLPC: A couple of fixes

2021-02-02 Thread Hans de Goede
hi, On 1/26/21 8:37 AM, Lubomir Rintel wrote: > Hi, > > chained to this message is a couple of fixes related to OLPC EC platform > code. Please take a look and consider applying to platform-drivers-x86. Thank you for your patch-series, I've applied the series to my review-hans branch:

Re: [PATCH 6/6] xhci: ext-caps: Use software node API with the properties

2021-02-02 Thread Hans de Goede
vice is tied to the > lifetime of device itself. > > Signed-off-by: Heikki Krogerus > Cc: Hans de Goede Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/usb/host/xhci-ext-caps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH] platform/x86: amd-pmc: put device on error paths

2021-02-02 Thread Hans de Goede
Hi, On 1/21/21 5:50 AM, Pan Bian wrote: > Put the PCI device rdev on error paths to fix potential reference count > leaks. > > Signed-off-by: Pan Bian Thank you for your patch, I've applied this patch to my review-hans branch:

Re: [PATCH v2 2/2] platform/x86: ideapad-laptop: DYTC Platform profile support

2021-02-02 Thread Hans de Goede
Hi, On 1/5/21 2:14 PM, Jiaxun Yang wrote: > Add support to ideapad-laptop for Lenovo platforms that have DYTC > version 5 support or newer to use the platform profile feature. > > Mostly based on Mark Pearson 's thinkpad-acpi > work but massaged to fit ideapad driver. > > Note that different

Re: [PATCH] platform/x86: thinkpad_acpi: rectify length of title underline

2021-02-02 Thread Hans de Goede
Hi, On 1/29/21 5:08 AM, Lukas Bulwahn wrote: > Commit d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language") > adds information on keyboard setting to the thinkpad documentation, but > made the subsection title underline too short. > > Hence, make htmldocs warns: > >

Re: [PATCH] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-02-02 Thread Hans de Goede
sabled by quirk to > prevent them from keeping the driver loaded if only disabled capabilities > are found. > > Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support") > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede

Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-02-02 Thread Hans de Goede
Hi, On 2/2/21 10:32 AM, Pavel Machek wrote: > Hi! > >>> Is it a regression? AFAIK it is a bug that has been there >>> forever... My original plan was to simply wait for 5.12, so it gets >>> full release of testing... >> >> It may have been a pre-existing bug which got triggered by libata >>

Re: [PATCH v3 0/3] common SVDM version and VDO from dt

2021-02-01 Thread Hans de Goede
Hi, On 2/1/21 2:34 PM, Kyle Tso wrote: > patch v2: > https://lore.kernel.org/linux-devicetree/20210131151832.215931-1-kyle...@google.com/ > > Changes since v2: > = > usb: typec: Determine common SVDM Versions > - rename the variable and the functions (remove the text "common") >

Re: [PATCH] platform/x86: dell-wmi-sysman: fix a NULL pointer dereference

2021-02-01 Thread Hans de Goede
Hi, On 2/1/21 3:36 AM, Perry Yuan wrote: > Hi Hans. > Could you share your the commit link after you apply this patch to your > for-next branch? https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next=64b0efa18f8c3b1baac369b8d74d0fdae02bc4bc

Re: [PATCH] platform/x86: dell-wmi-sysman: fix a NULL pointer dereference

2021-01-31 Thread Hans de Goede
Hi, On 1/31/21 3:04 PM, Limonciello, Mario wrote: > > >> -Original Message----- >> From: Hans de Goede >> Sent: Saturday, January 30, 2021 15:44 >> To: Limonciello, Mario; Mark Gross >> Cc: LKML; platform-driver-...@vger.kernel.org >> Subject: Re:

Re: [PATCH] platform/x86: dell-wmi-sysman: fix a NULL pointer dereference

2021-01-30 Thread Hans de Goede
Hi, On 1/29/21 6:26 PM, Mario Limonciello wrote: > An upcoming Dell platform is causing a NULL pointer dereference > in dell-wmi-sysman initialization. Validate that the input from > BIOS matches correct ACPI types and abort module initialization > if it fails. > > This leads to a memory leak

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

2021-01-30 Thread Hans de Goede
Hi, On 1/30/21 8:14 PM, Filipe Laíns wrote: > Hans, > > You added support for non unifying receivers in > 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure > this cause any breakage with your devices? > > AFAIK, they could only break if they have a 0x01 report which

Re: [PATCH v4 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-30 Thread Hans de Goede
Hi, On 1/30/21 4:40 PM, Charles Keepax wrote: > On Sat, Jan 23, 2021 at 01:17:20PM +0100, Hans de Goede wrote: >> Add jack detect support by creating a jack and calling >> snd_soc_component_set_jack to register the created jack >> with the codec. >> >> Reviewed-b

Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

2021-01-29 Thread Hans de Goede
Hi, On 1/29/21 9:28 PM, Linus Torvalds wrote: > On Fri, Jan 29, 2021 at 12:02 PM Linus Torvalds > wrote: >> >> It's fairly easy to work around in this in the tty layer by just >> avoiding that function entirely, so I'll cook up a patch to do that. >> But I'm adding the appropriate people to the

Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

2021-01-29 Thread Hans de Goede
Hi Linus, On 1/29/21 7:23 PM, Hans de Goede wrote: > Hi, > > On 1/29/21 7:09 PM, Linus Torvalds wrote: >> On Fri, Jan 29, 2021 at 6:54 AM Hans de Goede wrote: >>> >>> While testing 5.11-rc5 I noticed that flicker-free boot was no longer >>> flick

Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

2021-01-29 Thread Hans de Goede
Hi, On 1/29/21 7:09 PM, Linus Torvalds wrote: > On Fri, Jan 29, 2021 at 6:54 AM Hans de Goede wrote: >> >> While testing 5.11-rc5 I noticed that flicker-free boot was no longer >> flicker free, >> when plymouth loads and tells systemd to start logging detail

Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-01-28 Thread Hans de Goede
Hi, On 1/27/21 11:01 PM, Pavel Machek wrote: > Hi! > > Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm > (which still > emulates good old piix ATA controllers) I get the below lockdep splat > early on during boot: > > This seems to be led-class

Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-01-25 Thread Hans de Goede
Hi, On 1/13/21 9:59 AM, Hans de Goede wrote: > Hi, > > On 1/12/21 11:30 PM, Pavel Machek wrote: >> Hi! >> >>> Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm >>> (which still >>> emulates good old piix ATA controllers) I

Re: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-24 Thread Hans de Goede
Hi, On 1/24/21 8:53 PM, Andy Shevchenko wrote: > On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede wrote: >> >> Cleanup the use of dev_foo functions used for logging: >> >> 1. Many of these are unnecessarily split over multiple lines >> 2. Use dev_err_pr

[PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-23 Thread Hans de Goede
Cleanup the use of dev_foo functions used for logging: 1. Many of these are unnecessarily split over multiple lines 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER return value Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: - While

[PATCH v4 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-23 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-01-23 Thread Hans de Goede
d-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-ja

[PATCH v4 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-01-23 Thread Hans de Goede
Signed-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 12 +++- sound/soc/codecs/wm5110.c | 12 +++- sound/soc/codecs/wm8997.c | 14 -- sound/soc/codecs/wm8998.c | 9 + 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm5102.c b

[PATCH v4 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-23 Thread Hans de Goede
ndy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 42 ++--- sound/soc/codecs/arizona.h | 1 - 2 files changed, 18 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index 5b40316d0

[PATCH v4 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-23 Thread Hans de Goede
ers for codecs which are converted to use the new helper functions from arizona-jack.c are modified to create a snd_soc_jack through snd_soc_card_jack_new() and register this jack with the codec through snd_soc_component_set_jack(). Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Chan

[PATCH v4 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-01-23 Thread Hans de Goede
ound/soc/codecs/arizona-jack.c . This is a preparation patch for converting the arizona extcon-driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Signed-off-by: Hans de Goede --- Changes in v4: - Add s

[PATCH v4 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-01-23 Thread Hans de Goede
. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff --git a/sound/soc/codecs

[PATCH v4 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-01-23 Thread Hans de Goede
(). Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v3: - This is a new patch in v3 of this patch-set --- drivers/extcon/extcon-arizona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c

[PATCH v4 01/13] mfd: arizona: Drop arizona-extcon cells

2021-01-23 Thread Hans de Goede
The arizona jack-dection handling is being reworked so that the codec-child-device drivers directly handle jack-detect themselves, so it is no longer necessary to instantiate "arizona-extcon" child-devices. Signed-off-by: Hans de Goede --- drivers/mfd/arizona-core.c | 20 -

[PATCH v4 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2021-01-23 Thread Hans de Goede
ked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 76aacbac5869..72d23b15108c 100644 --- a/drivers/extcon/extcon-arizona.c ++

[PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-01-23 Thread Hans de Goede
other small tweaks, see individual patch changelogs Regards, Hans Hans de Goede (13): mfd: arizona: Drop arizona-extcon cells extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged extcon: arizona: Fix various races on driver unbind extcon: arizo

[PATCH v4 03/13] extcon: arizona: Fix various races on driver unbind

2021-01-23 Thread Hans de Goede
of various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c

[PATCH v4 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-01-23 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon

Re: [PATCH] regulator: core: Avoid debugfs: Directory ... already present! error

2021-01-23 Thread Hans de Goede
Hi, On 1/23/21 11:29 AM, Charles Keepax wrote: > On Fri, Jan 22, 2021 at 07:32:50PM +0100, Hans de Goede wrote: >> Sometimes regulator_get() gets called twice for the same supply on the >> same device. This may happen e.g. when a framework / library is used >> whi

Re: [PATCH v3 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-22 Thread Hans de Goede
HI, On 1/22/21 9:56 PM, Andy Shevchenko wrote: > On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote: >> >> Cleanup the use of dev_foo functions used for logging: >> >> 1. Many of these are unnecessarily split over multiple lines >> 2. Use dev_err_pr

Re: [PATCH v3 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-01-22 Thread Hans de Goede
Hi, On 1/22/21 9:40 PM, Andy Shevchenko wrote: > On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote: >> >> The jack handling for arizona codecs is being refactored so that it is >> done directly by the codec drivers, instead of having an extcon-driver >> bind to

Re: [PATCH v3 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-01-22 Thread Hans de Goede
Hi, On 1/22/21 9:38 PM, Andy Shevchenko wrote: > On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede wrote: >> >> Before this commit the extcon-arizona code was mixing pm_runtime_get() >> and pm_runtime_get_sync() in different places. >> >> In all places where

[PATCH] regulator: core: Avoid debugfs: Directory ... already present! error

2021-01-22 Thread Hans de Goede
Cc: Charles Keepax Signed-off-by: Hans de Goede --- drivers/regulator/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ca03d8e70bd1..75ec6f334506 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.

[PATCH v3 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-01-22 Thread Hans de Goede
Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index e121490eb379..26

[PATCH v3 01/13] mfd: arizona: Drop arizona-extcon cells

2021-01-22 Thread Hans de Goede
The arizona jack-dection handling is being reworked so that the codec-child-device drivers directly handle jack-detect themselves, so it is no longer necessary to instantiate "arizona-extcon" child-devices. Signed-off-by: Hans de Goede --- drivers/mfd/arizona-core.c | 20 -

[PATCH v3 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2021-01-22 Thread Hans de Goede
ked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 76aacbac5869..72d23b15108c 100644 --- a/drivers/extcon/extcon-arizona.c ++

[PATCH v3 03/13] extcon: arizona: Fix various races on driver unbind

2021-01-22 Thread Hans de Goede
of various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c

[PATCH v3 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-01-22 Thread Hans de Goede
dding arizona-jack.c as a copy and then later removing extcon-arizona.c -Some other small tweaks, see individual patch changelogs Regards, Hans Hans de Goede (13): mfd: arizona: Drop arizona-extcon cells extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplu

[PATCH v3 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-01-22 Thread Hans de Goede
ound/soc/codecs/arizona-jack.c . This is a preparation patch for converting the arizona extcon-driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Signed-off-by: Hans de Goede --- Changes in v3: - Fold the 2

[PATCH v3 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-01-22 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon

[PATCH v3 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-01-22 Thread Hans de Goede
(). Signed-off-by: Hans de Goede --- Changes in v3: - This is a new patch in v3 of this patch-set --- drivers/extcon/extcon-arizona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 72d23b15108c..56d2ce05de50

[PATCH v3 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-01-22 Thread Hans de Goede
Make all arizona codec drivers for which drivers/mfd/arizona-core.c used to instantiate a "arizona-extcon" child-device use the new arizona-jack.c library for jack-detection. This has been tested on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec. Signed-off-by: Hans de Goede ---

[PATCH v3 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-22 Thread Hans de Goede
ers for codecs which are converted to use the new helper functions from arizona-jack.c are modified to create a snd_soc_jack through snd_soc_card_jack_new() and register this jack with the codec through snd_soc_component_set_jack(). Signed-off-by: Hans de Goede --- Changes in v3: - Pass dev (the co

[PATCH v3 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-22 Thread Hans de Goede
has already been enabled on the parent-device by the arizona MFD driver. This is part of a patch series converting the arizona extcon driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Signed-off-by: Hans

[PATCH v3 11/13] ASoC: arizona-jack: Cleanup logging

2021-01-22 Thread Hans de Goede
Cleanup the use of dev_foo functions used for logging: 1. Many of these are unnecessarily split over multiple lines 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFERRED return value Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v3

[PATCH v3 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-22 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v3 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-01-22 Thread Hans de Goede
. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff --git a/sound/soc/codecs

Re: [PATCH v2 07/12] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-22 Thread Hans de Goede
Hi, On 1/22/21 10:38 AM, Andy Shevchenko wrote: > On Fri, Jan 22, 2021 at 2:03 AM Hans de Goede wrote: >> On 1/18/21 1:02 PM, Andy Shevchenko wrote: >>> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote: > > ... > >>> Can you elaborate switchings fr

Re: [PATCH v2 08/12] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-22 Thread Hans de Goede
Hi, On 1/22/21 2:04 PM, Charles Keepax wrote: > On Fri, Jan 22, 2021 at 01:23:44PM +0100, Hans de Goede wrote: >> On 1/22/21 12:26 PM, Charles Keepax wrote: >>> On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote: >>>> On 1/19/21 10:51 AM, Richard Fitzger

Re: [PATCH v2 08/12] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-22 Thread Hans de Goede
Hi, On 1/22/21 12:26 PM, Charles Keepax wrote: > On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote: >> Hi, >> >> On 1/19/21 10:51 AM, Richard Fitzgerald wrote: >>> On 18/01/2021 17:24, Andy Shevchenko wrote: >>>> On Sun, Ja

[GIT PULL] platform-drivers-x86 for 5.11-2

2021-01-22 Thread Hans de Goede
for tablet mode on Dell Inspiron 7352 Geert Uytterhoeven (1): platform/surface: SURFACE_PLATFORMS should depend on ACPI Hans de Goede (3): platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet platform/x86: intel-vbtn: Drop HP Stream x360

Re: [PATCH v2 07/12] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-21 Thread Hans de Goede
Hi, On 1/18/21 1:02 PM, Andy Shevchenko wrote: > On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote: >> >> Use arizona->dev for runtime-pm as the main shared/libray code from >> sound/soc/codecs/arizona.c does. > > Can you elaborate switchings from get() to g

Re: [PATCH v2 08/12] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-21 Thread Hans de Goede
Hi, On 1/19/21 10:51 AM, Richard Fitzgerald wrote: > On 18/01/2021 17:24, Andy Shevchenko wrote: >> On Sun, Jan 17, 2021 at 6:06 PM Hans de Goede wrote: >>> >>> Convert the arizona extcon driver into a helper library for direct use >>> from the arizona co

Re: [PATCH v2 03/12] ASoC: arizona-jack: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-01-21 Thread Hans de Goede
Hi, On 1/18/21 1:47 PM, Mark Brown wrote: > On Sun, Jan 17, 2021 at 05:05:46PM +0100, Hans de Goede wrote: >> When the jack is partially inserted and then removed again it may be >> removed while the hpdet code is running. In this case the following >> may happen: >

[PATCH v2] virt: vbox: Do not use wait_event_interruptible when called from kernel context

2021-01-21 Thread Hans de Goede
ssing requestor info to the host for VirtualBox 6.0.x") Reported-by: Ludovic Pouzenc Signed-off-by: Hans de Goede --- Changes in v2: - Add Reported-by: Ludovic Pouzenc --- drivers/virt/vboxguest/vboxguest_utils.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-)

Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-20 Thread Hans de Goede
Hi, On 1/20/21 8:59 PM, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 9:18 PM Hans de Goede wrote: >> On 1/18/21 2:34 PM, Mark Brown wrote: >>> On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: >>> >>>> More in general I'm not aware o

Re: [PATCH] drm: Added orientation quirk for OneGX1 Pro

2021-01-20 Thread Hans de Goede
Hi, On 1/20/21 9:56 PM, Jared Baldridge wrote: > The OneGX1 Pro has a fairly unique combination of generic strings, > but we additionally match on the BIOS date just to be safe. > > Signed-off-by: Jared Baldridge Thanks, patch looks good to me: Reviewed-by: Hans de Goede

[PATCH v4 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()

2021-01-20 Thread Hans de Goede
functions (this could happen on e.g. manual driver binding through sysfs). Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- Changes in v2: - New patch in v2 of this patchset --- drivers/mfd/arizona-core.c | 11 --- drivers

[PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-01-20 Thread Hans de Goede
in v2: - Split my WM5102 work into 2 series, one series adding basic support for Bay Trail boards with a WM5102 codec and a second series with the jack-detect work - Various other minor code tweaks Hans de Goede (4): mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") mfd: arizon

[PATCH v4 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2021-01-20 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/mfd/arizona-i2c.c | 1 + drivers/mfd/arizona-spi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c index 4b58e3ad6eb6..2a4a3a164d0a 100644 --- a/drivers/mfd/arizona-i2c.c +++ b/drivers/mfd/ari

[PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-01-20 Thread Hans de Goede
. and 2. still have their IPC IRQ at index 0 rather then 5 Add a DMI quirk table to check for the few known models with this issue, so that the right IPC IRQ index is used on these systems. Reviewed-by: Andy Shevchenko Acked-by: Pierre-Louis Bossart Signed-off-by: Hans de Goede --- sound/soc

[PATCH v4 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2021-01-20 Thread Hans de Goede
ine driver and ACPI hooks, the BYT-CR detection quirk which these devices need will be added in a separate patch. BugLink: https://github.com/thesofproject/linux/issues/2485 Co-authored-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Reviewed-by: Andy Shevchenko Signed-off-by: Han

[PATCH v4 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-20 Thread Hans de Goede
Hartmann, combined with insights in things like the speaker GPIO from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1]. [1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel Cc: Christian Hartmann Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede

Re: [PATCH] ACPI: scan: Rearrange code related to acpi_get_device_data()

2021-01-20 Thread Hans de Goede
d of an int and adapt its callers to that. > > While at it, rename acpi_get_device_data() to handle_to_device(), > because the old name does not really reflect the functionality > provided by that function. > > No intentional functional impact. > > Signed-off-by: Rafael J. Wysocki Ni

Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-20 Thread Hans de Goede
s running" > - no change I've finally gotten around to testing this. I'm happy to report that the power-role swapping regression seen in one of the older versions of this patch-set is gone. So the entire series is: Tested-by: Hans de Goede Regards, Hans > >

Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-20 Thread Hans de Goede
Hi, On 1/18/21 2:34 PM, Mark Brown wrote: > On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: > >> More in general I'm not aware of any (recent-ish) x86 GPIO controllers >> not being able to do active low interrupts. In theory we could hit this >> code path o

[PATCH] virt: vbox: Do not use wait_event_interruptible when called from kernel context

2021-01-20 Thread Hans de Goede
ssing requestor info to the host for VirtualBox 6.0.x") Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_utils.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/virt/vboxguest/vboxguest_utils.c b/drivers/virt/vboxguest/vboxgue

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Hans de Goede
Hi, On 1/19/21 5:33 PM, Limonciello, Mario wrote: -Original Message- From: Yuan, Perry Sent: Tuesday, January 12, 2021 11:18 To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com Cc: lgirdw...@gmail.com;

Re: [PATCH] cfg80211: Fix "suspicious RCU usage in wiphy_apply_custom_regulatory" warning/backtrace

2021-01-18 Thread Hans de Goede
Hi, On 1/5/21 10:24 AM, Peer, Ilan wrote: > Hi, > >> -Original Message----- >> From: Hans de Goede >> Sent: Monday, January 04, 2021 19:07 >> To: Johannes Berg ; David S . Miller >> ; Jakub Kicinski ; Rojewski, >> Cezary ; Pierre-Louis Bossart >

Re: linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 8:39 PM, Stephen Rothwell wrote: > Hi all, > > On Tue, 19 Jan 2021 06:27:58 +1100 Stephen Rothwell > wrote: >> >> In commit >> >> 99d53ba0d0d9 ("platform/x86: hp-wmi: Don't log a warning on >> HPWMI_RET_UNKNOWN_COMMAND errors") >> >> Fixes tag >> >> Fixes: 81c93798ef3e

Re: [PATCH] sony-laptop: Remove unneeded semicolon

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:01 AM, Yue Zou wrote: > Remove a superfluous semicolon after function definition. > > Signed-off-by: Yue Zou Thank you for your patch, I've applied this patch to my review-hans branch:

Re: [PATCH] platform/surface: aggregator: Fix kernel-doc references

2021-01-18 Thread Hans de Goede
Hi, On 1/14/21 4:08 PM, Maximilian Luz wrote: > Both, ssh_rtl_rx_start() and ssh_rtl_tx_start() functions, do not exist > and have been consolidated into ssh_rtl_start(). Nevertheless, > kernel-doc references the former functions. Replace those references > with references to ssh_rtl_start(). >

Re: [PATCH v6 16/16] platform/surface: aggregator: fix a kernel-doc markup

2021-01-18 Thread Hans de Goede
Hi, On 1/14/21 9:04 AM, Mauro Carvalho Chehab wrote: > A function has a different name between their prototype > and its kernel-doc markup: > > ../drivers/platform/surface/aggregator/ssh_request_layer.c:1065: > warning: expecting prototype for ssh_rtl_tx_start(). Prototype was for >

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 5:00 PM, Daniel Scally wrote: > > On 18/01/2021 15:48, andriy.shevche...@linux.intel.com wrote: >> On Mon, Jan 18, 2021 at 04:32:54PM +0100, Hans de Goede wrote: >>> On 1/18/21 4:23 PM, andriy.shevche...@linux.intel.com wrote: >> ... >> >>

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:23 PM, andriy.shevche...@linux.intel.com wrote: > On Mon, Jan 18, 2021 at 02:51:30PM +, Barnabás Pőcze wrote: >> 2021. január 18., hétfő 14:51 keltezéssel, Andy Shevchenko írta: >> >>> On Mon, Jan 18, 2021 at 11:12:34AM +, Barnabás Pőcze wrote: 2021. január 18.,

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:32 PM, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 04:16:16PM +0100, Rafael J. Wysocki wrote: >> On Sat, Jan 16, 2021 at 1:37 PM Hans de Goede wrote: >>> On 1/14/21 7:46 PM, Rafael J. Wysocki wrote: > > ... > >>> When I have cases like

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 4:16 PM, Rafael J. Wysocki wrote: > On Sat, Jan 16, 2021 at 1:37 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/14/21 7:46 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> The upfront allocation of n

Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:34 PM, Mark Brown wrote: > On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: > >> More in general I'm not aware of any (recent-ish) x86 GPIO controllers >> not being able to do active low interrupts. In theory we could hit this >> code path o

Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 2:02 PM, Mark Brown wrote: > On Sun, Jan 17, 2021 at 10:22:50PM +0100, Hans de Goede wrote: > >> +/* >> + * Some DSDTs wrongly declare the IRQ trigger-type as >> IRQF_TRIGGER_FALLING >> + * The IRQ line will stay low when a new IRQ eve

<    1   2   3   4   5   6   7   8   9   10   >