Hi,
On 10/31/20 2:32 AM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> ./passobj-attributes.c:38:23: warning: symbol 'po_is_pass_set' was not
> declared. Should it be static?
> ./passobj-attributes.c:70:23: warning: symbol 'po_current_password' was not
> declared. Should it be
Hi,
On 10/29/20 12:44 PM, Lukas Bulwahn wrote:
> Commit e8a60aa7404b ("platform/x86: Introduce support for Systems
> Management Driver over WMI for Dell Systems") added a new section
> DELL WMI SYSMAN DRIVERS in MAINTAINERS, but slipped in a typo.
>
> Hence, ./scripts/get_maintainer.pl
Hi,
On 10/29/20 12:44 PM, Lukas Bulwahn wrote:
> Commit e8a60aa7404b ("platform/x86: Introduce support for Systems
> Management Driver over WMI for Dell Systems") added a new section
> DELL WMI SYSMAN DRIVERS in MAINTAINERS, but slipped in a typo.
>
> Hence, ./scripts/get_maintainer.pl
Hi,
On 10/29/20 12:39 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/platform/x86/dell-wmi-sysman/sysman.c:258:24: warning:
> symbol 'wmi_sysman_kobj_sysfs_ops' was not declared.
> Should it be static?
>
> wmi_sysman_kobj_sysfs_ops has only call within sysman.c
> It should
Hi,
On 10/29/20 10:31 AM, Mauro Carvalho Chehab wrote:
> The Description: tag is missing on some places, causing
> scripts/get_abi.pl warnings:
>
> Warning: file
> Documentation/ABI/testing/sysfs-class-firmware-attributes#172:
> What
Hi,
On 11/3/20 2:46 AM, Rob Herring wrote:
> On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson wrote:
>>
>> This exports some things from i2c-hid so that we can have a driver
>> that's effectively a subclass of it and that can do its own power
>> sequencing.
>>
>> Signed-off-by: Douglas Anderson
Hi,
On 11/1/20 6:41 PM, rwri...@hpe.com wrote:
> From: Randy Wright
>
> For several months, I've been experiencing GPU hangs when starting
> Cinnamon on an HP Pavilion Mini 300-020 if I try to run an upstream
> kernel. I reported this recently in
>
Hi,
On 10/30/20 8:09 AM, Kai-Heng Feng wrote:
> Hi Hans,
>
>> On Oct 30, 2020, at 15:06, Kai-Heng Feng wrote:
>>
>> After reboot, it's not possible to use hotkeys to enter BIOS setup and
>> boot menu on some HP laptops.
>>
>> BIOS folks identified the root cause is the missing _PTS call, and
Hi,
On 10/29/20 9:36 PM, Dmitry Torokhov wrote:
> Hi Andrej,
>
> On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
>> Firmware file loadind for GT911 controller takes too much time (~60s).
>> There is no check that configuration is the same which is already present.
>> This happens
Hi,
On 10/29/20 3:16 PM, Coiby Xu wrote:
> On Thu, Oct 29, 2020 at 12:09:23PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 10/29/20 11:59 AM, Coiby Xu wrote:
>>> Hi Hans,
>>>
>>> Thank you for reviewing this patch!
>>>
>>> On T
Hi,
On 10/29/20 11:59 AM, Coiby Xu wrote:
> Hi Hans,
>
> Thank you for reviewing this patch!
>
> On Thu, Oct 29, 2020 at 11:04:36AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 10/29/20 8:41 AM, Coiby Xu wrote:
>>> SIMPLE_DEV_PM_OPS has
Hi,
On 10/29/20 8:41 AM, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
No it does not, when CONFIG_PM_SLEEP is not set then the
SET_SYSTEM_SLEEP_PM_OPS macro which SIMPLE_DEV_PM_OPS uses
is a no-op, so nothing will reference xo15_sci_resume leading to
a
Hi,
On 10/29/20 1:55 AM, Mark Pearson wrote:
> Thanks Hans and Bastien,
>
> On 28/10/2020 13:23, Hans de Goede wrote:
>>> Is there another file which explains whether those sysfs value will
>>> contain a trailing linefeed?
>>
>> sysfs APIs are typicall
Hi all,
On 10/28/20 12:03 PM, Hans de Goede wrote:
> Hi,
>
> On 10/8/20 2:37 PM, Shravan Kumar Ramani wrote:
>> The performance modules in BlueField are present in several hardware
>> blocks and each block provides access to these stats either through
>> coun
Hi,
On 10/19/20 3:32 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix
Thank you for your patch, I've applied this patch to my review-hans
branch:
Hi,
On 10/21/20 12:29 AM, Samuel Čavoj wrote:
> Hi,
>
> naturally I notice this right after I send the patch, but my whitespace
> is wrong. Time to set a pre-commit hook up. I guess that means a v4,
> unless you would fix it on your end? It's just a single line.
>
> Sorry about all the noise,
>
Hi,
A few minor nitpicks below, mostly stuff which I missed before, sorry.
I suggest you make v2 part of the series where you actually add the
drivers/acpi/... and the thinkpad_acpi.c bits to implement this.
On 10/27/20 5:42 PM, Mark Pearson wrote:
> From: Hans de Goede
>
> On moder
Hi,
On 10/8/20 2:37 PM, Shravan Kumar Ramani wrote:
> The performance modules in BlueField are present in several hardware
> blocks and each block provides access to these stats either through
> counters that can be programmed to monitor supported events or
> through memory-mapped registers that
Hi,
On 10/28/20 2:45 PM, Bastien Nocera wrote:
> Hey Hans, Mark,
>
> On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote:
>> From: Hans de Goede
>>
>> On modern systems the platform performance, temperature, fan and
>> other
>> hardware relate
m common interface. To facilitate this, the patch
> introduces a generic way for driver to be able to create
> configurable BIOS Attributes available in Setup (F2) screen.
>
> Cc: Hans de Goede
> Cc: Andy Shevchenko
> Cc: mark gross
>
> Co-developed-by: Mario Limonciello
The reason for using an allowlist via the quirk mechanism is that the new
> WMI device (0x00060062) is also present on some models which do not have
> a 360 degree hinge (at least FX503VD and GL503VD from Hans' DSTS
> collection) and therefore its presence cannot be relied on.
>
> Signed-o
mand. Other modules
> (serio_raw) do not currently lock the mutex, so there is still a
> possibility for intermixed commands.
>
> Link:
> https://lore.kernel.org/linux-input/CAHQZ30ANTeM-pgdYZ4AbgxsnevBJnJgKZ1Kg+Uy8oSXZUvz=o...@mail.gmail.com
> Signed-off-by: Raul E Rangel
Patch l
Hi,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy; and I'm working my way through
the backlog of old patches in patchwork:
https://patchwork.kernel.org/project/platform-driver-x86/list/
On 11/15/19 6:27 AM, Yongxin Liu wrote:
> This reverts commit
Hi Mark,
On 10/27/20 1:28 PM, Mark Pearson wrote:
> Hi Elia
>
> On 27/10/2020 05:19, Elia Devito wrote:
>> Hi to all,
>>
>> In data martedì 27 ottobre 2020 08:54:44 CET, Hans de Goede ha scritto:
>>> Hi,
>>>
>>> On 10/26/20 8:55 PM, Mark Pear
Hi,
On 10/9/20 4:11 PM, Maximilian Luz wrote:
> As has come up in the discussion around
>
> [RFC PATCH] Add support for Microsoft Surface System Aggregator Module
>
> it may make sense to add a Microsoft Surface specific platform
> subdirectory. Andy has suggested drivers/platform/surface for
vides support for the PMT framework, along with support
> for Telemetry on Tiger Lake.
The entire series looks good to me, so you may add my:
Reviewed-by: Hans de Goede
To the entire series.
Lee, in the discussion about previous versions you indicated that you
would be happy to merge the entire ser
Hi,
On 10/26/20 8:55 PM, Mark Pearson wrote:
> Thanks Hans
>
> On 26/10/2020 14:33, Hans de Goede wrote:
>> Hi Mark,
>>
>> Thank you for this new version.
>>
>> On 10/26/20 6:44 PM, Mark Pearson wrote:
>>> From: Hans de Goede
>>>
>
Hi Mark,
Thank you for this new version.
On 10/26/20 6:44 PM, Mark Pearson wrote:
> From: Hans de Goede
>
> On modern systems the platform performance, temperature, fan and other
> hardware related characteristics are often dynamically configurable. The
> profile is ofte
Hi Mark,
Thank you for this new version.
On 10/26/20 6:44 PM, Mark Pearson wrote:
> From: Hans de Goede
>
> On modern systems the platform performance, temperature, fan and other
> hardware related characteristics are often dynamically configurable. The
> profile is ofte
Hi,
On 10/26/20 4:39 PM, Limonciello, Mario wrote:
>> This was present in previous versions too, but I just noticed this are you
>> sure that using
>> .string.pointer is correct here? That seems wrong since the pointer gets
>> allocated by
>> the Linux ACPI core, so it is not under influence of
Hi,
On 10/26/20 4:25 PM, Limonciello, Mario wrote:
>>> +
>>> + print_hex_dump_bytes("set attribute data: ", DUMP_PREFIX_NONE, buffer,
>> buffer_size);
>>
>> This seems to be a debugging left-over?
>
> Yes it was for debugging, but its configurable to turn on by dynamic
> debug as I can tell.
ration
> capability on certain Dell Systems.
>
> This driver allows user to configure Dell systems with a
> uniform common interface. To facilitate this, the patch
> introduces a generic way for driver to be able to create
> configurable BIOS Attributes available in Setup (F2) screen
Hi,
On 10/19/20 8:49 PM, Mark Pearson wrote:
> Hi
>
>> On 19/10/2020 14:43, Hans de Goede wrote:
>> Hi,
>>
>> On 10/18/20 2:31 PM, Rafael J. Wysocki wrote:
>>> On Sun, Oct 18, 2020 at 11:41 AM Hans de Goede wrote:
>>>>
>>>
Hi,
On 10/18/20 2:31 PM, Rafael J. Wysocki wrote:
> On Sun, Oct 18, 2020 at 11:41 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 10/16/20 4:51 PM, Rafael J. Wysocki wrote:
>>> On Fri, Oct 16, 2020 at 1:11 PM Hans de Goede wrote:
>>>>
>&g
Hi,
On 10/19/20 5:44 PM, Enrico Weigelt, metux IT consult wrote:
> On 14.10.20 10:41, Hans de Goede wrote:
>
> Hi,
>
>> Keep the current LED/gpio setup code, but make executing it conditional
>> on the BIOS version and skip the LED/gpio setup when the new BIOS is
&g
Hi,
On 10/16/20 4:51 PM, Rafael J. Wysocki wrote:
> On Fri, Oct 16, 2020 at 1:11 PM Hans de Goede wrote:
>>
>> > from both threads to the Cc>
>>
>> Hi,
>>
>> On 10/14/20 5:42 PM, Rafael J. Wysocki wrote:
>>> On Wed, Oct 14, 2020 at 4:06 PM Ha
Hi Tom,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy.
On 10/17/20 6:09 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> This is a upcoming change to clean up a new warning treewide.
> I am wondering if the change could be one mega patch (see below) or
> normal
also present on some models which do not have
>> a 360 degree hinge (at least FX503VD and GL503VD from Hans' DSTS
>> collection) and therefore its presence cannot be relied on.
>>
>> This patch is a followup to "platform/x86: asus-wmi: Fix SW_TABLET_MODE
>> always re
s: ce945552fde4 ("Bluetooth: hci_h5: Add support for serdev enumerated
> devices")
> Reported-by: syzbot+6ce141c55b2f7aafd...@syzkaller.appspotmail.com
> Tested-by: syzbot+6ce141c55b2f7aafd...@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam
Patch looks good to me
Hi,
On 10/16/20 1:55 PM, Anant Thazhemadam wrote:
>
> Hi,
>
> On 16/10/20 4:58 pm, Hans de Goede wrote:
>> Hi,
>>
>> On 10/7/20 5:48 AM, Anant Thazhemadam wrote:
>>> If h5_close is called when !hu->serdev, h5 is directly freed.
>>> However,
Tested-by: syzbot+6ce141c55b2f7aafd...@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam h5_close v4
> ---
> Changes in v4:
> * Free h5->rx_skb even when hu->serdev
> (Suggested by Hans de Goede )
> * If hu->serdev, then assign h5->rx_skb
Hi,
On 9/22/20 11:19 AM, Jiri Kosina wrote:
> On Wed, 16 Sep 2020, Sultan Alsawaf wrote:
>
>> From: Sultan Alsawaf
>>
>> This is a fixed resubmission of "[PATCH 0/2] i2c-hid: Save power by reducing
>> i2c
>> xfers with block reads". That original patchset did not have enough fixes for
>> the
Hi,
On 10/14/20 5:42 PM, Rafael J. Wysocki wrote:
> On Wed, Oct 14, 2020 at 4:06 PM Hans de Goede wrote:
>> On 10/14/20 3:33 PM, Rafael J. Wysocki wrote:
>>> First, a common place to register a DPTF system profile seems to be
>>> needed and, as I said above, I wo
Hi,
On 10/16/20 12:39 AM, Matthew Garrett wrote:
On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote:
There is a misconfiguration in the bios of the gpio pin used for the
interrupt in the T490s. When interrupts are enabled in the tpm_tis
driver code this results in an interrupt storm.
Cc: Hans de Goede
Reviewed-by: James Bottomley
Signed-off-by: Jerry Snitselaar
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/char/tpm/tpm_tis.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/drivers
Hi,
On 10/14/20 3:55 PM, Rafael J. Wysocki wrote:
On Tue, Oct 13, 2020 at 3:09 PM Hans de Goede wrote:
Hi,
On 10/12/20 6:42 PM, Rafael J. Wysocki wrote:
On Wed, Oct 7, 2020 at 8:41 PM Limonciello, Mario
wrote:
On Wed, 2020-10-07 at 15:58 +, Limonciello, Mario wrote:
On Mon, 2020
Hi,
On 10/14/20 3:33 PM, Rafael J. Wysocki wrote:
Hi Hans,
On Tue, Oct 13, 2020 at 3:04 PM Hans de Goede wrote:
Hi Rafael,
On 10/12/20 6:37 PM, Rafael J. Wysocki wrote:
On Mon, Oct 12, 2020 at 1:46 PM Hans de Goede wrote:
A side note, related to your proposal, not this patch. IMO
Hi all,
On 10/14/20 1:23 PM, Hans de Goede wrote:
Hi,
On 10/14/20 1:09 PM, Kieran Bingham wrote:
Hi Hans, Sasha,
As mentioned on https://github.com/linux-surface/kernel/issues/63, I'm
afraid I've bisected a boot time issue on the Microsoft Surface Go 2 to
this commit on the stable 5.8 tree
Hi,
On 10/14/20 1:21 PM, Ed W wrote:
On 14/10/2020 09:41, Hans de Goede wrote:
So I have a suggested compromise:
Keep the current LED/gpio setup code, but make executing it conditional
on the BIOS version and skip the LED/gpio setup when the new BIOS is
present to avoid having duplicate LED
.
So this patch should not make a difference at all on the GO2,
other then maybe a subtle timing difference somewhere ... ?
Regards,
Hans
On 21/09/2020 15:40, Sasha Levin wrote:
From: Hans de Goede
[ Upstream commit 21653a4181ff292480599dad996a2b759ccf050f ]
Some ACPI i2c-devices _STA method
Hi,
On 10/13/20 11:40 PM, Ed W wrote:
Hans, can I ask you to look again at the history of this please. Bearing in
mind the speed kernel
stuff takes to get to end users, we are talking about a very small window of
userland changes here.
I would vote for simplifying this module and trying to
Hi,
On 10/12/20 6:42 PM, Rafael J. Wysocki wrote:
On Wed, Oct 7, 2020 at 8:41 PM Limonciello, Mario
wrote:
On Wed, 2020-10-07 at 15:58 +, Limonciello, Mario wrote:
On Mon, 2020-10-05 at 12:58 +, Limonciello, Mario wrote:
On modern systems CPU/GPU/... performance is often
Hi Rafael,
On 10/12/20 6:37 PM, Rafael J. Wysocki wrote:
On Mon, Oct 12, 2020 at 1:46 PM Hans de Goede wrote:
A side note, related to your proposal, not this patch. IMO it suits
better to have /sys/power/profile.
cat /sys/power/profile
power
balanced_power *
balanced
Hi,
On 10/12/20 6:02 PM, Daniel Lezcano wrote:
On 12/10/2020 13:46, Hans de Goede wrote:
Hi Daniel,
On 10/12/20 12:30 PM, Daniel Lezcano wrote:
Here the proposed interface is already exported in userspace via the
powercap framework which supports today the backend driver for the RAPL
h dev_info()
MAINTAINERS: Update maintainers for pmc_core driver
Greg Kroah-Hartman (1):
platform/x86: intel_pmc_core: do not create a static struct device
Hans de Goede (7):
platform/x86: touchscreen_dmi: Add info for the MPMAN Converter9 2-in-1
platform/x86: asus-nb-wmi: Revert "Do n
Hi Enrico and Ed W,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy; and I'm working my way through
the backlog of old patches in patchwork:
https://patchwork.kernel.org/project/platform-driver-x86/list/
On 10/12/20 9:39 PM, Enrico Weigelt, metux IT consult
Hi Daniel,
On 10/12/20 12:30 PM, Daniel Lezcano wrote:
Hi Hans,
On 07/10/2020 12:43, Hans de Goede wrote:
Hi,
On 10/6/20 2:20 PM, Daniel Lezcano wrote:
The density of components greatly increased the last decade bringing a
numerous number of heating sources which are monitored by more than
Hi,
On 10/11/20 9:05 AM, Luke Jones wrote:
Hello Hans and others, thank you for your valuable feedback
On Fri, Oct 9, 2020 at 16:22, Hans de Goede wrote:
Hi,
On 9/23/20 11:56 PM, Luke D Jones wrote:
The ASUS N-Key keyboard uses the productId of 0x1866 and is used in
almost all modern ASUS
Hi,
On 9/23/20 11:56 PM, Luke D Jones wrote:
The ASUS N-Key keyboard uses the productId of 0x1866 and is used in
almost all modern ASUS gaming laptops with slight changes to the
firmware. This patch enables: Fn+key hotkeys, keyboard backlight
brightness control, and notify asus-wmi to toggle
Hi,
On 10/9/20 3:14 PM, Andy Shevchenko wrote:
On Fri, Oct 09, 2020 at 11:38:55AM +0200, Jiri Kosina wrote:
On Thu, 24 Sep 2020, Luke D Jones wrote:
The ASUS N-Key keyboard uses the productId of 0x1866 and is used in
almost all modern ASUS gaming laptops with slight changes to the
firmware.
kernel.org
Signed-off-by: Hans de Goede
---
.../testing/sysfs-class-performance_profile | 104 ++
1 file changed, 104 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-performance_profile
diff --git a/Documentation/ABI/testing/sysfs-class-performance
Hi,
On 10/5/20 3:13 PM, Benjamin Berg wrote:
Hi,
seems reasonable to me. Quite simple, but likely good enough as we are
sticking to only use well known names.
Just found a small typo.
Benjamin
On Sat, 2020-10-03 at 15:19 +0200, Hans de Goede wrote:
On modern systems CPU/GPU/... performance
Hi,
On 10/5/20 12:29 AM, Elia Devito wrote:
Hi Hans,
On 2020-10-03 9:19 a.m., Hans de Goede wrote:
On modern systems CPU/GPU/... performance is often dynamically configurable
in the form of e.g. variable clock-speeds and TPD. The performance is often
automatically adjusted to the load by some
HI,
On 10/6/20 10:46 AM, Bharathi, Divya wrote:
Sorry for another mail on same patch. I missed to add one response on
previous comments
No problem.
+/**
+ * init_bios_attributes() - Initialize all attributes for a type
+ * @attr_type: The attribute type to initialize
+ * @guid: The WMI
Hi,
On 10/6/20 10:37 AM, Bharathi, Divya wrote:
Hmm, checkpatch is saying:
WARNING: Missing Signed-off-by: line by nominal patch author 'Divya
Bharathi '
I assume the dell address is the one you want to use ?
If so try setting the following in ~/.gitconfig:
[user]
email =
Hi,
On 10/1/20 9:37 PM, Limonciello, Mario wrote:
+
+ if (!capable(CAP_SYS_ADMIN))
+ return -EPERM;
Sorry for not addressing this during earlier reviews, but why is this
check here. Is read-only access to the settings by normal users
considered harmful ?
The best answer
platform/surface subdirectory for the
Surface device family, with subsequent commits moving existing Surface
drivers over from platform/x86.
A new MAINTAINERS entry is added for this directory. Patches to files in
this directory will be taken up by the platform-drivers-x86 team (i.e.
Hans de Goede
Hi,
On 10/8/20 2:32 PM, Maximilian Luz wrote:
On 10/8/20 1:44 PM, Hans de Goede wrote:
Hi Maximilian,
On 10/5/20 6:03 PM, Maximilian Luz wrote:
As has come up in the discussion around
[RFC PATCH] Add support for Microsoft Surface System Aggregator Module
it may make sense to add
Hi,
On 10/8/20 2:32 PM, Maximilian Luz wrote:
On 10/8/20 1:44 PM, Hans de Goede wrote:
Hi Maximilian,
On 10/5/20 6:03 PM, Maximilian Luz wrote:
As has come up in the discussion around
[RFC PATCH] Add support for Microsoft Surface System Aggregator Module
it may make sense to add
Hi Maximilian,
On 10/5/20 6:03 PM, Maximilian Luz wrote:
As has come up in the discussion around
[RFC PATCH] Add support for Microsoft Surface System Aggregator Module
it may make sense to add a Microsoft Surface specific platform
subdirectory. Andy has suggested drivers/platform/surface
Hi,
On 10/8/20 9:29 AM, Lee Jones wrote:
On Wed, 07 Oct 2020, Hans de Goede wrote:
Hi,
On 10/7/20 8:54 AM, Lee Jones wrote:
On Tue, 06 Oct 2020, David E. Box wrote:
On Tue, 2020-10-06 at 19:51 -0500, Bjorn Helgaas wrote:
On Tue, Oct 06, 2020 at 03:45:54PM -0700, David E. Box wrote:
Hi
Hi,
On 10/7/20 8:54 AM, Lee Jones wrote:
On Tue, 06 Oct 2020, David E. Box wrote:
On Tue, 2020-10-06 at 19:51 -0500, Bjorn Helgaas wrote:
On Tue, Oct 06, 2020 at 03:45:54PM -0700, David E. Box wrote:
Hi Bjorn,
This patch has been acked and unchanged for weeks. Is it possible
to
get this
Hi,
On 10/7/20 5:51 AM, David E. Box wrote:
Add RocketLake platform support and other driver maintainance.
Gayatri Kammela (4):
platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments
and reorganize
platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support
Hi,
On 10/7/20 12:46 AM, David E. Box wrote:
This patch set adds several critical fixes for intel_pmc_core driver.
Patch 1: Uses descriptive register names for the TigerLake low power
mode registers. Not critical, but was requested in review of
Patch 2.
Patch 2: Fixes the
Hi,
On 10/7/20 6:21 PM, Barnabás Pőcze wrote:
Hi
2020. október 7., szerda 16:02 keltezéssel, Hans de Goede írta:
[...]
Elia, Thank you for your patch, I've applied this patch to me review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h
Hi,
On 10/5/20 10:57 AM, Andy Shevchenko wrote:
On Mon, Oct 5, 2020 at 12:14 AM Elia Devito wrote:
HP Spectre notebooks (and probably other model as well)
support up to 4 thermal policy:
- HP Recommended
- Performance
- Cool
- Quiet
at least on HP Spectre x360 Convertible 15-df0xxx
Hi,
On 10/6/20 2:20 PM, Daniel Lezcano wrote:
The density of components greatly increased the last decade bringing a
numerous number of heating sources which are monitored by more than 20
sensors on recent SoC. The skin temperature, which is the case
temperature of the device, must stay below
.
Hans de Goede (1):
platform/x86: asus-wmi: Fix SW_TABLET_MODE always reporting 1 on many
different models
drivers/platform/x86/asus-nb-wmi.c | 32
drivers/platform/x86/asus-wmi.c| 16 +---
drivers/platform/x86/asus-wmi.h
Hi,
On 10/6/20 4:44 AM, Anant Thazhemadam wrote:
On 05-10-2020 14:48, Hans de Goede wrote:
To fully fix the memleak you also need to add a kfree_skb(h5->rx_skb);
call to the end of h5_serdev_remove(), because in the hu->serdev case
that is where the h5 struct will be free-ed (it is f
t;rx_skb when !hu->serdev, and fix the memory leak
* Do not incorrectly and unnecessarily call serdev_device_close()
Changes in v2:
* Fixed the Fixes tag
Hans de Goede also suggested calling h5_reset_rx() on close (for both,
!hu->serdev
and hu->serdev cases).
However, do
ctions by the way of eliminating said accesses and using
driver private flag.
Fixes: 84d3f6b76447 ("ACPI / button: Delay acpi_lid_initialize_state() until first
user space open")
Signed-off-by: Dmitry Torokhov
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
--
Hi,
On 10/3/20 3:19 PM, Hans de Goede wrote:
Hi All,
Recently 2 different patches have been submitted for drivers under
drivers/platform/x86 to configure the performance-profile of
modern laptops (see the actual RFC patch for what I mean with
a performance-profile). One for the thinkpad_acpi
Hi All,
Recently 2 different patches have been submitted for drivers under
drivers/platform/x86 to configure the performance-profile of
modern laptops (see the actual RFC patch for what I mean with
a performance-profile). One for the thinkpad_acpi driver and
one for the hp-wmi driver.
Since I
for selecting the performance-profile of these automatic-mechanisms.
Cc: Mark Pearson
Cc: Elia Devito
Cc: Bastien Nocera
Cc: Benjamin Berg
Cc: linux...@vger.kernel.org
Cc: linux-a...@vger.kernel.org
Signed-off-by: Hans de Goede
---
.../testing/sysfs-class-performance_profile | 104
Hi,
On 10/1/20 9:43 PM, Anant Thazhemadam wrote:
When h5_close() gets called, the memory allocated for the hu gets
freed only if hu->serdev doesn't exist. This leads to a memory leak.
So when h5_close() is requested, close the serdev device instance and
free the memory allocated to the hu
to be able to create
configurable BIOS Attributes available in Setup (F2) screen.
Cc: Hans de Goede
Cc: Andy Shevchenko
Cc: mark gross
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Co-developed-by: Prasanth KSR
Signed-off-by: Prasanth KSR
Signed-off-by: Divya Bharathi
Hmm
Hi,
On 9/30/20 11:02 PM, Limonciello, Mario wrote:
+ possible_values:A file that can be read to obtain the
possible
+ values of the . Values are
separated using
+ semi-colon (``;``).
why not use
Hi,
On 9/30/20 5:12 PM, Limonciello, Mario wrote:
-Original Message-
From: Hans de Goede
Sent: Wednesday, September 30, 2020 8:28
To: Limonciello, Mario; Barnabás Pőcze; Andy Shevchenko
Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org; Takashi
Iwai
Subject: Re
Hi,
On 9/29/20 10:47 PM, Limonciello, Mario wrote:
I requested on the Ubuntu bug for someone to provide these.
Joe Barnett was kind enough to share two ACPI dumps to compare.
Not affected:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1822394/+attachment/5415318/+files/1.2.0.acpidump
Hi,
On 9/29/20 10:48 AM, Takashi Iwai wrote:
Hi Hans,
it seems that the recent update of intel-vtn broke the keyboard input
on some laptops with libinput:
https://bugzilla.opensuse.org/show_bug.cgi?id=1175599
Blacklisting intel-vtn fixes the issue, so it's likely the falsely
reported
Hi,
On 9/29/20 10:48 AM, Takashi Iwai wrote:
Hi Hans,
it seems that the recent update of intel-vtn broke the keyboard input
on some laptops with libinput:
https://bugzilla.opensuse.org/show_bug.cgi?id=1175599
Blacklisting intel-vtn fixes the issue, so it's likely the falsely
reported
Hi,
On 9/29/20 11:21 AM, Hans de Goede wrote:
Since the problem of wrongly reporting SW_TABLET_MODE=1 in combination
with libinput, leads to a non-usable system. Where as OTOH many people will
not even notice when SW_TABLET_MODE is not being reported, I believe it
is best to move to a dmi
Hi,
On 9/29/20 2:27 PM, Limonciello, Mario wrote:
I'm afraid that the only answer which I have to these questions
is not helpful, but in my experience it is true: "firmware sucks".
So FWIW there is a Dell 2-in-1 that has been conflated into this same issue.
. To facilitate this, the patch
introduces a generic way for driver to be able to create
configurable BIOS Attributes available in Setup (F2) screen.
Cc: Hans de Goede
Cc: Andy Shevchenko
Cc: mark gross
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Co-developed-by: Prasanth KSR
Hi,
On 9/29/20 11:59 AM, Barnabás Pőcze wrote:
Oohoo, what a wonderful world :)
Splendid world, indeed. I'm wondering, however, why the incorrect state
is reported? Is it similar to the linked issue on the Manjaro forum, where a
different bit is seemingly used to report the tablet mode
Hi,
On 9/29/20 10:48 AM, Takashi Iwai wrote:
Hi Hans,
it seems that the recent update of intel-vtn broke the keyboard input
on some laptops with libinput:
https://bugzilla.opensuse.org/show_bug.cgi?id=1175599
Blacklisting intel-vtn fixes the issue, so it's likely the falsely
reported
my:
Tested-by: Hans de Goede
To the entire series.
Regards,
Hans
:
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
Regards,
Hans
Vincent Huang (3):
Input: synaptics-rmi4 - rename f30_data to gpio_data
HID: rmi - rename f30_data to gpio_data
Input: synaptics-rmi4 - add support for F3A
drivers/hid/hid-rmi.c | 2 +-
drivers/input
Hi,
On 9/25/20 8:37 PM, Limonciello, Mario wrote:
So a user would see the different authentication mechanisms available
by looking At the contents of /sys/class/firmware-
attributes/*/authentication
and if they don't understand it's purpose they look at the type sysfs file.
But one role
Hi,
On 9/25/20 5:32 PM, Limonciello, Mario wrote:
So I do want to preface this response by mentioning that Dell's implementation
is based off the PLDM specification from the DMTF.
https://www.dmtf.org/sites/default/files/standards/documents/DSP0247_1.0.0.pdf
A lot of the nomenclature that has
501 - 600 of 4303 matches
Mail list logo
