Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-15 Thread Jarod Wilson
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote: > > Jarod Wilson writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: error: 'wdev_

[PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-12 Thread Jarod Wilson
, since it's value doesn't otherwise matter unless have_wdev_id is true. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") CC: Johannes Berg CC: "David S. Miller" CC: Jakub Kicinski CC: linux-wirel...@vger.kernel.org CC: net...@vger.kernel.org Signed-

[PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Doc

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst > > b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documenta

[PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-15 Thread Jarod Wilson
posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Doc

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-15 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:54:31PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > >> On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > >> > This comes from an end-user request, w

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:23:14PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote: > > In truth, this code started out as a copy of bond_eth_hash(), which also > > only uses the last byte, though of both source and destination macs. In > >

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > > This comes from an end-user request, where they're running multiple VMs on > > hosts with bonded interfaces connected to some interest switch topologies, &g

[PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jarod Wilson
Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Documentation, changed tx hash mode name to vlan+mac for consistency and clarity. Documentation/networking/b

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > >> > Jarod Wilson wrote: > >&

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >This comes from an end-user request, where they're running multiple VMs on > > >hosts with bonded inte

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-08 Thread Jarod Wilson
k this one is kind of hard for team to do anything about, bonding really does have a smaller userspace footprint, which is a plus for embedded type applications and high-security environments looking to keep things as minimal as possible. I think I've heard a few "we tried team years ago and it didn't work" as well, which of course is ridiculous as a reason not to try something again, since a lot can change in a few years in this world. -- Jarod Wilson ja...@redhat.com

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn't an o

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
iver instead ? :) That's actually one of the things that was suggested, since team I believe already has support for this, but the user really wants to use bonding. We're finding that a lot of users really still prefer bonding over team. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-18 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: ... > >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat > >separate from the fix for the actual hang, but it eliminates a constant > >"invalid new link 3 o

[RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2020-12-18 Thread Jarod Wilson
: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 27 +-- drivers/net/bonding/bond_options.c | 1 + include/linux/n

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >I'm seeing a system get stuck unable to bring a downed interface back up > >when it's got an updelay value set, behavior which ceased when logging > >spew was removed from bond_miimon_ins

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 2:38 PM Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 18:43:54 -0500 Jarod Wilson wrote: > > I'm seeing a system get stuck unable to bring a downed interface back up > > when it's got an updelay value set, behavior which ceased when logging > &g

[PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-05 Thread Jarod Wilson
ski CC: Thomas Davis CC: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 26 ++ include/net/bonding.h | 38 + 2 files changed, 44 insertions(+), 20 deletions(-) diff --git a/drivers/net/bonding/bon

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-05 Thread Jarod Wilson
dev->wanted_features |= BOND_XFRM_FEATURES; > + else > + bond_dev->wanted_features &= ~BOND_XFRM_FEATURES; > + > + netdev_update_features(bond_dev); > +} > > (Assuming BOND_XFRM_FEATURES doesn't itself hide under an ifdef.) It is, but doesn't need to be. I can mix these changes in as well. -- Jarod Wilson ja...@redhat.com

[PATCH net v4] bonding: fix feature flag setting at init time

2020-12-05 Thread Jarod Wilson
van Vecera Suggested-by: Ivan Vecera Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: rework based on further testing and suggestions from ivecera v3: add hel

[PATCH net-next] bonding: set xfrm feature flags more sanely

2020-12-05 Thread Jarod Wilson
David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_ma

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-03 Thread Jarod Wilson
On Thu, Dec 3, 2020 at 11:50 AM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote: > > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; > > -#ifdef CONFIG_XFRM_OFFLOAD > > - bond_dev->hw_features |= B

[PATCH net v3] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bonding/bond_options.c | 19 ++- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/net/bonding/b

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 3:17 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh > >wrote: > >> > >> Jarod Wilson wrote: > >> > >> >Don't try to adjust XFRM support flags if the bond device

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 2:23 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote: > > On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > > > > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > > > + if

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:55 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Don't try to adjust XFRM support flags if the bond device isn't yet > >registered. Bad things can currently happen when netdev_change_features() > >is called without having wanted_f

Re: [PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote: > > + if (bond->dev->reg_state != NETREG_REGISTERED) > > + goto noreg; > > + > > if (newval->value == BOND_MODE_AC

[PATCH net v2] bonding: fix feature flag setting at init time

2020-12-02 Thread Jarod Wilson
d-by: Ivan Vecera Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bonding/bond_options.c

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-22 Thread Jarod Wilson
On Wed, Nov 11, 2020 at 5:04 PM Jakub Kicinski wrote: > > On Wed, 11 Nov 2020 12:13:56 -0800 Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >The bonding driver's use of master and slave, while largely understood > > >in technical circles, poses a bar

[PATCH net] bonding: fix feature flag setting at init time

2020-11-22 Thread Jarod Wilson
Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 10 -- drivers/net/bonding/bond_options.c | 14 +++--- 2 files chan

Re: [PATCH net-next v4 0/5] bonding: rename bond components

2020-11-09 Thread Jarod Wilson
On Fri, Nov 6, 2020 at 9:44 PM Jakub Kicinski wrote: > > On Fri, 6 Nov 2020 15:04:31 -0500 Jarod Wilson wrote: > > The bonding driver's use of master and slave, while largely understood > > in technical circles, poses a barrier for inclusion to some potential > > me

[PATCH 1/5] bonding: rename 802.3ad's struct port to ad_port

2020-11-06 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

[PATCH 4/5] bonding: rename bonding_sysfs_slave.c to _port.c

2020-11-06 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH 5/5] bonding: update Documentation for port/bond terminology

2020-11-06 Thread Jarod Wilson
at it, also make some mention of NetworkManager's existence. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding

[PATCH net-next v4 0/5] bonding: rename bond components

2020-11-06 Thread Jarod Wilson
: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Jarod Wilson (5): bonding: rename 802.3ad's struct port to ad_port bonding: replace use of the term master where possible bonding: rename slave to port where possible bonding: rename bonding_sysf

[PATCH 2/5] bonding: replace use of the term master where possible

2020-11-06 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

Re: [PATCH net-next v3 5/5] bonding: update Documentation for port/bond terminology

2020-10-07 Thread Jarod Wilson
On Wed, Oct 7, 2020 at 2:14 PM Jarod Wilson wrote: > > Swap in port/bond terminology where appropriate, leaving all legacy sysfs > and procfs interface mentions in place, but marked as deprecated. > Additionally, add more netlink/iproute2 documentation, and note that this > i

[PATCH net-next v3 2/5] bonding: replace use of the term master where possible

2020-10-07 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

[PATCH net-next v3 4/5] bonding: rename bonding_sysfs_slave.c to _port.c

2020-10-07 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net-next v3 1/5] bonding: rename 802.3ad's struct port to ad_port

2020-10-07 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

[PATCH net-next v3 5/5] bonding: update Documentation for port/bond terminology

2020-10-07 Thread Jarod Wilson
at it, also make some mention of NetworkManager's existence. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding

[PATCH net-next v3 0/5] bonding: rename bond components

2020-10-07 Thread Jarod Wilson
Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Jarod Wilson (5): bonding: rename 802.3ad's struct port to ad_port bonding: replace use of the term master where possible bonding: rename slave to port where possible bonding: rename bonding_sysfs_slave.c to _port.c bonding: update Documen

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:42 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 16:23:46 -0400 > Jarod Wilson wrote: > > > On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger > > wrote: > > > > > > On Fri, 2 Oct 2020 13:40:01 -0400 > > > Ja

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:57 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:23:46 -0400 > > > I'd had a bit of feedback that people would rather see both, and be > > able to toggle off the old ones, rather than only having one or the > >

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:55 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:12:49 -0400 > > > The documentation was updated to point to the new names, but the old > > ones still exist across the board, there should be no userspace > > b

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 13:40:01 -0400 > Jarod Wilson wrote: > > > By default, enable retaining all user-facing API that includes the use of > > master and slave, but add a Kconfig knob that allows those that wish t

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 2:09 PM Andrew Lunn wrote: > > On Fri, Oct 02, 2020 at 01:40:00PM -0400, Jarod Wilson wrote: > > Point users to the new interface names instead of the old ones, where > > appropriate. Userspace bits referenced still include use of master/slave, &

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 3:11 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 13:40:00 -0400 > Jarod Wilson wrote: > > > @@ -265,7 +265,7 @@ ad_user_port_key > > This parameter has effect only in 802.3ad mode and is available > > thr

[PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding.rst | 440 +-- 1 file changed, 220 insertions(+), 220 deletions(-)

[PATCH net-next v2 4/6] bonding: rename bonding_sysfs_slave.c to _port.c

2020-10-02 Thread Jarod Wilson
Now that use of "slave" has been replaced by "port", rename this file too. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Jarod Wilson
cinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 12 drivers/net/bonding/bond_main.c | 4 ++-- drivers/net/bonding/bond_options.c| 4 ++-- drivers/net/bonding/bond_procfs.c | 8 drivers/n

[PATCH net-next v2 2/6] bonding: replace use of the term master where possible

2020-10-02 Thread Jarod Wilson
vid S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/lag.c | 2 +- drivers/infiniband/core/roce_gid_mgmt.c | 6 +-

[PATCH net-next v2 0/6] bonding: rename bond components

2020-10-02 Thread Jarod Wilson
or dropped, depending on Kconfig, rather than being replaced. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Jarod Wilson (6): bonding: rename 802.3ad's struct port to ad_port

[PATCH net-next v2 1/6] bonding: rename 802.3ad's struct port to ad_port

2020-10-02 Thread Jarod Wilson
Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_3ad.c | 1307 drivers/net/bonding/bond_main.c|4 +- drivers/net/bon

Re: [PATCH net-next 0/5] bonding: rename bond components

2020-09-25 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 6:19 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >The bonding driver's use of master and slave, while largely understood > >in technical circles, poses a barrier for inclusion to some potential > >members of the development and user commu

Re: [PATCH net-next 2/5] bonding: rename slave to link where possible

2020-09-25 Thread Jarod Wilson
ar means as num_grat_arp and num_unsol_na use currently. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-23 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 8:01 PM Stephen Hemminger wrote: > > On Tue, 22 Sep 2020 16:47:07 -0700 > Jay Vosburgh wrote: > > > Stephen Hemminger wrote: > > > > >On Tue, 22 Sep 2020 09:37:30 -0400 > > >Jarod Wilson wrote: > > > > > >>

Re: [RFC PATCH] bonding: linkdesc can be static

2020-09-23 Thread Jarod Wilson
static const char *linkdesc = "Slave"; > #else > const char *linkdesc = "Link"; > #endif Good attempt, robot, but you missed the #else. Will fold a full version into my set. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jarod Wilson
On Tue, Sep 22, 2020 at 9:38 AM Jarod Wilson wrote: > > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > diff --git a/drivers/net/bonding/bon

[PATCH net-next 5/5] bonding: update Documentation for link/aggregator terminology

2020-09-22 Thread Jarod Wilson
Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- Documentation/networking/bonding.rst | 440 +-- 1 file changed, 220 insertions(+), 220 deletions(-)

[PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Jarod Wilson
cinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 12 drivers/net/bonding/bond_options.c| 4 ++-- drivers/net/bonding/bond_procfs.c | 14 ++ drivers/net/bonding/bond_sysfs.c

[PATCH net-next 0/5] bonding: rename bond components

2020-09-22 Thread Jarod Wilson
le working on this code, and have run it through multiple lnst test runs, which exercises the existing sysfs interfaces fairly extensively. As far as I can tell, there is no breakage of existing interfaces with this set, unless the user consciously opts to do so via Kconfig. Jarod Wilson (5): bondi

[PATCH net-next 3/5] bonding: rename master to aggregator where possible

2020-09-22 Thread Jarod Wilson
Getting rid of as much usage of "master" as we can here, without breaking any user-facing API. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson ---

[PATCH net-next 1/5] bonding: rename struct slave member link to link_state

2020-09-22 Thread Jarod Wilson
Necessary prep work to recycle the name "link" as a replacement for "slave" in bonding driver terminology. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-

[PATCH net v2] bonding: show saner speed for broadcast mode

2020-08-13 Thread Jarod Wilson
@vger.kernel.org Acked-by: Jay Vosburgh Signed-off-by: Jarod Wilson --- v2: fix description to clarify speed == that of slowest active interface drivers/net/bonding/bond_main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bon

Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-13 Thread Jarod Wilson
On Thu, Aug 13, 2020 at 1:30 AM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Broadcast mode bonds transmit a copy of all traffic simultaneously out of > >all interfaces, so the "speed" of the bond isn't really the aggregate of > >all interfaces, but r

[PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jarod Wilson
...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 5ad43aaf76e5..c853ca67058c 100644 --- a/drivers/net/bon

[PATCH net-next] bonding: don't need RTNL for ipsec helpers

2020-07-08 Thread Jarod Wilson
ntel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index f886d97c4359..e2d491c4378c 100644 --- a/drivers/net/bonding/b

Re: WARNING: suspicious RCU usage in bond_ipsec_add_sa

2020-07-08 Thread Jarod Wilson
is bug is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkal...@googlegroups.com. > > syzbot will keep track of this bug report. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > -- Jarod Wilson ja...@redhat.com

[PATCH net-next] bonding: deal with xfrm state in all modes and add more error-checking

2020-07-08 Thread Jarod Wilson
.@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 39 + 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.

[PATCH net-next] bonding: allow xfrm offload setup post-module-load

2020-06-30 Thread Jarod Wilson
Saeed Mahameed CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- drivers/ne

[PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev

2020-06-23 Thread Jarod Wilson
cinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org Suggested-by: Saeed Mahameed Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 6 +-- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 47 +-- .../mellanox/mlx5/core/en_accel/ipsec.c

Re: [PATCH net-next v2 3/4] mlx5: become aware of when running as a bonding slave

2020-06-21 Thread Jarod Wilson
On Thu, Jun 11, 2020 at 5:51 PM Saeed Mahameed wrote: > > On Wed, 2020-06-10 at 14:59 -0400, Jarod Wilson wrote: > > I've been unable to get my hands on suitable supported hardware to > > date, > > but I believe this ought to be all that is needed to enable the mlx5

[PATCH net-next v3 3/4] mlx5: become aware of when running as a bonding slave

2020-06-19 Thread Jarod Wilson
: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 6 ++ 1 file changed, 6

[PATCH net-next v3 4/4] bonding: support hardware encryption offload to slaves

2020-06-19 Thread Jarod Wilson
Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 127 +++- include/net/bonding.h | 3 + 2 files changed, 128 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 004919aea5fb..90

[PATCH net-next v3 1/4] xfrm: bail early on slave pass over skb

2020-06-19 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

[PATCH net-next v3 0/4] bonding: initial support for hardware crypto offload

2020-06-19 Thread Jarod Wilson
, add proper cc list to cover letter Jarod Wilson (4): xfrm: bail early on slave pass over skb ixgbe_ipsec: become aware of when running as a bonding slave mlx5: become aware of when running as a bonding slave bonding: support hardware encryption offload to slaves CC: Jay Vosburgh CC

[PATCH net-next v3 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-19 Thread Jarod Wilson
CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Acked-by: Jeff Kirsher Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insert

Re: [PATCH net-next v2 0/4] bonding: initial support for hardware crypto offload

2020-06-19 Thread Jarod Wilson
On Fri, Jun 19, 2020 at 6:26 AM Jeff Kirsher wrote: > > On Wed, Jun 10, 2020 at 1:18 PM Jarod Wilson wrote: > > > > This is an initial functional implementation for doing pass-through of > > hardware encryption from bonding device to capable slaves, in activ

[PATCH net-next v2 1/4] xfrm: bail early on slave pass over skb

2020-06-10 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

[PATCH net-next v2 3/4] mlx5: become aware of when running as a bonding slave

2020-06-10 Thread Jarod Wilson
: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 6 ++ 1 file changed, 6

[PATCH net-next v2 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-10 Thread Jarod Wilson
CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Acked-by: Jeff Kirsher Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insert

[PATCH net-next v2 4/4] bonding: support hardware encryption offload to slaves

2020-06-10 Thread Jarod Wilson
Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 127 +++- include/net/bonding.h | 3 + 2 files changed, 128 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a25c65d4af71..88

[PATCH net-next v2 0/4] bonding: initial support for hardware crypto offload

2020-06-10 Thread Jarod Wilson
similarly, but the NIC driver changes are minimal and straight-forward enough that I've included what I think ought to be enough for mlx5 devices too. v2: reordered patches, switched (back) to using CONFIG_XFRM_OFFLOAD to wrap the code additions and wrapped overlooked additions. Jarod Wilson (4): xfrm

Re: [PATCH net-next 3/4] bonding: support hardware encryption offload to slaves

2020-06-08 Thread Jarod Wilson
On Mon, Jun 8, 2020 at 7:48 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Currently, this support is limited to active-backup mode, as I'm not sure > >about the feasilibity of mapping an xfrm_state's offload handle to > >multiple hardware devices simultaneously

[PATCH net-next 1/4] xfrm: bail early on slave pass over skb

2020-06-08 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

[PATCH net-next 2/4] ixgbe_ipsec: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-)

[PATCH net-next 4/4] mlx5: become aware of when running as a bonding slave

2020-06-08 Thread Jarod Wilson
: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 6 ++ 1 file changed, 6

[PATCH net-next 3/4] bonding: support hardware encryption offload to slaves

2020-06-08 Thread Jarod Wilson
u CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson Signed-off-by: Jarod Wilson --- drivers/net/Kconfig | 11 drivers/net/bonding/bond_main.c | 111 +++- include/net/bonding.h | 3 + 3 files ch

[PATCH net-next 0/4] bonding: initial support for hardware crypto offload

2020-06-08 Thread Jarod Wilson
similarly, but the NIC driver changes are minimal and straight-forward enough that I've included what I think ought to be enough for mlx5 devices too. Earlier RFC submissions of this set didn't get any feedback, other than from the build bot, so I'm hoping silence means nobody hated it... Jarod Wilson (4

[RFC PATCH net-next v2 1/3] xfrm: bail early on slave pass over skb

2020-05-05 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

[RFC PATCH net-next v2 2/3] ixgbe_ipsec: become aware of when running as a bonding slave

2020-05-05 Thread Jarod Wilson
CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-)

[RFC PATCH net-next v2 3/3] bonding: support hardware encryption offload to slaves

2020-05-05 Thread Jarod Wilson
Signed-off-by: Jarod Wilson Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c | 111 +++- include/net/bonding.h | 3 + 2 files changed, 111 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_ma

[RFC PATCH net-next v2 0/3] bonding: support hardware crypto offload

2020-05-05 Thread Jarod Wilson
sburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Jarod Wilson (3): xfrm: bail early on slave pass over skb ixgbe_ipsec:

[RFC PATCH net-next 3/3] bonding: support hardware encryption offload to slaves

2020-05-04 Thread Jarod Wilson
Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_ma

[RFC PATCH net-next 2/3] ixgbe_ipsec: become aware of when running as a bonding slave

2020-05-04 Thread Jarod Wilson
CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-)

[RFC PATCH net-next 0/3] bonding: support hardware crypto offload

2020-05-04 Thread Jarod Wilson
ping folks with more of an idea about xfrm have some thoughts on ways to make this cleaner, and possibly support more bonding modes, but I'm reasonably happy I've made it this far. :) Jarod Wilson (3): xfrm: bail early on slave pass over skb ixgbe_ipsec: become aware of when running as a bon

[RFC PATCH net-next 1/3] xfrm: bail early on slave pass over skb

2020-05-04 Thread Jarod Wilson
CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirsher CC: Jakub Kicinski CC: Steffen Klassert CC: Herbert Xu CC: net...@vger.kernel.org CC: intel-wired-...@lists.osuosl.org Signed-off-by: Jarod Wilson --- include/net/xfrm.h | 1 + net/xfrm/xfrm_dev

Re: [PATCH net] bonding: make debugging output more succinct

2019-06-07 Thread Jarod Wilson
On 6/7/19 10:59 AM, Jarod Wilson wrote: Seeing bonding debug log data along the lines of "event: 5" is a bit spartan, and often requires a lookup table if you don't remember what every event is. Make use of netdev_cmd_to_name for an improved debugging experience, so for the prior examp

  1   2   3   4   5   6   7   >