Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-11 Thread Jason Wang
On Thu, Dec 7, 2023 at 7:28 PM Yunsheng Lin wrote: > > On 2023/12/7 14:00, Jason Wang wrote: > > On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > ... > > >> + > >> +static int tun_alloc(void) > >> +{ > >> + struct ifreq ifr; >

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-11 Thread Jason Wang
On Tue, Dec 12, 2023 at 12:37 AM Michael S. Tsirkin wrote: > > On Fri, Dec 08, 2023 at 04:07:54PM +0900, David Stevens wrote: > > If a virtio_pci_device supports native PCI power management and has the > > No_Soft_Reset bit set, then skip resetting and reinitializing the device > > when

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-11 Thread Jason Wang
On Tue, Dec 12, 2023 at 12:54 AM Michael S. Tsirkin wrote: > > On Mon, Dec 11, 2023 at 03:26:46PM +0800, Jason Wang wrote: > > > Try reducing the VHOST_NET_WEIGHT limit and see if that improves things > > > any? > > > > Or a dirty hack like cond_resched()

Re: [PATCH v2] virtio: Add support for no-reset virtio PCI PM

2023-12-10 Thread Jason Wang
wer states like s2idle to be used in systems with stateful virtio > devices that can't simply be re-initialized (e.g. virtio-fs). > > Signed-off-by: David Stevens Acked-by: Jason Wang Thanks > --- > v1 -> v2: > - Check the No_Soft_Reset bit > >

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-12-10 Thread Jason Wang
On Sat, Dec 9, 2023 at 6:42 PM Michael S. Tsirkin wrote: > > On Fri, Dec 08, 2023 at 12:41:38PM +0100, Tobias Huschle wrote: > > On Fri, Dec 08, 2023 at 05:31:18AM -0500, Michael S. Tsirkin wrote: > > > On Fri, Dec 08, 2023 at 10:24:16AM +0100, Tobias Huschle wrote: > > > > On Thu, Dec 07, 2023

Re: [PATCH net-next 6/6] tools: virtio: introduce vhost_net_test

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > introduce vhost_net_test basing on virtio_test to test > vhost_net changing in the kernel. > > Signed-off-by: Yunsheng Lin > --- > tools/virtio/Makefile | 8 +- > tools/virtio/vhost_net_test.c | 441

Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2023-12-06 Thread Jason Wang
st_net_test introduced in the > last patch. > > Signed-off-by: Yunsheng Lin > --- Acked-by: Jason Wang Thanks

Re: [PATCH net-next 5/6] net: introduce page_frag_cache_drain()

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:35 PM Yunsheng Lin wrote: > > When draining a page_frag_cache, most user are doing > the similar steps, so introduce an API to avoid code > duplication. > > Signed-off-by: Yunsheng Lin > --- For vhost part: Acked-by: Jason Wang Thanks

Re: [GIT PULL] virtio: features

2023-11-30 Thread Jason Wang
On Thu, Nov 30, 2023 at 5:44 PM Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2023 at 06:20:31PM +0800, Jason Wang wrote: > > On Wed, Nov 29, 2023 at 6:12 PM Ning, Hongyu > > wrote: > > > > > > > > > On 2023/11/29 17:16, Jason Wang wrote: > &g

Re: [GIT PULL] virtio: features

2023-11-29 Thread Jason Wang
flag > >vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature > >vdpa: add get_backend_features vdpa operation > >vdpa_sim: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK > > > > Jason Wang (1): > >virtio_v

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-09 Thread Jason Wang
On Wed, Nov 8, 2023 at 3:09 PM Jason Wang wrote: > > On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > >

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-07 Thread Jason Wang
On Wed, Nov 8, 2023 at 2:39 PM Cindy Lu wrote: > > On Wed, Nov 8, 2023 at 11:03 AM Jason Wang wrote: > > > > On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > > > > > On Mon, Nov 6, 2023 at 3:30 PM Jason Wang wrote: > > > > > &

Re: [RFC v1 8/8] iommu: expose the function iommu_device_use_default_domain

2023-11-07 Thread Jason Wang
On Tue, Nov 7, 2023 at 2:10 PM Cindy Lu wrote: > > On Mon, Nov 6, 2023 at 3:26 PM Jason Wang wrote: > > > > On Sat, Nov 4, 2023 at 1:18 AM Cindy Lu wrote: > > > > > > Expose the function iommu_device_use_default_domain() and > > > iommu_device_

Re: [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd

2023-11-07 Thread Jason Wang
On Tue, Nov 7, 2023 at 2:57 PM Cindy Lu wrote: > > On Mon, Nov 6, 2023 at 3:30 PM Jason Wang wrote: > > > > On Sat, Nov 4, 2023 at 1:17 AM Cindy Lu wrote: > > > > > > VHOST_VDPA_SET_IOMMU_FD: bind the device to iommufd device > > > > > &g

[PATCH] nvdimm/namespace: Fix comment typo

2022-08-02 Thread Jason Wang
The double `existing' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/nvdimm/namespace_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index dfade66bab73..c60ec0b373c5

[PATCH V3 2/2] virtio_pmem: set device ready in probe()

2022-06-28 Thread Jason Wang
by: Pankaj Gupta Signed-off-by: Jason Wang --- Changes since V2: - Tweak the change log Changes since v1: - Remove some comments per Dan --- drivers/nvdimm/virtio_pmem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c index 48

[PATCH V3 1/2] virtio_pmem: initialize provider_data through nd_region_desc

2022-06-28 Thread Jason Wang
3/0x90 [ 92.408895] entry_SYSCALL_64_after_hwframe+0x46/0xb0 [ 92.409257] RIP: 0033:0x7f3cd76c6c44 Fixes 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") Acked-by: Pankaj Gupta Reviewed-by: Dan Williams Signed-off-by: Jason Wang --- Changes since V1: - Add calltrace to explain the

Re: [PATCH V2 2/2] virtio_pmem: set device ready in probe()

2022-06-27 Thread Jason Wang
On Mon, Jun 27, 2022 at 4:00 PM Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2022 at 02:29:41PM +0800, Jason Wang wrote: > > The NVDIMM region could be available before the virtio_device_ready() > > that is called by virtio_dev_probe(). This means the driver tries to >

[PATCH V2 2/2] virtio_pmem: set device ready in probe()

2022-06-27 Thread Jason Wang
ot;) Acked-by: Pankaj Gupta Signed-off-by: Jason Wang --- Changes since v1: - Remove some comments per Dan --- drivers/nvdimm/virtio_pmem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c index 48f8327d0431..20da455d2ef6 100644 ---

[PATCH V2 1/2] virtio_pmem: initialize provider_data through nd_region_desc

2022-06-27 Thread Jason Wang
3/0x90 [ 92.408895] entry_SYSCALL_64_after_hwframe+0x46/0xb0 [ 92.409257] RIP: 0033:0x7f3cd76c6c44 Fixes 6e84200c0a29 ("virtio-pmem: Add virtio pmem driver") Acked-by: Pankaj Gupta Reviewed-by: Dan Williams Signed-off-by: Jason Wang --- Changes since V1: - Add calltrace to explain the

Re: [PATCH V4 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-19 Thread Jason Wang
Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 27 +++ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h index b2eeb16b9c2c

Re: [PATCH V3 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff

Re: [PATCH V3 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++- drivers/vdpa/ifcvf/ifcvf_main.c | 19 ++- 2 files

Re: [PATCH V3 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-18 Thread Jason Wang
在 2021/4/16 下午3:16, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan ---

Re: [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-15 Thread Jason Wang
在 2021/4/15 下午4:12, Stefano Garzarella 写道: On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10

[PATCH 7/7] vp_vdpa: report doorbell address

2021-04-15 Thread Jason Wang
This patch reports the per vq doorbell location and size to vDPA bus. Userspace can then map the doorbell via mmap() via vhost-vDPA bus driver. Signed-off-by: Jason Wang --- drivers/vdpa/virtio_pci/vp_vdpa.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[PATCH 6/7] virtio-pci library: report resource address

2021-04-15 Thread Jason Wang
Sometimes it might be useful to report the capability physical address. One example is to report the physical address of the doorbell in order to be mapped by userspace. Signed-off-by: Jason Wang --- drivers/vdpa/virtio_pci/vp_vdpa.c | 3 ++- drivers/virtio/virtio_pci_modern.c | 2

[PATCH 5/7] virito_pci libray: hide vp_modern_map_capability()

2021-04-15 Thread Jason Wang
No user now and the capability should not be setup externally. Instead, every access to the capability should be done via virtio_pci_modern_device. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 10 -- include/linux/virtio_pci_modern.h | 5 - 2 files

[PATCH 4/7] virtio_pci_modern: hide vp_modern_get_queue_notify_off()

2021-04-15 Thread Jason Wang
All users (both virtio-pci library and vp_vdpa driver) has been switched to use vp_modern_map_vq_notify(). So there's no need to export the low level helper of vp_modern_get_queue_notify_off(). Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 5 ++--- include/linux

[PATCH 3/7] vp_vdpa: switch to use vp_modern_map_vq_notify()

2021-04-15 Thread Jason Wang
This patch switches to use vp_vdpa to use vp_modern_map_notify(). Signed-off-by: Jason Wang --- drivers/vdpa/virtio_pci/vp_vdpa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c index

[PATCH 1/7] virtio_pci_modern: introduce helper to map vq notify area

2021-04-15 Thread Jason Wang
This patch factors out the logic of vq notify area mapping. Following patches will switch to use this common helpers for both virtio_pci library and virtio-pci vDPA driver. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 35 ++ include/linux

[PATCH 2/7] virtio-pci library: switch to use vp_modern_map_vq_notify()

2021-04-15 Thread Jason Wang
This patch switch to use vp_modern_map_notify() for virtio-pci library. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio

[PATCH 0/7] Doorbell mapping support for virito-pci vDPA

2021-04-15 Thread Jason Wang
Hi All: This series implements the doorbell mapping support for virtio-pci vDPA driver. Tested with page-per-vq=on in a nested guest. Please review Thanks Jason Wang (7): virtio_pci_modern: introduce helper to map vq notify area virtio-pci library: switch to use vp_modern_map_vq_notify

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-15 Thread Jason Wang
在 2021/4/15 下午2:41, Zhu Lingshan 写道: I think we've discussed this sometime in the past but what's the reason for such whitelist consider there's already a get_features() implemention? E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or VIRTIO_F_RING_PACKED? Thanks The reason is some

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-15 Thread Jason Wang
在 2021/4/15 下午2:36, Zhu Lingshan 写道: On 4/15/2021 2:30 PM, Jason Wang wrote: 在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-15 Thread Jason Wang
在 2021/4/15 下午1:55, Zhu Lingshan 写道: On 4/15/2021 11:34 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 17 -   drivers

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-15 Thread Jason Wang
在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-14 Thread Jason Wang
在 2021/3/23 下午10:19, Jie Deng 写道: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on

Re: [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 17 - drivers/vdpa/ifcvf/ifcvf_main.c | 10 +- 2 files changed, 25 insertions(+), 2

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Jason Wang
在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan ---

[PATCH] vhost-vdpa: fix vm_flags for virtqueue doorbell mapping

2021-04-13 Thread Jason Wang
xes this by setting the necessary vm_flags. With this patch, try to map doorbell via IOTLB will fail with bad address. Cc: sta...@vger.kernel.org Fixes: ddd89d0a059d ("vhost_vdpa: support doorbell mapping via mmap") Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 1 + 1 file changed

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: It's unsafe to operate a vq from multiple threads. Unfortunately this is exactly what we do when invoking clean tx poll from rx napi. As a fix move everything that deals with the vq to under tx lock. Signed-off-by: Michael S. Tsirkin ---

Re: [PATCH RFC v2 2/4] virtio_net: disable cb aggressively

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: There are currently two cases where we poll TX vq not in response to a callback: start xmit and rx napi. We currently do this with callbacks enabled which can cause extra interrupts from the card. Used not to be a big issue as we run with interrupts

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: virtio_disable_cb is currently a nop for split ring with event index. This is because it used to be always called from a callback when we know device won't trigger more events until we update the index. However, now that we run with interrupts

Re: [PATCH][next] vdpa/mlx5: Fix resource leak of mgtdev due to incorrect kfree

2021-04-12 Thread Jason Wang
4 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -2089,7 +2089,7 @@ static int mlx5v_probe(struct auxiliary_device *adev, return 0; reg_err: - kfree(mdev); + kfree(mgtdev); return err; } Acked-by: Jason Wang

Re: [RFC PATCH] vdpa: mandate 1.0 device

2021-04-12 Thread Jason Wang
在 2021/4/12 下午5:09, Michael S. Tsirkin 写道: On Mon, Apr 12, 2021 at 02:35:07PM +0800, Jason Wang wrote: 在 2021/4/10 上午12:04, Michael S. Tsirkin 写道: On Fri, Apr 09, 2021 at 12:47:55PM +0800, Jason Wang wrote: 在 2021/4/8 下午11:59, Michael S. Tsirkin 写道: On Thu, Apr 08, 2021 at 04:26:48PM +0800

Re: [RFC PATCH] vdpa: mandate 1.0 device

2021-04-12 Thread Jason Wang
在 2021/4/10 上午12:04, Michael S. Tsirkin 写道: On Fri, Apr 09, 2021 at 12:47:55PM +0800, Jason Wang wrote: 在 2021/4/8 下午11:59, Michael S. Tsirkin 写道: On Thu, Apr 08, 2021 at 04:26:48PM +0800, Jason Wang wrote: This patch mandates 1.0 for vDPA devices. The goal is to have the semantic

Re: [RFC PATCH] vdpa: mandate 1.0 device

2021-04-08 Thread Jason Wang
在 2021/4/8 下午11:59, Michael S. Tsirkin 写道: On Thu, Apr 08, 2021 at 04:26:48PM +0800, Jason Wang wrote: This patch mandates 1.0 for vDPA devices. The goal is to have the semantic of normative statement in the virtio spec and eliminate the burden of transitional device for both vDPA bus

[RFC PATCH] vdpa: mandate 1.0 device

2021-04-08 Thread Jason Wang
devices. For legacy guests, it can still work since Qemu will mediate when necessary (e.g doing the endian conversion). Signed-off-by: Jason Wang --- include/linux/vdpa.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 0fefeb976877

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-06 Thread Jason Wang
在 2021/4/6 下午8:42, Jason Gunthorpe 写道: On Tue, Apr 06, 2021 at 09:35:17AM +0800, Jason Wang wrote: VFIO and VDPA has no buisness having map/unmap interfaces once we have /dev/ioasid. That all belongs in the iosaid side. I know they have those interfaces today, but that doesn't mean we have

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-05 Thread Jason Wang
在 2021/4/6 上午7:42, Jason Gunthorpe 写道: On Fri, Apr 02, 2021 at 08:22:28AM +, Tian, Kevin wrote: From: Jason Gunthorpe Sent: Tuesday, March 30, 2021 9:29 PM First, userspace may use ioasid in a non-SVA scenario where ioasid is bound to specific security context (e.g. a control vq in

Re: [PATCH 1/3] virtio_ring: always warn when descriptor chain exceeds queue size

2021-03-22 Thread Jason Wang
在 2021/3/22 下午4:17, Michael S. Tsirkin 写道: On Mon, Mar 22, 2021 at 11:22:15AM +0800, Jason Wang wrote: 在 2021/3/18 下午9:52, Connor Kuehl 写道: From section 2.6.5.3.1 (Driver Requirements: Indirect Descriptors) of the virtio spec: "A driver MUST NOT create a descriptor chain longer

Re: [PATCH 3/3] fuse: fix typo for fuse_conn.max_pages comment

2021-03-21 Thread Jason Wang
在 2021/3/18 下午9:52, Connor Kuehl 写道: 'Maxmum' -> 'Maximum' Need a better log here. With the commit log fixed. Acked-by: Jason Wang Signed-off-by: Connor Kuehl --- fs/fuse/fuse_i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/fuse_i.h b/fs/f

Re: [PATCH 1/3] virtio_ring: always warn when descriptor chain exceeds queue size

2021-03-21 Thread Jason Wang
在 2021/3/18 下午9:52, Connor Kuehl 写道: From section 2.6.5.3.1 (Driver Requirements: Indirect Descriptors) of the virtio spec: "A driver MUST NOT create a descriptor chain longer than the Queue Size of the device." This text suggests that the warning should trigger even if indirect

Re: vDPA: explain in Kconfig what vDPA is, capitalise it consistenly

2021-03-21 Thread Jason Wang
在 2021/3/22 上午12:34, Pavel Machek 写道: Not everyone knows what vDPA stands for, explain it in Kconfig. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig index ffd1e098bfd2..8cb37b3dd279 100644 --- a/drivers/vdpa/Kconfig +++ b/drivers/vdpa/Kconfig @@

Re: [PATCH v4 14/14] vdpa_sim_blk: add support for vdpa management tool

2021-03-17 Thread Jason Wang
"mgmtdev": "vdpasim_blk", "vendor_id": 0, "max_vqs": 1, "max_vq_size": 256 } } } # Delete the vDPA device after its use $ vdpa dev del blk0

Re: [PATCH v4 10/14] vhost/vdpa: Remove the restriction that only supports virtio-net devices

2021-03-17 Thread Jason Wang
failures. Signed-off-by: Xie Yongji Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 7ae4080e57d8..850ed4b62942 100644 --- a/drivers

Re: [PATCH v4 09/14] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: Let's use the new 'get_config_size()' callback available instead of using the 'virtio_id' to get the size of the device config space. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 9 ++--- 1 file

Re: [PATCH v4 08/14] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- include/linux/vdpa.h | 4 drivers/vdpa/ifcvf/ifcvf_main.c | 6

Re: [PATCH V5 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-17 Thread Jason Wang
f (pdev->device < 0x1040) + ret = pdev->subsystem_device; + else + ret = pdev->device - 0x1040; + + return ret; } It would be better to keep the comment. But anyway Acked-by: Jason Wang static u32 ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev)

Re: [PATCH V4 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:45, Zhu Lingshan 写道: static u32 ifcvf_vdpa_get_device_id(struct vdpa_device *vdpa_dev) { - return VIRTIO_ID_NET; + struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); + u32 ret = -EOPNOTSUPP; + + if (ifcvf_probed_virtio_net(vf)) + ret =

Re: [PATCH V4 6/7] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-16 Thread Jason Wang
ERR(ifcvf->pdev, "VIRTIO_F_ACCESS_PLATFORM not negotiated\n"); Should be "is not negotiated". Otherwise: Acked-by: Jason Wang + return -EINVAL; + } + + return 0; +} + void ifcvf_read_net_config(struct ifcvf_hw *hw, u64 offset,

Re: [PATCH V4 5/7] vDPA/ifcvf: fetch device feature bits when probe

2021-03-16 Thread Jason Wang
Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.c | 12 ++-- drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++ drivers/vdpa/ifcvf/ifcvf_main.c | 2 ++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf

Re: [PATCH V4 4/7] vDPA/ifcvf: remove the version number string

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan Reviewed-by: Leon Romanovsky Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH V4 3/7] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang If you want to have a general driver, you pr

Re: [PATCH V4 2/7] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions

Re: [PATCH V4 1/7] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-16 Thread Jason Wang
在 2021/3/15 下午3:44, Zhu Lingshan 写道: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions

Re: [PATCH] vhost: Fix vhost_vq_reset()

2021-03-15 Thread Jason Wang
_le(vq); vhost_disable_cross_endian(vq); And so user_be is used before being set. To fix that, reverse the lines order as there is no other dependency between them. Signed-off-by: Laurent Vivier Acked-by: Jason Wang --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v7] i2c: virtio: add a virtio i2c frontend driver

2021-03-14 Thread Jason Wang
On 2021/3/15 9:14 上午, Jie Deng wrote: On 2021/3/12 16:58, Arnd Bergmann wrote: On Fri, Mar 12, 2021 at 2:33 PM Jie Deng wrote: + +/** + * struct virtio_i2c_req - the virtio I2C request structure + * @out_hdr: the OUT header of the virtio I2C message + * @buf: the buffer into which data is

Re: linux-next: Tree for Mar 11 [drivers/vdpa/virtio_pci/vp_vdpa.ko]

2021-03-12 Thread Jason Wang
On 2021/3/12 2:18 上午, Randy Dunlap wrote: On 3/10/21 9:14 PM, Stephen Rothwell wrote: Hi all, Warning: Some of the branches in linux-next are still based on v5.12-rc1, so please be careful if you are trying to bisect a bug. News: if your -next included tree is based on Linus' tree tag

[PATCH] vdpa: fix build dependency of VIRTIO_PCI_LIB

2021-03-12 Thread Jason Wang
The modern PCI device module should be built independently without VIRTIO. This patch fixes this. Fixes: 7075992ba8873(“vdpa: introduce virtio pci driver") Reported-by: Randy Dunlap Signed-off-by: Jason Wang --- drivers/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/12 2:40 下午, Zhu, Lingshan wrote: On 3/12/2021 1:52 PM, Jason Wang wrote: On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu

Re: [PATCH 2/2] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails

2021-03-11 Thread Jason Wang
to use an invalid pointer in other functions such as vhost_vdpa_config_put(). Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c

Re: [PATCH 1/2] vhost-vdpa: fix use-after-free of v->config_ctx

2021-03-11 Thread Jason Wang
e+0x44/0xae Fixes: 776f395004d8 ("vhost_vdpa: Support config interrupt in vdpa") Cc: lingshan@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-11 Thread Jason Wang
On 2021/3/11 3:19 下午, Zhu, Lingshan wrote: On 3/11/2021 2:20 PM, Jason Wang wrote: On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/11 12:16 下午, Zhu Lingshan wrote: On 3/11/2021 11:20 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.c

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/11 12:23 下午, Zhu Lingshan wrote: On 3/11/2021 11:25 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-o

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/11 12:21 下午, Zhu Lingshan wrote: On 3/11/2021 11:23 AM, Jason Wang wrote: On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan

Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 8

Re: [PATCH V3 1/6] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH V3 6/6] vDPA/ifcvf: verify mandatory feature bits for vDPA

2021-03-10 Thread Jason Wang
On 2021/3/10 5:00 下午, Zhu Lingshan wrote: vDPA requres VIRTIO_F_ACCESS_PLATFORM as a must, this commit examines this when set features. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.c | 8 drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 5

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-09 Thread Jason Wang
On 2021/3/10 10:22 上午, Jie Deng wrote: On 2021/3/4 17:15, Jason Wang wrote: +    } + +    if (msgs[i].flags & I2C_M_RD) +    memcpy(msgs[i].buf, req->buf, msgs[i].len); Sorry if I had asked this before but any rason not to use msg[i].buf directly? The msg

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/9 10:28 上午, Zhu, Lingshan wrote: On 3/9/2021 10:23 AM, Jason Wang wrote: On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan ---   drivers/vdpa/ifcvf/ifcvf_base.h | 5 +   drivers/vdpa

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit removes the version number string, using kernel version is enough. Signed-off-by: Zhu Lingshan --- Acked-by: Jason Wang drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/ifcvf

Re: [PATCH V2 3/4] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: IFCVF driver probes multiple types of devices now, to distinguish the original device driven by IFCVF from others, it is renamed as "N3000". Signed-off-by: Zhu Lingshan Acked-by: Jason Wang You probably need to rename the drive

Re: [PATCH V2 2/4] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 5 + drivers/vdpa/ifcvf/ifcvf_main.c | 5 + 2 files changed, 10 insertions(+) diff --git

Re: [PATCH V2 1/4] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-08 Thread Jason Wang
On 2021/3/8 4:35 下午, Zhu Lingshan wrote: In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4

Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space

2021-03-07 Thread Jason Wang
On 2021/3/5 4:37 下午, Stefano Garzarella wrote: On Thu, Mar 04, 2021 at 04:31:22PM +0800, Jason Wang wrote: On 2021/3/2 10:06 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: vdpa_get_config

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-07 Thread Jason Wang
On 2021/3/5 10:19 下午, Zhu Lingshan wrote: This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named

Re: [PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-07 Thread Jason Wang
ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev) { - return IFCVF_SUBSYS_VENDOR_ID; + struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev); + struct pci_dev *pdev = adapter->pdev; + + return pdev->subsystem_vendor; } Acked-by: Jason Wang stat

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Jason Wang
On 2021/3/5 1:47 下午, Jie Deng wrote: On 2021/3/4 17:15, Jason Wang wrote: On 2021/3/4 9:59 上午, Jie Deng wrote: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/4 9:50 下午, Cornelia Huck wrote: On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote

Re: [PATCH v6] i2c: virtio: add a virtio i2c frontend driver

2021-03-04 Thread Jason Wang
On 2021/3/4 9:59 上午, Jie Deng wrote: Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. The device specification can be found on

Re: [RFC PATCH 01/10] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-04 Thread Jason Wang
On 2021/3/2 10:15 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:14:13PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella ---  include

Re: [RFC PATCH 10/10] vhost/vdpa: return configuration bytes read and written to user space

2021-03-04 Thread Jason Wang
On 2021/3/2 10:06 下午, Stefano Garzarella wrote: On Tue, Mar 02, 2021 at 12:05:35PM +0800, Jason Wang wrote: On 2021/2/16 5:44 下午, Stefano Garzarella wrote: vdpa_get_config() and vdpa_set_config() now return the amount of bytes read and written, so let's return them to the user space. We

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Jason Wang
On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
On 2021/3/2 5:51 下午, Michael S. Tsirkin wrote: On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang Indeed and it's not just mlock

[PATCH V2] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
ility. " Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Jason Wang --- drivers/vhost/vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index ef688c8c0e0e..e93572e2e344 100644 --- a/

<    1   2   3   4   5   6   7   8   9   10   >