t;>> =
> >>>
> >>> Each watchdog driver, to check if one of the global parameters is
> >>> enabled, can use the corresponding in-line function declared in
> >>> include/linux/watchdog.h.
> >>> At the moment the following functions are ready to use:
> >>>
> >>> * watchdog_global_param_verbose_enabled()
> >>> * watchdog_global_param_test_mode_enabled()
> >>> * watchdog_global_param_start_enabled()
> >>> * watchdog_global_param_nowayout_enabled()
> >>>
> >>>
> >>>
> >>> Flavio Suligoi (2):
> >>> watchdog: add global watchdog kernel module parameters structure
> >>> watchdog: wdat: add start_enable global parameter
> >>>
> >>> Documentation/watchdog/index.rst | 1 +
> >>> .../watchdog-core-global-parameters.rst | 74 +++
> >>> drivers/watchdog/watchdog_core.c | 74 +++
> >>> drivers/watchdog/wdat_wdt.c | 2 +
> >>> include/linux/watchdog.h | 42 +++
> >>> 5 files changed, 193 insertions(+)
> >>> create mode 100644
> >>> Documentation/watchdog/watchdog-core-global-parameters.rst
> >>>
> >
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
riable.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Zhong
> ---
> drivers/watchdog/hpwdt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jerry Hoemann
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
&g
tdown.
> > The devices that were left in an unknown state and sending interrupt
> > could be a problem, but it's irrelevant to this hanging problem.
> >
> > I think I didn't make one thing clear, The PCI UR error never arrives
> > in kernel, it's the iLo BMC on that HPE machine caught the error, and
> > send kernel an NMI. kernel is panicked by NMI, I'm still trying to
> > figure out why the NMI hanged kernel, even with panic=-1,
> > panic_on_io_nmi, panic_on_unknown_nmi all set. But if we can avoid the
> > NMI by shutdown the devices in right order, that's also a solution.
>
> I'm not sure how much sympathy to have for this situation. A PCIe UR
> is fatal for the transaction and maybe even the device, but from the
> overall system point of view, it *should* be a recoverable error and
> we shouldn't panic.
>
> Errors like that should be reported via the normal AER or ACPI/APEI
> mechanisms. It sounds like in this case, the platform has decided
> these aren't enough and it is trying to force a reboot? If this is
> "special" platform behavior, I'm not sure how much we need to cater
> for it.
>
Are these AER errors the type processed by the GHES code?
I'll note that RedHat runs their crash kernel with: hest_disable.
So, the ghes code is disabled in the crash kernel.
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
On Thu, Aug 08, 2019 at 02:33:24PM -0600, Jerry Hoemann wrote:
> On Fri, Aug 02, 2019 at 06:33:28PM +0200, Peter Zijlstra wrote:
> > On Fri, Aug 02, 2019 at 06:20:15PM +0200, Peter Zijlstra wrote:
> > > On Fri, Aug 02, 2019 at 02:33:41PM +, Lendacky, Thomas wrote:
&g
l $0, %rax
> movq %rax, %cr8
> sti
> hlt
>
Hi Peter,
What is our the next step here?
Are you still looking to make this change?
Do we want to pick up Tom Lendacky's patch on an interim basis while
you're working on the bigger change? (I can say we tested Tom's
patch
attorney, I am not sure, and I opted for leaving such paragraphs in
> place.
>
For hpwdt.c changes:
Reviewed-by: Jerry Hoemann
> drivers/watchdog/acquirewdt.c | 6 +-
> drivers/watchdog/advantechwdt.c| 6 +-
> drivers/watchdog/ath79_wdt.c | 6
the "make htmldocs" to complete.
Jerry Hoemann (1):
docs: watchdog: Fix build error.
Documentation/watchdog/watchdog-parameters.rst | 2 ++
1 file changed, 2 insertions(+)
--
2.20.1
make htmldocs fails due to missing blank line following header.
Signed-off-by: Jerry Hoemann
---
Documentation/watchdog/watchdog-parameters.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/watchdog/watchdog-parameters.rst
b/Documentation/watchdog/watchdog-parameters.rst
On Fri, May 17, 2019 at 02:59:37PM -0600, Jerry Hoemann wrote:
> First two changes makes hpwdt more generic.
> Next two changes make hpwdt work better with kdump.
>
Hi Guenter,
Did you have feedback on this patch set?
Thanks
Jerry
>
> Jerry Hoemann (6):
> watchdog
Have the WD core stop the watchdog on unregister instead of explicitly
calling hpwdt_stop() in hpwdt_exit().
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index
Bump driver number to reflect recent changes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index dc65006..9e02f88 100644
--- a/drivers/watchdog/hpwdt.c
+++ b
Update documentation to explain new module parameter kdumptimeout.
Signed-off-by: Jerry Hoemann
---
Documentation/watchdog/hpwdt.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/watchdog/hpwdt.txt b/Documentation/watchdog/hpwdt.txt
index 55df692..35da141 100644
First two changes makes hpwdt more generic.
Next two changes make hpwdt work better with kdump.
Jerry Hoemann (6):
watchdog/hpwdt: Stop hpwdt on unregister.
watchdog/hpwdt: Advertize max_hw_heartbeat_ms
watchdog/hpwdt: Have core ping watchdog.
watchdog/hpwdt: Add module parameter
Instead of stopping the hw timer during probe, have the core update
the timer if the timer is already running.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog
Set max_hw_heartbeat_ms instead of max_timeout so that user client can
set timeout range in excess of what the underlying hardware supports.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog
Instead of unconditionally stopping the watchdog timer after receipt of
a pretimeout NMI, reprogram the timeout based upon module parameter
kdumptimeout.
The provides a more flexible override than the depricated allow_kdump.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 27
On Fri, Feb 22, 2019 at 07:49:28AM +0100, Greg KH wrote:
> On Thu, Feb 21, 2019 at 09:11:11PM -0700, Jerry Hoemann wrote:
>
> > Our primary means of supporting Linux to our customers is via our
> > distro partners. While we prefer to use in distro drivers, HPE does
> > f
to blacklist an instance.
Hope this helps.
Jerry
--
---------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
e version module actually being used.
Take care,
Jerry
>
> Want me to drop it?
No. please keep it. :)
--
---------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
h set.
Hope this helps.
Take care,
Jerry
--
---------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
Update documentation relating to HPWDT_NMI_DECODING to reflect its
current usage.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/Kconfig | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 57f017d..846dd07
On Sat, Feb 02, 2019 at 09:55:29AM +0500, Ivan Mironov wrote:
> On Tue, 2019-01-15 at 19:27 -0700, Jerry Hoemann wrote:
> > On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote:
>
> Somehow I missed the whole pretimout thing when reading about the
> watchdog API. Thanks
Document the sysfs attributes:
pretimeout
pretimeout_available_governors
pretimeout_governor
Signed-off-by: Jerry Hoemann
---
Documentation/ABI/testing/sysfs-class-watchdog | 23 +++
1 file changed, 23 insertions(+)
diff --git a/Documentation/ABI
On Fri, Feb 01, 2019 at 12:47:40AM +0100, Borislav Petkov wrote:
> On Thu, Jan 31, 2019 at 03:27:32PM -0700, Jerry Hoemann wrote:
> > So even if a system administrator is diligent and tests
> > that a chosen kdump configuration works, that configuration
> > might not work on
be the time that the system crashes
and we won't be able to collect the crash dump due to the
crashkernel allocation failure.
Jerry
--
---------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
On Tue, Jan 29, 2019 at 09:01:03AM +0200, Matti Vaittinen wrote:
> On Mon, Jan 28, 2019 at 01:26:56PM -0700, Jerry Hoemann wrote:
> > On Sat, Jan 26, 2019 at 08:30:24AM -0800, Guenter Roeck wrote:
> > > On 1/25/19 3:05 AM, Matti Vaittinen wrote:
> > > > +static int b
k
> if (enable == !!(*old_state & BD70528_WAKE_STATE_BIT))
> would be much better readable. Even if not, there are way too many ()
> in the above conditional.
>
The substitution is not equivalent to original. I think you mean:
if (!!en
_MAX,
> + crash_size, CRASH_ALIGN);
> +#endif
> if (!crash_base) {
> pr_info("crashkernel reservation failed - No suitable
> area found.\n");
> return;
> --
> 2.7.4
&
lity to the watchdog core are welcome;
> it should be possible to move the functionality into the core (maybe
> to be enabled with a new watchdog API call). Doing it using the class
> device sounds like an excellent idea. This should be straightforward
> to implement, though the ques
if (ilo5 && !pretimeout && !mynmi)
> return NMI_DONE;
>
> - hpwdt_stop();
> -
> hex_byte_pack(panic_msg, mynmi);
> nmi_panic(regs, panic_msg);
>
> --
> 2.20.1
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
++--
> 1 file changed, 25 insertions(+), 20 deletions(-)
>
> --
> 2.20.1
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
e started (default="
> #ifdef CONFIG_HPWDT_NMI_DECODING
> module_param(pretimeout, bool, 0);
> MODULE_PARM_DESC(pretimeout, "Watchdog pretimeout enabled");
> -#endif
> +
> +module_param(panic_on_nmi, bool, 0);
> +MODULE_PARM_DESC(panic_on_nmi, &
Do not claim when SSID 0x0289 as the watchdog features
are not enabled/validated by the firmware.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index eecd014..c8e8055 100644
0x0289 to the blacklist table.
4) Print via dev_dbg instead of dev_info.
Jerry Hoemann (3):
watchdog/hpwdt: Exclude via blacklist
watchdog/hpwdt: Do not claim unsupported hardware
watchdog/hpwdt: Update driver version.
drivers/watchdog/hpwdt.c | 15 +--
1 file changed, 9 insertions
Do not claim when SSID 0x0289 as the watchdog features
are not enabled/validated by the firmware.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index eecd014..c8e8055 100644
0x0289 to the blacklist table.
4) Print via dev_dbg instead of dev_info.
Jerry Hoemann (3):
watchdog/hpwdt: Exclude via blacklist
watchdog/hpwdt: Do not claim unsupported hardware
watchdog/hpwdt: Update driver version.
drivers/watchdog/hpwdt.c | 15 +--
1 file changed, 9 insertions
Bump version number to reflect recent minor changes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index c8e8055..ef30c7e 100644
--- a/drivers/watchdog/hpwdt.c
Instead of having explicit if statments excluding devices,
use a pci_device_id table of devices to blacklist.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog
Bump version number to reflect recent minor changes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index c8e8055..ef30c7e 100644
--- a/drivers/watchdog/hpwdt.c
Instead of having explicit if statments excluding devices,
use a pci_device_id table of devices to blacklist.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog
Do not claim when SSID 0x0289 as the watchdog features
are not enabled/validated by the firmware.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 9356230
Do not claim when SSID 0x0289 as the watchdog features
are not enabled/validated by the firmware.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 9356230
Add command line argument to call and display the results
of ioctl WDIOC_GETTIMELEFT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/watchdog/watchdog
Add command line argument to call and display the results
of ioctl WDIOC_GETTIMELEFT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/watchdog/watchdog
--
...
# Entries in this file show the compile time defaults.
...
#ShutdownWatchdogSec=10min
--
-----
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
--
...
# Entries in this file show the compile time defaults.
...
#ShutdownWatchdogSec=10min
--
-----
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/tools/testing
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/tools/testing
n
add new patch 1 to fix the existing printf first.
Jerry Hoemann (2):
selftests: watchdog: Fix error message.
selftests: watchdog: Add gettimeout and get|set pretimeout
tools/testing/selftests/watchdog/watchdog-test.c | 41 +---
1 file changed, 36 insertions(+), 5 deletions(-)
--
1.8.3.1
Printf's say errno but print the string version of error.
Make consistent.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/watchdog/watchdog-test.c
b/tools
n
add new patch 1 to fix the existing printf first.
Jerry Hoemann (2):
selftests: watchdog: Fix error message.
selftests: watchdog: Add gettimeout and get|set pretimeout
tools/testing/selftests/watchdog/watchdog-test.c | 41 +---
1 file changed, 36 insertions(+), 5 deletions(-)
--
1.8.3.1
Printf's say errno but print the string version of error.
Make consistent.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/watchdog/watchdog-test.c
b/tools
On Wed, Sep 26, 2018 at 01:47:25PM -0600, Shuah Khan wrote:
> On 09/26/2018 10:29 AM, Jerry Hoemann wrote:
> > On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
> >> Hi Jerry,
> >>
> >>
> >> The rest looks good to me.
>
> I spoke too s
On Wed, Sep 26, 2018 at 01:47:25PM -0600, Shuah Khan wrote:
> On 09/26/2018 10:29 AM, Jerry Hoemann wrote:
> > On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
> >> Hi Jerry,
> >>
> >>
> >> The rest looks good to me.
>
> I spoke too s
On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
> Hi Jerry,
>
> On 09/24/2018 01:36 PM, Jerry Hoemann wrote:
> > {"disable", no_argument, NULL, 'd'},
> > @@ -27,6 +27,9 @@
> > {"help",
On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
> Hi Jerry,
>
> On 09/24/2018 01:36 PM, Jerry Hoemann wrote:
> > {"disable", no_argument, NULL, 'd'},
> > @@ -27,6 +27,9 @@
> > {"help",
addresses the issues you raised below. Additional comments inline.
On Mon, Sep 24, 2018 at 02:42:33PM -0600, Shuah Khan wrote:
> On 09/23/2018 07:47 PM, Jerry Hoemann wrote:
> > On Fri, Sep 21, 2018 at 05:42:00PM -0600, Shuah Khan wrote:
> >>>
> >>> @@ -135,6 +
addresses the issues you raised below. Additional comments inline.
On Mon, Sep 24, 2018 at 02:42:33PM -0600, Shuah Khan wrote:
> On 09/23/2018 07:47 PM, Jerry Hoemann wrote:
> > On Fri, Sep 21, 2018 at 05:42:00PM -0600, Shuah Khan wrote:
> >>>
> >>> @@ -135,6 +
e permission
on /dev/watchdog allow only root to open it. The reason that we only
allow root to open /dev/watchdog is that it is trivial to crash
the system. Just open /dev/watchdog and don't update the watchdog.
One of my favorite ways to crash the system is to
as root "cat /dev/watchdog."
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
e permission
on /dev/watchdog allow only root to open it. The reason that we only
allow root to open /dev/watchdog is that it is trivial to crash
the system. Just open /dev/watchdog and don't update the watchdog.
One of my favorite ways to crash the system is to
as root "cat /dev/watchdog."
--
-
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/tools/testing
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/tools/testing
ot"
5) Made printf of WDIOC_GETPRETIMEOUT disnct from WDIOC_SETPRETIMEOUT
6) Made WDIOC_GETPRETIMEOUT a "one shot"
Jerry Hoemann (1):
selftests: watchdog: Add gettimeout and get|set pretimeout
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file ch
ot"
5) Made printf of WDIOC_GETPRETIMEOUT disnct from WDIOC_SETPRETIMEOUT
6) Made WDIOC_GETPRETIMEOUT a "one shot"
Jerry Hoemann (1):
selftests: watchdog: Add gettimeout and get|set pretimeout
tools/testing/selftests/watchdog/watchdog-test.c | 33 +++-
1 file ch
On Fri, Sep 21, 2018 at 05:42:00PM -0600, Shuah Khan wrote:
> Hi Jerry,
>
> Thanks for the patch. A few comments below:
Replies inline.
>
> On 09/21/2018 04:55 PM, Jerry Hoemann wrote:
> > Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
&g
On Fri, Sep 21, 2018 at 05:42:00PM -0600, Shuah Khan wrote:
> Hi Jerry,
>
> Thanks for the patch. A few comments below:
Replies inline.
>
> On 09/21/2018 04:55 PM, Jerry Hoemann wrote:
> > Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
&g
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 30 +++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/tools/testing
Add command line arguments to call ioctl WDIOC_GETTIMEOUT,
WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT.
Signed-off-by: Jerry Hoemann
---
tools/testing/selftests/watchdog/watchdog-test.c | 30 +++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/tools/testing
During module install, disable pretimeout if the requested timeout
value is not greater than the minimal pretimeout value that is
supported by hardware.
This makes the module load handling of pretimeout consistent
with the ioctl handling of pretimeout.
Signed-off-by: Jerry Hoemann
---
drivers
During module install, disable pretimeout if the requested timeout
value is not greater than the minimal pretimeout value that is
supported by hardware.
This makes the module load handling of pretimeout consistent
with the ioctl handling of pretimeout.
Signed-off-by: Jerry Hoemann
---
drivers
On Wed, Aug 08, 2018 at 01:13:22PM -0600, Jerry Hoemann wrote:
> Changes for v2
>
> 1) Patch 0001: Simplify initialization of pretimeout removing #ifdef.
> 2) Patch 0002: Loosen check on mynmi to accommodate potential FW issue.
> 3) Patch 0003: Split dev_info into mulitple
On Wed, Aug 08, 2018 at 01:13:22PM -0600, Jerry Hoemann wrote:
> Changes for v2
>
> 1) Patch 0001: Simplify initialization of pretimeout removing #ifdef.
> 2) Patch 0002: Loosen check on mynmi to accommodate potential FW issue.
> 3) Patch 0003: Split dev_info into mulitple
Remove references to deprecated features like NMI sourcing
and obsoleted module parameters.
Add details concerning new module parameter pretimeout and tips
to programming it.
Signed-off-by: Jerry Hoemann
---
Documentation/watchdog/hpwdt.txt | 93 ++--
1 file
Remove references to deprecated features like NMI sourcing
and obsoleted module parameters.
Add details concerning new module parameter pretimeout and tips
to programming it.
Signed-off-by: Jerry Hoemann
---
Documentation/watchdog/hpwdt.txt | 93 ++--
1 file
The hwpdt driver is overloaded for handling both the iLO
watchdog and the explicit "Generate NMI to System" virutal
button. Hence NMI handler needs to claim NMI resulting
from the virutal button.
Claim if iLO generated accommodating firmware that might
set wrong bit.
Signed-off
module parameter is ignored and the value internally will be 0.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 9dc62a4..fae9364 100644
--- a/drivers/watchdog
The hwpdt driver is overloaded for handling both the iLO
watchdog and the explicit "Generate NMI to System" virutal
button. Hence NMI handler needs to claim NMI resulting
from the virutal button.
Claim if iLO generated accommodating firmware that might
set wrong bit.
Signed-off
module parameter is ignored and the value internally will be 0.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 9dc62a4..fae9364 100644
--- a/drivers/watchdog
Bump version number to reflect recent bug fixes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index eb947bc..7af358b 100644
--- a/drivers/watchdog/hpwdt.c
+++ b
Print module parameters when the driver is loaded.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index bb41714..69a88b1 100644
--- a/drivers/watchdog
Print module parameters when the driver is loaded.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index bb41714..69a88b1 100644
--- a/drivers/watchdog
Bump version number to reflect recent bug fixes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index eb947bc..7af358b 100644
--- a/drivers/watchdog/hpwdt.c
+++ b
Add module parameter "timeout" as an alias to "soft_margin."
This aligns hpwdt usage more closely with other WDT while
retaining backwards compatibility.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driver
to diagnose problems.
Jerry
Jerry Hoemann (5):
watchdog: hpwdt: Initialize pretimeout from module parameter.
watchdog: hpwdt: Claim NMI from iLO
watchdog: hpwdt: Display module parameters.
watchdog: hpwdt: Module paramerter alias.
watchdog: hpwdt: Update version number.
drivers
Add module parameter "timeout" as an alias to "soft_margin."
This aligns hpwdt usage more closely with other WDT while
retaining backwards compatibility.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driver
to diagnose problems.
Jerry
Jerry Hoemann (5):
watchdog: hpwdt: Initialize pretimeout from module parameter.
watchdog: hpwdt: Claim NMI from iLO
watchdog: hpwdt: Display module parameters.
watchdog: hpwdt: Module paramerter alias.
watchdog: hpwdt: Update version number.
drivers
On Sat, Aug 04, 2018 at 06:09:05PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > The hwpdt driver is overloaded for handling both the iLO
> > watchdog and the explicit "Generate NMI to System" virutal
> > button.
> >
> >
On Sat, Aug 04, 2018 at 06:09:05PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > The hwpdt driver is overloaded for handling both the iLO
> > watchdog and the explicit "Generate NMI to System" virutal
> > button.
> >
> >
On Sat, Aug 04, 2018 at 06:08:17PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > When the pretimeout is specified as a module parameter, the
> > value should be reflected in hpwdt_dev.pretimeout. The default
> > (on) case is correct.
On Sat, Aug 04, 2018 at 06:08:17PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > When the pretimeout is specified as a module parameter, the
> > value should be reflected in hpwdt_dev.pretimeout. The default
> > (on) case is correct.
On Sat, Aug 04, 2018 at 06:13:20PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > Print module parameters when the driver is loaded.
> >
> > Signed-off-by: Jerry Hoemann
> > ---
> > drivers/watchdog/hpwdt.c | 5 +++--
> &g
On Sat, Aug 04, 2018 at 06:13:20PM -0700, Guenter Roeck wrote:
> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
> > Print module parameters when the driver is loaded.
> >
> > Signed-off-by: Jerry Hoemann
> > ---
> > drivers/watchdog/hpwdt.c | 5 +++--
> &g
: Update version number.
Bump version number to reflect changes.
Jerry Hoemann (4):
watchdog: hpwdt: Initialize pretimeout from module parameter.
watchdog: hpwdt: Claim NMI from iLO
watchdog: hpwdt: Display module parameters.
watchdog: hpwdt: Update version number.
drivers/watchdog
When the pretimeout is specified as a module parameter, the
value should be reflected in hpwdt_dev.pretimeout. The default
(on) case is correct. But, when disabling pretimeout, the value
should be set to zero in hpwdt_dev.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 5 +
1
: Update version number.
Bump version number to reflect changes.
Jerry Hoemann (4):
watchdog: hpwdt: Initialize pretimeout from module parameter.
watchdog: hpwdt: Claim NMI from iLO
watchdog: hpwdt: Display module parameters.
watchdog: hpwdt: Update version number.
drivers/watchdog
When the pretimeout is specified as a module parameter, the
value should be reflected in hpwdt_dev.pretimeout. The default
(on) case is correct. But, when disabling pretimeout, the value
should be set to zero in hpwdt_dev.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 5 +
1
The hwpdt driver is overloaded for handling both the iLO
watchdog and the explicit "Generate NMI to System" virutal
button.
Claim the iLO NMI virtual button even if we are not claiming
the iLO watchdog pretimeout.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 fi
The hwpdt driver is overloaded for handling both the iLO
watchdog and the explicit "Generate NMI to System" virutal
button.
Claim the iLO NMI virtual button even if we are not claiming
the iLO watchdog pretimeout.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 fi
Bump version number to reflect recent bug fixes.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index f098371..27091f3 100644
--- a/drivers/watchdog/hpwdt.c
+++ b
Print module parameters when the driver is loaded.
Signed-off-by: Jerry Hoemann
---
drivers/watchdog/hpwdt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 8a85ddd..f098371 100644
--- a/drivers/watchdog/hpwdt.c
1 - 100 of 534 matches
Mail list logo
