Re: [PATCH v1] Support Elan Touchscreen eKTF product.

2012-10-22 Thread Jian-Jhong Ding
Dmitry Torokhov writes: > On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote: >> With Benjamin's i2c-hid implimentation, is it possible to make >> hid-multitouch not depend on USBHID and reuse it to drive this device? > > Exactly. Before looking any further -

Re: [PATCH v1] Support Elan Touchscreen eKTF product.

2012-10-22 Thread Jian-Jhong Ding
Dmitry Torokhov dmitry.torok...@gmail.com writes: On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote: With Benjamin's i2c-hid implimentation, is it possible to make hid-multitouch not depend on USBHID and reuse it to drive this device? Exactly. Before looking any further

Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation

2012-10-18 Thread Jian-Jhong Ding
Benjamin Tissoires writes: > Hi JJ, > > On Thu, Oct 18, 2012 at 11:07 AM, Jian-Jhong Ding wrote: >> Hi Benjamin, >> >> Some suggestions to make the error messages more "human", and a little >> question on the return value of i2c_hid_fetch_hid_descripto

Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation

2012-10-18 Thread Jian-Jhong Ding
Hi Benjamin, Some suggestions to make the error messages more "human", and a little question on the return value of i2c_hid_fetch_hid_descriptor. Please see below: Benjamin Tissoires writes: > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > new file mode 100644 >

Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation

2012-10-18 Thread Jian-Jhong Ding
Hi Benjamin, Some suggestions to make the error messages more human, and a little question on the return value of i2c_hid_fetch_hid_descriptor. Please see below: Benjamin Tissoires benjamin.tissoi...@gmail.com writes: diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c

Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation

2012-10-18 Thread Jian-Jhong Ding
Benjamin Tissoires benjamin.tissoi...@gmail.com writes: Hi JJ, On Thu, Oct 18, 2012 at 11:07 AM, Jian-Jhong Ding jj_d...@emc.com.tw wrote: Hi Benjamin, Some suggestions to make the error messages more human, and a little question on the return value of i2c_hid_fetch_hid_descriptor. Please

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-02 Thread Jian-Jhong Ding
Hi Benjamin, I have one little question about __i2chid_command(), please see below. "benjamin.tissoires" writes: > From: Benjamin Tissoires > > Microsoft published the protocol specification of HID over i2c: > http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx > > This

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-02 Thread Jian-Jhong Ding
Hi Benjamin, I have one little question about __i2chid_command(), please see below. benjamin.tissoires benjamin.tissoi...@gmail.com writes: From: Benjamin Tissoires benjamin.tissoi...@enac.fr Microsoft published the protocol specification of HID over i2c:

Re: [PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread Jian-Jhong Ding
Hi Scott, 劉嘉駿 writes: > Some of ELAN’s production need to issue set_idle when resume. > > Signed-off-by: Scott Liu You might want to add a From: line at the top of mail body to make your name go along with the SoB line. > --- > drivers/hid/hid-ids.h|3 +++ >

Re: [PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread Jian-Jhong Ding
Hi Scott, 劉嘉駿 scott@emc.com.tw writes: Some of ELAN’s production need to issue set_idle when resume. Signed-off-by: Scott Liu scott@emc.com.tw You might want to add a From: line at the top of mail body to make your name go along with the SoB line. --- drivers/hid/hid-ids.h