Re: [PATCH] ocfs2: Annotate struct ocfs2_slot_info with __counted_by

ray indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ocfs2_slot_info. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Mark Fasheh >

Re: [PATCH v2] fs: ocfs2: Replace strlcpy with sysfs_emit

/KSPP/linux/issues/89 > [3] > https://elixir.bootlin.com/linux/v6.5/source/include/linux/moduleparam.h#L52 > > Signed-off-by: Azeem Shaikh Reviewed-by: Joseph Qi > --- > v2: > * Removes patch [1/2] which replaced module_param_call with module_param_cb. > * Use sysfs_emit

Re: [PATCH] ocfs2/dlm: remove unused function

cf71419b ("ocfs2: dlm: fix recovery hung"), dlm_reset_recovery() no longer has any user. Acked-by: Joseph Qi > --- > fs/ocfs2/dlm/dlmrecovery.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c > i

Re: [PATCH ] ocfs2: Fix a typo

On 3/24/21 3:29 PM, Bhaskar Chowdhury wrote: > > s/cluter/cluster/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Joseph Qi > --- > fs/ocfs2/stackglue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/stackglue.c b/f

Re: [PATCH] ocfs2: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

On 2/24/21 4:27 PM, Yang Li wrote: > Fix the following coccicheck warning: > ./fs/ocfs2/blockcheck.c:232:0-23: WARNING: blockcheck_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: Joseph Qi > --- >

Re: [PATCH] ocfs2: Remove unneeded return variable

NAK. This was discussed before, please refer: https://oss.oracle.com/pipermail/ocfs2-devel/2020-April/014969.html Thanks, Joseph On 2/4/21 11:12 AM, Yang Li wrote: > This patch removes unneeded return variables, using only > '0' instead. > It fixes the following warning detected by coccinelle: >

Re: [PATCH v2] ocfs2: Fix a use after free on error

On 2/2/21 7:32 PM, Dan Carpenter wrote: > The error handling in this function frees "reg" but it is still on the > "o2hb_all_regions" list so it will lead to a use after freew. Joseph Qi > points out that we need to clear the bit in the "o2hb_region_bitmap&q

Re: [PATCH] ocfs2: Simplify the calculation of variables

On 2/2/21 11:10 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./fs/ocfs2/refcounttree.c:981:16-18: WARNING !A || A && B is equivalent > to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Reviewed-by: Joseph Qi >

Re: [PATCH] ocfs2: Fix a use after free on error

On 2/1/21 8:25 PM, Dan Carpenter wrote: > The error handling in this function frees "reg" but it is still on the > "o2hb_all_regions" list so it will lead to a use after free. The fix > for this is to only add it to the list after everything has succeeded. > Seems we have to clear the bitmap

Re: [RFC PATCH 25/34] ocfs/cluster: use bio_new in dm-log-writes

I think you send a wrong subject by mistake. Thanks, Joseph On 1/28/21 3:11 PM, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni > --- > fs/ocfs2/cluster/heartbeat.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/cluster/heartbeat.c

Re: [PATCH v4] ovl: fix dentry leak in ovl_get_redirect

Hi Miklos, Any comments on this patch? Thanks, Joseph On 12/22/20 11:26 AM, Al Viro wrote: > On Tue, Dec 22, 2020 at 11:06:26AM +0800, Liangyan wrote: > >> Cc: >> Fixes: a6c606551141 ("ovl: redirect on rename-dir") >> Signed-off-by: Liangyan >> Rev

Re: [PATCH] ocfs2: Remove redundant conditional before iput

On 12/31/20 12:05 PM, Yi Li wrote: > iput handles NULL pointers gracefully, so there's no need to > check the pointer before the call. > > Signed-off-by: Yi Li Acked-by: Joseph Qi > --- > fs/ocfs2/super.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --

Re: [PATCH v3] ovl: fix dentry leak in ovl_get_redirect

890] FS:  7ffbedffb700() GS:93b92788() > knlGS: > [   49.830725] CS:  0010 DS: ES: CR0: 80050033 > [   49.832359] CR2: 0088 CR3: 0005e3f74006 CR4: > 003606a0 > [   49.834085] DR0: 00000000 DR1: 0

Re: [PATCH v2] ovl: fix dentry leak in ovl_get_redirect

Hi Viro, On 12/21/20 2:26 PM, Al Viro wrote: > On Sun, Dec 20, 2020 at 08:09:27PM +0800, Liangyan wrote: > >> +++ b/fs/overlayfs/dir.c >> @@ -973,6 +973,7 @@ static char *ovl_get_redirect(struct dentry *dentry, >> bool abs_redirect) >> for (d = dget(dentry); !IS_ROOT(d);) { >>

Re: [PATCH] ovl: fix dentry leak in ovl_get_redirect

0fffe R15: > 93b8da3446c0 > [   49.828890] FS:  7ffbedffb700() GS:93b92788() > knlGS: > [   49.830725] CS:  0010 DS: ES: CR0: 80050033 > [   49.832359] CR2: 0088 CR3: 0005e3f74006 CR4: > 003606a

Re: [PATCH] fs: ocfs2 remove unneeded break

On 2020/10/20 01:52, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a goto > > Signed-off-by: Tom Rix Acked-by: Joseph Qi > --- > fs/ocfs2/cluster/tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/

Re: [PATCH] ocfs2: ratelimit the 'max lookup times reached' notice

em may have nested directories, src inode: > 18007, dest inode: 17940. > ... > > Signed-off-by: Mauricio Faria de Oliveira Looks good to me. Reviewed-by: Joseph Qi > --- > fs/ocfs2/namei.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [PATCH] ocfs2: fix potential soft lockup during fstrim

s will avoid the potential soft lockup problem, > and also gives the upper applications more IO opportunities, these > applications are not blocked for too long at writing files. > > Signed-off-by: Gang He It makes sense. Reviewed-by: Joseph Qi > --- > fs/ocfs2/alloc.c | 4 +++- > 1

Re: [PATCH 09/14] ocfs2: cleanup o2hb_region_dev_store

On 2020/9/18 00:57, Christoph Hellwig wrote: > Use blkdev_get_by_dev instead of igrab (aka open coded bdgrab) + > blkdev_get. > > Signed-off-by: Christoph Hellwig Reviewed-by: Joseph Qi > --- > fs/ocfs2/cluster/heartbeat.c | 28 ++-- > 1 file c

Re: [Ocfs2-devel] [PATCH] fs: ocfs2: delete repeated words in comments

On 2020/8/11 10:18, Randy Dunlap wrote: > Drop duplicated words {the, and} in comments. > > Signed-off-by: Randy Dunlap > Cc: Mark Fasheh > Cc: Joel Becker > Cc: Joseph Qi > Cc: Andrew Morton > Cc: ocfs2-de...@oss.oracle.com Acked-by: Joseph Qi > --- >

Re: [PATCH] ocfs2: fix unbalanced locking

3f9ff6 ("ocfs2: avoid inode removal while nfsd is accessing it") Reviewed-by: Joseph Qi > > diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c > index 751bc4dc7466..8e3a369086db 100644 > --- a/fs/ocfs2/dlmglue.c > +++ b/fs/ocfs2/dlmglue.c > @@ -2871,9 +2871,15 @@ int

Re: [Ocfs2-devel] [PATCH] ocfs2: suballoc.h: delete a duplicated word

On 2020/7/20 08:14, Randy Dunlap wrote: > Drop the repeated word "is" in a comment. > > Signed-off-by: Randy Dunlap > Cc: Mark Fasheh > Cc: Joel Becker > Cc: Joseph Qi > Cc: ocfs2-de...@oss.oracle.com Acked-by: Joseph Qi > --- > fs/ocfs2/suba

Re: [PATCH] ocfs2: fix remounting needed after setfacl command

gt; getfacl: Removing leading '/' from absolute path names > file: ocfs2/ivan > owner: root > group: root > user::rw- > group::r-- > mask::r-- > other::r-- > > The latest acl record("u:ivan:rw") cannot be returned via getfacl > command until remounting. > >

Re: [PATCH] ocfs2: Replace HTTP links with HTTPS ones

Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Acked-by: Joseph Qi > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov > ' v5.7..master > (Actually letting a shell for loop submit all this stuf

Re: [PATCH v3] fs: ocfs2: fix spelling mistake and grammar

On 2020/6/8 09:48, Keyur Patel wrote: > ./ocfs2/mmap.c:65: bebongs ==> belonging > > Signed-off-by: Keyur Patel Reviewed-by: Joseph Qi > --- > fs/ocfs2/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/

Re: [PATCH v2] fs: ocfs2: fix spelling mistake and grammar

On 2020/6/8 06:07, Keyur Patel wrote: > ./ocfs2/mmap.c:65: bebongs ==> belongs > This should be updated with your new change. Thanks, Joseph > Signed-off-by: Keyur Patel > --- > fs/ocfs2/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/mmap.c

Re: [PATCH] Fix build failure of OCFS2 when TCP/IP is disabled

depend on > TCP/IP being enabled. > > To fix this, make OCFS2_FS depend on INET=y which already requires NET=y. > > Signed-off-by: Tom Seewald Reviewed-by: Joseph Qi > --- > fs/ocfs2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [PATCH v2] ocfs2: fix panic due to ocfs2_wq is null

0x81/0x460 > ocfs2_shutdown_local_alloc+0x47/0x440 [ocfs2] > ocfs2_dismount_volume+0x84/0x400 [ocfs2] > ocfs2_fill_super+0xa4/0x1270 [ocfs2] > ? ocfs2_initialize_super.isa.211+0xf20/0xf20 [ocfs2] > mount_bdev+0x17f/0x1c0 > mount_fs+0x3a/0x160 > > Signed-off-by: Yi L

Re: [PATCH] ocfs2: fix panic due to ocfs2_wq is null

Cc ocfs2-devel On 19/10/15 19:03, Joseph Qi wrote: > > > On 19/10/15 17:05, Yi Li wrote: >> mount.ocfs2 failed when read ocfs2 filesystem super error. >> the func ocfs2_initialize_super will return before allocate ocfs2_wq. >> ocfs2_dismount_volume will flush t

Re: [PATCH] ocfs2: fix panic due to ocfs2_wq is null

On 19/10/15 17:05, Yi Li wrote: > mount.ocfs2 failed when read ocfs2 filesystem super error. > the func ocfs2_initialize_super will return before allocate ocfs2_wq. > ocfs2_dismount_volume will flush the ocfs2_wq, that triggered the following > panic. > > Oct 15 16:09:27 cnwarekv-205120

Re: (RESEND) [PATCH] ocfs2: Fix error handling in ocfs2_setattr()

On 19/10/10 16:23, Chengguang Xu wrote: > Should set transfer_to[USRQUOTA/GRPQUOTA] to NULL > on error case before jump to do dqput(). > > Signed-off-by: Chengguang Xu Looks good. Reviewed-by: Joseph Qi > --- > fs/ocfs2/file.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH] ocfs2:fix potential Null Ptr Dereference

On 19/10/10 09:07, Yizhuo wrote: > Inside function o2hb_region_blocks_store(), to_o2hb_region() > could return NULL but there's no check before its dereference, > which is potentially unsafe. As I described before, this won't happen IMHO. configfs item is initialized after loading module, so

Re: [refcount] 26d2e0d5df: WARNING:at_lib/refcount.c:#refcount_warn_saturate

On 19/9/12 18:56, Will Deacon wrote: > [Adding the ocfs2 maintainers and mailing list] > > On Mon, Sep 09, 2019 at 09:52:26AM +0800, kernel test robot wrote: >> FYI, we noticed the following commit (built with gcc-7): >> >> commit: 26d2e0d5df5b9aab517d8327743e66fcb38e8136 ("refcount:

Re: [PATCH] ocfs2: fix spelling mistake "ambigous" -> "ambiguous"

On 19/9/12 00:07, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a mlog_bug_on_msg message. Fix it. > > Signed-off-by: Colin Ian King Acked-by: Joseph Qi > --- > fs/ocfs2/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] ocfs2: Fix passing zero to 'PTR_ERR' warning

d-off-by: Ding Xiang Reviewed-by: Joseph Qi > --- > fs/ocfs2/acl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c > index 3e7da39..bb981ec 100644 > --- a/fs/ocfs2/acl.c > +++ b/fs/ocfs2/acl.c > @@ -327,8

Re: [PATCH] ocfs2: Delete unnecessary checks before brelse()

ue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Joseph Qi > --- > fs/ocfs2/dlmglue.c| 7 ++- > fs/ocfs2/extent_map.c | 3 +-- > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/fs/ocfs2/dlm

Re: [PATCH][V2] ocfs2: remove deadcode on variable tmp_oh check

he redundant check and return of 0. > > Also update description in comment, return -EINVAL and not -1. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King Reviewed-by: Joseph Qi > --- > > V2: Fix typo of function name in description. >

Re: [PATCH] ocfs2: remove deadcode on variable tmp_oh check

On 19/8/30 19:16, Colin King wrote: > From: Colin Ian King > > At the end of cfs2_inode_lock_tracker tmp_oh is true because an s/cfs2_inode_lock_tracker/ocfs2_inode_lock_tracker/ BTW, could you please correct the following description of this function as well? "return == -1 if this lock

Re: [PATCH v3] psi: get poll_work to run when calling poll syscall next time

On 19/8/23 06:21, Andrew Morton wrote: > On Wed, 21 Aug 2019 11:26:25 +0800 Joseph Qi > wrote: > >> Only when calling the poll syscall the first time can user >> receive POLLPRI correctly. After that, user always fails to >> acquire the event signal. >

[PATCH v3] psi: get poll_work to run when calling poll syscall next time

ker. The cancel needs to pair with resetting the poll_scheduled flag. Signed-off-by: Jason Xing Reviewed-by: Caspar Zhang Reviewed-by: Suren Baghdasaryan Acked-by: Johannes Weiner Signed-off-by: Joseph Qi --- v3: Change the description as Johannes Weiner suggested. kernel/sched/psi.c

Re: [PATCH][ocfs2-next] ocfs2: ensure ret is set to zero before returning

On 19/8/7 20:42, Colin Ian King wrote: > On 07/08/2019 13:35, Joseph Qi wrote: >> >> >> On 19/8/7 20:19, Colin King wrote: >>> From: Colin Ian King >>> >>> A previous commit introduced a regression where variable ret was >>> ori

Re: [PATCH][ocfs2-next] ocfs2: ensure ret is set to zero before returning

On 19/8/7 20:19, Colin King wrote: > From: Colin Ian King > > A previous commit introduced a regression where variable ret was > originally being set from the return from a call to function > dlm_create_debugfs_subroot and this set was removed. Currently > ret is now uninitialized if no

Re: [PATCH] ocfs: further debugfs cleanups

c: ocfs2-de...@oss.oracle.com > Cc: Joseph Qi > Signed-off-by: Greg Kroah-Hartman Looks good to me. Reviewed-by: Joseph Qi > --- > fs/ocfs2/blockcheck.c| 26 - > fs/ocfs2/cluster/heartbeat.c | 103 +-- > fs/ocfs2/dlm/d

Re: [PATCH 1/3 v2] fs: ocfs2: Fix possible null-pointer dereferences in ocfs2_xa_prepare_entry()

value_len); > loc->xl_entry->xe_name_len = xi->xi_name_len; > > Thus, possible null-pointer dereferences may occur. > > To fix these bugs, if loc-xl_entry is NULL, ocfs2_xa_prepare_entry() > abnormally returns with -EINVAL. > > These bugs are found by a

Re: [PATCH 1/3] fs: ocfs2: Fix possible null-pointer dereferences in ocfs2_xa_prepare_entry()

On 19/7/26 11:36, Jia-Ju Bai wrote: > In ocfs2_xa_prepare_entry(), there is an if statement on line 2136 to > check whether loc->xl_entry is NULL: > if (loc->xl_entry) > > When loc->xl_entry is NULL, it is used on line 2158: > ocfs2_xa_add_entry(loc, name_hash); >

Re: [PATCH 3/3] fs: ocfs2: Fix a possible null-pointer dereference in ocfs2_info_scan_inode_alloc()

STCheck written by us. > > Signed-off-by: Jia-Ju Bai Looks good. Reviewed-by: Joseph Qi > --- > fs/ocfs2/ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c > index d6f7b299eb23..efeea208fdeb 100644

Re: [PATCH 2/3] fs: ocfs2: Fix a possible null-pointer dereference in ocfs2_write_end_nolock()

Check written by us. > > Signed-off-by: Jia-Ju Bai Looks good. Reviewed-by: Joseph Qi > --- > fs/ocfs2/aops.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c > index a4c905d6b575..5473bd99043e 100644

Re: [PATCH] ocfs2: remove set but not used variable 'last_hash'

ed and can be removed. > > Signed-off-by: YueHaibing Acked-by: Joseph Qi > --- > fs/ocfs2/xattr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c > index 385f3aa..90c830e3 100644 > --- a/fs/ocfs2/xattr.c > +++ b/

Re: [PATCH] fs: ocfs2: dlmglue: Unneeded variable: "status"

allback of kthread_create. > > Signed-off-by: Hariprasad Kelam Reviewed-by: Joseph Qi > --- > fs/ocfs2/dlmglue.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c > index dc987f5..1420723 100644 >

Re: [PATCH v2 31/35] ocfs2: Use kmemdup rather than duplicating its implementation

ode and also reduce the chances of mistakes. > Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy. > > Signed-off-by: Fuqian Huang Looks good. Reviewed-by: Joseph Qi > --- > Changes in v2: > - Fix a typo in commit message (memset -> memcpy) > > f

Re: [PATCH V4 3/3] ocfs2: add first lock wait time in locking_state

On 19/6/12 15:29, Gang He wrote: > Hello Joseph, > >>>> On 6/12/2019 at 3:03 pm, in message > , Joseph Qi > wrote: >> Hi Gang, >> >> On 19/6/11 09:54, Gang He wrote: >>> ocfs2 file system uses locking_state file under debugfs to d

Re: [PATCH V4 3/3] ocfs2: add first lock wait time in locking_state

Hi Gang, On 19/6/11 09:54, Gang He wrote: > ocfs2 file system uses locking_state file under debugfs to dump > each ocfs2 file system's dlm lock resources, but the users ever > encountered some hang(deadlock) problems in ocfs2 file system. > I'd like to add first lock wait time in locking_state

Re: [bug report][stable] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)

in stable 4.19.49. Thanks, Joseph On 19/6/9 22:50, Greg KH wrote: > On Sun, Jun 09, 2019 at 09:10:45PM +0800, Joseph Qi wrote: >> Hi Nadav, >> Thanks for the comments. >> I'll test the 3 patches in the mentioned thread. > > This should all be fixed in the latest

Re: [bug report][stable] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)

Hi Nadav, Thanks for the comments. I'll test the 3 patches in the mentioned thread. Thanks, Joseph On 19/6/8 00:38, Nadav Amit wrote: >> On Jun 7, 2019, at 3:24 AM, Joseph Qi wrote: >> >> Hi all, >> Any idea on this regression? > > Sorry for the late respon

Re: [bug report][stable] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)

Hi all, Any idea on this regression? Thanks, Joseph On 19/6/5 18:23, Joseph Qi wrote: > Hi, > > I have encountered a kernel BUG when running ltp ftrace-stress-test > on 4.19.48. > > [ 209.704855] LTP: starting ftrace-stress-test (ftrace_stress_test.sh 90) > [

Re: [PATCH] ocfs2/dlm: use struct_size() helper

; > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Joseph Qi > --- > fs/ocfs2/dlm/dlmrecovery.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocf

[bug report][stable] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)

Hi, I have encountered a kernel BUG when running ltp ftrace-stress-test on 4.19.48. [ 209.704855] LTP: starting ftrace-stress-test (ftrace_stress_test.sh 90) [ 209.739412] Scheduler tracepoints stat_sleep, stat_iowait, stat_blocked and stat_runtime require the kernel parameter

Re: [PATCH] ocfs2: Fix error path kobject memory leak

the release method is called if kobject_init_and_add() fails. > > Signed-off-by: Tobin C. Harding Reviewed-by: Joseph Qi > --- > > Is it ok to send patches during the merge window? > > Applies on top of Linus' mainline tag: v5.1 > > Happy to rebase if there are co

Re: [bug report][stable] perf probe: failed to add events

Hi Adrian, On 19/2/28 15:19, Adrian Hunter wrote: > On 28/02/19 4:07 AM, Joseph Qi wrote: >> Hi Adrian, >> >> On 19/2/27 20:39, Adrian Hunter wrote: >>> Seems to be fixed by this: >>> >>> From: Adrian Hunter >>> Date: Wed, 27 Feb 2019 05

Re: [bug report][stable] perf probe: failed to add events

ood commit again (v4.19 ~ v4.20): bf904d2762ee x86/pti/64: Remove the SYSCALL64 entry trampoline backported this commit as well as the related commit 98f05b5138f0 on v4.19.24, it works. And I've tested your fix on v4.19.24, it also works. Tested-by: Joseph Qi

Re: [bug report][stable] perf probe: failed to add events

On 19/2/26 21:08, Greg KH wrote: > On Tue, Feb 26, 2019 at 08:32:34PM +0800, Joseph Qi wrote: >> >> >> On 19/2/26 17:05, Greg KH wrote: >>> On Tue, Feb 26, 2019 at 03:31:14PM +0800, Joseph Qi wrote: >>>> Hi, >>>> >>>> I'

Re: [bug report][stable] perf probe: failed to add events

On 19/2/26 17:05, Greg KH wrote: > On Tue, Feb 26, 2019 at 03:31:14PM +0800, Joseph Qi wrote: >> Hi, >> >> I'm using kernel v4.19.24 and have found that there is an issue when >> using perf probe to define a new dynamic tracepoint. >> >> $ perf probe -a h

[bug report][stable] perf probe: failed to add events

Hi, I'm using kernel v4.19.24 and have found that there is an issue when using perf probe to define a new dynamic tracepoint. $ perf probe -a handle_mm_fault Failed to write event: Numerical result out of range Error: Failed to add events. I've also tried kernel v4.20, and it can pass. So

Re: testing io.low limit for blk-throttle

Hi Paolo, On 18/4/27 01:27, Paolo Valente wrote: > > >> Il giorno 25 apr 2018, alle ore 14:13, Joseph Qi <jiangqi...@gmail.com> ha >> scritto: >> >> Hi Paolo, >> > > Hi Joseph > >> ... >> Could you run blktrace as well whe

Re: testing io.low limit for blk-throttle

Hi Paolo, On 18/4/27 01:27, Paolo Valente wrote: > > >> Il giorno 25 apr 2018, alle ore 14:13, Joseph Qi ha >> scritto: >> >> Hi Paolo, >> > > Hi Joseph > >> ... >> Could you run blktrace as well when testing your case? There are seve

Re: testing io.low limit for blk-throttle

Hi Jianchao, On 18/4/27 10:09, jianchao.wang wrote: > Hi Tejun and Joseph > > On 04/27/2018 02:32 AM, Tejun Heo wrote: >> Hello, >> >> On Tue, Apr 24, 2018 at 02:12:51PM +0200, Paolo Valente wrote: >>> +Tejun (I guess he might be interested in the results below) >> >> Our experiments didn't work

Re: testing io.low limit for blk-throttle

Hi Jianchao, On 18/4/27 10:09, jianchao.wang wrote: > Hi Tejun and Joseph > > On 04/27/2018 02:32 AM, Tejun Heo wrote: >> Hello, >> >> On Tue, Apr 24, 2018 at 02:12:51PM +0200, Paolo Valente wrote: >>> +Tejun (I guess he might be interested in the results below) >> >> Our experiments didn't work

Re: testing io.low limit for blk-throttle

Hi Paolo, On 18/4/24 20:12, Paolo Valente wrote: > > >> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi <jiangqi...@gmail.com> ha >> scritto: >> >> >> >> On 18/4/23 15:35, Paolo Valente wrote: >>> >>> >>>&

Re: testing io.low limit for blk-throttle

Hi Paolo, On 18/4/24 20:12, Paolo Valente wrote: > > >> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi ha >> scritto: >> >> >> >> On 18/4/23 15:35, Paolo Valente wrote: >>> >>> >>>> Il giorno 23 apr 2018, alle ore 0

Re: [Ocfs2-devel] [PATCH v2] ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE

linux-4.4.21-69.tar.gz -o > ~/ocfs2mullog -C hacluster -s pcmk -n tb-node2,tb-node1,tb-node3 -d > /dev/sda1 -b 4096 -c 32768 -t multi_mmap /mnt/shared > Tests with "-b 4096 -C 32768" > Thu Dec 28 15:04:12 CST 2017 > multi_mmap...

Re: [Ocfs2-devel] [PATCH v2] ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE

linux-4.4.21-69.tar.gz -o > ~/ocfs2mullog -C hacluster -s pcmk -n tb-node2,tb-node1,tb-node3 -d > /dev/sda1 -b 4096 -c 32768 -t multi_mmap /mnt/shared > Tests with "-b 4096 -C 32768" > Thu Dec 28 15:04:12 CST 2017 > multi_mmap...

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 16:54, Gang He wrote: > Hi Joseph, > > > >> >> On 17/11/28 15:24, Gang He wrote: >>> Hello Joseph, >>> >>> >> >>> On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 16:54, Gang He wrote: > Hi Joseph, > > > >> >> On 17/11/28 15:24, Gang He wrote: >>> Hello Joseph, >>> >>> >> >>> On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 15:24, Gang He wrote: > Hello Joseph, > > > >> >> On 17/11/28 11:35, Gang He wrote: >>> Hello Joseph, >>> >>> >> Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 15:24, Gang He wrote: > Hello Joseph, > > > >> >> On 17/11/28 11:35, Gang He wrote: >>> Hello Joseph, >>> >>> >> Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks,

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

On 17/11/28 11:35, Gang He wrote: > Hello Joseph, > > >> Hi Gang, >> >> On 17/11/27 17:46, Gang He wrote: >>> Add ocfs2_overwrite_io function, which is used to judge if >>> overwrite allocated blocks, otherwise, the write will bring extra >>> block allocation overhead. >>> >>>

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

Re: [Ocfs2-devel] [PATCH 2/3] ocfs2: add ocfs2_overwrite_io function

Hi Gang, On 17/11/27 17:46, Gang He wrote: > Add ocfs2_overwrite_io function, which is used to judge if > overwrite allocated blocks, otherwise, the write will bring extra > block allocation overhead. > > Signed-off-by: Gang He > --- > fs/ocfs2/extent_map.c | 67 >

Re: [PATCH V6 00/18] blk-throttle: add .low limit

Hi Shaohua, On 17/9/6 05:02, Shaohua Li wrote: > On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: >> >>> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: >>> >>> Hi, >>> >>> cgroup still lacks a good iocontroller. CFQ works well for hard disk, but >>> not

Re: [PATCH V6 00/18] blk-throttle: add .low limit

Hi Shaohua, On 17/9/6 05:02, Shaohua Li wrote: > On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: >> >>> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: >>> >>> Hi, >>> >>> cgroup still lacks a good iocontroller. CFQ works well for hard disk, but >>> not >>> much for

Re: [Ocfs2-devel] [PATCH] ocfs2: free 'dummy_sc' in sc_fop_release() in case of memory leak

On 17/6/25 20:46, piaojun wrote: > 'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end > of sc_fop_release(). > > Signed-off-by: Jun Piao <piao...@huawei.com> Looks good. Reviewed-by: Joseph Qi <jiangqi...@gmail.com> Thanks, Joseph > --- >

Re: [Ocfs2-devel] [PATCH] ocfs2: free 'dummy_sc' in sc_fop_release() in case of memory leak

On 17/6/25 20:46, piaojun wrote: > 'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end > of sc_fop_release(). > > Signed-off-by: Jun Piao Looks good. Reviewed-by: Joseph Qi Thanks, Joseph > --- > fs/ocfs2/cluster/netdebug.c | 1 + > 1 f

Re: [PATCH v2] ocfs2: fix deadlock caused by recursive locking in xattr

Looks good. Reviewed-by: Joseph Qi <jiangqi...@gmail.com> Thanks, Joseph On 17/6/22 09:47, Eric Ren wrote: > Another deadlock path caused by recursive locking is reported. > This kind of issue was introduced since commit 743b5f1434f5 ("ocfs2: > take inode lock in ocfs2_iop_

Re: [PATCH v2] ocfs2: fix deadlock caused by recursive locking in xattr

Looks good. Reviewed-by: Joseph Qi Thanks, Joseph On 17/6/22 09:47, Eric Ren wrote: > Another deadlock path caused by recursive locking is reported. > This kind of issue was introduced since commit 743b5f1434f5 ("ocfs2: > take inode lock in ocfs2_iop_set/get_acl()"). Two de

Re: [Ocfs2-devel] [PATCH] ocfs2: get rid of ocfs2_is_o2cb_active function

tive() function is not total safe, > base on the design of stackglue, we need to get ocfs2_stack_lock lock > before using ocfs2_stack related data structures, and that > active_stack pointer can be NULL in case mount failure. > > Signed-off-by: Gang He <g...@suse.com> Reviewed

Re: [Ocfs2-devel] [PATCH] ocfs2: get rid of ocfs2_is_o2cb_active function

tive() function is not total safe, > base on the design of stackglue, we need to get ocfs2_stack_lock lock > before using ocfs2_stack related data structures, and that > active_stack pointer can be NULL in case mount failure. > > Signed-off-by: Gang He Reviewed-by: Joseph Qi Th

Re: [Ocfs2-devel] [PATCH] ocfs2: fix a static checker warning

On 17/5/22 12:54, Gang He wrote: > This patch will fix a static checker warning, this warning was > caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after > apply this patch, the error return value will not be NULL(zero). > > Signed-off-by: Gang He <g...@suse.com>

Re: [Ocfs2-devel] [PATCH] ocfs2: fix a static checker warning

On 17/5/22 12:54, Gang He wrote: > This patch will fix a static checker warning, this warning was > caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after > apply this patch, the error return value will not be NULL(zero). > > Signed-off-by: Gang He Reviewed-by: Jos

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

Hi Gang, As you described, only fsdlm will return this error and fsdlm has already print the same message. So why should we add it outside again? Thanks, Joseph On 17/5/18 18:43, Gang He wrote: > Hi Joseph, > > >> Hi Gang, >> >> How can we confirm EBADR is only because cluster name

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

Hi Gang, As you described, only fsdlm will return this error and fsdlm has already print the same message. So why should we add it outside again? Thanks, Joseph On 17/5/18 18:43, Gang He wrote: > Hi Joseph, > > >> Hi Gang, >> >> How can we confirm EBADR is only because cluster name

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

Hi Gang, How can we confirm EBADR is only because cluster name mismatch? Since the cluster stack may be o2cb(o2dlm) or user(fsdlm). Thanks, Joseph On 17/5/18 14:35, Gang He wrote: > This patch is used to add an obvious error message, due to > dismatch cluster names between on-disk and in the

Re: [Ocfs2-devel] [PATCH] ocfs2: give an obvious tip for dismatch cluster names

Hi Gang, How can we confirm EBADR is only because cluster name mismatch? Since the cluster stack may be o2cb(o2dlm) or user(fsdlm). Thanks, Joseph On 17/5/18 14:35, Gang He wrote: > This patch is used to add an obvious error message, due to > dismatch cluster names between on-disk and in the

Re: [PATCH v3 1/2] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

On 17/1/17 15:55, Eric Ren wrote: Hi! On 01/17/2017 03:39 PM, Joseph Qi wrote: On 17/1/17 14:30, Eric Ren wrote: We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid

Re: [PATCH v3 1/2] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

On 17/1/17 15:55, Eric Ren wrote: Hi! On 01/17/2017 03:39 PM, Joseph Qi wrote: On 17/1/17 14:30, Eric Ren wrote: We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid

Re: [PATCH v3 2/2] ocfs2: fix deadlock issue when taking inode lock at vfs entry points

ocfs2_is_locked_by_me() just return true/false to indicate if the process gets the cluster lock - suggested by: Joseph Qi <jiangqi...@gmail.com> and Junxiao Bi <junxiao...@oracle.com>. - Change "struct ocfs2_holder" to a more meaningful name "ocfs2_lock_holder",

Re: [PATCH v3 2/2] ocfs2: fix deadlock issue when taking inode lock at vfs entry points

ocfs2_is_locked_by_me() just return true/false to indicate if the process gets the cluster lock - suggested by: Joseph Qi and Junxiao Bi . - Change "struct ocfs2_holder" to a more meaningful name "ocfs2_lock_holder", suggested by: Junxiao Bi. - Add debugging output at ocfs2_seta

Re: [PATCH v3 1/2] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

r as I can see, including permission check, (get|set)_(acl|attr), and the gfs2 code also do so. Changes since v1: - Let ocfs2_is_locked_by_me() just return true/false to indicate if the process gets the cluster lock - suggested by: Joseph Qi <jiangqi...@gmail.com> and Junxiao Bi <junxia

Re: [PATCH v3 1/2] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

r as I can see, including permission check, (get|set)_(acl|attr), and the gfs2 code also do so. Changes since v1: - Let ocfs2_is_locked_by_me() just return true/false to indicate if the process gets the cluster lock - suggested by: Joseph Qi and Junxiao Bi . - Change "struct ocfs2_holder

Re: [Ocfs2-devel] [PATCH v3] ocfs2/journal: fix umount hang after flushing journal failure

On 17/1/13 20:37, Eric Ren wrote: On 01/13/2017 10:52 AM, Changwei Ge wrote: Hi Joseph, Do you think my last version of patch to fix umount hang after journal flushing failure is OK? If so, I 'd like to ask Andrew's help to merge this patch into his test tree. Thanks, Br. Changwei The

  1   2   >