Re: [PATCH V4 XRT Alveo 09/20] fpga: xrt: management physical function driver (root)

2021-04-09 Thread Max Zhen
drivers is completely dtb driven. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/mgmt/root.c | 333 +++ 1 file changed, 333 insertions(+) create mode 100644 drivers/fpga/xrt/mgmt/root.c diff --git a/drivers/fpga/xrt

Re: [PATCH V4 XRT Alveo 08/20] fpga: xrt: platform driver infrastructure

2021-04-08 Thread Max Zhen
t collect and send us the msg/output). On 3/23/21 10:29 PM, Lizhi Hou wrote: Infrastructure code providing APIs for managing leaf driver instance groups, facilitating inter-leaf driver calls and root calls. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- driver

Re: [PATCH V4 XRT Alveo 05/20] fpga: xrt: group platform driver

2021-04-06 Thread Max Zhen
Hi Tom, On 3/30/21 5:52 AM, Tom Rix wrote: On 3/23/21 10:29 PM, Lizhi Hou wrote: group driver that manages life cycle of a bunch of leaf driver instances and bridges them with root. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/include

Re: [PATCH V4 XRT Alveo 04/20] fpga: xrt: xrt-lib platform driver manager

2021-04-06 Thread Max Zhen
of patches is that global defines should be introduced before the user. On 3/23/21 10:29 PM, Lizhi Hou wrote: xrt-lib kernel module infrastructure code to register and manage all leaf driver modules. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers

Re: [PATCH V4 XRT Alveo 06/20] fpga: xrt: char dev node helper functions

2021-04-06 Thread Max Zhen
having one huge patch for review. On 3/23/21 10:29 PM, Lizhi Hou wrote: Helper functions for char device node creation / removal for platform drivers. This is part of platform driver infrastructure. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers

Re: [PATCH V4 XRT Alveo 07/20] fpga: xrt: root driver infrastructure

2021-04-05 Thread Max Zhen
drivers and handles root calls from platform drivers. This is part of root driver infrastructure. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/include/events.h | 45 +++ drivers/fpga/xrt/include/xroot.h | 117 ++ drivers/fpga/xrt

Re: [PATCH V3 XRT Alveo 07/18] fpga: xrt: management physical function driver (root)

2021-03-17 Thread Max Zhen
On 3/17/21 2:08 PM, Tom Rix wrote: On 3/16/21 1:29 PM, Max Zhen wrote: Hi Tom, On 2/26/21 7:01 AM, Tom Rix wrote: A question i do not know the answer to. Seems like 'golden' is linked to a manufacturing (diagnostics?) image. If the public will never see it, should handling it here

Re: [PATCH V3 XRT Alveo 07/18] fpga: xrt: management physical function driver (root)

2021-03-16 Thread Max Zhen
? Data driven means not hard-coded. Here data means meta data which is presented in device tree format, dtb. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/include/xroot.h | 114 +++ drivers/fpga/xrt/mgmt/root.c | 342

Re: [PATCH V3 XRT Alveo 06/18] fpga: xrt: platform driver infrastructure

2021-03-08 Thread Max Zhen
for managing leaf driver instance groups, facilitating inter-leaf driver calls and root calls, managing leaf driver device nodes. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/include/events.h| 48 ++ drivers/fpga/xrt/include/subdev_id.h

Re: [PATCH V3 XRT Alveo 04/18] fpga: xrt: xrt-lib platform driver manager

2021-03-03 Thread Max Zhen
to register and manage all leaf driver modules. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/lib/main.c | 274 drivers/fpga/xrt/lib/main.h | 17 +++ 2 files changed, 291 insertions(+) create mode

Re: [PATCH V3 XRT Alveo 04/18] fpga: xrt: xrt-lib platform driver manager

2021-03-01 Thread Max Zhen
wrote: xrt-lib kernel module infrastructure code to register and manage all leaf driver modules. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/lib/main.c | 274 drivers/fpga/xrt/lib/main.h | 17 +++ 2

Re: [PATCH V3 XRT Alveo 05/18] fpga: xrt: group platform driver

2021-02-26 Thread Max Zhen
cycle of a bunch of leaf driver instances and bridges them with root. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- drivers/fpga/xrt/include/group.h | 27 drivers/fpga/xrt/lib/group.c | 265 +++ 2 files changed, 292

Re: [PATCH Xilinx Alveo 7/8] fpga: xrt: Alveo management physical function driver

2020-12-03 Thread Max Zhen
Hi Yilun, On 12/1/20 7:00 PM, Xu Yilun wrote: +static int xmgmt_main_event_cb(struct platform_device *pdev, + enum xrt_events evt, void *arg) +{ + struct xmgmt_main *xmm = platform_get_drvdata(pdev); + struct xrt_event_arg_subdev *esd = (struct xrt_event_arg_subdev *)arg; +

RE: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-03 Thread Max Zhen
Hi Moritz, I manually fixed some line breaks. Not sure why outlook is not doing it properly. Let me know if it still looks bad to you. Please see my reply below. > > > Max, > > On Thu, Dec 03, 2020 at 03:38:26AM +, Max Zhen wrote: > > [...cut...] > > > &

RE: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-02 Thread Max Zhen
Hi Moritz, Please see my reply below. Thanks, -Max > -Original Message- > From: Moritz Fischer > Sent: Wednesday, December 2, 2020 15:10 > To: Max Zhen > Cc: Moritz Fischer ; Sonal Santan ; > linux-kernel@vger.kernel.org; linux-f...@vger.kernel.org; Lizhi Hou

RE: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-12-02 Thread Max Zhen
Hi Moritz, Thanks for your feedback. Please see my reply inline. Thanks, -Max > -Original Message- > From: Moritz Fischer > Sent: Monday, November 30, 2020 20:55 > To: Sonal Santan > Cc: linux-kernel@vger.kernel.org; linux-f...@vger.kernel.org; Max Zhen > ; Lizhi