[PATCH] staging: rtl8192e: remove unnecesasry f-trace like logging

Fixed Check: Remove unnecessary f-trace like logging by simply deleting that statement as we have other modes of logging like ftrace. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

[PATCH] staging: rtl8192e: replace comparison to NULL by bool

Fixed Comparison to NULL can be written as '!...' by replacing it with simpler form i.e boolean expression. This makes code more readable alternative. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++--- 1 file changed, 3 insertions

Re: [Outreachy kernel] [PATCH v2 2/2] staging: media: zoran: remove and add comments; align code

On Fri, Apr 09, 2021 at 10:12:12PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Removed comments from the same line and added them to new line above the > > blocks, aligned everything properly by using tabs to make code neater >

Re: [Outreachy kernel] [PATCH v2 1/2] media: zoran: add spaces around '<<'

On Fri, Apr 09, 2021 at 10:40:25PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > No changes required in this patch. > > In v1:- Added spaces around '<<' operator to improve readability and meet > > linux kernel coding &g

[PATCH v2 2/2] staging: media: zoran: remove and add comments; align code

Removed comments from the same line and added them to new line above the blocks, aligned everything properly by using tabs to make code neater and improve readability. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36057.h | 293 ++ 1 file changed, 162

[PATCH v2 1/2] media: zoran: add spaces around '<<'

No changes required in this patch. In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding style Signed-off-by: Mitali Borkar --- Changes from v1:- No changes required in this patch. Below is the git diff of v1. drivers/staging/media/zoran/zr3

[PATCH v2 0/2] staging: media: zoran: aligned the code and block comment changes

This patch fixes the cleanup style issues. Changes from v1:- In [PATCH v2 1/2]:- No changes made/required. In [PATCH v2 2/2]:- Aligned the code using tabs and spaces and readjusted comment line. Mitali Borkar (2): media: zoran: add spaces around '<<' staging: media: zoran: remove a

Re: [PATCH 1/2] media: zoran: add spaces around '<<'

On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote: > Hi Mitali, > > On 08/04/2021 22:38, Mitali Borkar wrote: > > Added spaces around '<<' operator to improve readability and meet linux > > kernel coding style. > > Reported by checkpatch >

Re: [PATCH 1/2] media: zoran: add spaces around '<<'

On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote: > Hi Mitali, > > On 08/04/2021 22:38, Mitali Borkar wrote: > > Added spaces around '<<' operator to improve readability and meet linux > > kernel coding style. > > Reported by checkpatch >

[PATCH v3] staging: media: zoran: remove and move statement in next line with '*'

Removed and moved statement in line in long(multi-line) comments and added '*' before it to meet linux kernel coding style for long (multi-line) comments Signed-off-by: Mitali Borkar --- Changes from v2:- made style changes in code according to linux kernel coding style for long comments

[PATCH v2] staging: media: zoran: moved statement to next line with '*'

Moved the statement to next line and added '*' before it to meet linux kernel coding style for long(multi-line) comments. Signed-off-by: Mitali Borkar --- Changes from v1:- made style changes according to linux kernel coding style for long comments. drivers/staging/media/zoran/zr36060.c | 3

[PATCH v2] staging: media: zoran: remove and add '*' in long(multi-line) comments

Added '*' before every line inside long(multi-line) comments. Removed '*/' from end of the comment line and added to next line as per linux kernel coding style. Aligned '*' accordingly to make code neater. Signed-off-by: Mitali Borkar --- Changes from v1:- Changes made in code according

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

On Fri, Apr 09, 2021 at 12:10:06AM +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > >

[PATCH] staging: media: zoran: add '*' in subsequent line

Added '*' in susbsequent lines for block comments to meet linux kernel coding style. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36050.c | 34 +-- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/zoran/zr36050.c b

[PATCH] staging: media: meson: vdec: matched alignment with parenthesis

Matched alignment with open parenthesis to meet linux kernel coding style. Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c

Re: [Outreachy kernel] [PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > Added #include and replaced bit shifts by BIT() macro. > > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* > > bitmas

Re: [Outreachy kernel] [PATCH 1/2] media: zoran: add spaces around '<<'

On Thu, Apr 08, 2021 at 11:16:41PM +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, Mitali Borkar wrote: > > > Added spaces around '<<' operator to improve readability and meet linux > > kernel coding style. > > Reported by checkpatch

[PATCH] staging: media: zoran: reduce length of a line

Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36060.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] media: zoran: replace bit shifts by BIT() macro

Added #include and replaced bit shifts by BIT() macro. This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_* bitmasks. Use of macro is better and neater. It maintains consistency. Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36057.h

[PATCH 1/2] media: zoran: add spaces around '<<'

Added spaces around '<<' operator to improve readability and meet linux kernel coding style. Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/media/zoran/zr36057.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH 0/2] media: zoran: clean up style issues

These patches make changes to clean up style issues as identified by checkpatch Mitali Borkar (2): media: zoran: add spaces around '<<' media: zoran: replace bit shifts by BIT() macro drivers/staging/media/zoran/zr36057.h | 16 +--- 1 file changed, 9 insertions(+), 7 del

[PATCH v2] staging: rtl8712: add spaces around '+'

Added spaces around '+' to improve readability and adhere to linux kernel coding style. Reported by checkpatch Signed-off-by: Mitali Borkar --- Changes from v1: No changes in the code, but only to subject description and patch body. Changed the subject decription according to PatchPhilosophy

Re: [Outreachy kernel] [PATCH] staging: rtl8712: added spaces around '+'

On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote: > The subject line should be in the imperative, so "add" instead of "added". > Ok Ma'am > On Thu, 8 Apr 2021, Mitali Borkar wrote: > > > Clean up Check:spaces preferred around that '+' (ctx:VxV)

[PATCH] staging: rtl8712: added spaces around '+'

Clean up Check:spaces preferred around that '+' (ctx:VxV) Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/rtl8712/wlan_bssdef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712

[PATCH] staging: rtl8712: removed unnecessary blank line

Cleanup patch for CHECK: blank lines aren't necessary after an open brace '{' Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/rtl8712/usb_intf.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers

[PATCH] staging: rtl8712: matched alignment with open parenthesis

Aligned arguments with open parenthesis to meet linux kernel coding style Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/rtl8712/usb_ops.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops.h b/drivers/staging

[PATCH] staging: rtl8712: removed extra blank line

Removed an extra blank line so that only one blank line is present in between two functions which separates them out. Reported by checkpatch Signed-off-by: Mitali Borkar --- drivers/staging/rtl8712/rtl8712_wmac_regdef.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712

[PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h

Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter Reported by checkpatch. Signed-off-by: Mitali Borkar --- drivers/staging/rtl8712/xmit_osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/xmit_osdep.h b/drivers/staging/rtl8712

[PATCH] staging: qlge: remove else after break

linux-staging@lists,linux-kernel@vger.kernel.org Bcc: Subject: [PATCH] staging: qlge:remove else after break Reply-To: Fixed Warning:- else is not needed after break break terminates the loop if encountered. else is unnecessary and increases indenatation Signed-off-by: Mitali Borkar

[no subject]

outreachy-ker...@googlegroups.com, mitaliborkar...@gmail.com Bcc: Subject: [PATCH] staging: qlge:remove else after break Reply-To: Fixed Warning:- else is not needed after break break terminates the loop if encountered. else is unnecessary and increases indenatation Signed-off-by: Mitali

<    1   2