Re: [PATCH] fs: btrfs: Remove repeated struct declaration

; > Signed-off-by: Wan Jiabing Reviewed-by: Nikolay Borisov

Re: [PATCH] btrfs: Use immediate assignment when referencing cc-option

On 17.03.21 г. 0:46 ч., Victor Erminpour wrote: > Calling cc-option will use KBUILD_CFLAGS, which when lazy setting > subdir-ccflags-y produces the following build error: > > scripts/Makefile.lib:10: *** Recursive variable `KBUILD_CFLAGS' \ > references itself (eventually). Stop. > >

Re: [btrfs] 5297199a8b: xfstests.btrfs.220.fail

On 9.03.21 г. 10:49 ч., kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 5297199a8bca12b8b96afcbf2341605efb6005de ("btrfs: remove inode number > cache feature") >

[tip: locking/core] locking/rwsem: Remove empty rwsem.h

The following commit has been merged into the locking/core branch of tip: Commit-ID: 442187f3c2de40bab13b8f9751b37925bede73b0 Gitweb: https://git.kernel.org/tip/442187f3c2de40bab13b8f9751b37925bede73b0 Author:Nikolay Borisov AuthorDate:Tue, 26 Jan 2021 12:17:21 +02:00

Re: [PATCH] x86: Disable CET instrumentation in the kernel

On 29.01.21 г. 18:49 ч., Josh Poimboeuf wrote: > Agreed, stable is a good idea. I think Nikolay saw it with GCC 9. Yes I did, with the default Ubuntu compiler as well as the default gcc-10 compiler: # gcc -v -Q -O2 --help=target | grep protection gcc version 9.3.0 (Ubuntu

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

On 29.01.21 г. 3:34 ч., Alexei Starovoitov wrote: > On Thu, Jan 28, 2021 at 07:24:14PM +0100, Peter Zijlstra wrote: >> On Thu, Jan 28, 2021 at 06:45:56PM +0200, Nikolay Borisov wrote: >>> it would be placed on the __fentry__ (and not endbr64) hence it works. >>> So p

Re: [PATCH] x86: Disable CET instrumentation in the kernel

, for functions which can be called indirectly. > > CET instrumentation isn't currently necessary in the kernel, as CET is > only supported in user space. Disable it unconditionally. > > Reported-by: Nikolay Borisov > Signed-off-by: Josh Poimboeuf Tested-by: Nikolay Borisov Reviewed-by: Nikolay Borisov

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

On 28.01.21 г. 18:12 ч., Nikolay Borisov wrote: > > > On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote: >> Hi, > > > >> >> Alexei, could you tell me what is the concerning situation for bpf? > > Another data point masami is that this affect

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote: > Hi, > > Alexei, could you tell me what is the concerning situation for bpf? Another data point masami is that this affects bpf kprobes which are entered via int3, alternatively if the kprobe is entered via kprobe_ftrace_handler it works as

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote: > Hi, > > > Yeah, there is. Nikolay, could you try this tentative patch? I can confirm that with this patch everything is working. I also applied the following diff: diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

On 27.01.21 г. 17:24 ч., Masami Hiramatsu wrote: > On Thu, 28 Jan 2021 00:13:53 +0900 > Masami Hiramatsu wrote: > >> Hi Nikolay, >> >> On Wed, 27 Jan 2021 15:43:29 +0200 >> Nikolay Borisov wrote: >> >>> Hello, >>> >>> I'm

Re: [PATCH v2] btrfs: Avoid calling btrfs_get_chunk_map() twice

On 27.01.21 г. 15:57 ч., Michal Rostecki wrote: > From: Michal Rostecki > > Before this change, the btrfs_get_io_geometry() function was calling > btrfs_get_chunk_map() to get the extent mapping, necessary for > calculating the I/O geometry. It was using that extent mapping only > internally

kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

Hello, I'm currently seeing latest Linus' master being somewhat broken w.r.t krpobes. In particular I have the following test-case: #!/bin/bash mkfs.btrfs -f /dev/vdc &> /dev/null mount /dev/vdc /media/scratch/ bpftrace -e 'kprobe:btrfs_sync_file {printf("kprobe: %s\n", kstack());}'

[PATCH v2] locking/rwsem: Remove empty rwsem.h

This is a leftover from 7f26482a872c ("locking/percpu-rwsem: Remove the embedded rwsem") Signed-off-by: Nikolay Borisov --- V2: * Add reference to commit which made the file useless. kernel/locking/rwsem.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100

Re: [RFC PATCH 04/37] btrfs: use bio_init_fields in volumes

On 19.01.21 г. 7:05 ч., Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni > --- > fs/btrfs/volumes.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index ee086fc56c30..836167212252 100644 > ---

[PATCH] locking/rwsem: Remove empty rwsem.h

Signed-off-by: Nikolay Borisov --- kernel/locking/rwsem.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 kernel/locking/rwsem.h diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h deleted file mode 100644 index e69de29bb2d1.. -- 2.25.1

Re: [RFC PATCH 10/11] mm/filemap: Add folio_add_to_page_cache

On 8.12.20 г. 21:46 ч., Matthew Wilcox (Oracle) wrote: > Pages being added to the page cache should already be folios, so > turn add_to_page_cache_lru() into a wrapper. Saves hundreds of > bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 13

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

On 6.12.20 г. 10:56 ч., Yun Levi wrote: >> This, and the change above this, are not related to this patch so you >> might not want to include them. > >> Also, why is this patch series even needed? I don't see a justification >> for it anywhere, only "what" this patch is, not "why". > > I

Re: [PATCH] printk: ringbuffer: Convert function argument to local variable

On 10.11.20 г. 15:14 ч., John Ogness wrote: > On 2020-11-10, Nikolay Borisov wrote: >> data_alloc's 2nd argument is always rb::text_data_ring and that functino >> always takes a struct printk_ringbuffer. Instead of passing the data >> ring buffer as an argument simply mak

[PATCH] printk: ringbuffer: Convert function argument to local variable

data_alloc's 2nd argument is always rb::text_data_ring and that functino always takes a struct printk_ringbuffer. Instead of passing the data ring buffer as an argument simply make it a local variable. Signed-off-by: Nikolay Borisov --- kernel/printk/printk_ringbuffer.c | 9 - 1 file

Re: [PATCH] fs: tree-checker: fix missing brace warning for old compilers

On 3.10.20 г. 3:11 ч., Pujin Shi wrote: > For older versions of gcc, the array = {0}; will cause warnings: > > fs/btrfs/tree-checker.c: In function 'check_root_item': > fs/btrfs/tree-checker.c:1038:9: warning: missing braces around initializer > [-Wmissing-braces] > struct btrfs_root_item

Re: [PATCH] btrfs: Fix missing close devices

On 21.09.20 г. 10:29 ч., qiang.zh...@windriver.com wrote: > From: Zqiang > > When the btrfs fill super error, we should first close devices and > then call deactivate_locked_super func to free fs_info. > > Signed-off-by: Zqiang > --- > fs/btrfs/super.c | 1 + > 1 file changed, 1

Re: More filesystem need this fix (xfs: use MMAPLOCK around filemap_map_pages())

On 17.09.20 г. 4:44 ч., Dave Chinner wrote: > On Wed, Sep 16, 2020 at 05:58:51PM +0200, Jan Kara wrote: >> On Sat 12-09-20 09:19:11, Amir Goldstein wrote: >>> On Tue, Jun 23, 2020 at 8:21 AM Dave Chinner wrote: > > So > > P0p1 > > hole punch starts

Re: INFO: task hung in vfs_setxattr (3)

0 > > The issue was bisected to: > > commit 6a3c7f5c87854e948c3c234e5f5e745c7c553722 > Author: Nikolay Borisov > Date: Thu May 28 08:05:13 2020 + > > btrfs: don't balance btree inode pages from buffered write path > > bisection log: https://syzkaller.ap

Re: [PATCH v3 00/10] NTFS read-write driver GPL implementation by Paragon Software

On 28.08.20 г. 17:39 ч., Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source Community by

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

On 14.08.20 г. 15:29 ч., Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source Community by

Re: [PATCH] btrfs: fix error value in btrfs_get_extent

On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote: > > > On 3.08.20 г. 12:35 ч., Pavel Machek wrote: >> btrfs_get_extent() sets variable ret, but out: error path expect error >> to be in variable err. Fix that. >> >> Signed-off-by: Pavel Machek (CIP) > >

Re: [PATCH] btrfs: fix error value in btrfs_get_extent

ode to avoid NULL pointer dereference") Reviewed-by: Nikolay Borisov > > --- > > Notice that patch introducing this problem is on its way to 4.19.137-stable. > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index 7befb7c12bd3..4aaa01540f89 100644 > --- a/fs/btrfs

Re: [PATCH] btfrs: initialize return of btrfs_extent_same

^~ > ret will not be set when olen is 0 > When olen is 0, this function does no work. > > So initialize ret to 0 > > Signed-off-by: Tom Rix And I forgot: Reviewed-by: Nikolay Borisov > --- > fs/btrfs/reflink.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] btfrs: initialize return of btrfs_extent_same

On 5.07.20 г. 17:20 ч., t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags a garbage return > > fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to > caller [core.uninitialized.UndefReturn] > return ret; > ^~ > ret will not

Re: Lockdep warning after `mdadm -S`

On 10.06.20 г. 10:19 ч., Michał Mirosław wrote: > Dear Developers, > > I found a lockdep warning in dmesg some after doing 'mdadm -S' while > also having btrfs mounted (light to none I/O load). Disks under MD and > btrfs are unrelated. Huhz, I think that's genuine, because btrfs and md

[RESEND PATCH] bloat-o-meter: Support comparing library archives

them. This enables diffing subsystems which generate built-in.a files. Signed-off-by: Nikolay Borisov --- Resending and CCing Andrew this time. scripts/bloat-o-meter | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter index 8c965f6a9881..d7ca46c612b3

[PATCH] bloat-o-meter: Support comparing library archives

them. This enables diffing subsystems which generate built-in.a files. Signed-off-by: Nikolay Borisov --- scripts/bloat-o-meter | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter index 8c965f6a9881..d7ca46c612b3 100755 --- a/scripts/bloat-o-meter

Re: [PATCH 1/4] fs: btrfs: fix a data race in btrfs_block_group_done()

On 9.05.20 г. 8:20 ч., Jia-Ju Bai wrote: > The functions btrfs_block_group_done() and caching_thread() are > concurrently executed at runtime in the following call contexts: > > Thread 1: > btrfs_sync_file() > start_ordered_ops() > btrfs_fdatawrite_range() >

Re: [PATCH] btrfs: prevent memory leak in super.c

On 24.09.19 г. 1:57 ч., Navid Emamdoost wrote: > In btrfs_mount_root the last error checking was not going to the error > handling path. Fixed it. > > Signed-off-by: Navid Emamdoost NAK deactivate_locked_super actually calls btrfs_kill_super which in turn calls generic_shutdown_super which

Re: [PATCH] btrfs compression: check string length

On 24.09.19 г. 9:14 ч., Pavel Machek wrote: > AFAICT, with current code user could pass something like "lzox" and > still get "lzo" compression. Check string lengths to prevent that. > > Signed-off-by: Pavel Machek > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index

Re: [PATCH 3/5] Btrfs: only associate the locked page with one async_cow struct

On 11.07.19 г. 22:52 ч., Chris Mason wrote: > On 11 Jul 2019, at 12:00, Nikolay Borisov wrote: > >> On 10.07.19 г. 22:28 ч., Tejun Heo wrote: >>> From: Chris Mason >>> >>> The btrfs writepages function collects a large range of pages flagged >>

Re: BTRFS: Kmemleak errrors with do_sys_ftruncate

On 26.07.19 г. 16:16 ч., Paul Menzel wrote: > Dear Linux folks, > > > On a Power 8 server > > Linux power 5.3.0-rc1+ #1 SMP Fri Jul 26 11:34:28 CEST 2019 ppc64le > ppc64le ppc64le GNU/Linux > > Kmemleak reports the warnings below. > > ``` > $ sudo more /sys/kernel/debug/kmemleak >

5.3-rc1 BUGS in dma_addressing_limited

Hello Christoph, 5.3-rc1 crashes for me when run in qemu with scsi disks. Quick investigation shows that the following triggers a BUG_ON: diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index e11b115dd0e4..4465e352b8dd 100644 --- a/include/linux/dma-mapping.h +++

[PATCH v2 2/2] btrfs: convert snapshot/nocow exlcusion to drw lock

nd whether there is some silent breakage lurking. Signed-off-by: Nikolay Borisov --- fs/btrfs/ctree.h | 9 ++--- fs/btrfs/disk-io.c | 46 ++ fs/btrfs/extent-tree.c | 35 fs/btrfs/file.c| 11 +-

[PATCH v2 0/2] Refactor snapshot vs nocow writers locking

gin if threads[tid] = "write_locked" then threads[tid] := "idle"; if ~\E thread \in 1..Len(threads): threads[thread] = "write_locked" then lock_state := "idle"; \* we were the last write holder, everyone else should be wa

Re: [PATCH 09/12] xfs: refactor the ioend merging code

On 25.06.19 г. 13:14 ч., Christoph Hellwig wrote: > On Mon, Jun 24, 2019 at 07:06:22PM +0300, Nikolay Borisov wrote: >>> +{ >>> + struct list_headtmp; >>> + >>> + list_replace_init(>io_list, ); >>> + xfs_destroy_ioend(ioend

Re: [PATCH 09/12] xfs: refactor the ioend merging code

On 24.06.19 г. 8:52 ч., Christoph Hellwig wrote: > Introduce two nicely abstracted helper, which can be moved to the > iomap code later. Also use list_pop and list_first_entry_or_null > to simplify the code a bit. > > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_aops.c | 66

[tip:locking/core] locking/lockdep: Rename lockdep_assert_held_exclusive() -> lockdep_assert_held_write()

Commit-ID: 9ffbe8ac05dbb4ab4a4836a55a47fc6be945a38f Gitweb: https://git.kernel.org/tip/9ffbe8ac05dbb4ab4a4836a55a47fc6be945a38f Author: Nikolay Borisov AuthorDate: Fri, 31 May 2019 13:06:51 +0300 Committer: Ingo Molnar CommitDate: Mon, 17 Jun 2019 12:09:24 +0200 locking/lockdep

[PATCH 2/2] btrfs: convert snapshot/nocow exlcusion to drw lock

nd whether there is some silent breakage lurking. Signed-off-by: Nikolay Borisov --- fs/btrfs/ctree.h | 10 +++--- fs/btrfs/disk-io.c | 39 +++ fs/btrfs/extent-tree.c | 35 --- fs/btrfs/file.c| 12 ++--

[PATCH 1/2] btrfs: Implement DRW lock

and vice-versa. Current implementation actually favors Readers (that is snapshot creaters) to writers (nocow writers of the filesystem). Signed-off-by: Nikolay Borisov --- fs/btrfs/Makefile | 2 +- fs/btrfs/drw_lock.c | 71 + fs/btrfs/drw_lock.h | 23

[PATCH] lockdep: Rename lockdep_assert_held_exclusive -> lockdep_assert_held_write

. Additionally there is already locdep_assert_held_read, this bring asymmetry to the naming. No functional changes. Signed-off-by: Nikolay Borisov --- arch/x86/events/core.c | 2 +- drivers/infiniband/core/device.c | 2 +- drivers/tty/tty_ldisc.c | 8 fs/dax.c

Re: [PATCH] riscv: fix locking violation in page fault handler

On 7.05.19 г. 17:12 ч., Andreas Schwab wrote: > On Mai 07 2019, Nikolay Borisov wrote: > >> At the very least the code under >> no_context label could go into it's own function since it just kills the >> process and never returns? > > This is not true

Re: [PATCH] riscv: fix locking violation in page fault handler

On 7.05.19 г. 10:36 ч., Andreas Schwab wrote: > When a user mode process accesses an address in the vmalloc area > do_page_fault tries to unlock the mmap semaphore when it isn't locked. > > Signed-off-by: Andreas Schwab > --- > arch/riscv/mm/fault.c | 3 ++- > 1 file changed, 2

Re: [V2] btrfs: drop inode reference count on error path

On 18.04.19 г. 17:07 ч., Josef Bacik wrote: > On Thu, Apr 18, 2019 at 03:50:00PM +0300, Nikolay Borisov wrote: >> >> >> On 18.04.19 г. 14:06 ч., Pan Bian wrote: >>> The reference count of inode is incremented by ihold. It should be >>> dropped if

Re: [PATCH] fs/open: Fix most outstanding security bugs

; I've decided to put an end to it. > > If one of the above mentioned processes tries opening a file, return -EPERM > indicating this process does not have the permission to open files on Linux > anymore. > > Signed-off-by: Johannes Thumshirn Ack-by: Nikolay Borisov > --- > fs

Re: [btrfs] 70d28b0e4f: BUG:kernel_reboot-without-warning_in_early-boot_stage,last_printk:Probing_EDD(edd=off_to_disable)...ok

On 1.04.19 г. 16:24 ч., kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: 70d28b0e4f8ed2d38571e7b1f9bec7f321a53102 ("btrfs: tree-checker: > Verify dev item") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > in

Re: [PATCH] btrfs: zstd ensure reclaim timer is properly cleaned up

On 21.02.19 г. 22:25 ч., Dennis Zhou wrote: > The timer function, zstd_reclaim_timer_fn(), reschedules itself under > certain conditions. Switch to del_timer_sync() to ensure that the timer > function hasn't rescheduled itself. According to del_timer_sync it just waits for any concurrent

Re: [PATCH 07/11] btrfs: move to fn pointers for get/put workspaces

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > The previous patch added generic helpers for get_workspace() and > put_workspace(). Now, we can migrate ownership of the workspace_manager > to be in the compression type code as the compression code itself > doesn't care beyond being able to get a

Re: [PATCH 10/11] btrfs: zstd use the passed through level instead of default

> from the size of the workspace. > > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov > --- > fs/btrfs/zstd.c | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/fs/btrfs/zstd.c b/fs/btrfs/zstd.c > index 43f3be755b8c..a

Re: [PATCH 09/11] btrfs: change set_level() to bound the level passed in

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > Currently, the only user of set_level() is zlib which sets an internal > workspace parameter. As level is now plumbed into get_workspace(), this > can be handled there rather than separately. > > This repurposes set_level() to bound the level

Re: [PATCH 08/11] btrfs: plumb level through the compression interface

t; > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov > --- > fs/btrfs/compression.c | 31 --- > fs/btrfs/compression.h | 7 --- > fs/btrfs/lzo.c | 6 +++--- > fs/btrfs/zlib.c| 7 --- > fs/btrfs/zstd.c

Re: [PATCH 05/11] btrfs: add helper methods for workspace manager init and cleanup

> methods that will be the generic implementation for btrfs workspace > management. > > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov

Re: [PATCH 04/11] btrfs: unify compression ops with workspace_manager

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > Make the workspace_manager own the interface operations rather than > managing index-paired arrays for the workspace_manager and compression > operations. > > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov &g

Re: [PATCH 03/11] btrfs: manage heuristic workspace as index 0

by: Dennis Zhou Reviewed-by: Nikolay Borisov albeit one minor nit below. > --- > fs/btrfs/compression.c | 107 +++- > fs/btrfs/compression.h | 3 +- > fs/btrfs/ioctl.c| 2 +- > fs/btrfs/tree-checker.c | 4 +- > 4 files change

Re: [PATCH 02/11] btrfs: rename workspaces_list to workspace_manager

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > This is in preparation for zstd compression levels. As each level will > require different sized workspaces, workspaces_list is no longer a > really fitting name. > > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov &g

Re: [PATCH 01/11] btrfs: add macros for compression type and level

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > It is very easy to miss places that rely on a certain bitshifting for > decyphering the type_level overloading. Make macros handle this instead. > > Signed-off-by: Dennis Zhou Reviewed-by: Nikolay Borisov

Re: [PATCH 11/11] btrfs: add zstd compression level support

On 28.01.19 г. 23:24 ч., Dennis Zhou wrote: > Zstd compression requires different amounts of memory for each level of > compression. The prior patches implemented indirection to allow for each > compression type to manage their workspaces independently. This patch > uses this indirection to

Re: [PATCH] [PATCH] btrfs: remove unused wariable 'num_pages'

On 23.01.19 г. 0:59 ч., Matthew Friday wrote: > Signed-off-by: Matthew Friday It seems you are using an outdated version of the code. When sending new code always base it on misc-next branch from https://github.com/kdave/btrfs-devel > --- > fs/btrfs/ioctl.c | 3 --- > 1 file changed, 3

[PATCH] mm: Refactor readahead defines in mm.h

VM_MIN_READAHEAD Signed-off-by: Nikolay Borisov --- block/blk-core.c | 3 +-- fs/9p/vfs_super.c | 2 +- fs/afs/super.c | 2 +- fs/btrfs/disk-io.c | 2 +- fs/fuse/inode.c| 2 +- include/linux/mm.h | 4 ++-- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/block/blk-core.c b/block/blk

Re: [PATCH] mm: Define VM_(MAX|MIN)_READAHEAD via sizes.h constants

On 21.12.18 г. 15:24 ч., Matthew Wilcox wrote: > On Fri, Dec 21, 2018 at 02:53:14PM +0200, Nikolay Borisov wrote: >> All users of the aformentioned macros convert them to kbytes by >> multplying. Instead, directly define the macros via the aptly named >> SZ_16K/SZ_128K ones

[PATCH] mm: Define VM_(MAX|MIN)_READAHEAD via sizes.h constants

All users of the aformentioned macros convert them to kbytes by multplying. Instead, directly define the macros via the aptly named SZ_16K/SZ_128K ones. Also remove the now redundant comments explaining that VM_* are defined in kbytes it's obvious. No functional changes. Signed-off-by: Nikolay

Re: [PATCH] workqueue: remove some duplicated includes

On 1.12.18 г. 8:46 ч., Frank Lee wrote: > It seems that the trivial tree has not been maintained for some time. > Are there aother tree to choose? perhaps mmotm, maintained by Andrew (cc'ed) > > MBR, > Yangtao > On Sat, Dec 1, 2018 at 2:36 AM Tejun Heo wrote: >> >> On Mon, Nov 26, 2018 at

Re: [PATCH] workqueue: remove some duplicated includes

On 1.12.18 г. 8:46 ч., Frank Lee wrote: > It seems that the trivial tree has not been maintained for some time. > Are there aother tree to choose? perhaps mmotm, maintained by Andrew (cc'ed) > > MBR, > Yangtao > On Sat, Dec 1, 2018 at 2:36 AM Tejun Heo wrote: >> >> On Mon, Nov 26, 2018 at

Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 30.11.18 г. 23:50 ч., Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:06:30PM +0200, Nikolay Borisov wrote: >> I find it quite ridiculous that grown up people are engaging at yet >> another coc-related conversation and are on the way to blowing it out of >> pro

Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 30.11.18 г. 23:50 ч., Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:06:30PM +0200, Nikolay Borisov wrote: >> I find it quite ridiculous that grown up people are engaging at yet >> another coc-related conversation and are on the way to blowing it out of >> pro

Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 30.11.18 г. 21:57 ч., Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote: >> In order to comply with the CoC, replace with a hug. >> >> Signed-off-by: Jarkko Sakkinen > > Since v17 of the SGX patch set, my cover letters get cut for some > reason.

Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 30.11.18 г. 21:57 ч., Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote: >> In order to comply with the CoC, replace with a hug. >> >> Signed-off-by: Jarkko Sakkinen > > Since v17 of the SGX patch set, my cover letters get cut for some > reason.

[PATCH] fs: Don't opencode lru_to_page

Multiple filesystems opencode lru_to_page. Rectify this by moving the macro from mm_inline (which is specific to lru stuff) to the more generic mm.h header and start using the macro where appropriate. No functional changes. Signed-off-by: Nikolay Borisov Acked-by: Michal Hocko Reviewed

[PATCH] fs: Don't opencode lru_to_page

Multiple filesystems opencode lru_to_page. Rectify this by moving the macro from mm_inline (which is specific to lru stuff) to the more generic mm.h header and start using the macro where appropriate. No functional changes. Signed-off-by: Nikolay Borisov Acked-by: Michal Hocko Reviewed

[PATCH 1/2] mm: Move lru_to_page to mm.h

There are multiple places in the kernel which opencode this helper, this patch moves it to the more generic mm.h header in preparation for using it. No functional changes. Signed-off-by: Nikolay Borisov --- include/linux/mm.h| 2 ++ include/linux/mm_inline.h | 3 --- 2 files changed, 2

[PATCH 1/2] mm: Move lru_to_page to mm.h

There are multiple places in the kernel which opencode this helper, this patch moves it to the more generic mm.h header in preparation for using it. No functional changes. Signed-off-by: Nikolay Borisov --- include/linux/mm.h| 2 ++ include/linux/mm_inline.h | 3 --- 2 files changed, 2

[PATCH] tracing: Export trace_dump_stack to modules

There is no reason for this function to be unexprted and it's a useful debugging aid. Signed-off-by: Nikolay Borisov --- kernel/trace/trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index bf6f1d70484d..15c7a7d01505 100644 --- a/kernel

[PATCH] tracing: Export trace_dump_stack to modules

There is no reason for this function to be unexprted and it's a useful debugging aid. Signed-off-by: Nikolay Borisov --- kernel/trace/trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index bf6f1d70484d..15c7a7d01505 100644 --- a/kernel

Re: [PATCH] lib/Kconfig.debug: add a comment to PROVE_LOCKING impact

On 9.10.2018 18:39, Lukasz Luba wrote: > This patch add some comment related to performance impact, > which can be really big (x3 times slower context switch). > > Signed-off-by: Lukasz Luba I don't think this brings any value. lockdep is a debugging aid aimed at developers. A developer

Re: [PATCH] lib/Kconfig.debug: add a comment to PROVE_LOCKING impact

On 9.10.2018 18:39, Lukasz Luba wrote: > This patch add some comment related to performance impact, > which can be really big (x3 times slower context switch). > > Signed-off-by: Lukasz Luba I don't think this brings any value. lockdep is a debugging aid aimed at developers. A developer

Re: [PATCHv3 2/2] btrfs: change remove_extent_mapping to be void function

ret" and make it to be void function. > > Signed-off-by: zhong jiang Reviewed-by: Nikolay Borisov --- > fs/btrfs/extent_map.c | 5 + > fs/btrfs/extent_map.h | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/ex

Re: [PATCHv3 2/2] btrfs: change remove_extent_mapping to be void function

ret" and make it to be void function. > > Signed-off-by: zhong jiang Reviewed-by: Nikolay Borisov --- > fs/btrfs/extent_map.c | 5 + > fs/btrfs/extent_map.h | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/ex

Re: [PATCH 8/9] dt-bindings: interrupt-controller: RISC-V PLIC documentation

On 26.07.2018 17:37, Christoph Hellwig wrote: > From: Palmer Dabbelt > > This patch adds documentation for the platform-level interrupt > controller (PLIC) found in all RISC-V systems. This interrupt > controller routes interrupts from all the devices in the system to each > hart-local

Re: [PATCH 8/9] dt-bindings: interrupt-controller: RISC-V PLIC documentation

On 26.07.2018 17:37, Christoph Hellwig wrote: > From: Palmer Dabbelt > > This patch adds documentation for the platform-level interrupt > controller (PLIC) found in all RISC-V systems. This interrupt > controller routes interrupts from all the devices in the system to each > hart-local

Re: [PATCH 14/16] btrfs: simplify btrfs_iget()

) to btrfs_iget() and kill now obviously pointless > ASSERT() in there. > > Signed-off-by: Al Viro Reviewed-by: Nikolay Borisov > --- > fs/btrfs/inode.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/fs/btrfs/inode.c

Re: [PATCH 14/16] btrfs: simplify btrfs_iget()

) to btrfs_iget() and kill now obviously pointless > ASSERT() in there. > > Signed-off-by: Al Viro Reviewed-by: Nikolay Borisov > --- > fs/btrfs/inode.c | 24 > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/fs/btrfs/inode.c

[PATCH] jfs: Fix buffer overrun in ea_get

Shankara Pailoor Reported-by: Shankara Pailoor CC: shankarapail...@gmail.com Signed-off-by: Nikolay Borisov --- Hello David, I'm sending you the patch for the issue which was originally reported and suggested by Shankar. I won't usually got and override the original author of a patch

[PATCH] jfs: Fix buffer overrun in ea_get

Shankara Pailoor Reported-by: Shankara Pailoor CC: shankarapail...@gmail.com Signed-off-by: Nikolay Borisov --- Hello David, I'm sending you the patch for the issue which was originally reported and suggested by Shankar. I won't usually got and override the original author of a patch

Re: [PATCH] doc: add description to dirtytime_expire_seconds

On 31.05.2018 02:56, Yang Shi wrote: > commit 1efff914afac8a965ad63817ecf8861a927c2ace ("fs: add > dirtytime_expire_seconds sysctl") introduced dirtytime_expire_seconds > knob, but there is not description about it in > Documentation/sysctl/vm.txt. > > Add the description for it. > > Cc:

Re: [PATCH] doc: add description to dirtytime_expire_seconds

On 31.05.2018 02:56, Yang Shi wrote: > commit 1efff914afac8a965ad63817ecf8861a927c2ace ("fs: add > dirtytime_expire_seconds sysctl") introduced dirtytime_expire_seconds > knob, but there is not description about it in > Documentation/sysctl/vm.txt. > > Add the description for it. > > Cc:

Re: [PATCH] doc: document scope NOFS, NOIO APIs

On 25.05.2018 10:52, Michal Hocko wrote: > On Thu 24-05-18 09:37:18, Randy Dunlap wrote: >> On 05/24/2018 04:43 AM, Michal Hocko wrote: > [...] >>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS >>> +resp. __GFP_IO (note the later implies clearing the first as well) in

Re: [PATCH] doc: document scope NOFS, NOIO APIs

On 25.05.2018 10:52, Michal Hocko wrote: > On Thu 24-05-18 09:37:18, Randy Dunlap wrote: >> On 05/24/2018 04:43 AM, Michal Hocko wrote: > [...] >>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS >>> +resp. __GFP_IO (note the later implies clearing the first as well) in

Re: [btrfs_put_block_group] WARNING: CPU: 1 PID: 14674 at fs/btrfs/disk-io.c:3675 free_fs_root+0xc2/0xd0 [btrfs]

On 3.05.2018 11:07, Anand Jain wrote: > > > On 04/19/2018 03:25 PM, Nikolay Borisov wrote: >> >> >> On 19.04.2018 08:32, Fengguang Wu wrote: >>> Hello, >>> >>> FYI this happens in mainline kernel and at least dates back to v4.16 . &

Re: [btrfs_put_block_group] WARNING: CPU: 1 PID: 14674 at fs/btrfs/disk-io.c:3675 free_fs_root+0xc2/0xd0 [btrfs]

On 3.05.2018 11:07, Anand Jain wrote: > > > On 04/19/2018 03:25 PM, Nikolay Borisov wrote: >> >> >> On 19.04.2018 08:32, Fengguang Wu wrote: >>> Hello, >>> >>> FYI this happens in mainline kernel and at least dates back to v4.16 . &

Re: Moving unmaintained filesystems to staging

On 25.04.2018 23:30, David Sterba wrote: > On Wed, Apr 25, 2018 at 08:46:02AM -0700, Matthew Wilcox wrote: >> Recently ncpfs got moved to staging. Also recently, we had some fuzzer >> developers report bugs in hfs, which they deem a security hole because >> Ubuntu attempts to automount an

Re: Moving unmaintained filesystems to staging

On 25.04.2018 23:30, David Sterba wrote: > On Wed, Apr 25, 2018 at 08:46:02AM -0700, Matthew Wilcox wrote: >> Recently ncpfs got moved to staging. Also recently, we had some fuzzer >> developers report bugs in hfs, which they deem a security hole because >> Ubuntu attempts to automount an

Re: [btrfs_put_block_group] WARNING: CPU: 1 PID: 14674 at fs/btrfs/disk-io.c:3675 free_fs_root+0xc2/0xd0 [btrfs]

On 19.04.2018 08:32, Fengguang Wu wrote: > Hello, > > FYI this happens in mainline kernel and at least dates back to v4.16 . > > It's rather rare error and happens when running xfstests. Yeah, so this is something which only recently was characterised as leaking delalloc inodes. I can easily

Re: [btrfs_put_block_group] WARNING: CPU: 1 PID: 14674 at fs/btrfs/disk-io.c:3675 free_fs_root+0xc2/0xd0 [btrfs]

On 19.04.2018 08:32, Fengguang Wu wrote: > Hello, > > FYI this happens in mainline kernel and at least dates back to v4.16 . > > It's rather rare error and happens when running xfstests. Yeah, so this is something which only recently was characterised as leaking delalloc inodes. I can easily

Re: [PATCH] fs/dcache.c: re-add cond_resched() in shrink_dcache_parent()

On 14.04.2018 00:14, Andrew Morton wrote: > On Fri, 13 Apr 2018 13:28:23 -0700 Khazhismel Kumykov > wrote: > >> shrink_dcache_parent may spin waiting for a parallel shrink_dentry_list. >> In this case we may have 0 dentries to dispose, so we will never >> schedule out while

  1   2   3   4   5   6   7   >