RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-09 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Thursday, April 8, 2021 5:46 PM > On Wed, Apr 07, 2021 at 03:44:35PM +0000, Parav Pandit wrote: > > > > If it returns EOPNOTUPP then the remove is never called so if it > > > allocated memory and left it allocated then it is leakin

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Wednesday, April 7, 2021 8:44 PM > > On Wed, Apr 07, 2021 at 03:06:35PM +, Parav Pandit wrote: > > > > > > > From: Jason Gunthorpe > > > Sent: Tuesday, April 6, 2021 9:17 PM > > > > > > On

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Tuesday, April 6, 2021 9:17 PM > > On Mon, Apr 05, 2021 at 08:49:56AM +0300, Leon Romanovsky wrote: > > @@ -2293,6 +2295,17 @@ static void ib_sa_event(struct ib_event_handler > *handler, > > } > > } > > > > +static bool ib_sa_client_supported(struct

RE: [PATCH] net/mlx5: remove unneeded semicolon

2021-03-03 Thread Parav Pandit
Hi Saeed, > From: Parav Pandit > Sent: Monday, February 22, 2021 3:32 PM > > > > From: Jiapeng Chong > > Sent: Monday, February 22, 2021 3:27 PM > > > > Fix the following coccicheck warnings: > > > > ./drivers/net/ethernet/mellanox/mlx5/c

RE: [PATCH] net/mlx5: remove unneeded semicolon

2021-02-22 Thread Parav Pandit
break; > - }; > + } > > return 0; > } > -- > 1.8.3.1 Reviewed-by: Parav Pandit

RE: [PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-05 Thread Parav Pandit
x5 function attributes`_ > - `Devlink health reporters`_ > - `mlx5 tracepoints`_ > > Enabling the driver and kconfig options - > > +=== > > | mlx5 core is modular and most of the major mlx5 core driver features can > be selected (compiled in/out) | at build time via kernel Kconfig flags. > -- > 2.17.1 Thanks. Reviewed-by: Parav Pandit

RE: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-04 Thread Parav Pandit
Oh > > > Co-developed-by: Leon Romanovsky > > > Signed-off-by: Kiran Patil > > > Signed-off-by: Ranjani Sridharan > > > Signed-off-by: Fred Oh > > > Signed-off-by: Leon Romanovsky > > > Signed-off-by: Dave Ertman > > > Reviewed

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Parav Pandit
> From: Dan Williams > Sent: Friday, November 6, 2020 1:56 AM > > On Thu, Nov 5, 2020 at 11:40 AM Parav Pandit wrote: > > > > > > > > > From: Ertman, David M > > > Sent: Friday, November 6, 2020 12:58 AM > > >

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Parav Pandit
> From: Ertman, David M > Sent: Friday, November 6, 2020 12:58 AM > Subject: RE: [PATCH v3 01/10] Add auxiliary bus support > > > -Original Message- > > From: Dan Williams > > Sent: Thursday, November 5, 2020 1:19 AM > > [..] > > > + > > > +Another use case is for the PCI device to

RE: [PATCH mlx5-next v1 03/11] net/mlx5_core: Clean driver version and name

2020-11-01 Thread Parav Pandit
/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h > index 8cec85ab419d..b285f1515e4e 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h > +++ b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h > @@ -42,9 +42,6 @@ > #include > #include > > -#define DRIVER_NAME "mlx5_core" > -#define DRIVER_VERSION "5.0-0" > - > extern uint mlx5_core_debug_mask; > > #define mlx5_core_dbg(__dev, format, ...)\ > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h index > 317257f8e0ad..ed1d030658d2 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -56,6 +56,8 @@ > #include > #include > > +#define MLX5_ADEV_NAME "mlx5_core" > + > enum { > MLX5_BOARD_ID_LEN = 64, > }; > -- > 2.28.0 Other than strlen removal check, Reviewed-by: Parav Pandit

RE: WARNING in dma_map_page_attrs

2020-10-30 Thread Parav Pandit
> From: h...@lst.de > Sent: Wednesday, October 28, 2020 11:01 PM > > On Tue, Oct 27, 2020 at 12:52:30PM +, Parav Pandit wrote: > > > > > From: h...@lst.de > > > Sent: Tuesday, October 27, 2020 1:41 PM > > > > > > On Mon, Oct 26, 20

RE: WARNING in dma_map_page_attrs

2020-10-27 Thread Parav Pandit
> From: h...@lst.de > Sent: Tuesday, October 27, 2020 1:41 PM > > On Mon, Oct 26, 2020 at 05:23:48AM +, Parav Pandit wrote: > > Hi Christoph, > > > > > From: Jakub Kicinski > > > Sent: Saturday, October 24, 2020 11:45 PM > > > &

RE: WARNING in dma_map_page_attrs

2020-10-25 Thread Parav Pandit
Hi Christoph, > From: Jakub Kicinski > Sent: Saturday, October 24, 2020 11:45 PM > > CC: rdma, looks like rdma from the stack trace > > On Fri, 23 Oct 2020 20:07:17 -0700 syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > > > HEAD commit:3cb12d27 Merge tag

RE: [PATCH] RDMA/core: fix return error value to negative

2020-07-27 Thread Parav Pandit
{ > - ret = EINVAL; > + ret = -EINVAL; > goto out; > } > } > -- > 2.7.4 With below corrected fixes tag, Fixes: 7a5c938b9ed0 ("IB/core: Check for rdma_protocol_ib only after validating port_num") Reviewed-by: Parav Pandit

Re: [REGRESSION] mlx5: Driver remove during hot unplug is broken

2020-07-09 Thread Parav Pandit
On 7/9/2020 3:36 PM, Niklas Schnelle wrote: > > On 7/8/20 5:44 PM, Parav Pandit wrote: > ... snip .. >>> >> >> It is likely because events_cleanup() freed the memory using kvfree() that >> health recovery context is trying to access in notifier chain. >>

RE: [REGRESSION] mlx5: Driver remove during hot unplug is broken

2020-07-08 Thread Parav Pandit
> From: Niklas Schnelle > Sent: Wednesday, July 8, 2020 5:14 PM > Hi Parav, Hi Shay, > > On 7/8/20 12:43 PM, Parav Pandit wrote: > > Hi Niklas, > > > ... snip ... > >>> > > > > Sorry for my late response. > > Yes, this looks goo

RE: [REGRESSION] mlx5: Driver remove during hot unplug is broken

2020-07-08 Thread Parav Pandit
Hi Niklas, > From: Niklas Schnelle > Sent: Monday, June 15, 2020 3:32 PM > > Hello Saeed, > > On 6/13/20 12:01 AM, Saeed Mahameed wrote: > > On Fri, 2020-06-12 at 15:09 +0200, Niklas Schnelle wrote: > >> Hello Parav, Hello Saeed, > >> > ... snip ... > >> > >> So without really knowing anything

RE: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Parav Pandit
m; seb...@linux.ibm.com; > ober...@linux.ibm.com; heiko.carst...@de.ibm.com; g...@linux.ibm.com; > borntrae...@de.ibm.com; akrow...@linux.ibm.com; fre...@linux.ibm.com; > lingshan@intel.com; Ido Shamay ; > epere...@redhat.com; l...@redhat.com; Parav Pandit > ; christophe.de.dinec...@g

RE: [PATCH v3 0/5] Introduce variable length mdev alias

2019-09-18 Thread Parav Pandit
Hi Cornelia, > -Original Message- > From: Cornelia Huck > Sent: Tuesday, September 17, 2019 5:14 AM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...

RE: [PATCH v3 0/5] Introduce variable length mdev alias

2019-09-13 Thread Parav Pandit
Hi Alex, > -Original Message- > From: Alex Williamson > Sent: Friday, September 13, 2019 4:33 PM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH v3 0/5] Introduce variable length mdev alias

2019-09-11 Thread Parav Pandit
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Wednesday, September 11, 2019 10:31 AM > To: Alex Williamson > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net;

RE: [PATCH v3 0/5] Introduce variable length mdev alias

2019-09-11 Thread Parav Pandit
Hi Alex, > -Original Message- > From: Alex Williamson > Sent: Wednesday, September 11, 2019 8:56 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; n

RE: [PATCH v3 0/5] Introduce variable length mdev alias

2019-09-09 Thread Parav Pandit
Hi Alex, > -Original Message- > From: Parav Pandit > Sent: Sunday, September 1, 2019 11:25 PM > To: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; coh...@redhat.com; da...@davemloft.net > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > n

RE: [PATCH v2 5/6] mdev: Update sysfs documentation

2019-09-02 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Monday, September 2, 2019 8:07 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; > linux-kernel@vger.kernel.org; net...@vger

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-09-02 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Monday, September 2, 2019 8:16 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; > linux-kernel@vger.kernel.org; net...@vger

[PATCH v3 1/5] mdev: Introduce sha1 based mdev alias

2019-09-01 Thread Parav Pandit
, that alias is checked for collisions. It is an optional attribute. mdev alias is generated using sha1 from the mdev name. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Kept mdev_device naturally aligned - Added error checking for crypt_*() calls - Corrected a typo from 'and' to 'an' - Chan

[PATCH v3 3/5] mdev: Expose mdev alias in sysfs tree

2019-09-01 Thread Parav Pandit
Expose the optional alias for an mdev device as a sysfs attribute. This way, userspace tools such as udev may make use of the alias, for example to create a netdevice name for the mdev. Updated documentation for optional read only sysfs attribute. Signed-off-by: Parav Pandit --- Changelog: v2

[PATCH v3 4/5] mdev: Introduce an API mdev_alias

2019-09-01 Thread Parav Pandit
Introduce an API mdev_alias() to provide access to optionally generated alias. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_core.c | 12 include/linux/mdev.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev

[PATCH v3 0/5] Introduce variable length mdev alias

2019-09-01 Thread Parav Pandit
nded over to mdev device - Fixed cleaunup of hash if mdev_bus_register() fails - Updated documentation for new sysfs alias file - Improved commit logs to make description more clear - Fixed inclusiong of alias for NULL check - Added ratelimited debug print for sha1 hash collision error Parav

[PATCH v3 2/5] mdev: Make mdev alias unique among all mdevs

2019-09-01 Thread Parav Pandit
Mdev alias should be unique among all the mdevs, so that when such alias is used by the mdev users to derive other objects, there is no collision in a given system. Signed-off-by: Parav Pandit --- Changelog: v2->v3: - Changed strcmp() ==0 to !strcmp() v1->v2: - Moved alias NULL

[PATCH v3 5/5] mtty: Optionally support mtty alias

2019-09-01 Thread Parav Pandit
Provide a module parameter to set alias length to optionally generate mdev alias. Example to request mdev alias. $ modprobe mtty alias_length=12 Make use of mtty_alias() API when alias_length module parameter is set. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Added mdev_al

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 7:32 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v2 5/6] mdev: Update sysfs documentation

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 6:19 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 6:11 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 6:09 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-30 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Friday, August 30, 2019 2:47 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH internal net-next 0/2] Minor refactor in devlink

2019-08-29 Thread Parav Pandit
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Friday, August 30, 2019 9:41 AM > To: linux-kernel@vger.kernel.org; Jiri Pirko > Cc: Parav Pandit > Subject: [PATCH internal net-nex

[PATCH internal net-next 0/2] Minor refactor in devlink

2019-08-29 Thread Parav Pandit
Two minor refactors in devlink. Patch-1 Explicitly defines devlink port index as unsigned int Patch-2 Uses switch-case to handle different port flavours attributes Parav Pandit (2): devlink: Make port index data type as unsigned int devlink: Use switch-case instead of if-else include/net

[PATCH internal net-next 1/2] devlink: Make port index data type as unsigned int

2019-08-29 Thread Parav Pandit
/devlink.h:81: + unsigned index; Signed-off-by: Parav Pandit --- include/net/devlink.h | 2 +- net/core/devlink.c| 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/devlink.h b/include/net/devlink.h index 7f43c48f54cd..13523b0a0642 100644 --- a/include/net

[PATCH internal net-next 2/2] devlink: Use switch-case instead of if-else

2019-08-29 Thread Parav Pandit
Make core more readable with switch-case for various port flavours. Signed-off-by: Parav Pandit --- net/core/devlink.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index b7091329987a

RE: [PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-29 Thread Parav Pandit
> -Original Message- > From: Yunsheng Lin > Sent: Thursday, August 29, 2019 5:57 PM > To: Parav Pandit ; alex.william...@redhat.com; Jiri > Pirko ; kwankh...@nvidia.com; coh...@redhat.com; > da...@davemloft.net > Cc: k...@vger.kernel.org; linux-kernel@v

[PATCH v2 1/6] mdev: Introduce sha1 based mdev alias

2019-08-29 Thread Parav Pandit
, that alias is checked for collisions. It is an optional attribute. mdev alias is generated using sha1 from the mdev name. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Kept mdev_device naturally aligned - Added error checking for crypt_*() calls - Corrected a typo from 'and' to 'an' - Chan

[PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs

2019-08-29 Thread Parav Pandit
Mdev alias should be unique among all the mdevs, so that when such alias is used by the mdev users to derive other objects, there is no collision in a given system. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Moved alias NULL check at beginning v0->v1: - Fixed inclusiong of

[PATCH v2 5/6] mdev: Update sysfs documentation

2019-08-29 Thread Parav Pandit
Updated documentation for optional read only sysfs attribute. Signed-off-by: Parav Pandit --- Documentation/driver-api/vfio-mediated-device.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated

[PATCH v2 6/6] mtty: Optionally support mtty alias

2019-08-29 Thread Parav Pandit
Provide a module parameter to set alias length to optionally generate mdev alias. Example to request mdev alias. $ modprobe mtty alias_length=12 Make use of mtty_alias() API when alias_length module parameter is set. Signed-off-by: Parav Pandit --- Changelog: v1->v2: - Added mdev_al

[PATCH v2 4/6] mdev: Introduce an API mdev_alias

2019-08-29 Thread Parav Pandit
Introduce an API mdev_alias() to provide access to optionally generated alias. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_core.c | 12 include/linux/mdev.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev

[PATCH v2 3/6] mdev: Expose mdev alias in sysfs tree

2019-08-29 Thread Parav Pandit
Expose the optional alias for an mdev device as a sysfs attribute. This way, userspace tools such as udev may make use of the alias, for example to create a netdevice name for the mdev. Signed-off-by: Parav Pandit --- Changelog: v0->v1: - Addressed comments from Cornelia Huck - Updated com

[PATCH v2 0/6] Introduce variable length mdev alias

2019-08-29 Thread Parav Pandit
alias for NULL check - Added ratelimited debug print for sha1 hash collision error Parav Pandit (6): mdev: Introduce sha1 based mdev alias mdev: Make mdev alias unique among all mdevs mdev: Expose mdev alias in sysfs tree mdev: Introduce an API mdev_alias mdev: Update sysfs documentation

RE: [PATCH v1 2/5] mdev: Make mdev alias unique among all mdevs

2019-08-29 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Thursday, August 29, 2019 3:07 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias

2019-08-29 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Thursday, August 29, 2019 3:05 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias

2019-08-29 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Thursday, August 29, 2019 2:56 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

[PATCH v1 2/5] mdev: Make mdev alias unique among all mdevs

2019-08-27 Thread Parav Pandit
Mdev alias should be unique among all the mdevs, so that when such alias is used by the mdev users to derive other objects, there is no collision in a given system. Signed-off-by: Parav Pandit --- Changelog: v0->v1: - Fixed inclusiong of alias for NULL check - Added ratelimited debug pr

[PATCH v1 4/5] mdev: Update sysfs documentation

2019-08-27 Thread Parav Pandit
Updated documentation for optional read only sysfs attribute. Signed-off-by: Parav Pandit --- Documentation/driver-api/vfio-mediated-device.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated

[PATCH v1 1/5] mdev: Introduce sha1 based mdev alias

2019-08-27 Thread Parav Pandit
, that alias is checked for collisions. It is an optional attribute. mdev alias is generated using sha1 from the mdev name. Signed-off-by: Parav Pandit --- Changelog: v0->v1: - Moved alias length check outside of the parent lock - Moved alias and digest allocation from kvzalloc to kzalloc - [0] chan

[PATCH v1 5/5] mtty: Optionally support mtty alias

2019-08-27 Thread Parav Pandit
Provide a module parameter to set alias length to optionally generate mdev alias. Example to request mdev alias. $ modprobe mtty alias_length=12 Signed-off-by: Parav Pandit --- samples/vfio-mdev/mtty.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/samples/vfio-mdev/mtty.c b

[PATCH v1 3/5] mdev: Expose mdev alias in sysfs tree

2019-08-27 Thread Parav Pandit
Expose the optional alias for an mdev device as a sysfs attribute. This way, userspace tools such as udev may make use of the alias, for example to create a netdevice name for the mdev. Signed-off-by: Parav Pandit --- Changelog: v0->v1: - Addressed comments from Cornelia Huck - Updated com

[PATCH v1 0/5] Introduce variable length mdev alias

2019-08-27 Thread Parav Pandit
eck - Added ratelimited debug print for sha1 hash collision error Parav Pandit (5): mdev: Introduce sha1 based mdev alias mdev: Make mdev alias unique among all mdevs mdev: Expose mdev alias in sysfs tree mdev: Update sysfs documentation mtty: Optionally support mtty alias .../driver-

RE: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 9:55 PM > To: Parav Pandit > Cc: Cornelia Huck ; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; > linux-kernel@vger.kernel.org; net...@vger.kernel.org &g

RE: [PATCH 0/4] Introduce variable length mdev alias

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 11:19 PM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 8:54 PM > To: Parav Pandit > Cc: Mark Bloch ; Jiri Pirko ; > kwankh...@nvidia.com; coh...@redhat.com; da...@davemloft.net; > k...@vger.kernel.org; linux-kernel@vger.kernel.org; n

RE: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 8:59 PM > To: Cornelia Huck > Cc: Parav Pandit ; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org

RE: [PATCH 0/4] Introduce variable length mdev alias

2019-08-27 Thread Parav Pandit
Hi Alex, Cornelia, > -Original Message- > From: kvm-ow...@vger.kernel.org On Behalf > Of Parav Pandit > Sent: Tuesday, August 27, 2019 2:11 AM > To: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; coh...@redhat.com; da...@davemloft.net > Cc: k...@v

RE: [PATCH 3/4] mdev: Expose mdev alias in sysfs tree

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 5:25 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 5:11 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 3/4] mdev: Expose mdev alias in sysfs tree

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 5:05 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 4:54 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 3:54 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 3:54 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 3:59 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 3/4] mdev: Expose mdev alias in sysfs tree

2019-08-27 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 27, 2019 4:17 PM > To: Parav Pandit > Cc: alex.william...@redhat.com; Jiri Pirko ; > kwankh...@nvidia.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger

RE: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-26 Thread Parav Pandit
Hi Mark, > -Original Message- > From: Mark Bloch > Sent: Tuesday, August 27, 2019 4:32 AM > To: Parav Pandit ; alex.william...@redhat.com; Jiri > Pirko ; kwankh...@nvidia.com; coh...@redhat.com; > da...@davemloft.net > Cc: k...@vger.kernel.org; linux-kernel@v

RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-26 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 7:15 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

RE: [PATCH 3/4] mdev: Expose mdev alias in sysfs tree

2019-08-26 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 27, 2019 7:24 AM > To: Parav Pandit > Cc: Jiri Pirko ; kwankh...@nvidia.com; > coh...@redhat.com; da...@davemloft.net; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; net...@vger.ker

[PATCH 1/4] mdev: Introduce sha1 based mdev alias

2019-08-26 Thread Parav Pandit
Whenever a parent requests to generate mdev alias, generate a mdev alias. It is an optional attribute that parent can request to generate for each of its child mdev. mdev alias is generated using sha1 from the mdev name. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_core.c| 98

[PATCH 4/4] mtty: Optionally support mtty alias

2019-08-26 Thread Parav Pandit
Provide a module parameter to set alias length to optionally generate mdev alias. Example to request mdev alias. $ modprobe mtty alias_length=12 Signed-off-by: Parav Pandit --- samples/vfio-mdev/mtty.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/samples/vfio-mdev/mtty.c b

[PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-26 Thread Parav Pandit
Mdev alias should be unique among all the mdevs, so that when such alias is used by the mdev users to derive other objects, there is no collision in a given system. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers

[PATCH 3/4] mdev: Expose mdev alias in sysfs tree

2019-08-26 Thread Parav Pandit
Expose mdev alias as string in a sysfs tree so that such attribute can be used to generate netdevice name by systemd/udev or can be used to match other kernel objects based on the alias of the mdev. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_sysfs.c | 13 + 1 file

[PATCH 0/4] Introduce variable length mdev alias

2019-08-26 Thread Parav Pandit
wants to use mdev alias, mdev_alias() API will be added to derive devlink port name. [1] http://man7.org/linux/man-pages/man8/devlink-port.8.html [2] https://docs.openstack.org/os-vif/latest/user/plugins/ovs.html [3] https://patchwork.kernel.org/cover/11084231/ Parav Pandit (4): mdev: Introduce

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Saturday, August 24, 2019 10:29 AM > To: Parav Pandit > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller ; Kirti Wankhede ; > Cornelia Huck ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cjia

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
Hi Alex, > -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Saturday, August 24, 2019 9:26 AM > To: Alex Williamson > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller ; Kirti Wankhede

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Saturday, August 24, 2019 1:14 AM > To: Parav Pandit > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller > ; Kirti Wankhede ; Cornelia > Huck ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cj

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Friday, August 23, 2019 10:47 PM > To: Parav Pandit > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller > ; Kirti Wankhede ; Cornelia > Huck ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cj

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Friday, August 23, 2019 9:22 PM > To: Parav Pandit > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller > ; Kirti Wankhede ; Cornelia > Huck ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cj

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Friday, August 23, 2019 7:58 PM > To: Parav Pandit > Cc: Jiri Pirko ; Jiri Pirko ; David S . > Miller > ; Kirti Wankhede ; Cornelia > Huck ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cj

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-23 Thread Parav Pandit
Hi Alex, > -Original Message- > From: Jiri Pirko > Sent: Friday, August 23, 2019 1:42 PM > To: Parav Pandit > Cc: Alex Williamson ; Jiri Pirko > ; David S . Miller ; Kirti > Wankhede ; Cornelia Huck ; > k...@vger.kernel.org; linux-kernel@vger.kernel.org; cjia ;

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-22 Thread Parav Pandit
> -Original Message- > From: Jiri Pirko > Sent: Thursday, August 22, 2019 5:50 PM > To: Parav Pandit > Cc: Alex Williamson ; Jiri Pirko > ; David S . Miller ; Kirti > Wankhede ; Cornelia Huck ; > k...@vger.kernel.org; linux-kernel@vger.kernel.org; cjia ;

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-22 Thread Parav Pandit
> -Original Message- > From: Jiri Pirko > Sent: Thursday, August 22, 2019 3:28 PM > To: Parav Pandit > Cc: Alex Williamson ; Jiri Pirko > ; David S . Miller ; Kirti > Wankhede ; Cornelia Huck ; > k...@vger.kernel.org; linux-kernel@vger.kernel.org; cjia ;

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-22 Thread Parav Pandit
> -Original Message- > From: Jiri Pirko > Sent: Thursday, August 22, 2019 2:59 PM > To: Parav Pandit > Cc: Alex Williamson ; Jiri Pirko > ; David S . Miller ; Kirti > Wankhede ; Cornelia Huck ; > k...@vger.kernel.org; linux-kernel@vger.kernel.org; cjia ;

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-21 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 10:56 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 10:27 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 9:51 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 20, 2019 11:25 PM > To: Alex Williamson > Cc: Parav Pandit ; Jiri Pirko ; > David S . Miller ; Kirti Wankhede > ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cjia ; net...@vger.

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 20, 2019 10:49 PM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 20, 2019 10:01 PM > > > > Option-1: mdev index > > > > Introduce an optional mdev index/handle as u32 during mdev create > time. > > > > User passes mdev index/handle as input. > > > > > > > > phys_port_name=mIndex=m%u

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Christophe de Dinechin > Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core > > > Parav Pandit writes: > > > + Dave. > > > > Hi Jiri, Dave, Alex, Kirti, Cornelia, > > > > Please provide your

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
egards, Parav Pandit > -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Wednesday, August 14, 2019 9:51 PM > To: Alex Williamson > Cc: Cornelia Huck ; Kirti Wankhede > ; k...@vger.kernel.org; linux-

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-14 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 14, 2019 8:28 PM > To: Parav Pandit > Cc: Cornelia Huck ; Kirti Wankhede > ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; c...@nvidia.com; Jiri Pirko ; > net...@vger.kernel.org &g

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-14 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Wednesday, August 14, 2019 6:39 PM > To: Parav Pandit > Cc: Alex Williamson ; Kirti Wankhede > ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; c...@nvidia.com; Jiri Pirko ; > net...@vger.kernel.org &g

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-14 Thread Parav Pandit
+ Jiri, + netdev To get perspective on the ndo->phys_port_name for the representor netdev of mdev. Hi Cornelia, > -Original Message- > From: Cornelia Huck > Sent: Wednesday, August 14, 2019 1:32 PM > To: Parav Pandit > Cc: Alex Williamson ; Kirti Wankhede > ;

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-13 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 13, 2019 10:42 PM > To: Parav Pandit > Cc: Kirti Wankhede ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; coh...@redhat.com; c...@nvidia.com > Subject: Re: [PATCH v2 0/2] Simplify mtty

  1   2   3   4   5   6   7   >