[PATCH] platform/chrome: cros_usbpd_notify: Listen to EC_HOST_EVENT_USB_MUX host event

2021-04-14 Thread Pi-Hsun Shih
]: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/heads/chromeos-2016.05/src/ec/google/chromeec/acpi/ec.asl#382 Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_usbpd_notify.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v8 2/2] soc: mediatek: add mt6779 devapc driver

2021-01-14 Thread Pi-Hsun Shih
Hi Neal, Please see inline comments below. On Thu, Oct 15, 2020 at 11:21 AM Neal Liu wrote: > > MediaTek bus fabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violation is logged and sent to the

Re: [PATCH v2 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2021-01-10 Thread Pi-Hsun Shih
gentle ping on these two patches for EC_REBOOT_COLD_AP_OFF. On Mon, Dec 21, 2020 at 12:12 PM Pi-Hsun Shih wrote: > > Add cold-ap-off to ChromeOS EC sysfs reboot file option, corresponds to > the EC_REBOOT_COLD_AP_OFF flag, that will reset EC and keep AP off. > > Signed-off-b

[PATCH v2 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2020-12-20 Thread Pi-Hsun Shih
Add cold-ap-off to ChromeOS EC sysfs reboot file option, corresponds to the EC_REBOOT_COLD_AP_OFF flag, that will reset EC and keep AP off. Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.

2020-12-20 Thread Pi-Hsun Shih
Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP. Signed-off-by: Pi-Hsun Shih --- include/linux/platform_data/cros_ec_commands.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h

[PATCH 2/2] platform/chrome: cros_ec_sysfs: Add cold-ap-off to sysfs reboot.

2020-12-17 Thread Pi-Hsun Shih
Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c index f521a5c65091..8210fb10e839 100644 --- a/drivers/platform/chrome

[PATCH 1/2] platform/chrome: cros_ec: Add host command to keep AP off after EC reset.

2020-12-17 Thread Pi-Hsun Shih
Add command to EC_CMD_REBOOT_EC to reset EC but don't boot AP. Signed-off-by: Pi-Hsun Shih --- The corresponding changes in ChromeOS EC firmware is at crrev.com/c/2428361 --- include/linux/platform_data/cros_ec_commands.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux

Re: [PATCH] drm/bridge: anx7625: Add anx7625 port switching.

2020-11-12 Thread Pi-Hsun Shih
Hi Prashant, Please see inline reply as below. On Thu, Nov 12, 2020 at 4:59 PM Prashant Malani wrote: > > Hi Pi-Hsun, > > I haven't gone through the code, but did have a high-level comment > (kindly see inline) > > On Thu, Nov 12, 2020 at 02:40:40PM +0800, Pi-Hsun Shih wro

[PATCH] drm/bridge: anx7625: Add anx7625 port switching.

2020-11-11 Thread Pi-Hsun Shih
the two ports currently has DP enabled. Signed-off-by: Pi-Hsun Shih This is an attempt to use typec framework with how we're using anx7625 on Chrome OS asurada board. An example of the dts for the two ports case can be found

[PATCH] regulator: core: don't disable regulator if is_enabled return error.

2020-11-05 Thread Pi-Hsun Shih
In regulator_late_cleanup when is_enabled failed, don't try to disable the regulator since it would likely to fail too and causing confusing error messages. Signed-off-by: Pi-Hsun Shih --- This is encountered while using drivers/regulator/cros-ec-regulator.c. Since the driver controls

[PATCH v4] remoteproc/mediatek: Add support for mt8192 SCP

2020-10-14 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v3: * Remove unnecessary barrier and readl in mt8192_scp_before_load, which also fixes build failure on linux-next because of COMPILE_TEST trying to compile this on other platforms. Change

Re: [PATCH v3] drm/bridge: add it6505 driver

2020-09-23 Thread Pi-Hsun Shih
On Fri, Sep 4, 2020 at 10:17 AM allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes

[PATCH v3] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-21 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v2: * Inline scp_reset_assert / scp_reset_deassert. Change since v1: * Remove unused register definitions. --- drivers/remoteproc/mtk_common.h | 32 + drivers/remoteproc/mtk_scp.c

[PATCH v2] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-18 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih Reviewed-by: Tzung-Bi Shih --- Change since v1: * Remove unused register definitions. --- drivers/remoteproc/mtk_common.h | 32 + drivers/remoteproc/mtk_scp.c | 207 ++- drivers/remoteproc

[PATCH] remoteproc/mediatek: Add support for mt8192 SCP

2020-09-17 Thread Pi-Hsun Shih
Add support for mt8192 SCP. Signed-off-by: Pi-Hsun Shih --- drivers/remoteproc/mtk_common.h | 34 + drivers/remoteproc/mtk_scp.c | 207 ++- drivers/remoteproc/mtk_scp_ipi.c | 5 +- 3 files changed, 213 insertions(+), 33 deletions(-) diff --git a/drivers

Re: [PATCH v2] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
On Wed, Sep 9, 2020 at 4:58 PM Matthias Brugger wrote: > > > > On 09/09/2020 10:14, Pi-Hsun Shih wrote: > > Add scp node to mt8183-kukui > > > > Fixes: 0d5e41709f76 ("arm64: dts: mt8183: add scp node") > > Signed-off-by: Pi-Hsun Shih > &

Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node

2020-09-09 Thread Pi-Hsun Shih
On Wed, Sep 9, 2020 at 3:37 PM Jon Hunter wrote: > > > On 02/09/2020 17:23, Krzysztof Kozlowski wrote: > > On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju > > wrote: > >> > >> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger > >> wrote: > >

[PATCH v2] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
Add scp node to mt8183-kukui Fixes: 0d5e41709f76 ("arm64: dts: mt8183: add scp node") Signed-off-by: Pi-Hsun Shih --- Change since v1: * Add Fixes tag. --- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/

[PATCH] arm64: dts: mt8183-kukui: add scp node

2020-09-09 Thread Pi-Hsun Shih
Add scp node to mt8183-kukui Signed-off-by: Pi-Hsun Shih --- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index f0a070535b34

[PATCH] regulator: cros-ec-regulator: Fix double free of desc->name.

2020-07-28 Thread Pi-Hsun Shih
The desc->name field is allocated with devm_kstrdup, but is also kfreed on the error path, causing it to be double freed. Remove the kfree on the error path. Fixes: 8d9f8d57e023 ("regulator: Add driver for cros-ec-regulator") Signed-off-by: Pi-Hsun Shih --- drivers/regulator/cros-e

[PATCH] platform/chrome: cros_ec: Fix host command for regulator control.

2020-07-24 Thread Pi-Hsun Shih
mmand for regulator control.") Signed-off-by: Pi-Hsun Shih --- The original numbers were chosen before the 0x012B is used in ChromeOS EC codebase. Since the original kernel patch got accepted before the corresponding commit in ChromeOS EC codebase got merged, the host command number was used by other co

[PATCH] scripts/decode_stacktrace: Strip basepath from all paths.

2020-07-20 Thread Pi-Hsun Shih
ripts/decode_stacktrace: match basepath using shell prefix operator, not regex") Signed-off-by: Pi-Hsun Shih Co-developed-by: Shik Chen Signed-off-by: Shik Chen --- scripts/decode_stacktrace.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/decode_stacktrace.sh

Re: [PATCH] regulator: cros-ec: Constify cros_ec_regulator_voltage_ops

2020-07-13 Thread Pi-Hsun Shih
Acked-by: Pi-Hsun Shih On Sat, Jul 11, 2020 at 7:44 PM Rikard Falkeborn wrote: > > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/regulator/cros-ec-regulator.c | 2 +-

Re: [PATCH 12/21] iommu/mediatek: Add iova reserved function

2020-07-13 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote: > > For multiple iommu_domains, we need to reserve some iova regions, so we > will add mtk_iommu_iova_region structure. It includes the base address > and size of the range. > This is a preparing patch for supporting multi-domain. > > Signed-off-by:

Re: [PATCH 11/21] iommu/mediatek: Add power-domain operation

2020-07-13 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote: > > In the previous SoC, the M4U HW is in the EMI power domain which is > always on. the latest M4U is in the display power domain which may be > turned on/off, thus we have to add pm_runtime interface for it. > > we should enable its power before

Re: [PATCH 01/21] dt-binding: memory: mediatek: Add a common larb-port header file

2020-07-12 Thread Pi-Hsun Shih
On Mon, Jul 13, 2020 at 2:06 AM Matthias Brugger wrote: > > > > On 11/07/2020 08:48, Yong Wu wrote: > > Put all the macros about smi larb/port togethers, this is a preparing > > patch for extending LARB_NR and adding new dom-id support. > > > > Signed-off-by: Yong Wu > > --- > >

Re: [PATCH 04/21] dt-binding: mediatek: Add binding for mt8192 IOMMU and SMI

2020-07-12 Thread Pi-Hsun Shih
On Sat, Jul 11, 2020 at 2:50 PM Yong Wu wrote: > > This patch adds decriptions for mt8192 IOMMU and SMI. > > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation > table format. The M4U-SMI HW diagram is as below: > > EMI >

[PATCH v6 3/3] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih Reviewed-by: Prashant Malani Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * Move

[PATCH v6 0/3] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
Kconfig description about compiling as module. Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (3): dt-bindings: regulator: Add DT

[PATCH v6 1/3] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * No change Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes

[PATCH v6 2/3] platform/chrome: cros_ec: Add command for regulator control.

2020-06-11 Thread Pi-Hsun Shih
Add host commands for voltage regulator control through ChromeOS EC. Signed-off-by: Pi-Hsun Shih Reviewed-by: Enric Balletbo i Serra --- Changes from v5: * Extract into a separate patch. --- drivers/platform/chrome/cros_ec_trace.c | 5 ++ .../linux/platform_data/cros_ec_commands.h

[PATCH v5 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes

[PATCH v5 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v4: * Change compatible name from regulator-cros-ec to cros-ec-regulator. Changes from v3: * Fix dt bindings file name. * Add full example. Changes

[PATCH v5 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../regulator/google,cros-ec-regulator.yaml

[PATCH v4 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v3: * Fix dt bindings file name. * Add full example. Changes from v2: * No change Changes from v1: * Change compatible string to google,regulator-cros

[PATCH v4 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v3: * Remove check around CONFIG_OF. * Add new host commands to cros_ec_trace. * Use

[PATCH v4 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-11 Thread Pi-Hsun Shih
. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../regulator/google,cros-ec-regulator.yaml | 51 drivers/platform/chrome/cros_ec_trace.c | 5 + drivers/regulator

Re: [PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

2020-06-11 Thread Pi-Hsun Shih
Thanks for the review, would address most of them in v4. An inline reply as below: On Thu, Jun 11, 2020 at 12:47 AM Enric Balletbo i Serra wrote: > > Hi Pi-Hsun, > > Thank you for your patch. > > On 10/6/20 11:07,

[PATCH v3 2/2] regulator: Add driver for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- Changes from v2: * Add 'depends on OF' to Kconfig. * Add Kconfig description about compiling

[PATCH v3 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- Changes from v2: * No change Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt

[PATCH v3 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-10 Thread Pi-Hsun Shih
compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec

[PATCH v2 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Changes from v1: * Change compatible string to google,regulator-cros-ec. * Use reg property in device tree. * Change license for dt binding according to checkpatch.pl. Signed-off-by: Pi-Hsun Shih

[PATCH v2 2/2] regulator: Add driver for cros-ec-regulator

2020-06-10 Thread Pi-Hsun Shih
on code styles. Signed-off-by: Pi-Hsun Shih --- This patch contains function cros_ec_cmd that is copied from the series: https://lore.kernel.org/patchwork/project/lkml/list/?series=428457. I can't find the first patch in that v2 series, so the function is modified from v1 of that series according

[PATCH v2 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-10 Thread Pi-Hsun Shih
binding according to checkpatch.pl. * Address comments on code styles. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator .../bindings/regulator/cros-ec-regulator.yaml | 43 +++ drivers/regulator/Kconfig

Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Thanks for the review, some inline reply: On Tue, Jun 9, 2020 at 7:19 PM Mark Brown wrote: > > On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote: > > > +static int cros_ec_regulator_set_state(struct regulator_dev *dev, bool > > enable) > > +{ > > +

[PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- This patch contains function cros_ec_cmd that is copied from the series: https://lore.kernel.org

[PATCH 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Add DT binding documentation for cros-ec-regulator, a voltage regulator controlled by ChromeOS EC. Signed-off-by: Pi-Hsun Shih --- .../bindings/regulator/cros-ec-regulator.yaml | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 0/2] Add support for voltage regulator on ChromeOS EC.

2020-06-09 Thread Pi-Hsun Shih
Add support for controlling voltage regulator that is connected and controlled by ChromeOS EC. Kernel controls these regulators through newly added EC host commands. Pi-Hsun Shih (2): dt-bindings: regulator: Add DT binding for cros-ec-regulator regulator: Add driver for cros-ec-regulator

Re: [PATCH v5 3/3] PM / AVS: SVS: Introduce SVS engine

2019-10-21 Thread Pi-Hsun Shih
Hi Roger, On Fri, Sep 6, 2019 at 6:06 PM Roger Lu wrote: > ... > +static int svs_resource_setup(struct mtk_svs *svs) > ... > + for (i = 0, freq = (u32)-1; i < svsb->opp_count; i++, freq--) > { > + opp = dev_pm_opp_find_freq_floor(svsb->dev, ); > +

[PATCH] arm64: dts: mt8183: add dpi node to mt8183

2019-10-15 Thread Pi-Hsun Shih
Add dpi node to mt8183. Signed-off-by: Jitao Shi Signed-off-by: Pi-Hsun Shih --- This depends on https://patchwork.kernel.org/cover/11081047/ (for the dpi driver on mt8183) and https://patchwork.kernel.org/cover/8371/ (for the scpsys node). --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 11

[PATCH v20 3/4] rpmsg: add rpmsg support for mt8183 SCP.

2019-10-14 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v19: - Fix an incorrect include in mtk_rpmsg.h (linux/device.h -> linux/platform_device.h) Changes from v18: - No change. Changes from v17: - Mark mtk_rpmsg_{prep

[PATCH v20 4/4] arm64: dts: mt8183: add scp node

2019-10-14 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v19 ... v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12 ... v10: - No change

[PATCH v20 2/4] remoteproc/mediatek: add SCP support for mt8183

2019-10-14 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v19: - No change. Changes from v18: - Use of_reserved_mem_device_init_by_idx() to hook the scp device to DMA mapping

[PATCH v20 1/4] dt-bindings: Add a binding for Mediatek SCP

2019-10-14 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v19 ... v6: - No change. Changes from v5: - Remove dependency on CONFIG_RPMSG_MTK_SCP. Changes from v4

[PATCH v20 0/4] Add support for mt8183 SCP.

2019-10-14 Thread Pi-Hsun Shih
n feedback for cros_ec_rpmsg.c. - Extract feature detection for SCP into separate patch (Patch 6). Eddie Huang (1): arm64: dts: mt8183: add scp node Erin Lo (2): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih (1): rpmsg: add rpm

[PATCH v19 2/4] remoteproc/mediatek: add SCP support for mt8183

2019-09-05 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v18: - Use of_reserved_mem_device_init_by_idx() to hook the scp device to DMA mapping API to provide a shared dma pool

[PATCH v19 0/4] Add support for mt8183 SCP.

2019-09-05 Thread Pi-Hsun Shih
uang (1): arm64: dts: mt8183: add scp node Erin Lo (2): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,scp.txt | 36 ++ arch/arm64/boot/dts/mediatek

[PATCH v19 1/4] dt-bindings: Add a binding for Mediatek SCP

2019-09-05 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v18, v17, v16, v15, v14, v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency

[PATCH v19 4/4] arm64: dts: mt8183: add scp node

2019-09-05 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v18, v17, v16, v15, v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10

[PATCH v19 3/4] rpmsg: add rpmsg support for mt8183 SCP.

2019-09-05 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v18: - No change. Changes from v17: - Mark mtk_rpmsg_{prepare,unprepare,stop} as static. Changes from v16: - Change year on another Copyright header to 2019. Changes from

[PATCH v18 5/5] arm64: dts: mt8183: add scp node

2019-09-04 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v17, v16, v15, v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10: - No change

[PATCH v18 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v17, v16, v15, v14, v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency

[PATCH v18 3/5] remoteproc: mt8183: add reserved memory manager API

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v17, v16, v15: - No change. Changes from v14: - Fix a typo in variable name in DEBUG section. Changes from v13

[PATCH v18 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v17: - Fix mixture use of __iomem found by sparse. - Change the ipi handler to take a u32 instead of enum scp_ipi_id

[PATCH v18 0/5] Add support for mt8183 SCP.

2019-09-04 Thread Pi-Hsun Shih
binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,scp.txt | 36 + arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11

[PATCH v18 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-09-04 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v17: - Mark mtk_rpmsg_{prepare,unprepare,stop} as static. Changes from v16: - Change year on another Copyright header to 2019. Changes from v15: - No change. Changes from

[PATCH] platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed.

2019-09-04 Thread Pi-Hsun Shih
no more new calls to cros_ec_rpmsg_callback), and then cancel all works in the host_event_work workqueue. Fixes: 2de89fd98958 ("platform/chrome: cros_ec: Add EC host command support using rpmsg") Signed-off-by: Pi-Hsun Shih --- drivers/platform/chrome/cros_ec_rpmsg.c | 33 ++

[PATCH v17 3/5] remoteproc: mt8183: add reserved memory manager API

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v16, v15: - No change. Changes from v14: - Fix a typo in variable name in DEBUG section. Changes from v13: - Add

[PATCH v17 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-09-04 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v16: - Change year on another Copyright header to 2019. Changes from v15: - No change. Changes from v14: - Change year on Copyright header to 2019. Changes from v13

[PATCH v17 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v16: - Change the desc_lock mutex to be a per-id lock. - Put the execution of handler inside the per-id lock, to prevent

[PATCH v17 5/5] arm64: dts: mt8183: add scp node

2019-09-04 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v16, v15, v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10: - No change

[PATCH v17 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-09-04 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v16, v15, v14, v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency

[PATCH v17 0/5] Add support for mt8183 SCP.

2019-09-04 Thread Pi-Hsun Shih
eparate patch (Patch 6). Eddie Huang (1): arm64: dts: mt8183: add scp node Erin Lo (3): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8

Re: [PATCH] platform/chrome: cros_ec_rpmsg: Add host command AP sleep state support

2019-08-26 Thread Pi-Hsun Shih
Tested that with this patch, SCP does receive host command from AP while AP goes to suspend and back. Tested-by: Pi-Hsun Shih On Fri, Aug 23, 2019 at 3:36 AM Enric Balletbo i Serra wrote: > > Hi, > > On 14/8/19 10:17, Yilun Lin wrote: > > Add EC host command to inform EC of

[PATCH v16 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-08-15 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v15: - No change. Changes from v14: - Change year on Copyright header to 2019. Changes from v13: - No change. Changes from v12: - Use strscpy instead of strncpy. Changes

[PATCH v16 5/5] arm64: dts: mt8183: add scp node

2019-08-15 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v15, v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10: - No change. Changes

[PATCH v16 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-08-15 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v15: - Fix a bug on incorrect usage of wait_event_timeout return value. Changes from v14: - No change. Changes from

[PATCH v16 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-08-15 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v15, v14, v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency

[PATCH v16 3/5] remoteproc: mt8183: add reserved memory manager API

2019-08-15 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v15: - No change. Changes from v14: - Fix a typo in variable name in DEBUG section. Changes from v13: - Add one

[PATCH v16 0/5] Add support for mt8183 SCP.

2019-08-15 Thread Pi-Hsun Shih
Extract feature detection for SCP into separate patch (Patch 6). Eddie Huang (1): arm64: dts: mt8183: add scp node Erin Lo (3): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun

[PATCH v15 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-08-07 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v14, v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency

[PATCH v15 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-08-07 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v14: - No change. Changes from v13: - Move include/linux/platform_data/mtk_scp.h to include/linux/remoteproc

[PATCH v15 5/5] arm64: dts: mt8183: add scp node

2019-08-07 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v14: - No change. Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10: - No change. Changes from

[PATCH v15 3/5] remoteproc: mt8183: add reserved memory manager API

2019-08-07 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v14: - Fix a typo in variable name in DEBUG section. Changes from v13: - Add one more reserved region. - Rename

[PATCH v15 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-08-07 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v14: - Change year on Copyright header to 2019. Changes from v13: - No change. Changes from v12: - Use strscpy instead of strncpy. Changes from v11: - Fix a bug that when

[PATCH v15 0/5] Add support for mt8183 SCP.

2019-08-07 Thread Pi-Hsun Shih
arm64: dts: mt8183: add scp node Erin Lo (3): dt-bindings: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,

[PATCH v14 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-08-05 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v13, v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency on CONFIG_RPMSG_MTK_SCP

[PATCH v14 0/5] Add support for mt8183 SCP.

2019-08-05 Thread Pi-Hsun Shih
gs: Add a binding for Mediatek SCP remoteproc/mediatek: add SCP support for mt8183 remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,scp.txt | 36 + arch/arm64/boot/dts/mediatek/mt8183-evb.dts

[PATCH v14 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-08-05 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v13: - No change. Changes from v12: - Use strscpy instead of strncpy. Changes from v11: - Fix a bug that when rproc_boot fails, the ns_ept won't be properly destroyed

[PATCH v14 5/5] arm64: dts: mt8183: add scp node

2019-08-05 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v13: - Change the size of the cfg register region. Changes from v12, v11, v10: - No change. Changes from v9: - Remove extra reserve

[PATCH v14 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-08-05 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v13: - Move include/linux/platform_data/mtk_scp.h to include/linux/remoteproc/mtk_scp.h. - Add lock for access of scp

[PATCH v14 3/5] remoteproc: mt8183: add reserved memory manager API

2019-08-05 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v13: - Add one more reserved region. - Rename scp_get_reserve_* to scp_get_reserved_*. - Minor fixes addressing

Re: [PATCH v13 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-08-05 Thread Pi-Hsun Shih
Thanks for the review. I'll address most of the comments in the next version. On Mon, Jul 22, 2019 at 5:37 PM Alexandre Courbot wrote: > > Hi Pi-Hsun, > > On Tue, Jul 9, 2019 at 4:27 PM Pi-Hsun Shih wrote: > > +static void *scp_da_to_va(struct rproc *rpro

[PATCH v13 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-07-09 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v12: - Initialize cache before firmware load, to avoid problem while loading large firmware. - Disable watchdog

[PATCH v13 4/5] rpmsg: add rpmsg support for mt8183 SCP.

2019-07-09 Thread Pi-Hsun Shih
Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly. Signed-off-by: Pi-Hsun Shih --- Changes from v12: - Use strscpy instead of strncpy. Changes from v11: - Fix a bug that when rproc_boot fails, the ns_ept won't be properly destroyed, causing memory leak. - Add

[PATCH v13 5/5] arm64: dts: mt8183: add scp node

2019-07-09 Thread Pi-Hsun Shih
From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang --- Changes from v12, v11, v10: - No change. Changes from v9: - Remove extra reserve-memory-vpu_share node. Changes from v8: - New patch. --- arch/arm64

[PATCH v13 1/5] dt-bindings: Add a binding for Mediatek SCP

2019-07-09 Thread Pi-Hsun Shih
From: Erin Lo Add a DT binding documentation of SCP for the MT8183 SoC from Mediatek. Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Reviewed-by: Rob Herring --- Changes from v12, v11, v10, v9, v8, v7, v6: - No change. Changes from v5: - Remove dependency on CONFIG_RPMSG_MTK_SCP

[PATCH v13 3/5] remoteproc: mt8183: add reserved memory manager API

2019-07-09 Thread Pi-Hsun Shih
From: Erin Lo Add memory table mapping API for other driver to lookup reserved physical and virtual memory Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih --- Changes from v12: - Reformat a line to fit 80 character width. Changes from v11: - No change. Changes from v10: - Fix some

[PATCH v13 0/5] Add support for mt8183 SCP.

2019-07-09 Thread Pi-Hsun Shih
add reserved memory manager API Pi-Hsun Shih (1): rpmsg: add rpmsg support for mt8183 SCP. .../bindings/remoteproc/mtk,scp.txt | 36 + arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 + arch/arm64/boot/dts/mediatek/mt8183.dtsi | 12 + drivers/remoteproc/Kco

[PATCH v12 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-07-02 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v11: - No change. Changes from v10: - Add a clock reset before loading firmware. Changes from v9: - No change

  1   2   3   >