[PATCH] HID: steam: fix deadlock with input devices.

the mutex when calling any function that sends commands to the controller. If not, random commands end up falling fail. Reported-by: Simon Gene Gottlieb Signed-off-by: Rodrigo Rivas Costa Tested-by: Simon Gene Gottlieb --- drivers/hid/hid-steam.c | 26 +++--- 1 file changed, 19

Re: [PATCH] Input: uinput - Allow uinput_request to be interrupted

On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote: > - if (!wait_for_completion_timeout(>done, 30 * HZ)) { > + if (!wait_for_completion_interruptible_timeout(>done, > + 30 * HZ)) { > retval = -ETIMEDOUT;

[PATCH] HID: steam: fix boot loop with bluetooth firmware.

. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index dc4128bfe2ca..8141cadfca0e 100644 --- a/drivers/hid/hid-steam.c +++ b

[PATCH] HID: steam: remove input device when a hid client is running.

. Other games just crashed, probably a bug in Unity [1]. With this commit, when a HID client starts, the input device is removed; when the HID client ends the input device is recreated. [1]: https://github.com/ValveSoftware/steam-for-linux/issues/5645 Signed-off-by: Rodrigo Rivas Costa

[PATCH] HID: steam: remove input device when a hid client is running.

. Other games just crashed, probably a bug in Unity [1]. With this commit, when a HID client starts, the input device is removed; when the HID client ends the input device is recreated. [1]: https://github.com/ValveSoftware/steam-for-linux/issues/5645 Signed-off-by: Rodrigo Rivas Costa

Re: [PATCH] HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

Hi, all! Could you check my previous patch to see if it makes any sense? My machine currently crashes without it, but I'm not sure why. If you think it is worth it I can try and bisect it. Regards -- Rodrigo Rivas Costa. On Tue, May 22, 2018 at 10:10:06PM +0200, Rodrigo Rivas Costa wrote

Re: [PATCH] HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

Hi, all! Could you check my previous patch to see if it makes any sense? My machine currently crashes without it, but I'm not sure why. If you think it is worth it I can try and bisect it. Regards -- Rodrigo Rivas Costa. On Tue, May 22, 2018 at 10:10:06PM +0200, Rodrigo Rivas Costa wrote

[PATCH] HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

() is for users "avobe" this hid_device, while hid_device.driver_data it for users "below" this one. In this case, we are creating a virtual hidraw device, so we must use hid_device.driver_data. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- This patch

[PATCH] HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

() is for users "avobe" this hid_device, while hid_device.driver_data it for users "below" this one. In this case, we are creating a virtual hidraw device, so we must use hid_device.driver_data. Signed-off-by: Rodrigo Rivas Costa --- This patch is to be applied over hi

Re: linux-next: Signed-off-by missing for commit in the hid tree

unsure about what is to be done now. Should I resubmit the patch? Or can it be amended any other way? Or it is not a big deal anyway? Best regards. -- Rodrigo Rivas Costa > > -- > Cheers, > Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the hid tree

unsure about what is to be done now. Should I resubmit the patch? Or can it be amended any other way? Or it is not a big deal anyway? Best regards. -- Rodrigo Rivas Costa > > -- > Cheers, > Stephen Rothwell

Re: [PATCH v9 0/2] hid-steam driver with user mode client dection

On Fri, May 04, 2018 at 10:12:51AM +0200, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Rodrigo Rivas Costa wrote: > > > Hello! This is reroll v9 of the Steam Controller driver. > > > > @Pierre-Loup, @Clément, could you please check if this driver is acceptable > > by

Re: [PATCH v9 0/2] hid-steam driver with user mode client dection

On Fri, May 04, 2018 at 10:12:51AM +0200, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Rodrigo Rivas Costa wrote: > > > Hello! This is reroll v9 of the Steam Controller driver. > > > > @Pierre-Loup, @Clément, could you please check if this driver is acceptable > > by

[PATCH v9 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa <rodrigoriva

[PATCH v9 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid

[PATCH v9 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index

[PATCH v9 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index

[PATCH v9 0/2] hid-steam driver with user mode client dection

cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig |8 + drivers/hid/Makefile|1 + drivers/hid/hid-ids.h |4 + drivers/hid/hid-steam.c | 1112 +++ include

[PATCH v9 0/2] hid-steam driver with user mode client dection

cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig |8 + drivers/hid/Makefile|1 + drivers/hid/hid-ids.h |4 + drivers/hid/hid-steam.c | 1112 +++ include

[PATCH] hidraw: Fix crash on HIDIOCGFEATURE with a destroyed device

s work, but `hidraw_get_report()` was missing that check. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hidraw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 5fbe0f81ab2e..01b5a9f01814 100644 --- a/drivers/hid/hi

[PATCH] hidraw: Fix crash on HIDIOCGFEATURE with a destroyed device

s work, but `hidraw_get_report()` was missing that check. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hidraw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 5fbe0f81ab2e..01b5a9f01814 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hi

[PATCH v8 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c

[PATCH v8 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c

[PATCH v8 0/2] hid-steam driver with user mode client dection

. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig |8 + drivers/hid/Makefile|1 + drivers/hid/hid-ids.h |4 + drivers/hid/hid-steam.c | 1112

[PATCH v8 0/2] hid-steam driver with user mode client dection

. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig |8 + drivers/hid/Makefile|1 + drivers/hid/hid-ids.h |4 + drivers/hid/hid-steam.c | 1112

[PATCH v8 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa <rodrigoriva

[PATCH v8 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

On Wed, Mar 28, 2018 at 08:14:48PM +0200, Rodrigo Rivas Costa wrote: > On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote: > > Also, I think there will be races if a user changes the value of the > > parameter while running the system. You might want to add an >

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

On Wed, Mar 28, 2018 at 08:14:48PM +0200, Rodrigo Rivas Costa wrote: > On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote: > > Also, I think there will be races if a user changes the value of the > > parameter while running the system. You might want to add an >

Re: [PATCH v7 1/2] HID: add driver for Valve Steam Controller

On Mon, Mar 26, 2018 at 11:20:30AM +0200, Benjamin Tissoires wrote: > Hi Rodrigo, > > few comments inlined. > > On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > There are two ways to connect the Steam C

Re: [PATCH v7 1/2] HID: add driver for Valve Steam Controller

On Mon, Mar 26, 2018 at 11:20:30AM +0200, Benjamin Tissoires wrote: > Hi Rodrigo, > > few comments inlined. > > On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa > wrote: > > There are two ways to connect the Steam Controller: directly to the USB > > or with t

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote: > Hi Rodrigo, > > On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > This is a reroll of the Steam Controller driver. > > > > This time the client

Re: [PATCH v7 0/2] hid-steam driver with user mode client dection

On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote: > Hi Rodrigo, > > On Sun, Mar 25, 2018 at 6:07 PM, Rodrigo Rivas Costa > wrote: > > This is a reroll of the Steam Controller driver. > > > > This time the client usage is detected by using expos

[PATCH v7 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa <rodrigoriva

[PATCH v7 1/2] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using hidraw and a creates a uinput virtual gamepad and XTest keyboard/mouse. This driver intercepts the hidraw usage, so it can get out of the way when the Steam Client is in use. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid

[PATCH v7 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 140 +++- 1 file changed, 139 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c

[PATCH v7 0/2] hid-steam driver with user mode client dection

in case of corrupt/malicius USB devices. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h

[PATCH v7 2/2] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. --- drivers/hid/hid-steam.c | 140 +++- 1 file changed, 139 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c

[PATCH v7 0/2] hid-steam driver with user mode client dection

in case of corrupt/malicius USB devices. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (2): HID: add driver for Valve Steam Controller HID: steam: add battery device. drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h

[RFC PATCH v6 1/1] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using direct USB access and a creates a uinput virtual gamepad. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h

[RFC PATCH v6 1/1] HID: add driver for Valve Steam Controller

/SteamBox Valve Steam Client provices a software translation by using direct USB access and a creates a uinput virtual gamepad. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h | 4 + drivers/hid/hid-steam.c | 874

[RFC PATCH v6 0/1] hid-steam driver with user mode client dection

collapsed the patch-set into a single bigger commit, because my original split makes sense no longer. Sorry for the inconvenience. Thank you in advance for any comment. Rodrigo Rivas Costa (1): HID: add driver for Valve Steam Controller drivers/hid/Kconfig | 8 + drivers/hid/Makefil

[RFC PATCH v6 0/1] hid-steam driver with user mode client dection

collapsed the patch-set into a single bigger commit, because my original split makes sense no longer. Sorry for the inconvenience. Thank you in advance for any comment. Rodrigo Rivas Costa (1): HID: add driver for Valve Steam Controller drivers/hid/Kconfig | 8 + drivers/hid/Makefil

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Wed, Mar 21, 2018 at 04:47:53PM +0100, Benjamin Tissoires wrote: > Hi Rodrigo, > > On Mon, Mar 19, 2018 at 9:08 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > >>

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Wed, Mar 21, 2018 at 04:47:53PM +0100, Benjamin Tissoires wrote: > Hi Rodrigo, > > On Mon, Mar 19, 2018 at 9:08 PM, Rodrigo Rivas Costa > wrote: > > On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > >> > >> > >> On 0

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Mon, Mar 19, 2018 at 10:06:09PM +0100, Clément VUCHENER wrote: > 2018-03-19 21:08 GMT+01:00 Rodrigo Rivas Costa <rodrigorivasco...@gmail.com>: > > On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > > > > Now, what I would really want is a revie

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Mon, Mar 19, 2018 at 10:06:09PM +0100, Clément VUCHENER wrote: > 2018-03-19 21:08 GMT+01:00 Rodrigo Rivas Costa : > > On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > > > > Now, what I would really want is a review by Valve of my set

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > > > On 03/15/2018 02:06 PM, Rodrigo Rivas Costa wrote: > > On Wed, Mar 14, 2018 at 05:39:25PM +0100, Benjamin Tissoires wrote: > > > On Mon, Mar 12, 2018 at 9:51 PM, Rodrigo Rivas Costa > >

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Sat, Mar 17, 2018 at 02:54:07PM -0700, Pierre-Loup A. Griffais wrote: > > > On 03/15/2018 02:06 PM, Rodrigo Rivas Costa wrote: > > On Wed, Mar 14, 2018 at 05:39:25PM +0100, Benjamin Tissoires wrote: > > > On Mon, Mar 12, 2018 at 9:51 PM, Rodrigo Rivas Costa > >

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Wed, Mar 14, 2018 at 05:39:25PM +0100, Benjamin Tissoires wrote: > On Mon, Mar 12, 2018 at 9:51 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > On Mon, Mar 12, 2018 at 03:30:43PM +0100, Clément VUCHENER wrote: > >> 2018-03-11 20:58 GM

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Wed, Mar 14, 2018 at 05:39:25PM +0100, Benjamin Tissoires wrote: > On Mon, Mar 12, 2018 at 9:51 PM, Rodrigo Rivas Costa > wrote: > > On Mon, Mar 12, 2018 at 03:30:43PM +0100, Clément VUCHENER wrote: > >> 2018-03-11 20:58 GMT+01:00 Rodrigo Rivas Costa > >> : &

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Mon, Mar 12, 2018 at 03:30:43PM +0100, Clément VUCHENER wrote: > 2018-03-11 20:58 GMT+01:00 Rodrigo Rivas Costa <rodrigorivasco...@gmail.com>: > > This patchset implements a driver for Valve Steam Controller, based on a > > reverse analysis by myself. > > >

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Mon, Mar 12, 2018 at 03:30:43PM +0100, Clément VUCHENER wrote: > 2018-03-11 20:58 GMT+01:00 Rodrigo Rivas Costa : > > This patchset implements a driver for Valve Steam Controller, based on a > > reverse analysis by myself. > > > > Sorry, I've been out of town for a

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Sun, Mar 11, 2018 at 04:12:41PM -0700, Pierre-Loup A. Griffais wrote: > > > On 03/11/2018 12:58 PM, Rodrigo Rivas Costa wrote: > > This patchset implements a driver for Valve Steam Controller, based on a > > reverse analysis by myself. > > > > Sorry, I've

Re: [PATCH v5 0/4] new driver for Valve Steam Controller

On Sun, Mar 11, 2018 at 04:12:41PM -0700, Pierre-Loup A. Griffais wrote: > > > On 03/11/2018 12:58 PM, Rodrigo Rivas Costa wrote: > > This patchset implements a driver for Valve Steam Controller, based on a > > reverse analysis by myself. > > > > Sorry, I've

[PATCH v5 0/4] new driver for Valve Steam Controller

. Rodrigo Rivas Costa (4): HID: add driver for Valve Steam Controller HID: steam: add serial number information. HID: steam: command to check wireless connection HID: steam: add battery device. drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h | 4

[PATCH v5 0/4] new driver for Valve Steam Controller

. Rodrigo Rivas Costa (4): HID: add driver for Valve Steam Controller HID: steam: add serial number information. HID: steam: command to check wireless connection HID: steam: add battery device. drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1 + drivers/hid/hid-ids.h | 4

[PATCH v5 3/4] HID: steam: command to check wireless connection

The wireless adaptor does not tell if a device is already connected when steam_probe() is run. Use a command to request the connection status. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 16 1 file changed, 16 inse

[PATCH v5 3/4] HID: steam: command to check wireless connection

The wireless adaptor does not tell if a device is already connected when steam_probe() is run. Use a command to request the connection status. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/hid/hid

[PATCH v5 4/4] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 de

[PATCH v5 4/4] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid

[PATCH v5 1/4] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/Kconfig | 8 + d

[PATCH v5 1/4] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1

[PATCH v5 2/4] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 108 ++-- 1 file change

[PATCH v5 2/4] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 108 ++-- 1 file changed, 105 insertions(+), 3 deletions

Re: [PATCH v4 1/4] HID: add driver for Valve Steam Controller

On Thu, Mar 01, 2018 at 12:20:37PM +0200, Andy Shevchenko wrote: > On Thu, Mar 1, 2018 at 12:49 AM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > On Wed, Feb 28, 2018 at 09:21:15PM +0200, Andy Shevchenko wrote: > >> On Wed, Feb 28, 2018 at 8

Re: [PATCH v4 1/4] HID: add driver for Valve Steam Controller

On Thu, Mar 01, 2018 at 12:20:37PM +0200, Andy Shevchenko wrote: > On Thu, Mar 1, 2018 at 12:49 AM, Rodrigo Rivas Costa > wrote: > > On Wed, Feb 28, 2018 at 09:21:15PM +0200, Andy Shevchenko wrote: > >> On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > >> wrot

Re: [PATCH v4 2/4] HID: steam: add serial number information.

On Wed, Feb 28, 2018 at 10:17:50PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > This device has a feature report to send and receive commands. > > Use it to get the serial number and set

Re: [PATCH v4 2/4] HID: steam: add serial number information.

On Wed, Feb 28, 2018 at 10:17:50PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > wrote: > > This device has a feature report to send and receive commands. > > Use it to get the serial number and set the device's uniq value. > > &g

Re: [PATCH v4 1/4] HID: add driver for Valve Steam Controller

On Wed, Feb 28, 2018 at 09:21:15PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > There are two ways to connect the Steam Controller: directly to the USB > > or with the USB wireless adapter.

Re: [PATCH v4 1/4] HID: add driver for Valve Steam Controller

On Wed, Feb 28, 2018 at 09:21:15PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > wrote: > > There are two ways to connect the Steam Controller: directly to the USB > > or with the USB wireless adapter. Both methods are similar, bu

[PATCH v4 3/4] HID: steam: command to check wireless connection

The wireless adaptor does not tell if a device is already connected when steam_probe() is run. Use a command to request the connection status. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 16 1 file changed, 16 inse

[PATCH v4 4/4] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 de

[PATCH v4 3/4] HID: steam: command to check wireless connection

The wireless adaptor does not tell if a device is already connected when steam_probe() is run. Use a command to request the connection status. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/hid/hid

[PATCH v4 4/4] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid

[PATCH v4 0/4] new driver for Valve Steam Controller

(with a UDEV rule to disable the lizard mode) while the Steam Client is running works without any issue. [1]: https://github.com/rodrigorc/steamctrl Rodrigo Rivas Costa (4): HID: add driver for Valve Steam Controller HID: steam: add serial number information. HID: steam: command to check wireless

[PATCH v4 2/4] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 104 ++-- 1 file change

[PATCH v4 0/4] new driver for Valve Steam Controller

(with a UDEV rule to disable the lizard mode) while the Steam Client is running works without any issue. [1]: https://github.com/rodrigorc/steamctrl Rodrigo Rivas Costa (4): HID: add driver for Valve Steam Controller HID: steam: add serial number information. HID: steam: command to check wireless

[PATCH v4 2/4] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 104 ++-- 1 file changed, 101 insertions(+), 3 deletions

[PATCH v4 1/4] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/Kconfig | 8 + d

[PATCH v4 1/4] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1

Re: [PATCH v3 0/3] new driver for Valve Steam Controller

On Mon, Feb 26, 2018 at 12:24:21PM +0100, Clément VUCHENER wrote: > 2018-02-26 10:50 GMT+01:00 Benjamin Tissoires <benjamin.tissoi...@redhat.com>: > > Hi Rodrigo, > > > > On Sun, Feb 25, 2018 at 7:52 PM, Rodrigo Rivas Costa > > <rodrigorivasco...@gmail.com&g

Re: [PATCH v3 0/3] new driver for Valve Steam Controller

On Mon, Feb 26, 2018 at 12:24:21PM +0100, Clément VUCHENER wrote: > 2018-02-26 10:50 GMT+01:00 Benjamin Tissoires : > > Hi Rodrigo, > > > > On Sun, Feb 25, 2018 at 7:52 PM, Rodrigo Rivas Costa > > wrote: > >> This patchset implements a driver for Valve Steam

[PATCH v3 3/3] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 de

[PATCH v3 3/3] HID: steam: add battery device.

The wireless Steam Controller is battery operated, so add the battery device and power information. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 141 +++- 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/drivers/hid

[PATCH v3 1/3] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/Kconfig | 8 + d

[PATCH v3 2/3] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa <rodrigorivasco...@gmail.com> --- drivers/hid/hid-steam.c | 105 ++-- 1 file change

[PATCH v3 1/3] HID: add driver for Valve Steam Controller

, as they are not so useful when you have a working gamepad. Working: buttons, axes, pads, wireless connect/disconnect. TO-DO: Battery, force-feedback, accelerometer/gyro, led, beeper... Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/Kconfig | 8 + drivers/hid/Makefile| 1

[PATCH v3 2/3] HID: steam: add serial number information.

This device has a feature report to send and receive commands. Use it to get the serial number and set the device's uniq value. Signed-off-by: Rodrigo Rivas Costa --- drivers/hid/hid-steam.c | 105 ++-- 1 file changed, 102 insertions(+), 3 deletions

[PATCH v3 0/3] new driver for Valve Steam Controller

r the ones with feature reports. * Feature reports buffers are allocated with hid_alloc_report_buf(). * Feature report length is checked, to avoid overflows in case of corrupt/malicius USB devices. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (3): HID:

[PATCH v3 0/3] new driver for Valve Steam Controller

r the ones with feature reports. * Feature reports buffers are allocated with hid_alloc_report_buf(). * Feature report length is checked, to avoid overflows in case of corrupt/malicius USB devices. * Resolution added to the ABS axes. * A lot of minor cleanups. Rodrigo Rivas Costa (3): HID:

Re: [PATCH v2 1/3] HID: add driver for Valve Steam Controller

On Tue, Feb 20, 2018 at 09:32:08PM -0800, Cameron Gutman wrote: > On 02/20/2018 11:33 AM, Rodrigo Rivas Costa wrote: > > +static void steam_work_connect_cb(struct work_struct *work) > > +{ > > + struct steam_device *steam = container_of(work

Re: [PATCH v2 1/3] HID: add driver for Valve Steam Controller

On Tue, Feb 20, 2018 at 09:32:08PM -0800, Cameron Gutman wrote: > On 02/20/2018 11:33 AM, Rodrigo Rivas Costa wrote: > > +static void steam_work_connect_cb(struct work_struct *work) > > +{ > > + struct steam_device *steam = container_of(work

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Thu, Feb 22, 2018 at 06:06:30PM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa > <rodrigorivasco...@gmail.com> wrote: > > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > >> On Thu, Feb 22, 2018 at 1:13

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Thu, Feb 22, 2018 at 06:06:30PM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa > wrote: > > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > >> On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A.

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais > <pgriff...@valvesoftware.com> wrote: > > > > > > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: > >> > >> On Tu

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais > wrote: > > > > > > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: > >> > >> On Tue, Feb 20, 2018 at 04:09

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: > On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: > > On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: > > About the left trackpad/joystick, currently I'm not treating them > &g

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: > On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: > > On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: > > About the left trackpad/joystick, currently I'm not treating them > &g

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

On Wed, Feb 21, 2018 at 11:39:49AM +0100, Clément VUCHENER wrote: > Hi Rodrigo, Hello, Clément! > I have written a kernel driver [1], some time ago. I did not submit it > for merging in the main-line because I thought that would mess with > user-space drivers. If your driver create an input

  1   2   >