shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
Resending V3 with adding Fixes and cc tag.
This patch depends on both the below patches:
interconnect: qcom: Ensure that the floor bandwidth value is enforced
interconnect: qcom: Use icc_sync_state
Roja Rani Yarubandi (2):
soc: qcom-geni-se: Cleanup the code to remove proxy votes
arm64: dts
t;interconnect: qcom: Use icc_sync_state")
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
Reviewed-by: Matthias Kaehlcke
---
Changes in V3:
- As per Matthias comments, updated commit text with adding
icc sync_state and geni icc earlycon commits info
Changes in V2:
- No change
d
will ensure that the default bootloader votes are not removed until
all it's consumer are probed.
We can safely remove ICC path for QUP-CORE clock from QUP wrapper
device.
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
Reviewed-by: Matthias Kaehlcke
---
Changes in V3:
- No change
n above support from ICC there is no longer need to maintain
proxy votes on QUP-CORE ICC node from QUP wrapper driver for early
console usecase, the default votes won't be removed until real
console is probed.
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
Reviewed-by: Matthias K
will ensure that the default bootloader votes are not removed until
all it's consumer are probed.
We can safely remove ICC path for QUP-CORE clock from QUP wrapper
device.
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
Reviewed-by: Matthias Kaehlcke
---
Changes in V3:
- No change
Roja Rani Yarubandi (2):
soc: qcom-geni-se: Cleanup the code to remove proxy votes
arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 --
drivers/soc/qcom/qcom-geni-se.c | 74 ---
drivers/tty/serial/qcom_geni_serial.c
Dropped below patch as it is not required:
[3/3] Serial: Separate out earlycon support
Roja Rani Yarubandi (2):
soc: qcom-geni-se: Cleanup the code to remove proxy votes
arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 --
drivers/soc/qcom/qcom
console is probed.
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
---
Changes in V2:
- No chage
drivers/soc/qcom/qcom-geni-se.c | 74 ---
drivers/tty/serial/qcom_geni_serial.c | 7 ---
include/linux/qcom-geni-se.h | 2 -
3 files changed
will ensure that the default bootloader votes are not removed until
all it's consumer are probed.
We can safely remove ICC path for QUP-CORE clock from QUP wrapper
device.
Signed-off-by: Roja Rani Yarubandi
Signed-off-by: Akash Asthana
---
Changes in V2:
- No chage
arch/arm64/boot/dts/qcom
Add QSPI and QUP SE instances configuration for sc7280.
Signed-off-by: Roja Rani Yarubandi
---
This patch depends on base dtsi and interconnect changes
[1] https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
[2] https://lore.kernel.org/patchwork/project/lkml/list/?series=488429
shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
Hi,
Other two patches of this series have been picked, posting this patch
with fixing minor comments.
Roja Rani Yarubandi (1):
i2c: i2c-qcom-geni: Add shutdown callback for i2c
drivers/i2c/busses/i2c-qcom-geni.c | 34 ++
1 file changed, 34 insertions
, and also add the power-domains property to specify
the CX power-domain.
Signed-off-by: Roja Rani Yarubandi
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
For devices which have 'assigned-performance-states' specified in DT,
set the specified performance state during probe and drop it on remove.
Also drop/set as part of runtime suspend/resume callbacks.
Signed-off-by: Roja Rani Yarubandi
---
drivers/i2c/busses/i2c-qcom-geni.c | 49
scaling the device's performance, also known as DVFS
techniques.
Add a property 'assigned-performance-states' which client devices can
use to set this default performance state on their power-domains.
Signed-off-by: Roja Rani Yarubandi
---
.../bindings/power/power-domain.yaml | 49
Roja Rani Yarubandi (3):
dt-bindings: power: Introduce 'assigned-performance-states' property
arm64: dts: sc7180: Add assigned-performance-states for i2c
i2c: i2c-qcom-geni: Add support for 'assigned-performance-states'
.../bindings/power/power-domain.yaml | 49
Hi,
Posting V7 with comments answering.
Roja Rani Yarubandi (2):
i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct
i2c: i2c-qcom-geni: Add shutdown callback for i2c
drivers/i2c/busses/i2c-qcom-geni.c | 94 +-
1 file changed, 78 insertions(+), 16
and
geni_i2c_tx_msg_cleanup to unwrap the things after rx/tx FIFO/DMA
transfers, so that the same can be used in geni_i2c_stop_xfer()
function during shutdown callback.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- As per Stephen's comments separated this patch from shutdown
callback
shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
Hi,
Below patch is picked:
[V6,1/3] soc: qcom: geni: Remove "iova" check
Resending below patches for review:
[V6,2/3] i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct
[V6,3/3] i2c: i2c-qcom-geni: Add shutdown callback for i2c
Thanks,
Roja
Roja Rani Yarubandi (2):
and
geni_i2c_tx_msg_cleanup to unwrap the things after rx/tx FIFO/DMA
transfers, so that the same can be used in geni_i2c_stop_xfer()
function during shutdown callback.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- As per Stephen's comments separated this patch from shutdown
callback
shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
__handle_domain_irq+0x94/0xcc
gic_handle_irq+0x114/0x1dc
el1_irq+0xcc/0x180
cpuidle_enter_state+0xf8/0x204
cpuidle_enter+0x38/0x4c
cros-ec-spi spi6.0: spi transfer failed: -110
...
Fixes: 2ee471a1e28e ("spi: spi-geni-qcom: Mo' betta locking")
Signed-off-by: Roja Rani Yarubandi
---
d
Roja Rani Yarubandi (3):
soc: qcom: geni: Remove "iova" check
i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct
i2c: i2c-qcom-geni: Add shutdown callback for i2c
drivers/i2c/busses/i2c-qcom-geni.c | 104 -
drivers/soc/qcom/qcom-geni-se.
shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
Remove "iova" check from geni_se_tx_dma_unprep and geni_se_rx_dma_unprep
functions as checking with dma_mapping_error() is enough.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- This is newly added patch in V5. As per Stephen's comments separted
this patch from shutdow
and
geni_i2c_tx_msg_cleanup to unwrap the things after rx/tx FIFO/DMA
transfers, so that the same can be used in geni_i2c_stop_xfer()
function during shutdown callback.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- As per Stephen's comments separated this patch from shutdown
callback
and
geni_i2c_tx_msg_cleanup to unwrap the things after rx/tx FIFO/DMA
transfers, so that the same can be used in geni_i2c_stop_xfer()
function during shutdown callback.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- As per Stephen's comments separated this patch from shutdown
callback
shutdown callback to i2c driver to stop on-going transfer
and unmap DMA mappings during system "reboot" or "shutdown".
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2
- As per Stephen's comments prepared separate patches for rx/tx
transfer cleanup and shutdown callback
Roja Rani Yarubandi (3):
soc: qcom: geni: Remove "iova" check
i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct
i2c: i2c-qcom-geni: Add shutdown callba
Remove "iova" check from geni_se_tx_dma_unprep and geni_se_rx_dma_unprep
fucntions as invalidating with dma_mapping_error() is enough.
Signed-off-by: Roja Rani Yarubandi
---
Changes in V5:
- This is newly added patch in V5. As per Stephen's comments separted
this patch from shutdow
er()
function during shutdown callback.
Remove "iova" check from geni_se_tx_dma_unprep and geni_se_rx_dma_unprep
fucntions as invalidating with dma_mapping_error() is enough.
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by
ing data can be used to call geni_se_tx_dma_unprep
and geni_se_rx_dma_unprep functions.
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI
I2C controller")
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2:
- As per Stephen's comments added seperate functi
shutdown callback to i2c driver to unmap DMA mappings
during system "reboot" or "shutdown".
Signed-off-by: Roja Rani Yarubandi
---
Changes in V2:
- As per Stephen's comments added seperate function for stop transfer,
fixed minor nitpicks.
drivers/i2c/busses/
Store DMA mapping data in geni_i2c_dev struct to enhance DMA mapping
data scope. For example during shutdown callback to unmap DMA mapping,
this stored DMA mapping data can be used to call geni_se_tx_dma_unprep
and geni_se_rx_dma_unprep functions.
Signed-off-by: Roja Rani Yarubandi
---
Changes
Store DMA mapping data in geni_i2c_dev struct.
Implement Shutdown callback for geni i2c driver.
Changes in V2:
- Changed commit text.
- As per Stephen's comments added separate function for stop transfer.
Roja Rani Yarubandi (2):
i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev
shutdown callback to i2c driver to unmap DMA mappings
during system "reboot" or "shutdown".
Signed-off-by: Roja Rani Yarubandi
---
drivers/i2c/busses/i2c-qcom-geni.c | 36 ++
include/linux/qcom-geni-se.h | 5 +
2 files changed, 41 inser
Adding tx_dma, rx_dma and xfer length in geni_i2c_dev struct to
store DMA mapping data to enhance its scope. For example during
shutdown callback to unmap DMA mapping, these new struct members
can be used as part of geni_se_tx_dma_unprep and
geni_se_rx_dma_unprep calls.
Signed-off-by: Roja Rani
Add tx_dma, rx_dma and xfer_len in geni_i2c_dev struct.
Implement Shutdown callback for geni i2c driver.
Roja Rani Yarubandi (2):
i2c: i2c-qcom-geni: Add tx_dma, rx_dma and xfer_len to geni_i2c_dev
struct
i2c: i2c-qcom-geni: Add shutdown callback for i2c
drivers/i2c/busses/i2c-qcom
40 matches
Mail list logo
