Re: [PATCH][next] scsi: fnic: Replace vmalloc() + memset() with vzalloc() and use array_size()

2020-06-15 Thread Satish Kharat (satishkh)
Reviewed-by: Satish Kharat  On 6/15/20, 3:49 PM, "Gustavo A. R. Silva" wrote: Use vzalloc() instead of the vmalloc() and memset. Also, use array_size() instead of the open-coded version. This issue was found with the help of Coccinelle and, audited and fixed manually.

RE: [PATCH -next] scsi: fnic: Remove set but not used variable 'vdev'

2019-01-25 Thread Satish Kharat (satishkh)
://www.cisco.com/c/en/us/about/legal/terms-sale-software-license-agreement/company-registration-information.html -Original Message- From: YueHaibing Sent: Thursday, January 24, 2019 6:00 PM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; j...@linux.ibm.com

RE: [PATCH 3/7] scsi: fnic: no need to check return value of debugfs_create functions

2019-01-22 Thread Satish Kharat (satishkh)
...@vger.kernel.org; Greg Kroah-Hartman ; Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) Subject: [PATCH 3/7] scsi: fnic: no need to check return value of debugfs_create functions When calling debugfs functions, there is no need to ever check the return value

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Satish Kharat (satishkh)
Looks good to me. Acked-by: Satish Kharat <satis...@cisco.com> -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) <satis...@cisco.com>; Sesidhar Baddela (sebaddel) <sebad...@cisco.com>;

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Satish Kharat (satishkh)
Looks good to me. Acked-by: Satish Kharat -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; James E.J. Bottomley ; Martin K. Petersen Cc