Re: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

+Cc: Andrew Morton On 2021/4/1 14:57, Shaokun Zhang wrote: > From: Yang Guo > > The buffer uptodate state has been checked in function set_buffer_uptodate, > there is no need use buffer_uptodate before calling set_buffer_uptodate and > delete it. > > Cc: Alexander Viro

[PATCH] fs: Optimized file struct to improve performance

Signed-off-by: Shaokun Zhang --- include/linux/fs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 3fbb98126248..cfc91d2dd6a7 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -917,7 +917,6 @@ struct file

[PATCH] ext4: Delete redundant uptodate check for buffer

From: Yang Guo The buffer uptodate state has been checked in function set_buffer_uptodate, there is no need use buffer_uptodate before calling set_buffer_uptodate and delete it. Cc: "Theodore Ts'o" Cc: Andreas Dilger Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- fs/ex

[PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

From: Yang Guo The buffer uptodate state has been checked in function set_buffer_uptodate, there is no need use buffer_uptodate before calling set_buffer_uptodate and delete it. Cc: Alexander Viro Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- fs/buffer.c | 6 ++ 1 file

Re: linux-next: build warnings after merge of the arm-perf tree

Hi Will & Stephen, Apologies for the mistake. Will, shall I send a new version v5 to fix this issue or other? Thanks, Shaokun On 2021/3/26 16:52, Stephen Rothwell wrote: > Hi all, > > After merging the arm-perf tree, today's linux-next build (htmldocs) > produced these warnings: > >

[tip: locking/core] locking/mutex: Remove repeated declaration

The following commit has been merged into the locking/core branch of tip: Commit-ID: 8af856d18bfbe89676ade38caa2a5d06f75f211d Gitweb: https://git.kernel.org/tip/8af856d18bfbe89676ade38caa2a5d06f75f211d Author:Shaokun Zhang AuthorDate:Wed, 24 Mar 2021 13:40:40 +08:00

[tip: locking/core] locking/mutex: Remove repeated declaration

The following commit has been merged into the locking/core branch of tip: Commit-ID: 93b02d29fbdbc221c84adcaf0e85be9f8008 Gitweb: https://git.kernel.org/tip/93b02d29fbdbc221c84adcaf0e85be9f8008 Author:Shaokun Zhang AuthorDate:Wed, 24 Mar 2021 13:40:40 +08:00

[tip: locking/core] locking/mutex: Remove repeated declaration

The following commit has been merged into the locking/core branch of tip: Commit-ID: 5965a7adbd72dd9b288c0911cb73719fed1efa08 Gitweb: https://git.kernel.org/tip/5965a7adbd72dd9b288c0911cb73719fed1efa08 Author:Shaokun Zhang AuthorDate:Wed, 24 Mar 2021 13:40:40 +08:00

[PATCH v2] locking/mutex: Remove repeated declaration

eng Acked-by: Waiman Long Signed-off-by: Shaokun Zhang --- include/linux/mutex.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/mutex.h b/include/linux/mutex.h index 0cd631a19727..e7a126796937 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h @@ -

Re: [PATCH] locking/mutex: Remove repeated declaration

Hi Ingo, On 2021/3/23 19:23, Ingo Molnar wrote: > > * Shaokun Zhang wrote: > >> Commit 0cd39f4600ed ("locking/seqlock, headers: Untangle the spaghetti >> monster") >> introduces 'struct ww_acquire_ctx' again, remove the repeated declaration. >> >&

[PATCH] locking/mutex: Remove repeated declaration

Commit 0cd39f4600ed ("locking/seqlock, headers: Untangle the spaghetti monster") introduces 'struct ww_acquire_ctx' again, remove the repeated declaration. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Signed-off-by: Shaokun Zhang --- inc

Re: [PATCH] fs/buffer.c: Add checking buffer head stat before clear

Hi Andrew, 在 2021/2/6 7:45, Andrew Morton 写道: > On Wed, 3 Feb 2021 14:14:50 +0800 Shaokun Zhang > wrote: > >> From: Yang Guo >> >> clear_buffer_new() is used to clear buffer new stat. When PAGE_SIZE >> is 64K, most buffer heads in the list are not needed to

[PATCH -next] xfs: Fix unused variable 'mp' warning

xfs/xfs.o Fix this warning. Fixes: f736d93d76d3 ("xfs: support idmapped mounts") Cc: "Darrick J. Wong" Cc: Christoph Hellwig Cc: Christian Brauner Signed-off-by: Shaokun Zhang --- fs/xfs/xfs_ioctl32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH] fs/buffer.c: Add checking buffer head stat before clear

which is good for performance. Cc: Alexander Viro Cc: Andrew Morton Cc: Nick Piggin Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- fs/buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/buffer.c b/fs/buffer.c index 32647d2011df..f1c3a5b27a90 100644 --- a/fs

Re: [PATCH v2 1/3] perf vendor events: Add cache refill and DCZVA events

Hi, 在 2021/1/21 18:54, Shunsuke Nakamura 写道: > Adds L1 data cache refill prefetch, L2 data cache refill prefetch, > and DCZVA instruction events. A silly question, Does Arm define these events? I checked Arm ARM document(DDI0487Fc) that these event numbers are reserved. Or maybe I miss

[PATCH v8] lib: optimize cpumask_local_spread()

is still in 'node2' with the patch. Cc: Dave Hansen Cc: Rusty Russell Cc: Andrew Morton Cc: Juergen Gross Cc: Paul Burton Cc: Michal Hocko Cc: Michael Ellerman Cc: Mike Rapoport Cc: Anshuman Khandual Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- ChangeLog from v7: 1. Fix

Re: [PATCH v7] lib: optimize cpumask_local_spread()

Hi Dave, Apologies for the late reply. 在 2020/12/1 1:08, Dave Hansen 写道: { - int cpu, hk_flags; + static DEFINE_SPINLOCK(spread_lock); + static bool used[MAX_NUMNODES]; >>> >>> I thought I mentioned this last time. How large is this array? How >>> large would it be if

Re: [PATCH v7] lib: optimize cpumask_local_spread()

Hi Dave, Apologies for later reply. 在 2020/11/21 1:48, Dave Hansen 写道: > On 11/17/20 6:54 PM, Shaokun Zhang wrote: >> From: Yuqi Jin >> >> In multi-processor and NUMA system, I/O driver will find cpu cores that >> which shall be bound IRQ. When cpu cores in the loca

[PATCH v7] lib: optimize cpumask_local_spread()

: Mike Rapoport Cc: Anshuman Khandual Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- ChangeLog from v6: 1. Addressed Dave comments 2. Fix the warning from Hulk Robot 3. Simply the git log. ChangeLog from v5: 1. Rebase to 5.10-rc2 ChangeLog from v4: 1. Rebase to 5.6

Re: [PATCH v6] lib: optimize cpumask_local_spread()

Hi Dave, 在 2020/11/16 22:48, Dave Hansen 写道: > On 11/15/20 11:59 PM, Shaokun Zhang wrote: >>> Do you want to take another pass at submitting this patch? >> 'Another pass'? Sorry for my bad understading, I don't follow it correctly. > > Could you please incorporate the

Re: [PATCH v6] lib: optimize cpumask_local_spread()

Hi Dave, 在 2020/11/14 0:02, Dave Hansen 写道: > On 11/12/20 6:06 PM, Shaokun Zhang wrote: >>>> On Huawei Kunpeng 920 server, there are 4 NUMA node(0 - 3) in the 2-cpu >>>> system(0 - 1). The topology of this server is followed: >>> >>> This is wit

Re: [PATCH v6] lib: optimize cpumask_local_spread()

Hi Dave, 在 2020/11/5 0:10, Dave Hansen 写道: > On 11/3/20 5:39 AM, Shaokun Zhang wrote: >> Currently, Intel DDIO affects only local sockets, so its performance >> improvement is due to the relative difference in performance between the >> local socket I/O and remote socket I/O

[PATCH v6] lib: optimize cpumask_local_spread()

NUMA distance for the non-local NUMA nodes. Cc: Rusty Russell Cc: Andrew Morton Cc: Juergen Gross Cc: Paul Burton Cc: Michal Hocko Cc: Michael Ellerman Cc: Mike Rapoport Cc: Anshuman Khandual Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- Hi Andrew, I rebased this patch later

Re: [NAK] Re: [PATCH] fs: Optimized fget to improve performance

Hi Al, 在 2020/8/27 22:28, Al Viro 写道: > On Thu, Aug 27, 2020 at 06:19:44PM +0800, Shaokun Zhang wrote: >> From: Yuqi Jin >> >> It is well known that the performance of atomic_add is better than that of >> atomic_cmpxchg. >> The initial value of @f_count is 1.

[PATCH] fs: Optimized fget to improve performance

tial Only) 2734.9 [1] https://lkml.org/lkml/2020/6/24/283 Cc: kernel test robot Cc: Will Deacon Cc: Mark Rutland Cc: Peter Zijlstra Cc: Alexander Viro Cc: Boqun Feng Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- Hi Rong, Can you help to test this patch individually an

[PATCH] iommu/iova: Replace cmpxchg with xchg in queue_iova

to 1. Cc: Joerg Roedel Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- drivers/iommu/iova.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c index 45a251da5453..30d969a4c5fd 100644 --- a/drivers/iommu/iova.c +++ b/drivers

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

Hi Aleksa, 在 2020/8/26 16:24, Aleksa Sarai 写道: > On 2020-08-26, Shaokun Zhang wrote: >> 在 2020/8/22 0:02, Will Deacon 写道: >>> - This thing is tagged with __randomize_layout, so it doesn't help anybody >>> using that crazy plugin >> >> This p

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

Hi Will， 在 2020/8/22 0:02, Will Deacon 写道: > On Wed, Jun 24, 2020 at 04:32:28PM +0800, Shaokun Zhang wrote: >> get_file_rcu_many, which is called by __fget_files, has used >> atomic_try_cmpxchg now and it can reduce the access number of the global >> variable to improve the

Re: linux-next: Tree for Jul 30 [build failure on arm64]

Hi, 在 2020/7/31 16:30, Naresh Kamboju 写道: > On Fri, 31 Jul 2020 at 09:38, Stephen Rothwell wrote: >> >> Hi all, >> >> On Fri, 31 Jul 2020 10:46:52 +0800 Shaokun Zhang >> wrote: >>> >>> There's a build failure on arm64: >>

Re: linux-next: Tree for Jul 30 [build failure on arm64]

Hi, There's a build failure on arm64: In file included from ./include/linux/compat.h:17:0, from ./arch/arm64/include/asm/stat.h:13, from ./include/linux/stat.h:6, from ./include/linux/sysfs.h:22, from

Re: [fs] 936e92b615: unixbench.score 32.3% improvement

: > Greeting, > > FYI, we noticed a 32.3% improvement of unixbench.score due to commit: > > > commit: 936e92b615e212d08eb74951324bef25ba564c34 ("[PATCH RESEND] fs: Move > @f_count to different cacheline with @f_mode") > url: > https://github.com/0day-c

Re: [Patch v3 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

Hi Andrew, 在 2020/6/25 3:26, Andrew Morton 写道: > On Tue, 23 Jun 2020 15:23:29 -0400 Nitesh Narayan Lal > wrote: > >> From: Alex Belits >> >> The current implementation of cpumask_local_spread() does not respect the >> isolated CPUs, i.e., even if a CPU has been isolated for Real-Time task, >>

Re: linux-next: Tree for Jun 24 [build failure on arm64]

Hi Will， My apologies for reply later because of a short holiday in China. 在 2020/6/24 18:55, Will Deacon 写道: > On Wed, Jun 24, 2020 at 05:08:56PM +0800, Shaokun Zhang wrote: >> +Will Deacon, >> >> Hi Will, >> >> There's a build failure on arm64: >> >&

Re: linux-next: Tree for Jun 24 [build failure on arm64]

+Will Deacon, Hi Will, There's a build failure on arm64: CALLscripts/atomic/check-atomics.sh CALLscripts/checksyscalls.sh LD arch/arm64/kernel/vdso/vdso.so.dbg ld: unrecognized option '--no-eh-frame-hdr' ld: use the --help option for usage information

[PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

Benchmarks Index Score (Partial Only) 2444.2 Cc: Will Deacon Cc: Mark Rutland Cc: Peter Zijlstra Cc: Alexander Viro Cc: Boqun Feng Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drivers/perf: hisi: Add identifier sysfs file

Hi John, Thanks your further explaination and I'm ok on it, so for this patch: Acked-by: Shaokun Zhang Thanks, Shaokun 在 2020/6/18 17:18, John Garry 写道: > On 18/06/2020 02:40, Shaokun Zhang wrote: >>> } >>>   +    hha_pmu->identifier = readl(hha_pmu->base + HHA_VE

Re: [PATCH] drivers/perf: hisi: Add identifier sysfs file

Hi John, 在 2020/6/17 21:05, John Garry 写道: > To allow userspace to identify the specific implementation of the device, > add an "identifier" sysfs file. > > Encoding is as follows: > hi1620: 0x0 (aka hip08) > hi1630: 0x30 > > Signed-off-by: John Garry > > diff --git

[tip: irq/core] platform-msi: Fix typos in comment

The following commit has been merged into the irq/core branch of tip: Commit-ID: ae0bb9fda405c881848f7f6e94d912b35f6e31d2 Gitweb: https://git.kernel.org/tip/ae0bb9fda405c881848f7f6e94d912b35f6e31d2 Author:Shaokun Zhang AuthorDate:Mon, 18 May 2020 11:00:59 +08:00 Committer

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

Hi, On 2020/5/27 22:34, John Garry wrote: > > I also really dislike this. What's the preferred way to identify the SoC > from userspace? /proc/cpuinfo? ;) >>> >>> The *SoC*! >>> For an non-firmware specific case, I'd say soc_device should be. I'd guess ACPI systems

[PATCH] platform-msi: Fix typos in comment

Fix up one typos @nev -> @nr_irqs. Cc: Marc Zyngier Signed-off-by: Shaokun Zhang --- drivers/base/platform-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c index 8da314b81eab..c4a17e5edf8b 100644 --- a/driv

Re: [RFC PATCH] fs: Move @f_count to different cacheline with @f_mode

Hi maintainers, A gentle ping. Thanks, Shaokun On 2020/4/30 11:25, Shaokun Zhang wrote: > From: Yuqi Jin > > __fget_files does check the @f_mode with mask variable and will do some > atomic operations on @f_count while both are on the same cacheline. > Many CPU cores

[PATCH] lib/sort: Remove unused pr_fmt

No pr_* is called in sort.c, let's remove the unused pr_fmt macro. Cc: Kostenzer Felix Cc: Andrew Morton Signed-off-by: Shaokun Zhang --- lib/sort.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sort.c b/lib/sort.c index 3ad454411997..99ecab8d6f41 100644 --- a/lib/sort.c +++ b/lib

[PATCH v2] net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

gcc.gnu.org/gcc-8/changes.html Suggested-by: Peter Zijlstra Suggested-by: Eric Dumazet Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Cc: Jakub Kicinski Cc: Jiri Pirko Cc: Arvind Sankar Cc: Peter Zijlstra Cc: Eric Dumazet Cc: Jiong Wang Signed-off-by: Yuqi Jin Si

[PATCH trivial] bootconfig: Fixup one typo

Fix up one typo: CONFIG_BOOTCONFIG -> CONFIG_BOOT_CONFIG Cc: Jiri Kosina Cc: Steven Rostedt Cc: Masami Hiramatsu Signed-off-by: Shaokun Zhang --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index 1a5da2c2660c..8369ba173ad8 100

[tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr()

The following commit has been merged into the perf/core branch of tip: Commit-ID: 454a8be0cff954f18729964317b40ef2c3031364 Gitweb: https://git.kernel.org/tip/454a8be0cff954f18729964317b40ef2c3031364 Author:Shaokun Zhang AuthorDate:Wed, 29 Apr 2020 14:33:12 +08:00

Re: [PATCH] net: optimize cmpxchg in ip_idents_reserve

Hi Peter/Eric, Shall we use atomic_add_return() unconditionally and add some comments? Or I missed something. Thanks, Shaokun On 2020/1/20 16:18, Peter Zijlstra wrote: > On Fri, Jan 17, 2020 at 10:48:19AM -0800, Eric Dumazet wrote: >> >> >> On 1/17/20 10:38 AM, Arvind Sankar wrote: >>> On Fri,

[RFC PATCH] fs: Move @f_count to different cacheline with @f_mode

2444.2 System Benchmarks Index Score (Partial Only) 2444.2 Cc: Alexander Viro Signed-off-by: Yuqi Jin Signed-off-by: Shaokun Zhang --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH RESEND] perf tools: Fix function name in comment

get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c, fix the name in comment. Cc: Arnaldo Carvalho de Melo CC: Andi Kleen Signed-off-by: Shaokun Zhang --- tools/perf/pmu-events/pmu-events.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/pmu-events/pmu

Re: linux-next: Tree for Oct 23

Hi Geert, On 2019/10/23 14:44, Geert Uytterhoeven wrote: > On Wed, Oct 23, 2019 at 8:17 AM Shaokun Zhang > wrote: >> +Cc: Mark Salyzyn >> >> There is a compiler failure on arm64 platform, as follow: >> zhangshaokun@ubuntu:~/linux-next$ make -j64 >> CAL

Re: linux-next: Tree for Oct 23

+Cc: Mark Salyzyn There is a compiler failure on arm64 platform, as follow: zhangshaokun@ubuntu:~/linux-next$ make -j64 CALLscripts/atomic/check-atomics.sh CC arch/arm64/kernel/asm-offsets.s In file included from ./include/linux/sysctl.h:30:0, from

Re: [RFC] lib: optimize cpumask_local_spread()

Hi Michal, On 2019/10/17 20:37, Michal Hocko wrote: > On Thu 17-10-19 18:23:08, Shaokun Zhang wrote: >> From: yuqi jin >> >> In the multi-processor and NUMA system, A device may have many numa >> nodes belonging to multiple cpus. When we get a local numa, it is better

[PATCH v2] net: stmmac: Fix the problem of tso_xmit

c Dumazet Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Signed-off-by: yuqi jin Signed-off-by: Shaokun Zhang --- Changes in v2: -- Address Eric's comment: add the Fixes tag drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |

[PATCH] net: stmmac: Fix the problem of tso_xmit

in Signed-off-by: yuqi jin Signed-off-by: Shaokun Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c76a1336a451..3e02e64c5

[RFC] lib: optimize cpumask_local_spread()

, it may be in the another socket and it is not friendly for performance. Cc: Andrew Morton Cc: Mike Rapoport Cc: Paul Burton Cc: Michal Hocko Cc: Michael Ellerman Cc: Anshuman Khandual Signed-off-by: yuqi jin Signed-off-by: Shaokun Zhang --- lib/cpumask.c | 78

Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

Hi John, Thanks for your nice work, these are useful for performance profiling if anyone is unfamiliar with the uncore PMU events on hip08. For this patchset, please feel free to add Reviewed-by: Shaokun Zhang Thanks, Shaokun On 2019/9/4 23:54, John Garry wrote: > This patchset adds s

Re: [PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

Hi Eric, On 2019/7/26 17:58, Eric Dumazet wrote: > > > On 7/26/19 11:17 AM, Shaokun Zhang wrote: >> From: Yang Guo >> >> There is an significant performance regression with the following >> commit-id >> ("net: get rid of an signed integer overflow

Re: [ext4] [confidence: ] 2f7f60cf9f: WARNING:at_lib/list_debug.c:#__list_add_valid

Thanks for the report. This patch has been dropped and the updated patch has been sent to community. https://lkml.org/lkml/2019/8/28/286 Thanks, Shaokun > url: > https://github.com/0day-ci/linux/commits/Shaokun-Zhang/ext4-change-the-type-of-ext4-cache-stats-to-percpu_counter-to-improve

[PATCH v2] ext4: use percpu_counters for extent_status cache hits/misses

)(90.3GiB/120002msec) with the patch, IOPS=218k, BW=852MiB/s (894MB/s)(99.9GiB/120002msec) Cc: "Theodore Ts'o" Cc: Andreas Dilger Cc: Eric Biggers Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- ChangeLog: Fix the issue that there is no percpu_counter_destroy() for the n

Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance

Hi Theodore, On 2019/8/26 23:57, Theodore Y. Ts'o wrote: > On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote: >>> The other problem with this patch is that it initializes >>> es_stats_cache_hits and es_stats_cache_miesses too late. They will >>> g

Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance

Hi Ted, On 2019/8/26 8:47, Theodore Y. Ts'o wrote: > On Sun, Aug 25, 2019 at 10:28:03AM -0700, Eric Biggers wrote: >> This patch is causing the following. Probably because there's no calls to >> percpu_counter_destroy() for the new counters? > > Yeah, I noticed this from my test runs last night

Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance

Hi Eric, On 2019/8/26 1:28, Eric Biggers wrote: > On Sat, Aug 24, 2019 at 11:25:24PM -0400, Theodore Y. Ts'o wrote: >> On Fri, Aug 23, 2019 at 10:47:34AM +0800, Shaokun Zhang wrote: >>> From: Yang Guo >>> >>> @es_stats_cache_hits and @es_stats_

[PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance

)(90.3GiB/120002msec) with the patch, IOPS=218k, BW=852MiB/s (894MB/s)(99.9GiB/120002msec) Cc: "Theodore Ts'o" Cc: Andreas Dilger Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- fs/ext4/extents_status.c | 20 +--- fs/ext4/extents_status.h | 4 ++-- 2 files c

[PATCH v2] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail

From: Nianyao Tang In its_vpe_init, when its_alloc_vpe_table fails, we should free vpt_page allocated just before, instead of vpe->vpt_page. Let's fix it. Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Signed-off-by: Nianyao Tang Signed-off-by: Shaokun Zhang --- drivers/irqchip/

[PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

From: Yang Guo There is an significant performance regression with the following commit-id ("net: get rid of an signed integer overflow in ip_idents_reserve()"). Both on x86 server(Skylake) and ARM64 server, when cpu core number increase, the function ip_idents_reserve() of cpu usage is very

[PATCH] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail

From: Nianyao Tang In its_vpe_init, when its_alloc_vpe_table fails, we should free vpt_page allocated just before, instead of vpe->vpt_page. Let's fix it. Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Signed-off-by: Nianyao Tang --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file

[PATCH v4 1/2] drivers: base: cacheinfo: Add variable to record max cache line size

Cc: Sudeep Holla Cc: Catalin Marinas Cc: Jeremy Linton Cc: Will Deacon Signed-off-by: Shaokun Zhang --- ChangeLog since v3: -- Address Greg's comments -- Fix some commit information ChangeLog since v2: -- Rebase to 5.2-rc2 -- Export cache_line_size for I/O driver ChangeLog since v1:

[PATCH v4 2/2] arm64: cacheinfo: Update cache_line_size detected from DT or PPTT

-by: Zhenfa Qiu Suggested-by: Catalin Marinas Signed-off-by: Shaokun Zhang --- arch/arm64/include/asm/cache.h | 6 +- arch/arm64/kernel/cacheinfo.c | 11 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h

[PATCH v3 1/2] drivers: base: cacheinfo: Add variable to record max cache line size

Linton Cc: Will Deacon Signed-off-by: Shaokun Zhang --- ChangeLog since v2: -- Rebase to 5.2-rc2 -- Export cache_line_size for I/O driver ChangeLog since v1: -- Move coherency_max_size to drivers/base/cacheinfo.c -- Address Catalin's comments Link: https://www.spinics.net/lists/arm-kernel/msg7

[PATCH v3 2/2] arm64: cacheinfo: Update cache_line_size detected from DT or PPTT

-by: Zhenfa Qiu Suggested-by: Catalin Marinas Signed-off-by: Shaokun Zhang --- arch/arm64/include/asm/cache.h | 6 +- arch/arm64/kernel/cacheinfo.c | 11 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h

[PATCH v2] intel_th: msu: Fix unused variable warning on arm64 platform

/intel_th/msu.c:863:6: warning: unused variable ‘i’ [-Wunused-variable] int i; ^ Fix this compiler warning on arm64 platform. Cc: Alexander Shishkin Cc: Greg Kroah-Hartman Suggested-by: Alexander Shishkin Signed-off-by: Shaokun Zhang --- drivers/hwtracing/intel_th/msu.c | 40

[RESEND PATCH] intel_th: msu: Fix unused variable warning on arm64 platform

/intel_th/msu.c:863:6: warning: unused variable ‘i’ [-Wunused-variable] int i; ^ Fix this compiler warning on arm64 platform. Cc: Alexander Shishkin Cc: Greg Kroah-Hartman Signed-off-by: Shaokun Zhang --- drivers/hwtracing/intel_th/msu.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH] intel_th: msu: Fix unused variable warning on arm64 platform

Fix this compiler warning on arm64 platform. Cc: Alexander Shishkin Cc: Greg Kroah-Hartman Signed-off-by: Shaokun Zhang --- drivers/hwtracing/intel_th/msu.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing

[PATCH v2 2/2] arm64: cacheinfo: Update cache_line_size detected from DT or PPTT

Suggested-by: Catalin Marinas Signed-off-by: Shaokun Zhang --- arch/arm64/include/asm/cache.h | 6 +- arch/arm64/kernel/cacheinfo.c | 10 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cache.h index 926434f413fa

[PATCH v2 1/2] drivers: base: cacheinfo: Add variable to record max cache line size

Linton Cc: Will Deacon Signed-off-by: Shaokun Zhang --- ChangeLog since v1 -- Move coherency_max_size to drivers/base/cacheinfo.c -- Address Catalin's comments Link: https://www.spinics.net/lists/arm-kernel/msg723615.html drivers/base/cacheinfo.c | 5 + include/linux/cacheinfo.h | 2 +

[tip:perf/core] perf/headers: Fix stale comment for struct perf_addr_filter

Commit-ID: 1279e41d535e28cc3b56fa4a09e71a709641cae6 Gitweb: https://git.kernel.org/tip/1279e41d535e28cc3b56fa4a09e71a709641cae6 Author: Shaokun Zhang AuthorDate: Wed, 3 Apr 2019 14:54:24 +0800 Committer: Ingo Molnar CommitDate: Wed, 3 Apr 2019 11:40:02 +0200 perf/headers: Fix stale

[PATCH] perf: Fix stale comment for struct perf_addr_filter

inode has been removed after commit 9511bce9fe8e ("perf/core: Fix bad use of igrab()"), Let's fix the stale comment. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Song Liu Cc: Arnaldo Carvalho de Melo Signed-off-by: Shaokun Zhang --- include/linux/perf_event.h | 2 +- 1 file changed, 1

[PATCH -next] net: dsa: mv88e6xxx: Fix build warning when CONFIG_NET_DSA_LEGACY is n

t;net: dsa: mv88e6xxx: prevent interrupt storm caused by mv88e6390x_port_set_cmode") Cc: Heiner Kallweit Cc: Andrew Lunn Cc: Vivien Didelot Cc: Florian Fainelli Cc: "David S. Miller" Signed-off-by: Shaokun Zhang --- drivers/net/dsa/mv88e6xxx/chip.c | 16 ---

[PATCH] perf tools: Fix function name in comment

get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c, fix the name in comment. Cc: Arnaldo Carvalho de Melo CC: Andi Kleen Signed-off-by: Shaokun Zhang --- tools/perf/pmu-events/pmu-events.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/pmu-events/pmu

[tip:x86/cleanups] x86/smpboot: Remove unused phys_id variable

Commit-ID: f91fecc09e498529230b4d5053cb361619a0c42d Gitweb: https://git.kernel.org/tip/f91fecc09e498529230b4d5053cb361619a0c42d Author: Shaokun Zhang AuthorDate: Mon, 18 Feb 2019 21:05:01 +0800 Committer: Borislav Petkov CommitDate: Mon, 18 Feb 2019 17:09:24 +0100 x86/smpboot: Remove

[PATCH] x86/smpboot: Remove unused phys_id variable

The 'phys_id' local variable became unused after commit ce4b1b16502b ("x86/smpboot: Initialize secondary CPU only if master CPU will wait for it"). Remove it. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Igor Mammedov Signed-o

[tip:x86/cleanups] x86/mm/dump_pagetables: Remove the unused prev_pud variable

Commit-ID: 8e8a3cea7ea5f5458fdf2287713626892e7715f5 Gitweb: https://git.kernel.org/tip/8e8a3cea7ea5f5458fdf2287713626892e7715f5 Author: Shaokun Zhang AuthorDate: Thu, 14 Feb 2019 17:33:49 +0800 Committer: Borislav Petkov CommitDate: Thu, 14 Feb 2019 17:09:43 +0100 x86/mm

[PATCH] x86/mm/dump_pagetables: Remove the unused prev_pud variable

"H. Peter Anvin" Cc: Andrey Ryabinin Signed-off-by: Shaokun Zhang --- arch/x86/mm/dump_pagetables.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/mm/dump_pagetables.c b/arch/x86/mm/dump_pagetables.c index e3cdc85ce5b6..ee8f8ab46941 100644 --- a/arch/x86/mm/dump_pagetables

[tip:x86/cleanups] x86/mm/tlb: Remove unused cpu variable

Commit-ID: 691b9ab6c9676e5868a4787be9041dd990005311 Gitweb: https://git.kernel.org/tip/691b9ab6c9676e5868a4787be9041dd990005311 Author: Shaokun Zhang AuthorDate: Tue, 29 Jan 2019 15:36:57 +0800 Committer: Borislav Petkov CommitDate: Tue, 29 Jan 2019 18:32:30 +0100 x86/mm/tlb: Remove

[PATCH] x86/mm: Remove unused cpu variable

cpu variable is never used after commit ("x86/mm: Pass flush_tlb_info to flush_tlb_others() etc"), so remove it. Cc: Andy Lutomirski Cc: Dave Hansen Cc: Peter Zijlstra Signed-off-by: Shaokun Zhang --- arch/x86/mm/tlb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x8

[PATCH] iommu/dma: Remove unused variable

end_pfn is never used after commit ('iommu/iova: Make dma 32bit pfn implicit'), cleanup it. Cc: Joerg Roedel Cc: Robin Murphy Cc: Zhen Lei Signed-off-by: Shaokun Zhang --- drivers/iommu/dma-iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/dma

[PATCH] driver core: remove unnecessary function extern declare

device_private_init is called only in core.c, extern declare is unnecessary and make it static. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Signed-off-by: Shaokun Zhang --- drivers/base/base.h | 2 -- drivers/base/core.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)

[PATCH] driver core: remove unnecessary function extern declare

device_private_init is called only in core.c, extern declare is unnecessary and make it static. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Signed-off-by: Shaokun Zhang --- drivers/base/base.h | 2 -- drivers/base/core.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)

[PATCH] iommu/vt-d, trivial: Remove unused variable

Unused after commit <42e8c186b595> ("iommu/vt-d: Simplify io/tlb flushing in intel_iommu_unmap"), cleanup it. Cc: David Woodhouse <dw...@infradead.org> Cc: Joerg Roedel <j...@8bytes.org> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> --- drivers/iomm

[PATCH] iommu/vt-d, trivial: Remove unused variable

Unused after commit <42e8c186b595> ("iommu/vt-d: Simplify io/tlb flushing in intel_iommu_unmap"), cleanup it. Cc: David Woodhouse Cc: Joerg Roedel Signed-off-by: Shaokun Zhang --- drivers/iommu/intel-iommu.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH v6 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

This patch adds support HiSilicon SoC uncore PMU driver framework and interfaces. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> Signed-off-by: Anurup M <anuru...@huawei.com> --- drivers/perf/Kconfig

[PATCH v6 2/6] perf: hisi: Add support for HiSilicon SoC uncore PMU driver

This patch adds support HiSilicon SoC uncore PMU driver framework and interfaces. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/Kconfig | 7 + drivers/perf/Makefile| 1 + drivers/perf/hisilicon

[PATCH v6 3/6] perf: hisi: Add support for HiSilicon SoC L3C PMU driver

. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> Signed-off-by: Anurup M <anuru...@huawei.com> --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_unco

[PATCH v6 3/6] perf: hisi: Add support for HiSilicon SoC L3C PMU driver

. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 463 +++ include/linux/cpuhotplug.h | 1 + 3 files changed, 465

[PATCH v6 6/6] arm64: MAINTAINERS: hisi: Add HiSilicon SoC PMU support

Add support HiSilicon SoC uncore PMU driver. Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a74227a..96c583c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6242,6 +6242,1

[PATCH v6 6/6] arm64: MAINTAINERS: hisi: Add HiSilicon SoC PMU support

Add support HiSilicon SoC uncore PMU driver. Signed-off-by: Shaokun Zhang --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a74227a..96c583c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6242,6 +6242,13 @@ S: Maintained F

[PATCH v6 5/6] perf: hisi: Add support for HiSilicon SoC DDRC PMU driver

code (0 - 7) in DDRC PMU driver. Interrupt is supported to handle counter (32-bits) overflow. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> Signed-off-by: Anurup M <anuru...@huawei.com> --- drivers/perf/

[PATCH v6 5/6] perf: hisi: Add support for HiSilicon SoC DDRC PMU driver

code (0 - 7) in DDRC PMU driver. Interrupt is supported to handle counter (32-bits) overflow. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 463

[PATCH v6 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver

This patch adds documentation for the uncore PMUs on HiSilicon SoC. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> Signed-off-by: Anurup M <anuru...@huawei.com> --- Documentation/perf

[PATCH v6 1/6] Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver

This patch adds documentation for the uncore PMUs on HiSilicon SoC. Reviewed-by: Jonathan Cameron Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- Documentation/perf/hisi-pmu.txt | 53 + 1 file changed, 53 insertions(+) create mode 100644

[PATCH v6 4/6] perf: hisi: Add support for HiSilicon SoC HHA PMU driver

is supported to handle counter (48-bits) overflow. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> Signed-off-by: Anurup M <anuru...@huawei.com> --- drivers/perf/hisilicon/Makefile | 2 +- driv

  1   2   >