[PATCH v4] mips: Do not include hi and lo in clobber list for R6

2021-04-20 Thread Sudip Mukherjee
omain Naour Signed-off-by: Sudip Mukherjee --- v4: [sudip] added macro VDSO_SYSCALL_CLOBBERS and fix checkpatch errors with commit message. v3 Avoid duplicate code (Maciej W. Rozycki) v2 use MIPS_ISA_REV instead of __mips_isa_rev (Alexander Lobakin) I have reused the original patch by Romain an

Re: [PATCH 5.10 000/103] 5.10.32-rc1 review

2021-04-20 Thread Sudip Mukherjee
failure x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure Boot test: x86_64: Booted on my test laptop. No regression. x86_64: Booted on qemu. No regression. arm: Booted on rpi3b. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.4 00/73] 5.4.114-rc1 review

2021-04-20 Thread Sudip Mukherjee
failure x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure Boot test: x86_64: Booted on my test laptop. No regression. x86_64: Booted on qemu. No regression. arm: Booted on rpi3b. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: build failure of malta_qemu_32r6_defconfig

2021-04-17 Thread Sudip Mukherjee
Hi Thomas, On Fri, Apr 9, 2021 at 1:17 PM Thomas Bogendoerfer wrote: > > On Thu, Apr 08, 2021 at 09:42:11AM +0800, YunQiang Su wrote: > > Sudip Mukherjee 于2021年4月8日周四 上午2:26写道: > > > > > > Hi Thomas, > > > > > > I was building v5.

[PATCH] media: sp887x: drop unneeded assignment

2021-04-16 Thread Sudip Mukherjee
The pointer 'mem' was initialized to 'fw->data' but immediately after that it was assigned 'fw->data + 10'. Lets remove the extra assignement and initialize the pointer to the address its going to use. Signed-off-by: Sudip Mukherjee --- drivers/media/dvb-frontends/sp887x.c | 4 +---

Re: [PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-16 Thread Sudip Mukherjee
failure x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure Boot test: x86_64: Booted on my test laptop. No regression. x86_64: Booted on qemu. No regression. arm: Booted on rpi3b. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.4 00/18] 5.4.113-rc1 review

2021-04-16 Thread Sudip Mukherjee
failure x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure Boot test: x86_64: Booted on my test laptop. No regression. x86_64: Booted on qemu. No regression. arm: Booted on rpi3b. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 4.19 00/13] 4.19.188-rc1 review

2021-04-16 Thread Sudip Mukherjee
failure x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure Boot test: x86_64: Booted on my test laptop. No regression. x86_64: Booted on qemu. No regression. arm: Booted on rpi3b. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

2021-04-13 Thread Sudip Mukherjee
no failure Boot test: x86_64: Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-13 Thread Sudip Mukherjee
d, please > let me know. > > Responses should be made by Wed, 14 Apr 2021 08:39:44 +. > Anything received after that time might be too late. Boot test: x86_64: Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.4 000/111] 5.4.112-rc1 review

2021-04-13 Thread Sudip Mukherjee
no failure Boot test: x86_64: Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 4.19 52/66] net: sched: bump refcount for new action in ACT replace mode

2021-04-13 Thread Sudip Mukherjee
Hi Greg, On Mon, Apr 12, 2021 at 10:40:58AM +0200, Greg Kroah-Hartman wrote: > From: Kumar Kartikeya Dwivedi > > commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149 upstream. This has been reverted upstream by: 4ba86128ba07 ("Revert "net: sched: bump refcount for new action in ACT replace mode"")

Re: [PATCH 5.4 097/111] net: sched: bump refcount for new action in ACT replace mode

2021-04-13 Thread Sudip Mukherjee
Hi Greg, On Mon, Apr 12, 2021 at 10:41:15AM +0200, Greg Kroah-Hartman wrote: > From: Kumar Kartikeya Dwivedi > > commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149 upstream. This has been reverted upstream by: 4ba86128ba07 ("Revert "net: sched: bump refcount for new action in ACT replace mode"")

Re: [PATCH 5.10 00/41] 5.10.29-rc1 review

2021-04-09 Thread Sudip Mukherjee
6_64: Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

2021-04-09 Thread Sudip Mukherjee
6_64: Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH 5.10 38/41] bpf, x86: Validate computation of branch displacements for x86-64

2021-04-09 Thread Sudip Mukherjee
Hi Greg, On Fri, Apr 09, 2021 at 11:54:00AM +0200, Greg Kroah-Hartman wrote: > From: Piotr Krysiuk > > commit e4d4d456436bfb2fe412ee2cd489f7658449b098 upstream. And, this one also. I am unable to find this SHA in Linus's tree. -- Regards Sudip

Re: [PATCH 5.10 39/41] bpf, x86: Validate computation of branch displacements for x86-32

2021-04-09 Thread Sudip Mukherjee
Hi Greg, On Fri, Apr 09, 2021 at 11:54:01AM +0200, Greg Kroah-Hartman wrote: > From: Piotr Krysiuk > > commit 26f55a59dc65ff77cd1c4b37991e26497fc68049 upstream. I am not finding this in Linus's tree and even not seeing this change in master branch also. Am I missing something? -- Regards

build failure of malta_qemu_32r6_defconfig

2021-04-07 Thread Sudip Mukherjee
Hi Thomas, I was building v5.10.28 with malta_qemu_32r6_defconfig and noticed that it fails to build, so tried next-20210407 to see if it has been fixed. But linux-next also has the issue with gcc-10. The error is: ./arch/mips/include/asm/vdso/gettimeofday.h: In function '__vdso_clock_gettime':

Re: [PATCH 5.10 000/126] 5.10.28-rc1 review

2021-04-07 Thread Sudip Mukherjee
ase > let me know. > > Responses should be made by Wed, 07 Apr 2021 08:50:09 +. > Anything received after that time might be too late. Booted on my test laptop. No regression. Tested-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH v2 1/3] parport: Introduce module_parport_driver() helper macro

2021-03-02 Thread Sudip Mukherjee
On Mon, Mar 1, 2021 at 12:12 PM Andy Shevchenko wrote: > > On Sun, Feb 28, 2021 at 11:27:10PM +, Sudip Mukherjee wrote: > > On Fri, Feb 26, 2021 at 07:03:09PM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 16, 2021 at 01:07:39PM +0200, Andy Shevchenko wro

Re: [PATCH v2 1/3] parport: Introduce module_parport_driver() helper macro

2021-02-28 Thread Sudip Mukherjee
ments on this? Sorry for the delay in reply. lgtm. I think there are few more drivers which can also use this new helper. Will you like to do them also? Acked-by: Sudip Mukherjee -- Regards Sudip

Re: [PATCH] Documentation: process: Correct numbering

2020-12-15 Thread Sudip Mukherjee
Hi Milan, On Tue, Dec 15, 2020 at 07:50:35PM +, Milan Lakhani wrote: > Renumber the steps in submit-checklist.rst as some numbers were skipped. > > Signed-off-by: Milan Lakhani Maybe you can also add: Fixes: 72deb455b5ec ("block: remove CONFIG_LBDAF") But I am confused about why you have

Re: [linux-safety] [PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO

2020-11-23 Thread Sudip Mukherjee
On 16/11/2020 17:01, Thierry Reding wrote: > On Mon, Nov 16, 2020 at 04:54:07PM +0000, Sudip Mukherjee wrote: >> Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, >> we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then >> doing 'return

Re: linux-next: Tree for Nov 20

2020-11-20 Thread Sudip Mukherjee
Hi, On Fri, Nov 20, 2020 at 5:59 AM Stephen Rothwell wrote: > > Hi all, > > Changes since 20201119: mips allmodconfig fails for next-20201120 with the error: /home/sudip/linux/drivers/video/fbdev/udlfb.c: In function 'dlfb_ops_mmap': /home/sudip/linux/drivers/video/fbdev/udlfb.c:343:52: error:

Re: [PATCH 5.4 140/203] MIPS: PCI: remember nasid changed by set interrupt affinity

2020-11-18 Thread Sudip Mukherjee
Hi Greg, On Fri, Jan 17, 2020 at 12:17:37AM +0100, Greg Kroah-Hartman wrote: > From: Thomas Bogendoerfer > > commit 37640adbefd66491cb8083a438f7bf366ac09bc7 upstream. > > > --- > arch/mips/pci/pci-xtalk-bridge.c |5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > ---

[PATCH] rtc: pcf8523: Use PTR_ERR_OR_ZERO

2020-11-16 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH] PCI: tegra: Use PTR_ERR_OR_ZERO

2020-11-16 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/pci/controller/pci-tegra.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] PCI: dwc: kirin: Use PTR_ERR_OR_ZERO

2020-11-16 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/pci/controller/dwc/pcie-kirin.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[PATCH] PCI: dwc/meson: Use PTR_ERR_OR_ZERO

2020-11-16 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/pci/controller/dwc/pci-meson.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[PATCH] mm: fix build failure with xtensa

2020-11-10 Thread Sudip Mukherjee
If CONFIG_ZSMALLOC is enabled with xtensa then the build fails with: mm/zsmalloc.c:43:10: fatal error: asm/sparsemem.h: No such file or directory Disable CONFIG_ZSMALLOC for xtensa as xtensa arch has not defined sparsemem.h. Signed-off-by: Sudip Mukherjee --- Build failed with next-20201110

Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Sudip Mukherjee
; > > > On Mon, Nov 09, 2020 at 10:14:46AM +, Sudip Mukherjee wrote: > > > Hi Greg, > > > > > > On Sun, Nov 8, 2020 at 8:23 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Sat, Nov 07, 2020 at 10:47:27PM +, Sudip Mu

Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-09 Thread Sudip Mukherjee
Hi Greg, On Sun, Nov 8, 2020 at 8:23 AM Greg Kroah-Hartman wrote: > > On Sat, Nov 07, 2020 at 10:47:27PM +, Sudip Mukherjee wrote: > > When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it > > is unable to find device_is_bound(). The error being:

[PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-07 Thread Sudip Mukherjee
: imx: scu: add two cells binding support") Signed-off-by: Sudip Mukherjee --- resending with the Fixes: tag. drivers/base/dd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 148e81969e04..a796a57e5efb 100644 --- a/drivers/base/dd.c +++

[PATCH] driver core: export device_is_bound() to fix build failure

2020-11-06 Thread Sudip Mukherjee
When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it is unable to find device_is_bound(). The error being: ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko] undefined! Export the symbol so that the module finds it. Signed-off-by: Sudip

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Sudip Mukherjee
Hi Lukas, On 06/11/2020 10:31, Lukas Bulwahn wrote: > > > On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > >> Hi Lukas, >> > > I did not try but I bet (a beverage of your choice) that the object code > remains the same also for your suggested patch. Try to

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Sudip Mukherjee
Hi Lukas, On 06/11/2020 06:22, Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > kernel/taskstats.c:120:2: warning: Value stored to 'rc' is never read \ > [clang-analyzer-deadcode.DeadStores] > rc = 0; > ^ > > Commit

[PATCH] ASoC: mediatek: mt8192: Fix build failure

2020-11-05 Thread Sudip Mukherjee
A build of arm64 allmodconfig with next-20201105 fails with the error: ERROR: modpost: "mt8192_afe_gpio_request" undefined! ERROR: modpost: "mt8192_afe_gpio_init" undefined! Export the symbols so that mt8192-mt6359-rt1015-rt5682.ko finds it. Signed-off-by: Sudip Mukhe

[PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO

2020-10-26 Thread Sudip Mukherjee
Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then doing 'return 0'. Signed-off-by: Sudip Mukherjee --- drivers/misc/hisi_hikey_usb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH] libtraceevent: install html files

2020-10-19 Thread Sudip Mukherjee
Hi Steve, On Mon, Oct 19, 2020 at 2:42 PM Steven Rostedt wrote: > > On Sun, 18 Oct 2020 22:19:12 +0100 > Sudip Mukherjee wrote: > > > Only the man pages were installed using "make install". Add rules to > > install html files also. > > > > Signed-o

[PATCH] libtraceevent: install html files

2020-10-18 Thread Sudip Mukherjee
Only the man pages were installed using "make install". Add rules to install html files also. Signed-off-by: Sudip Mukherjee --- tools/lib/traceevent/Documentation/Makefile | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/lib/traceevent/Doc

Re: [ANNOUNCE] libtraceevent.git

2020-10-14 Thread Sudip Mukherjee
Hi Steve, On Tue, Oct 13, 2020 at 2:02 PM Steven Rostedt wrote: > > On Tue, 13 Oct 2020 11:06:16 +0800 > Zamir SUN wrote: > > > On Tue, Oct 13, 2020 at 3:17 AM Steven Rostedt wrote: > > > > > So, for me, there is no more issue for Fedora packaging. > > > > So should I just add that one patch

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-13 Thread Sudip Mukherjee
Hi Lukas, On Tue, Oct 13, 2020 at 6:37 AM Lukas Bulwahn wrote: > > > > On Tue, 13 Oct 2020, Greg Kroah-Hartman wrote: > > > On Mon, Oct 12, 2020 at 08:25:30PM +0200, Lukas Bulwahn wrote: > > > > > > > > > On Mon, 12 Oct 2020, Greg Kroah-Hartman wrote: > > > > > > > On Mon, Oct 12, 2020 at

Re: [ANNOUNCE] libtraceevent.git

2020-10-12 Thread Sudip Mukherjee
Hi Steve, On Mon, Oct 12, 2020 at 8:17 PM Steven Rostedt wrote: > > > [ Removing the powertop mailing list because it's rejecting everything ] > > On Mon, 12 Oct 2020 11:41:20 -0700 > Tony Jones wrote: > > > On Mon, Oct 12, 2020 at 11:19:50AM -0400, Steven Rostedt wrote: > > > > > Once it's

Re: [ANNOUNCE] libtraceevent.git

2020-10-12 Thread Sudip Mukherjee
On Mon, Oct 12, 2020 at 4:19 PM Steven Rostedt wrote: > > On Mon, 12 Oct 2020 12:12:08 +0200 > Jiri Olsa wrote: > > > On Wed, Oct 07, 2020 at 01:07:50PM -0400, Steven Rostedt wrote: > > > I split out tools/lib/traceevent from the kernel tree using "git subtree", > > > which recreates all the

Re: [linux-safety] [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-12 Thread Sudip Mukherjee
Hi Lukas, On Mon, Oct 12, 2020 at 3:11 PM Lukas Bulwahn wrote: > > > > On Sun, 11 Oct 2020, Sudip Mukherjee wrote: > > > Add a comment explaining why find_tt() will not return error even though > > find_tt() is checking for NULL and other errors. > > > > Si

[PATCH] e1000: drop unneeded assignment in e1000_set_itr()

2020-10-11 Thread Sudip Mukherjee
The variable 'current_itr' is assigned to 0 before jumping to 'set_itr_now' but it has not been used after the jump. So, remove the unneeded assignement. Signed-off-by: Sudip Mukherjee --- drivers/net/ethernet/intel/e1000/e1000_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

[PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-11 Thread Sudip Mukherjee
Add a comment explaining why find_tt() will not return error even though find_tt() is checking for NULL and other errors. Signed-off-by: Sudip Mukherjee --- drivers/usb/host/ehci-sched.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/host/ehci-sched.c b/drivers

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-10 Thread Sudip Mukherjee
On Sat, Oct 10, 2020 at 1:08 AM Sudip Mukherjee wrote: > > On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > > Checking the argument passed to the ioctl is valid > > > or not. if no

Re: [PATCH] char: ppdev: check if ioctl argument is present and valid

2020-10-09 Thread Sudip Mukherjee
On Fri, Oct 9, 2020 at 5:57 AM Greg KH wrote: > > On Thu, Oct 08, 2020 at 11:57:13PM +0530, Harshal Chaudhari wrote: > > Checking the argument passed to the ioctl is valid > > or not. if not then return -EINVAL. > > Along the the comments that Arnd made, this is not the correct value to > be

[PATCH v2] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap()

2020-10-07 Thread Sudip Mukherjee
The variable 'first' is assigned 0 inside the while loop in the if block but it is not used in the if block and is only used in the else block. So, remove the unneeded assignment and move the variable in the else block. Signed-off-by: Sudip Mukherjee --- v1: only had the removal of assignment

[PATCH] usb: host: ehci-sched: avoid possible NULL dereference

2020-10-05 Thread Sudip Mukherjee
find_tt() can return NULL or the error value in ERR_PTR() and dereferencing the return value without checking for the error can lead to a possible dereference of NULL pointer or ERR_PTR(). Signed-off-by: Sudip Mukherjee --- drivers/usb/host/ehci-sched.c | 4 1 file changed, 4 insertions

[PATCH] kernel/relay.c: drop unneeded initialization

2020-10-05 Thread Sudip Mukherjee
The variable 'consumed' is initialized with the consumed count but immediately after that the consumed count is updated and assigned to 'consumed' again thus overwriting the previous value. So, drop the unneeded initialization. Signed-off-by: Sudip Mukherjee --- The resultant binary stayed same

[PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap()

2020-10-05 Thread Sudip Mukherjee
The variable 'first' is assigned 0 inside the while loop in the if block but it is not used in the if block and is only used in the else block. So, remove the unneeded assignment. Signed-off-by: Sudip Mukherjee --- The resultant binary stayed same after this change. Verified with md5sum which

[PATCH] proc: remove a pointless assignment

2020-09-30 Thread Sudip Mukherjee
The variable 'env_start' has only been used for the if condition before this assignment and is never read after this. So, remove the assignement. Signed-off-by: Sudip Mukherjee --- fs/proc/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/base.c b/fs/proc/base.c

[PATCH] tracing: remove a pointless assignment

2020-09-30 Thread Sudip Mukherjee
The variable 'len' has been assigned a value but is not used after that. So, remove the assignement. Signed-off-by: Sudip Mukherjee --- kernel/trace/trace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d3c75aab44ad..e13cb3baeff0 100644

[PATCH] nfs: use 'break' instead of 'fallthrough'

2020-09-24 Thread Sudip Mukherjee
. Fixes: cf65e49f89f2 ("nfs: Convert to use the preferred fallthrough macro") Signed-off-by: Sudip Mukherjee --- fs/nfs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index d20326ee0475..eb2401079b04 100644 --- a/fs/nfs/super.

[PATCH] mmc: block: remove unused variable

2019-10-22 Thread Sudip Mukherjee
The use of 'status' was removed but the variable itself was not removed and thus adding a build warning. Fixes: 05224f7e4975 ("mmc: block: Add CMD13 polling for MMC IOCTLS with R1B response") Signed-off-by: Sudip Mukherjee --- drivers/mmc/core/block.c | 1 - 1 file changed, 1 deletio

[PATCH] tty: serial: samsung: rename to fix build warning

2019-10-18 Thread Sudip Mukherjee
The build of arm allmodconfig gives a warning: warning: same module names found: drivers/tty/serial/samsung.ko drivers/mtd/nand/onenand/samsung.ko Rename drivers/tty/serial/samsung.c to drivers/tty/serial/samsung_tty.c to fix the warning. Signed-off-by: Sudip Mukherjee --- drivers/tty

[PATCH] omapfb: reduce stack usage

2019-10-18 Thread Sudip Mukherjee
The build of xtensa allmodconfig is giving a warning of: In function 'dsi_dump_dsidev_irqs': warning: the frame size of 1120 bytes is larger than 1024 bytes Allocate the memory for 'struct dsi_irq_stats' dynamically instead of assigning it in stack. Signed-off-by: Sudip Mukherjee --- drivers

[PATCH v2] tty: rocket: reduce stack usage

2019-10-18 Thread Sudip Mukherjee
The build of xtensa allmodconfig gives warning of: In function 'get_ports.isra.0': warning: the frame size of 1040 bytes is larger than 1024 bytes Signed-off-by: Sudip Mukherjee --- v2: check faliure of kzalloc drivers/tty/rocket.c | 32 +++- 1 file changed, 19

[PATCH] tty: rocket: reduce stack usage

2019-10-18 Thread Sudip Mukherjee
allocating memory. Signed-off-by: Sudip Mukherjee --- drivers/tty/rocket.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c index 5ba6816ebf81..cc1424b9a1e5 100644 --- a/drivers/tty/rocket.c +++ b

[PATCH] staging: rtl8723bs: reduce stack usage of rtw_cfg80211_unlink_bss

2019-10-18 Thread Sudip Mukherjee
The build of xtensa allmodconfig gives warning of: In function 'rtw_cfg80211_unlink_bss': warning: the frame size of 1136 bytes is larger than 1024 bytes Instead of having 'select_network' structure as a variable use it as a pointer. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: reduce stack usage of cfg80211_rtw_scan

2019-10-18 Thread Sudip Mukherjee
. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 8555f52ceb7c

Re: [PATCH] Input: walkera0701 - Fix possible NULL pointer dereference in walkera0701_detach

2019-10-16 Thread Sudip Mukherjee
Hulk Robot to verify if it fixes the problem. -- Regards Sudip >From 0338a89a873e7df57707852402f90bb0d6626f12 Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Wed, 16 Oct 2019 16:08:43 +0100 Subject: [PATCH] Input: walkera0701 - Fix possible NULL pointer dereference If walkera0701_a

[PATCH 1/4] parport: daisy: avoid hardcoded name

2019-10-16 Thread Sudip Mukherjee
The daisy device name is hardcoded, define it in the header file and use it in the code. Signed-off-by: Sudip Mukherjee --- drivers/parport/probe.c | 2 +- include/linux/parport.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/parport/probe.c b/drivers/parport

[PATCH 2/4] parport: do not check portlist when using device-model

2019-10-16 Thread Sudip Mukherjee
We do not need to maintain a list of ports when we are using the device-model. The base layer is going to maintain the list for us and we can get the list of ports just using bus_for_each_dev(). Signed-off-by: Sudip Mukherjee --- drivers/parport/share.c | 5 ++--- 1 file changed, 2 insertions

[PATCH 3/4] parport: load lowlevel driver if ports not found

2019-10-16 Thread Sudip Mukherjee
quot; and so it only works in Suse. Users of Debian based distro will need to load the lowlevel module manually. Signed-off-by: Sudip Mukherjee --- drivers/parport/share.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/parport/share.c b/drivers/parport/share.

[PATCH 4/4] parport: daisy: use new parport device model

2019-10-16 Thread Sudip Mukherjee
en Rostedt (VMware) Signed-off-by: Sudip Mukherjee --- Steven, Michal, Can you please test this series in your test environment and verify that I am not breaking anything this time. drivers/parport/daisy.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletio

[PATCH 1/3] parport: Add missing newline at end of file

2019-08-01 Thread Sudip Mukherjee
From: Geert Uytterhoeven "git diff" says: \ No newline at end of file after modifying the file. Signed-off-by: Geert Uytterhoeven Signed-off-by: Sudip Mukherjee --- drivers/parport/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/parport/

[PATCH 2/3] ppdev: add header include guard

2019-08-01 Thread Sudip Mukherjee
From: Masahiro Yamada Add a header include guard just in case. Signed-off-by: Masahiro Yamada Signed-off-by: Sudip Mukherjee --- include/uapi/linux/ppdev.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/ppdev.h b/include/uapi/linux/ppdev.h index

[PATCH 3/3] parport: parport_serial: Use dev_get_drvdata

2019-08-01 Thread Sudip Mukherjee
From: Chuhong Yuan Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan Signed-off-by: Sudip Mukherjee --- drivers/parport/parport_serial.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

Re: regression with napi/softirq ?

2019-07-19 Thread Sudip Mukherjee
On Thu, Jul 18, 2019 at 4:08 PM Eric Dumazet wrote: > > > > On 7/18/19 2:55 PM, Sudip Mukherjee wrote: > > > Thanks Eric. But there is no improvement in delay between > > softirq_raise and softirq_entry with this change. > > But moving to a later kernel (linus

Re: regression with napi/softirq ?

2019-07-18 Thread Sudip Mukherjee
On Thu, Jul 18, 2019 at 12:42 PM Eric Dumazet wrote: > > > > On 7/18/19 1:18 PM, Sudip Mukherjee wrote: > > Hi Eric, > > > > On Thu, Jul 18, 2019 at 7:58 AM Eric Dumazet wrote: > >> > >> > >> > >> On 7/17/19 11:52 PM, Thomas G

Re: regression with napi/softirq ?

2019-07-18 Thread Sudip Mukherjee
Hi Eric, On Thu, Jul 18, 2019 at 7:58 AM Eric Dumazet wrote: > > > > On 7/17/19 11:52 PM, Thomas Gleixner wrote: > > Sudip, > > > > On Wed, 17 Jul 2019, Sudip Mukherjee wrote: > >> On Wed, Jul 17, 2019 at 9:53 PM Thomas Gleixner wrote: > >>&g

Re: regression with napi/softirq ?

2019-07-17 Thread Sudip Mukherjee
Hi, On Wed, Jul 17, 2019 at 9:53 PM Thomas Gleixner wrote: > > On Wed, 17 Jul 2019, Sudip Mukherjee wrote: > > I am using v4.14.55 on an Intel Atom based board and I am seeing network > > packet drops frequently on wireshark logs. After lots of debugging it > > seem

regression with napi/softirq ?

2019-07-17 Thread Sudip Mukherjee
Hi All, I am using v4.14.55 on an Intel Atom based board and I am seeing network packet drops frequently on wireshark logs. After lots of debugging it seems that when this happens softirq is taking huge time to start after it has been raised. This is a small snippet from ftrace:

Re: [PATCH 4.14 68/92] appletalk: Fix use-after-free in atalk_proc_exit

2019-04-18 Thread Sudip Mukherjee
Hi Greg, On Thu, Apr 18, 2019 at 7:25 PM Greg Kroah-Hartman wrote: > > [ Upstream commit 6377f787aeb945cae7abbb6474798de129e1f3ac ] This has been fixed by 27da0d2ef998 ("appletalk: Fix compile regression"). -- Regards Sudip

[PATCH] parport: ieee1284: mark expected switch fall-through

2019-03-29 Thread Sudip Mukherjee
de comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Sudip Mukherjee --- drivers/parport/ieee1284.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] parport: daisy: do not try to load lowlevel driver

2019-03-25 Thread Sudip Mukherjee
Hi Linus, On Mon, Mar 25, 2019 at 9:49 PM Linus Torvalds wrote: > > On Mon, Mar 25, 2019 at 2:13 PM Sudip Mukherjee > wrote: > > > > We do not need to search for ports and bind the initial list of ports > > to daisy driver as daisy driver is always the first driv

[PATCH] parport: daisy: do not try to load lowlevel driver

2019-03-25 Thread Sudip Mukherjee
isy_drv registration even if the list of parport is empty. Fixes: 1aec4211204d ("parport: daisy: use new parport device model") Reported-by: Michal Kubecek Reported-by: Steven Rostedt Tested-by: Michal Kubecek Cc: Linus Torvalds Signed-off-by: Sudip Mukherjee --- drivers/parport/sha

Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model

2019-03-25 Thread Sudip Mukherjee
Hi Greg, Linus, On Mon, Mar 25, 2019 at 8:12 PM Greg Kroah-Hartman wrote: > > On Mon, Mar 25, 2019 at 11:04:49AM -0700, Linus Torvalds wrote: > > On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt wrote: > > > > > > I bisected it down to this commit: > > > > > > aec4211204d ("parport: daisy: use

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-25 Thread Sudip Mukherjee
On Mon, Mar 25, 2019 at 7:30 AM Michal Kubecek wrote: > > On Sun, Mar 24, 2019 at 07:38:38PM +, Sudip Mukherjee wrote: > > And I was able to reproduce the problem using a vm and Suse Tumblewood with > > next-20190322. Can you please try the attached patch and test on your

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-24 Thread Sudip Mukherjee
Hi Michal, On Fri, Mar 22, 2019 at 07:13:23AM +0100, Michal Kubecek wrote: > On Thursday, 21 March 2019 23:43 Sudip Mukherjee wrote: > > HI Michal, > > > > On Wed, Mar 20, 2019 at 9:18 PM Michal Kubecek wrote: > > > On Wed, Mar 20, 2019 at 09:30:59AM +, Sudip

Re: [PATCH] parport: ieee1284: mark expected switch fall-through

2019-03-24 Thread Sudip Mukherjee
Hi Greg, On Wed, Mar 20, 2019 at 8:12 PM Greg KH wrote: > > On Wed, Mar 20, 2019 at 03:06:04PM -0500, Gustavo A. R. Silva wrote: > > Greg, > > > > Can you take this, please? > > Will do, give me a week or so to catch up... I will send it to you with the another parport regression fix I have.

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-21 Thread Sudip Mukherjee
HI Michal, On Wed, Mar 20, 2019 at 9:18 PM Michal Kubecek wrote: > > On Wed, Mar 20, 2019 at 09:30:59AM +, Sudip Mukherjee wrote: > > Sorry, I didn't get the chance to look at it yet and have kept it > > pending for this weekend. But just had a quick look and I

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-20 Thread Sudip Mukherjee
Hi Michal, On Sun, Mar 17, 2019 at 6:05 PM Michal Kubecek wrote: > > On Sun, Mar 17, 2019 at 05:01:37PM +, Sudip Mukherjee wrote: > > On Wed, Mar 13, 2019 at 6:45 AM Michal Kubecek wrote: > > > I encountered a regression in current (post-5.0) mainline kernel which I >

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-17 Thread Sudip Mukherjee
HI Michal, On Wed, Mar 13, 2019 at 6:45 AM Michal Kubecek wrote: > > Hello, > > I encountered a regression in current (post-5.0) mainline kernel which I > bisected to commit 1aec4211204d ("parport: daisy: use new parport device > model"). Running "modprobe parport_pc" hangs up: Can you please

Re: [PATCH V3] parport_serial.c change for fix hanging problem.

2019-03-05 Thread Sudip Mukherjee
On Tue, Feb 19, 2019 at 9:23 AM saumah wrote: > > parport_serial.c change for fix hanging problem while suspend machine. > parport_seria.c support the same vendor id and device id definition as sunix > multi-I/O card driver, when the sunix multi-io borad driver is > installed,there are two

Re: [PATCH 4.14 04/62] uapi/if_ether.h: prevent redefinition of struct ethhdr

2019-02-18 Thread Sudip Mukherjee
Hi Greg, On Mon, Feb 18, 2019 at 1:56 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > commit 6926e041a8920c8ec27e4e155efa760aa01551fd upstream. This has been fixed upstream by da360299b673

[PATCH v2] parport: daisy: use new parport device model

2019-02-13 Thread Sudip Mukherjee
Modify parport daisy driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- v2: hide ifdef in the header file drivers/parport/daisy.c | 32 +++- drivers/parport/probe.c | 2 +- drivers/parport/share.c | 10 +- include/linux

[PATCH 1/2] parport: daisy: use new parport device model

2019-02-09 Thread Sudip Mukherjee
Modify parport daisy driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- drivers/parport/daisy.c | 32 +++- drivers/parport/probe.c | 2 +- drivers/parport/share.c | 14 +- include/linux/parport.h | 3 +++ 4 files

[PATCH 2/2] parport_pc: fix find_superio io compare code, should use equal test.

2019-02-09 Thread Sudip Mukherjee
dma() and get_superio_irq() and thus returning the wrong value. Fix the condition so that it now returns the correct pointer. Fixes: 181bf1e815a2 ("parport_pc: clean up the modified while loops using for") Cc: Alan Cox Cc: sta...@vger.kernel.org Signed-off-by: QiaoChong Signed-

Re: [PATCH] parport_pc: fix find_superio io compare code, should use equal test.

2019-01-28 Thread Sudip Mukherjee
Hi QiaoChong, On Tue, Jan 22, 2019 at 3:04 PM qiaochong wrote: > > From: QiaoChong > > git blame drivers/parport/parport_pc.c > > 181bf1e815a2a (Alan Cox 2009-06-11 13:08:10 +0100 1376) > static struct superio_struct *find_superio(struct parport *p) > ^1da177e4c3f4 (Linus

Re: [PATCH 4.14 024/105] bnx2x: Remove configured vlans as part of unload sequence.

2019-01-12 Thread Sudip Mukherjee
Hi Greg, On Fri, Jan 11, 2019 at 2:33 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > [ Upstream commit 04f05230c5c13b1384f66f5186a68d7499e34622 ] This was fixed upstream by 38355a5f9a22 ("bnx2x: Fix NULL

Re: [PATCH 4.14 058/105] tools: fix cross-compile var clobbering

2019-01-12 Thread Sudip Mukherjee
Hi Greg, On Fri, Jan 11, 2019 at 2:34 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Martin Kelly > > commit 7ed1c1901fe52e6c5828deb155920b44b0adabb1 upstream. This was fixed upstream by

Re: [PATCH 4.14 090/101] MIPS: c-r4k: Add r4k_blast_scache_node for Loongson-3

2019-01-08 Thread Sudip Mukherjee
On Tue, Jan 8, 2019 at 7:38 AM Greg Kroah-Hartman wrote: > > On Mon, Jan 07, 2019 at 09:17:22PM +, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Mon, Jan 7, 2019 at 1:14 PM Greg Kroah-Hartman > > wrote: > > > > > > 4.14-stable review pat

Re: [PATCH 4.14 090/101] MIPS: c-r4k: Add r4k_blast_scache_node for Loongson-3

2019-01-07 Thread Sudip Mukherjee
Hi Greg, On Mon, Jan 7, 2019 at 1:14 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Huacai Chen > > commit bb53fdf395eed103f85061bfff3b116cee123895 upstream. This has been fixed by 66a4059ba72c

Re: [PATCH 4.14 069/101] spi: bcm2835: Fix race on DMA termination

2019-01-07 Thread Sudip Mukherjee
HI Greg, On Mon, Jan 7, 2019 at 1:15 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Lukas Wunner > > commit e82b0b3828451c1cd331d9f304c6078fcd43b62e upstream. This has been fixed later by

Re: [PATCH 4.14 002/101] net: core: Fix Spectre v1 vulnerability

2019-01-07 Thread Sudip Mukherjee
Hi Greg, On Mon, Jan 7, 2019 at 1:00 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: "Gustavo A. R. Silva" > > [ Upstream commit 50d5258634aee2e62832aa086d2fb0de00e72b91 ] This has been reverted

Re: [PATCH 4.14 001/101] phonet: af_phonet: Fix Spectre v1 vulnerability

2019-01-07 Thread Sudip Mukherjee
Hi Greg, On Mon, Jan 7, 2019 at 1:16 PM Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: "Gustavo A. R. Silva" > > [ Upstream commit d686026b1e6ed4ea27d630d8f54f9a694db088b2 ] This has been reverted

  1   2   3   4   5   6   7   8   9   10   >