Re: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-09-02 Thread Yoshihiro YUNOMAE
to do macro expansion here, so we need to fix this. (We don't use enum for traceevents.) Thanks, Yoshihiro YUNOMAE But we can make these tracepoints dependent on CONFIG_SCSI_CONSTANTS to still allow building lighter kernels if we really care about it. -- To unsubscribe from this list: send the l

Re: Re: [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-02 Thread Yoshihiro YUNOMAE
(2014/09/02 0:15), Christoph Hellwig wrote: On Mon, Sep 01, 2014 at 12:33:28PM +, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. As mentioned about three times in various previous scsi logging

Re: Re: [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-02 Thread Yoshihiro YUNOMAE
(2014/09/02 0:15), Christoph Hellwig wrote: On Mon, Sep 01, 2014 at 12:33:28PM +, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. As mentioned about three times in various previous scsi logging

Re: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-09-02 Thread Yoshihiro YUNOMAE
://vger.kernel.org/majordomo-info.html -- Yoshihiro YUNOMAE Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: yoshihiro.yunomae...@hitachi.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH 3/3] scsi/trace: Delete a duplicated decoder of SCSI command

2014-09-01 Thread Yoshihiro YUNOMAE
Zzz" including space. We use a decoder in constants, so this patch adds double quotes for the name. Note: - If CONFIG_SCSI_CONSTANTS is disabled, command names are not shown. - Add command names for 0x07 and 0x2b. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Ma

[PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-01 Thread Yoshihiro YUNOMAE
For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE Reviewed-by: Ewan D. Milne Reviewed-by: Hannes Reinecke Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc

[ PATCH -logging 0/3] scsi/trace: Delete duplicated decoders

2014-09-01 Thread Yoshihiro YUNOMAE
] This patchset is based on Hannes' logging branch: http://git.kernel.org/cgit/linux/kernel/git/hare/scsi-devel.git/log/?h=logging Thanks, Yoshihiro YUNOMAE --- Yoshihiro YUNOMAE (3): scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte scsi/trace: Delete duplicated

[PATCH 2/3] scsi/trace: Delete duplicated decoders of hostbyte and driverbyte

2014-09-01 Thread Yoshihiro YUNOMAE
There are decoders of hostbyte and driverbyte in constants.c, so this patch deletes those in SCSI traveevents. Note: If CONFIG_SCSI_CONSTANTS is disabled, hostbyte, driverbyte, msgbyte, and statusbyte are output as raw format from this patch. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke

Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-09-01 Thread Yoshihiro YUNOMAE
Hi Hannes, Sorry for the late reply. (2014/08/28 21:15), Hannes Reinecke wrote: On 08/28/2014 08:19 AM, Yoshihiro YUNOMAE wrote: Hi Hannes, I tried to remove duplicated decoder of SCSI command, but the output format of it in constants.c is different from it in traceevents. I have two

Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-09-01 Thread Yoshihiro YUNOMAE
Hi Hannes, Sorry for the late reply. (2014/08/28 21:15), Hannes Reinecke wrote: On 08/28/2014 08:19 AM, Yoshihiro YUNOMAE wrote: Hi Hannes, I tried to remove duplicated decoder of SCSI command, but the output format of it in constants.c is different from it in traceevents. I have two

[ PATCH -logging 0/3] scsi/trace: Delete duplicated decoders

2014-09-01 Thread Yoshihiro YUNOMAE
] This patchset is based on Hannes' logging branch: http://git.kernel.org/cgit/linux/kernel/git/hare/scsi-devel.git/log/?h=logging Thanks, Yoshihiro YUNOMAE --- Yoshihiro YUNOMAE (3): scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte scsi/trace: Delete duplicated

[PATCH 2/3] scsi/trace: Delete duplicated decoders of hostbyte and driverbyte

2014-09-01 Thread Yoshihiro YUNOMAE
There are decoders of hostbyte and driverbyte in constants.c, so this patch deletes those in SCSI traveevents. Note: If CONFIG_SCSI_CONSTANTS is disabled, hostbyte, driverbyte, msgbyte, and statusbyte are output as raw format from this patch. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae

[PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-01 Thread Yoshihiro YUNOMAE
For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Reviewed-by: Ewan D. Milne emi...@redhat.com Reviewed-by: Hannes Reinecke h...@suse.de Cc: Hannes Reinecke h

[PATCH 3/3] scsi/trace: Delete a duplicated decoder of SCSI command

2014-09-01 Thread Yoshihiro YUNOMAE
. We use a decoder in constants, so this patch adds double quotes for the name. Note: - If CONFIG_SCSI_CONSTANTS is disabled, command names are not shown. - Add command names for 0x07 and 0x2b. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc

Re: Re: Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-28 Thread Yoshihiro YUNOMAE
rds. (Ex2) traceevents: (nothing) constants: Set limits(12) => Should we merge those decoder? I understand we use the decoder of constants, but we need to solve these problems. Would you give me your comments? Thanks, Yoshihiro YUNOMAE (2014/08/28 10:40), Yoshihiro YUNOMAE wrote: (2014/08/27 23:

Re: Re: Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-28 Thread Yoshihiro YUNOMAE
) constants: Set limits(12) = Should we merge those decoder? I understand we use the decoder of constants, but we need to solve these problems. Would you give me your comments? Thanks, Yoshihiro YUNOMAE (2014/08/28 10:40), Yoshihiro YUNOMAE wrote: (2014/08/27 23:16), Hannes Reinecke wrote

Re: Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous printk messages of SCSI command can be mixed into other printk messages because multiple printk messages are output for it. To avoid the problem, patch 4e64bb8d6 in Hannes' branch(*1) introduced

Re: Re: [RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: There are no mean that additional sense code and additional sense code qualifier are output as different messages of sense key, so those information are added. Note: scsi_show_extd_sense() is changed

Re: Re: [RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:15), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous sense messages can be mixed into other sense messages, because continuous printk (KERN_CONT) was used. To avoid the problem, patch d87f3a6f51 introduced a local buffer in Hannes's baranch (*1

Re: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:12), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Current SCSI trace has hostbyte table and driverbyte table, so we don't need to have the same table in scsi/constants.c. - Result examples (printk) sd 2:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte

Re: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:12), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Current SCSI trace has hostbyte table and driverbyte table, so we don't need to have the same table in scsi/constants.c. - Result examples Before (printk) sd 2:0:0:0: [sda] Result: hostbyte=DID_OK

Re: Re: [RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:15), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous sense messages can be mixed into other sense messages, because continuous printk (KERN_CONT) was used. To avoid the problem, patch d87f3a6f51 introduced a local buffer in Hannes's baranch (*1

Re: Re: [RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: There are no mean that additional sense code and additional sense code qualifier are output as different messages of sense key, so those information are added. Note: scsi_show_extd_sense() is changed

Re: Re: [RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-27 Thread Yoshihiro YUNOMAE
(2014/08/27 23:16), Hannes Reinecke wrote: On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: Previous printk messages of SCSI command can be mixed into other printk messages because multiple printk messages are output for it. To avoid the problem, patch 4e64bb8d6 in Hannes' branch(*1) introduced

Re: Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-17 Thread Yoshihiro YUNOMAE
(2014/08/16 0:08), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because "[%s] Unrecognized sense data (in hex): %s" message is output many times in loop. Signed-off-by: Yoshihiro Y

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-17 Thread Yoshihiro YUNOMAE
Hi Ewan, Thank you for your review. (2014/08/16 0:05), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because "[%s] CDB: %s\n" message is output many times in loop. Signed-off-by: Yoshihiro Y

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-17 Thread Yoshihiro YUNOMAE
Hi Ewan, Thank you for your review. (2014/08/16 0:05), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because [%s] CDB: %s\n message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE

Re: Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-17 Thread Yoshihiro YUNOMAE
(2014/08/16 0:08), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because [%s] Unrecognized sense data (in hex): %s message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE

Re: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-12 Thread Yoshihiro YUNOMAE
Hi Elliot, Thank you for your comment. (2014/08/12 23:51), Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Yoshihiro YUNOMAE Sent: Friday, 08 August, 2014 6:50 AM ... Subject

Re: Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-12 Thread Yoshihiro YUNOMAE
Hi Douglas, Thank you for your comment. (2014/08/08 22:07), Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI printk messages in upstream kernel can be divided

Re: Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-12 Thread Yoshihiro YUNOMAE
Hi Douglas, Thank you for your comment. (2014/08/08 22:07), Douglas Gilbert wrote: On 14-08-08 01:50 PM, Yoshihiro YUNOMAE wrote: Hi All, This patch set introduces new traceevents in order to output continuous error messages. Current SCSI printk messages in upstream kernel can be divided

Re: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-12 Thread Yoshihiro YUNOMAE
Hi Elliot, Thank you for your comment. (2014/08/12 23:51), Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Yoshihiro YUNOMAE Sent: Friday, 08 August, 2014 6:50 AM ... Subject

[RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-08 Thread Yoshihiro YUNOMAE
. Sense: Unrecovered read error (ftrace, merged into scsi_print_sense traceevent) scsi_print_sense: host_no=2 channel=0 id=0 lun=0 [sda] Sense Key (Medium Error [current]) Add. Sense (Unrecovered read error) Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K

[RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-08 Thread Yoshihiro YUNOMAE
Unrecognized sense data should be output after linebuf is filled because "[%s] Unrecognized sense data (in hex): %s" message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc:

[RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-08 Thread Yoshihiro YUNOMAE
All bytes in CDB should be output after linebuf is filled because "[%s] CDB: %s\n" message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc

[RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-08 Thread Yoshihiro YUNOMAE
For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc: Hidehiro Kawai

[RFC PATCH 02/10] scsi/constants: Cleanup printk message in scsi_decode_sense_extras()

2014-08-08 Thread Yoshihiro YUNOMAE
If sense_flags and fixed_valid are zero, the kernel does not need to output a printk message. So, if those conditions are met, it just returns. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley

[RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
(10) scsi_print_command: host_no=2 channel=0 id=0 lun=0 [sda] CDB (Read(10)) Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc: Hidehiro Kawai Cc: Masami Hiramatsu --- drivers/scs

[RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
: host_no=2 channel=0 id=0 lun=0 [sda] Sense Key (Medium Error [current]) Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc: Hidehiro Kawai Cc: Masami Hiramatsu --- drivers/scsi/constants.c

[RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-08 Thread Yoshihiro YUNOMAE
A device name is output like "sda: Sense Key : Medium Error [current]" in __scsi_print_sense(), but it should be "[sda] Sense Key : Medium Error [current]" because other printk messages output a device name like "[sda] foo." Signed-off-by: Yoshihiro YUNOMAE Cc: Han

[RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-08 Thread Yoshihiro YUNOMAE
sd_print_sense_hdr() calls scsi_show_extd_sense(), but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). We can get same result, so we delete it. Note: Calling scsi_show_extd_sense() is introduced in fdd8b297. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc

[RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
=DRIVER_SENSE host=DID_OK) Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: "James E.J. Bottomley" Cc: Hidehiro Kawai Cc: Masami Hiramatsu --- drivers/scsi/constants.c

[RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-08 Thread Yoshihiro YUNOMAE
Any comments are welcome! Thanks, Yoshihiro YUNOMAE --- Yoshihiro YUNOMAE (10): scsi/constants: Cleanup printk message in __scsi_print_sense() scsi/constants: Cleanup printk message in scsi_decode_sense_extras() scsi/constants: Cleanup printk message in __scsi_print_command

[RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-08 Thread Yoshihiro YUNOMAE
Any comments are welcome! Thanks, Yoshihiro YUNOMAE --- Yoshihiro YUNOMAE (10): scsi/constants: Cleanup printk message in __scsi_print_sense() scsi/constants: Cleanup printk message in scsi_decode_sense_extras() scsi/constants: Cleanup printk message in __scsi_print_command

[RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-08 Thread Yoshihiro YUNOMAE
sd_print_sense_hdr() calls scsi_show_extd_sense(), but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). We can get same result, so we delete it. Note: Calling scsi_show_extd_sense() is introduced in fdd8b297. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes

[RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
] result=(driver=DRIVER_SENSE host=DID_OK) Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: James E.J. Bottomley jbottom

[RFC PATCH 08/10] scsi/trace: Use scsi_print_sense trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
) scsi_print_sense: host_no=2 channel=0 id=0 lun=0 [sda] Sense Key (Medium Error [current]) Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h

[RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-08 Thread Yoshihiro YUNOMAE
A device name is output like sda: Sense Key : Medium Error [current] in __scsi_print_sense(), but it should be [sda] Sense Key : Medium Error [current] because other printk messages output a device name like [sda] foo. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes

[RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-08 Thread Yoshihiro YUNOMAE
For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K. Petersen martin.peter

[RFC PATCH 02/10] scsi/constants: Cleanup printk message in scsi_decode_sense_extras()

2014-08-08 Thread Yoshihiro YUNOMAE
If sense_flags and fixed_valid are zero, the kernel does not need to output a printk message. So, if those conditions are met, it just returns. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K

[RFC PATCH 10/10] scsi/trace: Use scsi_print_command trace point instead of printk

2014-08-08 Thread Yoshihiro YUNOMAE
: Read(10) After scsi_print_command: host_no=2 channel=0 id=0 lun=0 [sda] CDB (Read(10)) Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig

[RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-08 Thread Yoshihiro YUNOMAE
All bytes in CDB should be output after linebuf is filled because [%s] CDB: %s\n message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc: Martin K. Petersen martin.peter

[RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-08 Thread Yoshihiro YUNOMAE
Unrecognized sense data should be output after linebuf is filled because [%s] Unrecognized sense data (in hex): %s message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes Reinecke h...@suse.de Cc: Doug Gilbert dgilb...@interlog.com Cc

[RFC PATCH 09/10] scsi/trace: Add additional sense code and additional sense code qualifier to scsi_print_sense trace point

2014-08-08 Thread Yoshihiro YUNOMAE
] Add. Sense: Unrecovered read error After (ftrace, merged into scsi_print_sense traceevent) scsi_print_sense: host_no=2 channel=0 id=0 lun=0 [sda] Sense Key (Medium Error [current]) Add. Sense (Unrecovered read error) Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Hannes

Re: Re: [PATCH V4 1/5] trace-cmd/listen: Apply the trace-msg protocol for communication between a server and clients

2014-07-23 Thread Yoshihiro YUNOMAE
Hi Steven, Thank you for your review. (2014/07/23 0:04), Steven Rostedt wrote: Sorry for taking so long to reply, I've been hacking on the kernel a bit and that takes precedence over user tools :-/ On Fri, 11 Jul 2014 00:58:26 + Yoshihiro YUNOMAE wrote: Apply trace-msg protocol

[PATCH] serial/core: Fix too big allocation for attribute member

2014-07-23 Thread Yoshihiro YUNOMAE
Current code allocates too much data for tty_groups member of uart_port struct, so fix it. Signed-off-by: Yoshihiro YUNOMAE CC: Greg Kroah-Hartman CC: Dan Carpenter --- drivers/tty/serial/serial_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial

[PATCH] serial/core: Fix too big allocation for attribute member

2014-07-23 Thread Yoshihiro YUNOMAE
Current code allocates too much data for tty_groups member of uart_port struct, so fix it. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com CC: Greg Kroah-Hartman gre...@linuxfoundation.org CC: Dan Carpenter dan.carpen...@oracle.com --- drivers/tty/serial/serial_core.c |2

Re: Re: [PATCH V4 1/5] trace-cmd/listen: Apply the trace-msg protocol for communication between a server and clients

2014-07-23 Thread Yoshihiro YUNOMAE
Hi Steven, Thank you for your review. (2014/07/23 0:04), Steven Rostedt wrote: Sorry for taking so long to reply, I've been hacking on the kernel a bit and that takes precedence over user tools :-/ On Fri, 11 Jul 2014 00:58:26 + Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote

[PATCH V9 1/2] Serial: allow port drivers to have a default attribute group

2014-07-15 Thread Yoshihiro YUNOMAE
From: Greg Kroah-Hartman Some serial drivers (like 8250), want to add sysfs files. We need to do so in a race-free way, so allow any port to be able to specify an attribute group that should be added at device creation time. Signed-off-by: Greg Kroah-Hartman Signed-off-by: Yoshihiro YUNOMAE

[PATCH V9 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-07-15 Thread Yoshihiro YUNOMAE
IFORTRIG definition - Pass the interrupt trigger value itself Signed-off-by: Yoshihiro YUNOMAE --- Documentation/ABI/testing/sysfs-tty | 16 +++ drivers/tty/serial/8250/8250.h |2 drivers/tty/serial/8250/8250_core.c | 173 --- include/linux/serial_8250.h

[ PATCH V9 0/2] serial/uart/8250: Introduce tunable RX trigger I/F

2014-07-15 Thread Yoshihiro YUNOMAE
rs to have a default attribute group Yoshihiro YUNOMAE (1): serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers Documentation/ABI/testing/sysfs-tty | 16 +++ drivers/tty/serial/8250/8250.h |2 drivers/tty/serial/8250/8250_core.c | 173 ++

[PATCH V9 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-07-15 Thread Yoshihiro YUNOMAE
for TIOCSFIFORTRIG definition - Pass the interrupt trigger value itself Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- Documentation/ABI/testing/sysfs-tty | 16 +++ drivers/tty/serial/8250/8250.h |2 drivers/tty/serial/8250/8250_core.c | 173

[ PATCH V9 0/2] serial/uart/8250: Introduce tunable RX trigger I/F

2014-07-15 Thread Yoshihiro YUNOMAE
group Yoshihiro YUNOMAE (1): serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers Documentation/ABI/testing/sysfs-tty | 16 +++ drivers/tty/serial/8250/8250.h |2 drivers/tty/serial/8250/8250_core.c | 173 --- drivers/tty

[PATCH V9 1/2] Serial: allow port drivers to have a default attribute group

2014-07-15 Thread Yoshihiro YUNOMAE
...@linuxfoundation.org Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- drivers/tty/serial/serial_core.c | 24 +--- include/linux/serial_core.h |2 ++ 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b

Re: Re: [PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-07-13 Thread Yoshihiro YUNOMAE
K, I'll test it. If it works for you, can you redo your second patch, and then send both of these back to me so that I can apply them? Sure. Thank you, Yoshihiro YUNOMAE -- Yoshihiro YUNOMAE Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Labora

Re: Re: [PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-07-13 Thread Yoshihiro YUNOMAE
, can you redo your second patch, and then send both of these back to me so that I can apply them? Sure. Thank you, Yoshihiro YUNOMAE -- Yoshihiro YUNOMAE Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: yoshihiro.yunomae...@hitachi.com

[PATCH V4 2/5] trace-cmd/msg: Use poll(2) to wait for a message

2014-07-10 Thread Yoshihiro YUNOMAE
() Fix some typos Signed-off-by: Yoshihiro YUNOMAE --- trace-msg.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/trace-msg.c b/trace-msg.c index 08fa2a6..db48365 100644 --- a/trace-msg.c +++ b/trace-msg.c @@ -395,6 +395,27

[PATCHV4 0/5] trace-cmd: Support the feature which guests send trace data via virtio

2014-07-10 Thread Yoshihiro YUNOMAE
[4/6] Change _nw/_NW to _net/_NET [5/6] Change _nw/_NW to _net/_NET [6/6] Add this patch based on Steven's review (https://lkml.org/lkml/2013/10/14/618) Changes in V2: [1/5] Add a comment in open_udp() [2/5] Regacy protocol support in order to keep backward compatibility Thank you, ---

[PATCH V4 5/5] trace-cmd/record: Add --virt option for record mode

2014-07-10 Thread Yoshihiro YUNOMAE
nges in V3: Change _nw/_NW to _net/_NET Signed-off-by: Yoshihiro YUNOMAE --- Documentation/trace-cmd-record.1.txt | 11 - trace-cmd.h |4 +- trace-msg.c | 79 +++--- trace-msg.h

[PATCH V4 1/5] trace-cmd/listen: Apply the trace-msg protocol for communication between a server and clients

2014-07-10 Thread Yoshihiro YUNOMAE
ched # sleep 5 # ./trace-cmd snapshot -s # ./trace-cmd extract -N :12345 -s Changes in V4: Fix some typos, cleanups and rebase for current trace-cmd-v2.4 Change the argument of tracecmd_msg_recv() Changes in V3: Change the license of trace-msg.c to LGPL v2.1 Cha

[PATCH V4 4/5] trace-cmd/virt-server: Add --dom option which makes a domain directory to virt-server

2014-07-10 Thread Yoshihiro YUNOMAE
-server --dom guest1 -c 2 - trace-cmd creates guest2 and guest3 directories # trace-cmd virt-server --dom guest2 -c 3 --dom guest3 -c 1 Changes in V4: Introduce parse_args_virt() Add usage of virt-server in trace-usage.c Signed-off-by: Yoshihiro YUNOMAE --- Documentation/trace

[PATCH V4 3/5] trace-cmd/virt-server: Add virt-server mode for a virtualization environment

2014-07-10 Thread Yoshihiro YUNOMAE
/) - Use named pipe I/Fs of virtio-serial for trace data paths - Use UNIX domain socket for connecting clients on guests - Use splice(2) for collecting trace data of guests - Use libvirt when we boot guests Changes in V4: Fix some typos and cleanup Changes in V3: Change _nw/_NW to _net/_NET S

[PATCH V4 5/5] trace-cmd/record: Add --virt option for record mode

2014-07-10 Thread Yoshihiro YUNOMAE
)) Changes in V3: Change _nw/_NW to _net/_NET Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- Documentation/trace-cmd-record.1.txt | 11 - trace-cmd.h |4 +- trace-msg.c | 79 +++--- trace

[PATCH V4 1/5] trace-cmd/listen: Apply the trace-msg protocol for communication between a server and clients

2014-07-10 Thread Yoshihiro YUNOMAE
() Changes in V3: Change the license of trace-msg.c to LGPL v2.1 Changes in V2: Regacy porotocol support in order to keep backward compatibility Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- Makefile |2 trace-cmd.h| 11 + trace-listen.c | 133 +++ trace

[PATCH V4 4/5] trace-cmd/virt-server: Add --dom option which makes a domain directory to virt-server

2014-07-10 Thread Yoshihiro YUNOMAE
. # trace-cmd virt-server --dom guest1 -c 2 - trace-cmd creates guest2 and guest3 directories # trace-cmd virt-server --dom guest2 -c 3 --dom guest3 -c 1 Changes in V4: Introduce parse_args_virt() Add usage of virt-server in trace-usage.c Signed-off-by: Yoshihiro YUNOMAE

[PATCH V4 3/5] trace-cmd/virt-server: Add virt-server mode for a virtualization environment

2014-07-10 Thread Yoshihiro YUNOMAE
-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- Documentation/trace-cmd-virt-server.1.txt | 89 ++ trace-cmd.c |3 trace-cmd.h |2 trace-listen.c| 467 - trace

[PATCH V4 2/5] trace-cmd/msg: Use poll(2) to wait for a message

2014-07-10 Thread Yoshihiro YUNOMAE
() Fix some typos Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- trace-msg.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/trace-msg.c b/trace-msg.c index 08fa2a6..db48365 100644 --- a/trace-msg.c +++ b

[PATCHV4 0/5] trace-cmd: Support the feature which guests send trace data via virtio

2014-07-10 Thread Yoshihiro YUNOMAE
in open_udp() [2/5] Regacy protocol support in order to keep backward compatibility Thank you, --- Yoshihiro YUNOMAE (5): trace-cmd/listen: Apply the trace-msg protocol for communication between a server and clients trace-cmd/msg: Use poll(2) to wait for a message trace-cmd

[ PATCH 0/2] [BUGFIX] trace-cmd: Fix two small bugs

2014-06-23 Thread Yoshihiro YUNOMAE
Hi Steven, I found two small bugs for current trace-cmd, so I fixed those. 1st patch fixes the problem which listen server reader processes abort silently. 2nd patch fixes the problem which trace-cmd cannot record trace data of multiple buffers in old kernels. Thank you, --- Yoshihiro YUNOMAE

[PATCH 1/2] trace-cmd: [BUGFIX] Initialize handle->options list in tracecmd_attach_cpu_data_fd()

2014-06-23 Thread Yoshihiro YUNOMAE
will be fully able to output the client's tracing data and we will not get this error. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven Rostedt --- trace-output.c |1 + 1 file changed, 1 insertion(+) diff --git a/trace-output.c b/trace-output.c index ed81466..b033baa 100644 --- a/trace-output.c +

[PATCH 2/2] trace-cmd: [BUGFIX] Don't die if an instance does not have 'current_tracer' file

2014-06-23 Thread Yoshihiro YUNOMAE
9-200 and 3.15.0-rc2+. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven Rostedt --- trace-record.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/trace-record.c b/trace-record.c index d3dd0c5..1912175 100644 --- a/trace-record.c +++ b/trace-record.c @@ -890,8 +890,18 @@

[PATCH 1/2] trace-cmd: [BUGFIX] Initialize handle-options list in tracecmd_attach_cpu_data_fd()

2014-06-23 Thread Yoshihiro YUNOMAE
will be fully able to output the client's tracing data and we will not get this error. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org --- trace-output.c |1 + 1 file changed, 1 insertion(+) diff --git a/trace-output.c b/trace-output.c index

[PATCH 2/2] trace-cmd: [BUGFIX] Don't die if an instance does not have 'current_tracer' file

2014-06-23 Thread Yoshihiro YUNOMAE
+. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org --- trace-record.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/trace-record.c b/trace-record.c index d3dd0c5..1912175 100644 --- a/trace-record.c +++ b

[ PATCH 0/2] [BUGFIX] trace-cmd: Fix two small bugs

2014-06-23 Thread Yoshihiro YUNOMAE
Hi Steven, I found two small bugs for current trace-cmd, so I fixed those. 1st patch fixes the problem which listen server reader processes abort silently. 2nd patch fixes the problem which trace-cmd cannot record trace data of multiple buffers in old kernels. Thank you, --- Yoshihiro YUNOMAE

[RESEND PATCH V8 0/2] serial/uart/8250: Introduce tunable RX trigger I/F

2014-06-19 Thread Yoshihiro YUNOMAE
on - Pass the interrupt trigger value itself --- Yoshihiro YUNOMAE (2): serial/uart: Introduce device specific attribute group to uart_port structure serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers Documentation/ABI/testing/sysfs-tty | 16 +++ driver

[RESEND PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-06-19 Thread Yoshihiro YUNOMAE
er p->fcr is existing at serial8250_clear_and_reinit_fifos() - Set fcr = up->fcr in the begging of serial8250_do_set_termios() Changes in V3: - Change I/F from ioctl(2) to sysfs(rx_int_trig) Changed in V2: - Use _IOW for TIOCSFIFORTRIG definition - Pass the interrupt trigger value itself Signed-off-by: Yoshihiro YUNO

[RESEND PATCH V8 1/2] serial/uart: Introduce device specific attribute group to uart_port structure

2014-06-19 Thread Yoshihiro YUNOMAE
on Greg's comment Signed-off-by: Yoshihiro YUNOMAE --- drivers/tty/serial/serial_core.c | 18 +++--- include/linux/serial_core.h |4 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c

Re: [tracing] 939c7a4f04f: -46.4% cpuidle.C3-IVT.time

2014-06-19 Thread Yoshihiro YUNOMAE
ood sample [O] bisect-bad sample Disclaimer: Results have been estimated based on internal Intel analysis and are provided for informational purposes only. Any difference in system hardware or software design or configuration may affect actual performance. Thanks, Jet -- Yoshihiro YUNOMA

Re: [tracing] 939c7a4f04f: -46.4% cpuidle.C3-IVT.time

2014-06-19 Thread Yoshihiro YUNOMAE
[O] bisect-bad sample Disclaimer: Results have been estimated based on internal Intel analysis and are provided for informational purposes only. Any difference in system hardware or software design or configuration may affect actual performance. Thanks, Jet -- Yoshihiro YUNOMAE Software

[RESEND PATCH V8 1/2] serial/uart: Introduce device specific attribute group to uart_port structure

2014-06-19 Thread Yoshihiro YUNOMAE
on Greg's comment Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com --- drivers/tty/serial/serial_core.c | 18 +++--- include/linux/serial_core.h |4 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b

[RESEND PATCH V8 2/2] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

2014-06-19 Thread Yoshihiro YUNOMAE
: These sysfs values expose the TIOCGSERIAL interface via sysfs rather than via ioctls. + +What: /sys/class/tty/ttyS0/rx_trig_bytes +Date: May 2014 +Contact: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com +Description: +Shows

[RESEND PATCH V8 0/2] serial/uart/8250: Introduce tunable RX trigger I/F

2014-06-19 Thread Yoshihiro YUNOMAE
trigger value itself --- Yoshihiro YUNOMAE (2): serial/uart: Introduce device specific attribute group to uart_port structure serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers Documentation/ABI/testing/sysfs-tty | 16 +++ drivers/tty/serial/8250/8250.h

Re: [PATCH ftrace/core] tracing: Remove return value in event_trace_self_tests() when top_trace_array() returns NULL

2014-06-06 Thread Yoshihiro YUNOMAE
Hi Steven, Thank you for applying my patches. I received build warning report from kbuild test bot, so I fixed it. Would you apply this patch? Thank you, Yoshihiro YUNOMAE (2014/06/06 15:28), Yoshihiro YUNOMAE wrote: Remove return value in event_trace_self_tests() when top_trace_array

[PATCH ftrace/core] tracing: Remove return value in event_trace_self_tests() when top_trace_array() returns NULL

2014-06-06 Thread Yoshihiro YUNOMAE
Remove return value in event_trace_self_tests() when top_trace_array() returns NULL because event_trace_self_tests() is void type. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace_events.c |2 +- 1 file changed, 1

[PATCH ftrace/core] tracing: Remove return value in event_trace_self_tests() when top_trace_array() returns NULL

2014-06-06 Thread Yoshihiro YUNOMAE
Remove return value in event_trace_self_tests() when top_trace_array() returns NULL because event_trace_self_tests() is void type. Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Ingo Molnar mi...@redhat.com Cc: linux-kernel

Re: [PATCH ftrace/core] tracing: Remove return value in event_trace_self_tests() when top_trace_array() returns NULL

2014-06-06 Thread Yoshihiro YUNOMAE
Hi Steven, Thank you for applying my patches. I received build warning report from kbuild test bot, so I fixed it. Would you apply this patch? Thank you, Yoshihiro YUNOMAE (2014/06/06 15:28), Yoshihiro YUNOMAE wrote: Remove return value in event_trace_self_tests() when top_trace_array

[PATCH ftrace/core 0/3] ftrace: Fix three small bugs

2014-06-05 Thread Yoshihiro YUNOMAE
Hi Steven, I found three small bugs for current ftrace/core, so I fixed those. Would you apply these patches? Thanks! --- Yoshihiro YUNOMAE (3): trace/event: Return error if ftrace_trace_arrays is empty list trace/kprobes: Avoid self tests if tracing is disabled on boot up

[PATCH ftrace/core 3/3] trace: Fix memory leak when new instance creation failed

2014-06-05 Thread Yoshihiro YUNOMAE
Current new_instance_create() implements just two fail paths for four allocation operations. So, it can induce memory leak if new instance creation failed. This patch fixes it by defining all fail paths and freeing allocated memories appropriately. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven

[PATCH ftrace/core 1/3] trace/event: Return error if ftrace_trace_arrays is empty list

2014-06-05 Thread Yoshihiro YUNOMAE
it appropriately. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace.h|3 +++ kernel/trace/trace_events.c | 13 + 2 files changed, 16 insertions(+) diff --git a/kernel/trace/trace.h b/kernel/trace

[PATCH ftrace/core 2/3] trace/kprobes: Avoid self tests if tracing is disabled on boot up

2014-06-05 Thread Yoshihiro YUNOMAE
If tracing is disabled on boot up, the kernel should not execute self tests. In this patch, the kernel checks whether tracing is disabled or not before executing self tests. Signed-off-by: Yoshihiro YUNOMAE Cc: Steven Rostedt Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: linux-kernel

  1   2   3   4   5   >