On Tue, Apr 20, 2021 at 12:15:40PM CDT, Mark Brown wrote:
On Tue, Apr 20, 2021 at 11:40:24AM -0500, Zev Weiss wrote:
On Tue, Apr 20, 2021 at 11:13:18AM CDT, Mark Brown wrote:
> I already suggested writing a driver or drivers that represent the
> hardware you have, that advice remains.
On Tue, Apr 20, 2021 at 11:13:18AM CDT, Mark Brown wrote:
On Tue, Apr 20, 2021 at 10:19:04AM -0500, Zev Weiss wrote:
Mark, do you have any further input on what a viable approach might look
like?
I already suggested writing a driver or drivers that represent the
hardware you have
On Tue, Apr 20, 2021 at 05:52:16AM CDT, Guenter Roeck wrote:
On 4/20/21 12:06 AM, Zev Weiss wrote:
On Tue, Apr 20, 2021 at 01:00:25AM CDT, Guenter Roeck wrote:
On 4/19/21 10:50 PM, Zev Weiss wrote:
[ ... ]
I had a glance at the enclosure driver; it looks pretty geared toward SES-like things
On Tue, Apr 20, 2021 at 01:00:25AM CDT, Guenter Roeck wrote:
On 4/19/21 10:50 PM, Zev Weiss wrote:
[ ... ]
I had a glance at the enclosure driver; it looks pretty geared toward SES-like things
(drivers/scsi/ses.c being its only usage I can see in the kernel at the moment) and while
it could
On Mon, Apr 19, 2021 at 10:36:48PM CDT, Guenter Roeck wrote:
On Mon, Apr 19, 2021 at 08:29:53PM -0500, Zev Weiss wrote:
On Tue, Mar 30, 2021 at 02:38:10PM CDT, Guenter Roeck wrote:
> On Tue, Mar 30, 2021 at 07:02:00PM +0100, Mark Brown wrote:
> > On Tue, Mar 30, 2021 at 12:56:56PM -
On Tue, Mar 30, 2021 at 02:38:10PM CDT, Guenter Roeck wrote:
On Tue, Mar 30, 2021 at 07:02:00PM +0100, Mark Brown wrote:
On Tue, Mar 30, 2021 at 12:56:56PM -0500, Zev Weiss wrote:
> Okay, to expand a bit on the description in my initial message -- we've
> got a single chassis with mu
.
Signed-off-by: Zev Weiss
---
The relevant aspeed-vuart patches [0] have been merged into Greg KH's
tty-next tree, so I figure it's probably okay to proceed with the
corresponding dts adjustments now.
[0]
https://lore.kernel.org/openbmc/20210412034712.16778-1-...@bewilderbeest.net/
arch/arm/boot
These correspond to the existing lpc_address, sirq, and sirq_polarity
sysfs attributes; the second element of aspeed,lpc-interrupts provides
a replacement for the deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
Reviewed-by: Rob Herring
---
.../devicetree/bindings
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers. While we're at it,
these functions now provide some basic bounds-checking on their
arguments.
Signed-off-by: Zev
These allow describing all the Aspeed VUART attributes currently
available via sysfs. aspeed,lpc-interrupts provides a replacement for
the deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 51 -
1 file
/20210408011637.5361-1-...@bewilderbeest.net/
Zev Weiss (4):
dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense
serial: 8250_aspeed_vuart: refactor sirq and lpc address setting code
serial: 8250_aspeed_vuart: add aspeed,lpc-io-reg and
aspeed,lpc-interrupts DT properties
dt
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it was
removed in commit c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq
polarity").
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
Acked-by: R
On Sun, Apr 11, 2021 at 09:20:59PM CDT, Joel Stanley wrote:
On Mon, 12 Apr 2021 at 02:16, Andrew Jeffery wrote:
On Thu, 1 Apr 2021, at 15:12, Zev Weiss wrote:
> + {
> + status = "okay";
> + aspeed,sirq-active-high;
This should probably go away, but otherwi
On Fri, Apr 09, 2021 at 01:25:26AM CDT, Zev Weiss wrote:
>On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote:
>>
>>
>>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote:
>>>On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote:
>>>>Make the KCS
On Fri, Apr 09, 2021 at 12:48:21AM CDT, Andrew Jeffery wrote:
>
>
>On Fri, 9 Apr 2021, at 13:26, Zev Weiss wrote:
>> On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote:
>> >Take steps towards defining a coherent API to separate the KCS device
>> >dri
On Fri, Apr 09, 2021 at 12:44:04AM CDT, Zev Weiss wrote:
>On Fri, Apr 09, 2021 at 12:33:10AM CDT, Andrew Jeffery wrote:
>>
>>
>>On Fri, 9 Apr 2021, at 14:45, Zev Weiss wrote:
>>>On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote:
>>>>Given t
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
On Thursday, April 8, 2021, Zev Weiss wrote:
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers
On Fri, Apr 09, 2021 at 12:06:16AM CDT, Andrew Jeffery wrote:
On Thu, 8 Apr 2021, at 10:46, Zev Weiss wrote:
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers
On Fri, Apr 09, 2021 at 12:14:54AM CDT, Andrew Jeffery wrote:
Hi Zev,
A couple of minor comments:
On Thu, 8 Apr 2021, at 10:46, Zev Weiss wrote:
These allow describing all the Aspeed VUART attributes currently
available via sysfs. aspeed,sirq
aspeed,lpc-interrupts now
Ah right, thanks
On Fri, Apr 09, 2021 at 12:59:09AM CDT, Andrew Jeffery wrote:
>
>
>On Fri, 9 Apr 2021, at 13:27, Zev Weiss wrote:
>> On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote:
>> >Make the KCS device drivers responsible for allocating their own memory.
>> &g
On Fri, Apr 09, 2021 at 12:33:10AM CDT, Andrew Jeffery wrote:
>
>
>On Fri, 9 Apr 2021, at 14:45, Zev Weiss wrote:
>> On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote:
>> >Given the deprecated binding, improve the ability to detect issues in
>> >
On Fri, Mar 19, 2021 at 01:27:51AM CDT, Andrew Jeffery wrote:
>Input Buffer Full Interrupt Enable (IBFIE) is typoed as IBFIF for some
>registers in the datasheet. Fix the driver to use the sensible acronym.
>
>Signed-off-by: Andrew Jeffery
Reviewed-by: Zev Weiss
On Fri, Mar 19, 2021 at 01:27:39AM CDT, Andrew Jeffery wrote:
>Rename the functions in preparation for separating the IPMI chardev out
>from the KCS BMC core.
>
>Signed-off-by: Andrew Jeffery
Reviewed-by: Zev Weiss
fery
Reviewed-by: Zev Weiss
On Fri, Mar 19, 2021 at 01:27:47AM CDT, Andrew Jeffery wrote:
>The existing IPMI chardev encodes IPMI behaviours as the name suggests.
>However, KCS devices are useful beyond IPMI (or keyboards), as they
>provide a means to generate IRQs and exchange arbitrary data between a
>BMC and its host
On Fri, Mar 19, 2021 at 01:27:48AM CDT, Andrew Jeffery wrote:
>Given the deprecated binding, improve the ability to detect issues in
>the platform devicetrees. Further, a subsequent patch will introduce a
>new interrupts property for specifying SerIRQ behaviour, so convert
>before we do any
On Fri, Mar 19, 2021 at 01:27:46AM CDT, Andrew Jeffery wrote:
>Soon it will be possible for one KCS device to have multiple associated
>chardevs exposed to userspace (for IPMI and raw-style access). However,
>don't prevent userspace from:
>
>1. Opening more than one chardev at a time, or
>2.
On Fri, Mar 19, 2021 at 01:27:45AM CDT, Andrew Jeffery wrote:
>Add a mechanism for controlling whether the client associated with a
>KCS device will receive Input Buffer Full (IBF) and Output Buffer Empty
>(OBE) events. This enables an abstract implementation of poll() for KCS
>devices.
>
>A wart
On Fri, Mar 19, 2021 at 01:27:44AM CDT, Andrew Jeffery wrote:
>Now that we have untangled the data-structures, split the userspace
>interface out into its own module. Userspace interfaces and drivers are
>registered to the KCS BMC core to support arbitrary binding of either.
>
>Signed-off-by:
On Fri, Mar 19, 2021 at 01:27:41AM CDT, Andrew Jeffery wrote:
>Make the KCS device drivers responsible for allocating their own memory.
>
>Until now the private data for the device driver was allocated internal
>to the private data for the chardev interface. This coupling required
>the slightly
On Fri, Mar 19, 2021 at 01:27:37AM CDT, Andrew Jeffery wrote:
>Unpack and remove the aspeed_kcs_probe_of_v[12]() functions to aid
>rearranging how the private device-driver memory is allocated.
>
>Signed-off-by: Andrew Jeffery
>---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 146
On Fri, Mar 19, 2021 at 01:27:43AM CDT, Andrew Jeffery wrote:
>Move all client-private data out of `struct kcs_bmc` into the KCS client
>implementation.
>
>With this change the KCS BMC core code now only concerns itself with
>abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving
On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote:
>Strengthen the distinction between code that abstracts the
>implementation of the KCS behaviours (device drivers) and code that
>exploits KCS behaviours (clients). Neither needs to know about the APIs
>required by the other, so provide
On Fri, Mar 19, 2021 at 01:27:40AM CDT, Andrew Jeffery wrote:
>Take steps towards defining a coherent API to separate the KCS device
>drivers from the userspace interface. Decreasing the coupling will
>improve the separation of concerns and enable the introduction of
>alternative userspace
These correspond to the existing lpc_address, sirq, and sirq_polarity
sysfs attributes; the second element of aspeed,lpc-interrupts provides
a replacement for the deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
.../devicetree/bindings/serial/8250.yaml | 27
These allow describing all the Aspeed VUART attributes currently
available via sysfs. aspeed,sirq provides a replacement for the
deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 44 -
1 file changed
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers. While we're at it,
these functions now provide some basic bounds-checking on their
arguments.
Signed-off-by: Zev
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it was
removed in commit c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq
polarity").
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
---
Documentation/
://lore.kernel.org/openbmc/20210402182724.20848-1-...@bewilderbeest.net/
Zev Weiss (4):
dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense
drivers/tty/serial/8250: refactor sirq and lpc address setting code
drivers/tty/serial/8250: add aspeed,lpc-io-reg and
aspeed,lpc-interrupts DT
On Wed, Apr 07, 2021 at 12:25:09PM CDT, Greg Kroah-Hartman wrote:
On Wed, Apr 07, 2021 at 11:56:04AM -0500, Zev Weiss wrote:
On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:
> On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:
> > This property ties SIRQ polari
On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:
On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it
was removed in commit
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers. While we're at it,
these functions now provide some basic bounds-checking on their
arguments.
Signed-off-by: Zev
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it
was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
---
Documentation/devicetree/bindings/serial
These correspond to the existing lpc_address, sirq, and sirq_polarity
sysfs attributes; the second element of aspeed,lpc-interrupts provides
a replacement for the deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
.../devicetree/bindings/serial/8250.yaml | 27
These allow describing all the Aspeed VUART attributes currently
available via sysfs. aspeed,sirq provides a replacement for the
deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 44 -
1 file changed
/20210401005702.28271-1-...@bewilderbeest.net/
[1] https://lore.kernel.org/openbmc/20210330002338.335-1-...@bewilderbeest.net/
[2]
https://lore.kernel.org/openbmc/20210402004716.15961-1-...@bewilderbeest.net/
Zev Weiss (4):
dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense
drivers/tty
On Thu, Apr 01, 2021 at 08:14:39PM CDT, Andrew Jeffery wrote:
On Fri, 2 Apr 2021, at 11:17, Zev Weiss wrote:
These correspond to the existing lpc_address, sirq, and sirq_polarity
sysfs attributes; the second element of aspeed,sirq provides a
replacement for the deprecated aspeed,sirq-polarity
These correspond to the existing lpc_address, sirq, and sirq_polarity
sysfs attributes; the second element of aspeed,sirq provides a
replacement for the deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
.../devicetree/bindings/serial/8250.yaml | 27
These allow describing all the Aspeed VUART attributes currently
available via sysfs. aspeed,sirq provides a replacement for the
deprecated aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 44 -
1 file changed
This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
out of the sysfs store functions in preparation for adding DT
properties that will be poking the same registers. While we're at it,
these functions now provide some basic bounds-checking on their
arguments.
Signed-off-by: Zev
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it
was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
---
Documentation/devicetree/bindings/serial
/20210330002338.335-1-...@bewilderbeest.net/
Zev Weiss (4):
dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense
drivers/tty/serial/8250: refactor sirq and lpc address setting code
drivers/tty/serial/8250: add aspeed,lpc-address and aspeed,sirq DT
properties
dt-bindings: serial: 8250: add
On Fri, Mar 19, 2021 at 01:27:52AM CDT, Andrew Jeffery wrote:
>Some Aspeed KCS devices can derive the status register address from the
>address of the data register. As such, the address of the status
>register can be implicit in the configuration if desired. On the other
>hand, sometimes address
On Fri, Mar 19, 2021 at 01:27:50AM CDT, Andrew Jeffery wrote:
>Apply the SerIRQ ID and level/sense behaviours from the devicetree if
>provided.
>
>Signed-off-by: Andrew Jeffery
>---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 179 -
> 1 file changed, 177 insertions(+), 2
>Please review!
>
>Andrew
>
After rebasing the series onto the OpenBMC dev-5.10 kernel (with only a
tiny conflict for the addition of the ast2600 entry in
ast_kcs_bmc_match) and enabling CONFIG_IPMI_KCS_BMC_CDEV_IPMI, my
e3c246d4i system booted healthily and handled some basic ipmitool
operations as expected.
Tested-by: Zev Weiss
Zev
On Thu, Apr 01, 2021 at 12:34:04AM CDT, Andrew Jeffery wrote:
On Thu, 1 Apr 2021, at 15:48, Zev Weiss wrote:
On Wed, Mar 31, 2021 at 11:15:44PM CDT, Joel Stanley wrote:
>On Thu, 1 Apr 2021 at 00:57, Zev Weiss wrote:
>>
>> This provides a simple boolean to use instead of
On Wed, Mar 31, 2021 at 11:15:44PM CDT, Joel Stanley wrote:
On Thu, 1 Apr 2021 at 00:57, Zev Weiss wrote:
This provides a simple boolean to use instead of the deprecated
aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 3 +++
1
On Wed, Mar 31, 2021 at 11:04:44PM CDT, Andrew Jeffery wrote:
On Thu, 1 Apr 2021, at 11:27, Zev Weiss wrote:
This provides a simpler, more direct alternative to the deprecated
aspeed,sirq-polarity-sense property for indicating the polarity of
the Aspeed VUART's SIRQ line.
Signed-off-by: Zev
support, and POST code snooping.
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
---
Changes since v2:
- un-bungled filename in dtb-$(CONFIG_ARCH_ASPEED)
Changes since v1:
- added entry to dtb-$(CONFIG_ARCH_ASPEED)
- added board to compatible
- added pinctrl properties to adc
- split out
On Wed, Mar 31, 2021 at 10:51:42PM CDT, Joel Stanley wrote:
Hi Zev,
On Thu, 1 Apr 2021 at 02:57, Zev Weiss wrote:
This is a relatively low-cost AST2500-based Xeon E-2100/E-2200 series
mini-ITX board that we hope can provide a decent platform for OpenBMC
development.
This initial device-tree
support, and POST code snooping.
Signed-off-by: Zev Weiss
Reviewed-by: Joel Stanley
---
arch/arm/boot/dts/Makefile| 1 +
.../boot/dts/aspeed-bmc-asrock-e3c246d4i.dts | 202 ++
2 files changed, 203 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed-bmc
This provides a simpler, more direct alternative to the deprecated
aspeed,sirq-polarity-sense property for indicating the polarity of
the Aspeed VUART's SIRQ line.
Signed-off-by: Zev Weiss
---
Documentation/devicetree/bindings/serial/8250.yaml | 13 ++---
1 file changed, 10 insertions
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it
was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.
Signed-off-by: Zev Weiss
---
Documentation/devicetree/bindings/serial/8250.yaml | 1 +
1 file
(aspeed,sirq-active-high) to use instead.
Changes since v1:
- deprecate and retain aspeed,sirq-polarity-sense instead of removing it
- drop e3c246d4i dts addition from this series
Zev Weiss (3):
dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense
drivers/tty/serial/8250: add
This provides a simple boolean to use instead of the deprecated
aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c
b/drivers/tty/serial
On Wed, Mar 31, 2021 at 07:04:51PM CDT, Andrew Jeffery wrote:
On Tue, 30 Mar 2021, at 10:53, Zev Weiss wrote:
This is a relatively low-cost AST2500-based Xeon E-2100/E-2200 series
mini-ITX board that we hope can provide a decent platform for OpenBMC
development.
This initial device-tree
On Tue, Mar 30, 2021 at 05:39:02PM CDT, Rob Herring wrote:
On Mon, Mar 29, 2021 at 07:23:37PM -0500, Zev Weiss wrote:
Update DT bindings documentation for the new incarnation of the
aspeed,sirq-polarity-sense property.
Why?
This isn't a compatible change.
Ah, sorry
On Tue, Mar 30, 2021 at 12:42:21PM CDT, Mark Brown wrote:
On Tue, Mar 30, 2021 at 12:19:29PM -0500, Zev Weiss wrote:
On Tue, Mar 30, 2021 at 06:22:54AM CDT, Mark Brown wrote:
> On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:
> > (and I don't know if the userspace cons
On Tue, Mar 30, 2021 at 06:22:54AM CDT, Mark Brown wrote:
On Tue, Mar 30, 2021 at 03:34:16AM -0700, Guenter Roeck wrote:
(and I don't know if the userspace consumer code is appropriate - you
might want to check with the regulator maintainer on that).
It's not, you should never see this in a
Hello,
I'm working on a board that has a handful of LM25066 PMICs controlling
the power supply to various devices, and I'd like to have both the
existing hwmon sensor functionality as well as userspace power on/off
control, which does not currently seem to be available (other than via
'i2cset
The initial implementation of this configuration conflated the SIRQ
polarity setting with the syscon eSPI/LPC strapping; this patch
disentangles them by reducing the DT config to a simple boolean.
Signed-off-by: Zev Weiss
---
drivers/tty/serial/8250/8250_aspeed_vuart.c | 39
support, and POST code snooping.
Signed-off-by: Zev Weiss
---
.../boot/dts/aspeed-bmc-asrock-e3c246d4i.dts | 188 ++
1 file changed, 188 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dts
diff --git a/arch/arm/boot/dts/aspeed-bmc-asrock
(aspeed,sirq-polarity-sense never really had one) in the form of a
device tree for the ASRock E3C246D4I BMC, an OpenBMC target in
progress at Equinix Metal (formerly known as Packet).
Zev Weiss (3):
drivers/tty/serial/8250: simplify Aspeed VUART SIRQ polarity DT config
dt-bindings: serial
Update DT bindings documentation for the new incarnation of the
aspeed,sirq-polarity-sense property.
Signed-off-by: Zev Weiss
---
Documentation/devicetree/bindings/serial/8250.yaml | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree
On Tue, Dec 22, 2020 at 08:53:33PM CST, Ryan Chen wrote:
-Original Message-
From: Joel Stanley
Sent: Wednesday, December 23, 2020 9:07 AM
To: Zev Weiss ; Ryan Chen
Cc: Eddie James ; Mauro Carvalho Chehab
; Andrew Jeffery ;
linux-me...@vger.kernel.org; OpenBMC Maillist ;
Linux ARM
On Mon, Dec 21, 2020 at 10:47:37PM CST, Joel Stanley wrote:
On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote:
Instead of testing and conditionally clearing them one by one, we can
instead just unconditionally clear them all at once.
Signed-off-by: Zev Weiss
I had a poke at the assembly
On Mon, Dec 21, 2020 at 10:34:26PM CST, Joel Stanley wrote:
On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote:
Signed-off-by: Zev Weiss
---
drivers/media/platform/aspeed-video.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/aspeed-video.c
b/drivers/media
On Tue, Sep 15, 2020 at 01:45:25PM CDT, Zev Weiss wrote:
The ast25xx and ast26xx have, respectively, two and three configurable
slave device addresses to the ast24xx's one. We only support using
one at a time, but the others may come up in an indeterminate state
depending on hardware/bootloader
in the event of unhandled interrupt status bits should
hopefully make the debugging process simpler for any others that pop up
in the future.
Signed-off-by: Zev Weiss
---
drivers/media/platform/aspeed-video.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/aspeed-video.c
These patches build on commit 65d270acb2d6 to address a similar
problem we've observed with a different interrupt. The first patch
adds an error message so that any others that are discovered in the
future are easier to diagnose (this one took a while to reproduce and
identify).
Zev Weiss (3
Instead of testing and conditionally clearing them one by one, we can
instead just unconditionally clear them all at once.
Signed-off-by: Zev Weiss
---
drivers/media/platform/aspeed-video.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media
This joins CAPTURE_COMPLETE and FRAME_COMPLETE in the set of interrupts
that have been seen asserted by the hardware even when disabled, leading
to the interrupt eventually getting disabled as described in commit
65d270acb2d662c3346793663ac3a759eb4491b8.
Signed-off-by: Zev Weiss
---
drivers
as to avoid ending up with phantom devices on the bus.
Signed-off-by: Zev Weiss
---
drivers/i2c/busses/i2c-aspeed.c | 50 +++--
1 file changed, 41 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index
On Thu, Feb 07, 2019 at 09:51:44AM CST, Luis Chamberlain wrote:
On Thu, Feb 07, 2019 at 06:34:23AM -0600, Zev Weiss wrote:
Hello,
After being left with an unusable system after a typo executing
something like 'echo $((1<<24)) > /proc/sys/vm/max_map_count'
counterparts (plus the added check).
Signed-off-by: Zev Weiss
---
kernel/sysctl.c | 59 ++---
1 file changed, 27 insertions(+), 32 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index a71c4b3935bc..4b6bce36737e 100644
--- a/kernel
counterparts (plus the added check).
Signed-off-by: Zev Weiss
---
kernel/sysctl.c | 59 ++---
1 file changed, 27 insertions(+), 32 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index a71c4b3935bc..4b6bce36737e 100644
--- a/kernel/sysctl.c
ding check in do_proc_dointvec_conv().
Cc: # v2.6.2+
Signed-off-by: Zev Weiss
---
kernel/sysctl.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 5fc724e4e454..a71c4b3935bc 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
At present this exposes a bug in do_proc_dointvec_minmax_conv() (it
fails to check for values that are too wide to fit in an int).
Signed-off-by: Zev Weiss
---
tools/testing/selftests/sysctl/sysctl.sh | 55
1 file changed, 55 insertions(+)
diff --git a/tools/testing
intaining the
passing status of the selftest).
Changes in v2:
- Rearranged selftest to also test negative values and provide more
info in comments
- Added intermediate patch as a minimal fix for -stable without the
refactoring
Thanks,
Zev Weiss
Ping...any thoughts on these patches? (May have slipped through the
cracks over people's holiday vacations I'd guess.)
Thanks,
Zev
On Thu, Dec 27, 2018 at 05:12:28AM CST, Zev Weiss wrote:
Hello,
After being left with an unusable system after a typo executing
something like 'echo $((1<
g patches enhances the sysctl selftest such
that it detects this problem; the second fixes it (wasn't entirely
sure if this would meet the criteria of something that should be sent
to -stable; input welcome).
Thanks,
Zev Weiss
At present this exposes a bug in do_proc_dointvec_minmax_conv() (it
fails to check for values that are too wide to fit in an int).
Signed-off-by: Zev Weiss
---
tools/testing/selftests/sysctl/sysctl.sh | 37
1 file changed, 37 insertions(+)
diff --git a/tools/testing
to be defined in terms of their non-bounded counterparts
(plus the added check).
Signed-off-by: Zev Weiss
---
kernel/sysctl.c | 50 ++---
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 5fc724e4e454
It's a fairly inconsequential bug, since fdput() won't actually try to
fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in
the failure case, but most other vfs code takes steps to avoid this.
Signed-off-by: Zev Weiss <z...@bewilderbeest.net>
---
fs/read_write.c | 6 +++---
It's a fairly inconsequential bug, since fdput() won't actually try to
fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in
the failure case, but most other vfs code takes steps to avoid this.
Signed-off-by: Zev Weiss
---
fs/read_write.c | 6 +++---
1 file changed, 3 insertions
On Thu, Aug 31, 2017 at 08:54:07AM CDT, Steven Rostedt wrote:
On Thu, 31 Aug 2017 02:01:08 -0500
Zev Weiss <z...@bewilderbeest.net> wrote:
Hello,
It appears stack_tracer_disable()/stack_tracer_enable() have been
using the wrong name for the config symbol to enable their
preempt-deb
On Thu, Aug 31, 2017 at 08:54:07AM CDT, Steven Rostedt wrote:
On Thu, 31 Aug 2017 02:01:08 -0500
Zev Weiss wrote:
Hello,
It appears stack_tracer_disable()/stack_tracer_enable() have been
using the wrong name for the config symbol to enable their
preempt-debugging checks, which the patch
instead of zero).
Zev Weiss
---
include/linux/ftrace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index 6383115e9d2c..2e028854bac7 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -307,7 +307,7
instead of zero).
Zev Weiss
---
include/linux/ftrace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index 6383115e9d2c..2e028854bac7 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -307,7 +307,7
Commit-ID: 599b4840b0ea453c7d11e1798dcc8f494dcfd58a
Gitweb: http://git.kernel.org/tip/599b4840b0ea453c7d11e1798dcc8f494dcfd58a
Author: Zev Weiss <z...@bewilderbeest.net>
AuthorDate: Sun, 26 Jun 2016 16:13:23 -0500
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Mon, 27
1 - 100 of 105 matches
Mail list logo
