Re: [PATCH 3/3] Input: synaptics-rmi4 - log when we create a guest serio port

Reviewed-by: Lyude Paul On Thu, 2018-01-18 at 16:49 -0800, Dmitry Torokhov wrote: > To ease analyzing boot behavior from logs, let's log when we are about to > register the pass-through serio port. > > Also, let's drop "Synaptics" prefix from the port name, as RMI4 is good > enough indicator alr

Re: [PATCH 2/3] Input: synaptics_rmi4 - unmask F03 interrupts when port is opened

Looks good to me. Reviewed-by: Lyude Paul On Thu, 2018-01-18 at 16:49 -0800, Dmitry Torokhov wrote: > Currently we register the pass-through serio port when we probe the F03 RMI > function, and then, in sensor configure phase, we unmask interrupts. > Unfortunately this is too late, as other driv

Re: [PATCH 1/3] Input: synaptics_rmi4 - do not delete interrupt memory too early

Reviewed-by: Lyude Paul (hope you don't mind that I'm using my gmail address for this ;) On Thu, 2018-01-18 at 16:49 -0800, Dmitry Torokhov wrote: > We want to free memory reserved for interrupt mask handling only after we > free functions, as function drivers might want to mask interrupts. This