On 12/10/2013 06:17 AM, Samuel Ortiz wrote:
Hi Francis,
Adding Lee to the Cc list.
On Tue, Dec 03, 2013 at 09:14:14AM +0100, Francis Moreau wrote:
Now that you did the hard work, I hope driver's maintainer/developper
will care about this issue.
I applied Thomas' patch to mfd-fixes.
Thanks a
On 12/10/2013 06:17 AM, Samuel Ortiz wrote:
Hi Francis,
Adding Lee to the Cc list.
On Tue, Dec 03, 2013 at 09:14:14AM +0100, Francis Moreau wrote:
Now that you did the hard work, I hope driver's maintainer/developper
will care about this issue.
I applied Thomas' patch to mfd-fixes.
Thanks a
于 2013年09月10日 19:08, Lee Jones 写道:
I'm not asking for in-depth analysis, just an overview.
What's wrong with the default config?
Why is the signal quality bad and what makes it bad?
What did the old magic numbers do?
How will the configuration differ if I applied your patch?
It is a little
于 2013年09月10日 17:28, Lee Jones 写道:
I would like some more information in the commit log though. You're
making a lot of configuration changes here and due to the
incomprehensible 'magic numbers' used previously, it's impossible to
know what you're changing by just reading the code.
Why won't the
于 2013年09月10日 17:09, wei_w...@realsil.com.cn 写道:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
Hi all:
Sorry, forget to modify the subject prefix. Please
于 2013年09月10日 17:09, wei_w...@realsil.com.cn 写道:
From: Wei WANG wei_w...@realsil.com.cn
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Hi all:
Sorry, forget to modify the subject
于 2013年09月10日 17:28, Lee Jones 写道:
I would like some more information in the commit log though. You're
making a lot of configuration changes here and due to the
incomprehensible 'magic numbers' used previously, it's impossible to
know what you're changing by just reading the code.
Why won't the
于 2013年09月10日 19:08, Lee Jones 写道:
I'm not asking for in-depth analysis, just an overview.
What's wrong with the default config?
Why is the signal quality bad and what makes it bad?
What did the old magic numbers do?
How will the configuration differ if I applied your patch?
It is a little
于 2013年09月09日 21:02, Lee Jones 写道:
#define PHY_FLD4 0x1E
>+#define FLDEN_SEL 0x4000
>+#define REQ_REF 0x2000
>+#define RXAMP_OFF 0x1000
>+#define REQ_ADDA 0x0800
>+#define BER_COUNT
于 2013年09月09日 21:02, Lee Jones 写道:
#define PHY_FLD4 0x1E
+#define FLDEN_SEL 0x4000
+#define REQ_REF 0x2000
+#define RXAMP_OFF 0x1000
+#define REQ_ADDA 0x0800
+#define BER_COUNT 0x00E0
于 2013年09月05日 18:48, Dan Carpenter 写道:
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
于 2013年09月05日 18:48, Dan Carpenter 写道:
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the
于 2013年04月19日 06:50, Samuel Ortiz 写道:
Hi Wei,
On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG
Support new model: RTS5249
Could you please provide me with a more detailled changelog (What's so
different with this model that the current driver does not
于 2013年04月19日 06:50, Samuel Ortiz 写道:
Hi Wei,
On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
Support new model: RTS5249
Could you please provide me with a more detailled changelog (What's so
different with this model that the
于 2013年03月25日 14:00, Dan Carpenter 写道:
On Mon, Mar 25, 2013 at 10:13:56AM +0800, wei_w...@realsil.com.cn wrote:
+static int rts5249_optimize_phy(struct rtsx_pcr *pcr)
+{
+ int err;
+
+ err = rtsx_pci_write_phy_register(pcr, 0x19, 0xFE46);
+ if (err < 0)
+ return
于 2013年03月25日 14:00, Dan Carpenter 写道:
On Mon, Mar 25, 2013 at 10:13:56AM +0800, wei_w...@realsil.com.cn wrote:
+static int rts5249_optimize_phy(struct rtsx_pcr *pcr)
+{
+ int err;
+
+ err = rtsx_pci_write_phy_register(pcr, 0x19, 0xFE46);
+ if (err 0)
+ return
Hi Richard:
Could you please describe the detailed model of your 4G card? It would
be better if you can take a picture of that card or give me the Amazon
link of it. It looks like a compatibility issue.
BR,
Wei
于 2013年03月16日 20:54, Richard Cochran 写道:
I have an Acer Aspire One netbook with
Hi Richard:
Could you please describe the detailed model of your 4G card? It would
be better if you can take a picture of that card or give me the Amazon
link of it. It looks like a compatibility issue.
BR,
Wei
于 2013年03月16日 20:54, Richard Cochran 写道:
I have an Acer Aspire One netbook with
于 2013年01月23日 09:23, pclinux 写道:
> 于 2013年01月23日 06:42, Samuel Ortiz 写道:
>> On Tue, Jan 22, 2013 at 11:39:09AM +0800, wwang wrote:
>>>>>> Wei WANG (8):
>>>>>> MFD:rtsx: Fix typo in comment
>>>>>> MFD:rtsx: Remove redundant
于 2013年01月23日 09:23, pclinux 写道:
于 2013年01月23日 06:42, Samuel Ortiz 写道:
On Tue, Jan 22, 2013 at 11:39:09AM +0800, wwang wrote:
Wei WANG (8):
MFD:rtsx: Fix typo in comment
MFD:rtsx: Remove redundant code
MFD:rtsx: Declare that the DMA address limitation is 32bit explicitly
MFD:rtsx
于 2013年01月22日 11:31, Samuel Ortiz 写道:
Hi Wei,
On Wed, Jan 16, 2013 at 05:02:37PM +0800, wwang wrote:
于 2013年01月08日 17:57, 王炜 写道:
From: Wei WANG
v2:
1. Add commit message for patch 2
2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call
v3:
1. Add commit message for patch 3
2
于 2013年01月22日 11:31, Samuel Ortiz 写道:
Hi Wei,
On Wed, Jan 16, 2013 at 05:02:37PM +0800, wwang wrote:
于 2013年01月08日 17:57, 王炜 写道:
From: Wei WANG wei_w...@realsil.com.cn
v2:
1. Add commit message for patch 2
2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call
v3:
1. Add commit
于 2013年01月08日 17:57, 王炜 写道:
> From: Wei WANG
>
> v2:
> 1. Add commit message for patch 2
> 2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call
>
> v3:
> 1. Add commit message for patch 3
> 2. Add patch 8: Use macro defines to replace some variables
>
> v4:
> 1. Describe why patch 3
于 2013年01月08日 17:57, 王炜 写道:
From: Wei WANG wei_w...@realsil.com.cn
v2:
1. Add commit message for patch 2
2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call
v3:
1. Add commit message for patch 3
2. Add patch 8: Use macro defines to replace some variables
v4:
1. Describe
于 2013年01月03日 20:25, Dan Carpenter 写道:
> On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_w...@realsil.com.cn wrote:
>> From: Wei WANG
>>
>> Realtek PCIe card reader only supports 32bit DMA
>>
> Is this a bugfix? If so what does the bug look like?
>
> regards,
> dan carpenter
>
Hi Dan:
No, this is
于 2013年01月03日 20:25, Dan Carpenter 写道:
On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
Realtek PCIe card reader only supports 32bit DMA
Is this a bugfix? If so what does the bug look like?
regards,
dan carpenter
Hi Dan:
于 2012年11月20日 10:21, Chris Ball 写道:
Hi,
Sorry to be pedantic, but:
On Mon, Nov 19 2012, wei_w...@realsil.com.cn wrote:
For Realtek card reader, internal regsiter SD_CFG2 should be configured
before transferring data. In the prior version, the value of this register
has been calculated, but
于 2012年11月20日 10:21, Chris Ball 写道:
Hi,
Sorry to be pedantic, but:
On Mon, Nov 19 2012, wei_w...@realsil.com.cn wrote:
For Realtek card reader, internal regsiter SD_CFG2 should be configured
before transferring data. In the prior version, the value of this register
has been calculated, but
于 11/08/2012 03:41 AM, Chris Ball 写道:
Hi,
On Mon, Oct 29 2012, wwang wrote:
I'm happy with the MMC portion. I think we're mainly waiting for the
MFD patch -- Samuel, do you have any remaining review comments that need
to be fixed?
Thanks,
- Chris.
Hi Chris:
I have noticed that the file
于 11/08/2012 03:41 AM, Chris Ball 写道:
Hi,
On Mon, Oct 29 2012, wwang wrote:
I'm happy with the MMC portion. I think we're mainly waiting for the
MFD patch -- Samuel, do you have any remaining review comments that need
to be fixed?
Thanks,
- Chris.
Hi Chris:
I have noticed that the file
于 2012年11月08日 12:01, Alex Dubov 写道:
Hi,
Do you have any comment on the MEMSTICK part in this v7 patchset? Can
you help to merge the patch to the kernel tree?
I'm afraid that presently I don't have much time to look at the memstick
related stuff any further. Hopefully, somebody else can step
于 2012年11月08日 03:41, Chris Ball 写道:
On Mon, Oct 29 2012, wwang wrote:
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can
于 2012年11月08日 03:41, Chris Ball 写道:
On Mon, Oct 29 2012, wwang wrote:
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can
于 2012年11月08日 12:01, Alex Dubov 写道:
Hi,
Do you have any comment on the MEMSTICK part in this v7 patchset? Can
you help to merge the patch to the kernel tree?
I'm afraid that presently I don't have much time to look at the memstick
related stuff any further. Hopefully, somebody else can step
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can not be accessed easily.
BR,
Wei WANG
--
To unsubscribe from this list:
Hi Chris, Samuel and Alex:
Can you help to review this patchset, please?
I have asked Greg to remove rts_pstor from the staging tree. So this
driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card
reader can not be accessed easily.
BR,
Wei WANG
--
To unsubscribe from this list:
于 2012年10月26日 10:45, Greg KH 写道:
On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote:
于 2012年10月26日 02:50, Greg KH 写道:
On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
We are still maintaining the SCSI driver for Realtek
于 2012年10月26日 02:50, Greg KH 写道:
> On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
>> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
>>> We are still maintaining the SCSI driver for Realtek card reader,
>>> and will release the latest source code
于 2012年10月26日 02:50, Greg KH 写道:
On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
We are still maintaining the SCSI driver for Realtek card reader,
and will release the latest source code in the Github in the future
于 2012年10月26日 10:45, Greg KH 写道:
On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote:
于 2012年10月26日 02:50, Greg KH 写道:
On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote:
On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote:
We are still maintaining the SCSI driver for Realtek
于 2012年10月01日 06:49, Samuel Ortiz 写道:
> Hi Wei,
>
> On Tue, Sep 11, 2012 at 12:54:22PM +0800, wei_w...@realsil.com.cn wrote:
> Although pretty big, the patch looks mostly good to me.
> I only have a few comments:
>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index
于 2012年09月29日 23:29, Borislav Petkov 写道:
On Sat, Sep 29, 2012 at 09:41:17AM -0400, Chris Ball wrote:
On Sat, Sep 29 2012, Borislav Petkov wrote:
So, I think that this driver has seen a bunch of testing and reviewing
and we might start considering upstreaming it. There are a bunch of
laptops
于 2012年09月29日 23:29, Borislav Petkov 写道:
On Sat, Sep 29, 2012 at 09:41:17AM -0400, Chris Ball wrote:
On Sat, Sep 29 2012, Borislav Petkov wrote:
So, I think that this driver has seen a bunch of testing and reviewing
and we might start considering upstreaming it. There are a bunch of
laptops
于 2012年10月01日 06:49, Samuel Ortiz 写道:
Hi Wei,
On Tue, Sep 11, 2012 at 12:54:22PM +0800, wei_w...@realsil.com.cn wrote:
Although pretty big, the patch looks mostly good to me.
I only have a few comments:
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index d1facef..4c07a34 100644
=refs/tags/v3.6-rc5
BR,
wwang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
BR,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
于 2012年08月24日 17:36, 王炜 写道:
> From: Wei WANG
>
> Support for Realtek PCI-Express driver-based card readers including rts5209
> and rts5229.
>
>
Oh, bad mail thread. I will resend them all. Please ignore these mails.
Sorry for that.
--
To unsubscribe from this list: send the line "unsubscribe
于 2012年08月24日 17:36, 王炜 写道:
From: Wei WANG wei_w...@realsil.com.cn
Support for Realtek PCI-Express driver-based card readers including rts5209
and rts5229.
Oh, bad mail thread. I will resend them all. Please ignore these mails.
Sorry for that.
--
To unsubscribe from this list: send the
th of the patches according to your suggestion.
Thank you so much!
BR,
wwang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-by' or 'Reviewed-by' tag from someone,
please add that below your Signed-off-by.
Your patches both look fine now, so you can add my
Reviewed-by: Arnd Bergmann a...@arndb.de
Arnd
Hi Arnd:
OK. I will resend both of the patches according to your suggestion.
Thank you so much!
BR,
wwang
于 2012年08月13日 14:40, Dan Carpenter 写道:
> Looks like bitwise OR was intended here.
Hi Dan:
Thank you. I will resend the patches.
BR,
wwang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
于 2012年08月13日 14:40, Dan Carpenter 写道:
Looks like bitwise OR was intended here.
Hi Dan:
Thank you. I will resend the patches.
BR,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
\ \/ /
\_ \ /___/
\rtsx-slot-bus/
And I plan to push sdmmc-pci and sdmmc-usb to drivers/mmc/host, push
memstick-pci and memstick-usb to drivers/memstick/host, and push
pci-common,
, push
memstick-pci and memstick-usb to drivers/memstick/host, and push
pci-common, usb-common and rtsx-slot-bus to drivers/mfd/realtek_cr.
I would like to receive your suggestions. Thank you.
Best regards,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
\
>> +} while (0)
>> +
>> +#define wait_timeout(msecs) wait_timeout_x(TASK_INTERRUPTIBLE, (msecs))
> This is the same as msleep_interruptible, right? Note that with interuptible
> sleep, you should always check if you got interrupted and return -ERESTARTSYS
> to user space.
Thank you for your explanation. It seems that I should call msleep
instead of msleep_interruptible.
Best regards,
wwang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
should always check if you got interrupted and return -ERESTARTSYS
to user space.
Thank you for your explanation. It seems that I should call msleep
instead of msleep_interruptible.
Best regards,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Hi Dan:
Sorry to bother you.
I can't find the maintainer of drivers/misc. So if I want to submit my
driver as misc device, who should I contact to send my patch?
Thank you very much. I really appreciate this help.
BR,
wwang
--
To unsubscribe from this list: send the line "unsubscribe
Hi Aaron:
Thank you. I will modify our host per your suggestion.
BR,
wwang
于 2012年07月25日 18:16, Aaron Lu 写道:
Hi Wei,
We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would
sugget you do something like this:
static void realtek_init(struct realtek_sdmmc *host)
{
struct
Hi Aaron:
Thank you. I will modify our host per your suggestion.
BR,
wwang
于 2012年07月25日 18:16, Aaron Lu 写道:
Hi Wei,
We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would
sugget you do something like this:
static void realtek_init(struct realtek_sdmmc *host)
{
struct
Hi Dan:
Sorry to bother you.
I can't find the maintainer of drivers/misc. So if I want to submit my
driver as misc device, who should I contact to send my patch?
Thank you very much. I really appreciate this help.
BR,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux
kernel config?
BR,
wwang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
kernel config?
BR,
wwang
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Borislav:
Realtek card reader supports not only SDMMC card, but also Memory stick.
This part is the common code, so it is located in drivers/misc. There is
also SDMMC-relevant code under CONFIG_MMC. And in the future,
Memstick-relevant code will be added under CONFIG_MEMSTICK.
BR,
wwang
Hi Borislav:
Realtek card reader supports not only SDMMC card, but also Memory stick.
This part is the common code, so it is located in drivers/misc. There is
also SDMMC-relevant code under CONFIG_MMC. And in the future,
Memstick-relevant code will be added under CONFIG_MEMSTICK.
BR,
wwang
Hi Rusty:
Thank you.
I will fix it and resend all of the three patches
BR,
wwang
于 2012年07月20日 13:58, Rusty Russell 写道:
> On Thu, 19 Jul 2012 17:55:10 +0800, wrote:
>> From: Wei WANG
>>
>> Realtek PCI-E card reader driver adapts requests from upper-level
>> sdmmc
Hi Rusty:
Thank you.
I will fix it and resend all of the three patches
BR,
wwang
于 2012年07月20日 13:58, Rusty Russell 写道:
On Thu, 19 Jul 2012 17:55:10 +0800, wei_w...@realsil.com.cn wrote:
From: Wei WANG wei_w...@realsil.com.cn
Realtek PCI-E card reader driver adapts requests from upper
Hi Oliver:
I will fix it. Should I resend all three patches, or just this one?
BR,
Wei WANG
于 2012年07月19日 20:26, Oliver Neukum 写道:
> On Thursday 19 July 2012 17:55:18 wei_w...@realsil.com.cn wrote:
>
>> +static void sd_normal_rw(struct realtek_sdmmc *host, struct mmc_request
>> *mrq)
>> +{
>>
Hi Oliver:
I will fix it. Should I resend all three patches, or just this one?
BR,
Wei WANG
于 2012年07月19日 20:26, Oliver Neukum 写道:
On Thursday 19 July 2012 17:55:18 wei_w...@realsil.com.cn wrote:
+static void sd_normal_rw(struct realtek_sdmmc *host, struct mmc_request
*mrq)
+{
+
68 matches
Mail list logo
